omniauth-islykill 0.9.8 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 56fced1e74fbd3dfc280e4bcf348fe2d9d618108
-  data.tar.gz: 5b4c83f5ba4f4d904254024305263cf5643f6368
+  metadata.gz: 9d587f84b5b19548cb5757f12fc01c4ae0ad2f80
+  data.tar.gz: a89db600e9632875c20348e7d68bf756e6c63a3b
 SHA512:
-  metadata.gz: 0aba1334e79e01ee4446173e95029afc09f0cfe55ae40b1fec260edf069d2c75ccf4dd305c8ada165bec73681aa1d1ae0eeea9d4ff84fc8940a2a64864f801aa
-  data.tar.gz: fdfc5a2a975b9d89e0ed82c9fc1dc74c35ef1ad3d211d67dfd716319625afac14ca5fbba8530b2be0a0beb47903577d75ff962b0681d90d46b894e8aaed20f9e
+  metadata.gz: 369ee13fc7c14a4ec5e977636e0adaa65ea4e1660befaa2aac474e77e306fb18b3d67bb02ff027f906bfdc61288737d717e7cbdb74dd58695e482f5125fbbbea
+  data.tar.gz: e30326325f52c6061c38a4d15a4408602cf24f6c0a7b951431a8743064fbeb1b9956b79e04c1cb33ae3cb282ab4bfe08b18e94515b9e20de7ab26d2f23ae244f

data/README.md

@@ -74,7 +74,7 @@ The service provider metadata used to ease configuration of the SAML SP in the I
   If not specified, the IdP is free to choose the name identifier format used
   in the response. Optional.
 
-* See the `Onelogin::Saml::Settings` class in the [Ruby SAML gem](https://github.com/onelogin/ruby-saml) for additional supported options.
+* See the `OneLogin::Saml::Settings` class in the [Ruby SAML gem](https://github.com/onelogin/ruby-saml) for additional supported options.
 
 ## Authors
 

data/lib/omniauth-islykill/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module ISLYKILL
-    VERSION = '0.9.8'
+    VERSION = '1.0.0'
   end
 end

data/lib/omniauth/strategies/islykill.rb

@@ -4,7 +4,7 @@ require 'ruby-saml'
 module OmniAuth
   module Strategies
     class Islykill
-      include OmniAuth::Strategy
+      include OmniAuth::Strategy      
 
       option :name_identifier_format, nil
       option :idp_sso_target_url_runtime_params, {}
@@ -18,12 +18,35 @@ module OmniAuth
           additional_params[mapped_param_key] = request.params[request_param_key.to_s] if request.params.has_key?(request_param_key.to_s)
         end if runtime_request_parameters
 
-        authn_request = Onelogin::Saml::Authrequest.new
-        settings = Onelogin::Saml::Settings.new(options)
+        authn_request = OneLogin::RubySaml::Authrequest.new
+        settings = OneLogin::RubySaml::Settings.new(options)
 
         redirect(authn_request.create(settings, additional_params))
       end
 
+      def read_attributes token_base64
+          islykill_xml_saml_response = Base64.decode64(token_base64)
+          signedDocument = SignedXml::Document(islykill_xml_saml_response)
+          if !signedDocument.is_verified?
+              raise OmniAuth::Strategies::Islykill::ValidationError.new("Islykill response not valid")
+          end
+
+          # response is valid so we extract the information using xpath
+          xml_doc = REXML::Document.new(islykill_xml_saml_response)
+          prefix='Response/Assertion/AttributeStatement/Attribute[@Name="'
+          postfix='"]/AttributeValue'
+
+          @attributes={
+              name: REXML::XPath.first(xml_doc,"#{prefix}Name#{postfix}").text,
+              kennitala: REXML::XPath.first(xml_doc,"#{prefix}UserSSN#{postfix}").text,
+              provider: REXML::XPath.first(xml_doc,"#{prefix}Authentication#{postfix}").text
+          }
+          
+          @name_id = REXML::XPath.first(xml_doc,"Response/Assertion/Subject/NameID/@NameQualifier").value()
+
+      end   
+
+
       def callback_phase
         puts "   ___      _ _ _                _    "
         puts "  / __ __ _| | | |__   __ _  ___| | __"
@@ -36,51 +59,19 @@ module OmniAuth
           raise OmniAuth::Strategies::Islykill::ValidationError.new("Islykill response missing")
         end
 
-        token_base64 = request.params['token']
-        islykill_xml_saml_response = Base64.decode64(token_base64)
-        signedDocument = SignedXml::Document(islykill_xml_saml_response)
-        if !signedDocument.is_verified?
-            raise OmniAuth::Strategies::Islykill::ValidationError.new("Islykill response not valid")
-        end
-
-        # response is valid so we extract the information using xpath
-        xml_doc = REXML::Document.new(islykill_xml_saml_response)
-        prefix='Response/Assertion/AttributeStatement/Attribute[@Name="'
-        postfix='"]/AttributeValue'
+        read_attributes request.params['token']
 
-        @attributes={
-            name: REXML::XPath.first(xml_doc,"#{prefix}Name#{postfix}").text,
-            kennitala: REXML::XPath.first(xml_doc,"#{prefix}UserSSN#{postfix}").text,
-            provider: REXML::XPath.first(xml_doc,"#{prefix}Authentication#{postfix}").text
-        }
-        
-        @name_id = REXML::XPath.first(xml_doc,"Response/Assertion/Subject/NameID/@NameQualifier").value()
-
-        if @name_id.nil? || @name_id.empty?
+       if @name_id.nil? || @name_id.empty?
           raise OmniAuth::Strategies::Islykill::ValidationError.new("SAML response missing 'name_id'")
         end
 
         super
       rescue 
         fail!(:invalid_ticket, $!)
-      rescue Onelogin::Saml::ValidationError
+      rescue OneLogin::RubySaml::ValidationError
         fail!(:invalid_ticket, $!)
       end
 
-    #  def other_phase
-    #    if on_path?("#{request_path}/metadata")
-    #      # omniauth does not set the strategy on the other_phase
-    #      @env['omniauth.strategy'] ||= self
-    #      setup_phase
-
-    #      response = Onelogin::Saml::Metadata.new
-    #      settings = Onelogin::Saml::Settings.new(options)
-    #      Rack::Response.new(response.generate(settings), 200, { "Content-Type" => "application/xml" }).finish
-    #    else
-    #      call_app!
-    #    end
-    #  end
-
       uid { 
         #@name_id 
         @attributes[:kennitala]

data/lib/signed_xml/digest_method_resolution.rb

@@ -5,6 +5,7 @@ module SignedXml
     include OpenSSL
 
     def new_digester_for_id(id)
+
       id = id && id =~ /sha(.*?)$/i && $1.to_i
       case id
       when 256 then OpenSSL::Digest::SHA256.new

data/lib/signed_xml/document.rb

@@ -12,7 +12,7 @@ module SignedXml
         @doc = thing
       else
         @doc = Nokogiri::XML(thing)
-      end
+      end      
     end
 
     def is_verifiable?
@@ -20,7 +20,7 @@ module SignedXml
     end
 
     def is_verified?(arg = nil)
-      unless is_verifiable?
+      unless is_verifiable?        
         logger.warn "document cannot be verified because it contains no <Signature> elements"
         return false
       end

data/lib/signed_xml/signature.rb

@@ -28,9 +28,9 @@ module SignedXml
 
     def is_signed_info_verified?
       return false if public_key.nil?
-
       result = public_key.verify(new_digester_for_id(signed_info.signature_method), decoded_value, signed_info.apply_transforms)
       logger.info "verification of signature value [#{value}] failed" unless result
+      puts result
       result
     end
 

metadata

@@ -1,71 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-islykill
 version: !ruby/object:Gem::Version
-  version: 0.9.8
+  version: 1.0.0
 platform: ruby
 authors:
 - Bjorgvin Thordarson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-07 00:00:00.000000000 Z
+date: 2015-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
   name: ruby-saml
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: options
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.3'
 description: This is a specific SAML strategy that handles authentication to Icelands
   Íslykill for OmniAuth.
 email: algrim.is@outlook.com
@@ -73,26 +73,26 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- README.md
 - CHANGELOG.md
+- README.md
+- lib/omniauth-islykill.rb
+- lib/omniauth-islykill/version.rb
+- lib/omniauth/strategies/islykill.rb
+- lib/omniauth/strategies/islykill/validation_error.rb
 - lib/signed_xml.rb
+- lib/signed_xml/base64_transform.rb
 - lib/signed_xml/c14n_transform.rb
-- lib/signed_xml/signed_info.rb
+- lib/signed_xml/digest_method_resolution.rb
 - lib/signed_xml/digest_transform.rb
 - lib/signed_xml/document.rb
 - lib/signed_xml/enveloped_signature_transform.rb
-- lib/signed_xml/reference.rb
-- lib/signed_xml/base64_transform.rb
-- lib/signed_xml/version.rb
-- lib/signed_xml/digest_method_resolution.rb
-- lib/signed_xml/logging.rb
 - lib/signed_xml/fingerprinting.rb
-- lib/signed_xml/transformable.rb
+- lib/signed_xml/logging.rb
+- lib/signed_xml/reference.rb
 - lib/signed_xml/signature.rb
-- lib/omniauth-islykill.rb
-- lib/omniauth-islykill/version.rb
-- lib/omniauth/strategies/islykill/validation_error.rb
-- lib/omniauth/strategies/islykill.rb
+- lib/signed_xml/signed_info.rb
+- lib/signed_xml/transformable.rb
+- lib/signed_xml/version.rb
 homepage: https://github.com/Algrim/omniauth-islykill
 licenses:
 - ''
@@ -103,19 +103,18 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.9
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: This is a specific SAML strategy that handles authentication to Icelands
-  Íslykill for OmniAuth.
+summary: SAML strategy to handle Icelands Íslykill for OmniAuth.
 test_files: []