omniauth-identity 3.0.2 → 3.0.7

data/spec/support/shared_contexts/instance_with_instance_methods.rb

@@ -0,0 +1,89 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'instance with instance methods' do
+  describe '#initialize' do
+    it 'does not raise an error' do
+      block_is_expected.not_to raise_error
+    end
+  end
+
+  describe '#uid' do
+    it 'defaults to #id' do
+      allow(instance).to receive(:respond_to?).with(:id).and_return(true)
+      allow(instance).to receive(:id).and_return 'wakka-do'
+      expect(instance.uid).to eq('wakka-do')
+    end
+
+    it 'stringifies it' do
+      allow(instance).to receive(:id).and_return 123
+      expect(instance.uid).to eq('123')
+    end
+
+    it 'raises NotImplementedError if #id is not defined' do
+      allow(instance).to receive(:respond_to?).with(:id).and_return(false)
+      expect { instance.uid }.to raise_error(NotImplementedError)
+    end
+  end
+
+  describe '#auth_key' do
+    it 'defaults to #email' do
+      allow(instance).to receive(:respond_to?).with(:email).and_return(true)
+      allow(instance).to receive(:email).and_return('bob@bob.com')
+      expect(instance.auth_key).to eq('bob@bob.com')
+    end
+
+    it 'uses the class .auth_key' do
+      instance.class.auth_key 'login'
+      allow(instance).to receive(:login).and_return 'bob'
+      expect(instance.auth_key).to eq('bob')
+      instance.class.auth_key nil
+    end
+  end
+
+  describe '#auth_key=' do
+    it 'defaults to setting email' do
+      allow(instance).to receive(:respond_to?).with(:email=).and_return(true)
+      expect(instance).to receive(:email=).with 'abc'
+
+      instance.auth_key = 'abc'
+    end
+
+    it 'uses a custom .auth_key if one is provided' do
+      instance.class.auth_key 'login'
+      allow(instance).to receive(:respond_to?).with(:login=).and_return(true)
+      expect(instance).to receive(:login=).with('abc')
+
+      instance.auth_key = 'abc'
+    end
+  end
+
+  describe '#info' do
+    it 'includes all attributes as they have been set' do
+      allow(instance).to receive(:name).and_return('Bob Bobson')
+      allow(instance).to receive(:nickname).and_return('bob')
+
+      expect(instance.info).to include({
+                                         'name' => 'Bob Bobson',
+                                         'nickname' => 'bob'
+                                       })
+    end
+
+    it 'uses firstname and lastname, over nickname, to set missing name' do
+      allow(instance).to receive(:first_name).and_return('shoeless')
+      allow(instance).to receive(:last_name).and_return('joe')
+      allow(instance).to receive(:nickname).and_return('george')
+      instance.info['name'] == 'shoeless joe'
+    end
+
+    it 'uses nickname to set missing name when first and last are not set' do
+      allow(instance).to receive(:nickname).and_return('bob')
+      instance.info['name'] == 'bob'
+    end
+
+    it 'does not overwrite a provided name' do
+      allow(instance).to receive(:name).and_return('Awesome Dude')
+      allow(instance).to receive(:first_name).and_return('Frank')
+      expect(instance.info['name']).to eq('Awesome Dude')
+    end
+  end
+end

data/spec/support/shared_contexts/model_with_class_methods.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'model with class methods' do
+  describe 'class definition' do
+    it 'does not raise an error' do
+      block_is_expected.not_to raise_error
+    end
+  end
+
+  describe '::authenticate' do
+    it 'calls locate and then authenticate' do
+      mocked_instance = double('ExampleModel', authenticate: 'abbadoo')
+      allow(model_klass).to receive(:locate).with('email' => 'example').and_return(mocked_instance)
+      expect(model_klass.authenticate({ 'email' => 'example' }, 'pass')).to eq('abbadoo')
+    end
+
+    it 'calls locate with additional scopes when provided' do
+      mocked_instance = double('ExampleModel', authenticate: 'abbadoo')
+      allow(model_klass).to receive(:locate).with('email' => 'example',
+                                                  'user_type' => 'admin').and_return(mocked_instance)
+      expect(model_klass.authenticate({ 'email' => 'example', 'user_type' => 'admin' }, 'pass')).to eq('abbadoo')
+    end
+
+    it 'recovers gracefully if locate is nil' do
+      allow(model_klass).to receive(:locate).and_return(nil)
+      expect(model_klass.authenticate('blah', 'foo')).to be false
+    end
+  end
+end

data/spec/support/shared_contexts/persistable_model.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+RSpec.shared_context 'persistable model' do
+  include_context 'model with class methods'
+
+  describe 'instance methods' do
+    subject(:instance) { model_klass.new }
+
+    include_context 'instance with instance methods'
+
+    describe '#save' do
+      subject(:save) do
+        instance.email = DEFAULT_EMAIL
+        instance.password = DEFAULT_PASSWORD
+        instance.password_confirmation = DEFAULT_PASSWORD
+        instance.save
+      end
+
+      it 'does not raise an error' do
+        save
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-identity
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.7
 platform: ruby
 authors:
 - Peter Boling
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-14 00:00:00.000000000 Z
+date: 2021-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bcrypt
@@ -41,75 +41,61 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: anonymous_active_record
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.0.7
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.0.7
-- !ruby/object:Gem::Dependency
-  name: mongoid
+  name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '1'
 - !ruby/object:Gem::Dependency
-  name: rack-test
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '13'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13'
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rspec-block_is_expected
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -124,7 +110,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
-description: Internal authentication handlers for OmniAuth.
+description: Traditional username/password based authentication system for OmniAuth
 email:
 executables: []
 extensions: []
@@ -141,15 +127,19 @@ files:
 - lib/omniauth/identity/models/active_record.rb
 - lib/omniauth/identity/models/couch_potato.rb
 - lib/omniauth/identity/models/mongoid.rb
+- lib/omniauth/identity/models/nobrainer.rb
+- lib/omniauth/identity/models/sequel.rb
 - lib/omniauth/identity/secure_password.rb
 - lib/omniauth/strategies/identity.rb
 - spec/omniauth/identity/model_spec.rb
 - spec/omniauth/identity/models/active_record_spec.rb
-- spec/omniauth/identity/models/couch_potato_spec.rb
-- spec/omniauth/identity/models/mongoid_spec.rb
+- spec/omniauth/identity/models/sequel_spec.rb
 - spec/omniauth/identity/secure_password_spec.rb
 - spec/omniauth/strategies/identity_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_contexts/instance_with_instance_methods.rb
+- spec/support/shared_contexts/model_with_class_methods.rb
+- spec/support/shared_contexts/persistable_model.rb
 homepage: http://github.com/omniauth/omniauth-identity
 licenses:
 - MIT
@@ -170,15 +160,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.9
 signing_key:
 specification_version: 4
-summary: Internal authentication handlers for OmniAuth.
+summary: Traditional username/password based authentication system for OmniAuth
 test_files:
-- spec/omniauth/identity/model_spec.rb
+- spec/spec_helper.rb
+- spec/support/shared_contexts/persistable_model.rb
+- spec/support/shared_contexts/model_with_class_methods.rb
+- spec/support/shared_contexts/instance_with_instance_methods.rb
 - spec/omniauth/identity/models/active_record_spec.rb
-- spec/omniauth/identity/models/couch_potato_spec.rb
-- spec/omniauth/identity/models/mongoid_spec.rb
+- spec/omniauth/identity/models/sequel_spec.rb
 - spec/omniauth/identity/secure_password_spec.rb
+- spec/omniauth/identity/model_spec.rb
 - spec/omniauth/strategies/identity_spec.rb
-- spec/spec_helper.rb

data/spec/omniauth/identity/models/couch_potato_spec.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe(OmniAuth::Identity::Models::CouchPotatoModule, db: true) do
-  class CouchPotatoTestIdentity
-    include CouchPotato::Persistence
-    include OmniAuth::Identity::Models::CouchPotatoModule
-    auth_key :ham_sandwich
-  end
-
-  describe 'model', type: :model do
-    subject { CouchPotatoTestIdentity }
-
-    it 'delegates locate to the where query method' do
-      allow(subject).to receive(:where).with('ham_sandwich' => 'open faced',
-                                             'category' => 'sandwiches').and_return(['wakka'])
-      expect(subject.locate('ham_sandwich' => 'open faced', 'category' => 'sandwiches')).to eq('wakka')
-    end
-  end
-end

data/spec/omniauth/identity/models/mongoid_spec.rb

@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe(OmniAuth::Identity::Models::Mongoid, db: true) do
-  class MongoidTestIdentity
-    include Mongoid::Document
-    include OmniAuth::Identity::Models::Mongoid
-    auth_key :ham_sandwich
-    store_in database: 'db1', collection: 'mongoid_test_identities', client: 'secondary'
-  end
-
-  describe 'model', type: :model do
-    subject { MongoidTestIdentity }
-
-    it { is_expected.to be_mongoid_document }
-
-    it 'does not munge collection name' do
-      expect(subject).to be_stored_in(database: 'db1', collection: 'mongoid_test_identities', client: 'secondary')
-    end
-
-    it 'delegates locate to the where query method' do
-      allow(subject).to receive(:where).with('ham_sandwich' => 'open faced',
-                                             'category' => 'sandwiches').and_return(['wakka'])
-      expect(subject.locate('ham_sandwich' => 'open faced', 'category' => 'sandwiches')).to eq('wakka')
-    end
-  end
-end