omniauth-idcat_mobil 0.2.4 → 0.3.0

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## next version:
 
+## Version 0.3.0 (MINOR)
+- CI: Intoduce continous integration via GitHub Actions.
+- CI: Apply `rubocop` recommendations.
+
 ## Version 0.2.4 (PATCH)
 - FIX: do not delete the session state before checking it.
 - DOC: Change CHANGELOG format, prefix with change type.

data/Gemfile

@@ -1,12 +1,19 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in omniauth-idcat_mobil.gemspec
 gemspec
 
+group :development, :test do
+  gem "rubocop"
+  gem "rubocop-rspec"
+end
+
 group :test do
   gem "rack", ">= 2.1.4"
   gem "rack-test"
   gem "rspec", "~> 3.0"
-end
+end

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rake/testtask"
 
@@ -7,4 +9,4 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList["test/**/*_test.rb"]
 end
 
-task :default => :test
+task default: :test

data/lib/omniauth/idcat_mobil/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Omniauth
   module IdCatMobil
-    VERSION = "0.2.4"
+    VERSION = "0.3.0"
   end
 end

data/lib/omniauth/idcat_mobil.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "omniauth/idcat_mobil/version"
 require "omniauth/strategies/idcat_mobil"
 

data/lib/omniauth/strategies/idcat_mobil.rb

@@ -18,7 +18,7 @@ module OmniAuth
       option :name, :idcat_mobil
       option :auth_token_params, {
         mode: :query, # put the param in the query of the requested url
-        param_name: 'AccessToken'
+        param_name: "AccessToken"
       }
 
       option :user_info_path, "/serveis-rest/getUserInfo"
@@ -38,7 +38,7 @@ module OmniAuth
           surname1: raw_info["surname1"],
           surname2: raw_info["surname2"],
           surnames: raw_info["surnames"],
-          country_code: raw_info["countryCode"],
+          country_code: raw_info["countryCode"]
         }
       end
 
@@ -59,7 +59,7 @@ module OmniAuth
           scope: :autenticacio_usuari,
           response_type: :code,
           approval_prompt: :auto,
-          access_type: :online,
+          access_type: :online
         }
         options.client_options[:token_url] = URI.join(options.site, "/o/oauth2/token").to_s
         options.client_options[:auth_token_params] = {
@@ -74,7 +74,7 @@ module OmniAuth
       #
       # It is implemented in the OAuth2 superclass, and does the follwing:
       # redirect client.auth_code.authorize_url({:redirect_uri => callback_url}.merge(options.authorize_params))
-      # 
+      #
       # We're overriding solely to log.
       def request_phase
         idcat_log("In `request_phase`, with params: redirect_uri=>#{callback_url}, options=>#{options.authorize_params}")
@@ -99,7 +99,7 @@ module OmniAuth
         else
           idcat_log("Performing getUserInfo...")
           response= access_token.get(options.user_info_path)
-          result= %i(status headers body).collect  {|m| response.send(m)}
+          result= [:status, :headers, :body].collect { |m| response.send(m) }
           idcat_log("getUserInfo response status/headers/body: #{result}")
           @raw_info= response.parsed
           # Logout to avoid problems with IdCat mòbil's cookie session when trying to login again.
@@ -117,6 +117,7 @@ module OmniAuth
 
       # --------------------------------------------------
       private
+
       # --------------------------------------------------
 
       def idcat_log(msg)
@@ -124,8 +125,8 @@ module OmniAuth
       end
 
       def idcat_logger
-        @idcat_logger||= defined?(Rails.logger) ? Rails.logger : Logger.new(STDOUT, progname: 'idcat_mobil')
+        @idcat_logger||= defined?(Rails.logger) ? Rails.logger : Logger.new($stdout, progname: "idcat_mobil")
       end
     end
   end
-end
+end

data/omniauth-idcat_mobil.gemspec

@@ -1,30 +1,32 @@
+# frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "omniauth/idcat_mobil/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "omniauth-idcat_mobil"
-  spec.version       = Omniauth::IdCatMobil::VERSION
-  spec.authors       = ["Oliver Valls"]
-  spec.email         = ["oliver.vh@coditramuntana.com"]
+  spec.name = "omniauth-idcat_mobil"
+  spec.version = Omniauth::IdCatMobil::VERSION
+  spec.authors = ["Oliver Valls"]
+  spec.email = ["oliver.vh@coditramuntana.com"]
 
-  spec.summary       = %q{User registration and login through IdCat mòbil.}
-  spec.description   = %q{Authentication method that uses OAuth 2.0 protocol.}
-  spec.homepage      = "https://github.com/gencat/omniauth-idcat_mobil"
-  spec.license       = "MIT"
+  spec.summary = "User registration and login through IdCat mòbil."
+  spec.description = "Authentication method that uses OAuth 2.0 protocol."
+  spec.homepage = "https://github.com/gencat/omniauth-idcat_mobil"
+  spec.license = "MIT"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.bindir = "exe"
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_dependency "omniauth", "~> 1.5"
   spec.add_dependency "omniauth-oauth2", ">= 1.4.0", "< 2.0"
   spec.add_development_dependency "bundler", "~> 2.2", ">= 2.2.10"
   spec.add_development_dependency "rake", "~> 12.3", ">= 12.3.3"
+  spec.metadata["rubygems_mfa_required"] = "true"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-idcat_mobil
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.3.0
 platform: ruby
 authors:
 - Oliver Valls
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-01-31 00:00:00.000000000 Z
+date: 2022-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
@@ -91,7 +91,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/pull_request_template.md"
+- ".github/workflows/linters.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
+- ".rubocop.yml"
 - ".ruby-version"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -111,7 +116,8 @@ files:
 homepage: https://github.com/gencat/omniauth-idcat_mobil
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths: