omniauth-github 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7360551f98f08e0dc6b099cb8244f1c228be89b9
-  data.tar.gz: aeee13d4e028e0f6d55ecc2b395bbe13d129055f
+SHA256:
+  metadata.gz: 1f88c8d62903eb54ee19e957aea594380734acdf20943ea24817919659d1caa1
+  data.tar.gz: 2343a7c819ef367eebda314e3d3dfab4b0801f2c0165d72249b3a2ed0a5e5c4a
 SHA512:
-  metadata.gz: d0dc0f3cf76e07f851edfd9689302dadc618e98a12b03420f62aa836fef5ce14a7c458bf2d0d30d6c7c66ce332ad65ac610ff636532f7821611844f2db67235f
-  data.tar.gz: fca276a62cb23009a282ecbeb9e8b18e50a9b5048a71665742203514d55de636c6220b4aa8af8aabc76a14d3fe3c7be0dd172208d15829cc7741ba17fa52e2ee
+  metadata.gz: 3081908b47df5e1dbe4c1241910643d61949f9a2692cb1c9436d04a44e122d0096f01560a8666bf8c0d56e937c93a78e98be9eafb0270e0f6addb835dc99ccd0
+  data.tar.gz: 2162fbeb8c660834bd9cd09053ed77fa48f32f8b705a8d30d3128165c1144116731f22bdb8859ed07f2d1a520c6308e287ee76f02378876bde63450a85402863

data/.github/workflows/ruby.yml

@@ -0,0 +1,22 @@
+name: Ruby
+
+on: [push]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.4', '2.5', '2.6']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby ${{ matrix.ruby-version }}
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+    - name: Build and test with Rake
+      run: |
+        gem install bundler
+        bundle install --jobs 4 --retry 3
+        bundle exec rake

data/README.md

@@ -1,9 +1,17 @@
+![Ruby](https://github.com/omniauth/omniauth-github/workflows/Ruby/badge.svg?branch=master)
+
 # OmniAuth GitHub
 
 This is the official OmniAuth strategy for authenticating to GitHub. To
 use it, you'll need to sign up for an OAuth2 Application ID and Secret
 on the [GitHub Applications Page](https://github.com/settings/applications).
 
+## Installation
+
+```ruby
+gem 'omniauth-github', github: 'omniauth/omniauth-github', branch: 'master'
+```
+
 ## Basic Usage
 
 ```ruby

data/lib/omniauth-github/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module GitHub
-    VERSION = "1.3.0"
+    VERSION = "1.4.0"
   end
 end

data/lib/omniauth/strategies/github.rb

@@ -39,11 +39,11 @@ module OmniAuth
       end
 
       extra do
-        {:raw_info => raw_info, :all_emails => emails}
+        {:raw_info => raw_info, :all_emails => emails, :scope => scope }
       end
 
       def raw_info
-        access_token.options[:mode] = :query
+        access_token.options[:mode] = :header
         @raw_info ||= access_token.get('user').parsed
       end
 
@@ -51,6 +51,10 @@ module OmniAuth
         (email_access_allowed?) ? primary_email : raw_info['email']
       end
 
+      def scope
+        access_token['scope']
+      end
+
       def primary_email
         primary = emails.find{ |i| i['primary'] && i['verified'] }
         primary && primary['email'] || nil
@@ -59,7 +63,7 @@ module OmniAuth
       # The new /user/emails API - http://developer.github.com/v3/users/emails/#future-response
       def emails
         return [] unless email_access_allowed?
-        access_token.options[:mode] = :query
+        access_token.options[:mode] = :header
         @emails ||= access_token.get('user/emails', :headers => { 'Accept' => 'application/vnd.github.v3' }).parsed
       end
 

data/spec/omniauth/strategies/github_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe OmniAuth::Strategies::GitHub do
-  let(:access_token) { instance_double('AccessToken', :options => {}) }
+  let(:access_token) { instance_double('AccessToken', :options => {}, :[] => 'user') }
   let(:parsed_response) { instance_double('ParsedResponse') }
   let(:response) { instance_double('Response', :parsed => parsed_response) }
 
@@ -122,6 +122,12 @@ describe OmniAuth::Strategies::GitHub do
       expect(access_token).to receive(:get).with('user').and_return(response)
       expect(subject.raw_info).to eq(parsed_response)
     end
+
+    it 'should use the header auth mode' do
+      expect(access_token).to receive(:get).with('user').and_return(response)
+      subject.raw_info
+      expect(access_token.options[:mode]).to eq(:header)
+    end
   end
 
   context '#emails' do
@@ -133,6 +139,16 @@ describe OmniAuth::Strategies::GitHub do
       subject.options['scope'] = 'user'
       expect(subject.emails).to eq(parsed_response)
     end
+
+    it 'should use the header auth mode' do
+      expect(access_token).to receive(:get).with('user/emails', :headers => {
+        'Accept' => 'application/vnd.github.v3'
+      }).and_return(response)
+
+      subject.options['scope'] = 'user'
+      subject.emails
+      expect(access_token.options[:mode]).to eq(:header)
+    end
   end
 
   context '#info.email' do
@@ -150,6 +166,12 @@ describe OmniAuth::Strategies::GitHub do
     end
   end
 
+  context '#extra.scope' do
+    it 'returns the scope on the returned access_token' do
+      expect(subject.scope).to eq('user')
+    end
+  end
+
   describe '#callback_url' do
     it 'is a combination of host, script name, and callback path' do
       allow(subject).to receive(:full_host).and_return('https://example.com')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-github
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Michael Bleigh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-23 00:00:00.000000000 Z
+date: 2020-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
@@ -107,6 +107,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
 - Gemfile
@@ -139,8 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Official OmniAuth strategy for GitHub.