omniauth-applicaster 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f0ac378a39c598eb3656c8065628155e0b61bfde
-  data.tar.gz: 765f8acd6f8fac276beb05d58c91c218e64dc1d1
+  metadata.gz: 6945c3ae7d17b5590097a6a467a13234a2705355
+  data.tar.gz: 208431d82e39cc7d9de00343062b119a4a7f2b88
 SHA512:
-  metadata.gz: 0486f7b9d14805c576d94ed13bc0bf84b26714123316360fc8bfb6473bfc2257b0ebb9f86169b486b38294f698c0cdc180e413004dba5fef5f3b73538ba562c4
-  data.tar.gz: 5d932c806d173728e1a389700b55e21253bb4566d65f99194933ea10da974890bd0e9c0605b402f54731de59f05c567bb7941aff3cef26ff59b12ce83ecfe7a8
+  metadata.gz: 091d23f2dfdc715f35a7b5febf18a604c07dd2852b9c8ab94de2af4815745ceb7f90dc48e84402e273b54e9395b752bf707d228e245d9d3764d4f22044384788
+  data.tar.gz: c9286e01668134507bc8d3fafdceaf7ca8eb27013ee75d3349f47bc271188ebdcc61eb04c654c47fc09d935bce96fb9df782185682ebe11e36280ebf289b3cfd

data/lib/applicaster/accounts.rb

@@ -103,6 +103,8 @@ module Applicaster
 
     def find_user_by_id(id)
       self.class.user_by_id_and_token(id, client_credentials_token.token)
+    rescue Faraday::ResourceNotFound
+      nil
     end
 
     def connection(*args)

data/lib/omniauth-applicaster/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module Applicaster
-    VERSION = "1.6.0"
+    VERSION = "1.6.1"
   end
 end

data/spec/lib/applicaster/accounts_spec.rb

@@ -191,16 +191,36 @@ RSpec.describe Applicaster::Accounts do
   end
 
   describe "#find_user_by_id" do
-    let(:user_id) { 11 }
-
     before do
       stub_client_credentials_request
-      stub_user_show_request(user_id, "client-credentials-token")
     end
 
-    it "returns User object" do
-      expect(accounts_service.find_user_by_id(user_id))
-        .to be_kind_of(Applicaster::Accounts::User)
+    context "when accounts service returns 200" do
+      let(:user_id) { 11 }
+
+      before do
+        stub_user_show_request(user_id, "client-credentials-token")
+      end
+
+      it "returns User object" do
+        expect(accounts_service.find_user_by_id(user_id))
+          .to be_kind_of(Applicaster::Accounts::User)
+      end
+    end
+
+    context "when accounts service returns 404" do
+      let(:user_id) { "wrong-id" }
+
+      before do
+        stub_request(:get, "https://#{accounts_host}/api/v1/users/#{user_id}.json").
+           with(query: { access_token: "client-credentials-token" }).
+           to_return(status: 404, body: "")
+      end
+
+      it "doesn't raise" do
+        expect{ accounts_service.find_user_by_id(user_id) }
+          .to_not raise_error
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-applicaster
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Neer Friedman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-28 00:00:00.000000000 Z
+date: 2016-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler