omniauth-angellist 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a7fcf72d337a95f545086adb06cbfa76da04769a
-  data.tar.gz: 93e9c47c0b32cf70b8919e2165047309bbd99ff2
+  metadata.gz: c6459eaa408922092e18ed8f0be13e74dc73af28
+  data.tar.gz: 55e84be3cb787d439c29b7e4ff21f86a799b73cb
 SHA512:
-  metadata.gz: 5350bee46f7b08f55208773c97262aa5b9a80de9661919e807881cdccd52619b0a9eaef31ad40a2b2b93dea991ad2e2e2b6cbd43cfcad2bd2b6634b1c8b2712c
-  data.tar.gz: f149fee4067aa28c82a9c688bd3b8915d9ecd7398456dbfcf6d2303176e537baf366aa05177c882aed4067724ed03786717f0b4d6acddc8fc4a7dafc23efe186
+  metadata.gz: 2c86983f8dcfce830ded4c7eadeb782a7fd0d1e946514ce3937dc5c30a7b29b69c34dbe35f3a92ea8ceb857d1ca4ea12457f19da095bef36e91f5eb78c67045d
+  data.tar.gz: f6984caac274ae5aa80839fd92d78934ae1873c97f2315a3606208a2119b494375da00ebe958f749b7a644e50dac12ed67e6b75cf91388401cdeb0c15235da21

data/lib/omniauth-angellist/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module AngelList
-    VERSION = '1.0.0'
+    VERSION = '1.0.1'.freeze
   end
 end

data/lib/omniauth/strategies/angellist.rb

@@ -3,7 +3,7 @@ require 'omniauth/strategies/oauth2'
 module OmniAuth
   module Strategies
     class AngelList < OmniAuth::Strategies::OAuth2
-      DEFAULT_SCOPE = 'email'
+      DEFAULT_SCOPE = 'email'.freeze
 
       option :client_options, {
         site: 'https://angel.co/',
@@ -44,13 +44,12 @@ module OmniAuth
 
       credentials do
         hash = { 'token' => access_token.token }
-        hash.merge!('refresh_token' => access_token.refresh_token) if
+        hash['refresh_token'] = access_token.refresh_token if
           access_token.expires? && access_token.refresh_token
-        hash.merge!('expires_at' => access_token.expires_at) if
+        hash['expires_at'] = access_token.expires_at if
           access_token.expires?
-        hash.merge!('expires' => access_token.expires?)
-        hash.merge!(
-          'scope' => raw_info['scopes'] ? raw_info['scopes'].join(' ') : nil)
+        hash['expires'] = access_token.expires?
+        hash['scope'] = raw_info['scopes'] ? raw_info['scopes'].join(' ') : nil
         prune!(hash)
       end
 

data/omniauth-angellist.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |s|
   s.email       = ['srabuini@gmail.com']
   s.homepage    = 'https://github.com/wasabit/omniauth-angellist'
   s.summary     = 'AngelList OAuth strategy for OmniAuth'
-  s.description = 'AngelList OAuth strategy for OmniAuth'
+  s.description = 'AngelList OAuth strategy for OmniAuth.'
   s.license     = 'MIT'
 
   s.rubyforge_project = 'omniauth-angellist'
@@ -19,8 +19,5 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
 
   s.add_runtime_dependency 'omniauth-oauth2', '~> 1.1'
-  s.add_development_dependency 'rspec', '~> 2.7'
-  s.add_development_dependency 'rack-test'
-  s.add_development_dependency 'simplecov'
-  s.add_development_dependency 'webmock'
+  s.add_development_dependency 'rspec', '~> 3.5'
 end

data/spec/omniauth/strategies/angellist_spec.rb

@@ -4,7 +4,7 @@ require 'omniauth-angellist'
 describe OmniAuth::Strategies::AngelList do
   before :each do
     @request = double('Request')
-    @request.stub(:params) { {} }
+    allow(@request).to receive(:params).and_return({})
     @client_id = '123'
     @client_secret = 'afalsf'
     @raw_info = {
@@ -45,7 +45,7 @@ describe OmniAuth::Strategies::AngelList do
   subject do
     args = [@client_id, @client_secret, @options].compact
     OmniAuth::Strategies::AngelList.new(nil, *args).tap do |strategy|
-      strategy.stub(:request) { @request }
+      allow(strategy).to receive(:request).and_return(@request)
     end
   end
 
@@ -53,108 +53,108 @@ describe OmniAuth::Strategies::AngelList do
 
   describe '#client' do
     it 'has correct AngelList site' do
-      subject.client.site.should eq('https://angel.co/')
+      expect(subject.client.site).to eq('https://angel.co/')
     end
 
     it 'has correct authorize url' do
-      subject.client.options[:authorize_url].should eq('https://angel.co/api/oauth/authorize')
+      expect(subject.client.options[:authorize_url]).to eq('https://angel.co/api/oauth/authorize')
     end
 
     it 'has correct token url' do
-      subject.client.options[:token_url].should eq('https://angel.co/api/oauth/token')
+      expect(subject.client.options[:token_url]).to eq('https://angel.co/api/oauth/token')
     end
   end
 
   describe '#info' do
     before :each do
-      subject.stub(:raw_info) { @raw_info }
+      allow(subject).to receive(:raw_info).and_return(@raw_info)
     end
 
     context 'when data is present in raw info' do
       it 'returns the combined name' do
-        subject.info['name'].should eq('Sebastian Rabuini')
+        expect(subject.info['name']).to eq('Sebastian Rabuini')
       end
 
       it 'returns the bio' do
-        subject.info['bio'].should eq('Sebas')
+        expect(subject.info['bio']).to eq('Sebas')
       end
 
       it 'returns the image' do
-        subject.info['image'].should eq(@raw_info['image'])
+        expect(subject.info['image']).to eq(@raw_info['image'])
       end
 
       it 'return the email' do
-        subject.info['email'].should eq('sebas@wasabit.com.ar')
+        expect(subject.info['email']).to eq('sebas@wasabit.com.ar')
       end
 
       it 'return skills' do
-        subject.info['skills'].first['name'].should eq('ruby on rails')
+        expect(subject.info['skills'].first['name']).to eq('ruby on rails')
       end
     end
   end
 
   describe '#authorize_params' do
     before :each do
-      subject.stub(session: {})
+      allow(subject).to receive(:session).and_return({})
     end
 
     it 'includes default scope for email' do
-      subject.authorize_params['scope'].should eq('email')
+      expect(subject.authorize_params['scope']).to eq('email')
     end
   end
 
   describe '#credentials' do
     before :each do
       @access_token = double('OAuth2::AccessToken')
-      @access_token.stub(:token) { '123' } # Token is always required
-      @access_token.stub(:expires?)
-      @access_token.stub(:expires_at)
-      @access_token.stub(:refresh_token)
-      subject.stub(:access_token) { @access_token }
-      subject.stub(:raw_info) { @raw_info }
+      allow(@access_token).to receive(:token).and_return('123')
+      allow(@access_token).to receive(:expires?)
+      allow(@access_token).to receive(:expires_at)
+      allow(@access_token).to receive(:refresh_token)
+      allow(subject).to receive(:access_token).and_return(@access_token)
+      allow(subject).to receive(:raw_info).and_return(@raw_info)
     end
 
     it 'returns a Hash' do
-      subject.credentials.should be_a(Hash)
+      expect(subject.credentials).to be_a(Hash)
     end
 
     it 'returns the token' do
-      subject.credentials['token'].should eq('123')
+      expect(subject.credentials['token']).to eq('123')
     end
 
     it 'return scopes' do
-      subject.credentials['scope'].should eq('email comment message talent')
+      expect(subject.credentials['scope']).to eq('email comment message talent')
     end
 
     it 'returns the expiry status' do
-      @access_token.stub(:expires?) { true }
-      subject.credentials['expires'].should eq(true)
+      allow(@access_token).to receive(:expires?) { true }
+      expect(subject.credentials['expires']).to eq(true)
 
-      @access_token.stub(:expires?) { false }
-      subject.credentials['expires'].should eq(false)
+      allow(@access_token).to receive(:expires?) { false }
+      expect(subject.credentials['expires']).to eq(false)
     end
 
     it 'returns the refresh token and expiry time when expiring' do
       ten_mins_from_now = (Time.now + 360).to_i
-      @access_token.stub(:expires?) { true }
-      @access_token.stub(:refresh_token) { '321' }
-      @access_token.stub(:expires_at) { ten_mins_from_now }
-      subject.credentials['refresh_token'].should eq('321')
-      subject.credentials['expires_at'].should eq(ten_mins_from_now)
+      allow(@access_token).to receive(:expires?) { true }
+      allow(@access_token).to receive(:refresh_token) { '321' }
+      allow(@access_token).to receive(:expires_at) { ten_mins_from_now }
+      expect(subject.credentials['refresh_token']).to eq('321')
+      expect(subject.credentials['expires_at']).to eq(ten_mins_from_now)
     end
 
     it 'does not return the refresh token when it is nil and expiring' do
-      @access_token.stub(:expires?) { true }
-      @access_token.stub(:refresh_token) { nil }
-      subject.credentials['refresh_token'].should be_nil
-      subject.credentials.should_not have_key('refresh_token')
+      allow(@access_token).to receive(:expires?) { true }
+      allow(@access_token).to receive(:refresh_token) { nil }
+      expect(subject.credentials['refresh_token']).to be_nil
+      expect(subject.credentials).to_not have_key('refresh_token')
     end
 
     it 'does not return the refresh token when not expiring' do
-      @access_token.stub(:expires?) { false }
-      @access_token.stub(:refresh_token) { 'XXX' }
-      subject.credentials['refresh_token'].should be_nil
-      subject.credentials.should_not have_key('refresh_token')
+      allow(@access_token).to receive(:expires?) { false }
+      allow(@access_token).to receive(:refresh_token) { 'XXX' }
+      expect(subject.credentials['refresh_token']).to be_nil
+      expect(subject.credentials).to_not have_key('refresh_token')
     end
   end
 end

data/spec/support/shared_examples.rb

@@ -3,21 +3,22 @@ shared_examples 'an oauth2 strategy' do
     it 'should be initialized with symbolized client_options' do
       @options = { client_options:
         { 'authorize_url' => 'https://example.com' } }
-      subject.client.options[:authorize_url].should == 'https://example.com'
+      expect(subject.client.options[:authorize_url])
+        .to eq('https://example.com')
     end
   end
 
   describe '#token_params' do
     it 'should include any params passed in the :authorize_params option' do
       @options = { token_params: { foo: 'bar', baz: 'zip' } }
-      subject.token_params['foo'].should eq('bar')
-      subject.token_params['baz'].should eq('zip')
+      expect(subject.token_params['foo']).to eq('bar')
+      expect(subject.token_params['baz']).to eq('zip')
     end
 
     it 'should include top-level options marked as :authorize_options' do
       @options = { token_options: [:scope, :foo], scope: 'bar', foo: 'baz' }
-      subject.token_params['scope'].should eq('bar')
-      subject.token_params['foo'].should eq('baz')
+      expect(subject.token_params['scope']).to eq('bar')
+      expect(subject.token_params['foo']).to eq('baz')
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-angellist
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Sebastian Rabuini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-25 00:00:00.000000000 Z
+date: 2017-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth2
@@ -30,57 +30,15 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
-- !ruby/object:Gem::Dependency
-  name: rack-test
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-description: AngelList OAuth strategy for OmniAuth
+        version: '3.5'
+description: AngelList OAuth strategy for OmniAuth.
 email:
 - srabuini@gmail.com
 executables: []
@@ -118,7 +76,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: omniauth-angellist
-rubygems_version: 2.4.5
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: AngelList OAuth strategy for OmniAuth