omniauth-aleph 0.1.3 → 1.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: aab1e7e2aa996e8844f614953a5f835de9d082a4
+  data.tar.gz: 0d01f4578451e8be105da928ab5e32df896312dd
+SHA512:
+  metadata.gz: bfb2f4f6d321b772dd89d6e006bf44dcf0fa0cec722208e62c5da92a8a4fd3f4cec11967f77baa03ad3f0dc0acfc0abe8db90b9b91e871a33078182fb726b939
+  data.tar.gz: 0a7af65f9020d13750d93297a8ea1515193f46c0b358a98a646b63d0f4fceabae4f9d3cfc6200b9a7e3b2347a1801174a8af2859cba3e8ec33dc6225270d4ac6

data/.travis.yml

@@ -1,7 +1,5 @@
 language: ruby
 rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.0
-  - jruby-19mode
-  - rbx
+  - 2.3
+  - jruby-9.1.12.0
+sudo: false

data/Gemfile

@@ -1,16 +1,9 @@
 source 'http://rubygems.org'
 gemspec
 
-gem "coveralls", "~> 0.7.0", require: false, group: :test
-gem "pry-debugger", group: :development, platform: :mri
-gem "pry", group: :development, platforms: [:jruby, :rbx]
-
-platforms :rbx do
-  gem 'rubysl', '~> 2.0' # if using anything in the ruby standard library
-  gem 'json', '~> 1.8.1'
-  gem 'rubinius-coverage'
-end
+gem 'coveralls', '~> 0.8.0', require: false, group: :test
+gem 'pry', group: :development
 
 # XML parsing
-gem 'ox', '~> 2.1.0', platform: :ruby
-gem 'nokogiri', '~> 1.6.1', platform: :jruby
+gem 'ox', '~> 2.1', platform: :ruby
+gem 'nokogiri', '~> 1.8', platform: :jruby

data/README.md

@@ -1,9 +1,9 @@
 # OmniAuth Aleph
 [![Gem Version](https://badge.fury.io/rb/omniauth-aleph.png)](http://badge.fury.io/rb/omniauth-aleph)
-[![Build Status](https://api.travis-ci.org/scotdalton/omniauth-aleph.png?branch=master)](https://travis-ci.org/scotdalton/omniauth-aleph)
-[![Dependency Status](https://gemnasium.com/scotdalton/omniauth-aleph.png)](https://gemnasium.com/scotdalton/omniauth-aleph)
-[![Code Climate](https://codeclimate.com/github/scotdalton/omniauth-aleph.png)](https://codeclimate.com/github/scotdalton/omniauth-aleph)
-[![Coverage Status](https://coveralls.io/repos/scotdalton/omniauth-aleph/badge.png?branch=master)](https://coveralls.io/r/scotdalton/omniauth-aleph)
+[![Build Status](https://api.travis-ci.org/NYULibraries/omniauth-aleph.png?branch=master)](https://travis-ci.org/NYULibraries/omniauth-aleph)
+[![Dependency Status](https://gemnasium.com/NYULibraries/omniauth-aleph.png)](https://gemnasium.com/NYULibraries/omniauth-aleph)
+[![Code Climate](https://codeclimate.com/github/NYULibraries/omniauth-aleph.png)](https://codeclimate.com/github/NYULibraries/omniauth-aleph)
+[![Coverage Status](https://coveralls.io/repos/NYULibraries/omniauth-aleph/badge.png?branch=master)](https://coveralls.io/r/NYULibraries/omniauth-aleph)
 
 Aleph patron login strategy for OmniAuth.
 
@@ -20,7 +20,7 @@ returns the attributes from the returned XML.
 
 Use the Aleph strategy as a middleware in your application:
 
-    use OmniAuth::Strategies::Aleph, title: 'My Library's Aleph', 
+    use OmniAuth::Strategies::Aleph, title: 'My Library's Aleph',
       host: 'aleph.library.edu', port: 80, library: 'ADM50', sub_library: 'SUB'
 
 ## Configuring
@@ -170,4 +170,4 @@ Here's an example _Auth Hash_ available in `request.env['omniauth.auth']`:
           }
         }
       }
-    }
+    }

data/lib/omniauth/aleph/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module Aleph
-    VERSION = "0.1.3"
+    VERSION = "1.0.0"
   end
 end

data/omniauth-aleph.gemspec

@@ -4,10 +4,10 @@ require File.expand_path('../lib/omniauth/aleph/version', __FILE__)
 Gem::Specification.new do |gem|
   gem.name     = 'omniauth-aleph'
   gem.version  = OmniAuth::Aleph::VERSION
-  gem.authors  = ['Scot Dalton']
-  gem.email    = ['scotdalton@gmail.com']
+  gem.authors  = ['Scot Dalton','Barnaby Alter']
+  gem.email    = ['scotdalton@gmail.com','barnaby.alter@nyu.edu']
   gem.summary  = 'Aleph Patron Login Strategy for OmniAuth'
-  gem.homepage = 'https://github.com/scotdalton/omniauth-aleph'
+  gem.homepage = 'https://github.com/NYULibraries/omniauth-aleph'
   gem.license  = 'MIT'
 
   gem.files         = `git ls-files`.split("\n")
@@ -15,13 +15,13 @@ Gem::Specification.new do |gem|
   gem.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   gem.require_paths = ['lib']
 
-  gem.add_runtime_dependency 'omniauth', '~> 1.2.0'
-  gem.add_runtime_dependency 'faraday', '~> 0.9.0'
-  gem.add_runtime_dependency 'multi_xml', '~> 0.5.0'
+  gem.add_runtime_dependency 'omniauth', '~> 1.2'
+  gem.add_runtime_dependency 'faraday', '~> 0.9'
+  gem.add_runtime_dependency 'multi_xml', '~> 0.5'
 
-  gem.add_development_dependency 'rake', '~> 10.1.0'
-  gem.add_development_dependency 'rspec', '~> 2.14.0'
-  gem.add_development_dependency 'rack-test', '~> 0.6.2'
-  gem.add_development_dependency 'webmock', '~> 1.17.0'
-  gem.add_development_dependency 'vcr', '~> 2.8.0'
+  gem.add_development_dependency 'rake', '>= 10.1.0', '~> 11'
+  gem.add_development_dependency 'rspec', '>= 2.14.0', '< 4'
+  gem.add_development_dependency 'rack-test', '~> 0.6'
+  gem.add_development_dependency 'webmock', '>= 1.17.0', '< 4'
+  gem.add_development_dependency 'vcr', '>= 2.8.0', '< 4'
 end

data/spec/omniauth/strategies/aleph_spec.rb

@@ -6,8 +6,8 @@ describe "OmniAuth::Strategies::Aleph" do
 
     subject(:strategy) do
       OmniAuth::Strategies::Aleph.new(nil, config).tap do |strategy|
-        strategy.stub(:username) { aleph_username }
-        strategy.stub(:password) { aleph_password }
+        allow(strategy).to receive(:username).and_return(aleph_username)
+        allow(strategy).to receive(:password).and_return(aleph_password)
       end
     end
 
@@ -35,58 +35,60 @@ describe "OmniAuth::Strategies::Aleph" do
       # First argument is the app, which gets called with env,
       # i.e. app.call(env), so fake it with a stabby lambda
       OmniAuth::Strategies::Aleph.new(->(env) {}, config).tap do |strategy|
-        strategy.stub(:username) { aleph_username }
-        strategy.stub(:password) { aleph_password }
-        strategy.stub(:env) { {} }
-        strategy.stub(:fail!) { true }
+        allow(strategy).to receive(:username).and_return(aleph_username)
+        allow(strategy).to receive(:password).and_return(aleph_password)
+        allow(strategy).to receive(:env).and_return({})
+        allow(strategy).to receive(:fail!).and_return(true)
       end
     end
 
     describe '#options' do
       subject(:options) { strategy.options }
 
-      it { should_not raise_error }
+      it 'should not raise an error' do
+        expect { subject }.to_not raise_error
+      end
 
       describe'#name' do
         subject { options.name }
-        it { should_not be_nil }
-        it { should eq("aleph") }
+        it { is_expected.to_not be_nil }
+        it { is_expected.to eq("aleph") }
       end
 
       describe '#title' do
         subject { options.title }
-        it { should_not be_nil }
-        it { should eq("Aleph Authentication") }
+        it { is_expected.to_not be_nil }
+        it { is_expected.to eq("Aleph Authentication") }
       end
 
       describe '#scheme' do
         subject { options.scheme }
-        it { should_not be_nil }
-        it { should eq("http") }
+        it { is_expected.to_not be_nil }
+        it { is_expected.to eq("http") }
       end
 
       describe '#host' do
         subject { options.host }
-        it { should_not be_nil }
-        it { should eq(aleph_host) }
+        it { is_expected.to_not be_nil }
+        it { is_expected.to eq(aleph_host) }
       end
 
       describe '#port' do
         subject { options.port }
-        it { should_not be_nil }
-        it { should be(80) }
+        it { is_expected.to_not be_nil }
+        it { is_expected.to be(80) }
       end
 
       describe '#library' do
         subject { options.library }
-        it { should_not be_nil }
-        it { should eq(aleph_library) }
+        it { is_expected.to_not be_nil }
+        it { is_expected.to eq(aleph_library) }
       end
 
       describe '#sub_library' do
         subject { options.sub_library }
-        it { should_not be_nil }
-        it { should eq(aleph_sub_library) }
+        it { is_expected.to_not be_nil }
+        it { is_expected.to eq(aleph_sub_library) }
       end
     end
 
@@ -99,9 +101,9 @@ describe "OmniAuth::Strategies::Aleph" do
     describe "#callback_phase", vcr: { cassette_name: "valid" } do
       context "when the credentials are missing" do
         before(:each) do |example|
-          strategy.stub(:username) { "" }
-          strategy.stub(:password) { "" }
-        end          
+          allow(strategy).to receive(:username).and_return("")
+          allow(strategy).to receive(:password).and_return("")
+        end
 
         it 'shouldn\'t raise an error' do
           expect{ strategy.callback_phase }.not_to raise_error
@@ -115,14 +117,14 @@ describe "OmniAuth::Strategies::Aleph" do
 
       context "when the credentials are included" do
         before(:each) do
-          strategy.stub(:username) { aleph_username }
-          strategy.stub(:password) { aleph_password }
-        end          
+          allow(strategy).to receive(:username).and_return(aleph_username)
+          allow(strategy).to receive(:password).and_return(aleph_password)
+        end
 
         it 'shouldn\'t raise an error' do
           expect{ strategy.callback_phase }.not_to raise_error
         end
- 
+
         it 'shouldn\'t fail!' do
           strategy.callback_phase
           expect(strategy).not_to have_received(:fail!)
@@ -236,7 +238,7 @@ describe "OmniAuth::Strategies::Aleph" do
           expect(auth_hash.info.name).to eq('USERNAME, TEST-RECORD')
           expect(auth_hash.info.nickname).to eq('USERNAME')
           expect(auth_hash.info.email).to eq('username@library.edu')
-          expect(auth_hash.info.phone).to be_nil
+          expect(auth_hash.info.phone).to be_blank
           expect(auth_hash.extra.raw_info.bor_auth.z303.z303_id).to eq('USERNAME')
         end
       end

data/spec/spec_helper.rb

@@ -53,7 +53,4 @@ RSpec.configure do |config|
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end
-  # so we can use :vcr rather than :vcr => true;
-  # in RSpec 3 this will no longer be necessary.
-  config.treat_symbols_as_metadata_keys_with_true_values = true
 end

metadata

@@ -1,153 +1,162 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-aleph
 version: !ruby/object:Gem::Version
-  version: 0.1.3
-  prerelease: 
+  version: 1.0.0
 platform: ruby
 authors:
 - Scot Dalton
+- Barnaby Alter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-15 00:00:00.000000000 Z
+date: 2017-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: multi_xml
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 10.1.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 10.1.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '11'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.14.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.14.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.17.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.17.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.8.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.8.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
 description: 
 email:
 - scotdalton@gmail.com
+- barnaby.alter@nyu.edu
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -170,36 +179,29 @@ files:
 - spec/vcr_cassettes/nil_password.yml
 - spec/vcr_cassettes/nonexistent_user.yml
 - spec/vcr_cassettes/valid.yml
-homepage: https://github.com/scotdalton/omniauth-aleph
+homepage: https://github.com/NYULibraries/omniauth-aleph
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 563932762752653555
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 563932762752653555
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.5.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Aleph Patron Login Strategy for OmniAuth
 test_files:
 - spec/omniauth/aleph/adaptor_spec.rb