om 3.0.4 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1506c83ba270fd799906372dec5dad78bf22e15b
-  data.tar.gz: 52421f44573d4dd6dbccf317999992739b06a0d8
+  metadata.gz: 1de731732be29cdf0c460beebcb5b603deccb18c
+  data.tar.gz: 6fa913f9d7bcdd57e7d29555a266d265dd426ad0
 SHA512:
-  metadata.gz: b6708395c67ab5aae28ff0f2019320869de2b6c528fbe83c6a62cef25342467eda7e2eca2917a828f4361448f68a16f917184397966eee55e9285154b41d13bc
-  data.tar.gz: 8dc39146fa979e0acbab1915f73217868247629ff7a66c9b7200a85338969b89f8b683361afad740df704afc3896863725eea21da7650db999cc3c9450d16477
+  metadata.gz: e947f9c90119f8ac601105505d947a2ad78d4307ada79f3f7e609fd64ecb71c0330bbe668438e1d4ee71aac4dbcf112a9f5d2a0fe4a841d9a22125b81cd78e9d
+  data.tar.gz: 4db6a2f387c9630f6e9909966bc81e9939110ac92b6588745fb82766ec23d3249041ddbe70b5ddba6322b094622e51cdd09da26365bec6c6af7fcb12cc2a9f5a

data/lib/om.rb

@@ -65,6 +65,8 @@ module OM
   def self.version
     Om::VERSION
   end
+
+  class TypeMismatch < StandardError; end
 end
 
 module OM::XML; end

data/lib/om/version.rb

@@ -1,3 +1,3 @@
 module Om
-  VERSION = "3.0.4"
+  VERSION = "3.0.5"
 end

data/lib/om/xml/dynamic_node.rb

@@ -44,7 +44,7 @@ module OM
         elsif args.length > 1
           new_update_node_with_index(name, args)
         else
-          child =  term_child_by_name(term.nil? ? parent.term : term, name)
+          child = term_child_by_name(term.nil? ? parent.term : term, name)
           if child
             OM::XML::DynamicNode.new(name, args.first, @document, child, self)
           else 
@@ -53,6 +53,10 @@ module OM
         end
       end
 
+      def respond_to?(method)
+        super || val.respond_to?(method)
+      end
+
       def new_update_node(name, args)
         modified_name = name.to_s.chop.to_sym
         child = term.retrieve_term(modified_name)
@@ -97,6 +101,8 @@ module OM
         end
       end
 
+      # This resolves the target of this dynamic node into a reified Array
+      # @return [Array]
       def val 
         query = xpath
         trim_text = !query.index("text()").nil?
@@ -122,6 +128,10 @@ module OM
         other == val
       end
 
+      def !=(other)
+        val != other
+      end
+
       def eql?(other)
         self == other
       end

data/lib/om/xml/term.rb

@@ -4,288 +4,291 @@ require 'om/xml/term_builder'
 # type, index_as, attributes,
 # is_root_term, required
 #
-class OM::XML::Term
+module OM
+  class XML::Term
 
-  include OM::TreeNode
-  include OM::XML::TermBuilder
+    include TreeNode
+    include XML::TermBuilder
 
-  attr_accessor :name, :xpath, :xpath_constrained, :xpath_relative, :path, :index_as, :required, :type, :variant_of, :path, :default_content_path, :is_root_term
-  attr_accessor :children, :internal_xml, :terminology
+    attr_accessor :name, :xpath, :xpath_constrained, :xpath_relative, :path, :index_as, :required, :type, :variant_of, :path, :default_content_path, :is_root_term
+    attr_accessor :children, :internal_xml, :terminology
 
-  # Any XML attributes that qualify the Term.
-  #
-  # @example Declare a Term that has a given attribute (ie. //title[@xml:lang='eng'])
-  #   t.english_title(:path=>"title", :attributes=>{"xml:lang"=>"eng"}
-  # @example Use nil to point to nodes that do not have a given attribute (ie. //title[not(@xml:lang)])
-  #   t.title_without_lang_attribute(:path=>"title", :attributes=>{"xml:lang"=>nil})
-  attr_accessor :attributes
+    # Any XML attributes that qualify the Term.
+    #
+    # @example Declare a Term that has a given attribute (ie. //title[@xml:lang='eng'])
+    #   t.english_title(:path=>"title", :attributes=>{"xml:lang"=>"eng"}
+    # @example Use nil to point to nodes that do not have a given attribute (ie. //title[not(@xml:lang)])
+    #   t.title_without_lang_attribute(:path=>"title", :attributes=>{"xml:lang"=>nil})
+    attr_accessor :attributes
 
-  # Namespace Prefix (xmlns) for the Term.
-  #
-  # By default, OM assumes that all terms in a Terminology have the namespace set in the root of the document.  If you want to set a different namespace for a Term, pass :namespace_prefix into its initializer (or call .namespace_prefix= on its builder)
-  # If a node has _no_ namespace, you must explicitly set namespace_prefix to nil.  Currently you have to do this on _each_ term, you can't set namespace_prefix to nil for an entire Terminology.
-  #
-  # @example
-  #   # For xml like this
-  #   <foo xmlns="http://foo.com/schemas/fooschema" xmlns:bar="http://bar.com/schemas/barschema">
-  #     <address>1400 Pennsylvania Avenue</address>
-  #     <bar:latitude>56</bar:latitude>
-  #   </foo>
-  #
-  #   # The Terminology would look like this
-  #   OM::XML::Terminology::Builder.new do |t|
-  #     t.root(:name=>:foo, :path=>"foo", :xmlns=>"http://foo.com/schemas/fooschema", "xmlns:bar"=>"http://bar.com/schemas/barschema")
-  #     t.address
-  #     t.latitude(:namespace_prefix=>"bar")
-  #   end
-  #
-  attr_accessor :namespace_prefix
+    # Namespace Prefix (xmlns) for the Term.
+    #
+    # By default, OM assumes that all terms in a Terminology have the namespace set in the root of the document.  If you want to set a different namespace for a Term, pass :namespace_prefix into its initializer (or call .namespace_prefix= on its builder)
+    # If a node has _no_ namespace, you must explicitly set namespace_prefix to nil.  Currently you have to do this on _each_ term, you can't set namespace_prefix to nil for an entire Terminology.
+    #
+    # @example
+    #   # For xml like this
+    #   <foo xmlns="http://foo.com/schemas/fooschema" xmlns:bar="http://bar.com/schemas/barschema">
+    #     <address>1400 Pennsylvania Avenue</address>
+    #     <bar:latitude>56</bar:latitude>
+    #   </foo>
+    #
+    #   # The Terminology would look like this
+    #   OM::XML::Terminology::Builder.new do |t|
+    #     t.root(:name=>:foo, :path=>"foo", :xmlns=>"http://foo.com/schemas/fooschema", "xmlns:bar"=>"http://bar.com/schemas/barschema")
+    #     t.address
+    #     t.latitude(:namespace_prefix=>"bar")
+    #   end
+    #
+    attr_accessor :namespace_prefix
 
 
-  # h2. Namespaces
-  # By default, OM assumes you have no namespace defined unless it is explicitly defined at the root of your document.
-  #
-  # @param [Symbol] name the name to refer to this term by
-  # @param [Hash] opts
-  # @option opts [Array]  :index_as a list of indexing hints provided to to_solr
-  # @option opts [String] :path partial xpath that points to the node.  
-  # @option opts [Hash]   :attributes xml attributes to match in the selector 
-  # @option opts [String] :namespace_prefix xml namespace for this node. If not provided, the default namespace set in the terminology will be used. 
-  # @option opts [Symbol] :type one of :string, :date, :time :integer. Defaults to :string
-  def initialize(name, opts={}, terminology=nil)
-    opts = {:ancestors=>[], :children=>{}}.merge(opts)
-    [:children, :ancestors,:path, :index_as, :required, :variant_of, :path, :attributes, :default_content_path, :namespace_prefix].each do |accessor_name|
-      instance_variable_set("@#{accessor_name}", opts.fetch(accessor_name, nil) )
-    end
+    # h2. Namespaces
+    # By default, OM assumes you have no namespace defined unless it is explicitly defined at the root of your document.
+    #
+    # @param [Symbol] name the name to refer to this term by
+    # @param [Hash] opts
+    # @option opts [Array]  :index_as a list of indexing hints provided to to_solr
+    # @option opts [String] :path partial xpath that points to the node.
+    # @option opts [Hash]   :attributes xml attributes to match in the selector
+    # @option opts [String] :namespace_prefix xml namespace for this node. If not provided, the default namespace set in the terminology will be used. 
+    # @option opts [Symbol] :type one of :string, :date, :time :integer. Defaults to :string
+    def initialize(name, opts={}, terminology=nil)
+      opts = {:ancestors=>[], :children=>{}}.merge(opts)
+      [:children, :ancestors,:path, :index_as, :required, :variant_of, :path, :attributes, :default_content_path, :namespace_prefix].each do |accessor_name|
+        instance_variable_set("@#{accessor_name}", opts.fetch(accessor_name, nil) )
+      end
 
-    self.type = opts[:type] || :string
+      self.type = opts[:type] || :string
 
-    unless terminology.nil?
-      if opts[:namespace_prefix].nil?
-        unless terminology.namespaces["xmlns"].nil?
-          @namespace_prefix = "oxns"
+      unless terminology.nil?
+        if opts[:namespace_prefix].nil?
+          unless terminology.namespaces["xmlns"].nil?
+            @namespace_prefix = "oxns"
+          end
         end
       end
+      @name = name
+      if @path.nil? || @path.empty?
+        @path = name.to_s
+      end
     end
-    @name = name
-    if @path.nil? || @path.empty?
-      @path = name.to_s
-    end
-  end
 
 
-  def sanitize_new_values(new_values)
-      # Sanitize new_values to always be a hash with indexes
-      case new_values
-      when Hash
-        sanitize_new_values(new_values.values)
-      when Array
-        new_values.map {|v| serialize(v)}
+    def sanitize_new_values(new_values)
+        # Sanitize new_values to always be a hash with indexes
+        case new_values
+        when Hash
+          sanitize_new_values(new_values.values)
+        when Array
+          new_values.map {|v| serialize(v)}
+        else
+          [serialize(new_values)]
+        end
+    end
+
+    # @param val [String,Date,Integer]
+    def serialize (val)
+      return if val.nil?
+      case type
+      when :date, :integer
+        val.to_s
+      when :time
+        time = val.to_time
+        raise TypeMismatch, "Can't convert `#{val}` to time" if time.nil?
+        time.utc.iso8601
+      when :boolean
+        val.to_s
       else
-        [serialize(new_values)]
+        val
       end
-  end
-  
-  # @param val [String,Date,Integer]
-  def serialize (val)
-    return if val.nil?
-    case type
-    when :date, :integer
-      val.to_s
-    when :time
-      val.to_time.utc.iso8601 
-    when :boolean
-      val.to_s
-    else 
-      val
     end
-  end
 
-  # @param [String] val the value (from xml) to deserialize into the correct object type.
-  # @return [String,Date,Integer]
-  def deserialize(val)
-    case type
-    when :date
-      #TODO use present?
-      val.map { |v| !v.empty? ? Date.parse(v) : nil}
-    when :time
-      #TODO use present?
-      val.map { |v| !v.empty? ? DateTime.parse(v) : nil}
-    when :integer
-      #TODO use blank?
-      val.map { |v| v.empty? ? nil : v.to_i}
-    when :boolean
-      val.map { |v| v == 'true' }
-    else 
-      val
+    # @param [String] val the value (from xml) to deserialize into the correct object type.
+    # @return [String,Date,Integer]
+    def deserialize(val)
+      case type
+      when :date
+        #TODO use present?
+        val.map { |v| !v.empty? ? Date.parse(v) : nil}
+      when :time
+        #TODO use present?
+        val.map { |v| !v.empty? ? DateTime.parse(v) : nil}
+      when :integer
+        #TODO use blank?
+        val.map { |v| v.empty? ? nil : v.to_i}
+      when :boolean
+        val.map { |v| v == 'true' }
+      else 
+        val
+      end
     end
-  end
 
-  def self.from_node(mapper_xml)
-    name = mapper_xml.attribute("name").text.to_sym
-    attributes = {}
-    mapper_xml.xpath("./attribute").each do |a|
-      attributes[a.attribute("name").text.to_sym] = a.attribute("value").text
-    end
-    new_mapper = self.new(name, :attributes=>attributes)
-    [:index_as, :required, :type, :variant_of, :path, :default_content_path, :namespace_prefix].each do |accessor_name|
-      attribute =  mapper_xml.attribute(accessor_name.to_s)
-      unless attribute.nil?
-        new_mapper.instance_variable_set("@#{accessor_name}", attribute.text )
+    def self.from_node(mapper_xml)
+      name = mapper_xml.attribute("name").text.to_sym
+      attributes = {}
+      mapper_xml.xpath("./attribute").each do |a|
+        attributes[a.attribute("name").text.to_sym] = a.attribute("value").text
       end
-    end
-    new_mapper.internal_xml = mapper_xml
+      new_mapper = self.new(name, :attributes=>attributes)
+      [:index_as, :required, :type, :variant_of, :path, :default_content_path, :namespace_prefix].each do |accessor_name|
+        attribute =  mapper_xml.attribute(accessor_name.to_s)
+        unless attribute.nil?
+          new_mapper.instance_variable_set("@#{accessor_name}", attribute.text )
+        end
+      end
+      new_mapper.internal_xml = mapper_xml
 
-    mapper_xml.xpath("./mapper").each do |child_node|
-      child = self.from_node(child_node)
-      new_mapper.add_child(child)
-    end
+      mapper_xml.xpath("./mapper").each do |child_node|
+        child = self.from_node(child_node)
+        new_mapper.add_child(child)
+      end
 
-    return new_mapper
-  end
+      return new_mapper
+    end
 
-  ##
-  # Always co-erce :index_as attributes into an Array
-  def index_as
-    Array(@index_as)
-  end
+    ##
+    # Always co-erce :index_as attributes into an Array
+    def index_as
+      Array(@index_as)
+    end
 
-  # crawl down into mapper's children hash to find the desired mapper
-  # ie. @test_mapper.retrieve_mapper(:conference, :role, :text)
-  def retrieve_term(*pointers)
-    children_hash = self.children
-    pointers.each do |p|
-      if children_hash.has_key?(p)
-        target = children_hash[p]
-        if pointers.index(p) == pointers.length-1
-          return target
+    # crawl down into mapper's children hash to find the desired mapper
+    # ie. @test_mapper.retrieve_mapper(:conference, :role, :text)
+    def retrieve_term(*pointers)
+      children_hash = self.children
+      pointers.each do |p|
+        if children_hash.has_key?(p)
+          target = children_hash[p]
+          if pointers.index(p) == pointers.length-1
+            return target
+          else
+            children_hash = target.children
+          end
         else
-          children_hash = target.children
+          return nil
         end
-      else
-        return nil
       end
+      return target
     end
-    return target
-  end
 
-  def is_root_term?
-    @is_root_term == true
-  end
+    def is_root_term?
+      @is_root_term == true
+    end
 
-  def xpath_absolute
-    @xpath
-  end
+    def xpath_absolute
+      @xpath
+    end
 
-  # +term_pointers+ reference to the property you want to generate a builder template for
-  # @param [Hash] extra_opts
-  # @option extra_opts [Hash] :attributes 
-  def xml_builder_template(extra_opts = {})
-    extra_attributes = extra_opts.fetch(:attributes, {})
+    # +term_pointers+ reference to the property you want to generate a builder template for
+    # @param [Hash] extra_opts
+    # @option extra_opts [Hash] :attributes
+    def xml_builder_template(extra_opts = {})
+      extra_attributes = extra_opts.fetch(:attributes, {})
 
-    node_options = []
-    node_child_template = ""
-    if !self.default_content_path.nil?
-      node_child_options = ["\':::builder_new_value:::\'"]
-      node_child_template = " { xml.#{self.default_content_path}( #{OM::XML.delimited_list(node_child_options)} ) }"
-    else
-      node_options = ["\':::builder_new_value:::\'"]
-    end
-    if !self.attributes.nil?
-      self.attributes.merge(extra_attributes).each_pair do |k,v|
-        node_options << "\'#{k}\'=>\'#{v}\'" unless v == :none
+      node_options = []
+      node_child_template = ""
+      if !self.default_content_path.nil?
+        node_child_options = ["\':::builder_new_value:::\'"]
+        node_child_template = " { xml.#{self.default_content_path}( #{OM::XML.delimited_list(node_child_options)} ) }"
+      else
+        node_options = ["\':::builder_new_value:::\'"]
+      end
+      if !self.attributes.nil?
+        self.attributes.merge(extra_attributes).each_pair do |k,v|
+          node_options << "\'#{k}\'=>\'#{v}\'" unless v == :none
+        end
       end
-    end
 
-    builder_ref = if self.path.include?(":")
-      "xml['#{self.path[0..path.index(":")-1]}']"
-    elsif !self.namespace_prefix.nil? and self.namespace_prefix != 'oxns'
-      "xml['#{self.namespace_prefix}']"
-    else
-      "xml"
-    end
+      builder_ref = if self.path.include?(":")
+        "xml['#{self.path[0..path.index(":")-1]}']"
+      elsif !self.namespace_prefix.nil? and self.namespace_prefix != 'oxns'
+        "xml['#{self.namespace_prefix}']"
+      else
+        "xml"
+      end
 
-    attribute = OM::XML.delimited_list(node_options)
+      attribute = OM::XML.delimited_list(node_options)
 
-    builder_method = if self.path.include?(":")
-      "#{self.path[path.index(":")+1..-1]}( #{attribute} )"
-    elsif self.path.include?(".")
-      "send(:\\\"#{self.path}\\\",  #{attribute} )"
-    elsif self.path.kind_of?(Hash) && self.path[:attribute]
-      "@#{self.path[:attribute]}( #{OM::XML.delimited_list(node_options)} )"
-    elsif Nokogiri::XML::Builder.method_defined? self.path.to_sym
-      "#{self.path}_( #{OM::XML.delimited_list(node_options)} )"
-    else
-      "#{self.path}( #{OM::XML.delimited_list(node_options)} )"
+      builder_method = if self.path.include?(":")
+        "#{self.path[path.index(":")+1..-1]}( #{attribute} )"
+      elsif self.path.include?(".")
+        "send(:\\\"#{self.path}\\\",  #{attribute} )"
+      elsif self.path.kind_of?(Hash) && self.path[:attribute]
+        "@#{self.path[:attribute]}( #{OM::XML.delimited_list(node_options)} )"
+      elsif Nokogiri::XML::Builder.method_defined? self.path.to_sym
+        "#{self.path}_( #{OM::XML.delimited_list(node_options)} )"
+      else
+        "#{self.path}( #{OM::XML.delimited_list(node_options)} )"
+      end
+      template = "#{builder_ref}.#{builder_method}#{node_child_template}"
+      return template.gsub( /:::(.*?):::/ ) { '#{'+$1+'}' }
     end
-    template = "#{builder_ref}.#{builder_method}#{node_child_template}"
-    return template.gsub( /:::(.*?):::/ ) { '#{'+$1+'}' }
-  end
 
-  # Generates absolute, relative, and constrained xpaths for the term, setting xpath, xpath_relative, and xpath_constrained accordingly.
-  # Also triggers update_xpath_values! on all child nodes, as their absolute paths rely on those of their parent nodes.
-  def generate_xpath_queries!
-    self.xpath = OM::XML::TermXpathGenerator.generate_absolute_xpath(self)
-    self.xpath_constrained = OM::XML::TermXpathGenerator.generate_constrained_xpath(self)
-    self.xpath_relative = OM::XML::TermXpathGenerator.generate_relative_xpath(self)
-    self.children.each_value {|child| child.generate_xpath_queries! }
-    return self
-  end
+    # Generates absolute, relative, and constrained xpaths for the term, setting xpath, xpath_relative, and xpath_constrained accordingly.
+    # Also triggers update_xpath_values! on all child nodes, as their absolute paths rely on those of their parent nodes.
+    def generate_xpath_queries!
+      self.xpath = OM::XML::TermXpathGenerator.generate_absolute_xpath(self)
+      self.xpath_constrained = OM::XML::TermXpathGenerator.generate_constrained_xpath(self)
+      self.xpath_relative = OM::XML::TermXpathGenerator.generate_relative_xpath(self)
+      self.children.each_value {|child| child.generate_xpath_queries! }
+      return self
+    end
 
-  # Return an XML representation of the Term
-  # @param [Hash] options the term will be added to it. If :children=>false, skips rendering child Terms
-  # @param [Nokogiri::XML::Document] document (optional) document to insert the term xml into
-  # @return [Nokogiri::XML::Document]
-  # @example If :children=>false, skips rendering child Terms
-  #   term.to_xml(:children=>false)
-  # @example You can provide your own Nokogiri document to insert the xml into
-  #   doc = Nokogiri::XML::Document.new
-  #   term.to_xml({}, document=doc)
-  def to_xml(options={}, document=Nokogiri::XML::Document.new)
-    builder = Nokogiri::XML::Builder.with(document) do |xml|
-      xml.term(:name=>name) {
-        if is_root_term?
-          xml.is_root_term("true")
-        end
-        xml.path path
-        xml.namespace_prefix namespace_prefix
-        unless attributes.nil? || attributes.empty?
-          xml.attributes {
-            attributes.each_pair do |attribute_name, attribute_value|
-              xml.send("#{attribute_name}_".to_sym, attribute_value)
+    # Return an XML representation of the Term
+    # @param [Hash] options the term will be added to it. If :children=>false, skips rendering child Terms
+    # @param [Nokogiri::XML::Document] document (optional) document to insert the term xml into
+    # @return [Nokogiri::XML::Document]
+    # @example If :children=>false, skips rendering child Terms
+    #   term.to_xml(:children=>false)
+    # @example You can provide your own Nokogiri document to insert the xml into
+    #   doc = Nokogiri::XML::Document.new
+    #   term.to_xml({}, document=doc)
+    def to_xml(options={}, document=Nokogiri::XML::Document.new)
+      builder = Nokogiri::XML::Builder.with(document) do |xml|
+        xml.term(:name=>name) {
+          if is_root_term?
+            xml.is_root_term("true")
+          end
+          xml.path path
+          xml.namespace_prefix namespace_prefix
+          unless attributes.nil? || attributes.empty?
+            xml.attributes {
+              attributes.each_pair do |attribute_name, attribute_value|
+                xml.send("#{attribute_name}_".to_sym, attribute_value)
+              end
+            }
+          end
+          xml.index_as {
+            unless index_as.nil?
+              index_as.each  { |index_type| xml.index_type }
             end
           }
-        end
-        xml.index_as {
-          unless index_as.nil?
-            index_as.each  { |index_type| xml.index_type }
+          xml.required required
+          xml.data_type type
+          unless variant_of.nil?
+            xml.variant_of variant_of
+          end
+          unless default_content_path.nil?
+            xml.default_content_path default_content_path
+          end
+          xml.xpath {
+            xml.relative xpath_relative
+            xml.absolute xpath
+            xml.constrained xpath_constrained
+          }
+          if options.fetch(:children, true)
+            xml.children
           end
         }
-        xml.required required
-        xml.data_type type
-        unless variant_of.nil?
-          xml.variant_of variant_of
-        end
-        unless default_content_path.nil?
-          xml.default_content_path default_content_path
-        end
-        xml.xpath {
-          xml.relative xpath_relative
-          xml.absolute xpath
-          xml.constrained xpath_constrained
-        }
-        if options.fetch(:children, true)
-          xml.children
-        end
-      }
-    end
-    doc = builder.doc
-    if options.fetch(:children, true)
-      children.values.each {|child| child.to_xml(options, doc.xpath("//term[@name=\"#{name}\"]/children").first)}
+      end
+      doc = builder.doc
+      if options.fetch(:children, true)
+        children.values.each {|child| child.to_xml(options, doc.xpath("//term[@name=\"#{name}\"]/children").first)}
+      end
+      return doc
     end
-    return doc
-  end
-
-  # private :update_xpath_values
 
+    # private :update_xpath_values
+  end
 end

data/spec/integration/serialization_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'active_support/core_ext/string/conversions' # for String#to_time conversion
 
 describe "element values" do
   before(:all) do
@@ -20,7 +21,7 @@ describe "element values" do
 
 
   describe "when the xml template has existing values" do
-    subject do
+    let(:datastream) do
       ElementValueTerminology.from_xml <<-EOF
 <outer outerId="hypatia:outer" type="outer type">
   <my_date>2012-10-30</my_date>
@@ -30,6 +31,7 @@ describe "element values" do
 </outer>
 EOF
     end
+    subject { datastream } 
     describe "reading  values" do
       it "should deserialize date" do
         subject.my_date.should == [Date.parse('2012-10-30')]
@@ -45,26 +47,42 @@ EOF
       end
     end
     describe "Writing to xml" do
-      it "should serialize time" do
-        subject.my_time = [DateTime.parse('2011-01-30T03:45:15Z')]
-        subject.to_xml.should be_equivalent_to '<?xml version="1.0"?>
-         <outer outerId="hypatia:outer" type="outer type">
-           <my_date>2012-10-30</my_date>
-           <my_time>2011-01-30T03:45:15Z</my_time>
-           <my_int>7</my_int>
-           <active>true</active>
-         </outer>'
+      context "serializing time" do
+        context "with a valid time" do
+          subject { datastream.to_xml }
+          before { datastream.my_time = [DateTime.parse('2011-01-30T03:45:15Z')] }
+          it { should be_equivalent_to '<?xml version="1.0"?>
+           <outer outerId="hypatia:outer" type="outer type">
+             <my_date>2012-10-30</my_date>
+             <my_time>2011-01-30T03:45:15Z</my_time>
+             <my_int>7</my_int>
+             <active>true</active>
+           </outer>' }
+        end
+
+        context "setting an invalid time" do
+          it "raises a type mismatch error" do
+            expect { datastream.my_time = '' }.to raise_error OM::TypeMismatch
+          end
+        end
       end
-      it "should serialize date" do
-        subject.my_date = [Date.parse('2012-09-22')]
-        subject.to_xml.should be_equivalent_to '<?xml version="1.0"?>
-         <outer outerId="hypatia:outer" type="outer type">
-           <my_date>2012-09-22</my_date>
-           <my_time>2012-10-30T12:22:33Z</my_time>
-           <my_int>7</my_int>
-           <active>true</active>
-         </outer>'
+
+      context "serializing dates" do
+
+        subject { datastream.to_xml }
+        context "with a valid date" do
+
+          before { datastream.my_date = [Date.parse('2012-09-22')] }
+          it { should be_equivalent_to '<?xml version="1.0"?>
+           <outer outerId="hypatia:outer" type="outer type">
+             <my_date>2012-09-22</my_date>
+             <my_time>2012-10-30T12:22:33Z</my_time>
+             <my_int>7</my_int>
+             <active>true</active>
+           </outer>' }
+        end
       end
+
       it "should serialize ints" do
         subject.my_int = [9]
         subject.to_xml.should be_equivalent_to '<?xml version="1.0"?>

data/spec/unit/dynamic_node_spec.rb

@@ -47,6 +47,11 @@ describe "OM::XML::DynamicNode" do
       @sample.date_created = ['A long time ago']
       @sample.date_created.should == ['A long time ago']
     end
+
+    it "checks inequality" do
+      @sample.foo = ['in a galaxy far far away']
+      expect(@sample.foo != ['nearby']).to be true
+    end
   end
         
   
@@ -80,6 +85,10 @@ describe "OM::XML::DynamicNode" do
         @article.person.last_name.first.should == "FAMILY NAME"
       end
 
+      it "should respond_to? things an array can do" do
+        expect(@article.person.last_name).to respond_to(:map)
+      end
+
       it "should delegate with blocks to the found array" do
         arr = []
         @article.person.last_name.each{|x| arr << x}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: om
 version: !ruby/object:Gem::Version
-  version: 3.0.4
+  version: 3.0.5
 platform: ruby
 authors:
 - Matt Zumwalt
@@ -9,188 +9,188 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-10 00:00:00.000000000 Z
+date: 2014-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: solrizer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.4.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.4.2
 - !ruby/object:Gem::Dependency
   name: mediashelf-loggable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: deprecation
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: RedCloth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: awesome_print
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: equivalent-xml
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.4
 description: 'OM (Opinionated Metadata): A library to help you tame sprawling XML
@@ -203,9 +203,9 @@ extensions: []
 extra_rdoc_files:
 - LICENSE
 files:
-- .document
-- .gitignore
-- .travis.yml
+- ".document"
+- ".gitignore"
+- ".travis.yml"
 - COMMON_OM_PATTERNS.textile
 - CONTRIBUTING.md
 - GETTING_FANCY.textile
@@ -289,17 +289,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: 'OM (Opinionated Metadata): A library to help you tame sprawling XML schemas