ole-qa-framework 2.7.3 → 3.0.0

data/lib/olels/pages/item_editor.rb

@@ -80,19 +80,7 @@ module OLE_QA::Framework::OLELS
 
     # Create an item note line object.
     def set_lines
-      create_item_note(1)
+      set_line(:item_note, OLE_QA::Framework::OLELS::Item_Note)
     end
-
-    # Add an item note line object.
-    def create_item_note(which = 1)
-      create_line("item_note_#{which}","Item_Note",which)
-    end
-    alias_method(:add_item_note,:create_item_note)
-
-    # Remove an item note line object.
-    def remove_item_note(which = 1)
-      remove_line("item_note_#{which}")
-    end
-    alias_method(:delete_item_note,:remove_item_note)
   end
 end

data/lib/olels/pages/patron.rb

@@ -23,11 +23,6 @@ module OLE_QA::Framework::OLELS
       url = ole_session.url + 'ole-kr-krad/patronMaintenance?viewTypeName=MAINTENANCE&returnLocation='
       url += ole_session.url + 'portal.do&methodToCall=start&dataObjectClassName=org.kuali.ole.deliver.bo.OlePatronDocument'
       super(ole_session, url)
-
-      # Set up initial contact info lines, one of each.
-      add_address_line(1)
-      add_phone_line(1)
-      add_email_line(1)
     end
 
     # Define screen elements for patron record screen.
@@ -89,34 +84,10 @@ module OLE_QA::Framework::OLELS
                                                               end
     end
 
-    def create_address_line(which = 1)
-      create_line("address_line_#{which}","Patron_Address_Line", which)
-    end
-    alias_method(:add_address_line, :create_address_line)
-
-    def create_phone_line(which = 1)
-      create_line("phone_line_#{which}","Patron_Phone_Line", which)
-    end
-    alias_method(:add_phone_line, :create_phone_line)
-
-    def create_email_line(which = 1)
-      create_line("email_line_#{which}","Patron_Email_Line", which)
-    end
-    alias_method(:add_email_line, :create_email_line)
-
-    def remove_address_line(which = 1)
-      remove_line("address_line_#{which}")
-    end
-    alias_method(:delete_address_line, :remove_address_line)
-
-    def remove_phone_line(which = 1)
-      remove_line("phone_line_#{which}")
-    end
-    alias_method(:delete_phone_line, :remove_phone_line)
-
-    def remove_email_line(which = 1)
-      remove_line("email_line_#{which}")
+    def set_lines
+      set_line(:address_line, OLE_QA::Framework::OLELS::Patron_Address_Line)
+      set_line(:phone_line, OLE_QA::Framework::OLELS::Patron_Phone_Line)
+      set_line(:email_line, OLE_QA::Framework::OLELS::Patron_Email_Line)
     end
-    alias_method(:delete_email_line, :remove_email_line)
   end
 end

data/lib/olels/pages/return.rb

@@ -23,6 +23,7 @@ module OLE_QA::Framework::OLELS
 
     # Set elements for return page.
     def set_elements
+      super
       # General Elements
       element(:loan_button)                               {b.button(:id => 'LoanScreenLinkView-buttons')}
       element(:end_session_button)                        {b.button(:id => 'endSessionButton')}

data/lib/olels/pages/staff_upload.rb

@@ -24,6 +24,7 @@ module OLE_QA::Framework::OLELS
 
     # Set elements for Staff upload screen.
     def set_elements
+      super
       element(:title)                   {browser.h1(:class => 'uif-headerText').span}
       element(:marc_field)              {browser.input(:id => "StaffUploadView-marcFileUpload_control").to_subtype}
       element(:edi_field)               {browser.input(:id => "StaffUploadView-ediFileUpload_control").to_subtype}

data/lib/olels/subobjects/ownership_note.rb

@@ -17,10 +17,10 @@ module OLE_QA::Framework::OLELS
   class Ownership_Note < OLE_QA::Framework::Subline_Object
     # Set ownership note screen elements.
     def set_elements
-      element(:note_type_selector)                  {b.select_list(:id => "extentSubHoldingNoteTypeField_line#{@line_id}_line#{@subline_id}_control")}
-      element(:note_field)                          {b.text_field(:id => "extentSubHoldingNoteDescField_line#{@line_id}_line#{@subline_id}_control")}
-      element(:add_button)                          {b.button(:id => "oleEowHoldingNotes_addTagButton_line#{@line_id}_line#{@subline_id}")}
-      element(:remove_button)                       {b.button(:id => "oleEowHoldingNotes_removeTagButton_line#{@line_id}_line#{@subline_id}")}
+      element(:note_type_selector)                  {b.select_list(:id => "extentSubHoldingNoteTypeField_line#{@parent_line.line_id}_line#{line_id}_control")}
+      element(:note_field)                          {b.text_field(:id => "extentSubHoldingNoteDescField_line#{@parent_line.line_id}_line#{line_id}_control")}
+      element(:add_button)                          {b.button(:id => "oleEowHoldingNotes_addTagButton_line#{@parent_line.line_id}_line#{line_id}")}
+      element(:remove_button)                       {b.button(:id => "oleEowHoldingNotes_removeTagButton_line#{@parent_line.line_id}_line#{line_id}")}
     end
   end
 end

data/spec/common/line_object_spec.rb

@@ -20,19 +20,20 @@ describe 'A Line Object' do
 
   before :all do
     @ole = OLE_QA::Framework::Session.new
-    @line_object = OLE_QA::Framework::Line_Object.new(@ole, 1)
+    class TestLine < OLE_QA::Framework::Line_Object
+      def set_sublines
+        subline(:test_subline, OLE_QA::Framework::Subline_Object)
+      end
+    end
+    @line_object = TestLine.new(@ole, 1)
   end
 
   after :all do
     @ole.quit
   end
 
-  it 'should create a new instance' do
-    @line_object.class.should == OLE_QA::Framework::Line_Object
-  end
-
-  it 'should be a subclass of data object' do
-    @line_object.class.superclass.should == OLE_QA::Framework::Data_Object
+  it 'should create a new instance of line object' do
+    @line_object.class.superclass.should == OLE_QA::Framework::Line_Object
   end
 
   it 'should have a browser accessor' do
@@ -43,7 +44,39 @@ describe 'A Line Object' do
     @line_object.line_number.should == 1
   end
 
-  it 'should have a line id' do
+  it 'should have a line ID' do
     @line_object.line_id.should == 0
   end
+
+  it 'should allow the line number to be set dynamically' do
+    @line_object.line_number = 2
+    @line_object.line_number.should == 2
+  end
+
+  it 'should redefine the line ID to one less than the line number' do
+    @line_object.line_id.should == 1
+  end
+
+  it 'should start with a test subline defined automagically' do
+    @line_object.methods.include?(:test_subline).should be_true
+    @line_object.test_subline.should be_an_instance_of(OLE_QA::Framework::Subline_Object)
+  end
+
+  it 'should have that subline listed in the sublines reader attribute' do
+    @line_object.sublines.include?(:test_subline).should be_true
+  end
+
+  it 'should allow a subline to be set dynamically' do
+    @line_object.set_subline(:test_subline_2, OLE_QA::Framework::Subline_Object)
+    @line_object.methods.include?(:test_subline_2).should be_true
+    @line_object.test_subline_2.should be_an_instance_of(OLE_QA::Framework::Subline_Object)
+  end
+
+  it 'should add that subline object to the sublines reader attribute' do
+    @line_object.sublines.include?(:test_subline_2).should be_true
+  end
+
+  it 'should not define a subline object which already exists' do
+    lambda {@line_object.set_subline(:test_subline)}.should raise_error
+  end
 end

data/spec/common/subline_object_spec.rb

@@ -19,9 +19,8 @@ describe 'A Subline Object' do
 
   before :all do
     @ole = OLE_QA::Framework::Session.new
-    @line_num = 1
-    @subline_num = 1
-    @subline = OLE_QA::Framework::Subline_Object.new(@ole, @line_num, @subline_num)
+    @line = OLE_QA::Framework::Line_Object.new(@ole, 1)
+    @subline = OLE_QA::Framework::Subline_Object.new(@ole, @line, 1)
   end
 
   after :all do
@@ -30,25 +29,16 @@ describe 'A Subline Object' do
 
   it 'should create a new instance' do
     @subline.class.should == OLE_QA::Framework::Subline_Object
+    @subline.class.superclass.should == OLE_QA::Framework::Line_Object
   end
 
-  it 'should be a subclass of data object' do
-    @subline.class.superclass.should == OLE_QA::Framework::Data_Object
+  it 'should have its parent line object in the parent line reader attribute' do
+    @subline.parent_line.should == @line
   end
 
-  it 'should have a line number' do
-    @subline.line_number.should == 1
-  end
-
-  it 'should have a line id' do
-    @subline.line_id.should == 0
-  end
-
-  it 'should have a subline number' do
-    @subline.subline_number.should == 1
-  end
-
-  it 'should have a subline id' do
-    @subline.subline_id.should == 0
+  it 'should have access to parent line methods' do
+    @subline.parent_line.line_number = 2
+    @line.line_number.should == 2
+    @line.line_id.should == 1
   end
 end

data/spec/modules/qa_page_helpers_spec.rb

@@ -0,0 +1,54 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+require 'rspec'
+require 'spec_helper'
+
+describe 'The Page Helpers module' do
+
+  before :all do
+    @ole = OLE_QA::Framework::Session.new
+
+    class TestPage < OLE_QA::Framework::Page
+      def set_lines
+        set_line(:line_object, OLE_QA::Framework::Line_Object)
+      end
+    end
+
+    @test_page = TestPage.new(@ole, @ole.url)
+  end
+
+  after :all do
+    @ole.quit
+  end
+
+  it 'should create a page instance with a line object already declared' do
+    @test_page.methods.include?(:line_object).should be_true
+    @test_page.line_object.class.should == OLE_QA::Framework::Line_Object
+  end
+
+  it 'should have the line object listed in the lines accessor' do
+    @test_page.lines.include?(:line_object).should be_true
+  end
+
+  it 'should define a line object dynamically' do
+    @test_page.set_line(:addl_line_object, OLE_QA::Framework::Line_Object)
+    @test_page.lines.include?(:addl_line_object).should be_true
+    @test_page.addl_line_object.should be_an_instance_of(OLE_QA::Framework::Line_Object)
+  end
+
+  it 'should not set a line object which has already been defined' do
+    lambda {@test_page.set_line(:addl_line_object)}.should raise_error
+  end
+end

data/spec/olefs/accounting_line_spec.rb

@@ -20,7 +20,6 @@ describe 'An accounting line' do
   before :all do
     @ole = OLE_QA::Framework::Session.new
     @accounting_line = OLE_QA::Framework::OLEFS::Accounting_Line.new(@ole, 1, 1)
-    @new_accounting_line = OLE_QA::Framework::OLEFS::New_Accounting_Line.new(@ole, 1, 0)
   end
 
   after :all do
@@ -29,49 +28,22 @@ describe 'An accounting line' do
 
   it 'should create a new instance' do
     @accounting_line.class.should == OLE_QA::Framework::OLEFS::Accounting_Line
-    @new_accounting_line.class.should == OLE_QA::Framework::OLEFS::New_Accounting_Line
   end
 
   it 'should be a subclass of subline object' do
     @accounting_line.class.superclass.should == OLE_QA::Framework::Subline_Object
-    @new_accounting_line.class.superclass.should == OLE_QA::Framework::Subline_Object
   end
 
   it 'should have a browser accessor' do
     @accounting_line.browser.class.should == @ole.browser.class
-    @new_accounting_line.browser.class.should == @ole.browser.class
   end
 
   it 'should have line number attributes' do
     @accounting_line.line_number.should == 1
-    @accounting_line.subline_number.should == 1
-    @new_accounting_line.line_number.should == 1
-    @new_accounting_line.subline_number.should == 0
   end
 
   it 'should have accounting line elements' do
-    methods_array = @accounting_line.methods
-    methods_array.include?(:account_number_field).should be_true
-    methods_array.include?(:sub_account_number_field).should be_true
-    methods_array.include?(:object_field).should be_true
-    methods_array.include?(:sub_object_field).should be_true
-    methods_array.include?(:project_field).should be_true
-    methods_array.include?(:org_ref_id_field).should be_true
-    methods_array.include?(:dollar_field).should be_true
-    methods_array.include?(:percent_field).should be_true
-    methods_array.include?(:chart_selector).should be_true
-    methods_array.include?(:delete_button).should be_true
-    methods_array.include?(:balance_inquiry_button).should be_true
-    methods_array.include?(:closed_chart_field).should be_true
-    methods_array.include?(:closed_account_number_field).should be_true
-    methods_array.include?(:closed_object_field).should be_true
-    methods_array.include?(:closed_dollar_field).should be_true
-    methods_array.include?(:closed_percent_field).should be_true
-  end
-
-  it 'should have new accounting line elements' do
-    methods = @new_accounting_line.methods
-    methods.include?(:chart_selector).should be_true
+    methods = @accounting_line.methods
     methods.include?(:account_number_field).should be_true
     methods.include?(:sub_account_number_field).should be_true
     methods.include?(:object_field).should be_true
@@ -80,6 +52,13 @@ describe 'An accounting line' do
     methods.include?(:org_ref_id_field).should be_true
     methods.include?(:dollar_field).should be_true
     methods.include?(:percent_field).should be_true
-    methods.include?(:add_button).should be_true
+    methods.include?(:chart_selector).should be_true
+    methods.include?(:delete_button).should be_true
+    methods.include?(:balance_inquiry_button).should be_true
+    methods.include?(:closed_chart_field).should be_true
+    methods.include?(:closed_account_number_field).should be_true
+    methods.include?(:closed_object_field).should be_true
+    methods.include?(:closed_dollar_field).should be_true
+    methods.include?(:closed_percent_field).should be_true
   end
 end

data/spec/olefs/copies_line_spec.rb

@@ -19,8 +19,7 @@ describe 'A copies line' do
 
   before :all do
     @ole = OLE_QA::Framework::Session.new
-    @copies_line = OLE_QA::Framework::OLEFS::Copies_Line.new(@ole, 1, 1)
-    @new_copies_line = OLE_QA::Framework::OLEFS::New_Copies_Line.new(@ole, 1, 0)
+    @copies_line = OLE_QA::Framework::OLEFS::Copies_Line.new(@ole, 1)
   end
 
   after :all do
@@ -29,24 +28,18 @@ describe 'A copies line' do
 
   it 'should create a new instance' do
     @copies_line.class.should == OLE_QA::Framework::OLEFS::Copies_Line
-    @new_copies_line.class.should == OLE_QA::Framework::OLEFS::New_Copies_Line
   end
 
   it 'should be a subclass of subline object' do
     @copies_line.class.superclass.should == OLE_QA::Framework::Subline_Object
-    @new_copies_line.class.superclass.should == OLE_QA::Framework::Subline_Object
   end
 
   it 'should have a browser accessor' do
     @copies_line.browser.class.should == @ole.browser.class
-    @new_copies_line.browser.class.should == @ole.browser.class
   end
 
   it 'should have line number methods' do
     @copies_line.line_number.should == 1
-    @copies_line.subline_number.should == 1
-    @new_copies_line.line_number.should == 1
-    @new_copies_line.subline_number.should == 0
   end
 
   it 'should have copies line elements' do
@@ -59,12 +52,4 @@ describe 'A copies line' do
     methods.include?(:closed_part_enumeration_field).should be_true
     methods.include?(:closed_starting_copy_field).should be_true
   end
-
-  it 'should have new copies line elements' do
-    methods = @new_copies_line.methods
-    methods.include?(:copies_field).should be_true
-    methods.include?(:location_copies_selector).should be_true
-    methods.include?(:starting_copy_field).should be_true
-    methods.include?(:add_button).should be_true
-  end
 end

data/spec/olefs/exception_notes_line_spec.rb

@@ -20,8 +20,8 @@ describe 'An OLEFS Exception Notes Line object' do
   before :all do
     @ole = OLE_QA::Framework::Session.new
     @browser = @ole.browser
-    @exception_notes_line = OLE_QA::Framework::OLEFS::Exception_Notes_Line.new(@ole, 1, 1)
-    @new_exception_notes_line = OLE_QA::Framework::OLEFS::New_Exception_Notes_Line.new(@ole, 1, 0)
+    @rcv_line = OLE_QA::Framework::OLEFS::Receiving_Line.new(@ole, 1)
+    @exception_notes_line = OLE_QA::Framework::OLEFS::Exception_Notes_Line.new(@ole, @rcv_line, 1)
   end
 
 	after :all do
@@ -31,24 +31,14 @@ describe 'An OLEFS Exception Notes Line object' do
   it 'should create a new instance' do
     @exception_notes_line.class.should == OLE_QA::Framework::OLEFS::Exception_Notes_Line
     @exception_notes_line.class.superclass.should == OLE_QA::Framework::Subline_Object
-    @new_exception_notes_line.class.should == OLE_QA::Framework::OLEFS::New_Exception_Notes_Line
-    @new_exception_notes_line.class.superclass.should == OLE_QA::Framework::Subline_Object
   end
 
   it 'should have a browser accessor' do
     @exception_notes_line.browser.class.should == @ole.browser.class
-    @new_exception_notes_line.browser.class.should == @ole.browser.class
   end
 
   it 'should have exception notes elements' do
-    methods = @exception_notes_line.methods
-    methods.include?(:exception_type_selector).should be_true
-    methods.include?(:note_field).should be_true
-    methods.include?(:note_type_selector).should be_true
-  end
-
-  it 'should have new exception notes elements' do
-    elements = @new_exception_notes_line.methods
+    elements = @exception_notes_line.elements
     elements.include?(:exception_type_selector).should be_true
     elements.include?(:note_field).should be_true
     elements.include?(:note_type_selector).should be_true

data/spec/olefs/invoice_current_item_spec.rb

@@ -28,7 +28,7 @@ describe 'An OLEFS Invoice Current Item line' do
 
   it 'should create a new instance' do
     @line_object.class.should == OLE_QA::Framework::OLEFS::Invoice_Current_Item
-    @line_object.class.superclass.should == OLE_QA::Framework::OLEFS::Invoice_Line_Object
+    @line_object.class.superclass.should == OLE_QA::Framework::Line_Object
   end
 
   it 'should have current item elements' do

data/spec/olefs/invoice_line_item_spec.rb

@@ -19,8 +19,8 @@ describe 'A PO Line Item on an OLE Invoice' do
 
   before :all do
     @ole = OLE_QA::Framework::Session.new
-    @po_line = OLE_QA::Framework::OLEFS::Invoice_Line.new(@ole, 1)
-    @line_item = OLE_QA::Framework::OLEFS::Invoice_Line_Item.new(@ole, @po_line, 1)
+    @parent_line = OLE_QA::Framework::OLEFS::Invoice_Line.new(@ole, 1)
+    @line_item = OLE_QA::Framework::OLEFS::Invoice_Line_Item.new(@ole, @parent_line, 1)
   end
 
   after :all do
@@ -29,12 +29,12 @@ describe 'A PO Line Item on an OLE Invoice' do
 
   it 'should create a new instance' do
     @line_item.class.should == OLE_QA::Framework::OLEFS::Invoice_Line_Item
-    @line_item.class.superclass.should == OLE_QA::Framework::OLEFS::Invoice_Line_Object
+    @line_item.class.superclass.should == OLE_QA::Framework::Subline_Object
   end
 
   it 'should have access to the line_number and line_id methods on the PO Line' do
-    @line_item.po_line.line_number.should == 1
-    @line_item.po_line.line_id.should     == 0
+    @line_item.parent_line.line_number.should == 1
+    @line_item.parent_line.line_id.should     == 0
   end
 
   it 'should have line item elements' do