ole-qa-framework 2.4.1 → 2.5.2

data/CHANGELOG.md

@@ -1,3 +1,23 @@
+### v2.5.2 - 2013/08/15
+
+* Editor Fixes
+    * move all message elements to Editor base class (OLE_QA::Framework::OLELS::Editor)/.
+    * fix message definition
+    * add messages definition (multiple elements returned)
+    * add message_header definition
+    * add message_count function (returns "0" if message_header not present)
+
+### v2.5.1 - 2013/08/13
+
+* Small Fixes
+    * Update spec/common/page_spec.rb
+    * Update specs to ensure @ole.quit
+      is run after each full spec
+
+### v2.5.0 - 2013/08/05
+
+* Add Patron Record Screen
+
 ### v2.4.1 - 2013/07/30
 
 * Small Fixes

data/lib/common/page.rb

@@ -78,6 +78,7 @@ module OLE_QA::Framework
       element(:login_button)          {@browser.input(:class => 'go', :value => 'Login')}
       element(:logout_button)         {@browser.input(:class => 'go', :value => 'Logout')}
       element(:login_confirmation)    {@browser.div(:id => 'login-info').strong(:text => /Impersonating User\:/)}
+      element(:loading_message)       {@browser.body.div.h1.img(:alt => 'Loading...')}
     end
 
     # Set functions common to most or all pages across the OLE interface.

data/lib/ole-qa-framework.rb

@@ -49,7 +49,6 @@ module OLE_QA
     # If pages or elements need to be inherited by subclasses, put them in a (foo)/common/ directory.
     # Subobject directories (foo)/subobjects/ should be loaded before object directories (foo)/objects/ for inheritance.
     load_libs("/common/")
-    # load_libs("/olefs/")
     load_libs("/olefs/common/")
     load_libs("/olefs/subobjects/")
     load_libs("/olefs/objects/")

data/lib/ole_qa_framework/VERSION.rb

@@ -15,6 +15,6 @@
 module OLE_QA
   module Framework
     # The version number for this project.
-    VERSION = '2.4.1'
+    VERSION = '2.5.2'
   end
-end
+end

data/lib/olels/common/e_doc.rb

@@ -17,7 +17,38 @@ module OLE_QA::Framework::OLELS
   class E_Doc < OLE_QA::Framework::Page
     # Set elements common to all OLELS E-Document pages.
     def set_elements
+      super
+      element(:title)                                 {b.h1(:class => 'uif-headerText').span(:class => 'uif-headerText-span')}
       element(:description_field)                     {b.text_field(:xpath => "//tr/th[descendant::label[contains(text(),'Description:')]]/following-sibling::td[1]/descendant::input[1]")}
+      element(:explanation_field)                     {b.text_field(:xpath => "//tr/th[descendant::label[contains(text(),'Explanation:')]]/following-sibling::td[1]/descendant::textarea[1]")}
+      element(:org_doc_number_field)                  {b.text_field(:xpath => "//tr/th[descendant::label[contains(text(),'Organization Document Number:')]]/following-sibling::td[1]/descendant::input[1]")}
+      element(:document_id)                           {b.span(:xpath => "//table[@class='uif-gridLayout']/descendant::th[span/label[contains(text(),'Document Number:')]]/following-sibling::td[1]/div/span")}
+      element(:initiator_id)                          {b.span(:xpath => "//table[@class='uif-gridLayout']/descendant::th[span/label[contains(text(),'Initiator Network Id:')]]/following-sibling::td[1]/div/span")}
+      element(:document_status)                       {b.span(:xpath => "//table[@class='uif-gridLayout']/descendant::th[span/label[contains(text(),'Document Status:')]]/following-sibling::td[1]/div/span")}
+      element(:creation_timestamp)                    {b.span(:xpath => "//table[@class='uif-gridLayout']/descendant::th[span/label[contains(text(),'Creation Timestamp:')]]/following-sibling::td[1]/div/span")}
+    end
+
+    # FIXME - Make this a single flexible method during namespace revision.
+    # Create a line object on a page.
+    def create_line(instance_name, class_name, which=0)
+      raise StandardError, "Line object already exists.  (#{instance_name})" if self.instance_variables.include?("@#{instance_name}".to_sym)
+      new_line_name = instance_name
+      make_accessor(:"#{instance_name}")
+      klas = OLE_QA::Framework::OLELS.const_get(:"#{class_name}")
+      instance_variable_set(:"@#{new_line_name}", klas.new(@ole, which))
+    end
+
+    # Remove a line object from a page.
+    def remove_line(instance_name)
+      raise StandardError, "Line object does not exist.  (#{instance_name})" unless self.instance_variables.include?("@#{instance_name}".to_sym)
+      remove_instance_variable("@#{instance_name}".to_sym)
+      unmake_attr(instance_name.to_sym)
+    end
+
+    def wait_for_elements
+      super
+      @wait_on << :title
+      @wait_on << :document_id
     end
   end
 end

data/lib/olels/common/editor.rb

@@ -45,6 +45,9 @@ module OLE_QA::Framework::OLELS
     def set_elements
       super
       element(:title)                               {b.h2(:class => "uif-headerText").span}
+      element(:message)                             {b.li(:class => 'uif-infoMessageItem')}
+      element(:messages)                            {b.lis(:class => 'uif-infoMessageItem')}
+      element(:message_header)                      {b.h3(:class => 'uif-pageValidationHeader')}
       element(:submit_button)                       {b.button(:id => "submitEditor")}
       element(:cancel_button)                       {b.button(:id => "cancelEditor")}
       element(:close_button)                        {b.button(:id => "closeEditor")}
@@ -75,6 +78,9 @@ module OLE_QA::Framework::OLELS
       # This function takes two arguments - the first is the holdings element to which it belongs, and the second is its position.
       #   e.g., item_link(1,1) will return the first item under the first holdings link, item_link(2,2) will return the second item under the second holdings link.
       function(:item_link)                          {|which_holdings = 1, which_item = 1| b.a(:xpath => "//div[@id='holdingsItemTree_tree']/ul[@class='jstree-no-icons']/li[#{which_holdings}]/ul/li[#{which_item}]/a")}
+      # Return the number of messages found in the .message_header text.
+      #   - If .message_header is not present, a "0" will be returned.
+      function(:message_count)                       { if message_header.present? then message_header.text.match(/\d(?=\smessage)/).to_s else "0" end}
     end
 
     # Create a Line Object on an Editor page.

data/lib/olels/objects/patron_address_line.rb

@@ -0,0 +1,88 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+module OLE_QA::Framework::OLELS
+  # An address line on an individual patron record.
+  class Patron_Address_Line < Line_Object
+    # Define screen elements for patron record address line.
+    def set_elements
+      # Format id string based on @line_id .
+      # @note Address line 0 has no numerical identifier.
+      element(:details_link)                      {(@line_id == 0) ?
+                                                    id_str = 'OlePatronDocument-Address_detLink_add' :
+                                                    id_str = "OlePatronDocument-Address_detLink_line#{@line_id - 1}"
+                                                    b.a(:id => id_str)}
+      element(:address_type_selector)             {(@line_id == 0) ?
+                                                    id_str = 'addressTypeCode_add_control' :
+                                                    id_str = "addressTypeCode_line#{@line_id - 1}_control"
+                                                    b.select_list(:id => id_str)}
+      element(:address_source_selector)           {(@line_id == 0) ?
+                                                    id_str = 'addressSource_add_control' :
+                                                    id_str = "addressSource_line#{@line_id - 1}_control"
+                                                    b.select_list(:id => id_str)}
+      element(:valid_from_date_field)             {(@line_id == 0) ?
+                                                    id_str = 'addressValidFrom_add_control' :
+                                                    id_str = "addressValidFrom_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:valid_to_date_field)               {(@line_id == 0) ?
+                                                    id_str = 'addressValidTo_add_control' :
+                                                    id_str = "addressValidTo_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:verified_checkbox)                 {(@line_id == 0) ?
+                                                    id_str = 'addressVerified_add_control' :
+                                                    id_str = "addressVerified_line#{@line_id - 1}_control"
+                                                    b.checkbox(:id => id_str)}
+      element(:preferred_checkbox)                {(@line_id == 0) ?
+                                                    id_str = 'defaultValue_add_control' :
+                                                    id_str = "defaultValue_line#{@line_id - 1}_control"
+                                                    b.checkbox(:id => id_str)}
+      element(:active_checkbox)                   {(@line_id == 0) ?
+                                                    id_str = 'active_add_control' :
+                                                    id_str = "active_line#{@line_id - 1}_control"
+                                                    b.checkbox(:id => id_str)}
+      # Details Area
+      element(:line_1_field)                      {(@line_id == 0) ?
+                                                    id_str = 'line1_add_control' :
+                                                    id_str = "line1_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:line_2_field)                      {(@line_id == 0) ?
+                                                    id_str = 'line2_add_control' :
+                                                    id_str = "line2_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:line_3_field)                      {(@line_id == 0) ?
+                                                    id_str = 'line3_add_control' :
+                                                    id_str = "line3_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:city_field)                        {(@line_id == 0) ?
+                                                    id_str = 'city_add_control' :
+                                                    id_str = "city_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:state_selector)                    {(@line_id == 0) ?
+                                                    id_str = 'state_add_control' :
+                                                    id_str = "state_line#{@line_id - 1}_control"
+                                                    b.select_list(:id => id_str)}
+      element(:postal_code_field)                 {(@line_id == 0) ?
+                                                    id_str = 'postalCode_add_control' :
+                                                    id_str = "postalCode_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:country_selector)                  {(@line_id == 0) ?
+                                                    id_str = 'country_add_control' :
+                                                    id_str = "country_line#{@line_id - 1}_control"
+                                                    b.select_list(:id => id_str)}
+      # Add/Delete
+      element(:add_button)                        {b.button(:id => 'OlePatronDocument-Address_add')}
+      element(:delete_button)                     {b.button(:id => "OlePatronDocument-Address_del_line#{@line_id - 1}")}
+    end
+  end
+end

data/lib/olels/objects/patron_email_line.rb

@@ -0,0 +1,40 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+module OLE_QA::Framework::OLELS
+  # A line of email address information on a patron record.
+  class Patron_Email_Line < Line_Object
+    # Set screen elements on patron record email info line.
+    def set_elements
+      element(:email_type_selector)                       {(@line_id == 0) ?
+                                                            id_str = 'emailTypeCode_add_control' :
+                                                            id_str = "emailTypeCode_line#{@line_id - 1}_control"
+                                                            b.select_list(:id => id_str)}
+      element(:email_address_field)                       {(@line_id == 0) ?
+                                                            id_str = 'emailAddress_add_control' :
+                                                            id_str = "emailAddress_line#{@line_id - 1}_control"
+                                                            b.text_field(:id => id_str)}
+      element(:preferred_checkbox)                        {(@line_id == 0) ?
+                                                            id_str = 'email_defaultValue_add_control' :
+                                                            id_str = "email_defaultValue_line#{@line_id - 1}_control"
+                                                            b.checkbox(:id => id_str)}
+      element(:active_checkbox)                           {(@line_id == 0) ?
+                                                            id_str = 'email_active_add_control' :
+                                                            id_str = "email_active_line#{@line_id - 1}_control"
+                                                            b.checkbox(:id => id_str)}
+      element(:add_button)                                {b.button(:id => 'OlePatronDocument-Email_add')}
+      element(:delete_button)                             {b.button(:id => "OlePatronDocument-Email_del_line#{@line_id - 1}")}
+    end
+  end
+end

data/lib/olels/objects/patron_phone_line.rb

@@ -0,0 +1,48 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+module OLE_QA::Framework::OLELS
+  # A phone number info line on a single patron record.
+  class Patron_Phone_Line < Line_Object
+    # Set screen elements for patron phone number info line.
+    def set_elements
+      element(:phone_type_selector)               {(@line_id == 0) ?
+                                                    id_str = 'phoneTypeCode_add_control' :
+                                                    id_str = "phoneTypeCode_line#{@line_id - 1}_control"
+                                                    b.select_list(:id => id_str)}
+      element(:phone_number_field)                {(@line_id == 0) ?
+                                                    id_str = 'phoneNumber_add_control' :
+                                                    id_str = "phoneNumber_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:extension_field)                   {(@line_id == 0) ?
+                                                    id_str = 'extensionNumber_add_control' :
+                                                    id_str = "extensionNumber_line#{@line_id - 1}_control"
+                                                    b.text_field(:id => id_str)}
+      element(:country_selector)                  {(@line_id == 0) ?
+                                                    id_str = 'countryCode_add_control' :
+                                                    id_str = "countryCode_line#{@line_id - 1}_control"
+                                                    b.select_list(:id => id_str)}
+      element(:preferred_checkbox)                {(@line_id == 0) ?
+                                                    id_str = 'phoneNumber_defaultValue_add_control' :
+                                                    id_str = "phoneNumber_defaultValue_line#{@line_id - 1}_control"
+                                                    b.checkbox(:id => id_str)}
+      element(:active_checkbox)                   {(@line_id == 0) ?
+                                                    id_str = 'phoneNumber_active_add_control' :
+                                                    id_str = "phoneNumber_active_line#{@line_id - 1}_control"
+                                                    b.checkbox(:id => id_str)}
+      element(:add_button)                        {b.button(:id => 'OlePatronDocument-Phone_add')}
+      element(:delete_button)                     {b.button(:id => "OlePatronDocument-Phone_del_line#{@line_id - 1}")}
+    end
+  end
+end

data/lib/olels/pages/bib_editor.rb

@@ -20,10 +20,9 @@ module OLE_QA::Framework::OLELS
     #   {OLE_QA::Framework::OLELS::Data_Line}
     def set_elements
       super
-      element(:message)                             {b.span(:id => "workMessageSection_span")}
-      element(:leader_field)                        {b.text_field(:id => "LeaderTextInputField_control")}
       element(:bib_record_status_selector)          {b.select_list(:id => "StatusFieldSection_control")}
       element(:set_button)                          {b.button(:id => "set_button")}
+      element(:leader_field)                        {b.text_field(:id => "LeaderTextInputField_control")}
       # Control Field Buttons
       element(:control_003_link)                    {b.a(:id => "003FieldLink")}
       element(:control_005_link)                    {b.a(:id => "005FieldLink")}
@@ -48,6 +47,11 @@ module OLE_QA::Framework::OLELS
       element(:control_008_field)                   {b.text_field(:id => "008Field_control")}
     end
 
+    def set_functions
+      super
+
+    end
+
     # Add the first Marc Data Line to a new Bib Editor record.
     # @note There will always be at least one Marc Data Line on a newly-opened record,
     #   whether newly-created or previously extant.

data/lib/olels/pages/instance_editor.rb

@@ -18,8 +18,6 @@ module OLE_QA::Framework::OLELS
     # Set OLELS Instance Editor page elements.
     def set_elements
       super
-      # Override :message element on Editor base class.
-      element(:message)                               {b.span(:id => "workInstanceMessage_span")}
       element(:location_toggle)                       {b.a(:id => "OleLocationInformationSection_toggle")}
       element(:location_field)                        {b.text_field(:id => "OleHoldingLocation_control")}
       element(:call_number_toggle)                    {b.a(:id => "OleCallNumberInformation_toggle")}

data/lib/olels/pages/item_editor.rb

@@ -18,9 +18,6 @@ module OLE_QA::Framework::OLELS
     # Set Item Editor screen elements.
     def set_elements
       super
-      # Override message in Editor base class, add multi-message element.
-      element(:message)                                   {b.span(:id => "workItemMessage_span")}
-      element(:messages)                                  {b.span(:id => "workItemMessage_span").font}
       # Holdings Location/Call Number Information
       element(:holdings_location_field)                   {b.span(:id => "OleHoldingLocationLevelName_control")}
       element(:holdings_prefix_field)                     {b.span(:id => "OleHoldingCallNumberPrefix_control")}

data/lib/olels/pages/patron.rb

@@ -0,0 +1,122 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+module OLE_QA::Framework::OLELS
+  # A single patron record in the OLE Library System.
+  # @note Use of this page may require a special login.  The default user,
+  #   ole-khuntley, does not have sufficient permissions to create a new
+  #   patron record (as of 1.0.0-M2-r13397, 07/31/2013).
+  class Patron < E_Doc
+    # The page object will open a new patron record by default.
+    def initialize(ole_session)
+      url = ole_session.url + 'ole-kr-krad/patronMaintenance?viewTypeName=MAINTENANCE&returnLocation='
+      url += ole_session.url + 'portal.do&methodToCall=start&dataObjectClassName=org.kuali.ole.deliver.bo.OlePatronDocument'
+      super(ole_session, url)
+
+      # Set up initial contact info lines, one of each.
+      add_address_line(1)
+      add_phone_line(1)
+      add_email_line(1)
+    end
+
+    # Define screen elements for patron record screen.
+    def set_elements
+      super
+      element(:patron_id)                                     {b.a(:xpath => "//th[span/label[contains(text(),'Patron Id:')]]/following-sibling::td[1]/div/span/a")}
+      element(:barcode_field)                                 {b.text_field(:id => 'barcode_control')}
+      element(:borrower_type_selector)                        {b.select_list(:id => 'borrowerType_control')}
+      element(:source_selector)                               {b.select_list(:id => 'sourceType_control')}
+      element(:patron_image_field)                            {b.input(:id => 'attachment_Files_control').to_subtype}
+      element(:upload_image_button)                           {b.button(:id => 'uploadButton_patron')}
+      element(:statistical_category_selector)                 {b.select_list(:id => 'statisticalCategory_control')}
+      element(:activation_date_field)                         {b.text_field(:id => 'activationDate_control')}
+      element(:expiration_date_field)                         {b.text_field(:id => 'expirationDate_control')}
+      element(:active_checkbox)                               {b.checkbox(:id => 'activeIndicator_control')}
+      element(:name_type)                                     {b.span(:id => /nameType.*control/)}
+      element(:title_selector)                                {b.select_list(:id => /namePrefix.*control/)}
+      element(:first_name_field)                              {b.text_field(:id => /firstName.*control/)}
+      element(:middle_name_field)                             {b.text_field(:id => /middleName.*control/)}
+      element(:last_name_field)                               {b.text_field(:id => /lastName.*control/)}
+      element(:suffix_selector)                               {b.select_list(:id => /nameSuffix.*control/)}
+      element(:affiliation_toggle)                            {b.a(:id => 'OlePatronDocument-Affiliation_toggle')}
+      element(:library_policies_toggle)                       {b.a(:id => 'OlePatronDocument-LibraryPoliciesSection_toggle')}
+      element(:loaned_records_toggle)                         {b.a(:id => 'OlePatronDocument-PatronLoanedRecords_toggle')}
+      element(:requested_records_toggle)                      {b.a(:id => 'OlePatronDocument-PatronRequestedRecords_toggle')}
+      element(:temp_circ_history_toggle)                      {b.a(:id => 'OlePatronDocument-TemporaryCirculationHistoryRecords_toggle')}
+      element(:note_toggle)                                   {b.a(:id => 'OlePatronDocument-NotesSection_toggle')}
+      element(:proxy_patron_toggle)                           {b.a(:id => 'OlePatronDocument-ProxySection_toggle')}
+      element(:proxy_for_toggle)                              {b.a(:id => 'OlePatronDocument-ProxyForSection_toggle')}
+      element(:local_id_toggle)                               {b.a(:id => 'OlePatronDocument-PatronLocalIdSection_toggle')}
+      element(:lost_barcode_toggle)                           {b.a(:id => 'OlePatronDocument-InvalidOrLostBarcodeSection_toggle')}
+      # TODO Check on OLE-4523 for the establishment of the element ID in the ad_hoc_toggle link.
+      element(:ad_hoc_toggle)                                 {b.a(:id => 'OlePatronDocument-AdHocRecipientsSection_toggle')}
+      # TODO Check on OLE-4526 for the establishment of the element ID in the route_log_toggle link.
+      element(:route_log_toggle)                              {b.a(:id => 'OlePatronDocument-RouteLogSection_toggle')}
+      element(:contacts_toggle)                               {b.a(:id => 'OlePatronDocument-ContactsSection_toggle')}
+      element(:overview_toggle)                               {b.a(:id => 'OlePatronDocument-OverviewSection_toggle')}
+      element(:name_toggle)                                   {b.a(:id => 'OlePatronDocument-Name_toggle')}
+      element(:address_toggle)                                {b.a(:id => 'OlePatronDocument-Address_toggle')}
+      element(:phone_toggle)                                  {b.a(:id => 'OlePatronDocument-Phone_toggle')}
+      element(:email_toggle)                                  {b.a(:id => 'OlePatronDocument-Email_toggle')}
+    end
+
+    # Define commonly used functions for patron record screen.
+    def set_functions
+      super
+      # If the .patron_image_field has already been set once, IDs of related elements change.
+      # Use this method to update element IDs on the page object.  It will return true if the IDs have been updated, false if the default IDs are still being used.
+      function(:redefine_patron_image_elements)               do
+                                                                if b.input(:id => 'attachment_File_edit_control').present?
+                                                                  set_element(:patron_image_field, true)  {b.input(:id => 'attachment_File_edit_control').to_subtype}
+                                                                  set_element(:upload_image_button,true)  {b.button(:id => 'uploadButton_edit')}
+                                                                  true
+                                                                else
+                                                                  set_element(:patron_image_field, true)  {b.input(:id => 'attachment_Files_control').to_subtype}
+                                                                  set_element(:upload_image_button, true) {b.button(:id => 'uploadButton_patron')}
+                                                                  false
+                                                                end
+                                                              end
+    end
+
+    def create_address_line(which = 1)
+      create_line("address_line_#{which}","Patron_Address_Line", which)
+    end
+    alias_method(:add_address_line, :create_address_line)
+
+    def create_phone_line(which = 1)
+      create_line("phone_line_#{which}","Patron_Phone_Line", which)
+    end
+    alias_method(:add_phone_line, :create_phone_line)
+
+    def create_email_line(which = 1)
+      create_line("email_line_#{which}","Patron_Email_Line", which)
+    end
+    alias_method(:add_email_line, :create_email_line)
+
+    def remove_address_line(which = 1)
+      remove_line("address_line_#{which}")
+    end
+    alias_method(:delete_address_line, :remove_address_line)
+
+    def remove_phone_line(which = 1)
+      remove_line("phone_line_#{which}")
+    end
+    alias_method(:delete_phone_line, :remove_phone_line)
+
+    def remove_email_line(which = 1)
+      remove_line("email_line_#{which}")
+    end
+    alias_method(:delete_email_line, :remove_email_line)
+  end
+end

data/lib/olels/pages/patron_lookup.rb

@@ -17,7 +17,7 @@ module OLE_QA::Framework::OLELS
   class Patron_Lookup < Lookup
     def initialize(ole_session)
       url = ole_session.url + 'portal.do?channelTitle=Patron&channelUrl='
-      url += ole_session.url + 'ole-kr-krad/lookup?methodToCall=start&dataObjectClassName=org.kuali.ole.patron.bo.OlePatronDocument&returnLocation='
+      url += ole_session.url + 'ole-kr-krad/lookup?methodToCall=start&dataObjectClassName=org.kuali.ole.deliver.bo.OlePatronDocument&returnLocation='
       url += ole_session.url + 'portal.do&hideReturnLink=true&showMaintenanceLinks=true'
       super(ole_session, url)
     end

data/spec/common/page_spec.rb

@@ -23,6 +23,10 @@ describe "A Page" do
     @page = OLE_QA::Framework::Page.new(@ole, @ole.base_url)
   end
 
+  after :all do
+    @ole.quit
+  end
+
   it "should open via url" do
     @page.open
     @ole.browser.title.should == "Kuali Portal Index"
@@ -36,11 +40,6 @@ describe "A Page" do
     @page.url.should == @ole.base_url
   end
 
-  it 'should set a frame element on the browser if one is present' do
-    @page.browser.link(:text => "Requisition").click
-    @page.browser.class.should == Watir::Frame
-  end
-
   it 'should be able to login as another user' do
     @page.open
     @page.login('ole-abeal').should be_true
@@ -54,4 +53,10 @@ describe "A Page" do
     @ole.open('www.google.com')
     lambda {@page.login}.should raise_error(error=OLE_QA::Framework::Error)
   end
-end
+
+  it 'should set a frame element on the browser if one is present' do
+    OLE_QA::Framework::OLEFS::Requisition.new(@ole).open
+    @page.browser.class.should == Watir::Frame
+  end
+
+end

data/spec/modules/qa_helpers_spec.rb

@@ -38,6 +38,10 @@ describe 'The Helpers module' do
     @test_object = TestObject.new(@ole)
   end
 
+	after :all do
+	  @ole.quit
+	end
+
   it 'should do create an accessor attribute' do
     @test_object.foo.should == "foo"
     @test_object.foo = "foo bar baz"
@@ -52,4 +56,4 @@ describe 'The Helpers module' do
     @test_object.xyzzy = "xyzzy"
     @test_object.give_xyzzy.should == "xyzzy"
   end
-end
+end

data/spec/olefs/exception_notes_line_spec.rb

@@ -24,6 +24,10 @@ describe 'An OLEFS Exception Notes Line object' do
     @new_exception_notes_line = OLE_QA::Framework::OLEFS::New_Exception_Notes_Line.new(@ole, 1, 0)
   end
 
+	after :all do
+		@ole.quit
+	end
+
   it 'should create a new instance' do
     @exception_notes_line.class.should == OLE_QA::Framework::OLEFS::Exception_Notes_Line
     @exception_notes_line.class.superclass.should == OLE_QA::Framework::Subline_Object
@@ -49,4 +53,4 @@ describe 'An OLEFS Exception Notes Line object' do
     elements.include?(:note_field).should be_true
     elements.include?(:note_type_selector).should be_true
   end
-end
+end

data/spec/olefs/invoice_notes_line_spec.rb

@@ -24,6 +24,10 @@ describe 'An OLEFS Invoice Notes Line object' do
     @new_invoice_notes = OLE_QA::Framework::OLEFS::New_Invoice_Notes_Line.new(@ole, 1, 0)
   end
 
+	after :all do
+		@ole.quit
+	end
+
   it 'should create a new instance' do
     @invoice_notes.class.should == OLE_QA::Framework::OLEFS::Invoice_Notes_Line
     @invoice_notes.class.superclass.should == OLE_QA::Framework::Subline_Object
@@ -42,4 +46,4 @@ describe 'An OLEFS Invoice Notes Line object' do
     methods.include?(:note_field).should be_true
     methods.include?(:add_button).should be_true
   end
-end
+end

data/spec/olefs/line_item_spec.rb

@@ -25,6 +25,10 @@ describe 'An OLEFS line item' do
     @new_line_item = OLE_QA::Framework::OLEFS::New_Line_Item.new(@ole, @line_number)
   end
 
+	after :all do
+		@ole.quit
+	end
+
   it 'should should create a new instance' do
     @line_item.class.should == OLE_QA::Framework::OLEFS::Line_Item
     @new_line_item.class.should == OLE_QA::Framework::OLEFS::New_Line_Item
@@ -152,4 +156,4 @@ describe 'An OLEFS line item' do
     lambda {@line_item.remove_notes_line(1)}.should raise_error
     lambda {@line_item.remove_copies_line(1)}.should raise_error
   end
-end
+end

data/spec/olefs/load_report_spec.rb

@@ -22,6 +22,10 @@ describe 'My behaviour' do
     @page = OLE_QA::Framework::OLEFS::Load_Report.new(@ole)
   end
 
+	after :all do
+		@ole.quit
+	end
+
   it 'should create a new instance' do
     @page.should be_an_instance_of(OLE_QA::Framework::OLEFS::Load_Report)
     @page.class.superclass.should == OLE_QA::Framework::OLEFS::E_Doc
@@ -49,4 +53,4 @@ describe 'My behaviour' do
     functions.should include(:upload_date_ymd)
     functions.should include(:upload_date_tod)
   end
-end
+end

data/spec/olefs/load_summary_lookup_spec.rb

@@ -22,6 +22,10 @@ describe 'An OLEFS Load Summary Lookup page' do
     @page = OLE_QA::Framework::OLEFS::Load_Summary_Lookup.new(@ole)
   end
 
+	after :all do
+	  @ole.quit
+  end
+
   it 'should create a new instance' do
     @page.should be_an_instance_of(OLE_QA::Framework::OLEFS::Load_Summary_Lookup)
     @page.class.superclass.should == OLE_QA::Framework::OLEFS::Lookup
@@ -46,4 +50,4 @@ describe 'An OLEFS Load Summary Lookup page' do
     @page.open
     @page.title.text.strip.should == 'Load Summary Lookup'
   end
-end
+end

data/spec/olefs/preq_creation_spec.rb

@@ -22,6 +22,10 @@ describe 'An OLEFS Payment Request Creation page' do
     @preq_screen = OLE_QA::Framework::OLEFS::PREQ_Creation.new(@ole)
   end
 
+  after :all do
+    @ole.quit
+  end
+
   it 'should create a new instance' do
     @preq_screen.class.should == OLE_QA::Framework::OLEFS::PREQ_Creation
     @preq_screen.class.superclass.should == OLE_QA::Framework::OLEFS::E_Doc
@@ -40,4 +44,4 @@ describe 'An OLEFS Payment Request Creation page' do
     elements.include?(:continue_button).should be_true
     elements.include?(:clear_button).should be_true
   end
-end
+end

data/spec/olels/bib_editor_spec.rb

@@ -34,7 +34,6 @@ describe 'The Bib Editor' do
 
   it 'should have bib editor elements' do
     elements = @bib_editor.elements
-    elements.include?(:message).should be_true
     elements.include?(:leader_field).should be_true
     elements.include?(:bib_record_status_selector).should be_true
     elements.include?(:set_button).should be_true
@@ -58,6 +57,10 @@ describe 'The Bib Editor' do
     elements.include?(:control_008_field).should be_true
   end
 
+  it 'should have bib editor functions' do
+    functions = @bib_editor.functions
+  end
+
   it 'should start with one data line added' do
     @bib_editor.data_line_1.class.should == OLE_QA::Framework::OLELS::Data_Line
   end

data/spec/olels/describe_workbench_spec.rb

@@ -22,6 +22,10 @@ describe 'An OLELS Describe Workbench page' do
     @workbench = OLE_QA::Framework::OLELS::Describe_Workbench.new(@ole)
   end
 
+  after :all do
+    @ole.quit
+  end
+
   it 'should create a new instance' do
     @workbench.class.should == OLE_QA::Framework::OLELS::Describe_Workbench
     @workbench.class.superclass.should == OLE_QA::Framework::OLELS::Lookup
@@ -41,4 +45,4 @@ describe 'An OLELS Describe Workbench page' do
     elements.include?(:search_which_selector_1).should be_true
     elements.include?(:search_field_selector_1).should be_true
   end
-end
+end

data/spec/olels/editor_spec.rb

@@ -43,6 +43,9 @@ describe 'The Editor base class' do
   it 'should have editor elements' do
     elements = @editor.elements
     elements.include?(:title).should be_true
+    elements.should include(:message)
+    elements.should include(:messages)
+    elements.should include(:message_header)
     elements.include?(:submit_button).should be_true
     elements.include?(:cancel_button).should be_true
     elements.include?(:close_button).should be_true
@@ -60,6 +63,7 @@ describe 'The Editor base class' do
     functions.include?(:holdings_link).should be_true
     functions.include?(:holdings_icon).should be_true
     functions.include?(:item_link).should be_true
+    functions.should include(:message_count)
   end
 
   it 'should wait for a title to be present' do

data/spec/olels/edocs_spec.rb

@@ -37,6 +37,14 @@ describe 'An OLELS E-Document' do
   end
 
   it 'should have e-document elements' do
-    # None yet.
+    elements = @edoc.elements
+    elements.should include(:title)
+    elements.should include(:description_field)
+    elements.should include(:explanation_field)
+    elements.should include(:org_doc_number_field)
+    elements.should include(:document_id)
+    elements.should include(:document_status)
+    elements.should include(:initiator_id)
+    elements.should include(:creation_timestamp)
   end
 end

data/spec/olels/item_editor_spec.rb

@@ -23,6 +23,10 @@ describe 'An OLELS Item Editor page' do
     @item_editor = OLE_QA::Framework::OLELS::Item_Editor.new(@ole)
   end
 
+  after :all do
+    @ole.quit
+  end
+
   it 'should create a new instance' do
     @item_editor.class.should == OLE_QA::Framework::OLELS::Item_Editor
     @item_editor.class.superclass.should == OLE_QA::Framework::OLELS::Editor
@@ -30,9 +34,6 @@ describe 'An OLELS Item Editor page' do
 
   it 'should have item editor elements' do
     elements = @item_editor.methods
-    # Messages Elements
-    elements.include?(:message).should be_true
-    elements.include?(:messages).should be_true
     # Holdings Location/Call Number Information
     elements.include?(:holdings_location_field).should be_true
     elements.include?(:holdings_prefix_field).should be_true
@@ -91,4 +92,4 @@ describe 'An OLELS Item Editor page' do
     @item_editor.remove_item_note(2)
     @item_editor.methods.include?(:item_note_2).should be_false
   end
-end
+end

data/spec/olels/patron_address_line_spec.rb

@@ -0,0 +1,55 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+require 'rspec'
+require 'spec_helper'
+
+describe 'A patron address line' do
+
+  before :all do
+    @ole = OLE_QA::Framework::Session.new
+    @line_1 = OLE_QA::Framework::OLELS::Patron_Address_Line.new(@ole, 1)
+    @line_2 = OLE_QA::Framework::OLELS::Patron_Address_Line.new(@ole, 2)
+  end
+
+  after :all do
+    @ole.quit
+  end
+
+  it 'should create a new instance' do
+    @line_1.should be_an_instance_of(OLE_QA::Framework::OLELS::Patron_Address_Line)
+    @line_1.class.superclass.should == OLE_QA::Framework::OLELS::Line_Object
+  end
+
+  it 'should have address line elements' do
+    elements = @line_1.elements
+    elements.should include(:details_link)
+    elements.should include(:address_type_selector)
+    elements.should include(:address_source_selector)
+    elements.should include(:valid_from_date_field)
+    elements.should include(:valid_to_date_field)
+    elements.should include(:verified_checkbox)
+    elements.should include(:preferred_checkbox)
+    elements.should include(:active_checkbox)
+    elements.should include(:line_1_field)
+    elements.should include(:line_2_field)
+    elements.should include(:line_3_field)
+    elements.should include(:city_field)
+    elements.should include(:state_selector)
+    elements.should include(:postal_code_field)
+    elements.should include(:country_selector)
+    elements.should include(:add_button)
+    elements.should include(:delete_button)
+  end
+end

data/spec/olels/patron_email_line_spec.rb

@@ -0,0 +1,44 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+require 'rspec'
+require 'spec_helper'
+
+describe 'A patron email line' do
+  before :all do
+    @ole = OLE_QA::Framework::Session.new
+    @line_1 = OLE_QA::Framework::OLELS::Patron_Email_Line.new(@ole,1)
+    @line_2 = OLE_QA::Framework::OLELS::Patron_Email_Line.new(@ole,2)
+  end
+
+  after :all do
+    @ole.quit
+  end
+
+  it 'should create a new instance' do
+    @line_1.should be_an_instance_of(OLE_QA::Framework::OLELS::Patron_Email_Line)
+    @line_2.should be_an_instance_of(OLE_QA::Framework::OLELS::Patron_Email_Line)
+    @line_1.class.superclass.should == OLE_QA::Framework::OLELS::Line_Object
+  end
+
+  it 'should have email line elements' do
+    elements = @line_1.elements
+    elements.should include(:email_type_selector)
+    elements.should include(:email_address_field)
+    elements.should include(:preferred_checkbox)
+    elements.should include(:active_checkbox)
+    elements.should include(:add_button)
+    elements.should include(:delete_button)
+  end
+end

data/spec/olels/patron_phone_line_spec.rb

@@ -0,0 +1,47 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+require 'rspec'
+require 'spec_helper'
+
+describe 'My behaviour' do
+
+  before :all do
+    @ole = OLE_QA::Framework::Session.new
+    @line_1 = OLE_QA::Framework::OLELS::Patron_Phone_Line.new(@ole,1)
+    @line_2 = OLE_QA::Framework::OLELS::Patron_Phone_Line.new(@ole,2)
+  end
+
+  after :all do
+    @ole.quit
+  end
+
+  it 'should create a new instance' do
+    @line_1.should be_an_instance_of(OLE_QA::Framework::OLELS::Patron_Phone_Line)
+    @line_2.should be_an_instance_of(OLE_QA::Framework::OLELS::Patron_Phone_Line)
+    @line_1.class.superclass.should == OLE_QA::Framework::OLELS::Line_Object
+  end
+
+  it 'should have patron phone line elements' do
+    elements = @line_1.elements
+    elements.should include(:phone_type_selector)
+    elements.should include(:phone_number_field)
+    elements.should include(:extension_field)
+    elements.should include(:country_selector)
+    elements.should include(:preferred_checkbox)
+    elements.should include(:active_checkbox)
+    elements.should include(:add_button)
+    elements.should include(:delete_button)
+  end
+end

data/spec/olels/patron_spec.rb

@@ -0,0 +1,125 @@
+#  Copyright 2005-2013 The Kuali Foundation
+#
+#  Licensed under the Educational Community License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at:
+#
+#    http://www.opensource.org/licenses/ecl2.php
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+require 'rspec'
+require 'spec_helper'
+
+describe 'A patron record page' do
+
+  before :all do
+    @ole = OLE_QA::Framework::Session.new
+    @page = OLE_QA::Framework::OLELS::Patron.new(@ole)
+  end
+
+  after :all do
+    @ole.quit
+  end
+
+  it 'should create a new instance' do
+    @page.should be_an_instance_of(OLE_QA::Framework::OLELS::Patron)
+    @page.class.superclass.should == OLE_QA::Framework::OLELS::E_Doc
+  end
+
+  it 'should have patron elements' do
+    elements = @page.elements
+    elements.should include(:patron_id)
+    elements.should include(:barcode_field)
+    elements.should include(:borrower_type_selector)
+    elements.should include(:source_selector)
+    elements.should include(:patron_image_field)
+    elements.should include(:upload_image_button)
+    elements.should include(:statistical_category_selector)
+    elements.should include(:activation_date_field)
+    elements.should include(:expiration_date_field)
+    elements.should include(:active_checkbox)
+    elements.should include(:name_type)
+    elements.should include(:title_selector)
+    elements.should include(:first_name_field)
+    elements.should include(:last_name_field)
+    elements.should include(:middle_name_field)
+    elements.should include(:suffix_selector)
+    elements.should include(:affiliation_toggle)
+    elements.should include(:library_policies_toggle)
+    elements.should include(:loaned_records_toggle)
+    elements.should include(:requested_records_toggle)
+    elements.should include(:temp_circ_history_toggle)
+    elements.should include(:note_toggle)
+    elements.should include(:proxy_patron_toggle)
+    elements.should include(:proxy_for_toggle)
+    elements.should include(:local_id_toggle)
+    elements.should include(:lost_barcode_toggle)
+    elements.should include(:ad_hoc_toggle)
+    elements.should include(:route_log_toggle)
+    elements.should include(:contacts_toggle)
+    elements.should include(:overview_toggle)
+    elements.should include(:name_toggle)
+    elements.should include(:address_toggle)
+    elements.should include(:phone_toggle)
+    elements.should include(:email_toggle)
+  end
+
+  it 'should have patron functions' do
+    functions = @page.functions
+    functions.should include(:redefine_patron_image_elements)
+  end
+
+  it 'should have contact info lines' do
+    all_methods = @page.methods
+    all_methods.should include(:address_line_1)
+    all_methods.should include(:phone_line_1)
+    all_methods.should include(:email_line_1)
+    all_methods.should include(:add_address_line)
+    all_methods.should include(:add_phone_line)
+    all_methods.should include(:add_email_line)
+    all_methods.should include(:remove_address_line)
+    all_methods.should include(:remove_phone_line)
+    all_methods.should include(:remove_email_line)
+  end
+
+  it 'should add contact info lines' do
+    @page.add_address_line(2)
+    @page.add_phone_line(2)
+    @page.add_email_line(2)
+    methods = @page.methods
+    methods.should include(:address_line_2)
+    methods.should include(:phone_line_2)
+    methods.should include(:email_line_2)
+    @page.address_line_2.should be_an_instance_of(OLE_QA::Framework::OLELS::Patron_Address_Line)
+    @page.phone_line_2.should   be_an_instance_of(OLE_QA::Framework::OLELS::Patron_Phone_Line)
+    @page.email_line_2.should   be_an_instance_of(OLE_QA::Framework::OLELS::Patron_Email_Line)
+  end
+
+  it 'should remove contact info lines' do
+    @page.remove_address_line(2)
+    @page.remove_phone_line(2)
+    @page.remove_email_line(2)
+    methods = @page.methods
+    methods.should_not include(:address_line_2)
+    methods.should_not include(:phone_line_2)
+    methods.should_not include(:email_line_2)
+  end
+
+  it 'should not remove contact info lines which do not exist' do
+    lambda {@page.remove_address_line(2)}.should  raise_error
+    lambda {@page.remove_phone_line(2)}.should    raise_error
+    lambda {@page.remove_email_line(2)}.should    raise_error
+  end
+
+  it 'should open the page via URL' do
+    @ole.open
+    @page.login('admin').should be_true
+    @page.open
+    @page.title.when_present.text.strip.should == 'Patron'
+  end
+end

data/spec/spec_helper.rb

@@ -18,4 +18,4 @@ require "watir-webdriver"
 require "headless"
 require "open-uri"
 
-require 'lib/ole-qa-framework'
+require 'lib/ole-qa-framework'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ole-qa-framework
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.5.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-30 00:00:00.000000000 Z
+date: 2013-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -183,12 +183,16 @@ files:
 - lib/olels/objects/holdings_note.rb
 - lib/olels/objects/item_note.rb
 - lib/olels/objects/ownership_extent_line.rb
+- lib/olels/objects/patron_address_line.rb
+- lib/olels/objects/patron_email_line.rb
+- lib/olels/objects/patron_phone_line.rb
 - lib/olels/pages/bib_editor.rb
 - lib/olels/pages/describe_workbench.rb
 - lib/olels/pages/instance_editor.rb
 - lib/olels/pages/item_editor.rb
 - lib/olels/pages/loan.rb
 - lib/olels/pages/main_menu.rb
+- lib/olels/pages/patron.rb
 - lib/olels/pages/patron_lookup.rb
 - lib/olels/pages/return.rb
 - lib/olels/pages/staff_upload.rb
@@ -238,7 +242,11 @@ files:
 - spec/olels/main_menu_spec.rb
 - spec/olels/ownership_extent_line_spec.rb
 - spec/olels/ownership_note_spec.rb
+- spec/olels/patron_address_line_spec.rb
+- spec/olels/patron_email_line_spec.rb
 - spec/olels/patron_lookup_spec.rb
+- spec/olels/patron_phone_line_spec.rb
+- spec/olels/patron_spec.rb
 - spec/olels/return_spec.rb
 - spec/olels/staff_upload_spec.rb
 - spec/spec_helper.rb
@@ -313,7 +321,11 @@ test_files:
 - spec/olels/main_menu_spec.rb
 - spec/olels/ownership_extent_line_spec.rb
 - spec/olels/ownership_note_spec.rb
+- spec/olels/patron_address_line_spec.rb
+- spec/olels/patron_email_line_spec.rb
 - spec/olels/patron_lookup_spec.rb
+- spec/olels/patron_phone_line_spec.rb
+- spec/olels/patron_spec.rb
 - spec/olels/return_spec.rb
 - spec/olels/staff_upload_spec.rb
 - spec/spec_helper.rb