oj 3.14.3 → 3.15.0

data/test/sample.rb

@@ -1,10 +1,11 @@
 #!/usr/bin/env ruby -wW2
+# frozen_string_literal: true
 
-if $0 == __FILE__
-  $: << '.'
-  $: << '..'
-  $: << '../lib'
-  $: << '../ext'
+if $PROGRAM_NAME == __FILE__
+  $LOAD_PATH << '.'
+  $LOAD_PATH << '..'
+  $LOAD_PATH << '../lib'
+  $LOAD_PATH << '../ext'
 end
 
 require 'sample/doc'
@@ -12,7 +13,7 @@ require 'sample/doc'
 def sample_doc(size=3)
   colors = [ :black, :gray, :white, :red, :blue, :yellow, :green, :purple, :orange ]
 
-  d = ::Sample::Doc.new('Sample')
+  d = Sample::Doc.new('Sample')
 
   # add some history
   (0..size * 10).each do |i|
@@ -21,22 +22,22 @@ def sample_doc(size=3)
 
   # add some layers
   (1..size).each do |i|
-    layer = ::Sample::Layer.new("Layer-#{i}")
+    layer = Sample::Layer.new("Layer-#{i}")
     (1..size).each do |j|
-      g = ::Sample::Group.new
+      g = Sample::Group.new
       (1..size).each do |k|
-        g2 = ::Sample::Group.new
-        r = ::Sample::Rect.new((j * 40) + 10.0, i * 10.0,
-                               10.123456 / k, 10.0 / k, colors[(i + j + k) % colors.size])
+        g2 = Sample::Group.new
+        r = Sample::Rect.new((j * 40) + 10.0, i * 10.0,
+                             10.123456 / k, 10.0 / k, colors[(i + j + k) % colors.size])
         r.add_prop(:part_of, layer.name)
         g2 << r
-        g2 << ::Sample::Text.new("#{k} in #{j}", r.left, r.top, r.width, r.height)
+        g2 << Sample::Text.new("#{k} in #{j}", r.left, r.top, r.width, r.height)
         g << g2
       end
-      g2 = ::Sample::Group.new
+      g2 = Sample::Group.new
       (1..size).each do |k|
-        o = ::Sample::Oval.new((j * 40) + 12.0, (i * 10.0) + 2.0,
-                               6.0 / k, 6.0 / k, colors[(i + j + k) % colors.size])
+        o = Sample::Oval.new((j * 40) + 12.0, (i * 10.0) + 2.0,
+                             6.0 / k, 6.0 / k, colors[(i + j + k) % colors.size])
         o.add_prop(:inside, true)
         g << o
       end

data/test/sample_json.rb

@@ -1,10 +1,11 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-if $0 == __FILE__
-  $: << '.'
-  $: << '..'
-  $: << '../lib'
-  $: << '../ext'
+if $PROGRAM_NAME == __FILE__
+  $LOAD_PATH << '.'
+  $LOAD_PATH << '..'
+  $LOAD_PATH << '../lib'
+  $LOAD_PATH << '../ext'
 end
 
 require 'oj'
@@ -31,6 +32,6 @@ def sample_json(size=3)
   container
 end
 
-if $0 == __FILE__
-  File.open('sample.json', "w") { |f| f.write(Oj.dump(sample_json(3), :indent => 2)) }
+if $PROGRAM_NAME == __FILE__
+  File.write('sample.json', Oj.dump(sample_json(3), :indent => 2))
 end

data/test/test_compat.rb

@@ -1,10 +1,10 @@
 #!/usr/bin/env ruby
-# encoding: utf-8
+# frozen_string_literal: true
 
-$: << File.dirname(__FILE__)
-$oj_dir = File.dirname(File.expand_path(File.dirname(__FILE__)))
+$LOAD_PATH << __dir__
+@oj_dir = File.dirname(File.expand_path(__dir__))
 %w(lib ext).each do |dir|
-  $: << File.join($oj_dir, dir)
+  $LOAD_PATH << File.join(@oj_dir, dir)
 end
 
 require 'minitest'
@@ -29,18 +29,16 @@ class CompatJuice < Minitest::Test
     end
     alias == eql?
 
-    def to_json(*a)
+    def to_json(*_a)
       %|{"json_class":"#{self.class}","x":#{@x},"y":#{@y}}|
     end
 
     def self.json_create(h)
-      self.new(h['x'], h['y'])
+      new(h['x'], h['y'])
     end
   end # Jeez
 
   class Argy
-    def initialize()
-    end
 
     def to_json(*a)
       %|{"args":"#{a}"}|
@@ -48,10 +46,8 @@ class CompatJuice < Minitest::Test
   end # Argy
 
   class Stringy
-    def initialize()
-    end
 
-    def to_s()
+    def to_s
       %|[1,2]|
     end
   end # Stringy
@@ -61,20 +57,17 @@ class CompatJuice < Minitest::Test
       module Three
         class Deep
 
-          def initialize()
-          end
-
           def eql?(o)
             self.class == o.class
           end
           alias == eql?
 
-          def to_json(*a)
+          def to_json(*_a)
             %|{"json_class":"#{self.class.name}"}|
           end
 
-          def self.json_create(h)
-            self.new()
+          def self.json_create(_h)
+            new()
           end
         end # Deep
       end # Three
@@ -106,24 +99,30 @@ class CompatJuice < Minitest::Test
 
   def test_fixnum
     dump_and_load(0, false)
-    dump_and_load(12345, false)
-    dump_and_load(-54321, false)
+    dump_and_load(12_345, false)
+    dump_and_load(-54_321, false)
     dump_and_load(1, false)
   end
 
+  def test_fixnum_array
+    data = (1..1000).to_a
+    json = Oj.dump(data, mode: :compat)
+    assert_equal("[#{data.join(',')}]", json)
+  end
+
   def test_float
     dump_and_load(0.0, false)
     dump_and_load(0.56, false)
     dump_and_load(3.0, false)
-    dump_and_load(12345.6789, false)
+    dump_and_load(12_345.6789, false)
     dump_and_load(70.35, false)
-    dump_and_load(-54321.012, false)
+    dump_and_load(-54_321.012, false)
     dump_and_load(1.7775, false)
     dump_and_load(2.5024, false)
     dump_and_load(2.48e16, false)
     dump_and_load(2.48e100 * 1.0e10, false)
     dump_and_load(-2.48e100 * 1.0e10, false)
-    dump_and_load(1405460727.723866, false)
+    dump_and_load(1_405_460_727.723866, false)
     dump_and_load(0.5773, false)
     dump_and_load(0.6768, false)
     dump_and_load(0.685, false)
@@ -148,7 +147,7 @@ class CompatJuice < Minitest::Test
   def test_encode
     opts = Oj.default_options
     Oj.default_options = { :ascii_only => true }
-    json = Oj.dump("ぴーたー")
+    json = Oj.dump('ぴーたー')
     assert_equal(%{"\\u3074\\u30fc\\u305f\\u30fc"}, json)
     Oj.default_options = opts
   end
@@ -179,8 +178,8 @@ class CompatJuice < Minitest::Test
   end
 
   def test_time_xml_schema
-    t = Time.xmlschema("2012-01-05T23:58:07.123456000+09:00")
-    #t = Time.local(2012, 1, 5, 23, 58, 7, 123456)
+    t = Time.xmlschema('2012-01-05T23:58:07.123456000+09:00')
+    # t = Time.local(2012, 1, 5, 23, 58, 7, 123456)
     json = Oj.dump(t, :mode => :compat)
     assert_equal(%{"2012-01-05 23:58:07 +0900"}, json)
   end
@@ -199,8 +198,9 @@ class CompatJuice < Minitest::Test
   def test_non_str_hash
     json = Oj.dump({ 1 => true, 0 => false }, :mode => :compat)
     h = Oj.load(json, :mode => :strict)
-    assert_equal({ "1" => true, "0" => false }, h)
+    assert_equal({ '1' => true, '0' => false }, h)
   end
+
   def test_hash
     dump_and_load({}, false)
     dump_and_load({ 'true' => true, 'false' => false}, false)
@@ -239,12 +239,12 @@ class CompatJuice < Minitest::Test
   def test_invalid_escapes_handled
     json = '{"subtext":"\"404er\” \w \k \3 \a"}'
     obj = Oj.compat_load(json)
-    assert_equal({"subtext" => "\"404er” w k 3 a"}, obj)
+    assert_equal({'subtext' => '"404er” w k 3 a'}, obj)
   end
 
   def test_hash_escaping
     json = Oj.to_json({'<>' => '<>'}, mode: :compat)
-    assert_equal(json, '{"<>":"<>"}')
+    assert_equal('{"<>":"<>"}', json)
   end
 
   def test_bignum_object
@@ -271,7 +271,7 @@ class CompatJuice < Minitest::Test
   def test_bignum_compat
     json = Oj.dump(7 ** 55, :mode => :compat)
     b = Oj.load(json, :mode => :strict)
-    assert_equal(30226801971775055948247051683954096612865741943, b)
+    assert_equal(30_226_801_971_775_055_948_247_051_683_954_096_612_865_741_943, b)
   end
 
   # BigDecimal
@@ -313,7 +313,7 @@ class CompatJuice < Minitest::Test
     if x.is_a?(String)
       assert_equal(orig.to_s, x)
     else # better be a Hash
-      assert_equal({"year" => orig.year, "month" => orig.month, "day" => orig.day, "start" => orig.start}, x)
+      assert_equal({'year' => orig.year, 'month' => orig.month, 'day' => orig.day, 'start' => orig.start}, x)
     end
   end
 
@@ -340,15 +340,13 @@ class CompatJuice < Minitest::Test
   end
 
   def test_io_file
-    filename = File.join(File.dirname(__FILE__), 'open_file_test.json')
-    File.open(filename, 'w') { |f|
-      f.write(%{{
+    filename = File.join(__dir__, 'open_file_test.json')
+    File.write(filename, %{{
   "x":true,
   "y":58,
   "z": [1,2,3]
 }
 })
-    }
     f = File.new(filename)
     obj = Oj.compat_load(f)
     f.close()
@@ -412,7 +410,7 @@ class CompatJuice < Minitest::Test
 
   # A child to_json should not be called.
   def test_json_object_child
-    obj = { "child" => Jeez.new(true, 58) }
+    obj = { 'child' => Jeez.new(true, 58) }
     assert_equal('{"child":{"json_class":"CompatJuice::Jeez","x":true,"y":58}}', Oj.dump(obj))
   end
 
@@ -433,10 +431,10 @@ class CompatJuice < Minitest::Test
     begin
       Oj.compat_load(json, :create_additions => true)
     rescue Exception => e
-      assert_equal("ArgumentError", e.class().name)
+      assert_equal('ArgumentError', e.class().name)
       return
     end
-    assert(false, "*** expected an exception")
+    assert(false, '*** expected an exception')
   end
 
   def test_json_object_create_cache
@@ -452,7 +450,7 @@ class CompatJuice < Minitest::Test
     expected = Jeez.new(true, 58)
     json = Oj.to_json(expected)
     json.gsub!('json_class', '_class_')
-    obj = Oj.compat_load(json, :create_id => "_class_", :create_additions => true)
+    obj = Oj.compat_load(json, :create_id => '_class_', :create_additions => true)
     assert_equal(expected, obj)
   end
 
@@ -492,10 +490,10 @@ class CompatJuice < Minitest::Test
 
   def test_parse_large_string
     error = assert_raises() { Oj.load(%|{"a":"aaaaaaaaaa\0aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"}|) }
-    assert(error.message.include?('NULL byte in string'))
+    assert_includes(error.message, 'NULL byte in string')
 
     error = assert_raises() { Oj.load(%|{"a":"aaaaaaaaaaaaaaaaaaaa                       }|) }
-    assert(error.message.include?('quoted string not terminated'))
+    assert_includes(error.message, 'quoted string not terminated')
 
     json =<<~JSON
       {
@@ -503,15 +501,15 @@ class CompatJuice < Minitest::Test
         "b": "aaaaaaaaaaaaaaaaaaaaaaaaaaaa"
       }
     JSON
-    assert_equal("ぴーたー", Oj.load(json)['a'])
+    assert_equal('ぴーたー', Oj.load(json)['a'])
   end
 
   def test_parse_large_escaped_string
-    invalid_json = %|{"a":\"aaaa\\nbbbb\\rcccc\\tddd\\feee\\bf\/\\\\\\u3074\\u30fc\\u305f\\u30fc                             }|
+    invalid_json = %|{"a":"aaaa\\nbbbb\\rcccc\\tddd\\feee\\bf/\\\\\\u3074\\u30fc\\u305f\\u30fc                             }|
     error = assert_raises() { Oj.load(invalid_json) }
-    assert(error.message.include?('quoted string not terminated'))
+    assert_includes(error.message, 'quoted string not terminated')
 
-    json = "\"aaaa\\nbbbb\\rcccc\\tddd\\feee\\bf\/\\\\\\u3074\\u30fc\\u305f\\u30fc             \""
+    json = '"aaaa\\nbbbb\\rcccc\\tddd\\feee\\bf/\\\\\\u3074\\u30fc\\u305f\\u30fc             "'
     assert_equal("aaaa\nbbbb\rcccc\tddd\feee\bf/\\ぴーたー             ", Oj.load(json))
   end
 
@@ -527,7 +525,7 @@ class CompatJuice < Minitest::Test
   def dump_and_load(obj, trace=false)
     json = Oj.dump(obj)
     puts json if trace
-    loaded = Oj.compat_load(json, :create_additions => true);
+    loaded = Oj.compat_load(json, :create_additions => true)
     if obj.nil?
       assert_nil(loaded)
     else
@@ -539,7 +537,7 @@ class CompatJuice < Minitest::Test
   def dump_to_json_and_load(obj, trace=false)
     json = Oj.to_json(obj, :indent => '  ')
     puts json if trace
-    loaded = Oj.compat_load(json, :create_additions => true);
+    loaded = Oj.compat_load(json, :create_additions => true)
     if obj.nil?
       assert_nil(loaded)
     else

data/test/test_custom.rb

@@ -1,10 +1,10 @@
 #!/usr/bin/env ruby
-# encoding: utf-8
+# frozen_string_literal: true
 
-$: << File.dirname(__FILE__)
-$oj_dir = File.dirname(File.expand_path(File.dirname(__FILE__)))
+$LOAD_PATH << __dir__
+@oj_dir = File.dirname(File.expand_path(__dir__))
 %w(lib ext).each do |dir|
-  $: << File.join($oj_dir, dir)
+  $LOAD_PATH << File.join(@oj_dir, dir)
 end
 
 require 'minitest'
@@ -27,19 +27,24 @@ class CustomJuice < Minitest::Test
       @y = y
       @_z = x.to_s
     end
+
     def ==(o)
       self.class == o.class && @x == o.x && @y = o.y
     end
-    def to_json(*args)
+
+    def to_json(*_args)
       %|{"xx":#{@x},"yy":#{y}}|
     end
-    def raw_json(depth, indent)
+
+    def raw_json(_depth, _indent)
       %|{"xxx":#{@x},"yyy":#{y}}|
     end
-    def as_json(*args)
+
+    def as_json(*_args)
       {'a' => @x, :b => @y }
     end
-    def to_hash()
+
+    def to_hash
       {'b' => @x, 'n' => @y }
     end
   end
@@ -51,10 +56,12 @@ class CustomJuice < Minitest::Test
       @x = x
       @y = y
     end
+
     def ==(o)
       self.class == o.class && @x == o.x && @y = o.y
     end
-    def as_json(*args)
+
+    def as_json(*_args)
       {'a' => @x, :b => @y }
     end
   end
@@ -66,10 +73,12 @@ class CustomJuice < Minitest::Test
       @x = x
       @y = y
     end
+
     def ==(o)
       self.class == o.class && @x == o.x && @y = o.y
     end
-    def as_json(*args)
+
+    def as_json(*_args)
       a = @x
       a = a.as_json if a.respond_to?('as_json')
       b = @y
@@ -101,16 +110,16 @@ class CustomJuice < Minitest::Test
 
   def test_fixnum
     dump_and_load(0, false)
-    dump_and_load(12345, false)
-    dump_and_load(-54321, false)
+    dump_and_load(12_345, false)
+    dump_and_load(-54_321, false)
     dump_and_load(1, false)
   end
 
   def test_float
     dump_and_load(0.0, false)
-    dump_and_load(12345.6789, false)
+    dump_and_load(12_345.6789, false)
     dump_and_load(70.35, false)
-    dump_and_load(-54321.012, false)
+    dump_and_load(-54_321.012, false)
     dump_and_load(1.7775, false)
     dump_and_load(2.5024, false)
     dump_and_load(2.48e16, false)
@@ -119,12 +128,12 @@ class CustomJuice < Minitest::Test
   end
 
   def test_float_parse
-    f = Oj.load("12.123456789012345678", mode: :custom, bigdecimal_load: :float);
+    f = Oj.load('12.123456789012345678', mode: :custom, bigdecimal_load: :float)
     assert_equal(Float, f.class)
   end
 
   def test_float_parse_fast
-    f = Oj.load("12.123456789012345678", mode: :custom, bigdecimal_load: :fast);
+    f = Oj.load('12.123456789012345678', mode: :custom, bigdecimal_load: :fast)
     assert_equal(Float, f.class)
     assert(12.12345678901234 <= f && f < 12.12345678901236)
   end
@@ -139,7 +148,7 @@ class CustomJuice < Minitest::Test
       assert(true)
       return
     end
-    assert(false, "*** expected an exception")
+    assert(false, '*** expected an exception')
   end
 
   def test_infinity_dump
@@ -152,7 +161,7 @@ class CustomJuice < Minitest::Test
       assert(true)
       return
     end
-    assert(false, "*** expected an exception")
+    assert(false, '*** expected an exception')
   end
 
   def test_neg_infinity_dump
@@ -165,7 +174,7 @@ class CustomJuice < Minitest::Test
       assert(true)
       return
     end
-    assert(false, "*** expected an exception")
+    assert(false, '*** expected an exception')
   end
 
   def test_string
@@ -176,15 +185,15 @@ class CustomJuice < Minitest::Test
   end
 
   def test_string_ascii
-    json = Oj.dump("ぴーたー", :escape_mode => :ascii)
+    json = Oj.dump('ぴーたー', :escape_mode => :ascii)
     assert_equal(%{"\\u3074\\u30fc\\u305f\\u30fc"}, json)
-    dump_and_load("ぴーたー", false, :escape_mode => :ascii)
+    dump_and_load('ぴーたー', false, :escape_mode => :ascii)
   end
 
   def test_string_json
-    json = Oj.dump("ぴーたー", :escape_mode => :json)
+    json = Oj.dump('ぴーたー', :escape_mode => :json)
     assert_equal(%{"ぴーたー"}, json)
-    dump_and_load("ぴーたー", false, :escape_mode => :json)
+    dump_and_load('ぴーたー', false, :escape_mode => :json)
   end
 
   def test_array
@@ -203,10 +212,10 @@ class CustomJuice < Minitest::Test
     skip 'TruffleRuby causes SEGV' if RUBY_ENGINE == 'truffleruby'
 
     begin
-      n = 10000
+      n = 10_000
       Oj.strict_load(('[' * n) + (']' * n))
     rescue Exception => e
-      assert(false, e.message)
+      refute(e.message)
     end
   end
 
@@ -261,11 +270,11 @@ class CustomJuice < Minitest::Test
 
   def test_object
     obj = Jeez.new(true, 58)
-    json = Oj.dump(obj, create_id: "^o", use_to_json: false, use_as_json: false, use_to_hash: false)
+    json = Oj.dump(obj, create_id: '^o', use_to_json: false, use_as_json: false, use_to_hash: false)
     assert_equal(%|{"x":true,"y":58,"_z":"true"}|, json)
-    json = Oj.dump(obj, create_id: "^o", use_to_json: false, use_as_json: false, use_to_hash: false, ignore_under: true)
+    json = Oj.dump(obj, create_id: '^o', use_to_json: false, use_as_json: false, use_to_hash: false, ignore_under: true)
     assert_equal(%|{"x":true,"y":58}|, json)
-    dump_and_load(obj, false, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :create_id => '^o', :create_additions => true)
   end
 
   def test_object_to_json
@@ -393,24 +402,29 @@ class CustomJuice < Minitest::Test
     assert_equal(%|{"x":{"a":1}}|, json)
   end
 
+  def test_omit_null_byte
+    json = Oj.dump({ "fo\x00o" => "b\x00ar" }, :omit_null_byte => true)
+    assert_equal(%|{"foo":"bar"}|, json)
+  end
+
   def test_complex
     obj = Complex(2, 9)
-    dump_and_load(obj, false, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :create_id => '^o', :create_additions => true)
   end
 
   def test_rational
     obj = Rational(2, 9)
-    dump_and_load(obj, false, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :create_id => '^o', :create_additions => true)
   end
 
   def test_range
     obj = 3..8
-    dump_and_load(obj, false, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :create_id => '^o', :create_additions => true)
   end
 
   def test_date
     obj = Date.new(2017, 1, 5)
-    dump_and_load(obj, false, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :create_id => '^o', :create_additions => true)
   end
 
   def test_date_unix
@@ -439,7 +453,7 @@ class CustomJuice < Minitest::Test
 
   def test_datetime
     obj = DateTime.new(2017, 1, 5, 10, 20, 30)
-    dump_and_load(obj, false, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :create_id => '^o', :create_additions => true)
   end
 
   def test_datetime_unix
@@ -469,12 +483,12 @@ class CustomJuice < Minitest::Test
   def test_regexp
     # this notation must be used to get an == match later
     obj = /(?ix-m:^yes$)/
-    dump_and_load(obj, false, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :create_id => '^o', :create_additions => true)
   end
 
   def test_openstruct
     obj = OpenStruct.new(:a => 1, 'b' => 2)
-    dump_and_load(obj, false, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :create_id => '^o', :create_additions => true)
   end
 
   def test_time
@@ -484,14 +498,14 @@ class CustomJuice < Minitest::Test
     # These two forms should be able to recreate the time precisely,
     # so we check they can load a dumped version and recreate the
     # original object correctly.
-    dump_and_load(obj, false, :time_format => :unix, :create_id => "^o", :create_additions => true)
-    dump_and_load(obj, false, :time_format => :unix_zone, :create_id => "^o", :create_additions => true)
+    dump_and_load(obj, false, :time_format => :unix, :create_id => '^o', :create_additions => true)
+    dump_and_load(obj, false, :time_format => :unix_zone, :create_id => '^o', :create_additions => true)
     # These two forms will lose precision while dumping as they don't
     # preserve full precision. We check that a dumped version is equal
     # to that version loaded and dumped a second time, but don't check
     # that the loaded Ruby objects is still the same as the original.
-    dump_load_dump(obj, false, :time_format => :xmlschema, :create_id => "^o", :create_additions => true)
-    dump_load_dump(obj, false, :time_format => :ruby, :create_id => "^o", :create_additions => true)
+    dump_load_dump(obj, false, :time_format => :xmlschema, :create_id => '^o', :create_additions => true)
+    dump_load_dump(obj, false, :time_format => :ruby, :create_id => '^o', :create_additions => true)
   end
 
   def dump_and_load(obj, trace=false, options={})
@@ -499,7 +513,7 @@ class CustomJuice < Minitest::Test
     json = Oj.dump(obj, options)
     puts json if trace
 
-    loaded = Oj.load(json, options);
+    loaded = Oj.load(json, options)
     if obj.nil?
       assert_nil(loaded)
     else
@@ -513,7 +527,7 @@ class CustomJuice < Minitest::Test
     json = Oj.dump(obj, options)
     puts json if trace
 
-    loaded = Oj.load(json, options);
+    loaded = Oj.load(json, options)
     if obj.nil?
       assert_nil(loaded)
     else
@@ -527,7 +541,7 @@ class CustomJuice < Minitest::Test
     json = Oj.dump(obj, options)
     puts json if trace
 
-    loaded = Oj.load(json, options);
+    loaded = Oj.load(json, options)
     if obj.nil?
       assert_nil(loaded)
     else

data/test/test_debian.rb

@@ -1,4 +1,4 @@
-# encoding: UTF-8
+# frozen_string_literal: true
 
 require 'helper'
 
@@ -20,18 +20,15 @@ class DebJuice < Minitest::Test
 
   # contributed by sauliusg to fix as_json
   class Orange < Jam
-    def initialize(x, y)
-      super
-    end
 
-    def as_json()
+    def as_json
       { :json_class => self.class,
         :x => @x,
         :y => @y }
     end
 
     def self.json_create(h)
-      self.new(h['x'], h['y'])
+      new(h['x'], h['y'])
     end
   end
 
@@ -39,13 +36,13 @@ class DebJuice < Minitest::Test
     Oj.default_options = { :mode => :compat, :class_cache => true, :use_as_json => true }
     obj = Orange.new(true, 58)
     json = Oj.dump(obj, :indent => 2)
-    assert(!json.nil?)
+    refute_nil(json)
     dump_and_load(obj, true)
   end
 
-  def dump_and_load(obj, trace=false)
+  def dump_and_load(obj, _trace=false)
     json = Oj.dump(obj, :indent => 2)
-    loaded = Oj.load(json);
+    loaded = Oj.load(json)
     assert_equal(obj, loaded)
     loaded
   end