ohm-tallyable 0.1.1 → 0.1.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MWRmOGJiMzVmNzQxODAyNDU1YTUyYzMzMDAyN2VjNjg3ZmIwYjBhYw==
+    ZDY5MTc1ZDZmZWMxOGNmYzEyODc3NzBlYTY3MGYxZjA3ODIyNmE3Mw==
   data.tar.gz: !binary |-
-    YWFjYTE0ZDRiMjRhMDg2YjIyMjQ5MTRiOWZiM2YxZWM4NTFjNjQxMw==
+    MzM2NDAxZWQ5Nzk1NWM2YTMxN2YzNWUwMzMxMzQzNjg2ODIxZmRhZQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NzJkODc2YjFiNDkyYjIxMGI4ZTMzNzBmOTY5YzBmNmY2NGZmMzdiOWE5OWFh
-    YTI0ZjUyYTIwZTNhYzAxNmYzMGM4NWIxY2NhOGIxY2Y5ZWViODE4NjI1NGU5
-    MmMwZDhiOWMyZTliMmIwNThjMGQ5MmM4MDM2MTE2ZDAwZTE1NDA=
+    MTdlZmI3YmQ4ZGNlMDUyNTUzOWNlOTRhZDZjOWMxMGUxMjA2ODU3NjE5ZWQ3
+    NDkwNTFiODE4OWJiNGJmNzViMmRkMzljY2EyNTBlYjUzZjJiOTJmNDUyN2Nj
+    ZmJmYjA2YzU1MjhmMTcxMjkwYjczODAzYzc3ZDRlYjc3ZTVmNTc=
   data.tar.gz: !binary |-
-    OTkwNDQyM2JiYjM0NGY5MjAxZDNmNzY0NWE3ODEyOWY4Y2I4MTIzNGE3OWNi
-    YWEwNDYxMGIyOGNiMWRjZDYxNjE4N2NmOTg3YjJlNmFhZDVjYmRjMzUyMTI5
-    MGU5MmQwZmI5YzlmNDlhOGM5NTRmMjY3NzBlZTQ5MmUxYzFmZjU=
+    NWU2YjZhZTNhNWFkODE2MjM0NTVlMDFlMDFhMGZiYjA3ZTUyYzQxYzI5MDY5
+    Y2QzZTlhNjIzM2U4YmRhYjg3ODJiN2IwNjMyNGY4YzM5Y2FkZGIxNThmMTgy
+    MzVjNTdjNzQxMmYzNzZiOTZiODVmOTQ4NzZlMTEyYTQ1Mjc3Mjc=

data/README.md

@@ -1,7 +1,9 @@
-
 ohm-tallyable
 =============
 
+[![Gem Version](https://badge.fury.io/rb/ohm-tallyable.png)](http://badge.fury.io/rb/ohm-tallyable)
+[![Code Climate](https://codeclimate.com/github/educabilia/ohm-tallyable.png)](https://codeclimate.com/github/educabilia/ohm-tallyable)
+
 A tally plugin for Ohm
 
 

data/lib/ohm/tallyable.rb

@@ -13,18 +13,24 @@ module Ohm
       end
 
       def leaderboard(attribute, by=nil)
+        raise ArgumentError if !_has_tally(attribute, by)
+
+        _load_zset(_tally_key(attribute, by))
+          .map { |k, v| [k, v.to_i] }
+          .sort_by { |k, v| [-v, k] }
+      end
+
+      def _has_tally(attribute, by=nil)
         tally = tallies[attribute]
-        if tally.nil? || (tally[:by] && (by.nil? || !by.include?(tally[:by])))
-          raise ArgumentError
-        end
+        !!(tally && (!tally[:by] || (by && by.include?(tally[:by]))))
+      end
+
+      def _tally_key(attribute, by=nil)
         key = self.key[:tallies][attribute]
         if by
           key = key[by.keys.first][by.values.first]
         end
-
-        _load_zset(key)
-          .map { |k, v| [k, v.to_i] }
-          .sort_by { |k, v| [-v, k] }
+        key
       end
 
       if Redis::VERSION.to_i == 2

data/ohm-tallyable.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'ohm-tallyable'
-  s.version     = '0.1.1'
+  s.version     = '0.1.2'
   s.summary     = "Ohm Tally Plugin"
   s.description = "A tally plugin for Ohm that keeps counts of records for every value of an attribute"
   s.author      = "Federico Bond"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ohm-tallyable
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Federico Bond
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-07 00:00:00.000000000 Z
+date: 2013-08-13 00:00:00.000000000 Z
 dependencies: []
 description: A tally plugin for Ohm that keeps counts of records for every value of
   an attribute