ohai 8.26.1 → 13.0.0

data/lib/ohai/mixin/do_metadata.rb

@@ -0,0 +1,47 @@
+
+# Author:: Dylan Page (<dpage@digitalocean.com>)
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require "net/http"
+
+module Ohai
+  module Mixin
+    module DOMetadata
+
+      DO_METADATA_ADDR = "169.254.169.254" unless defined?(DO_METADATA_ADDR)
+      DO_METADATA_URL = "/metadata/v1.json" unless defined?(DO_METADATA_URL)
+
+      def http_client
+        Net::HTTP.start(DO_METADATA_ADDR).tap { |h| h.read_timeout = 6 }
+      end
+
+      def fetch_metadata
+        uri = "#{DO_METADATA_URL}"
+        response = http_client.get(uri)
+        case response.code
+        when "200"
+          parser = FFI_Yajl::Parser.new
+          parser.parse(response.body)
+        when "404"
+          Ohai::Log.debug("Mixin DOMetadata: Encountered 404 response retreiving Digital Ocean metadata: #{uri} ; continuing.")
+          {}
+        else
+          raise "Mixin DOMetadata: Encountered error retrieving Digital Ocean metadata (#{uri} returned #{response.code} response)"
+        end
+      end
+
+    end
+  end
+end

data/lib/ohai/mixin/ec2_metadata.rb

@@ -2,7 +2,7 @@
 # Author:: Tim Dysinger (<tim@dysinger.net>)
 # Author:: Benjamin Black (<bb@chef.io>)
 # Author:: Christopher Brown (<cb@chef.io>)
-# Copyright:: 2009-2017 Chef Software, Inc.
+# Copyright:: Copyright (c) 2009-2016 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -18,7 +18,6 @@
 # limitations under the License.
 
 require "net/http"
-require "socket"
 
 module Ohai
   module Mixin
@@ -43,38 +42,12 @@ module Ohai
       EC2_METADATA_ADDR = "169.254.169.254" unless defined?(EC2_METADATA_ADDR)
       EC2_SUPPORTED_VERSIONS = %w{ 1.0 2007-01-19 2007-03-01 2007-08-29 2007-10-10 2007-12-15
                                    2008-02-01 2008-09-01 2009-04-04 2011-01-01 2011-05-01 2012-01-12
-                                   2014-11-05 2014-02-25 2016-04-19 2016-06-30 2016-09-02}
+                                   2014-11-05 2014-02-25 }
 
       EC2_ARRAY_VALUES = %w{security-groups}
       EC2_ARRAY_DIR    = %w{network/interfaces/macs}
       EC2_JSON_DIR     = %w{iam}
 
-      def can_metadata_connect?(addr, port, timeout = 2)
-        t = Socket.new(Socket::Constants::AF_INET, Socket::Constants::SOCK_STREAM, 0)
-        saddr = Socket.pack_sockaddr_in(port, addr)
-        connected = false
-
-        begin
-          t.connect_nonblock(saddr)
-        rescue Errno::EINPROGRESS
-          r, w, e = IO.select(nil, [t], nil, timeout)
-          if !w.nil?
-            connected = true
-          else
-            begin
-              t.connect_nonblock(saddr)
-            rescue Errno::EISCONN
-              t.close
-              connected = true
-            rescue SystemCallError
-            end
-          end
-        rescue SystemCallError
-        end
-        Ohai::Log.debug("ec2 metadata mixin: can_metadata_connect? == #{connected}")
-        connected
-      end
-
       def best_api_version
         response = http_client.get("/")
         if response.code == "404"

data/lib/ohai/mixin/gce_metadata.rb

@@ -15,7 +15,6 @@
 # limitations under the License.
 
 require "net/http"
-require "socket"
 
 module Ohai
   module Mixin
@@ -25,38 +24,6 @@ module Ohai
       GCE_METADATA_ADDR = "metadata.google.internal." unless defined?(GCE_METADATA_ADDR)
       GCE_METADATA_URL = "/computeMetadata/v1/?recursive=true" unless defined?(GCE_METADATA_URL)
 
-      def can_metadata_connect?(addr, port, timeout = 2)
-        t = Socket.new(Socket::Constants::AF_INET, Socket::Constants::SOCK_STREAM, 0)
-        begin
-          saddr = Socket.pack_sockaddr_in(port, addr)
-        rescue SocketError => e # occurs when non-GCE systems try to resolve metadata.google.internal
-          Ohai::Log.debug("Mixin GCE: can_metadata_connect? failed setting up socket: #{e}")
-          return false
-        end
-
-        connected = false
-
-        begin
-          t.connect_nonblock(saddr)
-        rescue Errno::EINPROGRESS
-          r, w, e = IO.select(nil, [t], nil, timeout)
-          if !w.nil?
-            connected = true
-          else
-            begin
-              t.connect_nonblock(saddr)
-            rescue Errno::EISCONN
-              t.close
-              connected = true
-            rescue SystemCallError
-            end
-          end
-        rescue SystemCallError
-        end
-        Ohai::Log.debug("Mixin GCE: can_metadata_connect? == #{connected}")
-        connected
-      end
-
       # fetch the meta content with a timeout and the required header
       def http_get(uri)
         conn = Net::HTTP.start(GCE_METADATA_ADDR)
@@ -94,10 +61,6 @@ module Ohai
         end
       end
 
-      def multiline?(data)
-        data.lines.to_a.size > 1
-      end
-
       def has_trailing_slash?(data)
         !! ( data =~ %r{/$} )
       end

data/lib/ohai/mixin/http_helper.rb

@@ -0,0 +1,56 @@
+#
+# Copyright:: 2017, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require "socket"
+
+module Ohai
+  module Mixin
+    module HttpHelper
+
+      def can_socket_connect?(addr, port, timeout = 2)
+        t = Socket.new(Socket::Constants::AF_INET, Socket::Constants::SOCK_STREAM, 0)
+        begin
+          saddr = Socket.pack_sockaddr_in(port, addr)
+        rescue SocketError => e # generally means dns resolution error
+          Ohai::Log.debug("Mixin HttpHelper: can_socket_connect? failed setting up socket connection: #{e}")
+          return false
+        end
+
+        connected = false
+
+        begin
+          t.connect_nonblock(saddr)
+        rescue Errno::EINPROGRESS
+          r, w, e = IO.select(nil, [t], nil, timeout)
+          if !w.nil?
+            connected = true
+          else
+            begin
+              t.connect_nonblock(saddr)
+            rescue Errno::EISCONN
+              t.close
+              connected = true
+            rescue SystemCallError
+            end
+          end
+        rescue SystemCallError
+        end
+        Ohai::Log.debug("Mixin HttpHelper: can_socket_connect? == #{connected}")
+        connected
+      end
+    end
+  end
+end

data/lib/ohai/mixin/network_constants.rb

@@ -24,11 +24,6 @@ module Ohai
         "inet" => "default",
         "inet6" => "default_inet6",
       }
-
-      # From sigar: include/sigar.h sigar_net_route_t
-      SIGAR_ROUTE_METHODS = [:destination, :gateway, :mask, :flags,
-                             :refcnt, :use, :metric, :mtu, :window,
-                             :irtt, :ifname]
     end
   end
 end

data/lib/ohai/plugins/cloud.rb

@@ -15,6 +15,7 @@
 # limitations under the License.
 
 Ohai.plugin(:Cloud) do
+  provides "cloud_v2"
   provides "cloud"
 
   depends "ec2"
@@ -25,36 +26,106 @@ Ohai.plugin(:Cloud) do
   depends "openstack"
   depends "azure"
   depends "digital_ocean"
-  depends "softlayer"
 
-  # Make top-level cloud hashes
+  # Class to help enforce the interface exposed to node[:cloud] (OHAI-542)
   #
-  def create_objects
-    cloud Mash.new
-    cloud[:public_ips] = Array.new
-    cloud[:private_ips] = Array.new
+  # cloud[:provider] - (String) the cloud provider the VM is running on.
+  #
+  # cloud[:public_hostname] - (String) a fully qualified hostname
+  # cloud[:local_hostname] - (String) a hostname resolvable on the internal (private) network
+  #
+  # cloud[:public_ipv4_addrs] - (Array) a list of all publicly accessible IPv4 addresses
+  # cloud[:local_ipv4_addrs] - (Array) a list of all private IPv4 addresses
+  # cloud[:public_ipv4] - (String) the first public IPv4 address detected
+  # cloud[:local_ipv4] - (String) the first private IPv4 address detected
+  #
+  # cloud[:public_ipv6_addrs] - (Array) a list of all publicly accessible IPv6 addresses
+  # cloud[:local_ipv6_addrs] - (Array) a list of all private IPv6 addresses
+  # cloud[:public_ipv6] - (String) the first public IPv6 address detected
+  # cloud[:local_ipv6] - (String) the first private IPv6 address detected
+  #
+  class CloudAttrs
+    attr_writer :provider, :public_hostname, :local_hostname
+
+    def initialize
+      @cloud = Mash.new
+    end
+
+    def add_ipv4_addr(ip, accessibility)
+      return if ip.nil? # just skip if ip is nil
+      ipaddr = validate_ip_addr(ip, :ipv4)
+
+      case accessibility
+      when :public
+        @cloud[:public_ipv4_addrs] ||= Array.new
+        @cloud[:public_ipv4_addrs] << ipaddr.to_s
+      when :private
+        @cloud[:local_ipv4_addrs] ||= Array.new
+        @cloud[:local_ipv4_addrs] << ipaddr.to_s
+      else
+        raise "ERROR: invalid accessibility param of '#{accessibility}'. must be :public or :private."
+      end
+    end
+
+    def add_ipv6_addr(ip, accessibility)
+      return if ip.nil? # just skip if ip is nil
+      ipaddr = validate_ip_addr(ip, :ipv6)
+
+      raise "ERROR: invalid ipv6 address of '#{ip}' detected. " unless ipaddr.ipv6?
+      case accessibility
+      when :public
+        @cloud[:public_ipv6_addrs] ||= Array.new
+        @cloud[:public_ipv6_addrs] << ipaddr.to_s
+      when :private
+        @cloud[:local_ipv6_addrs] ||= Array.new
+        @cloud[:local_ipv6_addrs] << ipaddr.to_s
+      else
+        raise "ERROR: invalid accessibility param of '#{accessibility}'. must be :public or :private."
+      end
+    end
+
+    def cloud_mash
+      @cloud[:provider] = @provider if @provider
+
+      @cloud[:public_hostname] = @public_hostname if @public_hostname
+      @cloud[:local_hostname] = @local_hostname if @local_hostname
+
+      @cloud[:public_ipv4] = @cloud[:public_ipv4_addrs][0] if @cloud[:public_ipv4_addrs]
+      @cloud[:local_ipv4] = @cloud[:local_ipv4_addrs][0] if @cloud[:local_ipv4_addrs]
+
+      @cloud[:public_ipv6] = @cloud[:public_ipv6_addrs][0] if @cloud[:public_ipv6_addrs]
+      @cloud[:local_ipv6] = @cloud[:local_ipv6_addrs][0] if @cloud[:local_ipv6_addrs]
+
+      # if empty, return nil
+      (@cloud.empty?) ? nil : @cloud
+    end
+
+    private
+
+    def validate_ip_addr(ip, address_family = :ipv4)
+      ipaddr = ""
+      begin
+        ipaddr = IPAddr.new(ip)
+        raise ArgumentError, "not valid #{address_family} address" unless (address_family == :ipv4) ? ipaddr.ipv4? : ipaddr.ipv6?
+      rescue ArgumentError => e
+        raise "ERROR: the ohai 'cloud' plugin failed with an IP address of '#{ip}' : #{e.message}"
+      end
+      ipaddr
+    end
   end
+
   #---------------------------------------
   # Google Compute Engine (gce)
   #--------------------------------------
 
-  # Is current cloud gce?
-  #
-  # === Return
-  # true:: If gce Hash is defined
-  # false:: Otherwise
   def on_gce?
     gce != nil
   end
 
-  # Fill cloud hash with gce values
   def get_gce_values
-    cloud[:public_ipv4] = []
-    cloud[:local_ipv4] = []
-
     public_ips = gce["instance"]["networkInterfaces"].collect do |interface|
       if interface.has_key?("accessConfigs")
-        interface["accessConfigs"].collect { |ac| ac["externalIp"] }
+        interface["accessConfigs"].collect { |ac| ac["externalIp"] unless ac["externalIp"] == "" }
       end
     end.flatten.compact
 
@@ -62,13 +133,10 @@ Ohai.plugin(:Cloud) do
       interface["ip"]
     end.compact
 
-    cloud[:public_ips] += public_ips
-    cloud[:private_ips] += private_ips
-    cloud[:public_ipv4] += public_ips
-    cloud[:public_hostname] = nil
-    cloud[:local_ipv4] += private_ips
-    cloud[:local_hostname] = gce["instance"]["hostname"]
-    cloud[:provider] = "gce"
+    public_ips.each { |ipaddr| @cloud_attr_obj.add_ipv4_addr(ipaddr, :public) }
+    private_ips.each { |ipaddr| @cloud_attr_obj.add_ipv4_addr(ipaddr, :private) }
+    @cloud_attr_obj.local_hostname = gce["instance"]["hostname"]
+    @cloud_attr_obj.provider = "gce"
   end
 
   # ----------------------------------------
@@ -86,13 +154,11 @@ Ohai.plugin(:Cloud) do
 
   # Fill cloud hash with ec2 values
   def get_ec2_values
-    cloud[:public_ips] << ec2["public_ipv4"]
-    cloud[:private_ips] << ec2["local_ipv4"]
-    cloud[:public_ipv4] = ec2["public_ipv4"]
-    cloud[:public_hostname] = ec2["public_hostname"]
-    cloud[:local_ipv4] = ec2["local_ipv4"]
-    cloud[:local_hostname] = ec2["local_hostname"]
-    cloud[:provider] = "ec2"
+    @cloud_attr_obj.add_ipv4_addr(ec2["public_ipv4"], :public)
+    @cloud_attr_obj.add_ipv4_addr(ec2["local_ipv4"], :private)
+    @cloud_attr_obj.public_hostname = ec2["public_hostname"]
+    @cloud_attr_obj.local_hostname = ec2["local_hostname"]
+    @cloud_attr_obj.provider = "ec2"
   end
 
   # ----------------------------------------
@@ -110,15 +176,13 @@ Ohai.plugin(:Cloud) do
 
   # Fill cloud hash with rackspace values
   def get_rackspace_values
-    cloud[:public_ips] << rackspace["public_ipv4"] if rackspace["public_ipv4"]
-    cloud[:private_ips] << rackspace["local_ipv4"] if rackspace["local_ipv4"]
-    cloud[:public_ipv4] = rackspace["public_ipv4"]
-    cloud[:public_ipv6] = rackspace["public_ipv6"]
-    cloud[:public_hostname] = rackspace["public_hostname"]
-    cloud[:local_ipv4] = rackspace["local_ipv4"]
-    cloud[:local_ipv6] = rackspace["local_ipv6"]
-    cloud[:local_hostname] = rackspace["local_hostname"]
-    cloud[:provider] = "rackspace"
+    @cloud_attr_obj.add_ipv4_addr(rackspace["public_ipv4"], :public)
+    @cloud_attr_obj.add_ipv4_addr(rackspace["local_ipv4"], :private)
+    @cloud_attr_obj.add_ipv6_addr(rackspace["public_ipv6"], :public)
+    @cloud_attr_obj.add_ipv6_addr(rackspace["local_ipv6"], :private)
+    @cloud_attr_obj.public_hostname = rackspace["public_hostname"]
+    @cloud_attr_obj.local_hostname = rackspace["local_hostname"]
+    @cloud_attr_obj.provider = "rackspace"
   end
 
   # ----------------------------------------
@@ -136,13 +200,11 @@ Ohai.plugin(:Cloud) do
 
   # Fill cloud hash with linode values
   def get_linode_values
-    cloud[:public_ips] << linode["public_ip"]
-    cloud[:private_ips] << linode["private_ip"]
-    cloud[:public_ipv4] = linode["public_ipv4"]
-    cloud[:public_hostname] = linode["public_hostname"]
-    cloud[:local_ipv4] = linode["local_ipv4"]
-    cloud[:local_hostname] = linode["local_hostname"]
-    cloud[:provider] = "linode"
+    @cloud_attr_obj.add_ipv4_addr(linode["public_ip"], :public)
+    @cloud_attr_obj.add_ipv4_addr(linode["private_ip"], :private)
+    @cloud_attr_obj.public_hostname = linode["public_hostname"]
+    @cloud_attr_obj.local_hostname = linode["local_hostname"]
+    @cloud_attr_obj.provider = "linode"
   end
 
   # ----------------------------------------
@@ -159,13 +221,11 @@ Ohai.plugin(:Cloud) do
   end
 
   def get_eucalyptus_values
-    cloud[:public_ips] << eucalyptus["public_ipv4"]
-    cloud[:private_ips] << eucalyptus["local_ipv4"]
-    cloud[:public_ipv4] = eucalyptus["public_ipv4"]
-    cloud[:public_hostname] = eucalyptus["public_hostname"]
-    cloud[:local_ipv4] = eucalyptus["local_ipv4"]
-    cloud[:local_hostname] = eucalyptus["local_hostname"]
-    cloud[:provider] = "eucalyptus"
+    @cloud_attr_obj.add_ipv4_addr(eucalyptus["public_ipv4"], :public)
+    @cloud_attr_obj.add_ipv4_addr(eucalyptus["local_ipv4"], :private)
+    @cloud_attr_obj.public_hostname = eucalyptus["public_hostname"]
+    @cloud_attr_obj.local_hostname = eucalyptus["local_hostname"]
+    @cloud_attr_obj.provider = "eucalyptus"
   end
 
   # ----------------------------------------
@@ -183,13 +243,11 @@ Ohai.plugin(:Cloud) do
 
   # Fill cloud hash with openstack values
   def get_openstack_values
-    cloud[:public_ips] << openstack["public_ipv4"]
-    cloud[:private_ips] << openstack["local_ipv4"]
-    cloud[:public_ipv4] = openstack["public_ipv4"]
-    cloud[:public_hostname] = openstack["public_hostname"]
-    cloud[:local_ipv4] = openstack["local_ipv4"]
-    cloud[:local_hostname] = openstack["local_hostname"]
-    cloud[:provider] = openstack["provider"]
+    @cloud_attr_obj.add_ipv4_addr(openstack["public_ipv4"], :public)
+    @cloud_attr_obj.add_ipv4_addr(openstack["local_ipv4"], :private)
+    @cloud_attr_obj.public_hostname = openstack["public_hostname"]
+    @cloud_attr_obj.local_hostname = openstack["local_hostname"]
+    @cloud_attr_obj.provider = openstack["provider"]
   end
 
   # ----------------------------------------
@@ -207,15 +265,10 @@ Ohai.plugin(:Cloud) do
 
   # Fill cloud hash with azure values
   def get_azure_values
-    cloud[:vm_name] = azure["vm_name"]
-    cloud[:private_ips] << azure["private_ip"]
-    cloud[:public_ips] << azure["public_ip"]
-    cloud[:public_ipv4] = azure["public_ip"]
-    cloud[:public_fqdn] = azure["public_fqdn"]
-    cloud[:public_hostname] = azure["public_fqdn"]
-    cloud[:public_ssh_port] = azure["public_ssh_port"] if azure["public_ssh_port"]
-    cloud[:public_winrm_port] = azure["public_winrm_port"] if azure["public_winrm_port"]
-    cloud[:provider] = "azure"
+    @cloud_attr_obj.add_ipv4_addr(azure["public_ip"], :public)
+    @cloud_attr_obj.add_ipv4_addr(azure["private_ip"], :private)
+    @cloud_attr_obj.public_hostname = azure["public_fqdn"]
+    @cloud_attr_obj.provider = "azure"
   end
 
   # ----------------------------------------
@@ -231,97 +284,31 @@ Ohai.plugin(:Cloud) do
     digital_ocean != nil
   end
 
-  # Fill cloud hash with linode values
+  # Fill cloud hash with digital_ocean values
   def get_digital_ocean_values
-    public_ipv4 = digital_ocean["networks"]["v4"].select { |address| address["type"] == "public" }
-    private_ipv4 = digital_ocean["networks"]["v4"].select { |address| address["type"] == "private" }
-    public_ipv6 = digital_ocean["networks"]["v6"].select { |address| address["type"] == "public" }
-    private_ipv6 = digital_ocean["networks"]["v6"].select { |address| address["type"] == "private" }
-    cloud[:public_ips].concat public_ipv4 + public_ipv6
-    cloud[:private_ips].concat private_ipv4 + private_ipv6
-    cloud[:public_ipv4] = public_ipv4.first
-    cloud[:public_ipv6] = public_ipv6.first
-    cloud[:local_ipv4] = private_ipv4.first
-    cloud[:local_ipv6] = private_ipv6.first
-    cloud[:public_hostname] = digital_ocean["name"]
-    cloud[:provider] = "digital_ocean"
-  end
-
-  # ----------------------------------------
-  # softlayer
-  # ----------------------------------------
-
-  # Is current cloud softlayer?
-  #
-  # === Return
-  # true:: If softlayer Hash is defined
-  # false:: Otherwise
-  def on_softlayer?
-    softlayer != nil
-  end
-
-  # Fill cloud hash with softlayer values
-  def get_softlayer_values
-    cloud[:public_ipv4] = softlayer["public_ipv4"]
-    cloud[:local_ipv4] = softlayer["local_ipv4"]
-    cloud[:public_ips] << softlayer["public_ipv4"] if softlayer["public_ipv4"]
-    cloud[:private_ips] << softlayer["local_ipv4"] if softlayer["local_ipv4"]
-    cloud[:public_hostname] = softlayer["public_fqdn"]
-    cloud[:provider] = "softlayer"
+    @cloud_attr_obj.add_ipv4_addr(digital_ocean["interfaces"]["public"][0]["ipv4"]["ip_address"], :public) rescue NoMethodError
+    @cloud_attr_obj.add_ipv4_addr(digital_ocean["interfaces"]["private"][0]["ipv4"]["ip_address"], :private) rescue NoMethodError
+    @cloud_attr_obj.add_ipv6_addr(digital_ocean["interfaces"]["public"][0]["ipv6"]["ip_address"], :public) rescue NoMethodError
+    @cloud_attr_obj.add_ipv6_addr(digital_ocean["interfaces"]["private"][0]["ipv6"]["ip_address"], :private) rescue NoMethodError
+    @cloud_attr_obj.provider = "digital_ocean"
   end
 
   collect_data do
-    # setup gce cloud
-    if on_gce?
-      create_objects
-      get_gce_values
-    end
-
-    # setup ec2 cloud
-    if on_ec2?
-      create_objects
-      get_ec2_values
-    end
-
-    # setup rackspace cloud
-    if on_rackspace?
-      create_objects
-      get_rackspace_values
-    end
-
-    # setup linode cloud data
-    if on_linode?
-      create_objects
-      get_linode_values
-    end
-
-    if on_eucalyptus?
-      create_objects
-      get_eucalyptus_values
-    end
-
-    # setup openstack cloud
-    if on_openstack?
-      create_objects
-      get_openstack_values
-    end
-
-    # setup azure cloud data
-    if on_azure?
-      create_objects
-      get_azure_values
-    end
-
-    # setup digital_ocean cloud data
-    if on_digital_ocean?
-      create_objects
-      get_digital_ocean_values
-    end
-
-    # setup softlayer cloud
-    if on_softlayer?
-      create_objects
-      get_softlayer_values
-    end
+    require "ipaddr"
+
+    @cloud_attr_obj = CloudAttrs.new()
+
+    get_gce_values if on_gce?
+    get_ec2_values if on_ec2?
+    get_rackspace_values if on_rackspace?
+    get_linode_values if on_linode?
+    get_eucalyptus_values if on_eucalyptus?
+    get_openstack_values if on_openstack?
+    get_azure_values if on_azure?
+    get_digital_ocean_values if on_digital_ocean?
+
+    # set node[:cloud] and node[:cloud_v2] hash here
+    cloud_v2 @cloud_attr_obj.cloud_mash
+    cloud @cloud_attr_obj.cloud_mash
   end
 end