ohai 7.4.1 → 7.6.0.rc.0

data/spec/unit/plugins/hostname_spec.rb

@@ -72,6 +72,18 @@ describe Ohai::System, "hostname plugin" do
     end
   end
 
+  context "when a system has a bare hostname without a FQDN" do
+    before(:each) do
+      @plugin.stub(:collect_os).and_return(:default)
+      @plugin.stub(:shell_out).with("hostname").and_return(mock_shell_out(0, "katie", ""))
+    end
+
+    it "should correctly set the [short] hostname" do
+      @plugin.run
+      @plugin[:hostname].should == "katie"
+    end
+  end
+
   context "hostname --fqdn when it returns empty string" do
     before(:each) do
       @plugin.stub(:collect_os).and_return(:linux)

data/spec/unit/plugins/linux/filesystem_spec.rb

@@ -26,7 +26,7 @@ describe Ohai::System, "Linux filesystem plugin" do
     @plugin.stub(:shell_out).with("df -P").and_return(mock_shell_out(0, "", ""))
     @plugin.stub(:shell_out).with("df -i").and_return(mock_shell_out(0, "", ""))
     @plugin.stub(:shell_out).with("mount").and_return(mock_shell_out(0, "", ""))
-    File.stub(:exists?).with("/bin/lsblk").and_return(false)
+    File.stub(:exist?).with("/bin/lsblk").and_return(false)
     @plugin.stub(:shell_out).with("blkid -s TYPE").and_return(mock_shell_out(0, "", ""))
     @plugin.stub(:shell_out).with("blkid -s UUID").and_return(mock_shell_out(0, "", ""))
     @plugin.stub(:shell_out).with("blkid -s LABEL").and_return(mock_shell_out(0, "", ""))
@@ -38,7 +38,22 @@ describe Ohai::System, "Linux filesystem plugin" do
     @plugin.stub(:shell_out).with("lsblk -r -n -o NAME,LABEL").
       and_return(mock_shell_out(0, "", ""))
 
-    File.stub(:exists?).with("/proc/mounts").and_return(false)
+    File.stub(:exist?).with("/proc/mounts").and_return(false)
+
+    %w{sdb1 sdb2 sda1 sda2 md0 md1 md2}.each do |name|
+      File.stub(:exist?).with("/dev/#{name}").and_return(true)
+    end
+    %w{
+       sys.vg-root.lv
+       sys.vg-swap.lv
+       sys.vg-tmp.lv
+       sys.vg-usr.lv
+       sys.vg-var.lv
+       sys.vg-home.lv
+    }.each do |name|
+      File.stub(:exist?).with("/dev/#{name}").and_return(false)
+      File.stub(:exist?).with("/dev/mapper/#{name}").and_return(true)
+    end
   end
 
   describe "when gathering filesystem usage data from df" do
@@ -191,20 +206,20 @@ BLKID_TYPE
 
   describe "when gathering filesystem type data from lsblk" do
     before(:each) do
-      File.stub(:exists?).with("/bin/lsblk").and_return(true)
+      File.stub(:exist?).with("/bin/lsblk").and_return(true)
       @stdout = <<-BLKID_TYPE
-/dev/sdb1 linux_raid_member 
-/dev/sdb2 linux_raid_member 
-/dev/sda1 linux_raid_member 
-/dev/sda2 linux_raid_member 
-/dev/md0 ext3 
-/dev/md1 LVM2_member 
-/dev/mapper/sys.vg-root.lv ext4 
-/dev/mapper/sys.vg-swap.lv swap 
-/dev/mapper/sys.vg-tmp.lv ext4 
-/dev/mapper/sys.vg-usr.lv ext4 
-/dev/mapper/sys.vg-var.lv ext4 
-/dev/mapper/sys.vg-home.lv xfs 
+sdb1 linux_raid_member 
+sdb2 linux_raid_member 
+sda1 linux_raid_member 
+sda2 linux_raid_member 
+md0 ext3 
+md1 LVM2_member 
+sys.vg-root.lv ext4 
+sys.vg-swap.lv swap 
+sys.vg-tmp.lv ext4 
+sys.vg-usr.lv ext4 
+sys.vg-var.lv ext4 
+sys.vg-home.lv xfs 
 BLKID_TYPE
       @plugin.stub(:shell_out).with("lsblk -r -n -o NAME,FSTYPE").
         and_return(mock_shell_out(0, @stdout, ""))
@@ -254,20 +269,20 @@ BLKID_UUID
 
   describe "when gathering filesystem uuid data from lsblk" do
     before(:each) do
-      File.stub(:exists?).with("/bin/lsblk").and_return(true)
+      File.stub(:exist?).with("/bin/lsblk").and_return(true)
       @stdout = <<-BLKID_UUID
-/dev/sdb1 bd1197e0-6997-1f3a-e27e-7801388308b5 
-/dev/sdb2 e36d933e-e5b9-cfe5-6845-1f84d0f7fbfa 
-/dev/sda1 bd1197e0-6997-1f3a-e27e-7801388308b5 
-/dev/sda2 e36d933e-e5b9-cfe5-6845-1f84d0f7fbfa 
-/dev/md0 37b8de8e-0fe3-4b5a-b9b4-dde33e19bb32 
-/dev/md1 YsIe0R-fj1y-LXTd-imla-opKo-OuIe-TBoxSK 
-/dev/mapper/sys.vg-root.lv 7742d14b-80a3-4e97-9a32-478be9ea9aea 
-/dev/mapper/sys.vg-swap.lv 9bc2e515-8ddc-41c3-9f63-4eaebde9ce96 
-/dev/mapper/sys.vg-tmp.lv 74cf7eb9-428f-479e-9a4a-9943401e81e5 
-/dev/mapper/sys.vg-usr.lv 26ec33c5-d00b-4f88-a550-492def013bbc 
-/dev/mapper/sys.vg-var.lv 6b559c35-7847-4ae2-b512-c99012d3f5b3 
-/dev/mapper/sys.vg-home.lv d6efda02-1b73-453c-8c74-7d8dee78fa5e 
+sdb1 bd1197e0-6997-1f3a-e27e-7801388308b5 
+sdb2 e36d933e-e5b9-cfe5-6845-1f84d0f7fbfa 
+sda1 bd1197e0-6997-1f3a-e27e-7801388308b5 
+sda2 e36d933e-e5b9-cfe5-6845-1f84d0f7fbfa 
+md0 37b8de8e-0fe3-4b5a-b9b4-dde33e19bb32 
+md1 YsIe0R-fj1y-LXTd-imla-opKo-OuIe-TBoxSK 
+sys.vg-root.lv 7742d14b-80a3-4e97-9a32-478be9ea9aea 
+sys.vg-swap.lv 9bc2e515-8ddc-41c3-9f63-4eaebde9ce96 
+sys.vg-tmp.lv 74cf7eb9-428f-479e-9a4a-9943401e81e5 
+sys.vg-usr.lv 26ec33c5-d00b-4f88-a550-492def013bbc 
+sys.vg-var.lv 6b559c35-7847-4ae2-b512-c99012d3f5b3 
+sys.vg-home.lv d6efda02-1b73-453c-8c74-7d8dee78fa5e 
 BLKID_UUID
       @plugin.stub(:shell_out).with("lsblk -r -n -o NAME,UUID").
         and_return(mock_shell_out(0, @stdout, ""))
@@ -316,18 +331,18 @@ BLKID_LABEL
 
   describe "when gathering filesystem label data from lsblk" do
     before(:each) do
-      File.stub(:exists?).with("/bin/lsblk").and_return(true)
+      File.stub(:exist?).with("/bin/lsblk").and_return(true)
       @stdout = <<-BLKID_LABEL
-/dev/sda1 fuego:0 
-/dev/sda2 fuego:1 
-/dev/sdb1 fuego:0 
-/dev/sdb2 fuego:1 
-/dev/md0 /boot 
-/dev/mapper/sys.vg-root.lv / 
-/dev/mapper/sys.vg-tmp.lv /tmp 
-/dev/mapper/sys.vg-usr.lv /usr 
-/dev/mapper/sys.vg-var.lv /var 
-/dev/mapper/sys.vg-home.lv /home 
+sda1 fuego:0 
+sda2 fuego:1 
+sdb1 fuego:0 
+sdb2 fuego:1 
+md0 /boot 
+sys.vg-root.lv / 
+sys.vg-tmp.lv /tmp 
+sys.vg-usr.lv /usr 
+sys.vg-var.lv /var 
+sys.vg-home.lv /home 
 BLKID_LABEL
       @plugin.stub(:shell_out).with("lsblk -r -n -o NAME,LABEL").
         and_return(mock_shell_out(0, @stdout, ""))
@@ -348,7 +363,7 @@ BLKID_LABEL
 
   describe "when gathering data from /proc/mounts" do
     before(:each) do
-      File.stub(:exists?).with("/proc/mounts").and_return(true)
+      File.stub(:exist?).with("/proc/mounts").and_return(true)
       @double_file = double("/proc/mounts")
       @mounts = <<-MOUNTS
 rootfs / rootfs rw 0 0

data/spec/unit/plugins/linux/platform_spec.rb

@@ -35,6 +35,7 @@ describe Ohai::System, "Linux plugin platform" do
     File.stub(:exists?).with("/etc/slackware-version").and_return(false)
     File.stub(:exists?).with("/etc/enterprise-release").and_return(false)
     File.stub(:exists?).with("/etc/oracle-release").and_return(false)
+    File.stub(:exists?).with("/etc/parallels-release").and_return(false)
     File.stub(:exists?).with("/usr/bin/raspi-config").and_return(false)
   end
 
@@ -295,6 +296,41 @@ describe Ohai::System, "Linux plugin platform" do
         @plugin[:platform].should == "fedora"
         @plugin[:platform_version].to_i.should == 13
       end
+
+    end
+  end
+
+  describe "on pcs linux" do
+    describe "with lsb_result" do
+      it "should read the platform as parallels and version as 6.0.5" do
+        @plugin[:lsb][:id] = "CloudLinuxServer"
+        @plugin[:lsb][:release] = "6.5"
+        File.stub(:exists?).with("/etc/redhat-release").and_return(true)
+        File.stub(:read).with("/etc/redhat-release").and_return("CloudLinux Server release 6.5 (Pavel Popovich)")
+        File.should_receive(:exists?).with("/etc/parallels-release").and_return(true)
+        File.should_receive(:read).with("/etc/parallels-release").and_return("Parallels Cloud Server 6.0.5 (20007)")
+        @plugin.run
+        @plugin[:platform].should == "parallels"
+        @plugin[:platform_version].should == "6.0.5"
+        @plugin[:platform_family].should == "rhel"
+      end
+    end
+
+    describe "without lsb_results" do
+      before(:each) do
+        @plugin.lsb = nil
+      end
+
+      it "should read the platform as parallels and version as 6.0.5" do
+        File.stub(:exists?).with("/etc/redhat-release").and_return(true)
+        File.stub(:read).with("/etc/redhat-release").and_return("CloudLinux Server release 6.5 (Pavel Popovich)")
+        File.should_receive(:exists?).with("/etc/parallels-release").and_return(true)
+        File.should_receive(:read).with("/etc/parallels-release").and_return("Parallels Cloud Server 6.0.5 (20007)")
+        @plugin.run
+        @plugin[:platform].should == "parallels"
+        @plugin[:platform_version].should == "6.0.5"
+        @plugin[:platform_family].should == "rhel"
+      end
     end
   end
 

data/spec/unit/plugins/openstack_spec.rb

@@ -118,6 +118,26 @@ EOM
         }
       end
 
+      let(:openstack_metadata_version) { "2013-04-04" }
+      let(:openstack_metadata_endpoint) { "http://169.254.169.254/openstack/" }
+
+      let(:openstack_metadata_values) do
+        '{
+            "availability_zone" : "nova",
+            "hostname" : "ohai.novalocal",
+            "launch_index" : 0,
+            "meta" : {
+                "priority" : "low",
+                "role" : "ohaiserver"
+            },
+            "name" : "ohai_spec",
+            "public_keys" : {
+                "mykey" : "SSH KEY DATA"
+            },
+            "uuid" : "00000000-0000-0000-0000-100000000000"
+        }'
+      end
+
       let(:http_client) { double("Net::HTTP", :read_timeout= => nil) }
 
       def expect_get(url, response_body)
@@ -126,6 +146,12 @@ EOM
           and_return(double("HTTP Response", :code => "200", :body => response_body))
       end
 
+      def expect_get_response(url, response_body)
+        http_client.should_receive(:get_response).
+          with(url,nil,nil).
+          and_return(double("HTTP Response", :code => "200", :body => response_body))
+      end
+
       before do
         openstack_plugin.should_receive(:can_metadata_connect?).
           with(Ohai::Mixin::Ec2Metadata::EC2_METADATA_ADDR,80).
@@ -143,6 +169,11 @@ EOM
           expect_get("/#{metadata_version}/meta-data/#{md_id}", md_value)
         end
 
+        expect_get_response(
+          URI.parse("#{openstack_metadata_endpoint}#{openstack_metadata_version}/meta_data.json"),
+          openstack_metadata_values
+        )
+
         openstack_plugin.run
       end
 
@@ -206,6 +237,30 @@ EOM
       it "reads the provider from the metadata service" do
         expect(ohai_data['openstack']['provider']).to eq("openstack")
       end
+
+      context 'Retreive openStack specific metadata' do
+        it "reads the availability_zone from the openstack metadata service" do
+          expect(ohai_data['openstack']['metadata']['availability_zone']).to eq('nova')
+        end
+        it "reads the hostname from the openstack metadata service" do
+          expect(ohai_data['openstack']['metadata']['hostname']).to eq('ohai.novalocal')
+        end
+        it "reads the launch_index from the openstack metadata service" do
+          expect(ohai_data['openstack']['metadata']['launch_index']).to eq(0)
+        end
+        it "reads the meta from the openstack metadata service" do
+          expect(ohai_data['openstack']['metadata']['meta']).to eq({ "priority" => "low", "role" => "ohaiserver"})
+        end
+        it "reads the name from the openstack metadata service" do
+          expect(ohai_data['openstack']['metadata']['name']).to eq('ohai_spec')
+        end
+        it "reads the public_keys from the openstack metadata service" do
+          expect(ohai_data['openstack']['metadata']['public_keys']).to eq({"mykey" => "SSH KEY DATA"})
+        end
+        it "reads the uuid from the openstack metadata service" do
+          expect(ohai_data['openstack']['metadata']['uuid']).to eq('00000000-0000-0000-0000-100000000000')
+        end
+      end
     end
 
 

data/spec/unit/plugins/passwd_spec.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
 
-describe Ohai::System, "plugin etc" do
+describe Ohai::System, "plugin etc", :unix_only do
   before(:each) do
     @plugin = get_plugin("passwd")
   end
@@ -24,7 +24,8 @@ describe Ohai::System, "plugin etc" do
   end
 
   it "should set the current user" do
-    Etc.should_receive(:getlogin).and_return('chef')
+    Process.should_receive(:euid).and_return('31337')
+    Etc.should_receive(:getpwuid).and_return(PasswdEntry.new('chef', 31337, 31337, '/home/chef', '/bin/ksh', 'Julia Child'))
     @plugin.run
     @plugin[:current_user].should == 'chef'
   end

data/spec/unit/plugins/python_spec.rb

@@ -7,9 +7,9 @@
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
-# 
+#
 #     http://www.apache.org/licenses/LICENSE-2.0
-# 
+#
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -17,33 +17,35 @@
 # limitations under the License.
 #
 
-
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
 
 describe Ohai::System, "plugin python" do
+  let(:stdout) { "2.5.2 (r252:60911, Jan  4 2009, 17:40:26)\n[GCC 4.3.2]\n" }
+
+  let(:retval) { 0 }
 
-  before(:each) do
-    @plugin = get_plugin("python")
-    @plugin[:languages] = Mash.new
-    @stdout = "2.5.2 (r252:60911, Jan  4 2009, 17:40:26)\n[GCC 4.3.2]\n"
-    @plugin.stub(:shell_out).with("python -c \"import sys; print sys.version\"").and_return(mock_shell_out(0, @stdout, ""))
+  let(:plugin) do
+    plugin = get_plugin("python")
+    plugin[:languages] = Mash.new
+    expect(plugin).to receive(:shell_out).with("python -c \"import sys; print (sys.version)\"").and_return(mock_shell_out(retval, stdout, ""))
+    plugin
   end
-  
+
   it "should get the python version from printing sys.version and sys.platform" do
-    @plugin.should_receive(:shell_out).with("python -c \"import sys; print sys.version\"").and_return(mock_shell_out(0, @stdout, ""))
-    @plugin.run
+    plugin.run
   end
 
   it "should set languages[:python][:version]" do
-    @plugin.run
-    @plugin.languages[:python][:version].should eql("2.5.2")
-  end
-  
-  it "should not set the languages[:python] tree up if python command fails" do
-    @stdout = "2.5.2 (r252:60911, Jan  4 2009, 17:40:26)\n[GCC 4.3.2]\n"
-    @plugin.stub(:shell_out).with("python -c \"import sys; print sys.version\"").and_return(mock_shell_out(1, @stdout, ""))
-    @plugin.run
-    @plugin.languages.should_not have_key(:python)
+    plugin.run
+    expect(plugin.languages[:python][:version]).to eql("2.5.2")
   end
 
+  context "when the python command fails" do
+    let(:retval) { 1 }
+
+    it "should not set the languages[:python] tree up" do
+      plugin.run
+      expect(plugin.languages).not_to have_key(:python)
+    end
+  end
 end

data/spec/unit/plugins/solaris2/zpools_spec.rb

@@ -0,0 +1,153 @@
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
+
+describe Ohai::System, "Solaris 2.x zpool plugin" do
+  before(:each) do
+    @plugin = get_plugin("solaris2/zpools")
+    @plugin.stub(:collect_os).and_return(:solaris2)
+
+    @zpool_status_rpool = <<-EOSR
+pool: rpool
+state: ONLINE
+scan: resilvered 65.6G in 0h8m with 0 errors on Fri Jun  6 14:22:40 2014
+config:
+
+      NAME          STATE     READ WRITE CKSUM
+      rpool         ONLINE       0     0     0
+        mirror-0    ONLINE       0     0     0
+          c3t5d0s0  ONLINE       0     0     0
+          c3t4d0s0  ONLINE       0     0     0
+
+errors: No known data errors
+EOSR
+
+    @zpool_status_tank = <<-EOST
+pool: tank
+state: ONLINE
+scan: scrub repaired 0 in 0h0m with 0 errors on Fri Jun  6 14:43:40 2014
+config:
+
+      NAME                       STATE     READ WRITE CKSUM
+      tank                       ONLINE       0     0     0
+        raidz2-0                 ONLINE       0     0     0
+          c1t50014EE209D1DBA9d0  ONLINE       0     0     0
+          c1t50014EE20A0ECED2d0  ONLINE       0     0     0
+          c1t50014EE20A106BFFd0  ONLINE       0     0     0
+          c1t50014EE20A1423E8d0  ONLINE       0     0     0
+          c1t50014EE20A145447d0  ONLINE       0     0     0
+          c1t50014EE20A29EE56d0  ONLINE       0     0     0
+        raidz2-1                 ONLINE       0     0     0
+          c1t50014EE20A2B984Cd0  ONLINE       0     0     0
+          c1t50014EE20A2BBC78d0  ONLINE       0     0     0
+          c1t50014EE20A2BDCA9d0  ONLINE       0     0     0
+          c1t50014EE25F697DC4d0  ONLINE       0     0     0
+          c1t50014EE25F698BECd0  ONLINE       0     0     0
+          c1t50014EE25F6998DAd0  ONLINE       0     0     0
+EOST
+    @zpool_out = <<-EOZO
+rpool   109G    66.2G   42.8G   60%     1.00x   ONLINE  34
+tank    130T    4.91M   130T    0%      1.00x   ONLINE  34
+EOZO
+    @plugin.stub(:shell_out).with("zpool list -H -o name,size,alloc,free,cap,dedup,health,version").and_return(mock_shell_out(0,@zpool_out,""))
+    @plugin.stub(:shell_out).with("su adm -c \"zpool status rpool\"").and_return(mock_shell_out(0,@zpool_status_rpool,""))
+    @plugin.stub(:shell_out).with("su adm -c \"zpool status tank\"").and_return(mock_shell_out(0,@zpool_status_tank,""))
+  end
+
+  describe "On Solaris2 Common" do
+    it "Should have entries for both zpools" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool]).to be
+      expect(@plugin[:zpools][:tank]).to be
+    end
+
+    it "Should have the correct pool size" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:pool_size]).to match("109G")
+      expect(@plugin[:zpools][:tank][:pool_size]).to match("130T")
+    end
+
+    it "Should have the correct pool allocated size" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:pool_allocated]).to match("66.2G")
+      expect(@plugin[:zpools][:tank][:pool_allocated]).to match("4.91M")
+    end
+
+    it "Should have the correct pool free size" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:pool_free]).to match("42.8G")
+      expect(@plugin[:zpools][:tank][:pool_free]).to match("130T")
+    end
+
+    it "Should have the correct capacity_used" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:capacity_used]).to match("60%")
+      expect(@plugin[:zpools][:tank][:capacity_used]).to match("0%")
+    end
+
+    it "Should have the correct dedup_factor" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:dedup_factor]).to match("1.00x")
+      expect(@plugin[:zpools][:tank][:dedup_factor]).to match("1.00x")
+    end
+
+    it "Should have the correct health" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:health]).to match("ONLINE")
+      expect(@plugin[:zpools][:tank][:health]).to match("ONLINE")
+    end
+
+    it "Should have the correct number of devices" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:devices].keys.size).to match(2)
+      expect(@plugin[:zpools][:tank][:devices].keys.size).to match(12)
+    end
+  end
+
+  describe "On OmniOS_151006" do
+    before(:each) do
+      @zpool_out = <<-EOZO
+rpool   109G    66.2G   42.8G   60%     1.00x   ONLINE  -
+tank    130T    4.91M   130T    0%      1.00x   ONLINE  -
+EOZO
+      @plugin.stub(:shell_out).with("zpool list -H -o name,size,alloc,free,cap,dedup,health,version").and_return(mock_shell_out(0,@zpool_out,""))
+    end
+
+    it "Won't have a version number" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:zpool_version]).to match("-")
+      expect(@plugin[:zpools][:tank][:zpool_version]).to match("-")
+    end
+
+  end
+
+  describe "On Solaris_11.1" do
+    before(:each) do
+      @zpool_out = <<-EOZO
+rpool   109G    66.2G   42.8G   60%     1.00x   ONLINE  34
+tank    130T    4.91M   130T    0%      1.00x   ONLINE  34
+EOZO
+      @plugin.stub(:shell_out).with("zpool list -H -o name,size,alloc,free,cap,dedup,health,version").and_return(mock_shell_out(0,@zpool_out,""))
+    end
+
+    it "Should have a version number" do
+      @plugin.run
+      expect(@plugin[:zpools][:rpool][:zpool_version]).to match("34")
+      expect(@plugin[:zpools][:tank][:zpool_version]).to match("34")
+    end
+
+  end
+end