ohai 6.24.2 → 7.0.0.rc.0

data/spec/unit/plugins/aix/platform_spec.rb

@@ -19,24 +19,25 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
 
 describe Ohai::System, "Aix plugin platform" do
   before(:each) do
-    @ohai = Ohai::System.new
-    @ohai[:kernel] = Mash.new
-    @ohai[:kernel][:name] = "aix"
-    @ohai[:kernel][:version] = "1"
-    @ohai[:kernel][:release] = "0"
-    @ohai.stub(:require_plugin).and_return(true)
-    @ohai._require_plugin("aix::platform")    
+    @plugin = get_plugin("aix/platform")
+    @plugin.stub(:collect_os).and_return(:aix)
+    kernel = Mash.new
+    kernel[:name] = "aix"
+    kernel[:version] = "1"
+    kernel[:release] = "0"
+    @plugin.stub(:kernel).and_return(kernel)
+    @plugin.run
   end
 
   it "should set platform to aix" do
-    @ohai[:platform].should == "aix"
+    @plugin[:platform].should == "aix"
   end
 
   it "should set the platform_version" do
-    @ohai[:platform_version].should == "1.0"
+    @plugin[:platform_version].should == "1.0"
   end
 
   it "should set platform_family" do
-    @ohai[:platform_family].should == @ohai[:platform]
+    @plugin[:platform_family].should == @plugin[:platform]
   end
 end

data/spec/unit/plugins/aix/uptime_spec.rb

@@ -20,21 +20,20 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
 describe Ohai::System, "Aix plugin uptime" do
 
   before(:each) do
-    @ohai = Ohai::System.new
-    @ohai[:os] = "aix"
-    @ohai._require_plugin("uptime")    
-    @ohai.stub(:popen4).with("who -b").and_yield(nil, StringIO.new, StringIO.new(" .  system boot  Jul  9 17:51"), nil)
-
+    @plugin = get_plugin("aix/uptime")
+    @plugin.stub(:collect_os).and_return(:aix)
     Time.stub_chain(:now, :to_i).and_return(1374258600)
     DateTime.stub_chain(:parse, :strftime, :to_i).and_return(1373392260)
-    @ohai._require_plugin("aix::uptime")                    
+    @plugin.stub(:shell_out).with("who -b").and_return(mock_shell_out(0, " .  system boot  Jul  9 17:51", nil))
+
+    @plugin.run              
   end
 
   it "should set uptime_seconds to uptime" do
-    @ohai[:uptime_seconds].should == 866340
+    @plugin[:uptime_seconds].should == 866340
   end
 
   it "should set uptime to a human readable date" do
-    @ohai[:uptime].should == "10 days 00 hours 39 minutes 00 seconds"
+    @plugin[:uptime].should == "10 days 00 hours 39 minutes 00 seconds"
   end
 end

data/spec/unit/plugins/azure_spec.rb

@@ -22,51 +22,50 @@ require 'open-uri'
 
 describe Ohai::System, "plugin azure" do
   before(:each) do
-    @ohai = Ohai::System.new
-    @ohai.stub!(:require_plugin).and_return(true)
+    @plugin = get_plugin("azure")
   end
 
   describe "with azure cloud file" do
     before(:each) do
-      File.stub!(:exist?).with('/etc/chef/ohai/hints/azure.json').and_return(true)
-      File.stub!(:read).with('/etc/chef/ohai/hints/azure.json').and_return('{"public_ip":"137.135.46.202","vm_name":"test-vm","public_fqdn":"service.cloudapp.net","public_ssh_port":"22", "public_winrm_port":"5985"}')
-      File.stub!(:exist?).with('C:\chef\ohai\hints/azure.json').and_return(true)
-      File.stub!(:read).with('C:\chef\ohai\hints/azure.json').and_return('{"public_ip":"137.135.46.202","vm_name":"test-vm","public_fqdn":"service.cloudapp.net","public_ssh_port":"22", "public_winrm_port":"5985"}')
-      @ohai._require_plugin("azure")
+      File.stub(:exist?).with('/etc/chef/ohai/hints/azure.json').and_return(true)
+      File.stub(:read).with('/etc/chef/ohai/hints/azure.json').and_return('{"public_ip":"137.135.46.202","vm_name":"test-vm","public_fqdn":"service.cloudapp.net","public_ssh_port":"22", "public_winrm_port":"5985"}')
+      File.stub(:exist?).with('C:\chef\ohai\hints/azure.json').and_return(true)
+      File.stub(:read).with('C:\chef\ohai\hints/azure.json').and_return('{"public_ip":"137.135.46.202","vm_name":"test-vm","public_fqdn":"service.cloudapp.net","public_ssh_port":"22", "public_winrm_port":"5985"}')
+      @plugin.run
     end
 
     it 'should set the azure cloud attributes' do
-      @ohai[:azure].should_not be_nil
-      @ohai[:azure]['public_ip'].should  == "137.135.46.202"
-      @ohai[:azure]['vm_name'].should == "test-vm"
-      @ohai[:azure]['public_fqdn'].should == "service.cloudapp.net"
-      @ohai[:azure]['public_ssh_port'].should == "22"
-      @ohai[:azure]['public_winrm_port'].should == "5985"
+      @plugin[:azure].should_not be_nil
+      @plugin[:azure]['public_ip'].should  == "137.135.46.202"
+      @plugin[:azure]['vm_name'].should == "test-vm"
+      @plugin[:azure]['public_fqdn'].should == "service.cloudapp.net"
+      @plugin[:azure]['public_ssh_port'].should == "22"
+      @plugin[:azure]['public_winrm_port'].should == "5985"
     end
 
   end
 
   describe "without azure cloud file" do
     before(:each) do
-      File.stub!(:exist?).with('/etc/chef/ohai/hints/azure.json').and_return(false)
-      File.stub!(:exist?).with('C:\chef\ohai\hints/azure.json').and_return(false)
+      File.stub(:exist?).with('/etc/chef/ohai/hints/azure.json').and_return(false)
+      File.stub(:exist?).with('C:\chef\ohai\hints/azure.json').and_return(false)
     end
 
     it 'should not behave like azure' do
-      @ohai[:azure].should be_nil
+      @plugin[:azure].should be_nil
     end
   end
 
   describe "with rackspace cloud file" do
     before(:each) do
-      File.stub!(:exist?).with('/etc/chef/ohai/hints/rackspace.json').and_return(true)
-      File.stub!(:read).with('/etc/chef/ohai/hints/rackspace.json').and_return('')
-      File.stub!(:exist?).with('C:\chef\ohai\hints/rackspace.json').and_return(true)
-      File.stub!(:read).with('C:\chef\ohai\hints/rackspace.json').and_return('')
+      File.stub(:exist?).with('/etc/chef/ohai/hints/rackspace.json').and_return(true)
+      File.stub(:read).with('/etc/chef/ohai/hints/rackspace.json').and_return('')
+      File.stub(:exist?).with('C:\chef\ohai\hints/rackspace.json').and_return(true)
+      File.stub(:read).with('C:\chef\ohai\hints/rackspace.json').and_return('')
     end
 
     it 'should not behave like azure' do
-      @ohai[:azure].should be_nil
+      @plugin[:azure].should be_nil
     end
   end
 

data/spec/unit/plugins/c_spec.rb

@@ -103,205 +103,206 @@ EOF
 describe Ohai::System, "plugin c" do
 
   before(:each) do
-    @ohai = Ohai::System.new
-    @ohai[:languages] = Mash.new
-    @ohai.stub!(:require_plugin).and_return(true)
+    @plugin = get_plugin("c")
+
+    @plugin[:languages] = Mash.new
     #gcc
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"gcc -v"}).and_return([0, "", C_GCC])
+    @plugin.stub(:shell_out).with("gcc -v").and_return(mock_shell_out(0, "", C_GCC))
     #glibc
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"/lib/libc.so.6"}).and_return([0, C_GLIBC_2_3_4, ""])
+    @plugin.stub(:shell_out).with("/lib/libc.so.6").and_return(mock_shell_out(0, C_GLIBC_2_3_4, ""))
     #ms cl
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"cl /\?"}).and_return([0, "", C_CL])
+    @plugin.stub(:shell_out).with("cl /\?").and_return(mock_shell_out(0, "", C_CL))
     #ms vs
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"devenv.com /\?"}).and_return([0, C_VS, ""])
+    @plugin.stub(:shell_out).with("devenv.com /\?").and_return(mock_shell_out(0, C_VS, ""))
     #ibm xlc
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"xlc -qversion"}).and_return([0, C_XLC, ""])
+    @plugin.stub(:shell_out).with("xlc -qversion").and_return(mock_shell_out(0, C_XLC, ""))
     #sun pro
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"cc -V -flags"}).and_return([0, "", C_SUN])
+    @plugin.stub(:shell_out).with("cc -V -flags").and_return(mock_shell_out(0, "", C_SUN))
     #hpux cc
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"what /opt/ansic/bin/cc"}).and_return([0, C_HPUX, ""])
+    @plugin.stub(:shell_out).with("what /opt/ansic/bin/cc").and_return(mock_shell_out(0, C_HPUX, ""))
   end
 
   #gcc
   it "should get the gcc version from running gcc -v" do
-    @ohai.should_receive(:run_command).with({:no_status_check=>true, :command=>"gcc -v"}).and_return([0, "", C_GCC])
-    @ohai._require_plugin("c")
+    @plugin.should_receive(:shell_out).with("gcc -v").and_return(mock_shell_out(0, "", C_GCC))
+    @plugin.run
   end
 
   it "should set languages[:c][:gcc][:version]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:gcc][:version].should eql("3.4.6")
+    @plugin.run
+    @plugin.languages[:c][:gcc][:version].should eql("3.4.6")
   end
 
   it "should set languages[:c][:gcc][:description]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:gcc][:description].should eql(C_GCC.split($/).last)
+    @plugin.run
+    @plugin.languages[:c][:gcc][:description].should eql(C_GCC.split($/).last)
   end
 
   it "should not set the languages[:c][:gcc] tree up if gcc command fails" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"gcc -v"}).and_return([1, "", ""])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:gcc) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("gcc -v").and_return(mock_shell_out(1, "", ""))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:gcc) if @plugin[:languages][:c]
   end
 
   #glibc
   it "should get the glibc x.x.x version from running /lib/libc.so.6" do
-    @ohai.should_receive(:run_command).with({:no_status_check=>true, :command=>"/lib/libc.so.6"}).and_return([0, C_GLIBC_2_3_4, ""])
-    @ohai._require_plugin("c")
+    @plugin.should_receive(:shell_out).with("/lib/libc.so.6").and_return(mock_shell_out(0, C_GLIBC_2_3_4, ""))
+    @plugin.run
   end
 
   it "should set languages[:c][:glibc][:version]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:glibc][:version].should eql("2.3.4")
+    @plugin.run
+    @plugin.languages[:c][:glibc][:version].should eql("2.3.4")
   end
 
   it "should set languages[:c][:glibc][:description]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:glibc][:description].should eql(C_GLIBC_2_3_4.split($/).first)
+    @plugin.run
+    @plugin.languages[:c][:glibc][:description].should eql(C_GLIBC_2_3_4.split($/).first)
   end
 
   it "should not set the languages[:c][:glibc] tree up if glibc command fails" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"/lib/libc.so.6"}).and_return([1, "", ""])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:glibc) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("/lib/libc.so.6").and_return(mock_shell_out(1, "", ""))
+    @plugin.stub(:shell_out).with("/lib64/libc.so.6").and_return(mock_shell_out(1, "", ""))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:glibc) if @plugin[:languages][:c]
   end
 
   it "should get the glibc x.x version from running /lib/libc.so.6" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"/lib/libc.so.6"}).and_return([0, C_GLIBC_2_5, ""])
-    @ohai.should_receive(:run_command).with({:no_status_check=>true, :command=>"/lib/libc.so.6"}).and_return([0, C_GLIBC_2_5, ""])
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:glibc][:version].should eql("2.5")
+    @plugin.stub(:shell_out).with("/lib/libc.so.6").and_return(mock_shell_out(0, C_GLIBC_2_5, ""))
+    @plugin.should_receive(:shell_out).with("/lib/libc.so.6").and_return(mock_shell_out(0, C_GLIBC_2_5, ""))
+    @plugin.run
+    @plugin.languages[:c][:glibc][:version].should eql("2.5")
   end
 
   #ms cl
   it "should get the cl version from running cl /?" do
-    @ohai.should_receive(:run_command).with({:no_status_check=>true, :command=>"cl /\?"}).and_return([0, "", C_CL])
-    @ohai._require_plugin("c")
+    @plugin.should_receive(:shell_out).with("cl /\?").and_return(mock_shell_out(0, "", C_CL))
+    @plugin.run
   end
 
   it "should set languages[:c][:cl][:version]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:cl][:version].should eql("14.00.50727.762")
+    @plugin.run
+    @plugin.languages[:c][:cl][:version].should eql("14.00.50727.762")
   end
 
   it "should set languages[:c][:cl][:description]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:cl][:description].should eql(C_CL.split($/).first)
+    @plugin.run
+    @plugin.languages[:c][:cl][:description].should eql(C_CL.split($/).first)
   end
 
   it "should not set the languages[:c][:cl] tree up if cl command fails" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"cl /\?"}).and_return([1, "", ""])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:cl) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("cl /\?").and_return(mock_shell_out(1, "", ""))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:cl) if @plugin[:languages][:c]
   end
 
   #ms vs
   it "should get the vs version from running devenv.com /?" do
-    @ohai.should_receive(:run_command).with({:no_status_check=>true, :command=>"devenv.com /\?"}).and_return([0, C_VS, ""])
-    @ohai._require_plugin("c")
+    @plugin.should_receive(:shell_out).with("devenv.com /\?").and_return(mock_shell_out(0, C_VS, ""))
+    @plugin.run
   end
 
   it "should set languages[:c][:vs][:version]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:vs][:version].should eql("8.0.50727.762")
+    @plugin.run
+    @plugin.languages[:c][:vs][:version].should eql("8.0.50727.762")
   end
 
   it "should set languages[:c][:vs][:description]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:vs][:description].should eql(C_VS.split($/)[1])
+    @plugin.run
+    @plugin.languages[:c][:vs][:description].should eql(C_VS.split($/)[1])
   end
 
   it "should not set the languages[:c][:vs] tree up if devenv command fails" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"devenv.com /\?"}).and_return([1, "", ""])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:vs) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("devenv.com /\?").and_return(mock_shell_out(1, "", ""))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:vs) if @plugin[:languages][:c]
   end
 
   #ibm xlc
   it "should get the xlc version from running xlc -qversion" do
-    @ohai.should_receive(:run_command).with({:no_status_check=>true, :command=>"xlc -qversion"}).and_return([0, C_XLC, ""])
-    @ohai._require_plugin("c")
+    @plugin.should_receive(:shell_out).with("xlc -qversion").and_return(mock_shell_out(0, C_XLC, ""))
+    @plugin.run
   end
 
   it "should set languages[:c][:xlc][:version]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:xlc][:version].should eql("9.0")
+    @plugin.run
+    @plugin.languages[:c][:xlc][:version].should eql("9.0")
   end
 
   it "should set languages[:c][:xlc][:description]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:xlc][:description].should eql(C_XLC.split($/).first)
+    @plugin.run
+    @plugin.languages[:c][:xlc][:description].should eql(C_XLC.split($/).first)
   end
 
   it "should not set the languages[:c][:xlc] tree up if xlc command fails" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"xlc -qversion"}).and_return([1, "", ""])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:xlc) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("xlc -qversion").and_return(mock_shell_out(1, "", ""))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:xlc) if @plugin[:languages][:c]
   end
 
   it "should set the languages[:c][:xlc] tree up if xlc exit status is 249" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"xlc -qversion"}).and_return([63744, "", ""])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:xlc) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("xlc -qversion").and_return(mock_shell_out(63744, "", ""))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:xlc) if @plugin[:languages][:c]
   end
 
   #sun pro
   it "should get the cc version from running cc -V -flags" do
-    @ohai.should_receive(:run_command).with({:no_status_check=>true, :command=>"cc -V -flags"}).and_return([0, "", C_SUN])
-    @ohai._require_plugin("c")
+    @plugin.should_receive(:shell_out).with("cc -V -flags").and_return(mock_shell_out(0, "", C_SUN))
+    @plugin.run
   end
 
   it "should set languages[:c][:sunpro][:version]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:sunpro][:version].should eql("5.8")
+    @plugin.run
+    @plugin.languages[:c][:sunpro][:version].should eql("5.8")
   end
 
   it "should set languages[:c][:sunpro][:description]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:sunpro][:description].should eql(C_SUN.chomp)
+    @plugin.run
+    @plugin.languages[:c][:sunpro][:description].should eql(C_SUN.chomp)
   end
 
   it "should not set the languages[:c][:sunpro] tree up if cc command fails" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"cc -V -flags"}).and_return([1, "", ""])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:sunpro) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("cc -V -flags").and_return(mock_shell_out(1, "", ""))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:sunpro) if @plugin[:languages][:c]
   end
 
-
   it "should not set the languages[:c][:sunpro] tree if the corresponding cc command fails on linux" do
     fedora_error_message = "cc: error trying to exec 'i686-redhat-linux-gcc--flags': execvp: No such file or directory"
 
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"cc -V -flags"}).and_return([0, "", fedora_error_message])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:sunpro) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("cc -V -flags").and_return(mock_shell_out(0, "", fedora_error_message))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:sunpro) if @plugin[:languages][:c]
   end
 
   it "should not set the languages[:c][:sunpro] tree if the corresponding cc command fails on hpux" do
     hpux_error_message = "cc: warning 901: unknown option: `-flags': use +help for online documentation.\ncc: HP C/aC++ B3910B A.06.25 [Nov 30 2009]"
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"cc -V -flags"}).and_return([0, "", hpux_error_message])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:sunpro) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("cc -V -flags").and_return(mock_shell_out(0, "", hpux_error_message))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:sunpro) if @plugin[:languages][:c]
   end
 
   #hpux cc
   it "should get the cc version from running what cc" do
-    @ohai.should_receive(:run_command).with({:no_status_check=>true, :command=>"what /opt/ansic/bin/cc"}).and_return([0, C_HPUX, ""])
-    @ohai._require_plugin("c")
+    @plugin.should_receive(:shell_out).with("what /opt/ansic/bin/cc").and_return(mock_shell_out(0, C_HPUX, ""))
+    @plugin.run
   end
 
   it "should set languages[:c][:hpcc][:version]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:hpcc][:version].should eql("B.11.11.16")
+    @plugin.run
+    @plugin.languages[:c][:hpcc][:version].should eql("B.11.11.16")
   end
 
   it "should set languages[:c][:hpcc][:description]" do
-    @ohai._require_plugin("c")
-    @ohai.languages[:c][:hpcc][:description].should eql(C_HPUX.split($/)[3].strip)
+    @plugin.run
+    @plugin.languages[:c][:hpcc][:description].should eql(C_HPUX.split($/)[3].strip)
   end
 
   it "should not set the languages[:c][:hpcc] tree up if cc command fails" do
-    @ohai.stub!(:run_command).with({:no_status_check=>true, :command=>"what /opt/ansic/bin/cc"}).and_return([1, "", ""])
-    @ohai._require_plugin("c")
-    @ohai[:languages][:c].should_not have_key(:hpcc) if @ohai[:languages][:c]
+    @plugin.stub(:shell_out).with("what /opt/ansic/bin/cc").and_return(mock_shell_out(1, "", ""))
+    @plugin.run
+    @plugin[:languages][:c].should_not have_key(:hpcc) if @plugin[:languages][:c]
   end
+
 end

data/spec/unit/plugins/chef_spec.rb

@@ -25,18 +25,17 @@ begin
   
   describe Ohai::System, "plugin chef" do
     before(:each) do
-      @ohai = Ohai::System.new
-      @ohai.stub!(:require_plugin).and_return(true)
+      @plugin = get_plugin("chef")
     end
-    
+
     it "should set [:chef_packages][:chef][:version] to the current chef version", :if => defined?(Chef) do
-      @ohai._require_plugin("chef")
-      @ohai[:chef_packages][:chef][:version].should == Chef::VERSION
+      @plugin.run
+      @plugin[:chef_packages][:chef][:version].should == Chef::VERSION
     end
   
     pending "would set [:chef_packages][:chef][:version] if chef was available", :unless => defined?(Chef)
-  
   end
+  
 rescue LoadError
   # the chef module is not available, ignoring.