ohai 18.1.18 → 19.1.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba5e0cd23be58860dbaeaa8215628de72afb4ca181235acacd356064c8cdcdb6
-  data.tar.gz: 8059d2d3e7bf4c4a68b75f926165929446a3dbe280402438eba20be552c05fec
+  metadata.gz: 6339d53754721217929ead82d4a232ace638f648d5e7ba2469221dfd22da54a0
+  data.tar.gz: 28eda66502f23a2bacf4c96407fb89193023fe76cd5f30f0ab839096def6e044
 SHA512:
-  metadata.gz: 5161f55dba454fff218dd4545a940cb0b324e3802930bf01b3b0d62730026d470961d4138259c4b6c8f76e3ed4059eb98e1a37b188823e02808d1e35817254e3
-  data.tar.gz: 27e98bd57c54192067a797a1303466becf7fa0eff0448665b35782613abbe238ae8c623192afd0ac6acd270a313212384e25c98373b0f101cd766dbece762358
+  metadata.gz: c33166e19c09e55f3b28d9ee437a350666b7241b949e0b45bc1e4cc27118bc86130f2c6520c7a136de879d3e72fde0254cadbe3d562646abc7298cbb8b437731
+  data.tar.gz: ffd0515bda588dee888dcd1deed4a8d1275b35ddbb55d7b8913b5e87203781628820f0417df55847da3e27a2cec85b2df2e7a2cb7dcb632b9f1181d2f0575e03

data/Gemfile

@@ -1,23 +1,23 @@
 # frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gemspec
 
-# pull these gems from main of chef/chef so that we're testing against what we will release
+# pull these gems from main of chef/chef so that we"re testing against what we will release
+gem "appbundler"
 gem "chef-config", git: "https://github.com/chef/chef", branch: "main", glob: "chef-config/chef-config.gemspec"
 gem "chef-utils", git: "https://github.com/chef/chef", branch: "main", glob: "chef-utils/chef-utils.gemspec"
-
+gem "ffi", "~> 1.17", force_ruby_platform: true
 # NOTE: do not submit PRs to add pry as a dep, add to your Gemfile.local
 group :development do
-  gem "chefstyle", "2.2.2"
+  gem "cookstyle", ">= 7.32.8"
   gem "ipaddr_extensions"
   gem "rake", ">= 10.1.0"
   gem "rspec-collection_matchers", "~> 1.0"
   gem "rspec-core", "~> 3.0"
   gem "rspec-expectations", "~> 3.0"
   gem "rspec-mocks", "~> 3.0"
-  gem "rubocop-performance", "1.18.0"
-  gem "rubocop-rspec"
 end
 
 group :debug do

data/lib/ohai/application.rb

@@ -49,7 +49,7 @@ class Ohai::Application
     short: "-l LEVEL",
     long: "--log_level LEVEL",
     description: "Set the log level (debug, info, warn, error, fatal)",
-    proc: lambda { |l| l.to_sym }
+    proc: lambda(&:to_sym)
 
   option :log_location,
     short: "-L LOGLOCATION",

data/lib/ohai/dsl/plugin/versionvii.rb

@@ -149,11 +149,11 @@ module Ohai
         end
 
         def provides(*paths)
-          logger.warn("[UNSUPPORTED OPERATION] \'provides\' is no longer supported in a \'collect_data\' context. Please specify \'provides\' before collecting plugin data. Ignoring command \'provides #{paths.join(", ")}")
+          logger.warn("[UNSUPPORTED OPERATION] 'provides' is no longer supported in a 'collect_data' context. Please specify 'provides' before collecting plugin data. Ignoring command 'provides #{paths.join(", ")}")
         end
 
         def require_plugin(*args)
-          logger.warn("[UNSUPPORTED OPERATION] \'require_plugin\' is no longer supported. Please use \'depends\' instead.\nIgnoring plugin(s) #{args.join(", ")}")
+          logger.warn("[UNSUPPORTED OPERATION] 'require_plugin' is no longer supported. Please use 'depends' instead.\nIgnoring plugin(s) #{args.join(", ")}")
         end
 
         def configuration(option, *options)

data/lib/ohai/loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Claire McQuin (<claire@chef.io>)
 # Copyright:: Copyright (c) Chef Software Inc.
@@ -97,10 +98,10 @@ module Ohai
     # @return [Object] class object for the ohai plugin defined in the file
     def load_plugin_class(plugin_path)
       # Read the contents of the plugin to understand if it's a V6 or V7 plugin.
-      contents = ""
+      contents = nil
       begin
         logger.trace("Loading plugin at #{plugin_path}")
-        contents << IO.read(plugin_path)
+        contents = File.read(plugin_path)
       rescue IOError, Errno::ENOENT
         logger.warn("Unable to open or read plugin at #{plugin_path}")
         return nil
@@ -110,9 +111,9 @@ module Ohai
       if contents.include?("Ohai.plugin")
         load_v7_plugin_class(contents, plugin_path)
       else
-        raise Exceptions::IllegalPluginDefinition, "[DEPRECATION] Plugin at #{plugin_path}"\
-        " is a version 6 plugin. Version 6 plugins are no longer supported by Ohai. This"\
-        " plugin will need to be updated to the v7 Ohai plugin format. See"\
+        raise Exceptions::IllegalPluginDefinition, "[DEPRECATION] Plugin at #{plugin_path}" \
+        " is a version 6 plugin. Version 6 plugins are no longer supported by Ohai. This" \
+        " plugin will need to be updated to the v7 Ohai plugin format. See" \
         " https://docs.chef.io/ohai_custom.html for v7 syntax."
       end
     end
@@ -151,7 +152,7 @@ module Ohai
     rescue Ohai::Exceptions::IllegalPluginDefinition => e
       logger.warn("Plugin Definition Error: <#{plugin_path}>: #{e.message}")
     rescue NoMethodError => e
-      logger.warn("Plugin Method Error: <#{plugin_path}>: unsupported operation \'#{e.name}\'")
+      logger.warn("Plugin Method Error: <#{plugin_path}>: unsupported operation '#{e.name}'")
     rescue SyntaxError => e
       # split on occurrences of
       #    <env>: syntax error,

data/lib/ohai/mixin/ec2_metadata.rb

@@ -248,8 +248,14 @@ module Ohai
       private
 
       def expand_path(file_name)
-        path = file_name.gsub(/\=.*$/, "/")
-        # ignore "./" and "../"
+        # First substitution - exactly matches original behavior but safer
+        path = if file_name.include?("=")
+                 file_name[0...file_name.index("=")] + "/"
+               else
+                 file_name.dup
+               end
+
+        # Handle relative path components
         path.gsub(%r{/\.\.?(?:/|$)}, "/")
           .sub(%r{^\.\.?(?:/|$)}, "")
           .sub(/^$/, "/")

data/lib/ohai/mixin/oci_metadata.rb

@@ -28,6 +28,39 @@ module Ohai
       OCI_METADATA_URL = "/opc/v2"
       CHASSIS_ASSET_TAG_FILE = "/sys/devices/virtual/dmi/id/chassis_asset_tag"
 
+      # Get the chassis asset tag from DMI information
+      # On Linux: reads from sysfs
+      # On Windows: queries WMI Win32_SystemEnclosure
+      def chassis_asset_tag
+        if RUBY_PLATFORM =~ /mswin|mingw|windows/
+          get_chassis_asset_tag_windows
+        else
+          get_chassis_asset_tag_linux
+        end
+      end
+
+      # Read chassis asset tag from Linux sysfs
+      def get_chassis_asset_tag_linux
+        return unless ::File.exist?(CHASSIS_ASSET_TAG_FILE)
+
+        ::File.read(CHASSIS_ASSET_TAG_FILE).strip
+      rescue => e
+        logger.debug("Mixin OciMetadata: Failed to read chassis asset tag from #{CHASSIS_ASSET_TAG_FILE}: #{e}")
+        nil
+      end
+
+      # Read chassis asset tag from Windows WMI
+      def get_chassis_asset_tag_windows
+        require "wmi-lite/wmi" unless defined?(WmiLite::Wmi)
+
+        wmi = WmiLite::Wmi.new
+        enclosure = wmi.first_of("Win32_SystemEnclosure")
+        enclosure&.[]("SMBIOSAssetTag")
+      rescue => e
+        logger.debug("Mixin OciMetadata: Failed to read chassis asset tag from WMI: #{e}")
+        nil
+      end
+
       # fetch the meta content with a timeout and the required header
       def http_get(uri)
         conn = Net::HTTP.start(OCI_METADATA_ADDR)
@@ -51,7 +84,7 @@ module Ohai
           end
           json_data
         else
-          logger.warn("Mixin OciMetadata: Received response code #{response.code} requesting metadata")
+          logger.debug("Mixin OciMetadata: Received response code #{response.code} requesting #{metadata}")
           nil
         end
       end

data/lib/ohai/mixin/string.rb

@@ -25,7 +25,7 @@ class String
   # ActiveSupport::CoreExtensions::String::Inflections
   # @return [String]
   def wmi_underscore
-    gsub(/::/, "/").gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
+    gsub("::", "/").gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
       .gsub(/([a-z\d])([A-Z])/, '\1_\2').tr("-", "_").downcase
   end
 end

data/lib/ohai/plugins/aix/kernel.rb

@@ -26,11 +26,11 @@ Ohai.plugin(:Kernel) do
 
     uname_so = shell_out("uname -rvp").stdout.split
 
-    kernel[:name] =    "aix" # this is here for historical reasons, but it's always aix
+    kernel[:name] = "aix" # this is here for historical reasons, but it's always aix
     kernel[:release] = uname_so[0]
     kernel[:version] = uname_so[1]
     kernel[:machine] = uname_so[2]
-    kernel[:bits] =    shell_out("getconf KERNEL_BITMODE").stdout.strip
+    kernel[:bits] = shell_out("getconf KERNEL_BITMODE").stdout.strip
 
     modules = Mash.new
     so = shell_out("genkex -d")

data/lib/ohai/plugins/aix/network.rb

@@ -120,7 +120,7 @@ Ohai.plugin(:Network) do
           interface = $6
           ifaces[interface][:routes] ||= []
           ifaces[interface][:routes] << Mash.new( destination: $1, family: family,
-                                                  via: $2, flags: $3)
+            via: $2, flags: $3)
         end
       end
     end

data/lib/ohai/plugins/aix/virtualization.rb

@@ -143,7 +143,7 @@ Ohai.plugin(:Virtualization) do
           evalstr = "wpars['#{wpar_name}']"
           breadcrumb = attribute.split(".")
           breadcrumb.each do |node|
-            evalstr << "[\'#{node}\']"
+            evalstr << "['#{node}']"
           end
           wpars[wpar_name][breadcrumb[-1]] = eval evalstr # rubocop: disable Security/Eval
         end

data/lib/ohai/plugins/alibaba.rb

@@ -54,7 +54,7 @@ Ohai.plugin(:Alibaba) do
   # a single check that combines all the various detection methods for Alibaba
   # @return [Boolean] Does the system appear to be on Alibaba
   def looks_like_alibaba?
-    return true if hint?("alibaba") || has_ali_dmi?
+    hint?("alibaba") || has_ali_dmi?
   end
 
   collect_data do

data/lib/ohai/plugins/cpu.rb

@@ -63,7 +63,8 @@ Ohai.plugin(:CPU) do
   def parse_lscpu(cpu_info)
     lscpu_info = Mash.new
     begin
-      so = shell_out("lscpu")
+      # Pipe to cat to retain previous output on newer util-linux (see lscpu(1))
+      so = shell_out("lscpu | cat")
       cpu_cores = shell_out("lscpu -p=CPU,CORE,SOCKET")
       if so.exitstatus == 0 && cpu_cores.exitstatus == 0
         lscpu_info[:numa_node_cpus] = Mash.new
@@ -96,10 +97,12 @@ Ohai.plugin(:CPU) do
             end
           when /^Thread\(s\) per core:\s+(.+)/ # http://rubular.com/r/lOw2pRrw1q
             lscpu_info[:threads_per_core] = $1.to_i
-          when /^Core\(s\) per socket:\s+(.+)/ # http://rubular.com/r/lOw2pRrw1q
+          when /^Core\(s\) per (?:socket|cluster):\s+(.+)/ # http://rubular.com/r/lOw2pRrw1q
             lscpu_info[:cores_per_socket] = $1.to_i
           when /^Socket\(s\):\s+(.+)/ # http://rubular.com/r/DIzmPtJFvK
             lscpu_info[:sockets] = $1.to_i
+          when /^Clusters\(s\):\s+(.+)/
+            lscpu_info[:clusters] = $1.to_i
           when /^Socket\(s\) per book:\s+(.+)/
             lscpu_info[:sockets_per_book] = $1.to_i
           when /^Book\(s\) per drawer:\s+(.+)/
@@ -110,6 +113,10 @@ Ohai.plugin(:CPU) do
             lscpu_info[:numa_nodes] = $1.to_i
           when /^Vendor ID:\s+(.+)/
             lscpu_info[:vendor_id] = $1
+          when /^BIOS Vendor ID:\s+(.+)/
+            lscpu_info[:bios_vendor_id] = $1
+          when /^BIOS Model name:\s+(.+)/
+            lscpu_info[:bios_model_name] = $1.strip
           when /^Machine type:\s+(.+)/
             lscpu_info[:machine_type] = $1
           when /^CPU family:\s+(.+)/
@@ -630,6 +637,6 @@ Ohai.plugin(:CPU) do
 
     cpu[:total] = logical_processors
     cpu[:cores] = cores
-    cpu[:real] =  processors.length
+    cpu[:real] = processors.length
   end
 end

data/lib/ohai/plugins/darwin/virtualization.rb

@@ -36,7 +36,7 @@ Ohai.plugin(:Virtualization) do
   end
 
   def fusion_exists?
-    file_exist?("/Applications/VMware\ Fusion.app/")
+    file_exist?("/Applications/VMware Fusion.app/")
   end
 
   def docker_exists?

data/lib/ohai/plugins/ec2.rb

@@ -108,7 +108,11 @@ Ohai.plugin(:EC2) do
   end
 
   collect_data do
-    require "base64" unless defined?(Base64)
+    begin
+      require "base64" unless defined?(Base64)
+    rescue LoadError
+      logger.warn("Plugin EC2: base64 gem not found. Binary userdata will not be properly encoded.")
+    end
 
     if looks_like_ec2?
       logger.trace("Plugin EC2: looks_like_ec2? == true")

data/lib/ohai/plugins/eucalyptus.rb

@@ -29,7 +29,7 @@ Ohai.plugin(:Eucalyptus) do
   provides "eucalyptus"
   depends "network/interfaces"
 
-  MAC_MATCH = /^[dD]0:0[dD]:/.freeze unless defined?(MAC_MATCH)
+  MAC_MATCH = /^[dD]0:0[dD]:/ unless defined?(MAC_MATCH)
 
   # returns the mac address from the collection of all address types
   def get_mac_address(addresses)

data/lib/ohai/plugins/filesystem.rb

@@ -276,19 +276,21 @@ Ohai.plugin(:Filesystem) do
     if entry[:fs_type] == "btrfs" && entry["uuid"]
       uuid = entry["uuid"]
       alloc = "/sys/fs/btrfs/#{uuid}/allocation"
-      %w{data metadata system}.each do |bg_type|
-        dir = "#{alloc}/#{bg_type}"
-        %w{single dup}.each do |raid|
-          if file_exist?("#{dir}/#{raid}")
-            btrfs["raid"] = raid
+      if Dir.exist?(alloc)
+        %w{data metadata system}.each do |bg_type|
+          dir = "#{alloc}/#{bg_type}"
+          %w{single dup}.each do |raid|
+            if file_exist?("#{dir}/#{raid}")
+              btrfs["raid"] = raid
+            end
+          end
+          logger.trace("Plugin Filesystem: reading btrfs allocation files at #{dir}")
+          btrfs["allocation"] ||= Mash.new
+          btrfs["allocation"][bg_type] ||= Mash.new
+          %w{total_bytes bytes_used}.each do |field|
+            bytes = file_read("#{dir}/#{field}").chomp.to_i
+            btrfs["allocation"][bg_type][field] = "#{bytes}"
           end
-        end
-        logger.trace("Plugin Filesystem: reading btrfs allocation files at #{dir}")
-        btrfs["allocation"] ||= Mash.new
-        btrfs["allocation"][bg_type] ||= Mash.new
-        %w{total_bytes bytes_used}.each do |field|
-          bytes = file_read("#{dir}/#{field}").chomp.to_i
-          btrfs["allocation"][bg_type][field] = "#{bytes}"
         end
       end
     end
@@ -742,10 +744,6 @@ Ohai.plugin(:Filesystem) do
     fs_data["by_mountpoint"] = by_mountpoint
     fs_data["by_pair"] = by_pair
 
-    # Chef 16 added 'filesystem2'
-    # In Chef 17 we made 'filesystem' and 'filesystem2' match (both new-style)
-    # In Chef 18 we will drop 'filesystem2'
     filesystem fs_data
-    filesystem2 fs_data
   end
 end

data/lib/ohai/plugins/freebsd/network.rb

@@ -43,7 +43,7 @@ Ohai.plugin(:Network) do
     so = shell_out("#{Ohai.abs_path( "/sbin/ifconfig" )} -a")
     cint = nil
     so.stdout.lines do |line|
-      if line =~ /^([0-9a-zA-Z\.]+):\s+/
+      if line =~ /^([0-9a-zA-Z\._]+):\s+/
         cint = $1
         iface[cint] = Mash.new
         if cint =~ /^(\w+)(\d+.*)/
@@ -80,10 +80,13 @@ Ohai.plugin(:Network) do
         flags = $1.split(",")
         iface[cint][:flags] = flags if flags.length > 0
       end
-      if line =~ /metric: (\d+) mtu: (\d+)/
+      if line =~ /metric (\d+) mtu (\d+)/
         iface[cint][:metric] = $1
         iface[cint][:mtu] = $2
       end
+      if line =~ /media: (\w+)/
+        iface[cint][:encapsulation] = $1
+      end
     end
 
     so = shell_out("arp -an")
@@ -104,22 +107,44 @@ Ohai.plugin(:Network) do
     # which have been auto-configured (interfaces statically configured
     # into a system, but not located at boot time are not shown).
     so = shell_out("netstat -ibdn")
-    so.stdout.lines do |line|
+    head = so.stdout.lines[0]
+    have_drop = false
+    if head =~ /Idrop/
+      have_drop = true
+      # Name     Mtu Network                  Address                                   Ipkts Ierrs Idrop     Ibytes    Opkts Oerrs     Obytes  Coll  Drop
+      # vtnet0  1500 <Link#1>                 fa:16:3e:ba:3e:25                           579     0     0      46746      210     0      26242     0     0
+      # $1                                    $2                                           $3    $4    $5         $6       $7    $8         $9   $10   $11
+      regex = /^([\w\.\*]+)\s+\d+\s+<Link#\d+>\s+([\w\d:]*)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)/
+    else
       # Name    Mtu Network       Address              Ipkts Ierrs     Ibytes    Opkts Oerrs     Obytes  Coll Drop
       # ed0    1500 <Link#1>      54:52:00:68:92:85   333604    26  151905886   175472     0   24897542     0  905
       # $1                        $2                      $3    $4         $5       $6    $7         $8    $9  $10
-      if line =~ /^([\w\.\*]+)\s+\d+\s+<Link#\d+>\s+([\w:]*)\s*(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)/
+      regex = /^([\w\.\*]+)\s+\d+\s+<Link#\d+>\s+([\w\d:]*)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)/
+    end
+    so.stdout.lines do |line|
+      if line =~ regex
         net_counters[$1] ||= Mash.new
         net_counters[$1]["rx"] ||= Mash.new
         net_counters[$1]["tx"] ||= Mash.new
         net_counters[$1]["rx"]["packets"] = $3
         net_counters[$1]["rx"]["errors"] = $4
-        net_counters[$1]["rx"]["bytes"] = $5
-        net_counters[$1]["tx"]["packets"] = $6
-        net_counters[$1]["tx"]["errors"] = $7
-        net_counters[$1]["tx"]["bytes"] = $8
-        net_counters[$1]["tx"]["collisions"] = $9
-        net_counters[$1]["tx"]["dropped"] = $10
+        if have_drop
+          net_counters[$1]["rx"]["dropped"] = $5
+          net_counters[$1]["rx"]["bytes"] = $6
+          net_counters[$1]["tx"]["packets"] = $7
+          net_counters[$1]["tx"]["errors"] = $8
+          net_counters[$1]["tx"]["bytes"] = $9
+          net_counters[$1]["tx"]["collisions"] = $10
+          net_counters[$1]["tx"]["dropped"] = $11
+        else
+          net_counters[$1]["rx"]["bytes"] = $5
+          net_counters[$1]["tx"]["packets"] = $6
+          net_counters[$1]["tx"]["errors"] = $7
+          net_counters[$1]["tx"]["bytes"] = $8
+          net_counters[$1]["tx"]["collisions"] = $9
+          net_counters[$1]["tx"]["dropped"] = $10
+        end
+
       end
     end
 

data/lib/ohai/plugins/gce.rb

@@ -72,7 +72,7 @@ Ohai.plugin(:GCE) do
     return true if hint?("gce")
 
     if has_gce_dmi? || has_gce_system_info?
-      return true if can_socket_connect?(Ohai::Mixin::GCEMetadata::GCE_METADATA_ADDR, 80)
+      can_socket_connect?(Ohai::Mixin::GCEMetadata::GCE_METADATA_ADDR, 80)
     end
   end
 

data/lib/ohai/plugins/linux/interrupts.rb

@@ -27,9 +27,8 @@ Ohai.plugin(:Interrupts) do
   # each bit is a CPU, right to left ordering (i.e. CPU0 is rightmost)
   def parse_smp_affinity(path, cpus)
     masks = file_read(path).strip
-    bit_masks = []
-    masks.split(",").each do |mask|
-      bit_masks << mask.rjust(8, "0").to_i(16).to_s(2)
+    bit_masks = masks.split(",").map do |mask|
+      mask.rjust(8, "0").to_i(16).to_s(2)
     end
     affinity_mask = bit_masks.join
     affinity_by_cpu = affinity_mask.split("").reverse

data/lib/ohai/plugins/linux/network.rb

@@ -104,7 +104,7 @@ Ohai.plugin(:Network) do
       end
       route_endings.each do |route_ending|
         route_entry = Mash.new(destination: route_dest,
-                               family: family[:name])
+          family: family[:name])
         route_int = nil
         if route_ending =~ /\bdev\s+([^\s]+)\b/
           route_int = $1
@@ -578,6 +578,8 @@ Ohai.plugin(:Network) do
 
   # returns the macaddress for interface from a hash of interfaces (iface elsewhere in this file)
   def get_mac_for_interface(interfaces, interface)
+    return "00:00:00:00:00:00" if interfaces[interface][:flags].include?("LOOPBACK")
+
     interfaces[interface][:addresses].find { |k, v| v["family"] == "lladdr" }.first unless interfaces[interface][:addresses].nil? || interfaces[interface][:flags].include?("NOARP")
   end
 
@@ -700,7 +702,7 @@ Ohai.plugin(:Network) do
     # Match the lead line for an interface from iproute2
     # 3: eth0.11@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP
     # The '@eth0:' portion doesn't exist on primary interfaces and thus is optional in the regex
-    IPROUTE_INT_REGEX ||= /^(\d+): ([0-9a-zA-Z@:\.\-_]*?)(@[0-9a-zA-Z\-_]+|):\s/.freeze
+    IPROUTE_INT_REGEX ||= /^(\d+): ([0-9a-zA-Z@:;\.\-_]*?)(@[0-9a-zA-Z\-_]+|):\s/
 
     if which("ip")
       # families to get default routes from

data/lib/ohai/plugins/oci.rb

@@ -44,24 +44,22 @@ Ohai.plugin(:Oci) do
   end
 
   def oci_chassis_asset_tag?
-    has_oci_chassis_asset_tag = false
-    if file_exist?(Ohai::Mixin::OCIMetadata::CHASSIS_ASSET_TAG_FILE)
-      file_open(Ohai::Mixin::OCIMetadata::CHASSIS_ASSET_TAG_FILE).each do |line|
-        next unless /OracleCloud.com/.match?(line)
-
-        logger.trace("Plugin oci: Found OracleCloud.com chassis_asset_tag used by oci.")
-        has_oci_chassis_asset_tag = true
-        break
-      end
+    asset_tag = chassis_asset_tag
+    return false if asset_tag.nil? || asset_tag.empty?
+
+    if /OracleCloud.com/.match?(asset_tag)
+      logger.trace("Plugin oci: Found OracleCloud.com chassis_asset_tag used by oci.")
+      true
+    else
+      false
     end
-    has_oci_chassis_asset_tag
   end
 
   def parse_metadata
-    return nil unless can_socket_connect?(Ohai::Mixin::OCIMetadata::OCI_METADATA_ADDR, 80)
+    return unless can_socket_connect?(Ohai::Mixin::OCIMetadata::OCI_METADATA_ADDR, 80)
 
     instance_data = fetch_metadata("instance")
-    return nil if instance_data.nil?
+    return if instance_data.nil?
 
     metadata = Mash.new
     metadata["compute"] = Mash.new
@@ -80,12 +78,14 @@ Ohai.plugin(:Oci) do
       end
     end
 
-    volume_attachments_data = fetch_metadata("volumeAttachments")
+    volume_attachments_data = fetch_metadata("allVolumeAttachments")
 
     unless volume_attachments_data.nil?
       metadata["volumes"] = Mash.new
-      volume_attachments_data.each do |k, v|
-        metadata["volumes"][k] = v
+      volume_attachments_data.each do |v|
+        if v.is_a?(Hash) && v["id"]
+          metadata["volumes"][v["id"]] = v
+        end
       end
     end
 

data/lib/ohai/plugins/passwd.rb

@@ -31,7 +31,7 @@ Ohai.plugin(:Passwd) do
 
       Etc.group do |entry|
         group_entry = Mash.new(gid: entry.gid,
-                               members: entry.mem.map { |u| fix_encoding(u) })
+          members: entry.mem.map { |u| fix_encoding(u) })
 
         etc[:group][fix_encoding(entry.name)] = group_entry
       end

data/lib/ohai/plugins/platform.rb

@@ -18,12 +18,24 @@
 #
 
 Ohai.plugin(:Platform) do
-  provides "platform", "platform_version", "platform_family"
+  provides "platform", "platform_version", "platform_family", "platform_backend"
   depends "os", "os_version"
 
   collect_data(:default) do
     platform os unless attribute?("platform")
     platform_version os_version unless attribute?("platform_version")
     platform_family platform unless attribute?("platform_family")
+
+    platform_backend Mash.new
+    platform_backend["type"] = "local"
+    platform_backend["uri"] = "local://"
+
+    if connection
+      platform_backend["type"] = connection.backend_type
+      if connection.respond_to?(:uri)
+        platform_backend["type"] = connection.uri.split(":").first
+        platform_backend["uri"] = connection.uri
+      end
+    end
   end
 end

data/lib/ohai/plugins/rackspace.rb

@@ -115,7 +115,7 @@ Ohai.plugin(:Rackspace) do
   def get_instance_id
     so = shell_out("xenstore-read name")
     if so.exitstatus == 0
-      rackspace[:instance_id] = so.stdout.gsub(/instance-/, "")
+      rackspace[:instance_id] = so.stdout.gsub("instance-", "")
     end
   rescue Ohai::Exceptions::Exec
     logger.trace("Plugin Rackspace: Unable to find xenstore-read, cannot capture instance ID information for Rackspace cloud")

data/lib/ohai/plugins/rpm.rb

@@ -22,7 +22,7 @@ Ohai.plugin(:Rpm) do
   provides "rpm"
   optional "true"
 
-  MACROS_MARKER = /========================/.freeze unless defined?(MACROS_MARKER)
+  MACROS_MARKER = /========================/ unless defined?(MACROS_MARKER)
 
   unless defined?(DO_NOT_SPLIT)
     DO_NOT_SPLIT = %w{

data/lib/ohai/plugins/windows/dmi.rb

@@ -37,7 +37,7 @@ Ohai.plugin(:DMI) do
   #
   # This cannot handle some property names, eg SMBIOSBIOSVersion.
   # https://rubular.com/r/FBNtXod4wkZGAG
-  SPLIT_REGEX ||= /[A-Z][a-z0-9]+|[A-Z]{2,}(?=[A-Z][a-z0-9])|[A-Z]{2,}/.freeze
+  SPLIT_REGEX ||= /[A-Z][a-z0-9]+|[A-Z]{2,}(?=[A-Z][a-z0-9])|[A-Z]{2,}/
 
   WINDOWS_TO_UNIX_KEYS ||= [
     %w{vendor manufacturer},

data/lib/ohai/plugins/windows/network.rb

@@ -41,7 +41,7 @@ Ohai.plugin(:Network) do
       # If we are running on windows nano or another operating system from the future
       # that does not populate the deprecated win32_* WMI classes, then we should
       # grab data from the newer MSFT_* classes
-      return msft_adapter_data if data[:addresses].count == 0
+      return msft_adapter_data if data[:addresses].none?
 
       data[:adapters] = wmi.instances_of("Win32_NetworkAdapter")
       data

data/lib/ohai/provides_map.rb

@@ -65,8 +65,8 @@ module Ohai
       plugins = []
       attributes.each do |attribute|
         attrs = select_subtree(@map, attribute)
-        raise Ohai::Exceptions::AttributeNotFound, "No such attribute: \'#{attribute}\'" unless attrs
-        raise Ohai::Exceptions::ProviderNotFound, "Cannot find plugin providing attribute: \'#{attribute}\'" unless attrs[:_plugins]
+        raise Ohai::Exceptions::AttributeNotFound, "No such attribute: '#{attribute}'" unless attrs
+        raise Ohai::Exceptions::ProviderNotFound, "Cannot find plugin providing attribute: '#{attribute}'" unless attrs[:_plugins]
 
         plugins += attrs[:_plugins]
       end
@@ -93,7 +93,7 @@ module Ohai
           attrs = select_closest_subtree(@map, attribute)
 
           unless attrs
-            raise Ohai::Exceptions::AttributeNotFound, "No such attribute: \'#{attribute}\'"
+            raise Ohai::Exceptions::AttributeNotFound, "No such attribute: '#{attribute}'"
           end
         end
 
@@ -115,10 +115,10 @@ module Ohai
       plugins = []
       attributes.each do |attribute|
         parts = normalize_and_validate(attribute)
-        raise Ohai::Exceptions::AttributeNotFound, "No such attribute: \'#{attribute}\'" unless @map[parts[0]]
+        raise Ohai::Exceptions::AttributeNotFound, "No such attribute: '#{attribute}'" unless @map[parts[0]]
 
         attrs = select_closest_subtree(@map, attribute)
-        raise Ohai::Exceptions::ProviderNotFound, "Cannot find plugin providing attribute: \'#{attribute}\'" unless attrs
+        raise Ohai::Exceptions::ProviderNotFound, "Cannot find plugin providing attribute: '#{attribute}'" unless attrs
 
         plugins += attrs[:_plugins]
       end

data/lib/ohai/runner.rb

@@ -119,9 +119,7 @@ module Ohai
     # cycle. Does not include plugins that aren't a part of the cycle
     def get_cycle(plugins, cycle_start)
       cycle = plugins.drop_while { |plugin| !plugin.eql?(cycle_start) }
-      names = []
-      cycle.each { |plugin| names << plugin.name }
-      names
+      cycle.map(&:name)
     end
 
   end

data/lib/ohai/version.rb

@@ -19,5 +19,5 @@
 
 module Ohai
   OHAI_ROOT = File.expand_path(__dir__)
-  VERSION = "18.1.18"
+  VERSION = "19.1.16"
 end

data/ohai.gemspec

@@ -12,17 +12,18 @@ Gem::Specification.new do |s|
   s.email = "adam@chef.io"
   s.homepage = "https://github.com/chef/ohai/"
 
-  s.required_ruby_version = ">= 2.7"
+  s.required_ruby_version = ">= 3.1"
 
-  s.add_dependency "chef-config", ">= 14.12", "< 19"
-  s.add_dependency "chef-utils", ">= 16.0", "< 19"
-  s.add_dependency "ffi", "~> 1.9"
+  s.add_dependency "base64" # For encoding binary data in Ruby 3.4+
+  s.add_dependency "chef-config", ">= 14.12", "< 20"
+  s.add_dependency "chef-utils", ">= 16.0", "< 20"
+  s.add_dependency "ffi", ">= 1.15.5"
   s.add_dependency "ffi-yajl", "~> 2.2"
   s.add_dependency "ipaddress"
   s.add_dependency "mixlib-cli", ">= 1.7.0" # 1.7+ needed to support passing multiple options
   s.add_dependency "mixlib-config", ">= 2.0", "< 4.0"
   s.add_dependency "mixlib-log", ">= 2.0.1", "< 4.0"
-  s.add_dependency "mixlib-shellout", "~> 3.2", ">= 3.2.5"
+  s.add_dependency "mixlib-shellout", "~> 3.3.6"
   s.add_dependency "plist", "~> 3.1"
   s.add_dependency "train-core"
   s.add_dependency "wmi-lite", "~> 1.0"

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: ohai
 version: !ruby/object:Gem::Version
-  version: 18.1.18
+  version: 19.1.16
 platform: ruby
 authors:
 - Adam Jacob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-05-28 00:00:00.000000000 Z
+date: 2025-12-09 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: base64
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: chef-config
   requirement: !ruby/object:Gem::Requirement
@@ -19,7 +33,7 @@ dependencies:
         version: '14.12'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '19'
+        version: '20'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +43,7 @@ dependencies:
         version: '14.12'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '19'
+        version: '20'
 - !ruby/object:Gem::Dependency
   name: chef-utils
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +53,7 @@ dependencies:
         version: '16.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '19'
+        version: '20'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -49,21 +63,21 @@ dependencies:
         version: '16.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '19'
+        version: '20'
 - !ruby/object:Gem::Dependency
   name: ffi
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: 1.15.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: 1.15.5
 - !ruby/object:Gem::Dependency
   name: ffi-yajl
   requirement: !ruby/object:Gem::Requirement
@@ -152,20 +166,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.2.5
+        version: 3.3.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.2.5
+        version: 3.3.6
 - !ruby/object:Gem::Dependency
   name: plist
   requirement: !ruby/object:Gem::Requirement
@@ -394,14 +402,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: Ohai profiles your system and emits JSON