ohai 14.2.0 → 14.3.0

data/spec/unit/plugins/azure_spec.rb

@@ -53,9 +53,9 @@ describe Ohai::System, "plugin azure" do
 
   before do
     # skips all the metadata logic unless we want to test it
-    allow(plugin).to receive(:can_socket_connect?).
-      with(Ohai::Mixin::AzureMetadata::AZURE_METADATA_ADDR, 80).
-      and_return(false)
+    allow(plugin).to receive(:can_socket_connect?)
+      .with(Ohai::Mixin::AzureMetadata::AZURE_METADATA_ADDR, 80)
+      .and_return(false)
   end
 
   shared_examples_for "!azure" do
@@ -96,26 +96,26 @@ describe Ohai::System, "plugin azure" do
       allow(Dir).to receive(:exist?).with('C:\WindowsAzure').and_return(false)
       allow(File).to receive(:exist?).with("/var/lib/dhcp/dhclient.eth0.leases").and_return(true)
       @double_file = double("/var/lib/dhcp/dhclient.eth0.leases")
-      allow(@double_file).to receive(:each).
-        and_yield("lease {").
-        and_yield('  interface "eth0";').
-        and_yield("  fixed-address 192.168.1.194;").
-        and_yield("  option subnet-mask 255.255.255.0;").
-        and_yield("  option routers 192.168.1.1;").
-        and_yield("  option dhcp-lease-time 86400;").
-        and_yield("  option dhcp-message-type 5;").
-        and_yield("  option domain-name-servers 8.8.8.8;").
-        and_yield("  option dhcp-server-identifier 192.168.1.2;").
-        and_yield("  option interface-mtu 1454;").
-        and_yield("  option dhcp-renewal-time 42071;").
-        and_yield("  option broadcast-address 192.168.1.255;").
-        and_yield("  option dhcp-rebinding-time 74471;").
-        and_yield('  option host-name "host-192-168-1-194";').
-        and_yield('  option domain-name "openstacklocal";').
-        and_yield("  renew 2 2016/03/01 01:49:41;").
-        and_yield("  rebind 2 2016/03/01 13:22:07;").
-        and_yield("  expire 2 2016/03/01 16:40:56;").
-        and_yield("}")
+      allow(@double_file).to receive(:each)
+        .and_yield("lease {")
+        .and_yield('  interface "eth0";')
+        .and_yield("  fixed-address 192.168.1.194;")
+        .and_yield("  option subnet-mask 255.255.255.0;")
+        .and_yield("  option routers 192.168.1.1;")
+        .and_yield("  option dhcp-lease-time 86400;")
+        .and_yield("  option dhcp-message-type 5;")
+        .and_yield("  option domain-name-servers 8.8.8.8;")
+        .and_yield("  option dhcp-server-identifier 192.168.1.2;")
+        .and_yield("  option interface-mtu 1454;")
+        .and_yield("  option dhcp-renewal-time 42071;")
+        .and_yield("  option broadcast-address 192.168.1.255;")
+        .and_yield("  option dhcp-rebinding-time 74471;")
+        .and_yield('  option host-name "host-192-168-1-194";')
+        .and_yield('  option domain-name "openstacklocal";')
+        .and_yield("  renew 2 2016/03/01 01:49:41;")
+        .and_yield("  rebind 2 2016/03/01 13:22:07;")
+        .and_yield("  expire 2 2016/03/01 16:40:56;")
+        .and_yield("}")
       allow(File).to receive(:open).with("/var/lib/dhcp/dhclient.eth0.leases").and_return(@double_file)
     end
 
@@ -161,26 +161,26 @@ describe Ohai::System, "plugin azure" do
       allow(Dir).to receive(:exist?).with('C:\WindowsAzure').and_return(false)
       allow(File).to receive(:exist?).with("/var/lib/dhcp/dhclient.eth0.leases").and_return(true)
       @double_file = double("/var/lib/dhcp/dhclient.eth0.leases")
-      allow(@double_file).to receive(:each).
-        and_yield("lease {").
-        and_yield('  interface "eth0";').
-        and_yield("  fixed-address 10.1.0.5;").
-        and_yield('  server-name "RD24BE05C6F140";').
-        and_yield("  option subnet-mask 255.255.255.0;").
-        and_yield("  option dhcp-lease-time 4294967295;").
-        and_yield("  option routers 10.1.0.1;").
-        and_yield("  option dhcp-message-type 5;").
-        and_yield("  option dhcp-server-identifier 168.63.129.16;").
-        and_yield("  option domain-name-servers 168.63.129.16;").
-        and_yield("  option dhcp-renewal-time 4294967295;").
-        and_yield("  option rfc3442-classless-static-routes 0,10,1,0,1,32,168,63,129,16,10,1,0,1;").
-        and_yield("  option unknown-245 a8:3f:81:10;").
-        and_yield("  option dhcp-rebinding-time 4294967295;").
-        and_yield('  option domain-name "v4wvfurds4relghweduc4zqjmd.dx.internal.cloudapp.net";').
-        and_yield("  renew 5 2152/03/10 09:03:39;").
-        and_yield("  rebind 5 2152/03/10 09:03:39;").
-        and_yield("  expire 5 2152/03/10 09:03:39;").
-        and_yield("}")
+      allow(@double_file).to receive(:each)
+        .and_yield("lease {")
+        .and_yield('  interface "eth0";')
+        .and_yield("  fixed-address 10.1.0.5;")
+        .and_yield('  server-name "RD24BE05C6F140";')
+        .and_yield("  option subnet-mask 255.255.255.0;")
+        .and_yield("  option dhcp-lease-time 4294967295;")
+        .and_yield("  option routers 10.1.0.1;")
+        .and_yield("  option dhcp-message-type 5;")
+        .and_yield("  option dhcp-server-identifier 168.63.129.16;")
+        .and_yield("  option domain-name-servers 168.63.129.16;")
+        .and_yield("  option dhcp-renewal-time 4294967295;")
+        .and_yield("  option rfc3442-classless-static-routes 0,10,1,0,1,32,168,63,129,16,10,1,0,1;")
+        .and_yield("  option unknown-245 a8:3f:81:10;")
+        .and_yield("  option dhcp-rebinding-time 4294967295;")
+        .and_yield('  option domain-name "v4wvfurds4relghweduc4zqjmd.dx.internal.cloudapp.net";')
+        .and_yield("  renew 5 2152/03/10 09:03:39;")
+        .and_yield("  rebind 5 2152/03/10 09:03:39;")
+        .and_yield("  expire 5 2152/03/10 09:03:39;")
+        .and_yield("}")
       allow(File).to receive(:open).with("/var/lib/dhcp/dhclient.eth0.leases").and_return(@double_file)
     end
 
@@ -193,9 +193,9 @@ describe Ohai::System, "plugin azure" do
     end
 
     it "does not return metadata information" do
-      allow(plugin).to receive(:can_socket_connect?).
-        with(Ohai::Mixin::AzureMetadata::AZURE_METADATA_ADDR, 80).
-        and_return(true)
+      allow(plugin).to receive(:can_socket_connect?)
+        .with(Ohai::Mixin::AzureMetadata::AZURE_METADATA_ADDR, 80)
+        .and_return(true)
       allow(plugin).to receive(:fetch_metadata).and_return(nil)
 
       plugin.run
@@ -207,9 +207,9 @@ describe Ohai::System, "plugin azure" do
   describe "with responsive metadata endpoint" do
     before(:each) do
       allow(plugin).to receive(:hint?).with("azure").and_return({})
-      allow(plugin).to receive(:can_socket_connect?).
-        with(Ohai::Mixin::AzureMetadata::AZURE_METADATA_ADDR, 80).
-        and_return(true)
+      allow(plugin).to receive(:can_socket_connect?)
+        .with(Ohai::Mixin::AzureMetadata::AZURE_METADATA_ADDR, 80)
+        .and_return(true)
       allow(plugin).to receive(:fetch_metadata).and_return(response_data)
       plugin.run
     end

data/spec/unit/plugins/bsd/filesystem_spec.rb

@@ -1,7 +1,7 @@
 #
 # Author:: Matthew Kent (<mkent@magoazul.com>)
 # Author:: Tim Smith (<tsmith@chef.io>)
-# Copyright:: Copyright (c) 2011-2016 Chef Software, Inc.
+# Copyright:: Copyright (c) 2011-2018, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -31,18 +31,18 @@ describe Ohai::System, "BSD filesystem plugin" do
 
   describe "when gathering filesystem usage data from df" do
     before(:each) do
-      @stdout = <<-DF
-Filesystem  1K-blocks    Used   Avail Capacity  Mounted on
-/dev/ada0p2   9637788 3313504 5553264    37%    /
-devfs               1       1       0   100%    /dev
+      @stdout = <<~DF
+        Filesystem  1K-blocks    Used   Avail Capacity  Mounted on
+        /dev/ada0p2   9637788 3313504 5553264    37%    /
+        devfs               1       1       0   100%    /dev
 DF
       allow(plugin).to receive(:shell_out).with("df").and_return(mock_shell_out(0, @stdout, ""))
 
-      @inode_stdout = <<-DFi
-Filesystem  512-blocks    Used   Avail Capacity iused  ifree %iused  Mounted on
-/dev/ada0p2   15411832 5109256 9069632    36%  252576 790750   24%   /
-devfs                2       2       0   100%       0      0  100%   /dev
-DFi
+      @inode_stdout = <<~DFI
+        Filesystem  512-blocks    Used   Avail Capacity iused  ifree %iused  Mounted on
+        /dev/ada0p2   15411832 5109256 9069632    36%  252576 790750   24%   /
+        devfs                2       2       0   100%       0      0  100%   /dev
+DFI
       allow(plugin).to receive(:shell_out).with("df -iP").and_return(mock_shell_out(0, @inode_stdout, ""))
     end
 
@@ -103,9 +103,9 @@ DFi
 
   describe "when gathering mounted filesystem data from mount" do
     before(:each) do
-      @stdout = <<-MOUNT
-/dev/ada0p2 on / (ufs, local, journaled soft-updates)
-devfs on /dev (devfs, local, multilabel)
+      @stdout = <<~MOUNT
+        /dev/ada0p2 on / (ufs, local, journaled soft-updates)
+        devfs on /dev (devfs, local, multilabel)
 MOUNT
       allow(plugin).to receive(:shell_out).with("mount -l").and_return(mock_shell_out(0, @stdout, ""))
     end

data/spec/unit/plugins/bsd/virtualization_spec.rb

@@ -23,7 +23,7 @@ describe Ohai::System, "BSD virtualization plugin" do
     @plugin = get_plugin("bsd/virtualization")
     allow(@plugin).to receive(:collect_os).and_return(:freebsd)
     allow(@plugin).to receive(:shell_out).with("sysctl -n security.jail.jailed").and_return(mock_shell_out(0, "0", ""))
-    allow(@plugin).to receive(:shell_out).with("#{Ohai.abs_path( "/sbin/kldstat" )}").and_return(mock_shell_out(0, "", ""))
+    allow(@plugin).to receive(:shell_out).with((Ohai.abs_path( "/sbin/kldstat" )).to_s).and_return(mock_shell_out(0, "", ""))
     allow(@plugin).to receive(:shell_out).with("jls -nd").and_return(mock_shell_out(0, "", ""))
     allow(@plugin).to receive(:shell_out).with("sysctl -n hw.model").and_return(mock_shell_out(0, "", ""))
     allow(@plugin).to receive(:shell_out).with("sysctl -n kern.vm_guest").and_return(mock_shell_out(0, "", ""))
@@ -72,12 +72,12 @@ describe Ohai::System, "BSD virtualization plugin" do
 
   context "when on a virtualbox guest" do
     before do
-      @vbox_guest = <<-OUT
-Id Refs Address Size Name
-1 40 0xffffffff80100000 d20428 kernel
-7 3 0xffffffff81055000 41e88 vboxguest.ko
+      @vbox_guest = <<~OUT
+        Id Refs Address Size Name
+        1 40 0xffffffff80100000 d20428 kernel
+        7 3 0xffffffff81055000 41e88 vboxguest.ko
 OUT
-      allow(@plugin).to receive(:shell_out).with("#{Ohai.abs_path("/sbin/kldstat")}").and_return(mock_shell_out(0, @vbox_guest, ""))
+      allow(@plugin).to receive(:shell_out).with((Ohai.abs_path("/sbin/kldstat")).to_s).and_return(mock_shell_out(0, @vbox_guest, ""))
     end
 
     it "detects we are a guest" do
@@ -90,10 +90,10 @@ OUT
 
   context "when on a virtualbox host" do
     before do
-      @stdout = <<-OUT
-Id Refs Address Size Name
-1 40 0xffffffff80100000 d20428 kernel
-7 3 0xffffffff81055000 41e88 vboxdrv.ko
+      @stdout = <<~OUT
+        Id Refs Address Size Name
+        1 40 0xffffffff80100000 d20428 kernel
+        7 3 0xffffffff81055000 41e88 vboxdrv.ko
 OUT
       allow(@plugin).to receive(:shell_out).with("/sbin/kldstat").and_return(mock_shell_out(0, @stdout, ""))
     end

data/spec/unit/plugins/c_spec.rb

@@ -18,64 +18,64 @@
 
 require_relative "../../spec_helper.rb"
 
-C_GCC = <<EOF
-Using built-in specs.
-COLLECT_GCC=gcc
-COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper
-Target: x86_64-linux-gnu
-Configured with: ../src/configure -v --with-pkgversion='Ubuntu 5.4.0-6ubuntu1~16.04.4' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
-Thread model: posix
-gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)
+C_GCC = <<~EOF.freeze
+  Using built-in specs.
+  COLLECT_GCC=gcc
+  COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper
+  Target: x86_64-linux-gnu
+  Configured with: ../src/configure -v --with-pkgversion='Ubuntu 5.4.0-6ubuntu1~16.04.4' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
+  Thread model: posix
+  gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)
 EOF
 
-C_GLIBC = <<EOF
-GNU C Library stable release version 2.5, by Roland McGrath et al.
-Copyright (C) 2006 Free Software Foundation, Inc.
-This is free software; see the source for copying conditions.
-There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
-PARTICULAR PURPOSE.
-Compiled by GNU CC version 4.1.2 20080704 (Red Hat 4.1.2-44).
-Compiled on a Linux 2.6.9 system on 2009-09-02.
-Available extensions:
-  The C stubs add-on version 2.1.2.
-  crypt add-on version 2.1 by Michael Glad and others
-  GNU Libidn by Simon Josefsson
-  GNU libio by Per Bothner
-  NIS(YP)/NIS+ NSS modules 0.19 by Thorsten Kukuk
-  Native POSIX Threads Library by Ulrich Drepper et al
-  BIND-8.2.3-T5B
-  RT using linux kernel aio
-Thread-local storage support included.
-For bug reporting instructions, please see:
-<http://www.gnu.org/software/libc/bugs.html>.
+C_GLIBC = <<~EOF.freeze
+  GNU C Library stable release version 2.5, by Roland McGrath et al.
+  Copyright (C) 2006 Free Software Foundation, Inc.
+  This is free software; see the source for copying conditions.
+  There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
+  PARTICULAR PURPOSE.
+  Compiled by GNU CC version 4.1.2 20080704 (Red Hat 4.1.2-44).
+  Compiled on a Linux 2.6.9 system on 2009-09-02.
+  Available extensions:
+    The C stubs add-on version 2.1.2.
+    crypt add-on version 2.1 by Michael Glad and others
+    GNU Libidn by Simon Josefsson
+    GNU libio by Per Bothner
+    NIS(YP)/NIS+ NSS modules 0.19 by Thorsten Kukuk
+    Native POSIX Threads Library by Ulrich Drepper et al
+    BIND-8.2.3-T5B
+    RT using linux kernel aio
+  Thread-local storage support included.
+  For bug reporting instructions, please see:
+  <http://www.gnu.org/software/libc/bugs.html>.
 EOF
 
-C_CL = <<EOF
-Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 14.00.50727.762 for 80x86
-Copyright (C) Microsoft Corporation.  All rights reserved.
+C_CL = <<~EOF.freeze
+  Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 14.00.50727.762 for 80x86
+  Copyright (C) Microsoft Corporation.  All rights reserved.
 EOF
 
-C_VS = <<EOF
+C_VS = <<~EOF.freeze
 
-Microsoft (R) Visual Studio Version 8.0.50727.762.
-Copyright (C) Microsoft Corp 1984-2005. All rights reserved.
+  Microsoft (R) Visual Studio Version 8.0.50727.762.
+  Copyright (C) Microsoft Corp 1984-2005. All rights reserved.
 EOF
 
-C_XLC = <<EOF
-IBM XL C/C++ Enterprise Edition for AIX, V9.0
-Version: 09.00.0000.0000
+C_XLC = <<~EOF.freeze
+  IBM XL C/C++ Enterprise Edition for AIX, V9.0
+  Version: 09.00.0000.0000
 EOF
 
-C_SUN = <<EOF
-cc: Sun C 5.8 Patch 121016-06 2007/08/01
+C_SUN = <<~EOF.freeze
+  cc: Sun C 5.8 Patch 121016-06 2007/08/01
 EOF
 
-C_HPUX = <<EOF
-/opt/ansic/bin/cc:
-        $Revision: 92453-07 linker linker crt0.o B.11.47 051104 $
-        LINT B.11.11.16 CXREF B.11.11.16
-        HP92453-01 B.11.11.16 HP C Compiler
-         $ PATCH/11.00:PHCO_27774  Oct  3 2002 09:45:59 $
+C_HPUX = <<~EOF.freeze
+  /opt/ansic/bin/cc:
+          $Revision: 92453-07 linker linker crt0.o B.11.47 051104 $
+          LINT B.11.11.16 CXREF B.11.11.16
+          HP92453-01 B.11.11.16 HP C Compiler
+           $ PATCH/11.00:PHCO_27774  Oct  3 2002 09:45:59 $
 EOF
 
 describe Ohai::System, "plugin c" do
@@ -85,7 +85,7 @@ describe Ohai::System, "plugin c" do
   before(:each) do
 
     plugin[:languages] = Mash.new
-    #gcc
+    # gcc
     allow(plugin).to receive(:shell_out).with("gcc -v").and_return(mock_shell_out(0, "", C_GCC))
   end
 
@@ -95,7 +95,7 @@ describe Ohai::System, "plugin c" do
       allow(plugin).to receive(:shell_out).with("xlc -qversion").and_return(mock_shell_out(0, C_XLC, ""))
     end
 
-    #ibm xlc
+    # ibm xlc
     it "gets the xlc version from running xlc -qversion" do
       expect(plugin).to receive(:shell_out).with("xlc -qversion").and_return(mock_shell_out(0, C_XLC, ""))
       plugin.run
@@ -138,7 +138,7 @@ describe Ohai::System, "plugin c" do
       allow(plugin).to receive(:shell_out).with("what /opt/ansic/bin/cc").and_return(mock_shell_out(0, C_HPUX, ""))
     end
 
-    #hpux cc
+    # hpux cc
     it "gets the cc version from running what cc" do
       expect(plugin).to receive(:shell_out).with("what /opt/ansic/bin/cc").and_return(mock_shell_out(0, C_HPUX, ""))
       plugin.run
@@ -194,7 +194,7 @@ describe Ohai::System, "plugin c" do
       allow(plugin).to receive(:shell_out).with("devenv.com /\?").and_return(mock_shell_out(0, C_VS, ""))
     end
 
-    #ms cl
+    # ms cl
     it "gets the cl version from running cl /?" do
       expect(plugin).to receive(:shell_out).with("cl /\?")
       plugin.run
@@ -223,7 +223,7 @@ describe Ohai::System, "plugin c" do
       expect(plugin[:languages][:c]).not_to be_empty # expect other attributes
     end
 
-    #ms vs
+    # ms vs
     it "gets the vs version from running devenv.com /?" do
       expect(plugin).to receive(:shell_out).with("devenv.com /\?").and_return(mock_shell_out(0, C_VS, ""))
       plugin.run
@@ -259,11 +259,11 @@ describe Ohai::System, "plugin c" do
       # glibc
       allow(plugin).to receive(:shell_out).with("/lib/libc.so.6").and_return(mock_shell_out(0, C_GLIBC, ""))
       allow(plugin).to receive(:shell_out).with("/lib64/libc.so.6").and_return(mock_shell_out(0, C_GLIBC, ""))
-      #sun pro
+      # sun pro
       allow(plugin).to receive(:shell_out).with("cc -V -flags").and_return(mock_shell_out(0, "", C_SUN))
     end
 
-    #gcc
+    # gcc
     it "gets the gcc version from running gcc -v" do
       expect(plugin).to receive(:shell_out).with("gcc -v")
       plugin.run
@@ -307,7 +307,7 @@ describe Ohai::System, "plugin c" do
       expect(plugin[:languages][:c]).not_to be_empty # expect other attributes
     end
 
-    #glibc
+    # glibc
     it "gets the glibc x.x.x version from running /lib/libc.so.6" do
       expect(plugin).to receive(:shell_out).with("/lib/libc.so.6")
       plugin.run
@@ -345,7 +345,7 @@ describe Ohai::System, "plugin c" do
       expect(plugin.languages[:c][:glibc][:version]).to eql("2.5")
     end
 
-    #sun pro
+    # sun pro
     it "gets the cc version from running cc -V -flags" do
       expect(plugin).to receive(:shell_out).with("cc -V -flags").and_return(mock_shell_out(0, "", C_SUN))
       plugin.run

data/spec/unit/plugins/chef_spec.rb

@@ -27,18 +27,18 @@ begin
       @plugin = get_plugin("chef")
     end
 
-    it "should set [:chef_packages][:chef][:version] to the current chef version", :if => defined?(Chef) do
+    it "should set [:chef_packages][:chef][:version] to the current chef version", if: defined?(Chef) do
       @plugin.run
       expect(@plugin[:chef_packages][:chef][:version]).to eq(Chef::VERSION)
     end
 
-    pending "would set [:chef_packages][:chef][:version] if chef was available", :unless => defined?(Chef)
+    pending "would set [:chef_packages][:chef][:version] if chef was available", unless: defined?(Chef)
   end
 
 rescue LoadError
   # the chef module is not available, ignoring.
 
   describe Ohai::System, "plugin chef" do
-    pending "would set [:chef_packages][:chef][:version] if chef was available", :unless => defined?(Chef)
+    pending "would set [:chef_packages][:chef][:version] if chef was available", unless: defined?(Chef)
   end
 end

data/spec/unit/plugins/darwin/cpu_spec.rb

@@ -21,60 +21,60 @@ require_relative "../../../spec_helper.rb"
 describe Ohai::System, "Darwin cpu plugin" do
   before(:each) do
     @plugin = get_plugin("darwin/cpu")
-    @stdout = <<-CTL
-hw.ncpu: 8
-hw.byteorder: 1234
-hw.memsize: 17179869184
-hw.activecpu: 8
-hw.packages: 1
-hw.tbfrequency: 1000000000
-hw.l3cachesize: 6291456
-hw.l2cachesize: 262144
-hw.l1dcachesize: 32768
-hw.l1icachesize: 32768
-hw.cachelinesize: 64
-hw.cpufrequency: 2800000000
-hw.busfrequency: 100000000
-hw.pagesize32: 4096
-hw.pagesize: 4096
-hw.cpufamily: 280134364
-hw.cpu64bit_capable: 1
-hw.cpusubtype: 8
-hw.cputype: 7
-hw.logicalcpu_max: 8
-hw.logicalcpu: 8
-hw.physicalcpu_max: 4
-hw.physicalcpu: 4
-hw.targettype: Mac
-hw.cputhreadtype: 1
-machdep.cpu.thread_count: 8
-machdep.cpu.core_count: 4
-machdep.cpu.address_bits.virtual: 48
-machdep.cpu.address_bits.physical: 39
-machdep.cpu.cache.size: 256
-machdep.cpu.cache.L2_associativity: 8
-machdep.cpu.cache.linesize: 64
-machdep.cpu.processor_flag: 5
-machdep.cpu.microcode_version: 15
-machdep.cpu.cores_per_package: 8
-machdep.cpu.logical_per_package: 16
-machdep.cpu.extfeatures: SYSCALL XD 1GBPAGE EM64T LAHF LZCNT RDTSCP TSCI
-machdep.cpu.leaf7_features: SMEP ERMS RDWRFSGS TSC_THREAD_OFFSET BMI1 HLE AVX2 BMI2 INVPCID RTM FPU_CSDS
-machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH DS ACPI MMX FXSR SSE SSE2 SS HTT TM PBE SSE3 PCLMULQDQ DTES64 MON DSCPL VMX SMX EST TM2 SSSE3 FMA CX16 TPR PDCM SSE4.1 SSE4.2 x2APIC MOVBE POPCNT AES PCID XSAVE OSXSAVE SEGLIM64 TSCTMR AVX1.0 RDRAND F16C
-machdep.cpu.brand: 0
-machdep.cpu.signature: 263777
-machdep.cpu.extfeature_bits: 142473169152
-machdep.cpu.leaf7_feature_bits: 12219
-machdep.cpu.feature_bits: 9221960262849657855
-machdep.cpu.stepping: 1
-machdep.cpu.extfamily: 0
-machdep.cpu.extmodel: 4
-machdep.cpu.model: 70
-machdep.cpu.family: 6
-machdep.cpu.brand_string: Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
-machdep.cpu.vendor: GenuineIntel
-machdep.cpu.max_ext: 2147483656
-machdep.cpu.max_basic: 13
+    @stdout = <<~CTL
+      hw.ncpu: 8
+      hw.byteorder: 1234
+      hw.memsize: 17179869184
+      hw.activecpu: 8
+      hw.packages: 1
+      hw.tbfrequency: 1000000000
+      hw.l3cachesize: 6291456
+      hw.l2cachesize: 262144
+      hw.l1dcachesize: 32768
+      hw.l1icachesize: 32768
+      hw.cachelinesize: 64
+      hw.cpufrequency: 2800000000
+      hw.busfrequency: 100000000
+      hw.pagesize32: 4096
+      hw.pagesize: 4096
+      hw.cpufamily: 280134364
+      hw.cpu64bit_capable: 1
+      hw.cpusubtype: 8
+      hw.cputype: 7
+      hw.logicalcpu_max: 8
+      hw.logicalcpu: 8
+      hw.physicalcpu_max: 4
+      hw.physicalcpu: 4
+      hw.targettype: Mac
+      hw.cputhreadtype: 1
+      machdep.cpu.thread_count: 8
+      machdep.cpu.core_count: 4
+      machdep.cpu.address_bits.virtual: 48
+      machdep.cpu.address_bits.physical: 39
+      machdep.cpu.cache.size: 256
+      machdep.cpu.cache.L2_associativity: 8
+      machdep.cpu.cache.linesize: 64
+      machdep.cpu.processor_flag: 5
+      machdep.cpu.microcode_version: 15
+      machdep.cpu.cores_per_package: 8
+      machdep.cpu.logical_per_package: 16
+      machdep.cpu.extfeatures: SYSCALL XD 1GBPAGE EM64T LAHF LZCNT RDTSCP TSCI
+      machdep.cpu.leaf7_features: SMEP ERMS RDWRFSGS TSC_THREAD_OFFSET BMI1 HLE AVX2 BMI2 INVPCID RTM FPU_CSDS
+      machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH DS ACPI MMX FXSR SSE SSE2 SS HTT TM PBE SSE3 PCLMULQDQ DTES64 MON DSCPL VMX SMX EST TM2 SSSE3 FMA CX16 TPR PDCM SSE4.1 SSE4.2 x2APIC MOVBE POPCNT AES PCID XSAVE OSXSAVE SEGLIM64 TSCTMR AVX1.0 RDRAND F16C
+      machdep.cpu.brand: 0
+      machdep.cpu.signature: 263777
+      machdep.cpu.extfeature_bits: 142473169152
+      machdep.cpu.leaf7_feature_bits: 12219
+      machdep.cpu.feature_bits: 9221960262849657855
+      machdep.cpu.stepping: 1
+      machdep.cpu.extfamily: 0
+      machdep.cpu.extmodel: 4
+      machdep.cpu.model: 70
+      machdep.cpu.family: 6
+      machdep.cpu.brand_string: Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
+      machdep.cpu.vendor: GenuineIntel
+      machdep.cpu.max_ext: 2147483656
+      machdep.cpu.max_basic: 13
 CTL
 
     allow(@plugin).to receive(:collect_os).and_return(:darwin)