ohai 13.6.0 → 13.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f877e6723a132a880743b84ab9a9d6a0ede623eb
-  data.tar.gz: 7bb2833e7c7d12bc8207608bf14f93b266e48371
+  metadata.gz: 29f7dbc2f6ba160d4cc5a90e112804e12338cb76
+  data.tar.gz: 1a6a50e9261b97ea92348d64cbf3e2bdc97717ab
 SHA512:
-  metadata.gz: b7b5ff8c56d7f071ac3278e345c91bd8df4f9a5e4e07fd4aec0a714833f1debaabc02a588d6ca2b5c43595d8799662410d6ec95cca4b9fb84a641358ccfb4c06
-  data.tar.gz: d062c3f9b9595a699be681be9d3b1a8bb6513e61fefc7662fbc3e88f0f5063dbe2b640997e4957e0ff4667b79023e4016e114ba68c34d288b6c2e27479b22e40
+  metadata.gz: 35f52d079c7a4dc1b0dfaf70c8977b808c11d36d3069888a4967973d14d70326581a22539a7f3fee2b85345b325bfd78a91cfeb52792d64c5e98bcc30f8ace74
+  data.tar.gz: 85006bb7724517c6edeed48cabffbb806b8d5e638fa5481d7f354965159e19c28778185bd282a184fa1f6e2498fdf566ed2a0319adfc1d89176f853e56fed58f

data/bin/ohai

@@ -19,23 +19,8 @@
 # limitations under the License.
 #
 
-begin
-  require "rubygems"
-rescue LoadError
-  # must be debian! ;)
-  missing_rubygems = true
-end
-begin
-  # if we're in a source code checkout, we want to run the code from that.
-  # have to do this *after* rubygems is loaded.
-  $:.unshift File.expand_path("../../lib", __FILE__)
-  require "ohai/application"
-rescue LoadError
-  if missing_rubygems
-    STDERR.puts "rubygems previously failed to load - is it installed?"
-  end
-
-  raise
-end
+# if we're in a source code checkout, we want to run the code from that.
+$:.unshift File.expand_path("../../lib", __FILE__)
+require "ohai/application"
 
 Ohai::Application.new.run

data/lib/ohai/mixin/azure_metadata.rb

@@ -44,7 +44,7 @@ module Ohai
             nil
           end
         else
-          Ohai::Log.warn("Mixin AzureMetadata: Received resonse code #{response.code} requesting metadata")
+          Ohai::Log.warn("Mixin AzureMetadata: Received response code #{response.code} requesting metadata")
           nil
         end
       end

data/lib/ohai/mixin/do_metadata.rb

@@ -35,7 +35,7 @@ module Ohai
           parser = FFI_Yajl::Parser.new
           parser.parse(response.body)
         when "404"
-          Ohai::Log.debug("Mixin DOMetadata: Encountered 404 response retreiving Digital Ocean metadata: #{uri} ; continuing.")
+          Ohai::Log.debug("Mixin DOMetadata: Encountered 404 response retrieving Digital Ocean metadata: #{uri} ; continuing.")
           {}
         else
           raise "Mixin DOMetadata: Encountered error retrieving Digital Ocean metadata (#{uri} returned #{response.code} response)"

data/lib/ohai/mixin/ec2_metadata.rb

@@ -94,7 +94,7 @@ module Ohai
         when "200"
           response.body
         when "404"
-          Ohai::Log.debug("Mixin EC2: Encountered 404 response retreiving EC2 metadata path: #{path} ; continuing.")
+          Ohai::Log.debug("Mixin EC2: Encountered 404 response retrieving EC2 metadata path: #{path} ; continuing.")
           nil
         else
           raise "Mixin EC2: Encountered error retrieving EC2 metadata (#{path} returned #{response.code} response)"

data/lib/ohai/plugins/c.rb

@@ -134,6 +134,7 @@ Ohai.plugin(:C) do
       end
     end
   rescue Ohai::Exceptions::Exec
+    Ohai::Log.debug("Plugin C: 'xlc' binary could not be found. Skipping data.")
   end
 
   def collect_sunpro

data/lib/ohai/plugins/cloud.rb

@@ -298,7 +298,7 @@ Ohai.plugin(:Cloud) do
   collect_data do
     require "ipaddr"
 
-    @cloud_attr_obj = CloudAttrs.new()
+    @cloud_attr_obj = CloudAttrs.new
 
     get_gce_values if on_gce?
     get_ec2_values if on_ec2?

data/lib/ohai/plugins/ec2.rb

@@ -21,7 +21,8 @@
 # How we detect EC2 from easiest to hardest & least reliable
 # 1. Ohai ec2 hint exists. This always works
 # 2. Xen hypervisor UUID starts with 'ec2'. This catches Linux HVM & paravirt instances
-# 3. DMI data mentions amazon. This catches HVM instances in a VPC
+# 3. DMI bios version data mentions amazon. This catches HVM instances in a VPC on the Xen based hypervisor
+# 3. DMI bios vendor data mentions amazon. This catches HVM instances in a VPC on the non-Xen based hypervisor
 # 4. Kernel data mentioned Amazon. This catches Windows HVM & paravirt instances
 
 Ohai.plugin(:EC2) do
@@ -33,32 +34,43 @@ Ohai.plugin(:EC2) do
   include Ohai::Mixin::HttpHelper
 
   provides "ec2"
-  depends "dmi"
 
-  # look for amazon string in dmi bios data
+  # look for amazon string in dmi vendor bios data within the sys tree.
+  # this works even if the system lacks dmidecode use by the Dmi plugin
+  # this gets us detection of new Xen-less HVM instances that are within a VPC
+  # @return [Boolean] do we have Amazon DMI data?
+  def has_ec2_amazon_dmi?
+    # detect a version of '4.2.amazon'
+    if file_val_if_exists("/sys/class/dmi/id/bios_vendor") =~ /Amazon/
+      Ohai::Log.debug("Plugin EC2: has_ec2_amazon_dmi? == true")
+      true
+    else
+      Ohai::Log.debug("Plugin EC2: has_ec2_amazon_dmi? == false")
+      false
+    end
+  end
+
+  # look for amazon string in dmi bios version data within the sys tree.
+  # this works even if the system lacks dmidecode use by the Dmi plugin
   # this gets us detection of HVM instances that are within a VPC
   # @return [Boolean] do we have Amazon DMI data?
-  def has_ec2_dmi?
+  def has_ec2_xen_dmi?
     # detect a version of '4.2.amazon'
-    if get_attribute(:dmi, :bios, :all_records, 0, :Version) =~ /amazon/
-      Ohai::Log.debug("Plugin EC2: has_ec2_dmi? == true")
+    if file_val_if_exists("/sys/class/dmi/id/bios_version") =~ /amazon/
+      Ohai::Log.debug("Plugin EC2: has_ec2_xen_dmi? == true")
       true
     else
-      Ohai::Log.debug("Plugin EC2: has_ec2_dmi? == false")
+      Ohai::Log.debug("Plugin EC2: has_ec2_xen_dmi? == false")
       false
     end
   end
 
-  # looks for a xen UUID that starts with ec2
-  # uses the sys tree on Linux and a WMI query on windows
-  # this gets us detection of HVM and Paravirt hosts
+  # looks for a xen UUID that starts with ec2 from within the Linux sys tree
   # @return [Boolean] do we have a Xen UUID or not?
   def has_ec2_xen_uuid?
-    if ::File.exist?("/sys/hypervisor/uuid")
-      if ::File.read("/sys/hypervisor/uuid") =~ /^ec2/
-        Ohai::Log.debug("Plugin EC2: has_ec2_xen_uuid? == true")
-        return true
-      end
+    if file_val_if_exists("/sys/hypervisor/uuid") =~ /^ec2/
+      Ohai::Log.debug("Plugin EC2: has_ec2_xen_uuid? == true")
+      return true
     end
     Ohai::Log.debug("Plugin EC2: has_ec2_xen_uuid? == false")
     false
@@ -82,13 +94,22 @@ Ohai.plugin(:EC2) do
     end
   end
 
+  # return the contents of a file if the file exists
+  # @param path[String] abs path to the file
+  # @return [String] contents of the file if it exists
+  def file_val_if_exists(path)
+    if ::File.exist?(path)
+      ::File.read(path)
+    end
+  end
+
   # a single check that combines all the various detection methods for EC2
   # @return [Boolean] Does the system appear to be on EC2
   def looks_like_ec2?
     return true if hint?("ec2")
 
     # Even if it looks like EC2 try to connect first
-    if has_ec2_xen_uuid? || has_ec2_dmi? || has_ec2_identifying_number?
+    if has_ec2_xen_uuid? || has_ec2_amazon_dmi? || has_ec2_xen_dmi? || has_ec2_identifying_number?
       return true if can_socket_connect?(Ohai::Mixin::Ec2Metadata::EC2_METADATA_ADDR, 80)
     end
   end

data/lib/ohai/plugins/linux/mdadm.rb

@@ -64,10 +64,35 @@ Ohai.plugin(:Mdadm) do
           # unless the array is inactive, in which case you don't get a raid
           # level.
           members = pieces.drop_while { |x| !x.start_with?("raid", "inactive") }
-          # drop the 'raid' too
-
+          # and drop that too
           members.shift unless members.empty?
-          devices[device] = members.map { |s| s.match(/(.+)\[\d\]/)[1] }
+          devices[device] = {
+            "active" => [],
+            "spare" => [],
+            "journal" => nil,
+          }
+          members.each do |member|
+            # We want to match the device, and optionally the type
+            # most entries will look like:
+            #   sdc1[5]
+            # but some will look like:
+            #   sdc1[5](J)
+            # where the format is:
+            #   <device>[<number in array>](<type>)
+            # Type can be things like "J" for a journal device, or "S" for
+            # a spare device.
+            m = member.match(/(.+)\[\d+\](?:\((\w)\))?/)
+            member_device = m[1]
+            member_type = m[2]
+            case member_type
+            when "J"
+              devices[device]["journal"] = member_device
+            when "S"
+              devices[device]["spare"] << member_device
+            else
+              devices[device]["active"] << member_device
+            end
+          end
         end
       end
 
@@ -82,7 +107,9 @@ Ohai.plugin(:Mdadm) do
 
           # if the mdadm command was sucessful pass so.stdout to create_raid_device_mash to grab the tidbits we want
           mdadm[device] = create_raid_device_mash(so.stdout) if so.stdout
-          mdadm[device]["members"] = devices[device]
+          mdadm[device]["members"] = devices[device]["active"]
+          mdadm[device]["spares"] = devices[device]["spare"]
+          mdadm[device]["journal"] = devices[device]["journal"]
         end
       end
     end

data/lib/ohai/plugins/linux/memory.rb

@@ -30,6 +30,8 @@ Ohai.plugin(:Memory) do
         memory[:total] = "#{$1}#{$2}"
       when /^MemFree:\s+(\d+) (.+)$/
         memory[:free] = "#{$1}#{$2}"
+      when /^MemAvailable:\s+(\d+) (.+)$/
+        memory[:available] = "#{$1}#{$2}"
       when /^Buffers:\s+(\d+) (.+)$/
         memory[:buffers] = "#{$1}#{$2}"
       when /^Cached:\s+(\d+) (.+)$/

data/lib/ohai/plugins/linux/platform.rb

@@ -249,7 +249,7 @@ Ohai.plugin(:Platform) do
       platform_version `uname -r`.strip
     elsif File.exist?("/etc/alpine-release")
       platform "alpine"
-      platform_version File.read("/etc/alpine-release").strip()
+      platform_version File.read("/etc/alpine-release").strip
     elsif File.exist?("/usr/lib/os-release")
       contents = File.read("/usr/lib/os-release")
       if /Clear Linux/ =~ contents

data/lib/ohai/plugins/linux/virtualization.rb

@@ -159,7 +159,7 @@ Ohai.plugin(:Virtualization) do
       end
     end
 
-    # Detect LXC/Docker
+    # Detect LXC/Docker/Nspawn
     #
     # /proc/self/cgroup will look like this inside a docker container:
     # <index #>:<subsystem>:/lxc/<hexadecimal container id>
@@ -190,6 +190,11 @@ Ohai.plugin(:Virtualization) do
         virtualization[:system] = "lxc"
         virtualization[:role] = "guest"
         virtualization[:systems][:lxc] = "guest"
+      elsif File.read("/proc/1/environ") =~ /container=systemd-nspawn/
+        Ohai::Log.debug("Plugin Virtualization: /proc/1/environ indicates nspawn container. Detecting as nspawn guest")
+        virtualization[:system] = "nspawn"
+        virtualization[:role] = "guest"
+        virtualization[:systems][:nspawn] = "guest"
       elsif lxc_version_exists? && File.read("/proc/self/cgroup") =~ %r{\d:[^:]+:/$}
         # lxc-version shouldn't be installed by default
         # Even so, it is likely we are on an LXC capable host that is not being used as such

data/lib/ohai/system.rb

@@ -62,7 +62,7 @@ module Ohai
       @loader = Ohai::Loader.new(self)
       @runner = Ohai::Runner.new(self, true)
 
-      Ohai::Hints.refresh_hints()
+      Ohai::Hints.refresh_hints
 
       # Remove the previously defined plugins
       recursive_remove_constants(Ohai::NamedPlugin)
@@ -193,7 +193,7 @@ module Ohai
     # This method takes a naive approach to v6 plugins: it simply re-runs all
     # of them whenever called.
     def refresh_plugins(attribute_filter = nil)
-      Ohai::Hints.refresh_hints()
+      Ohai::Hints.refresh_hints
       @provides_map.all_plugins(attribute_filter).each do |plugin|
         plugin.reset!
       end

data/lib/ohai/version.rb

@@ -18,5 +18,5 @@
 
 module Ohai
   OHAI_ROOT = File.expand_path(File.dirname(__FILE__))
-  VERSION = "13.6.0"
+  VERSION = "13.7.0"
 end

data/spec/unit/plugins/cloud_spec.rb

@@ -39,7 +39,7 @@ describe "CloudAttrs object" do
   end
 
   it "populates cloud mash" do
-    @cloud_attr_obj = ::CloudAttrs.new()
+    @cloud_attr_obj = ::CloudAttrs.new
     @cloud_attr_obj.add_ipv4_addr("1.2.3.1", :public)
     @cloud_attr_obj.add_ipv4_addr("1.2.4.1", :private)
     @cloud_attr_obj.add_ipv6_addr("3ffe:505:2::1", :public)
@@ -51,22 +51,22 @@ describe "CloudAttrs object" do
   end
 
   it "throws exception with a bad ipv4 address" do
-    @cloud_attr_obj = ::CloudAttrs.new()
+    @cloud_attr_obj = ::CloudAttrs.new
     expect { @cloud_attr_obj.add_ipv6_addr("somebogusstring", :public) }.to raise_error(RuntimeError)
   end
 
   it "throws exception with a bad ipv6 address" do
-    @cloud_attr_obj = ::CloudAttrs.new()
+    @cloud_attr_obj = ::CloudAttrs.new
     expect { @cloud_attr_obj.add_ipv6_addr("FEED:B0B:DEAD:BEEF", :public) }.to raise_error(RuntimeError)
   end
 
   it "throws exception with ipv6 address passed to ipv4" do
-    @cloud_attr_obj = ::CloudAttrs.new()
+    @cloud_attr_obj = ::CloudAttrs.new
     expect { @cloud_attr_obj.add_ipv4_addr("3ffe:506:2::1", :public) }.to raise_error(RuntimeError)
   end
 
   it "throws exception with ipv4 address passed to ipv6" do
-    @cloud_attr_obj = ::CloudAttrs.new()
+    @cloud_attr_obj = ::CloudAttrs.new
     expect {  @cloud_attr_obj.add_ipv6_addr("1.2.3.4", :public) }.to raise_error(RuntimeError)
   end
 

data/spec/unit/plugins/ec2_spec.rb

@@ -28,6 +28,8 @@ describe Ohai::System, "plugin ec2" do
   before(:each) do
     allow(plugin).to receive(:hint?).with("ec2").and_return(false)
     allow(File).to receive(:exist?).with("/sys/hypervisor/uuid").and_return(false)
+    allow(File).to receive(:exist?).with("/sys/class/dmi/id/bios_vendor").and_return(false)
+    allow(File).to receive(:exist?).with("/sys/class/dmi/id/bios_version").and_return(false)
   end
 
   shared_examples_for "!ec2" do
@@ -332,11 +334,39 @@ describe Ohai::System, "plugin ec2" do
     end
   end # shared examples for ec2
 
-  describe "with ec2 dmi data" do
+  describe "with amazon dmi bios version data" do
     it_behaves_like "ec2"
 
     before(:each) do
-      plugin[:dmi] = { :bios => { :all_records => [ { :Version => "4.2.amazon" } ] } }
+      allow(File).to receive(:exist?).with("/sys/class/dmi/id/bios_version").and_return(true)
+      allow(File).to receive(:read).with("/sys/class/dmi/id/bios_version").and_return("4.2.amazon\n")
+    end
+  end
+
+  describe "with non-amazon dmi bios version data" do
+    it_behaves_like "!ec2"
+
+    before(:each) do
+      allow(File).to receive(:exist?).with("/sys/class/dmi/id/bios_version").and_return(true)
+      allow(File).to receive(:read).with("/sys/class/dmi/id/bios_version").and_return("1.0\n")
+    end
+  end
+
+  describe "with amazon dmi bios vendor data" do
+    it_behaves_like "ec2"
+
+    before(:each) do
+      allow(File).to receive(:exist?).with("/sys/class/dmi/id/bios_vendor").and_return(true)
+      allow(File).to receive(:read).with("/sys/class/dmi/id/bios_vendor").and_return("Amazon EC2\n")
+    end
+  end
+
+  describe "with non-amazon dmi bios vendor data" do
+    it_behaves_like "!ec2"
+
+    before(:each) do
+      allow(File).to receive(:exist?).with("/sys/class/dmi/id/bios_vendor").and_return(true)
+      allow(File).to receive(:read).with("/sys/class/dmi/id/bios_vendor").and_return("Xen\n")
     end
   end
 
@@ -345,7 +375,7 @@ describe Ohai::System, "plugin ec2" do
 
     before(:each) do
       allow(File).to receive(:exist?).with("/sys/hypervisor/uuid").and_return(true)
-      allow(File).to receive(:read).with("/sys/hypervisor/uuid").and_return("ec2a0561-e4d6-8e15-d9c8-2e0e03adcde8")
+      allow(File).to receive(:read).with("/sys/hypervisor/uuid").and_return("ec2a0561-e4d6-8e15-d9c8-2e0e03adcde8\n")
     end
   end
 
@@ -354,7 +384,7 @@ describe Ohai::System, "plugin ec2" do
 
     before(:each) do
       allow(File).to receive(:exist?).with("/sys/hypervisor/uuid").and_return(true)
-      allow(File).to receive(:read).with("/sys/hypervisor/uuid").and_return("123a0561-e4d6-8e15-d9c8-2e0e03adcde8")
+      allow(File).to receive(:read).with("/sys/hypervisor/uuid").and_return("123a0561-e4d6-8e15-d9c8-2e0e03adcde8\n")
     end
   end
 

data/spec/unit/plugins/linux/mdadm_spec.rb

@@ -106,6 +106,20 @@ MD
       )
     end
 
+    it "should detect member devices even if there are multi-digit numbers" do
+      new_mdstat = double("/proc/mdstat2")
+      allow(new_mdstat).to receive(:each).
+        and_yield("Personalities : [raid1] [raid6] [raid5] [raid4] [linear] [multipath] [raid0] [raid10]").
+        and_yield("md0 : active raid10 sdj[2010] sdi[99] sdh[5] sdg[4] sdf[3] sde[2] sdd[1] sdc[0]").
+        and_yield("      2929893888 blocks super 1.2 256K chunks 2 near-copies [6/6] [UUUUUU]")
+      allow(File).to receive(:open).with("/proc/mdstat").and_return(new_mdstat)
+
+      @plugin.run
+      expect(@plugin[:mdadm][:md0][:members].sort).to eq(
+        %w{sdc sdd sde sdf sdg sdh sdi sdj}
+      )
+    end
+
     it "should detect member devices even if mdstat has extra entries" do
       new_mdstat = double("/proc/mdstat2")
       allow(new_mdstat).to receive(:each).
@@ -128,8 +142,29 @@ MD
       allow(File).to receive(:open).with("/proc/mdstat").and_return(new_mdstat)
 
       @plugin.run
-      expect(@plugin[:mdadm][:md0][:members].sort).to eq(%w{nvme2n1p3})
+      expect(@plugin[:mdadm][:md0][:spares]).to eq(%w{nvme2n1p3})
     end
-  end
 
+    it "should report journal devices" do
+      new_mdstat = double("/proc/mdstat_journal")
+      allow(new_mdstat).to receive(:each).
+        and_yield("Personalies : [raid6]").
+        and_yield("md0 : active (somecraphere) <morestuff raid6 sdbc1[7] sdd1[6] sde1[5] sdd1[4] sde1[3] sdf1[2] sdg1[1] nvme2n1p3[0](J)")
+      allow(File).to receive(:open).with("/proc/mdstat").and_return(new_mdstat)
+
+      @plugin.run
+      expect(@plugin[:mdadm][:md0][:journal]).to eq("nvme2n1p3")
+    end
+
+    it "should report spare devices" do
+      new_mdstat = double("/proc/mdstat_spare")
+      allow(new_mdstat).to receive(:each).
+        and_yield("Personalies : [raid6]").
+        and_yield("md0 : active (somecraphere) <morestuff raid6 sdbc1[7] sdd1[6] sde1[5] sdd1[4] sde1[3] sdf1[2] sdg1[1] sdh1[0](S)")
+      allow(File).to receive(:open).with("/proc/mdstat").and_return(new_mdstat)
+
+      @plugin.run
+      expect(@plugin[:mdadm][:md0][:spares]).to eq(%w{sdh1})
+    end
+  end
 end

data/spec/unit/plugins/linux/memory_spec.rb

@@ -24,6 +24,7 @@ describe Ohai::System, "Linux memory plugin" do
     allow(@double_file).to receive(:each).
       and_yield("MemTotal:     131932120 kB").
       and_yield("MemFree:       2269032 kB").
+      and_yield("MemAvailable:  9208922 kB").
       and_yield("Buffers:        646368 kB").
       and_yield("Cached:       32346556 kB").
       and_yield("SwapCached:        312 kB").
@@ -68,6 +69,11 @@ describe Ohai::System, "Linux memory plugin" do
     expect(@plugin[:memory][:free]).to eql("2269032kB")
   end
 
+  it "should get available memory" do
+    @plugin.run
+    expect(@plugin[:memory][:available]).to eql("9208922kB")
+  end
+
   it "should get memory used for file buffers" do
     @plugin.run
     expect(@plugin[:memory][:buffers]).to eql("646368kB")

data/spec/unit/plugins/linux/virtualization_spec.rb

@@ -40,6 +40,7 @@ describe Ohai::System, "Linux virtualization platform" do
     allow(File).to receive(:exist?).with("/sys/devices/virtual/misc/kvm").and_return(false)
     allow(File).to receive(:exist?).with("/dev/lxd/sock").and_return(false)
     allow(File).to receive(:exist?).with("/var/lib/lxd/devlxd").and_return(false)
+    allow(File).to receive(:exist?).with("/proc/1/environ").and_return(false)
 
     # default the which wrappers to nil
     allow(plugin).to receive(:which).with("lxc-version").and_return(nil)
@@ -627,6 +628,18 @@ CGROUP
     end
   end
 
+  describe "when we are checking for systemd-nspawn" do
+    it "sets nspawn guest if /proc/1/environ has nspawn string in it" do
+      allow(File).to receive(:exist?).with("/proc/self/cgroup").and_return(true)
+      one_environ = "container=systemd-nspawn_ttys=/dev/pts/0 /dev/pts/1 /dev/pts/2 /dev/pts/3".chomp
+      allow(File).to receive(:read).with("/proc/1/environ").and_return(one_environ)
+      allow(File).to receive(:read).with("/proc/self/cgroup").and_return("")
+      plugin.run
+      expect(plugin[:virtualization][:system]).to eq("nspawn")
+      expect(plugin[:virtualization][:role]).to eq("guest")
+    end
+  end
+
   describe "when we are checking for docker" do
     it "sets docker guest if /proc/self/cgroup exist and there are /docker/<hexadecimal> mounts" do
       self_cgroup = <<-CGROUP

data/spec/unit/plugins/powershell_spec.rb

@@ -45,7 +45,7 @@ PSRemotingProtocolVersion      2.2
 END
     compat_version_array = ["1.0", "2.0", "3.0", "4.0"]
 
-    allow(plugin).to receive(:shell_out).with(anything()).and_return(mock_shell_out(0, v4_output, ""))
+    allow(plugin).to receive(:shell_out).with(anything).and_return(mock_shell_out(0, v4_output, ""))
     allow(plugin).to receive(:parse_compatible_versions).and_return(compat_version_array)
     plugin.run
     expect(plugin.languages[:powershell][:version]).to eql("4.0")

data/spec/unit/system_spec.rb

@@ -79,12 +79,12 @@ describe "Ohai::System" do
           log_level = :debug
           Ohai.config[:log_level] = log_level
           expect(Ohai::Log).not_to receive(:level=).with(log_level)
-          Ohai::System.new()
+          Ohai::System.new
         end
 
         it "does not resolve log_level when set to :auto" do
           expect(Ohai::Log).not_to receive(:level=).with(:info)
-          Ohai::System.new()
+          Ohai::System.new
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ohai
 version: !ruby/object:Gem::Version
-  version: 13.6.0
+  version: 13.7.0
 platform: ruby
 authors:
 - Adam Jacob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-24 00:00:00.000000000 Z
+date: 2017-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: systemu