ogc-gml 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85394869fbff7b7cac85c5d8ca435c1876b34dde2edb5936e1c05d88dc4fa36e
-  data.tar.gz: 85a6bed6c6f6c0e9c78ab57b616eac56a4ea7fe5aba9fed0464da454041b2263
+  metadata.gz: b8f0d439b67f0cc07b0974172fcb075c253f1e245947dd524a2cb53920529aef
+  data.tar.gz: d2413f431befdf21e5e7aad79fdaceb68be0636b49034d36dff6adf3777aeb9c
 SHA512:
-  metadata.gz: 893f2fcf43800b1049274ce83f2a73804768c82ccba372e831a940a1a592c3eb3033696af4b4ed1b0143587c00db7e68b0004df26ac42eac9e1f483e685b17a3
-  data.tar.gz: 3e32002b943e8c4c09876f0ee94c9328670fca33385a5c5efcf3de5af4ff1a8c01e326fb9d2c449349f95f9ff32797c9b79000b01286ac55f46c4a0b30421b52
+  metadata.gz: c0f302d4a94cbce0011ac7bf7991879d24e8e37fe04c08002078de0e55f9ea19c1795f2edc02217bcff16fd287662c2e80c423f7753aeee2b7f72838f43c5cbd
+  data.tar.gz: 76fa53ef24147b5b69d68e27c336f577c19201b940a0cdbe187e3bddf170c9c5d2544c8dc4512018e6e82c2621d76eea0913d3468f360d000e5f6a00b3e0a491

data/CLAUDE.md

@@ -0,0 +1,139 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+This is a Ruby gem for parsing and generating OGC GML 3.2 (Geography Markup Language) data. It provides Ruby objects that map to GML schema elements, using the `lutaml-model` library for XML serialization/deserialization.
+
+GML 3.1.1 documents are NOT parsed by these models (different namespace and schema). Multi-version support is planned on lutaml-model's register system (namespace-bound contexts per version, the plurimath/mml pattern); the i-UR 3.1.1 fixtures are skipped in specs until the gml_31 register mappings are generated.
+
+## Commands
+
+```bash
+# Install dependencies (includes git submodule initialization)
+git submodule update --init --recursive
+bundle install
+
+# Run all tests
+bundle exec rake spec
+# or
+bundle exec rspec
+
+# Run a single test file
+bundle exec rspec spec/ogc/gml/point_spec.rb
+
+# Run a specific test
+bundle exec rspec spec/ogc/gml/point_spec.rb:18
+
+# Run linter
+bundle exec rubocop
+
+# Run linter with auto-fix
+bundle exec rubocop -A
+
+# Run default task (tests + linting)
+bundle exec rake
+
+# Start interactive console
+bin/console
+```
+
+## Architecture
+
+The codebase follows a consistent pattern where each GML element is represented by a Ruby class:
+
+- **Location**: All model classes are in `lib/ogc/gml/` with one class per file
+- **Entry point**: `lib/ogc/gml.rb` registers `autoload` entries for every class; there is no `require_relative` graph (removing it fixed the circular-require warnings of issue #21). Never add `require_relative` for internal library code — add an autoload entry in `lib/ogc/gml.rb`.
+- **One class per file, opened first**: mutually recursive schema types rely on the class keyword executing before any cyclic constant reference. Do not embed duplicate or stub class definitions in other files (the old cycle-dodge shells broke autoload resolution).
+- **Namespace**: `lib/ogc/gml/namespace.rb` aliases `Namespace = Gml32Namespace`; the version namespace classes live in `lib/ogc/gml/namespaces/`
+
+### Class Hierarchy
+
+Classes inherit from abstract base classes that mirror the GML schema:
+
+```
+Lutaml::Model::Serializable
+└── AbstractGml
+    ├── AbstractFeature (features, collections)
+    ├── AbstractGeometry ← AbstractGeometricPrimitive
+    │   ├── Point, LineString, Curve, Surface, Solid, etc.
+    │   └── Multi* aggregate types
+    ├── AbstractCRS (coordinate reference systems)
+    ├── AbstractDatum, AbstractCoordinateSystem
+    └── AbstractTime* (temporal types)
+```
+
+### XML Mapping Pattern
+
+Each class defines its XML structure using the `xml` block:
+
+```ruby
+class Point < AbstractGeometry
+  attribute :pos, DirectPosition
+  attribute :coordinates, Coordinates
+
+  xml do
+    element "Point"
+    namespace Namespace  # References the Gml::Namespace constant
+
+    # gml:id is a namespace-qualified global attribute
+    map_attribute "id", to: :id, form: :qualified
+    # Local attributes are unqualified in the GML schema
+    map_attribute "srsName", to: :srs_name
+
+    map_element "pos", to: :pos
+    map_element "coordinates", to: :coordinates
+  end
+end
+```
+
+### Namespace Configuration
+
+The namespace classes (`lib/ogc/gml/namespaces/gml_32_namespace.rb`) configure the GML namespace:
+
+```ruby
+class Gml32Namespace < Lutaml::Xml::Namespace
+  uri "http://www.opengis.net/gml/3.2"
+  prefix_default "gml"
+  element_form_default :qualified
+  # NO attribute_form_default here: GML declares attributeFormDefault="unqualified".
+  # Qualifying the schema-wide default serialized invalid gml:srsName (issue #22).
+  # Only per-rule form: :qualified on gml:id attributes.
+end
+```
+
+## Testing
+
+Tests use RSpec with the `canon` gem for XML comparison. The main pattern is round-trip testing:
+
+```ruby
+it "round-trips Point-epsg3045.xml" do
+  input = file_contents("Point-epsg3045.xml")
+  output = described_class.from_xml(input).to_xml(
+    prefix: true,      # Include namespace prefixes
+    pretty: true,      # Format with indentation
+    declaration: true  # Include XML declaration
+  )
+  expect(SpecHelpers.remove_xml_comments(output))
+    .to be_xml_equivalent_to(SpecHelpers.remove_xml_comments(input))
+end
+```
+
+- `SpecHelpers.remove_xml_comments` (in `spec/spec_helper.rb`) is the shared comment-stripper.
+- Strict attribute-form assertions live in `spec/ogc/gml/point_spec.rb` (gml:id prefixed; srsName/srsDimension never prefixed) and `spec/ogc/gml/gml3*_namespace_spec.rb`. Canon compares attributes loosely (lutaml/canon#155), so prefix regressions are only caught by these strict specs.
+- RSpec semantics: `pending "reason"` inside an example body STILL EXECUTES the body; use `skip "reason"` when the body must not run (this once turned "pending" 3.1.1 round-trips into a multi-minute suite freeze).
+
+Test fixtures are located in:
+- `spec/fixtures/ets-gml32/` - GML test suite from OGC ETS for GML 3.2 (git submodule)
+- `spec/fixtures/geospatial_jp_iur_3.1/` - Japanese i-UR codelist data (GML 3.1.1; round-trips skipped pending gml_31 register support)
+
+## Dependencies
+
+- **lutaml-model**: XML serialization framework (`~> 0.8.20` — first release with source-namespace-preserving serialization, which round-trip fidelity relies on)
+- **nokogiri**: XML parsing
+- **canon**: XML comparison for tests (dev dependency in Gemfile, not gemspec)
+
+## Known upstream issues
+
+- lutaml-model#754: lenient parsing of out-of-namespace documents silently drops `gml:description` content; resolution is strict expanded-name parsing with register-based multi-version support, never local-name fallbacks.

data/Gemfile

@@ -6,7 +6,6 @@ source "https://rubygems.org"
 gemspec
 
 gem "canon"
-gem "lutaml-model", github: "lutaml/lutaml-model", branch: "main"
 gem "rake"
 gem "rspec"
 gem "rubocop"

data/README.adoc

@@ -46,10 +46,10 @@ For example:
 gml_data = File.read('spec/fixtures/geospatial_jp_iur_3.1/Bridge_class.xml')
 gml = Ogc::Gml::Dictionary.from_xml(gml_data)
 
-# Access the loaded GML Dictionary
-gml_dictionary = gml.dictionary
-gml_dictionary.features.each do |feature|
-  puts feature.name
+# Access the loaded GML Dictionary entries
+gml.dictionary_entry.each do |entry|
+  definition = entry.definition
+  puts "#{definition.name.first&.content}: #{definition.description}"
 end
 ----
 

data/lib/ogc/gml/abstract_continuous_coverage.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "coverage_function"
-require_relative "abstract_coverage"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_coordinate_operation.rb

@@ -2,10 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "coordinate_operation_accuracy"
-require_relative "crs_property"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractCoordinateOperation < AbstractTopology

data/lib/ogc/gml/abstract_coordinate_system.rb

@@ -2,13 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "coordinate_system_axis_property"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "identifier"
-
 module Ogc
   module Gml
     class AbstractCoordinateSystem < Lutaml::Model::Serializable

data/lib/ogc/gml/abstract_coverage.rb

@@ -1,11 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "bounding_shape"
-require_relative "domain_set"
-require_relative "location_property"
-require_relative "range_set"
-require_relative "abstract_topology"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_crs.rb

@@ -2,12 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractCRS < AbstractTopology

data/lib/ogc/gml/abstract_curve.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "abstract_geometric_primitive"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_datum.rb

@@ -2,12 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractDatum < AbstractTopology

data/lib/ogc/gml/abstract_feature.rb

@@ -2,14 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "bounding_shape"
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "location_property"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractFeature < AbstractTopology

data/lib/ogc/gml/abstract_feature_collection.rb

@@ -1,11 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "bounding_shape"
-require_relative "feature_array_property"
-require_relative "feature_property"
-require_relative "location_property"
-require_relative "abstract_topology"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_general_conversion.rb

@@ -2,13 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "coordinate_operation_accuracy"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractGeneralConversion < AbstractTopology

data/lib/ogc/gml/abstract_general_derived_crs.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "general_conversion_property"
-require_relative "abstract_crs"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_general_operation_parameter.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "abstract_topology"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_general_operation_parameter_property.rb

@@ -2,16 +2,8 @@
 
 require "lutaml/model"
 
-require_relative "abstract_general_operation_parameter"
-
 module Ogc
   module Gml
-    class RemoteSchema < Lutaml::Model::Type::String
-      xml do
-        namespace Namespace
-      end
-    end
-
     class AbstractGeneralOperationParameterProperty < Lutaml::Model::Serializable
       attribute :nil_reason, :string
       attribute :remote_schema, RemoteSchema

data/lib/ogc/gml/abstract_general_parameter_value_property.rb

@@ -2,8 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "abstract_general_parameter_value"
-
 module Ogc
   module Gml
     class AbstractGeneralParameterValueProperty < Lutaml::Model::Serializable

data/lib/ogc/gml/abstract_general_transformation.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "abstract_coordinate_operation"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_geometric_aggregate.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "abstract_geometric_primitive"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_geometric_primitive.rb

@@ -2,12 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "identifier"
-
 module Ogc
   module Gml
     class AbstractGeometricPrimitive < Lutaml::Model::Serializable

data/lib/ogc/gml/abstract_geometry.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "abstract_geometric_primitive"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_gml.rb

@@ -2,12 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractGML < AbstractTopology

data/lib/ogc/gml/abstract_meta_data.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "identifier"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_ring_property.rb

@@ -2,8 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "abstract_ring"
-
 module Ogc
   module Gml
     class AbstractRingProperty < Lutaml::Model::Serializable

data/lib/ogc/gml/abstract_solid.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "abstract_geometric_primitive"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_surface.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "abstract_geometric_primitive"
 
 module Ogc
   module Gml

data/lib/ogc/gml/abstract_time_complex.rb

@@ -2,12 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractTimeComplex < AbstractTopology

data/lib/ogc/gml/abstract_time_geometric_primitive.rb

@@ -2,13 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "related_time"
-require_relative "identifier"
-
 module Ogc
   module Gml
     class AbstractTimeGeometricPrimitive < Lutaml::Model::Serializable

data/lib/ogc/gml/abstract_time_object.rb

@@ -2,12 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractTimeObject < AbstractTopology

data/lib/ogc/gml/abstract_time_primitive.rb

@@ -1,13 +1,9 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-# require_relative "related_time"
 
 module Ogc
   module Gml
-    class RelatedTime < Lutaml::Model::Serializable
-    end
-
     class AbstractTimePrimitive < AbstractTopology
       attribute :related_time, RelatedTime, collection: true
 

data/lib/ogc/gml/abstract_time_slice.rb

@@ -2,14 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "string_or_ref"
-require_relative "time_primitive_property"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractTimeSlice < AbstractTopology

data/lib/ogc/gml/abstract_time_topology_primitive.rb

@@ -2,13 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "related_time"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractTimeTopologyPrimitive < AbstractTopology

data/lib/ogc/gml/abstract_topo_primitive.rb

@@ -2,12 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "abstract_topology"
-
 module Ogc
   module Gml
     class AbstractTopoPrimitive < AbstractTopology

data/lib/ogc/gml/abstract_topology.rb

@@ -1,11 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "code"
-require_relative "code_with_authority"
-require_relative "meta_data_property"
-require_relative "reference"
-require_relative "identifier"
 
 module Ogc
   module Gml

data/lib/ogc/gml/affine_cs.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "abstract_coordinate_system"
 
 module Ogc
   module Gml

data/lib/ogc/gml/affine_cs_property.rb

@@ -2,8 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "affine_cs"
-
 module Ogc
   module Gml
     class AffineCSProperty < Lutaml::Model::Serializable

data/lib/ogc/gml/affine_placement.rb

@@ -2,9 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "direct_position"
-require_relative "vector"
-
 module Ogc
   module Gml
     class AffinePlacement < Lutaml::Model::Serializable

data/lib/ogc/gml/angle.rb

@@ -2,9 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "measure"
-require_relative "unit_of_measure"
-
 module Ogc
   module Gml
     class Angle < UnitOfMeasure

data/lib/ogc/gml/arc.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "arc_string"
 
 module Ogc
   module Gml

data/lib/ogc/gml/arc_by_bulge.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "vector"
-require_relative "arc"
 
 module Ogc
   module Gml

data/lib/ogc/gml/arc_by_center_point.rb

@@ -2,11 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "angle"
-require_relative "direct_position"
-require_relative "length"
-require_relative "arc"
-
 module Ogc
   module Gml
     class ArcByCenterPoint < Arc

data/lib/ogc/gml/arc_string.rb

@@ -2,12 +2,6 @@
 
 require "lutaml/model"
 
-require_relative "coordinates"
-require_relative "direct_position_list"
-require_relative "direct_position"
-require_relative "point_property"
-require_relative "abstract_curve_segment"
-
 module Ogc
   module Gml
     class ArcString < AbstractCurveSegment

data/lib/ogc/gml/arc_string_by_bulge.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "vector"
-require_relative "arc_string"
 
 module Ogc
   module Gml