oga 1.3.0-java → 1.3.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b02ebf4182fe4de0d8b0fe875352a7f87300c19c
-  data.tar.gz: b190fec4be054b8acb23ba2b4e8b3d212a066ad7
+  metadata.gz: 3608b688e55076f115741bdb807801c071e30e60
+  data.tar.gz: 11f53bdfb9476c8f4fc1bb34d87492a735558924
 SHA512:
-  metadata.gz: 096867f90ece07e4e6aa55d92074a3f5bcfe6626fb652b0f43f5955b0712dd27a7636630b3c003336222f61a5105b3e49a2538ec403be4f23927593895d96d0f
-  data.tar.gz: 939678d51de4fe44eda8dada5d8b6e48a6cddb5b5f76b796501eb0c3dc643bae8a664b8cfe5a85c16194517cde982f22160995e79532f59a5a96ee92e7ae4d66
+  metadata.gz: ce3a13a06251539d4d9d16ea8095529606fb6d7a727c49ff8487c15bd62ee4233343e4ef8da5fd11323057607ad18421f8327830d36703b7575311217156625e
+  data.tar.gz: 6156e9bd4ec21b89974cf1e40406938164028c95aeac63207dffe48edbd3689bf3411cd3877e385fb7b38c790676b105c838db6e9eac8b614ae7cc1837b77561

data/README.md

@@ -177,13 +177,17 @@ process and bundled inside the Gem itself.
 
 ## Thread Safety
 
-Documents parsed using Oga are thread-safe as long as they are not modified by
-multiple threads at the same time. Querying documents using XPath can be done by
-multiple threads just fine. Write operations, such as removing attributes, are
-_not_ thread-safe and should not be done by multiple threads at once.
+Oga does not use a unsynchronized global mutable state. As a result of this you
+can parse/create documents concurrently without any problems. Modifying
+documents concurrently can lead to bugs as these operations are not
+synchronized.
 
-It is advised that you do not share parsed documents between threads unless you
-_really_ have to.
+Some querying operations will cache data in instance variables, without
+synchronization. An example is `Oga::XML::Element#namespace` which will cache an
+element's namespace after the first call.
+
+In general it's recommended to _not_ use the same document in multiple threads
+at the same time.
 
 ## Namespace Support
 

data/lib/oga.rb

@@ -55,6 +55,7 @@ require 'oga/ruby/generator'
 
 require 'oga/xpath/lexer'
 require 'oga/xpath/parser'
+require 'oga/xpath/context'
 require 'oga/xpath/compiler'
 require 'oga/xpath/conversion'
 

data/lib/oga/version.rb

@@ -1,3 +1,3 @@
 module Oga
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end # Oga

data/lib/oga/xpath/compiler.rb

@@ -12,6 +12,11 @@ module Oga
       # @return [Oga::LRU]
       CACHE = LRU.new
 
+      # Context for compiled Procs. As compiled Procs do not mutate the
+      # enclosing environment we can just re-use the same instance without
+      # synchronization.
+      CONTEXT = Context.new
+
       # Wildcard for node names/namespace prefixes.
       STAR = '*'
 
@@ -86,7 +91,7 @@ module Oga
         generator = Ruby::Generator.new
         source    = generator.process(proc_ast)
 
-        eval(source)
+        CONTEXT.evaluate(source)
       ensure
         reset
       end

data/lib/oga/xpath/context.rb

@@ -0,0 +1,17 @@
+module Oga
+  module XPath
+    # Class used as the context for compiled XPath Procs.
+    #
+    # The binding of this class is used for the binding of Procs compiled by
+    # {Compiler}. Not using a specific binding would result in the procs
+    # using the binding of {Compiler#compile}, which could lead to race
+    # conditions.
+    class Context
+      # @param [String] string
+      # @return [Proc]
+      def evaluate(string)
+        binding.eval(string)
+      end
+    end # Context
+  end # XPath
+end # Oga

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: oga
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: java
 authors:
 - Yorick Peterse
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-09-06 00:00:00.000000000 Z
+date: 2015-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -199,6 +199,7 @@ files:
 - lib/oga/xml/traversal.rb
 - lib/oga/xml/xml_declaration.rb
 - lib/oga/xpath/compiler.rb
+- lib/oga/xpath/context.rb
 - lib/oga/xpath/conversion.rb
 - lib/oga/xpath/lexer.rb
 - lib/oga/xpath/parser.rb