ofx_ruby 0.0.14 → 0.0.15

data/README.md

@@ -1,15 +1,23 @@
-# OfxRuby
+[coin]:https://raw.githubusercontent.com/bigfatgreg/ofx_ruby/master/doc/img/coin.gif
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/ofx_ruby`. To experiment with that code, run `bin/console` for an interactive prompt.
+[![Code Climate](https://codeclimate.com/repos/5817e08271a9496d910040e2/badges/aa4aa26c5907d13625de/gpa.svg)](https://codeclimate.com/repos/5817e08271a9496d910040e2/feed)
+[![Issue Count](https://codeclimate.com/repos/5817e08271a9496d910040e2/badges/aa4aa26c5907d13625de/issue_count.svg)](https://codeclimate.com/repos/5817e08271a9496d910040e2/feed)
+[![Test Coverage](https://codeclimate.com/repos/5817e08271a9496d910040e2/badges/aa4aa26c5907d13625de/coverage.svg)](https://codeclimate.com/repos/5817e08271a9496d910040e2/coverage)
+[![Build Status](https://drone.graveflex.com/api/badges/bigfatgreg/ofx_ruby/status.svg)](https://drone.graveflex.com/bigfatgreg/ofx_ruby)
 
-TODO: Delete this and the text above, and describe your gem
+  
+
+![coin]
+
+#OFX
+WIP ofx gem built for my rather specific needs. 
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'ofx_ruby'
+gem 'ofx_ruby', require: 'ofx'
 ```
 
 And then execute:
@@ -20,9 +28,9 @@ Or install it yourself as:
 
     $ gem install ofx_ruby
 
-## Usage
+## Use
 
-TODO: Write usage instructions here
+Take a look at the tests for usage examples.
 
 ## Development
 
@@ -32,7 +40,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/ofx_ruby. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/bigfatgreg/ofx_ruby. Pull requests must have tests. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](contributor-covenant.org) code of conduct.
 
 
 ## License

data/Rakefile

@@ -1,5 +1,7 @@
 require "bundler/gem_tasks"
 require "rake/testtask"
+require "dotenv"
+Dotenv.load
 
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
@@ -8,3 +10,18 @@ Rake::TestTask.new(:test) do |t|
 end
 
 task :default => :test
+
+namespace :drone do
+  desc 'Generate the encrypted drone secrets file.'
+  task :sec do
+    `DRONE_SERVER=#{ENV['DRONE_SERVER']} DRONE_TOKEN=#{ENV['DRONE_TOKEN']} \
+    drone secure --in .drone.sec.yml --repo #{ENV['DRONE_REPO']}`
+
+    puts 'generated .drone.sec.yml!'
+  end
+
+  desc 'Run the drone build locally'
+  task :test do
+    `drone exec -E .drone.sec.yml --trusted --debug --notify 2>&1`
+  end
+end

data/lib/ofx/document.rb

@@ -5,17 +5,17 @@ module OFX
     attr_reader :uri
 
     def initialize(options = {})
-      @user = options[:user] || ENV['OFX_USER']
-      @password = options[:password] || ENV['OFX_PASSWORD']
-      @uri = options[:uri] || ENV['OFX_URI']
-      @fi_org = options[:fi_org] || ENV['OFX_FI_ORG']
-      @fi_fid = options[:fi_fid] || ENV['OFX_FI_FID']
-      @routing = options[:routing] || ENV['OFX_ROUTING']
-      @account = options[:account] || ENV['OFX_ACCOUNT']
-      @app_id = options[:app_id] || ENV['OFX_APP_ID']
-      @app_ver = options[:app_ver] || ENV['OFX_APP_VER']
       @start = options[:start] || (Date.today - 30)
       @end = options[:end] || Date.today
+      @uri = options[:uri]
+      @user = options[:user]
+      @password = options[:password]
+      @routing = options[:routing]
+      @account = options[:account]
+      @fi_org = options[:fi_org]
+      @fi_fid = options[:fi_fid]
+      @app_id = options[:app_id]
+      @app_ver = options[:app_ver]
       super
     end
     
@@ -54,39 +54,39 @@ module OFX
     end
 
     def user
-      @user || (raise Errors::UserMissing)
+      @user || ENV['OFX_USER'] || (raise Errors::UserMissing)
     end
-    
+
     def password
-      @password || (raise Errors::PasswordMissing)
+      @password || ENV['OFX_PASSWORD'] || (raise Errors::PasswordMissing)
     end
-    
+
     def fi_org
-      @fi_org || (raise Errors::FiOrgMissing)
+      @fi_org || ENV['OFX_FI_ORG'] || (raise Errors::FiOrgMissing)
     end
-    
+
     def fi_fid
-      @fi_fid || (raise Errors::FiFidMissing)
+      @fi_fid || ENV['OFX_FI_FID'] || (raise Errors::FiFidMissing)
     end
-    
+
     def routing
-      @routing || (raise Errors::RoutingMissing)
+      @routing || ENV['OFX_ROUTING'] || (raise Errors::RoutingMissing)
     end
-    
+
     def account
-      @account || (raise Errors::AccountMissing)
+      @account || ENV['OFX_ACCOUNT'] || (raise Errors::AccountMissing)
     end
-    
+
     def app_id
-      @app_id || (raise Errors::AppIdMissing)
+      @app_id || ENV['OFX_APP_ID'] || (raise Errors::AppIdMissing)
     end
-    
+
     def app_ver
-      @app_ver || (raise Errors::AppVerMissing)
+      @app_ver || ENV['OFX_APP_VER'] || (raise Errors::AppVerMissing)
     end
-    
+
     def uri
-      @uri || (raise Errors::URIMissing)
+      @uri || ENV['OFX_URI'] || (raise Errors::URIMissing)
     end
 
     def http

data/lib/ofx/document/bank_account.rb

@@ -3,8 +3,8 @@ module OFX
   class Document
     class BankAccount < StatementRequest
       def initialize(options = {})
-        @routing = options[:routing] || (raise Errors::RoutingNumberMissing)
-        @account = options[:account] || (raise Errors::AccountNumberMissing)
+        @routing = options[:routing] || (raise Errors::RoutingMissing)
+        @account = options[:account] || (raise Errors::AccountMissing)
         @type = account_type(options[:type] || :checking)
         super
       end

data/lib/ofx/errors.rb

@@ -76,20 +76,6 @@ module OFX
       end
     end
 
-    class RoutingNumberMissing < Errors
-      def message
-        'You must specify the routing number for ' \
-        'your account in the options hash or ' \
-        'set OFX_URI as an environment.'
-      end
-    end
-
-    class AccountNumberMissing < Errors
-      def message
-        'You must specify the account number in the options hash.'
-      end
-    end
-
     class AccountTypeNotAvailable < Errors
       def message
         "The account type #{@account_type} is not available. " \

data/lib/ofx/handler.rb

@@ -31,7 +31,7 @@ module OFX
       case name
       when :STMTTRN
         @parser.output[:transactions] = [] unless @parser.output[:transactions]
-        @parser.output[:transactions].push(transaction(@transaction))
+        @parser.output[:transactions].push(transaction)
       when :LEDGERBAL
         @parser.output[:balance] = @balance[:BALAMT]
       when :AVAILBAL
@@ -41,7 +41,7 @@ module OFX
     
     protected
     
-    def transaction(hash)
+    def transaction
       { type: @transaction[:TRNTYPE], posted: @transaction[:DTPOSTED],
         amount: @transaction[:TRNAMT], fitid: @transaction[:FITID],
         name: @transaction[:NAME] }

data/lib/ofx/http.rb

@@ -13,8 +13,8 @@ module OFX
 
     def headers
       {
-        'Content-Type': 'application/x-ofx',
-        'Accept': '*/*, application/x-ofx'
+        'Content-Type' => 'application/x-ofx',
+        'Accept'=> '*/*, application/x-ofx'
       }
     end
 

data/lib/ofx/parser.rb

@@ -4,7 +4,7 @@ module OFX
     attr_reader :body
     attr_accessor :output
     
-    def initialize(body, options = {})
+    def initialize(body)
       @body = body
       @output = {}
       dump

data/lib/ofx/version.rb

@@ -1,3 +1,3 @@
 module OFX
-  VERSION = "0.0.14"
+  VERSION = "0.0.15"
 end

data/ofx_ruby.gemspec

@@ -1,7 +1,7 @@
 # coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'ofx'
+require 'ofx/version'
 
 Gem::Specification.new do |g|
   g.name          = "ofx_ruby"
@@ -22,6 +22,8 @@ Gem::Specification.new do |g|
   g.add_development_dependency "guard-minitest", "~> 2.4.5"
   g.add_development_dependency "dotenv", "~> 2.1.1"
   g.add_development_dependency "byebug", "~> 9.0.5"
+  g.add_development_dependency "codeclimate-test-reporter", "~> 0.4.8"
+  g.add_development_dependency "simplecov"
 
   g.required_ruby_version = ">= 2.3"
   g.add_dependency "ox", "~> 2.4"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ofx_ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.14
+  version: 0.0.15
 platform: ruby
 authors:
 - rob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-30 00:00:00.000000000 Z
+date: 2016-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -122,6 +122,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 9.0.5
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.4.8
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.4.8
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ox
   requirement: !ruby/object:Gem::Requirement
@@ -143,8 +171,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
+- ".drone.sec"
+- ".drone.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".rubocop.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Guardfile
@@ -153,6 +184,7 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- doc/img/coin.gif
 - lib/ofx.rb
 - lib/ofx/aggregate.rb
 - lib/ofx/document.rb
@@ -190,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: A simple, incomplete OFX gem for Ruby.

data/.travis.yml

@@ -1,4 +0,0 @@
-language: ruby
-rvm:
-  - 2.2.4
-before_install: gem install bundler -v 1.10.6