ofx_reader 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae2436c3f3f0305cbb57d847205d99ea6e71ff0a1394f180b35bf033c59818c1
-  data.tar.gz: 3fd5a2ae1f9ccbe8ca15bd160236c159b583b1e4f0c59b913992631f345c4989
+  metadata.gz: 412056e9bc0138a1aa7612277e4678942fa1e8a514ef3af9c84133e337cba320
+  data.tar.gz: c2a011b0b3d7002fecc96b7923bf827969fb9c7db28e5deb02bb59dad2da1bc6
 SHA512:
-  metadata.gz: e7ae801e9a571dc1c8c122e13a8e2c6e0e1241975ed566fcf469d9afff5df38f2dbbb6abc7730fdc97e4688cb41573a8e37318fcb831bce1413efe9c32c2ddad
-  data.tar.gz: 151e7cb00cbb1d41b570d3ac8a4b89f95434db9820a9aee215153dfdac67758a3834f239194d57c4294628a4ad7ffa4f27896ee3aa8d018f1fe8ba60f0371470
+  metadata.gz: 3f4a500d8b8d3d7dccc9601d1a97ab572c7d4506a990ed0198b1e004a70aa3987a196467c5d30d09ad6561fcb6b6ce9e93fec3a16aa3ae6fdd74c414e67aa2cb
+  data.tar.gz: 74c34eb7b255ab0438d5ba9bacc9861efc45734ff0f079f88cecf3ad129f0e7671dca56e3875ab02c1e0304d8987136c22dbf75a0ab300a55ac070594e4e8493

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ofx_reader (0.1.1)
+    ofx_reader (0.1.3)
       nokogiri (~> 1.8)
 
 GEM

data/README.md

@@ -21,7 +21,8 @@ Or install it yourself as:
 ## Usage
 
 ```ruby
-ofx = OFXReader::Parser::OFX102.new(ofx_text)
+ofx = OFXReader.(ofx_text)
+=> #<OFXReader::Parser::Base:...
 ```
 
 #### Headers

data/lib/ofx_reader/errors/unsupported_ofx_version_error.rb

@@ -0,0 +1,2 @@
+class UnsupportedOFXVersionError < StandardError
+end

data/lib/ofx_reader/parser/base.rb

@@ -4,36 +4,41 @@ module OFXReader
       require 'nokogiri'
       require 'time'
 
-      attr_reader :headers, :body, :content
+      attr_reader :header, :body
+      attr_reader :headers, :account, :transactions
 
       def initialize(content)
-        @content = content.encode("UTF-8", "ISO-8859-1")
-        @headers, @body = read(@content)
+        content = content.encode("UTF-8", "ISO-8859-1")
+        @header, @body = content.dup.split(/(?=<OFX>)/, 2)
+        @headers = parse_headers(header)
+        @account, @transactions = parse_body(body)
       end
 
       private
 
-      def read(content)
-        headers, body = content.dup.split(/(?=<OFX>)/, 2)
-        headers = parse_headers(headers)
-        body = parse_body(body)
-        [headers, body]
-      end
-
       def parse_headers(headers)
         headers.each_line.with_object({}) do |line, hash|
           _, k, v = *line.match(/^(.*?):(.*?)\s*(\r?\n)*$/)
-          hash[k] = v unless v.nil?
+          hash[k.downcase.to_sym] = v unless v.nil?
         end
       end
 
       def parse_body(body)
-        # body.prepend('<OFX>')
         body.gsub!(/>\s+</m, '><')
         body.gsub!(/\s+</m, '<')
         body.gsub!(/>\s+/m, '>')
         body.gsub!(/<(\w+?)>([^<]+)/m, '<\1>\2</\1>')
-        body = ::Nokogiri::XML(body)
+        parser.new(::Nokogiri::XML(body)).parse
+      end
+
+      def parser
+        # TODO: Provide support to other formats
+        case headers[:version]
+        when /10(2|3)/
+          OFXReader::Parser::OFX102
+        else
+          raise UnsupportedOFXVersionError
+        end
       end
     end
   end

data/lib/ofx_reader/parser/ofx_102.rb

@@ -1,31 +1,19 @@
 module OFXReader
   module Parser
-    class OFX102 < OFXReader::Parser::Base
-
-      ACCOUNT_TYPES = [
-        "CHECKING",
-        "SAVINGS",
-        "CREDITCARD",
-        "CREDITLINE",
-        "INVESTMENT",
-        "MONEYMRKT",
-      ]
-
-      TRANSACTION_TYPES = [
-        'ATM', 'CASH', 'CHECK', 'CREDIT', 'DEBIT', 'DEP', 'DIRECTDEBIT',
-        'DIRECTDEP', 'DIV', 'FEE', 'INT', 'OTHER', 'PAYMENT', 'POS',
-        'REPEATPMT', 'SRVCHG', 'XFER',
-      ].inject({}) { |hash, type| hash.tap { |h| h[type] = type.downcase } }
+    class OFX102 < Struct.new(:ofx_body)
+      def parse
+        [account, transactions]
+      end
 
       def account
         {
-          bank_id: body.search('BANKACCTFROM BANKID').inner_text,
-          account_id: body.search('BANKACCTFROM ACCTID').inner_text,
+          bank_id: ofx_body.search('BANKACCTFROM BANKID').inner_text,
+          account_id: ofx_body.search('BANKACCTFROM ACCTID').inner_text,
         }
       end
 
       def transactions
-        body.search('BANKTRANLIST STMTTRN').map do |node|
+        ofx_body.search('BANKTRANLIST STMTTRN').map do |node|
           build_transaction(node)
         end
       end

data/lib/ofx_reader/version.rb

@@ -1,3 +1,3 @@
 module OFXReader
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/ofx_reader.rb

@@ -5,9 +5,27 @@ begin
 rescue LoadError
 end
 
+require "ofx_reader/errors/unsupported_ofx_version_error"
 require "ofx_reader/parser/base"
 require "ofx_reader/parser/ofx_102"
 
 module OFXReader
-  # Your code goes here...
+# ACCOUNT_TYPES = [
+#   "CHECKING",
+#   "SAVINGS",
+#   "CREDITCARD",
+#   "CREDITLINE",
+#   "INVESTMENT",
+#   "MONEYMRKT",
+# ]
+#
+# TRANSACTION_TYPES = [
+#   'ATM', 'CASH', 'CHECK', 'CREDIT', 'DEBIT', 'DEP', 'DIRECTDEBIT',
+#   'DIRECTDEP', 'DIV', 'FEE', 'INT', 'OTHER', 'PAYMENT', 'POS',
+#   'REPEATPMT', 'SRVCHG', 'XFER',
+# ]
+
+  def self.call(ofx_text)
+    OFXReader::Parser::Base.new(ofx_text)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ofx_reader
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Francisco Martins
@@ -99,6 +99,7 @@ files:
 - bin/setup
 - exe/ofx_reader
 - lib/ofx_reader.rb
+- lib/ofx_reader/errors/unsupported_ofx_version_error.rb
 - lib/ofx_reader/parser/base.rb
 - lib/ofx_reader/parser/ofx_102.rb
 - lib/ofx_reader/version.rb