ofx_br 0.3.3 → 0.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7762b34050e1cb1c3cd7191d88bdbff23902c771a4e76e50ec960ead46464bb7
-  data.tar.gz: 4fb5f842f6592c125a07007dc7e33aefb7ec6b72a37c0c9d270f374d3f16e424
+  metadata.gz: cdedb8184f7321dcbae5c63eb80b1eabadf9c2543d383dfa89ffdd0a46c512fb
+  data.tar.gz: 27e6a3b16b2a703a260dde990c8afc1549d5d16389d52fa1da88a3255b150b5c
 SHA512:
-  metadata.gz: ec56cc287b9b1c4accc141a97ffbb7f10c649cb4a29ee4b5234ef77aee52d413ee65177b26d20d33a5c468610bf2a4734aff9cedcaee881efc12bbfb3dab800e
-  data.tar.gz: ebc5b4d3243f90de88678b0cd696e47fd9c01e160ad529946936b1276ca55f9d892e60b0b11122ab3a7e972dabe9c8234fba0c0b5641509defcc9aecf7d3ba73
+  metadata.gz: d312c4e19283da6d4bab75b0a1989a9e579a94e83ecfbbca8c672a267e3636769586709cbf681174aaded45b5f7fdc6d372390ae30f7577d8381d9f488d73cbb
+  data.tar.gz: 01b7e02a8b575cbe51bb3b2da3c06277defc1d114cd5a5ced0ad64f8b1f426fde9235679f111421bd368ee4f90a9433c8da91e59248c512fdd1364b12239e5d2

data/README.rdoc

@@ -1,7 +1,7 @@
 = OFX
 
-{<img src="https://badge.fury.io/rb/ofx.png" alt="Gem Version" />}[http://badge.fury.io/rb/ofx]
-{<img src="https://travis-ci.org/annacruz/ofx.svg?branch=master" alt="Build Status" />}[https://travis-ci.org/annacruz/ofx]
+{<img src="https://badge.fury.io/rb/ofx.svg" alt="Gem Version" />}[https://badge.fury.io/rb/ofx]
+{<img src="https://github.com/annacruz/ofx/actions/workflows/config.yml/badge.svg" alt="Build Status" />}[https://github.com/annacruz/ofx/actions]
 
 A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently supports both OFX 1.0.2 and 2.1.1.
 

data/lib/{ofx_br → ofx}/parser/ofx102.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OFX
   module Parser
     class OFX102
@@ -8,28 +10,27 @@ module OFX
         'SAVINGS' => :savings,
         'CREDITLINE' => :creditline,
         'MONEYMRKT' => :moneymrkt
-      }
+      }.freeze
 
       TRANSACTION_TYPES = %w[
         ATM CASH CHECK CREDIT DEBIT DEP DIRECTDEBIT DIRECTDEP DIV
-        FEE INT OTHER PAYMENT POS REPEATPMT SRVCHG XFER
-      ].each_with_object({}) { |tran_type, hash| hash[tran_type] = tran_type.downcase.to_sym; }
+        FEE INT OTHER PAYMENT POS REPEATPMT SRVCHG XFER IN OUT
+      ].each_with_object({}) do |tran_type, hash|
+        hash[tran_type] = tran_type.downcase.to_sym
+      end
 
       SEVERITY = {
         'INFO' => :info,
         'WARN' => :warn,
         'ERROR' => :error
-      }
+      }.freeze
 
-      attr_reader :headers, :body, :html, :date_start, :date_end
+      attr_reader :headers, :body, :html
 
       def initialize(options = {})
         @headers = options[:headers]
         @body = options[:body]
         @html = Nokogiri::HTML.parse(body)
-
-        @date_start ||= build_date(@html.search('banktranlist > dtstart').inner_text)
-        @date_end ||= build_date(@html.search('banktranlist > dtend').inner_text)
       end
 
       def statements
@@ -72,6 +73,8 @@ module OFX
         account = build_account(node)
         OFX::Statement.new(
           currency: stmrs_node.search('curdef').inner_text,
+          start_date: build_date(stmrs_node.search('banktranlist > dtstart').inner_text),
+          end_date: build_date(stmrs_node.search('banktranlist > dtend').inner_text),
           account: account,
           transactions: account.transactions,
           balance: account.balance,
@@ -195,6 +198,8 @@ module OFX
 
       def to_decimal(amount)
         BigDecimal(amount.to_s.gsub(',', '.'))
+      rescue ArgumentError
+        BigDecimal('0.0')
       end
     end
   end

data/lib/{ofx_br → ofx}/parser.rb

@@ -17,10 +17,8 @@ module OFX
         end
 
         case headers["VERSION"]
-        when /102/ then
+        when /100|102|103/ then
           @parser = OFX102.new(:headers => headers, :body => body)
-        when /103/ then
-          @parser = OFX103.new(:headers => headers, :body => body)
         when /200|202|211|220/ then
           @parser = OFX211.new(:headers => headers, :body => body)
         else

data/lib/ofx/statement.rb

@@ -0,0 +1,11 @@
+module OFX
+  class Statement < Foundation
+    attr_accessor :account
+    attr_accessor :available_balance
+    attr_accessor :balance
+    attr_accessor :currency
+    attr_accessor :start_date
+    attr_accessor :end_date
+    attr_accessor :transactions
+  end
+end

data/lib/{ofx_br → ofx}/version.rb

@@ -2,7 +2,7 @@ module OFX
   module Version
     MAJOR = 0
     MINOR = 3
-    PATCH = 3
+    PATCH = 8
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/lib/ofx.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'open-uri'
+require 'nokogiri'
+require 'bigdecimal'
+
+require 'kconv'
+
+require 'ofx/errors'
+require 'ofx/parser'
+require 'ofx/parser/ofx102'
+require 'ofx/parser/ofx211'
+require 'ofx/foundation'
+require 'ofx/balance'
+require 'ofx/account'
+require 'ofx/sign_on'
+require 'ofx/status'
+require 'ofx/statement'
+require 'ofx/transaction'
+require 'ofx/version'
+
+def OFX(resource, &block)
+  parser = OFX::Parser::Base.new(resource).parser
+
+  if block_given?
+    if block.arity == 1
+      yield parser
+    else
+      parser.instance_eval(&block)
+    end
+  end
+
+  parser
+end

data/spec/{ofx_br → ofx}/ofx102_spec.rb

@@ -39,7 +39,7 @@ describe OFX::Parser::OFX102 do
   it "should know about all transaction types" do
     valid_types = [
       'CREDIT', 'DEBIT', 'INT', 'DIV', 'FEE', 'SRVCHG', 'DEP', 'ATM', 'POS', 'XFER',
-      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER'
+      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER', 'IN', 'OUT'
     ]
     valid_types.sort.should == OFX::Parser::OFX102::TRANSACTION_TYPES.keys.sort
 

data/spec/{ofx_br → ofx}/ofx_parser_spec.rb

@@ -1,6 +1,17 @@
 require "spec_helper"
 
 describe OFX::Parser do
+  def ofx_example_to(version)
+    <<~OFX_CONTENT
+      <?xml version="1.0" encoding="US-ASCII"?>
+
+      <?OFX OFXHEADER="200" VERSION="#{version}" SECURITY="NONE" OLDFILEUID="NONE" NEWFILEUID="NONE"?>"
+
+      <OFX>
+      </OFX>
+    OFX_CONTENT
+  end
+
   before do
     @ofx = OFX::Parser::Base.new("spec/fixtures/sample.ofx")
   end
@@ -47,18 +58,53 @@ describe OFX::Parser do
     }.should raise_error(OFX::UnsupportedFileError)
   end
 
+  it "should use 102 parser to parse version 100 ofx files" do
+    expect(OFX::Parser::OFX102).to receive(:new).and_return('ofx-102-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_example_to('100'))
+    expect(ofx.parser).to eql 'ofx-102-parser'
+  end
+
+  it "should use 102 parser to parse version 102 ofx files" do
+    expect(OFX::Parser::OFX102).to receive(:new).and_return('ofx-102-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_example_to('102'))
+    expect(ofx.parser).to eql 'ofx-102-parser'
+  end
+
+  it "should use 102 parser to parse version 103 ofx files" do
+    expect(OFX::Parser::OFX102).to receive(:new).and_return('ofx-102-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_example_to('103'))
+    expect(ofx.parser).to eql 'ofx-102-parser'
+  end
+
   it "should use 211 parser to parse version 200 ofx files" do
-    OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
-    ofx = OFX::Parser::Base.new(ofx_2_example('200'))
+    expect(OFX::Parser::OFX211).to receive(:new).and_return('ofx-211-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_example_to('200'))
     ofx.parser.should == 'ofx-211-parser'
   end
 
   it "should use 211 parser to parse version 202 ofx files" do
     OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
-    ofx = OFX::Parser::Base.new(ofx_2_example('202'))
+    ofx = OFX::Parser::Base.new(ofx_example_to('202'))
     ofx.parser.should == 'ofx-211-parser'
   end
 
+  it "should use 211 parser to parse version 211 ofx files" do
+    OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
+    ofx = OFX::Parser::Base.new(ofx_example_to('211'))
+    ofx.parser.should == 'ofx-211-parser'
+  end
+
+  it "should use 211 parser to parse version 220 ofx files" do
+    expect(OFX::Parser::OFX211).to receive(:new).and_return('ofx-211-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_example_to('220'))
+    expect(ofx.parser).to eql 'ofx-211-parser'
+  end
+
   describe "headers" do
     it "should have OFXHEADER" do
       @ofx.headers["OFXHEADER"].should == "100"
@@ -101,23 +147,12 @@ describe OFX::Parser do
     end
 
     it "should parse headers with CR and without LF" do
+      header = %{OFXHEADER:100\rDATA:OFXSGML\rVERSION:102\rSECURITY:NONE\rENCODING:USASCII\rCHARSET:1252\rCOMPRESSION:NONE\rOLDFILEUID:NONE\rNEWFILEUID:NONE\r}
+      body   = open("spec/fixtures/sample.ofx").read.split(/<OFX>/, 2)[1]
+      ofx_with_carriage_return = header + "<OFX>" + body
+
       @ofx = OFX::Parser::Base.new(ofx_with_carriage_return)
       @ofx.headers.size.should be(9)
     end
   end
-
-  def ofx_with_carriage_return
-    header = %{OFXHEADER:100\rDATA:OFXSGML\rVERSION:102\rSECURITY:NONE\rENCODING:USASCII\rCHARSET:1252\rCOMPRESSION:NONE\rOLDFILEUID:NONE\rNEWFILEUID:NONE\r}
-    body   = open("spec/fixtures/sample.ofx").read.split(/<OFX>/, 2)[1]
-    header + "<OFX>" + body
-  end
-
-  def ofx_2_example(version)
-    <<-EndOfx
-<?xml version="1.0" encoding="US-ASCII"?>
-<?OFX OFXHEADER="200" VERSION="#{version}" SECURITY="NONE" OLDFILEUID="NONE" NEWFILEUID="NONE"?>"
-<OFX>
-</OFX>
-    EndOfx
-  end
 end

data/spec/{ofx_br → ofx}/transaction_spec.rb

@@ -13,43 +13,43 @@ describe OFX::Transaction do
     end
 
     it "should set amount" do
-      @transaction.amount.should == BigDecimal('-35.34')
+      expect(@transaction.amount).to eql BigDecimal('-35.34')
     end
 
     it "should cast amount to BigDecimal" do
-      @transaction.amount.class.should == BigDecimal
+      expect(@transaction.amount.class).to be BigDecimal
     end
 
     it "should set amount in pennies" do
-      @transaction.amount_in_pennies.should == -3534
+      expect(@transaction.amount_in_pennies).to eql -3534
     end
 
     it "should set fit id" do
-      @transaction.fit_id.should == "200910091"
+      expect(@transaction.fit_id).to eql "200910091"
     end
 
     it "should set memo" do
-      @transaction.memo.should == "COMPRA VISA ELECTRON"
+      expect(@transaction.memo).to eql "COMPRA VISA ELECTRON"
     end
 
     it "should set check number" do
-      @transaction.check_number.should == "0001223"
+      expect(@transaction.check_number).to eql "0001223"
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-09 08:00:00 +0000")
+      expect(@transaction.posted_at).to eql Time.parse("2009-10-09 08:00:00 +0000")
     end
 
     it 'should have user date' do
-      @transaction.occurred_at.should == Time.parse("2009-09-09 08:00:00 +0000")
+      expect(@transaction.occurred_at).to eql Time.parse("2009-09-09 08:00:00 +0000")
     end
 
     it "should have type" do
-      @transaction.type.should == :debit
+      expect(@transaction.type).to eql :debit
     end
 
     it "should have sic" do
-      @transaction.sic.should == '5072'
+      expect(@transaction.sic).to eql '5072'
     end
   end
 
@@ -59,39 +59,39 @@ describe OFX::Transaction do
     end
 
     it "should set amount" do
-      @transaction.amount.should == BigDecimal('60.39')
+      expect(@transaction.amount).to eql BigDecimal('60.39')
     end
 
     it "should set amount in pennies" do
-      @transaction.amount_in_pennies.should == 6039
+      expect(@transaction.amount_in_pennies).to eql 6039
     end
 
     it "should set fit id" do
-      @transaction.fit_id.should == "200910162"
+      expect(@transaction.fit_id).to eql "200910162"
     end
 
     it "should set memo" do
-      @transaction.memo.should == "DEPOSITO POUP.CORRENTE"
+      expect(@transaction.memo).to eql "DEPOSITO POUP.CORRENTE"
     end
 
     it "should set check number" do
-      @transaction.check_number.should == "0880136"
+      expect(@transaction.check_number).to eql "0880136"
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-16 08:00:00 +0000")
+      expect(@transaction.posted_at).to eql Time.parse("2009-10-16 08:00:00 +0000")
     end
 
     it "should have user date" do
-      @transaction.occurred_at.should == Time.parse("2009-09-16 08:00:00 +0000")
+      expect(@transaction.occurred_at).to eql Time.parse("2009-09-16 08:00:00 +0000")
     end
 
     it "should have type" do
-      @transaction.type.should == :credit
+      expect(@transaction.type).to eql :credit
     end
 
     it "should have empty sic" do
-      @transaction.sic.should == ''
+      expect(@transaction.sic).to eql ''
     end
   end
 
@@ -101,27 +101,27 @@ describe OFX::Transaction do
     end
 
     it "should set payee" do
-      @transaction.payee.should == "Pagto conta telefone"
+      expect(@transaction.payee).to eql "Pagto conta telefone"
     end
 
     it "should set check number" do
-      @transaction.check_number.should == "000000101901"
+      expect(@transaction.check_number).to eql "000000101901"
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-19 12:00:00 -0300")
+      expect(@transaction.posted_at).to eql Time.parse("2009-10-19 12:00:00 -0300")
     end
 
     it "should have user date" do
-      @transaction.occurred_at.should == Time.parse("2009-10-17 12:00:00 -0300")
+      expect(@transaction.occurred_at).to eql Time.parse("2009-10-17 12:00:00 -0300")
     end
 
     it "should have type" do
-      @transaction.type.should == :other
+      expect(@transaction.type).to eql :other
     end
 
     it "should have reference number" do
-      @transaction.ref_number.should == "101.901"
+      expect(@transaction.ref_number).to eql "101.901"
     end
   end
 
@@ -131,7 +131,7 @@ describe OFX::Transaction do
     end
 
     it "should set name" do
-      @transaction.name.should == "Pagto conta telefone"
+      expect(@transaction.name).to eql "Pagto conta telefone"
     end
   end
 
@@ -144,22 +144,22 @@ describe OFX::Transaction do
 
     it "should return dep" do
       @transaction = @account.transactions[9]
-      @transaction.type.should == :dep
+      expect(@transaction.type).to eql :dep
     end
 
     it "should return xfer" do
       @transaction = @account.transactions[18]
-      @transaction.type.should == :xfer
+      expect(@transaction.type).to eql :xfer
     end
 
     it "should return cash" do
       @transaction = @account.transactions[45]
-      @transaction.type.should == :cash
+      expect(@transaction.type).to eql :cash
     end
 
     it "should return check" do
       @transaction = @account.transactions[0]
-      @transaction.type.should == :check
+      expect(@transaction.type).to eql :check
     end
   end
 
@@ -176,11 +176,11 @@ describe OFX::Transaction do
       end
 
       it "should set amount" do
-        @transaction.amount.should == BigDecimal('-11.76')
+        expect(@transaction.amount).to eql BigDecimal('-11.76')
       end
 
       it "should set amount in pennies" do
-        @transaction.amount_in_pennies.should == -1176
+        expect(@transaction.amount_in_pennies).to eql -1176
       end
     end
 
@@ -190,12 +190,31 @@ describe OFX::Transaction do
       end
 
       it "should set amount" do
-        @transaction.amount.should == BigDecimal('47.01')
+        expect(@transaction.amount).to eql BigDecimal('47.01')
       end
 
       it "should set amount in pennies" do
-        @transaction.amount_in_pennies.should == 4701
+        expect(@transaction.amount_in_pennies).to eql 4701
       end
     end
   end
+
+  context "invalid decimal values" do
+    before do
+      @ofx = OFX::Parser::Base.new("spec/fixtures/cef_malformed_decimal.ofx")
+      @parser = @ofx.parser
+    end
+
+    it "should not raise error" do
+      expect { @parser.account.transactions }.to_not raise_error
+    end
+
+    it "should return zero in amount" do
+      expect(@parser.account.transactions[0].amount).to eql BigDecimal('0.0')
+    end
+
+    it "should return zero in amount_in_pennies" do
+      expect(@parser.account.transactions[0].amount_in_pennies).to eql 0
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,9 +1,14 @@
-require 'ofx_br'
+require "ofx"
+require "byebug"
 
 RSpec::Matchers.define :have_key do |key|
   match do |hash|
     hash.respond_to?(:keys) &&
-      hash.keys.is_a?(Array) &&
-      hash.keys.include?(key)
+    hash.keys.kind_of?(Array) &&
+    hash.keys.include?(key)
   end
 end
+
+RSpec.configure do |c|
+  c.filter_run_when_matching :focus
+end