ofx 0.3.4 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f010daf75c910a87b19c737c27a0970a4a410f5e5b6ba5916f4546e2bb5f9abb
-  data.tar.gz: abf6b0090855e5c063ce2d627e8f2b4907be64a71289cb520d4ae4bf7687371e
+  metadata.gz: 98b2accf4fa4b1b9d0d8168e4518140484b69be77dfc114d5924eea1cf6eb912
+  data.tar.gz: c7eb6a605614095ac31ffcc840965a965146f803453652a37d1d2855e2dbc5e4
 SHA512:
-  metadata.gz: f3ccb6719848c32e3047243715a3ec2aabbc80b2f241bfd2ff7dcbda819bf1baeb3086ee751459a28643345d4272bf4b4481dd56ba727f9ebf94ea6a680d4cf0
-  data.tar.gz: 48076b4428d20fa368544099691ebe1bf877b724b49cfce83265545a84b62b07e45759e00ae0febaf254090d53c157a1f9b7b6340f5c9d59237aa1847e590ca5
+  metadata.gz: daf84f358d5810cfa9916dcce97bedb6297718f1db96e9bf347a5fef041c35eafa4e7934e0509a0c0133199ef678713ebba377afdde3f8172f523808abfb1ea4
+  data.tar.gz: 3bee29bfb6338c36842e5b08321944c3b4c668e607b3c980b2acba9dfa530941f17157ca0ca8921cb6479e380a33c4145a309e5f5cdf482a8147c06fa98627c2

data/README.rdoc

@@ -1,7 +1,7 @@
 = OFX
 
-{<img src="https://badge.fury.io/rb/ofx.png" alt="Gem Version" />}[http://badge.fury.io/rb/ofx]
-{<img src="https://travis-ci.org/annacruz/ofx.svg?branch=master" alt="Build Status" />}[https://travis-ci.org/annacruz/ofx]
+{<img src="https://badge.fury.io/rb/ofx.svg" alt="Gem Version" />}[https://badge.fury.io/rb/ofx]
+{<img src="https://github.com/annacruz/ofx/actions/workflows/config.yml/badge.svg" alt="Build Status" />}[https://github.com/annacruz/ofx/actions]
 
 A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently supports both OFX 1.0.2 and 2.1.1.
 

data/lib/ofx/parser/ofx102.rb

@@ -14,7 +14,7 @@ module OFX
 
       TRANSACTION_TYPES = %w[
         ATM CASH CHECK CREDIT DEBIT DEP DIRECTDEBIT DIRECTDEP DIV
-        FEE INT OTHER PAYMENT POS REPEATPMT SRVCHG XFER
+        FEE INT OTHER PAYMENT POS REPEATPMT SRVCHG XFER IN OUT
       ].each_with_object({}) do |tran_type, hash|
         hash[tran_type] = tran_type.downcase.to_sym
       end
@@ -23,7 +23,7 @@ module OFX
         'INFO' => :info,
         'WARN' => :warn,
         'ERROR' => :error
-      }.freeza
+      }.freeze
 
       attr_reader :headers, :body, :html
 
@@ -52,7 +52,7 @@ module OFX
 
       def self.parse_headers(header_text)
         # Change single CR's to LF's to avoid issues with some banks
-        header_text.gsub!(/\r(?!\n)/, '\n')
+        header_text.gsub!(/\r(?!\n)/, "\n")
 
         # Parse headers. When value is NONE, convert it to nil.
         headers = header_text.to_enum(:each_line).each_with_object({}) do |line, memo|
@@ -134,7 +134,7 @@ module OFX
                                check_number: element.search('checknum').inner_text,
                                ref_number: element.search('refnum').inner_text,
                                posted_at: build_date(element.search('dtposted').inner_text),
-                               occurred_at:,
+                               occurred_at: occurred_at,
                                type: build_type(element),
                                sic: element.search('sic').inner_text
                              })
@@ -164,7 +164,7 @@ module OFX
           offset = '+0000'
         end
 
-        date << ' #{offset}'
+        date << " #{offset}"
 
         Time.parse(date)
       end
@@ -178,9 +178,9 @@ module OFX
         end
 
         OFX::Balance.new({
-                           amount:,
+                           amount: amount,
                            amount_in_pennies: (amount * 100).to_i,
-                           posted_at:
+                           posted_at: posted_at
                          })
       end
 
@@ -189,7 +189,7 @@ module OFX
           amount = to_decimal(node.search('availbal > balamt').inner_text)
 
           OFX::Balance.new({
-                             amount:,
+                             amount: amount,
                              amount_in_pennies: (amount * 100).to_i,
                              posted_at: build_date(node.search('availbal > dtasof').inner_text)
                            })
@@ -198,6 +198,8 @@ module OFX
 
       def to_decimal(amount)
         BigDecimal(amount.to_s.gsub(',', '.'))
+      rescue ArgumentError
+        BigDecimal('0.0')
       end
     end
   end

data/lib/ofx/parser.rb

@@ -17,7 +17,7 @@ module OFX
         end
 
         case headers["VERSION"]
-        when /102/ then
+        when /100|102/ then
           @parser = OFX102.new(:headers => headers, :body => body)
         when /103/ then
           @parser = OFX103.new(:headers => headers, :body => body)

data/lib/ofx/version.rb

@@ -2,7 +2,7 @@ module OFX
   module Version
     MAJOR = 0
     MINOR = 3
-    PATCH = 4
+    PATCH = 6
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/spec/ofx/ofx102_spec.rb

@@ -39,7 +39,7 @@ describe OFX::Parser::OFX102 do
   it "should know about all transaction types" do
     valid_types = [
       'CREDIT', 'DEBIT', 'INT', 'DIV', 'FEE', 'SRVCHG', 'DEP', 'ATM', 'POS', 'XFER',
-      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER'
+      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER', 'IN', 'OUT'
     ]
     valid_types.sort.should == OFX::Parser::OFX102::TRANSACTION_TYPES.keys.sort
 

data/spec/ofx/ofx103_spec.rb

@@ -39,7 +39,7 @@ describe OFX::Parser::OFX103 do
   it "should know about all transaction types" do
     valid_types = [
       'CREDIT', 'DEBIT', 'INT', 'DIV', 'FEE', 'SRVCHG', 'DEP', 'ATM', 'POS', 'XFER',
-      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER'
+      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER', 'IN', 'OUT'
     ]
     valid_types.sort.should == OFX::Parser::OFX103::TRANSACTION_TYPES.keys.sort
 

data/spec/ofx/ofx_parser_spec.rb

@@ -47,8 +47,16 @@ describe OFX::Parser do
     }.should raise_error(OFX::UnsupportedFileError)
   end
 
-  it "should use 211 parser to parse version 200 ofx files" do
-    OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
+  it "uses 102 parser to parse version 100 ofx files" do
+    expect(OFX::Parser::OFX102).to receive(:new).and_return('ofx-102-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_2_example('100'))
+    expect(ofx.parser).to eql 'ofx-102-parser'
+  end
+
+  it "uses 211 parser to parse version 200 ofx files" do
+    expect(OFX::Parser::OFX211).to receive(:new).and_return('ofx-211-parser')
+
     ofx = OFX::Parser::Base.new(ofx_2_example('200'))
     ofx.parser.should == 'ofx-211-parser'
   end
@@ -59,6 +67,13 @@ describe OFX::Parser do
     ofx.parser.should == 'ofx-211-parser'
   end
 
+  it "uses 211 parser to parse version 220 ofx files" do
+    expect(OFX::Parser::OFX211).to receive(:new).and_return('ofx-211-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_2_example('220'))
+    expect(ofx.parser).to eql 'ofx-211-parser'
+  end
+
   describe "headers" do
     it "should have OFXHEADER" do
       @ofx.headers["OFXHEADER"].should == "100"
@@ -101,17 +116,15 @@ describe OFX::Parser do
     end
 
     it "should parse headers with CR and without LF" do
+      header = %{OFXHEADER:100\rDATA:OFXSGML\rVERSION:102\rSECURITY:NONE\rENCODING:USASCII\rCHARSET:1252\rCOMPRESSION:NONE\rOLDFILEUID:NONE\rNEWFILEUID:NONE\r}
+      body   = open("spec/fixtures/sample.ofx").read.split(/<OFX>/, 2)[1]
+      ofx_with_carriage_return = header + "<OFX>" + body
+
       @ofx = OFX::Parser::Base.new(ofx_with_carriage_return)
       @ofx.headers.size.should be(9)
     end
   end
 
-  def ofx_with_carriage_return
-    header = %{OFXHEADER:100\rDATA:OFXSGML\rVERSION:102\rSECURITY:NONE\rENCODING:USASCII\rCHARSET:1252\rCOMPRESSION:NONE\rOLDFILEUID:NONE\rNEWFILEUID:NONE\r}
-    body   = open("spec/fixtures/sample.ofx").read.split(/<OFX>/, 2)[1]
-    header + "<OFX>" + body
-  end
-
   def ofx_2_example(version)
     <<-EndOfx
 <?xml version="1.0" encoding="US-ASCII"?>

data/spec/ofx/transaction_spec.rb

@@ -13,43 +13,43 @@ describe OFX::Transaction do
     end
 
     it "should set amount" do
-      @transaction.amount.should == BigDecimal('-35.34')
+      expect(@transaction.amount).to eql BigDecimal('-35.34')
     end
 
     it "should cast amount to BigDecimal" do
-      @transaction.amount.class.should == BigDecimal
+      expect(@transaction.amount.class).to be BigDecimal
     end
 
     it "should set amount in pennies" do
-      @transaction.amount_in_pennies.should == -3534
+      expect(@transaction.amount_in_pennies).to eql -3534
     end
 
     it "should set fit id" do
-      @transaction.fit_id.should == "200910091"
+      expect(@transaction.fit_id).to eql "200910091"
     end
 
     it "should set memo" do
-      @transaction.memo.should == "COMPRA VISA ELECTRON"
+      expect(@transaction.memo).to eql "COMPRA VISA ELECTRON"
     end
 
     it "should set check number" do
-      @transaction.check_number.should == "0001223"
+      expect(@transaction.check_number).to eql "0001223"
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-09 08:00:00 +0000")
+      expect(@transaction.posted_at).to eql Time.parse("2009-10-09 08:00:00 +0000")
     end
 
     it 'should have user date' do
-      @transaction.occurred_at.should == Time.parse("2009-09-09 08:00:00 +0000")
+      expect(@transaction.occurred_at).to eql Time.parse("2009-09-09 08:00:00 +0000")
     end
 
     it "should have type" do
-      @transaction.type.should == :debit
+      expect(@transaction.type).to eql :debit
     end
 
     it "should have sic" do
-      @transaction.sic.should == '5072'
+      expect(@transaction.sic).to eql '5072'
     end
   end
 
@@ -59,39 +59,39 @@ describe OFX::Transaction do
     end
 
     it "should set amount" do
-      @transaction.amount.should == BigDecimal('60.39')
+      expect(@transaction.amount).to eql BigDecimal('60.39')
     end
 
     it "should set amount in pennies" do
-      @transaction.amount_in_pennies.should == 6039
+      expect(@transaction.amount_in_pennies).to eql 6039
     end
 
     it "should set fit id" do
-      @transaction.fit_id.should == "200910162"
+      expect(@transaction.fit_id).to eql "200910162"
     end
 
     it "should set memo" do
-      @transaction.memo.should == "DEPOSITO POUP.CORRENTE"
+      expect(@transaction.memo).to eql "DEPOSITO POUP.CORRENTE"
     end
 
     it "should set check number" do
-      @transaction.check_number.should == "0880136"
+      expect(@transaction.check_number).to eql "0880136"
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-16 08:00:00 +0000")
+      expect(@transaction.posted_at).to eql Time.parse("2009-10-16 08:00:00 +0000")
     end
 
     it "should have user date" do
-      @transaction.occurred_at.should == Time.parse("2009-09-16 08:00:00 +0000")
+      expect(@transaction.occurred_at).to eql Time.parse("2009-09-16 08:00:00 +0000")
     end
 
     it "should have type" do
-      @transaction.type.should == :credit
+      expect(@transaction.type).to eql :credit
     end
 
     it "should have empty sic" do
-      @transaction.sic.should == ''
+      expect(@transaction.sic).to eql ''
     end
   end
 
@@ -101,27 +101,27 @@ describe OFX::Transaction do
     end
 
     it "should set payee" do
-      @transaction.payee.should == "Pagto conta telefone"
+      expect(@transaction.payee).to eql "Pagto conta telefone"
     end
 
     it "should set check number" do
-      @transaction.check_number.should == "000000101901"
+      expect(@transaction.check_number).to eql "000000101901"
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-19 12:00:00 -0300")
+      expect(@transaction.posted_at).to eql Time.parse("2009-10-19 12:00:00 -0300")
     end
 
     it "should have user date" do
-      @transaction.occurred_at.should == Time.parse("2009-10-17 12:00:00 -0300")
+      expect(@transaction.occurred_at).to eql Time.parse("2009-10-17 12:00:00 -0300")
     end
 
     it "should have type" do
-      @transaction.type.should == :other
+      expect(@transaction.type).to eql :other
     end
 
     it "should have reference number" do
-      @transaction.ref_number.should == "101.901"
+      expect(@transaction.ref_number).to eql "101.901"
     end
   end
 
@@ -131,7 +131,7 @@ describe OFX::Transaction do
     end
 
     it "should set name" do
-      @transaction.name.should == "Pagto conta telefone"
+      expect(@transaction.name).to eql "Pagto conta telefone"
     end
   end
 
@@ -144,22 +144,22 @@ describe OFX::Transaction do
 
     it "should return dep" do
       @transaction = @account.transactions[9]
-      @transaction.type.should == :dep
+      expect(@transaction.type).to eql :dep
     end
 
     it "should return xfer" do
       @transaction = @account.transactions[18]
-      @transaction.type.should == :xfer
+      expect(@transaction.type).to eql :xfer
     end
 
     it "should return cash" do
       @transaction = @account.transactions[45]
-      @transaction.type.should == :cash
+      expect(@transaction.type).to eql :cash
     end
 
     it "should return check" do
       @transaction = @account.transactions[0]
-      @transaction.type.should == :check
+      expect(@transaction.type).to eql :check
     end
   end
 
@@ -176,11 +176,11 @@ describe OFX::Transaction do
       end
 
       it "should set amount" do
-        @transaction.amount.should == BigDecimal('-11.76')
+        expect(@transaction.amount).to eql BigDecimal('-11.76')
       end
 
       it "should set amount in pennies" do
-        @transaction.amount_in_pennies.should == -1176
+        expect(@transaction.amount_in_pennies).to eql -1176
       end
     end
 
@@ -190,12 +190,31 @@ describe OFX::Transaction do
       end
 
       it "should set amount" do
-        @transaction.amount.should == BigDecimal('47.01')
+        expect(@transaction.amount).to eql BigDecimal('47.01')
       end
 
       it "should set amount in pennies" do
-        @transaction.amount_in_pennies.should == 4701
+        expect(@transaction.amount_in_pennies).to eql 4701
       end
     end
   end
+
+  context "invalid decimal values" do
+    before do
+      @ofx = OFX::Parser::Base.new("spec/fixtures/cef_malformed_decimal.ofx")
+      @parser = @ofx.parser
+    end
+
+    it "should not raise error" do
+      expect { @parser.account.transactions }.to_not raise_error
+    end
+
+    it "should return zero in amount" do
+      expect(@parser.account.transactions[0].amount).to eql BigDecimal('0.0')
+    end
+
+    it "should return zero in amount_in_pennies" do
+      expect(@parser.account.transactions[0].amount_in_pennies).to eql 0
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require "ofx"
+require "byebug"
 
 RSpec::Matchers.define :have_key do |key|
   match do |hash|
@@ -7,3 +8,7 @@ RSpec::Matchers.define :have_key do |key|
     hash.keys.include?(key)
   end
 end
+
+RSpec.configure do |c|
+  c.filter_run_when_matching :focus
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ofx
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.6
 platform: ruby
 authors:
 - Nando Vieira
@@ -9,22 +9,28 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-22 00:00:00.000000000 Z
+date: 2025-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.13.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.16.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.13.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.16.0
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement