ofx 0.3.2 → 0.3.4

data/spec/ofx/ofx103_spec.rb

@@ -0,0 +1,50 @@
+require "spec_helper"
+
+describe OFX::Parser::OFX103 do
+  before do
+    @ofx = OFX::Parser::Base.new("spec/fixtures/v103.ofx")
+    @parser = @ofx.parser
+  end
+
+  it "should have a version" do
+    OFX::Parser::OFX103::VERSION.should == "1.0.3"
+  end
+
+  it "should set headers" do
+    @parser.headers.should == @ofx.headers
+  end
+
+  it "should trim trailing whitespace from headers" do
+    headers = OFX::Parser::OFX103.parse_headers("VERSION:103   ")
+    headers["VERSION"].should == "103"
+  end
+
+  it "should set body" do
+    @parser.body.should == @ofx.body
+  end
+
+  it "should set account" do
+    @parser.account.should be_a_kind_of(OFX::Account)
+  end
+
+  it "should set account" do
+    @parser.sign_on.should be_a_kind_of(OFX::SignOn)
+  end
+
+  it "should set statements" do
+    @parser.statements.size.should == 1
+    @parser.statements.first.should be_a_kind_of(OFX::Statement)
+  end
+
+  it "should know about all transaction types" do
+    valid_types = [
+      'CREDIT', 'DEBIT', 'INT', 'DIV', 'FEE', 'SRVCHG', 'DEP', 'ATM', 'POS', 'XFER',
+      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER'
+    ]
+    valid_types.sort.should == OFX::Parser::OFX103::TRANSACTION_TYPES.keys.sort
+
+    valid_types.each do |transaction_type|
+      transaction_type.downcase.to_sym.should equal OFX::Parser::OFX103::TRANSACTION_TYPES[transaction_type]
+    end
+  end
+end

data/spec/ofx/ofx211_spec.rb

@@ -5,19 +5,19 @@ describe OFX::Parser::OFX211 do
     @ofx = OFX::Parser::Base.new("spec/fixtures/v211.ofx")
     @parser = @ofx.parser
   end
-  
+
   it "should have a version" do
     OFX::Parser::OFX211::VERSION.should == "2.1.1"
   end
-  
+
   it "should set headers" do
     @parser.headers.should == @ofx.headers
   end
-  
+
   it "should set body" do
     @parser.body.should == @ofx.body
   end
-  
+
   it "should set account" do
     @parser.account.should be_a_kind_of(OFX::Account)
   end
@@ -26,51 +26,56 @@ describe OFX::Parser::OFX211 do
     @parser.sign_on.should be_a_kind_of(OFX::SignOn)
   end
 
-  context "transactions" do
-    before do
-      @transactions = @parser.account.transactions
-    end
+  it "should set accounts" do
+    @parser.accounts.size.should == 2
+  end
 
+  it "should set statements" do
+    @parser.statements.size.should == 2
+    @parser.statements.first.should be_a_kind_of(OFX::Statement)
+  end
+
+  context "transactions" do
     # Test file contains only three transactions. Let's just check
     # them all.
     context "first" do
       before do
-        @t = @transactions[0]
+        @t = @parser.accounts[0].transactions[0]
       end
 
       it "should contain the correct values" do
-        @t.amount.should == -80
+        @t.amount.should == BigDecimal('-80')
         @t.fit_id.should == "219378"
         @t.memo.should be_empty
-        @t.posted_at.should == Time.parse("2005-08-24 08:00:00")
+        @t.posted_at.should == Time.parse("2005-08-24 08:00:00 +0000")
         @t.name.should == "FrogKick Scuba Gear"
       end
     end
 
     context "second" do
       before do
-        @t = @transactions[1]
+        @t = @parser.accounts[1].transactions[0]
       end
-      
+
       it "should contain the correct values" do
-        @t.amount.should == -23
+        @t.amount.should == BigDecimal('-23')
         @t.fit_id.should == "219867"
         @t.memo.should be_empty
-        @t.posted_at.should == Time.parse("2005-08-11 08:00:00")
+        @t.posted_at.should == Time.parse("2005-08-11 08:00:00 +0000")
         @t.name.should == "Interest Charge"
       end
     end
-    
+
     context "third" do
       before do
-        @t = @transactions[2]
+        @t = @parser.accounts[1].transactions[1]
       end
-      
+
       it "should contain the correct values" do
-        @t.amount.should == 350
+        @t.amount.should == BigDecimal('350')
         @t.fit_id.should == "219868"
         @t.memo.should be_empty
-        @t.posted_at.should == Time.parse("2005-08-11 08:00:00")
+        @t.posted_at.should == Time.parse("2005-08-11 08:00:00 +0000")
         @t.name.should == "Payment - Thank You"
       end
     end

data/spec/ofx/ofx_parser_spec.rb

@@ -47,6 +47,18 @@ describe OFX::Parser do
     }.should raise_error(OFX::UnsupportedFileError)
   end
 
+  it "should use 211 parser to parse version 200 ofx files" do
+    OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
+    ofx = OFX::Parser::Base.new(ofx_2_example('200'))
+    ofx.parser.should == 'ofx-211-parser'
+  end
+
+  it "should use 211 parser to parse version 202 ofx files" do
+    OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
+    ofx = OFX::Parser::Base.new(ofx_2_example('202'))
+    ofx.parser.should == 'ofx-211-parser'
+  end
+
   describe "headers" do
     it "should have OFXHEADER" do
       @ofx.headers["OFXHEADER"].should == "100"
@@ -87,16 +99,25 @@ describe OFX::Parser do
       @ofx.headers.should have_key("NEWFILEUID")
       @ofx.headers["NEWFILEUID"].should be_nil
     end
-    
+
     it "should parse headers with CR and without LF" do
       @ofx = OFX::Parser::Base.new(ofx_with_carriage_return)
       @ofx.headers.size.should be(9)
     end
   end
-  
+
   def ofx_with_carriage_return
     header = %{OFXHEADER:100\rDATA:OFXSGML\rVERSION:102\rSECURITY:NONE\rENCODING:USASCII\rCHARSET:1252\rCOMPRESSION:NONE\rOLDFILEUID:NONE\rNEWFILEUID:NONE\r}
     body   = open("spec/fixtures/sample.ofx").read.split(/<OFX>/, 2)[1]
     header + "<OFX>" + body
   end
-end
+
+  def ofx_2_example(version)
+    <<-EndOfx
+<?xml version="1.0" encoding="US-ASCII"?>
+<?OFX OFXHEADER="200" VERSION="#{version}" SECURITY="NONE" OLDFILEUID="NONE" NEWFILEUID="NONE"?>"
+<OFX>
+</OFX>
+    EndOfx
+  end
+end

data/spec/ofx/sign_on_spec.rb

@@ -19,5 +19,9 @@ describe OFX::SignOn do
     it "should return Financial Institution Name" do
       @sign_on.fi_name.should == "Citigroup"
     end
+
+    it "should return status" do
+      @sign_on.status.should be_a(OFX::Status)
+    end
   end
 end

data/spec/ofx/statement_spec.rb

@@ -0,0 +1,131 @@
+require "spec_helper"
+
+describe OFX::Statement do
+  let(:parser) { ofx.parser }
+  let(:statement) { parser.statements.first }
+
+  context "Bank Account" do
+    let(:ofx) { OFX::Parser::Base.new("spec/fixtures/sample.ofx") }
+
+    it "returns currency" do
+      statement.currency.should == "BRL"
+    end
+
+    it "returns start date" do
+      statement.start_date.should == Time.parse("2009-10-09 08:00:00 +0000")
+    end
+
+    it "returns end date" do
+      statement.end_date.should == Time.parse("2009-11-03 08:00:00 +0000")
+    end
+
+    it "returns account" do
+      statement.account.should be_a(OFX::Account)
+      statement.account.id.should == '03227113109'
+      statement.account.type.should == :checking
+    end
+
+    it "returns transactions" do
+      statement.transactions.should be_a(Array)
+      statement.transactions.size.should == 36
+    end
+
+    describe "balance" do
+      let(:balance) { statement.balance }
+
+      it "returns balance" do
+        balance.amount.should == BigDecimal('598.44')
+      end
+
+      it "returns balance in pennies" do
+        balance.amount_in_pennies.should == 59844
+      end
+
+      it "returns balance date" do
+        balance.posted_at.should == Time.parse("2009-11-01 00:00:00 +0000")
+      end
+    end
+
+    describe "available_balance" do
+      let(:available_balance) { statement.available_balance }
+
+      it "returns available balance" do
+        available_balance.amount.should == BigDecimal('1555.99')
+      end
+
+      it "returns available balance in pennies" do
+        available_balance.amount_in_pennies.should == 155599
+      end
+
+      it "returns available balance date" do
+        available_balance.posted_at.should == Time.parse("2009-11-01 00:00:00 +0000")
+      end
+
+      context "when AVAILBAL not found" do
+        let(:ofx) { OFX::Parser::Base.new("spec/fixtures/utf8.ofx") }
+
+        it "returns nil " do
+          available_balance.should be_nil
+        end
+      end
+    end
+  end
+
+  context "Credit Card" do
+    let(:ofx) { OFX::Parser::Base.new("spec/fixtures/creditcard.ofx") }
+
+    it "returns currency" do
+      statement.currency.should == "USD"
+    end
+
+    it "returns start date" do
+      statement.start_date.should == Time.parse("2007-05-09 12:00:00 +0000")
+    end
+
+    it "returns end date" do
+      statement.end_date.should == Time.parse("2007-06-08 12:00:00 +0000")
+    end
+
+    it "returns account" do
+      statement.account.should be_a(OFX::Account)
+      statement.account.id.should == 'XXXXXXXXXXXX1111'
+    end
+
+    it "returns transactions" do
+      statement.transactions.should be_a(Array)
+      statement.transactions.size.should == 3
+    end
+
+    describe "balance" do
+      let(:balance) { statement.balance }
+
+      it "returns balance" do
+        balance.amount.should == BigDecimal('-1111.01')
+      end
+
+      it "returns balance in pennies" do
+        balance.amount_in_pennies.should == -111101
+      end
+
+      it "returns balance date" do
+        balance.posted_at.should == Time.parse("2007-06-23 19:20:13 +0000")
+      end
+    end
+
+    describe "available_balance" do
+      let(:available_balance) { statement.available_balance }
+
+      it "returns available balance" do
+        available_balance.amount.should == BigDecimal('19000.99')
+      end
+
+      it "returns available balance in pennies" do
+        available_balance.amount_in_pennies.should == 1900099
+      end
+
+      it "returns available balance date" do
+        available_balance.posted_at.should == Time.parse("2007-06-23 19:20:13 +0000")
+      end
+    end
+  end
+end

data/spec/ofx/status_spec.rb

@@ -0,0 +1,47 @@
+require "spec_helper"
+
+describe OFX::Status do
+  let(:ofx) { OFX::Parser::Base.new(ofx_file) }
+  let(:parser) { ofx.parser }
+  let(:status) { parser.sign_on.status }
+
+  context "success" do
+    let(:ofx_file) { "spec/fixtures/creditcard.ofx" }
+
+    it "should return code" do
+      status.code.should == 0
+    end
+
+    it "should return severity" do
+      status.severity.should == :info
+    end
+
+    it "should return message" do
+      status.message.should == ""
+    end
+
+    it "should be successful" do
+      status.success?.should == true
+    end
+  end
+
+  context "error" do
+    let(:ofx_file) { "spec/fixtures/error.ofx" }
+
+    it "should return code" do
+      status.code.should == 2000
+    end
+
+    it "should return severity" do
+      status.severity.should == :error
+    end
+
+    it "should return message" do
+      status.message.should == "We were unable to process your request. Please try again later."
+    end
+
+    it "should not be successful" do
+      status.success?.should == false
+    end
+  end
+end

data/spec/ofx/transaction_spec.rb

@@ -13,7 +13,7 @@ describe OFX::Transaction do
     end
 
     it "should set amount" do
-      @transaction.amount.should == -35.34
+      @transaction.amount.should == BigDecimal('-35.34')
     end
 
     it "should cast amount to BigDecimal" do
@@ -37,7 +37,11 @@ describe OFX::Transaction do
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-09 08:00:00")
+      @transaction.posted_at.should == Time.parse("2009-10-09 08:00:00 +0000")
+    end
+
+    it 'should have user date' do
+      @transaction.occurred_at.should == Time.parse("2009-09-09 08:00:00 +0000")
     end
 
     it "should have type" do
@@ -55,7 +59,7 @@ describe OFX::Transaction do
     end
 
     it "should set amount" do
-      @transaction.amount.should == 60.39
+      @transaction.amount.should == BigDecimal('60.39')
     end
 
     it "should set amount in pennies" do
@@ -75,13 +79,17 @@ describe OFX::Transaction do
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-16 08:00:00")
+      @transaction.posted_at.should == Time.parse("2009-10-16 08:00:00 +0000")
+    end
+
+    it "should have user date" do
+      @transaction.occurred_at.should == Time.parse("2009-09-16 08:00:00 +0000")
     end
 
     it "should have type" do
       @transaction.type.should == :credit
     end
-    
+
     it "should have empty sic" do
       @transaction.sic.should == ''
     end
@@ -101,7 +109,11 @@ describe OFX::Transaction do
     end
 
     it "should have date" do
-      @transaction.posted_at.should == Time.parse("2009-10-19 12:00:00")
+      @transaction.posted_at.should == Time.parse("2009-10-19 12:00:00 -0300")
+    end
+
+    it "should have user date" do
+      @transaction.occurred_at.should == Time.parse("2009-10-17 12:00:00 -0300")
     end
 
     it "should have type" do
@@ -124,7 +136,6 @@ describe OFX::Transaction do
   end
 
   context "with other types" do
-
     before do
       @ofx = OFX::Parser::Base.new("spec/fixtures/bb.ofx")
       @parser = @ofx.parser
@@ -151,4 +162,40 @@ describe OFX::Transaction do
       @transaction.type.should == :check
     end
   end
+
+  context "decimal values using a comma" do
+    before do
+      @ofx = OFX::Parser::Base.new("spec/fixtures/santander.ofx")
+      @parser = @ofx.parser
+      @account = @parser.account
+    end
+
+    context "debit" do
+      before do
+        @transaction = @account.transactions[0]
+      end
+
+      it "should set amount" do
+        @transaction.amount.should == BigDecimal('-11.76')
+      end
+
+      it "should set amount in pennies" do
+        @transaction.amount_in_pennies.should == -1176
+      end
+    end
+
+    context "credit" do
+      before do
+        @transaction = @account.transactions[3]
+      end
+
+      it "should set amount" do
+        @transaction.amount.should == BigDecimal('47.01')
+      end
+
+      it "should set amount in pennies" do
+        @transaction.amount_in_pennies.should == 4701
+      end
+    end
+  end
 end

metadata

@@ -1,93 +1,79 @@
 --- !ruby/object:Gem::Specification
 name: ofx
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.4
 platform: ruby
 authors:
 - Nando Vieira
 - Anna Cruz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2013-08-24 00:00:00.000000000 Z
+date: 2022-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.13.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.13.1
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: 11.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: 11.1.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.0.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.0.6
 - !ruby/object:Gem::Dependency
-  name: pry-debugger
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.10'
 description: |
   A simple OFX (Open Financial Exchange) parser built on top of Nokogiri.
   Currently supports OFX 102, 200 and 211.
 
   Usage:
 
-    OFX("sample.ofx") do |ofx|
+    OFX('sample.ofx') do |ofx|
       p ofx
     end
 email:
@@ -97,10 +83,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- Gemfile
-- Gemfile.lock
 - README.rdoc
 - Rakefile
 - lib/ofx.rb
@@ -110,63 +92,46 @@ files:
 - lib/ofx/foundation.rb
 - lib/ofx/parser.rb
 - lib/ofx/parser/ofx102.rb
+- lib/ofx/parser/ofx103.rb
 - lib/ofx/parser/ofx211.rb
 - lib/ofx/sign_on.rb
+- lib/ofx/statement.rb
+- lib/ofx/status.rb
 - lib/ofx/transaction.rb
 - lib/ofx/version.rb
-- ofx.gemspec
-- spec/fixtures/avatar.gif
-- spec/fixtures/bb.ofx
-- spec/fixtures/creditcard.ofx
-- spec/fixtures/invalid_version.ofx
-- spec/fixtures/sample.ofx
-- spec/fixtures/utf8.ofx
-- spec/fixtures/v211.ofx
 - spec/ofx/account_spec.rb
 - spec/ofx/ofx102_spec.rb
+- spec/ofx/ofx103_spec.rb
 - spec/ofx/ofx211_spec.rb
 - spec/ofx/ofx_parser_spec.rb
 - spec/ofx/ofx_spec.rb
 - spec/ofx/sign_on_spec.rb
+- spec/ofx/statement_spec.rb
+- spec/ofx/status_spec.rb
 - spec/ofx/transaction_spec.rb
 - spec/spec_helper.rb
 homepage: http://rubygems.org/gems/ofx
-licenses: []
+licenses:
+- MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.0.3
-signing_key: 
+rubygems_version: 3.3.3
+signing_key:
 specification_version: 4
 summary: A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently
   supports OFX 102, 200 and 211.
-test_files:
-- spec/fixtures/avatar.gif
-- spec/fixtures/bb.ofx
-- spec/fixtures/creditcard.ofx
-- spec/fixtures/invalid_version.ofx
-- spec/fixtures/sample.ofx
-- spec/fixtures/utf8.ofx
-- spec/fixtures/v211.ofx
-- spec/ofx/account_spec.rb
-- spec/ofx/ofx102_spec.rb
-- spec/ofx/ofx211_spec.rb
-- spec/ofx/ofx_parser_spec.rb
-- spec/ofx/ofx_spec.rb
-- spec/ofx/sign_on_spec.rb
-- spec/ofx/transaction_spec.rb
-- spec/spec_helper.rb
+test_files: []