ofx 0.2.9 → 0.3.4

data/spec/ofx/account_spec.rb

@@ -11,34 +11,121 @@ describe OFX::Account do
     it "should return currency" do
       @account.currency.should == "BRL"
     end
-    
+
     it "should return bank id" do
       @account.bank_id.should == "0356"
     end
-    
+
     it "should return id" do
       @account.id.should == "03227113109"
     end
-    
+
     it "should return type" do
       @account.type.should == :checking
     end
-    
+
     it "should return transactions" do
       @account.transactions.should be_a_kind_of(Array)
       @account.transactions.size.should == 36
     end
-    
+
     it "should return balance" do
-      @account.balance.amount.should == 598.44
+      @account.balance.amount.should == BigDecimal('598.44')
     end
-    
+
     it "should return balance in pennies" do
       @account.balance.amount_in_pennies.should == 59844
     end
-    
+
     it "should return balance date" do
-      @account.balance.posted_at.should == Time.parse("2009-11-01")
+      @account.balance.posted_at.should == Time.gm(2009,11,1)
+    end
+
+    context "available_balance" do
+      it "should return available balance" do
+        @account.available_balance.amount.should == BigDecimal('1555.99')
+      end
+
+      it "should return available balance in pennies" do
+        @account.available_balance.amount_in_pennies.should == 155599
+      end
+
+      it "should return available balance date" do
+        @account.available_balance.posted_at.should == Time.gm(2009,11,1)
+      end
+
+      it "should return nil if AVAILBAL not found" do
+        @ofx = OFX::Parser::Base.new("spec/fixtures/utf8.ofx")
+        @parser = @ofx.parser
+        @account = @parser.account
+        @account.available_balance.should be_nil
+      end
+    end
+
+    context "Credit Card" do
+      before do
+        @ofx = OFX::Parser::Base.new("spec/fixtures/creditcard.ofx")
+        @parser = @ofx.parser
+        @account = @parser.account
+      end
+
+      it "should return id" do
+        @account.id.should == "XXXXXXXXXXXX1111"
+      end
+
+      it "should return currency" do
+        @account.currency.should == "USD"
+      end
+    end
+    context "With Issue" do # Bradesco do not provide a valid date in balance
+      before do
+        @ofx = OFX::Parser::Base.new("spec/fixtures/dtsof_balance_issue.ofx")
+        @parser = @ofx.parser
+        @account = @parser.account
+      end
+
+      it "should return nil for date balance" do
+        @account.balance.posted_at.should be_nil
+      end
+    end
+
+    context "Invalid Dates" do
+      before do
+        @ofx = OFX::Parser::Base.new("spec/fixtures/bradesco.ofx")
+        @parser = @ofx.parser
+      end
+      it "should not raise error when balance has date zero" do
+        expect { @parser.account.balance }.to_not raise_error
+      end
+      it "should return NIL in balance.posted_at when balance date is zero" do
+        @parser.account.balance.posted_at.should be_nil
+     end
+    end
+
+    context "decimal values using a comma" do
+      before do
+        @ofx = OFX::Parser::Base.new("spec/fixtures/santander.ofx")
+        @parser = @ofx.parser
+        @account = @parser.account
+      end
+
+      it "should return balance" do
+        @account.balance.amount.should == BigDecimal('348.29')
+      end
+
+      it "should return balance in pennies" do
+        @account.balance.amount_in_pennies.should == 34829
+      end
+
+      context "available_balance" do
+        it "should return available balance" do
+          @account.available_balance.amount.should == BigDecimal('2415.87')
+        end
+
+        it "should return available balance in pennies" do
+          @account.available_balance.amount_in_pennies.should == 241587
+        end
+      end
     end
   end
 end

data/spec/ofx/ofx102_spec.rb

@@ -5,20 +5,63 @@ describe OFX::Parser::OFX102 do
     @ofx = OFX::Parser::Base.new("spec/fixtures/sample.ofx")
     @parser = @ofx.parser
   end
-  
+
   it "should have a version" do
     OFX::Parser::OFX102::VERSION.should == "1.0.2"
   end
-  
+
   it "should set headers" do
     @parser.headers.should == @ofx.headers
   end
-  
+
+  it "should trim trailing whitespace from headers" do
+    headers = OFX::Parser::OFX102.parse_headers("VERSION:102   ")
+    headers["VERSION"].should == "102"
+  end
+
   it "should set body" do
     @parser.body.should == @ofx.body
   end
-  
+
   it "should set account" do
     @parser.account.should be_a_kind_of(OFX::Account)
   end
-end
+
+  it "should set account" do
+    @parser.sign_on.should be_a_kind_of(OFX::SignOn)
+  end
+
+  it "should set statements" do
+    @parser.statements.size.should == 1
+    @parser.statements.first.should be_a_kind_of(OFX::Statement)
+  end
+  
+  it "should know about all transaction types" do
+    valid_types = [
+      'CREDIT', 'DEBIT', 'INT', 'DIV', 'FEE', 'SRVCHG', 'DEP', 'ATM', 'POS', 'XFER',
+      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER'
+    ]
+    valid_types.sort.should == OFX::Parser::OFX102::TRANSACTION_TYPES.keys.sort
+
+    valid_types.each do |transaction_type|
+      transaction_type.downcase.to_sym.should equal OFX::Parser::OFX102::TRANSACTION_TYPES[transaction_type]
+    end
+  end
+
+  describe "#build_date" do
+    context "without a Time Zone" do
+      it "should default to GMT" do
+        @parser.send(:build_date, "20170904").should == Time.gm(2017, 9, 4)
+        @parser.send(:build_date, "20170904082855").should == Time.gm(2017, 9, 4, 8, 28, 55)
+      end
+    end
+
+    context "with a Time Zone" do
+      it "should returns the correct date" do
+        @parser.send(:build_date, "20150507164333[-0300:BRT]").should == Time.new(2015, 5, 7, 16, 43, 33, "-03:00")
+        @parser.send(:build_date, "20180507120000[0:GMT]").should == Time.gm(2018, 5, 7, 12)
+        @parser.send(:build_date, "20170904082855[-3:GMT]").should == Time.new(2017, 9, 4, 8, 28, 55, "-03:00")
+      end
+    end
+  end
+end

data/spec/ofx/ofx103_spec.rb

@@ -0,0 +1,50 @@
+require "spec_helper"
+
+describe OFX::Parser::OFX103 do
+  before do
+    @ofx = OFX::Parser::Base.new("spec/fixtures/v103.ofx")
+    @parser = @ofx.parser
+  end
+
+  it "should have a version" do
+    OFX::Parser::OFX103::VERSION.should == "1.0.3"
+  end
+
+  it "should set headers" do
+    @parser.headers.should == @ofx.headers
+  end
+
+  it "should trim trailing whitespace from headers" do
+    headers = OFX::Parser::OFX103.parse_headers("VERSION:103   ")
+    headers["VERSION"].should == "103"
+  end
+
+  it "should set body" do
+    @parser.body.should == @ofx.body
+  end
+
+  it "should set account" do
+    @parser.account.should be_a_kind_of(OFX::Account)
+  end
+
+  it "should set account" do
+    @parser.sign_on.should be_a_kind_of(OFX::SignOn)
+  end
+
+  it "should set statements" do
+    @parser.statements.size.should == 1
+    @parser.statements.first.should be_a_kind_of(OFX::Statement)
+  end
+
+  it "should know about all transaction types" do
+    valid_types = [
+      'CREDIT', 'DEBIT', 'INT', 'DIV', 'FEE', 'SRVCHG', 'DEP', 'ATM', 'POS', 'XFER',
+      'CHECK', 'PAYMENT', 'CASH', 'DIRECTDEP', 'DIRECTDEBIT', 'REPEATPMT', 'OTHER'
+    ]
+    valid_types.sort.should == OFX::Parser::OFX103::TRANSACTION_TYPES.keys.sort
+
+    valid_types.each do |transaction_type|
+      transaction_type.downcase.to_sym.should equal OFX::Parser::OFX103::TRANSACTION_TYPES[transaction_type]
+    end
+  end
+end

data/spec/ofx/ofx211_spec.rb

@@ -0,0 +1,84 @@
+require "spec_helper"
+
+describe OFX::Parser::OFX211 do
+  before do
+    @ofx = OFX::Parser::Base.new("spec/fixtures/v211.ofx")
+    @parser = @ofx.parser
+  end
+
+  it "should have a version" do
+    OFX::Parser::OFX211::VERSION.should == "2.1.1"
+  end
+
+  it "should set headers" do
+    @parser.headers.should == @ofx.headers
+  end
+
+  it "should set body" do
+    @parser.body.should == @ofx.body
+  end
+
+  it "should set account" do
+    @parser.account.should be_a_kind_of(OFX::Account)
+  end
+
+  it "should set account" do
+    @parser.sign_on.should be_a_kind_of(OFX::SignOn)
+  end
+
+  it "should set accounts" do
+    @parser.accounts.size.should == 2
+  end
+
+  it "should set statements" do
+    @parser.statements.size.should == 2
+    @parser.statements.first.should be_a_kind_of(OFX::Statement)
+  end
+
+  context "transactions" do
+    # Test file contains only three transactions. Let's just check
+    # them all.
+    context "first" do
+      before do
+        @t = @parser.accounts[0].transactions[0]
+      end
+
+      it "should contain the correct values" do
+        @t.amount.should == BigDecimal('-80')
+        @t.fit_id.should == "219378"
+        @t.memo.should be_empty
+        @t.posted_at.should == Time.parse("2005-08-24 08:00:00 +0000")
+        @t.name.should == "FrogKick Scuba Gear"
+      end
+    end
+
+    context "second" do
+      before do
+        @t = @parser.accounts[1].transactions[0]
+      end
+
+      it "should contain the correct values" do
+        @t.amount.should == BigDecimal('-23')
+        @t.fit_id.should == "219867"
+        @t.memo.should be_empty
+        @t.posted_at.should == Time.parse("2005-08-11 08:00:00 +0000")
+        @t.name.should == "Interest Charge"
+      end
+    end
+
+    context "third" do
+      before do
+        @t = @parser.accounts[1].transactions[1]
+      end
+
+      it "should contain the correct values" do
+        @t.amount.should == BigDecimal('350')
+        @t.fit_id.should == "219868"
+        @t.memo.should be_empty
+        @t.posted_at.should == Time.parse("2005-08-11 08:00:00 +0000")
+        @t.name.should == "Payment - Thank You"
+      end
+    end
+  end
+end
+

data/spec/ofx/ofx_parser_spec.rb

@@ -47,6 +47,18 @@ describe OFX::Parser do
     }.should raise_error(OFX::UnsupportedFileError)
   end
 
+  it "should use 211 parser to parse version 200 ofx files" do
+    OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
+    ofx = OFX::Parser::Base.new(ofx_2_example('200'))
+    ofx.parser.should == 'ofx-211-parser'
+  end
+
+  it "should use 211 parser to parse version 202 ofx files" do
+    OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
+    ofx = OFX::Parser::Base.new(ofx_2_example('202'))
+    ofx.parser.should == 'ofx-211-parser'
+  end
+
   describe "headers" do
     it "should have OFXHEADER" do
       @ofx.headers["OFXHEADER"].should == "100"
@@ -87,16 +99,25 @@ describe OFX::Parser do
       @ofx.headers.should have_key("NEWFILEUID")
       @ofx.headers["NEWFILEUID"].should be_nil
     end
-    
+
     it "should parse headers with CR and without LF" do
       @ofx = OFX::Parser::Base.new(ofx_with_carriage_return)
       @ofx.headers.size.should be(9)
     end
   end
-  
+
   def ofx_with_carriage_return
     header = %{OFXHEADER:100\rDATA:OFXSGML\rVERSION:102\rSECURITY:NONE\rENCODING:USASCII\rCHARSET:1252\rCOMPRESSION:NONE\rOLDFILEUID:NONE\rNEWFILEUID:NONE\r}
     body   = open("spec/fixtures/sample.ofx").read.split(/<OFX>/, 2)[1]
     header + "<OFX>" + body
   end
-end
+
+  def ofx_2_example(version)
+    <<-EndOfx
+<?xml version="1.0" encoding="US-ASCII"?>
+<?OFX OFXHEADER="200" VERSION="#{version}" SECURITY="NONE" OLDFILEUID="NONE" NEWFILEUID="NONE"?>"
+<OFX>
+</OFX>
+    EndOfx
+  end
+end

data/spec/ofx/sign_on_spec.rb

@@ -0,0 +1,27 @@
+require "spec_helper"
+
+describe OFX::SignOn do
+  before do
+    @ofx = OFX::Parser::Base.new("spec/fixtures/creditcard.ofx")
+    @parser = @ofx.parser
+    @sign_on = @parser.sign_on
+  end
+
+  describe "sign_on" do
+    it "should return language" do
+      @sign_on.language.should == "ENG"
+    end
+
+    it "should return Financial Institution ID" do
+      @sign_on.fi_id.should == "24909"
+    end
+
+    it "should return Financial Institution Name" do
+      @sign_on.fi_name.should == "Citigroup"
+    end
+
+    it "should return status" do
+      @sign_on.status.should be_a(OFX::Status)
+    end
+  end
+end

data/spec/ofx/statement_spec.rb

@@ -0,0 +1,131 @@
+require "spec_helper"
+
+describe OFX::Statement do
+  let(:parser) { ofx.parser }
+  let(:statement) { parser.statements.first }
+
+  context "Bank Account" do
+    let(:ofx) { OFX::Parser::Base.new("spec/fixtures/sample.ofx") }
+
+    it "returns currency" do
+      statement.currency.should == "BRL"
+    end
+
+    it "returns start date" do
+      statement.start_date.should == Time.parse("2009-10-09 08:00:00 +0000")
+    end
+
+    it "returns end date" do
+      statement.end_date.should == Time.parse("2009-11-03 08:00:00 +0000")
+    end
+
+    it "returns account" do
+      statement.account.should be_a(OFX::Account)
+      statement.account.id.should == '03227113109'
+      statement.account.type.should == :checking
+    end
+
+    it "returns transactions" do
+      statement.transactions.should be_a(Array)
+      statement.transactions.size.should == 36
+    end
+
+    describe "balance" do
+      let(:balance) { statement.balance }
+
+      it "returns balance" do
+        balance.amount.should == BigDecimal('598.44')
+      end
+
+      it "returns balance in pennies" do
+        balance.amount_in_pennies.should == 59844
+      end
+
+      it "returns balance date" do
+        balance.posted_at.should == Time.parse("2009-11-01 00:00:00 +0000")
+      end
+    end
+
+    describe "available_balance" do
+      let(:available_balance) { statement.available_balance }
+
+      it "returns available balance" do
+        available_balance.amount.should == BigDecimal('1555.99')
+      end
+
+      it "returns available balance in pennies" do
+        available_balance.amount_in_pennies.should == 155599
+      end
+
+      it "returns available balance date" do
+        available_balance.posted_at.should == Time.parse("2009-11-01 00:00:00 +0000")
+      end
+
+      context "when AVAILBAL not found" do
+        let(:ofx) { OFX::Parser::Base.new("spec/fixtures/utf8.ofx") }
+
+        it "returns nil " do
+          available_balance.should be_nil
+        end
+      end
+    end
+  end
+
+  context "Credit Card" do
+    let(:ofx) { OFX::Parser::Base.new("spec/fixtures/creditcard.ofx") }
+
+    it "returns currency" do
+      statement.currency.should == "USD"
+    end
+
+    it "returns start date" do
+      statement.start_date.should == Time.parse("2007-05-09 12:00:00 +0000")
+    end
+
+    it "returns end date" do
+      statement.end_date.should == Time.parse("2007-06-08 12:00:00 +0000")
+    end
+
+    it "returns account" do
+      statement.account.should be_a(OFX::Account)
+      statement.account.id.should == 'XXXXXXXXXXXX1111'
+    end
+
+    it "returns transactions" do
+      statement.transactions.should be_a(Array)
+      statement.transactions.size.should == 3
+    end
+
+    describe "balance" do
+      let(:balance) { statement.balance }
+
+      it "returns balance" do
+        balance.amount.should == BigDecimal('-1111.01')
+      end
+
+      it "returns balance in pennies" do
+        balance.amount_in_pennies.should == -111101
+      end
+
+      it "returns balance date" do
+        balance.posted_at.should == Time.parse("2007-06-23 19:20:13 +0000")
+      end
+    end
+
+    describe "available_balance" do
+      let(:available_balance) { statement.available_balance }
+
+      it "returns available balance" do
+        available_balance.amount.should == BigDecimal('19000.99')
+      end
+
+      it "returns available balance in pennies" do
+        available_balance.amount_in_pennies.should == 1900099
+      end
+
+      it "returns available balance date" do
+        available_balance.posted_at.should == Time.parse("2007-06-23 19:20:13 +0000")
+      end
+    end
+  end
+end

data/spec/ofx/status_spec.rb

@@ -0,0 +1,47 @@
+require "spec_helper"
+
+describe OFX::Status do
+  let(:ofx) { OFX::Parser::Base.new(ofx_file) }
+  let(:parser) { ofx.parser }
+  let(:status) { parser.sign_on.status }
+
+  context "success" do
+    let(:ofx_file) { "spec/fixtures/creditcard.ofx" }
+
+    it "should return code" do
+      status.code.should == 0
+    end
+
+    it "should return severity" do
+      status.severity.should == :info
+    end
+
+    it "should return message" do
+      status.message.should == ""
+    end
+
+    it "should be successful" do
+      status.success?.should == true
+    end
+  end
+
+  context "error" do
+    let(:ofx_file) { "spec/fixtures/error.ofx" }
+
+    it "should return code" do
+      status.code.should == 2000
+    end
+
+    it "should return severity" do
+      status.severity.should == :error
+    end
+
+    it "should return message" do
+      status.message.should == "We were unable to process your request. Please try again later."
+    end
+
+    it "should not be successful" do
+      status.success?.should == false
+    end
+  end
+end