offsite_payments 2.7.3 → 2.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c6868f90410159ecc5ee57256207f32210f8be2a
-  data.tar.gz: 238cc3e1db58f69bb44c6236fd5b9feb5d8bc692
+  metadata.gz: fca5c3503aa8268bc5f0b3495a8b610bd79ff955
+  data.tar.gz: 95634ae04ab55cf706721238b0e30fff074fa4d5
 SHA512:
-  metadata.gz: 0ca28a713f780ebef3e0647493920b666d12d09b3002b05f464b7fe5d4318a5bc9d26f3ef19ef3207f2c71e6ec1c7b007d9aae79901ad2a45ee33328ce68efae
-  data.tar.gz: c734ff0003ad31e2f079f0ac8c964fc76e3ea225329be4cd546ef2c23988ae7cf71403ef9e5e3adbe171ee29f7a983f97fb93a042c232445c7ae869c3eab3fad
+  metadata.gz: fe7b2ecbef11e6580b9ba736f92a402d8f8b8270c2b6a76a5192075d31a76757eb92b9d5f8bc340ff236eeb805560a7d5bc5d8bdf76c4a7f56c45d8cd9afa815
+  data.tar.gz: 4d3377a975972d0255d054749dcd8cbadb54decbd7fe76ebf6ff9fec8a797ed42ad341ca48e28ee1cc0ab227a7103c0552234d2e0722a82c7ed50ad1c60e9d93

data/lib/offsite_payments/integrations/mollie.rb

@@ -30,6 +30,35 @@ module OffsitePayments #:nodoc:
         end
       end
 
+      class Helper < OffsitePayments::Helper
+        def credential_based_url
+          response = request_redirect
+          @transaction_id = response['id']
+
+          uri = URI.parse(response['links']['paymentUrl'])
+          set_form_fields_for_redirect(uri)
+          uri.query = ''
+          uri.to_s.sub(/\?\z/, '')
+        end
+
+        def form_method
+          "GET"
+        end
+
+        private
+
+        def set_form_fields_for_redirect(uri)
+          return unless uri.query
+
+          CGI.parse(uri.query).each do |key, value|
+            if value.is_a?(Array) && value.length == 1
+              add_field(key, value.first)
+            else
+              add_field(key, value)
+            end
+          end
+        end
+      end
     end
   end
 end

data/lib/offsite_payments/integrations/mollie_ideal.rb

@@ -61,7 +61,7 @@ module OffsitePayments #:nodoc:
         true
       end
 
-      class Helper < OffsitePayments::Helper
+      class Helper < Mollie::Helper
         attr_reader :transaction_id, :redirect_parameters, :token
 
         def initialize(order, account, options = {})
@@ -84,30 +84,6 @@ module OffsitePayments #:nodoc:
           raise ArgumentError, "The description option needs to be set." if options[:description].blank?
         end
 
-        def credential_based_url
-          response = request_redirect
-          @transaction_id = response['id']
-
-          uri = URI.parse(response['links']['paymentUrl'])
-          set_form_fields_for_redirect(uri)
-          uri.query = ''
-          uri.to_s.sub(/\?\z/, '')
-        end
-
-        def form_method
-          "GET"
-        end
-
-        def set_form_fields_for_redirect(uri)
-          CGI.parse(uri.query).each do |key, value|
-            if value.is_a?(Array) && value.length == 1
-              add_field(key, value.first)
-            else
-              add_field(key, value)
-            end
-          end
-        end
-
         def request_redirect
           MollieIdeal.create_payment(token, redirect_parameters)
         rescue ActiveUtils::ResponseError => e

data/lib/offsite_payments/integrations/mollie_mistercash.rb

@@ -3,140 +3,130 @@ module OffsitePayments #:nodoc:
     module MollieMistercash
       include Mollie
 
-        RedirectError = Class.new(ActiveUtils::ActiveUtilsError)
+      RedirectError = Class.new(ActiveUtils::ActiveUtilsError)
 
-        def self.notification(post, options = {})
-          Notification.new(post, options)
-        end
+      def self.notification(post, options = {})
+        Notification.new(post, options)
+      end
 
-        def self.return(post, options = {})
-          Return.new(post, options)
-        end
+      def self.return(post, options = {})
+        Return.new(post, options)
+      end
 
-        def self.live?
-          OffsitePayments.mode == :production
-        end
+      def self.live?
+        OffsitePayments.mode == :production
+      end
 
-        def self.create_payment(token, params)
-          API.new(token).post_request('payments', params)
-        end
+      def self.create_payment(token, params)
+        API.new(token).post_request('payments', params)
+      end
 
-        def self.check_payment_status(token, payment_id)
-          API.new(token).get_request("payments/#{payment_id}")
-        end
+      def self.check_payment_status(token, payment_id)
+        API.new(token).get_request("payments/#{payment_id}")
+      end
 
-        def self.requires_redirect_param?
-          false
-        end
+      def self.requires_redirect_param?
+        false
+      end
 
-        class Helper < OffsitePayments::Helper
-          attr_reader :transaction_id, :redirect_parameters, :token
-
-            def initialize(order, account, options = {})
-              @token = account
-              @redirect_parameters = {
-                :amount => options[:amount],
-                :description => options[:description],
-                :redirectUrl => options[:return_url],
-                :method => 'mistercash',
-                :metadata => { :order => order }
-              }
-
-              @redirect_parameters[:webhookUrl] = options[:notify_url] if options[:notify_url]
-
-              super
-
-              raise ArgumentError, "The return_url option needs to be set." if options[:return_url].blank?
-              raise ArgumentError, "The description option needs to be set." if options[:description].blank?
-            end
-
-            def credential_based_url
-              response = request_redirect
-              uri = URI.parse(response['links']['paymentUrl'])
-              uri.to_s
-            end
-
-            def form_method
-              "GET"
-            end
-
-            def request_redirect
-              MollieMistercash.create_payment(token, redirect_parameters)
-            rescue ActiveUtils::ResponseError => e
-              case e.response.code
-              when '401', '403', '422'
-                error = JSON.parse(e.response.body)['error']['message']
-                raise ActionViewHelperError, error
-              when '503'
-                raise ActionViewHelperError, 'Service temporarily unavailable. Please try again.'
-              else
-                raise
-              end
-            end
+      class Helper < Mollie::Helper
+        attr_reader :transaction_id, :redirect_parameters, :token
 
-        end
+        def initialize(order, account, options = {})
+          @token = account
+          @redirect_parameters = {
+            :amount => options[:amount],
+            :description => options[:description],
+            :redirectUrl => options[:return_url],
+            :method => 'mistercash',
+            :metadata => { :order => order }
+          }
 
-        class Notification < OffsitePayments::Notification
-          def initialize(post_arguments, options = {})
-            super
+          @redirect_parameters[:webhookUrl] = options[:notify_url] if options[:notify_url]
 
-            raise ArgumentError, "The transaction_id needs to be included in the query string." if transaction_id.nil?
-            raise ArgumentError, "The credential1 option needs to be set to the Mollie API key." if api_key.blank?
-          end
+          super
 
-          def complete?
-            true
-          end
+          raise ArgumentError, "The return_url option needs to be set." if options[:return_url].blank?
+          raise ArgumentError, "The description option needs to be set." if options[:description].blank?
+        end
 
-          def item_id
-            params['metadata']['order']
+        def request_redirect
+          MollieMistercash.create_payment(token, redirect_parameters)
+        rescue ActiveUtils::ResponseError => e
+          case e.response.code
+          when '401', '403', '422'
+            error = JSON.parse(e.response.body)['error']['message']
+            raise ActionViewHelperError, error
+          when '503'
+            raise ActionViewHelperError, 'Service temporarily unavailable. Please try again.'
+          else
+            raise
           end
+        end
 
-          def transaction_id
-            params['id']
-          end
+      end
 
-          def api_key
-            @options[:credential1]
-          end
+      class Notification < OffsitePayments::Notification
+        def initialize(post_arguments, options = {})
+          super
 
-          def currency
-            "EUR"
-          end
+          raise ArgumentError, "The transaction_id needs to be included in the query string." if transaction_id.nil?
+          raise ArgumentError, "The credential1 option needs to be set to the Mollie API key." if api_key.blank?
+        end
 
-          # the money amount we received in X.2 decimal.
-          def gross
-            @params['amount']
-          end
+        def complete?
+          true
+        end
 
-          def gross_cents
-            (BigDecimal.new(@params['amount'], 2) * 100).to_i
-          end
+        def item_id
+          params['metadata']['order']
+        end
 
-          def status
-            case @params['status']
-              when 'open';                 'Pending'
-              when 'paidout', 'paid';      'Completed'
-              else                         'Failed'
-            end
-          end
+        def transaction_id
+          params['id']
+        end
 
-          def test?
-            @params['mode'] == 'test'
-          end
+        def api_key
+          @options[:credential1]
+        end
 
-          def acknowledge(authcode = nil)
-            @params = check_payment_status(transaction_id)
-            true
-          end
+        def currency
+          "EUR"
+        end
 
-          def check_payment_status(transaction_id)
-            MollieMistercash.check_payment_status(@options[:credential1], transaction_id)
+        # the money amount we received in X.2 decimal.
+        def gross
+          @params['amount']
+        end
+
+        def gross_cents
+          (BigDecimal.new(@params['amount'], 2) * 100).to_i
+        end
+
+        def status
+          case @params['status']
+          when 'open';                 'Pending'
+          when 'paidout', 'paid';      'Completed'
+          else                         'Failed'
           end
         end
 
-        class Return < OffsitePayments::Return
+        def test?
+          @params['mode'] == 'test'
+        end
+
+        def acknowledge(authcode = nil)
+          @params = check_payment_status(transaction_id)
+          true
+        end
+
+        def check_payment_status(transaction_id)
+          MollieMistercash.check_payment_status(@options[:credential1], transaction_id)
         end
+      end
+
+      class Return < OffsitePayments::Return
+      end
 
     end
   end

data/lib/offsite_payments/version.rb

@@ -1,3 +1,3 @@
 module OffsitePayments
-  VERSION = "2.7.3"
+  VERSION = "2.7.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: offsite_payments
 version: !ruby/object:Gem::Version
-  version: 2.7.3
+  version: 2.7.4
 platform: ruby
 authors:
 - Tobias Luetke