offsite_payments 2.7.27 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 26c27fc431af5ea0650cb099bd36dc13ec371928e9f1ceabbe2aff0a09904a6e
-  data.tar.gz: 99edfdf3c683213d89fb05dc227c7323e2ded4e6725ea3d232a6a142cf38def5
+  metadata.gz: 5a045a98fd10c22d309a48cf2ecf4d9d6fc612d28adac50bd3896d6a2db34f49
+  data.tar.gz: a6982ef987e443c0eae1d1f78bfc35bba6bdecea24f8a2ca177b36509225cab1
 SHA512:
-  metadata.gz: 3d15d1a95e2e6230b67176ceb7bdb8dc4831923611fe9dc93304d4a9a727acc97361117978161a8c31bf40c6df01f152bfe72e24f7af6626b7c0851a6e142a76
-  data.tar.gz: 83a2c6d68f7979cc7ba91ca7842aef2774f34e3e412f8c97da063e327c36ee0f78dab2c6a99a4c0d37f90ccc878da6ac69454ff47564f4bff69420051132808f
+  metadata.gz: 4cc1411ae98b5e8c9ede9f4c4e7ef759186a779b95917c2e2e18ad160077dbd5baa83d1e4354b8deeffc4a1f7fa10ae2f7858dca46c46989b2263b513d047904
+  data.tar.gz: ad859cda068445f86b5afe022305c0766bae7045b34278c3ece6dafc894bc4eb945bc8ddf1e527804c97137b15f64dbcab7844208fc1b679b13b0d324c152ec2

data/README.md

@@ -1,3 +1,6 @@
+> [!CAUTION]  
+> This gem is not actively maintained, and many of the integrations have not been updated in years. It is deprecated at Shopify, and should not be used.
+
 # Offsite Payments
 [![Build Status](https://github.com/activemerchant/offsite_payments/workflows/CI/badge.svg?branch=master)](https://github.com/activemerchant/offsite_payments/actions?query=workflow%3ACI)
 [![Code Climate](https://codeclimate.com/github/activemerchant/offsite_payments/badges/gpa.svg)](https://codeclimate.com/github/activemerchant/offsite_payments)

data/lib/offsite_payments/helper.rb

@@ -1,5 +1,13 @@
 module OffsitePayments #:nodoc:
+  module MoneyCompatibility
+    def to_cents(money)
+      money.try(:cents) || money.try(:subunits) || money
+    end
+  end
+
   class Helper #:nodoc:
+    include MoneyCompatibility
+
     attr_reader :fields
     class_attribute :service_url
     class_attribute :mappings

data/lib/offsite_payments/integrations/direc_pay.rb

@@ -97,7 +97,7 @@ module OffsitePayments #:nodoc:
 
         # Need to format the amount to have 2 decimal places
         def amount=(money)
-          cents = money.respond_to?(:cents) ? money.cents : money
+          cents = to_cents(money)
           raise ArgumentError, "amount must be a Money object or an integer" if money.is_a?(String)
           raise ActionViewHelperError, "amount must be greater than $0.00" if cents.to_i <= 0
 

data/lib/offsite_payments/integrations/directebanking.rb

@@ -89,7 +89,7 @@ module OffsitePayments #:nodoc:
 
         # Need to format the amount to have 2 decimal places
         def amount=(money)
-          cents = money.respond_to?(:cents) ? money.cents : money
+          cents = to_cents(money)
           raise ArgumentError, "amount must be a Money object or an integer" if money.is_a?(String)
           raise ActionViewHelperError, "amount must be greater than $0.00" if cents.to_i <= 0
 

data/lib/offsite_payments/integrations/hi_trust.rb

@@ -43,7 +43,7 @@ module OffsitePayments #:nodoc:
         mapping :amount, 'amount'
 
         def amount=(money)
-          cents = money.respond_to?(:cents) ? money.cents : money
+          cents = to_cents(money)
           raise ArgumentError, "amount must be a Money object or an integer" if money.is_a?(String)
           raise ActionViewHelperError, "amount must be greater than $0.00" if cents.to_i <= 0
 

data/lib/offsite_payments/integrations/ipay88.rb

@@ -66,7 +66,7 @@ module OffsitePayments #:nodoc:
         end
 
         def amount=(money)
-          @amount_in_cents = money.respond_to?(:cents) ? money.cents : money
+          @amount_in_cents = to_cents(money)
           raise ArgumentError, "amount must be a Money object or an integer" if money.is_a?(String)
           raise ActionViewHelperError, "amount must be greater than $0.00" if @amount_in_cents.to_i <= 0
 

data/lib/offsite_payments/integrations/nochex.rb

@@ -94,7 +94,7 @@ module OffsitePayments #:nodoc:
 
         # Need to format the amount to have 2 decimal places
         def amount=(money)
-          cents = money.respond_to?(:cents) ? money.cents : money
+          cents = to_cents(money)
           raise ArgumentError, "amount must be a Money object or an integer" if money.is_a?(String)
           raise ActionViewHelperError, "amount must be greater than $0.00" if cents.to_i <= 0
 

data/lib/offsite_payments/integrations/realex_offsite.rb

@@ -422,14 +422,19 @@ module OffsitePayments #:nodoc:
         end
 
         # This method is used for generating the "BILLING_CODE" field,
-        # this field is generated by concatenating the zip field and
+        # which is only needed for US, CA and GB.
+        # This field is generated by concatenating the zip field and
         # the first line of address with a pipe(|) between them
         # if the country is GB, we remove the non-numeric characters
         def extract_avs_code(params={})
-          return unless params[:zip] && params[:address1]
+          country_code = lookup_country_code(params[:country], :alpha2)
+          return unless params[:zip] && params[:address1] && ['US', 'CA', 'GB'].include?(country_code)
           code = [params[:zip], params[:address1]]
           code = code.collect{|p| extract_digits(p) } if params[:country] == 'GB'
-          code.reject{|p| p.empty? }.join('|')
+          code = code.reject{|p| p.empty? }.join('|')
+          # Since this field accepts only a few characters, we remove the ones that are not accepted,
+          # and trim the white spaces
+          code = code.gsub(/[^a-z0-9_\-| ]+/i, '').strip
         end
 
         def extract_address_match_indicator(value)
@@ -507,8 +512,8 @@ module OffsitePayments #:nodoc:
           case key
             when 'HPP_CUSTOMER_EMAIL' then /^([a-zA-Z0-9_\-\.]+)@([a-zA-Z0-9_\-\.]+)\.([a-zA-Z]{2,24})*$/
             when 'HPP_CUSTOMER_PHONENUMBER_MOBILE' then /^([0-9 +]){1,3}(\|){0,1}([0-9 +]){1,15}$/
-            when 'HPP_BILLING_STREET1', 'HPP_SHIPPING_STREET1', 'HPP_BILLING_STREET2', 'HPP_SHIPPING_STREET2' then /^[\p{L}\p{M}\p{Blank}\p{N}\/\.\-\_\'\,]{1,50}$/
-            when 'HPP_BILLING_CITY', 'HPP_SHIPPING_CITY' then /^[\p{L}\p{M}\p{Blank}\p{N}\/\.\-\_\'\,]{1,40}$/
+            when 'HPP_BILLING_STREET1', 'HPP_SHIPPING_STREET1', 'HPP_BILLING_STREET2', 'HPP_SHIPPING_STREET2' then /^[ÀÁÂÃÂÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ØÙÚÛÜÝÞßàáâãäåªæçèéêëìíîïðñòóôõöº÷ø¤ùúûüýþÿ~L~N~Z~\~^~_¥a-zA-Z0-9.'";\s,\+\-£\/@!\?%\*:$#\[\]|=\\&\u0152\u0153\u017D\u0161\u017E\u0178\u20AC]{1,50}$/
+            when 'HPP_BILLING_CITY', 'HPP_SHIPPING_CITY' then /^[ÀÁÂÃÂÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ØÙÚÛÜÝÞßàáâãäåªæçèéêëìíîïðñòóôõöº÷ø¤ùúûüýþÿ~L~N~Z~\~^~_¥a-zA-Z0-9.'";\s,\+\-£\/@!\?%\*:$#\[\]|=\\&\u0152\u0153\u017D\u0161\u017E\u0178\u20AC]{1,40}$/
             when 'HPP_BILLING_COUNTRY', 'HPP_SHIPPING_COUNTRY' then /^([0-9])*$/
             when 'HPP_BILLING_POSTALCODE', 'HPP_SHIPPING_POSTALCODE' then /^[a-zA-Z0-9\-\s]{1,16}$/
             when 'HPP_BILLING_STATE', 'HPP_SHIPPING_STATE' then /^([A-Z])*$/
@@ -599,6 +604,14 @@ module OffsitePayments #:nodoc:
             end
           end
 
+          unless ['US', 'CA', 'GB'].include?(country_code)
+            # BILLING_CODE is required only for US, CA and GB, otherwise is nil,
+            # therefore the field is deleted for the other countries
+            @fields.delete_if do |k, _|
+              k == 'BILLING_CODE'
+            end
+          end
+
           if @fields[mappings[:customer][:phone]]
             add_field(mappings[:customer][:phone], format_phone_number(@phone_number, country_code))
           end

data/lib/offsite_payments/integrations/sage_pay_form.rb

@@ -367,7 +367,7 @@ module OffsitePayments #:nodoc:
 
         # Used by composition methods, but not supplied by SagePay.
         def currency
-          nil
+          Money::NULL_CURRENCY
         end
 
         def test?

data/lib/offsite_payments/notification.rb

@@ -63,7 +63,23 @@ module OffsitePayments #:nodoc:
       @raw = post.to_s
       for line in @raw.split('&')
         key, value = *line.scan( %r{^([A-Za-z0-9_.-]+)\=(.*)$} ).flatten
-        params[key] = CGI.unescape(value.to_s) if key.present?
+        if key.present?
+          value = CGI.unescape(value.to_s)
+
+          # Paypal tend to send data encoded in ISO-8859-1
+          unless value.valid_encoding?
+            iso_value = value.dup.force_encoding(Encoding::ISO_8859_1)
+            if iso_value.valid_encoding?
+              value = iso_value.encode(Encoding::UTF_8)
+            else
+              # To be safe, if we get something even weirder, we ensure
+              # we return a UTF-8 strings.
+              value = value.b.encode(Encoding::UTF_8, replace: "?")
+            end
+          end
+
+          params[key] = value
+        end
       end
     end
   end

data/lib/offsite_payments/version.rb

@@ -1,3 +1,3 @@
 module OffsitePayments
-  VERSION = "2.7.27"
+  VERSION = "3.0.0"
 end

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: offsite_payments
 version: !ruby/object:Gem::Version
-  version: 2.7.27
+  version: 3.0.0
 platform: ruby
 authors:
 - Tobias Luetke
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-21 00:00:00.000000000 Z
+date: 2024-09-26 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: shopify-money
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.3
+        version: 7.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.3
+        version: 7.2.0
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -62,14 +76,14 @@ dependencies:
   name: active_utils
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.3.0
 - !ruby/object:Gem::Dependency
@@ -92,28 +106,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.3
+        version: 7.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.3
+        version: 7.2.0
 - !ruby/object:Gem::Dependency
   name: actionview
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.6.2
+        version: 7.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.6.2
+        version: 7.2.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -278,15 +292,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: "\n    In order to use `offsite_payments` gem, you need to either
-  install or add to your Gemfile\n    one of the two options for Money gem:\n      -
-  `gem 'money'`\n      - `gem 'shopify-money', require: 'money'`\n\n    Regardless
-  of which gem you choose, please add them *before* `offsite_payments`.\n    For more
-  info, go to https://github.com/activemerchant/offsite_payments#money-gem-dependency\n\n
-  \   It's also important to note that all Money object usage inside `offsite_payments`
-  is being\n    deprecated. We encourage you to use your own Money object inside your
-  app instead of relying\n    on `offsite_payments` doing it for you, e.g. `Money.from_amount(notification.gross)`\n
-  \   "
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -301,8 +307,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.5.18
+signing_key:
 specification_version: 4
 summary: Framework and tools for dealing with offsite (hosted) payment pages.
 test_files: []