offsite_payments 2.1.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 657879b046bcb541ea2225eee85af0f5916a4d79
-  data.tar.gz: 73e5e75b10f09b131966a268697dd641dfc1bd93
+  metadata.gz: b93c09319f5c58335021b513de7d370d04369846
+  data.tar.gz: 27db91e8bc8007d62fd62c10bbedbc301b5e87e8
 SHA512:
-  metadata.gz: 697047cf3a0639a5093c1f1ba0c5a19c9040a4694405ea7ca515b0a2bcabb3a52527ac97e49919b8fcd42fd1c27b7f10ead8d55c9aea4597eb4cdcbc20308bc3
-  data.tar.gz: 22c3e6d5e428a00fd8943d15ad95ae3e811716d8cbbdf778cb7f881f16665b952a63223a786274b616c6741118ab1f00feef0dd87dbabb04d012ab966b4a3440
+  metadata.gz: 2e3892c9fc35ef7949b8b98ea8521bdf33d98c58b2e8a8ff220d3d7fcabd5efc4de1d0bca75ca9431d1df4374d14d938aa58e7fba60cd0a4693d46180ab5db53
+  data.tar.gz: cc5bb2b3a068fb481f6a09365ad359005fd31d5a2d202d93e143b00287653b7a5ea76533b41d90c0cbe43b375bf33eb4aa3a9b30bd89bb448b0cf4bb0fdf7223

data/README.md

@@ -1,13 +1,23 @@
 # Offsite Payments
-[![Build Status](https://travis-ci.org/Shopify/offsite_payments.png?branch=master)](https://travis-ci.org/Shopify/offsite_payments)
-[![Code Climate](https://codeclimate.com/github/Shopify/offsite_payments.png)](https://codeclimate.com/github/Shopify/offsite_payments)
+[![Build Status](https://travis-ci.org/activemerchant/offsite_payments.png?branch=master)](https://travis-ci.org/activemerchant/offsite_payments)
+[![Code Climate](https://codeclimate.com/github/activemerchant/offsite_payments.png)](https://codeclimate.com/github/activemerchant/offsite_payments)
 
 Offsite Payments is an extraction from the ecommerce system [Shopify](http://www.shopify.com). Shopify's requirements for a simple and unified API to handle dozens of different offsite payment pages (often called hosted payment pages) with very different exposed APIs was the chief principle in designing the library.
 
 It was developed for usage in Ruby on Rails web applications and integrates seamlessly
 as a Rails plugin. It should also work as a stand alone Ruby library, but much of the benefit is in the ActionView helpers which are Rails-specific.
 
-Offsite Payments has been in production use (originally as part of the [ActiveMerchant](https://github.com/Shopify/active_merchant) project) since June 2006. It is maintained by the [Shopify](http://www.shopify.com) team, with much help from an ever-growing set of contributors.
+Offsite Payments has been in production use (originally as part of the [ActiveMerchant](https://github.com/activemerchant/active_merchant) project) since June 2006. It is maintained by the [Shopify](http://www.shopify.com) team, with much help from an ever-growing set of contributors.
+
+The addition of your gateway to offsite_payments does not guarantee placement within Shopify. In order to have your gateway considered, please send an email to payment-integrations@shopify.com with **Offsite Payments Integration** in the subject. Be sure to include:
+
+1. Name, URL & description of the payment provider you wish to integrate
+2. Markets served by this integration
+3. List of major supported payment methods
+4. Your most recent Certificate of PCI Compliance
+5. Reason that the [Universal API](https://github.com/activemerchant/offsite_payments/blob/master/lib/offsite_payments/integrations/universal.rb)* cannot be used for your integration.
+
+*The Universal API defines a standard set of requests and callbacks that can be used to integrate with Shopify. A sample app and documentation are hosted [here](https://github.com/Shopify/offsite-gateway-sim). The Universal API should be used for all integrations in which placement within Shopify is the desired outcome. 
 
 ## Installation
 
@@ -15,7 +25,7 @@ Offsite Payments has been in production use (originally as part of the [ActiveMe
 
 You can check out the latest source from git:
 
-    git clone https://github.com/Shopify/offsite_payments.git
+    git clone https://github.com/activemerchant/offsite_payments.git
 
 ### From RubyGems
 
@@ -27,7 +37,7 @@ Or, if you're using Bundler, just add the following to your Gemfile:
 
     gem 'offsite_payments'
 
-[API documentation](http://rubydoc.info/github/Shopify/offsite_payments/master/file/README.md).
+[API documentation](http://www.rubydoc.info/github/activemerchant/offsite_payments/master).
 
 ## Supported Integrations
 
@@ -45,6 +55,7 @@ Or, if you're using Bundler, just add the following to your Gemfile:
 * [ePay](http://www.epay.dk/epay-payment-solutions/)
 * [First Data](https://firstdata.zendesk.com/entries/407522-first-data-global-gateway-e4sm-payment-pages-integration-manual)
 * [HiTRUST](http://www.hitrust.com.hk/)
+* [MOLPay](http://www.molpay.com/v2/) - MY, SG, ID, TH, VN, PH, CN, AU
 * [Moneybookers](http://www.moneybookers.com)
 * [Nochex](http://www.nochex.com)
 * [PagSeguro](http://www.pagseguro.com.br/) - BR
@@ -53,6 +64,7 @@ Or, if you're using Bundler, just add the following to your Gemfile:
 * [PayDollar](http://www.paydollar.com)
 * [Paysbuy](https://www.paysbuy.com/) - TH
 * [Platron](https://www.platron.ru/) - RU
+* [Realex](http://www.realexpayments.com)
 * [RBK Money](https://rbkmoney.ru/) - RU
 * [Robokassa](http://robokassa.ru/) - RU
 * [SagePay Form](http://www.sagepay.com/products_services/sage_pay_go/integration/form)

data/lib/offsite_payments.rb

@@ -3,8 +3,6 @@ require 'cgi'
 require "timeout"
 require "socket"
 
-require 'active_support/core_ext/class/delegating_attributes'
-
 require 'active_utils'
 
 require "offsite_payments/helper"

data/lib/offsite_payments/helper.rb

@@ -16,7 +16,7 @@ module OffsitePayments #:nodoc:
     end
 
     def initialize(order, account, options = {})
-      options.assert_valid_keys([:amount, :currency, :test, :credential2, :credential3, :credential4, :country, :account_name, :description, :transaction_type, :authcode, :notify_url, :return_url, :redirect_param, :forward_url])
+      options.assert_valid_keys([:amount, :currency, :test, :credential2, :credential3, :credential4, :country, :account_name, :description, :transaction_type, :authcode, :notify_url, :return_url, :redirect_param, :forward_url, :checkout_token])
       @fields             = {}
       @raw_html_fields    = []
       @test               = options[:test]
@@ -30,6 +30,7 @@ module OffsitePayments #:nodoc:
       self.notify_url     = options[:notify_url]
       self.return_url     = options[:return_url]
       self.redirect_param = options[:redirect_param]
+      self.checkout_token = options[:checkout_token]
     end
 
     def self.mapping(attribute, options = {})

data/lib/offsite_payments/integrations/citrus.rb

@@ -84,7 +84,7 @@ module OffsitePayments
             else
               case transaction_status.downcase
               when 'success' then 'Completed'
-              when 'canceled' then 'Cancelled'
+              when 'canceled' then 'Failed'
               end
             end
           else
@@ -219,7 +219,7 @@ module OffsitePayments
         end
 
         def cancelled?
-          @notification.status == 'Cancelled'
+          @notification.status == 'Failed'
         end
       end
     end

data/lib/offsite_payments/integrations/coinbase.rb

@@ -81,7 +81,11 @@ module OffsitePayments #:nodoc:
         end
 
         def gross
-          "%.2f" % (params['total_native']['cents'].to_f / 100)
+          if params['total_original'].present?
+            "%.2f" % (params['total_original']['cents'].to_f / 100)
+          else
+            "%.2f" % (params['total_native']['cents'].to_f / 100)
+          end
         end
 
         def currency
@@ -101,7 +105,6 @@ module OffsitePayments #:nodoc:
         # apc arrives. Coinbase will verify that all the information we received are correct
         # and will return a ok or a fail.
         def acknowledge(authcode = {})
-
           uri = URI.parse(Coinbase.notification_confirmation_url % transaction_id)
 
           response = Coinbase.do_request(uri, @options[:credential1], @options[:credential2])
@@ -110,6 +113,7 @@ module OffsitePayments #:nodoc:
           posted_order = @params
           parse(response)
 
+          return false unless @params
           %w(id custom total_native status).all? { |param| posted_order[param] == @params[param] }
         end
 
@@ -118,6 +122,8 @@ module OffsitePayments #:nodoc:
         def parse(post)
           @raw = post.to_s
           @params = JSON.parse(post)['order']
+        rescue JSON::ParserError
+          @params = {}
         end
       end
 

data/lib/offsite_payments/integrations/direc_pay.rb

@@ -289,7 +289,7 @@ module OffsitePayments #:nodoc:
 
       class Return < OffsitePayments::Return
         def initialize(post_data, options = {})
-          @notification = Notification.new(treat_failure_as_pending(post_data), options)
+          @notification = Notification.new(post_data, options)
         end
 
         def success?
@@ -299,13 +299,6 @@ module OffsitePayments #:nodoc:
         def message
           notification.status
         end
-
-        private
-
-        # Work around the issue that the initial return from DirecPay is always either SUCCESS or FAIL, there is no PENDING
-        def treat_failure_as_pending(post_data)
-          post_data.sub(/FAIL/, 'PENDING')
-        end
       end
 
       class Status

data/lib/offsite_payments/integrations/gestpay.rb

@@ -189,6 +189,8 @@ module OffsitePayments #:nodoc:
           response = ssl_get(Gestpay.service_url, decryption_query_string(shop_login, encrypted_string))
           encoded_response = parse_response(response)
           parse_delimited_string(encoded_response, DELIMITER, true)
+        rescue GestpayEncryptionResponseError => e
+          { 'PAY1_TRANSACTIONRESULT' => 'Error' }
         end
 
         def decryption_query_string(shop_login, encrypted_string)

data/lib/offsite_payments/integrations/klarna.rb

@@ -2,7 +2,9 @@ module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Klarna
       mattr_accessor :service_url
-      self.service_url = 'https://api.hostedcheckout.io/api/v1/checkout'
+      self.service_url = 'https://api.hostedcheckout.io/shopify/payment'
+
+      REQUIRED_FIELDS = %w(amount checkout_token merchant_base_uri merchant_checkout_uri merchant_confirmation_uri merchant_id merchant_terms_uri purchase_currency)
 
       def self.notification(post_body, options = {})
         Notification.new(post_body, options)
@@ -15,24 +17,11 @@ module OffsitePayments #:nodoc:
       def self.cart_items_payload(fields, cart_items)
         check_required_fields!(fields)
 
-        payload = fields['purchase_country'].to_s +
-                  fields['purchase_currency'].to_s +
-                  fields['locale'].to_s
-
-        cart_items.each_with_index do |item, i|
-          payload << fields["cart_item-#{i}_type"].to_s +
-                     fields["cart_item-#{i}_reference"].to_s +
-                     fields["cart_item-#{i}_quantity"].to_s +
-                     fields["cart_item-#{i}_unit_price"].to_s +
-                     fields.fetch("cart_item-#{i}_discount_rate", '').to_s
+        payload = ""
+        REQUIRED_FIELDS.sort.each do |field|
+           payload << fields[field].to_s
         end
 
-        payload << fields['merchant_id'].to_s +
-                   fields['merchant_terms_uri'].to_s +
-                   fields['merchant_checkout_uri'].to_s +
-                   fields['merchant_base_uri'].to_s +
-                   fields['merchant_confirmation_uri'].to_s
-
         payload
       end
 
@@ -49,14 +38,7 @@ module OffsitePayments #:nodoc:
       private
 
       def self.check_required_fields!(fields)
-        %w(purchase_country
-           purchase_currency
-           locale
-           merchant_id
-           merchant_terms_uri
-           merchant_checkout_uri
-           merchant_base_uri
-           merchant_confirmation_uri).each do |required_field|
+        REQUIRED_FIELDS.each do |required_field|
           raise ArgumentError, "Missing required field #{required_field}" if fields[required_field].nil?
         end
       end
@@ -66,6 +48,8 @@ module OffsitePayments #:nodoc:
         mapping :cancel_return_url, ['merchant_terms_uri', 'merchant_checkout_uri', 'merchant_base_uri']
         mapping :account, 'merchant_id'
         mapping :customer, email: 'shipping_address_email'
+        mapping :checkout_token, 'checkout_token'
+        mapping :amount, 'amount'
 
         def initialize(order, account, options = {})
           super
@@ -234,7 +218,7 @@ module OffsitePayments #:nodoc:
         end
 
         def gross_cents
-          params["cart"]["total_price_including_tax"]
+          params["order_amount"]
         end
 
         def status

data/lib/offsite_payments/integrations/mollie.rb

@@ -0,0 +1,32 @@
+module OffsitePayments #:nodoc:
+  module Integrations #:nodoc:
+    module Mollie
+      class API
+        include ActiveUtils::PostsData
+
+        attr_reader :token
+
+        MOLLIE_API_V1_URI = 'https://api.mollie.nl/v1/'.freeze
+
+        def initialize(token)
+          @token = token
+        end
+
+        def get_request(resource, params = nil)
+          uri = URI.parse(MOLLIE_API_V1_URI + resource)
+          uri.query = params.map { |k,v| "#{CGI.escape(k)}=#{CGI.escape(v)}}"}.join('&') if params
+          headers = { "Authorization" => "Bearer #{token}", "Content-Type" => "application/json" }
+          JSON.parse(ssl_get(uri.to_s, headers))
+        end
+
+        def post_request(resource, params = nil)
+          uri = URI.parse(MOLLIE_API_V1_URI + resource)
+          headers = { "Authorization" => "Bearer #{token}", "Content-Type" => "application/json" }
+          data = params.nil? ? nil : JSON.dump(params)
+          JSON.parse(ssl_post(uri.to_s, data, headers))
+        end
+      end
+
+    end
+  end
+end

data/lib/offsite_payments/integrations/mollie_ideal.rb

@@ -1,33 +1,7 @@
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module MollieIdeal
-      class API
-        include ActiveUtils::PostsData
-
-        attr_reader :token
-
-        def initialize(token)
-          @token = token
-        end
-
-        def get_request(resource, params = nil)
-          uri = URI.parse(MOLLIE_API_V1_URI + resource)
-          uri.query = params.map { |k,v| "#{CGI.escape(k)}=#{CGI.escape(v)}}"}.join('&') if params
-          headers = { "Authorization" => "Bearer #{token}", "Content-Type" => "application/json" }
-          JSON.parse(ssl_get(uri.to_s, headers))
-        end
-
-        def post_request(resource, params = nil)
-          uri = URI.parse(MOLLIE_API_V1_URI + resource)
-          headers = { "Authorization" => "Bearer #{token}", "Content-Type" => "application/json" }
-          data = params.nil? ? nil : JSON.dump(params)
-          JSON.parse(ssl_post(uri.to_s, data, headers))
-        end
-      end
-
-      RedirectError = Class.new(ActiveUtils::ActiveUtilsError)
-
-      MOLLIE_API_V1_URI = 'https://api.mollie.nl/v1/'.freeze
+      include Mollie
 
       mattr_accessor :live_issuers
       self.live_issuers = [
@@ -48,22 +22,6 @@ module OffsitePayments #:nodoc:
         ["TBM Bank", "ideal_TESTNL99"]
       ]
 
-      def self.notification(post, options = {})
-        Notification.new(post, options)
-      end
-
-      def self.return(post, options = {})
-        Return.new(post, options)
-      end
-
-      def self.live?
-        OffsitePayments.mode == :production
-      end
-
-      def self.requires_redirect_param?
-        true
-      end
-
       def self.redirect_param_label
         "Select your bank"
       end
@@ -80,6 +38,22 @@ module OffsitePayments #:nodoc:
           .map { |issuer| [issuer['name'], issuer['id']] }
       end
 
+      RedirectError = Class.new(ActiveUtils::ActiveUtilsError)
+
+      MOLLIE_API_V1_URI = 'https://api.mollie.nl/v1/'.freeze
+
+      def self.notification(post, options = {})
+        Notification.new(post, options)
+      end
+
+      def self.return(post, options = {})
+        Return.new(post, options)
+      end
+
+      def self.live?
+        OffsitePayments.mode == :production
+      end
+
       def self.create_payment(token, params)
         API.new(token).post_request('payments', params)
       end
@@ -88,12 +62,16 @@ module OffsitePayments #:nodoc:
         API.new(token).get_request("payments/#{payment_id}")
       end
 
+      def self.requires_redirect_param?
+        true
+      end
+
       class Helper < OffsitePayments::Helper
-        attr_reader :transaction_id, :redirect_paramaters, :token
+        attr_reader :transaction_id, :redirect_parameters, :token
 
         def initialize(order, account, options = {})
           @token = account
-          @redirect_paramaters = {
+          @redirect_parameters = {
             :amount => options[:amount],
             :description => options[:description],
             :issuer => options[:redirect_param],
@@ -102,7 +80,7 @@ module OffsitePayments #:nodoc:
             :metadata => { :order => order }
           }
 
-          @redirect_paramaters[:webhookUrl] = options[:notify_url] if options[:notify_url]
+          @redirect_parameters[:webhookUrl] = options[:notify_url] if options[:notify_url]
 
           super
 
@@ -136,7 +114,7 @@ module OffsitePayments #:nodoc:
         end
 
         def request_redirect
-          MollieIdeal.create_payment(token, redirect_paramaters)
+          MollieIdeal.create_payment(token, redirect_parameters)
         rescue ActiveUtils::ResponseError => e
           case e.response.code
           when '401', '403', '422'

data/lib/offsite_payments/integrations/mollie_mistercash.rb

@@ -0,0 +1,143 @@
+module OffsitePayments #:nodoc:
+  module Integrations #:nodoc:
+    module MollieMistercash
+      include Mollie
+
+        RedirectError = Class.new(ActiveUtils::ActiveUtilsError)
+
+        def self.notification(post, options = {})
+          Notification.new(post, options)
+        end
+
+        def self.return(post, options = {})
+          Return.new(post, options)
+        end
+
+        def self.live?
+          OffsitePayments.mode == :production
+        end
+
+        def self.create_payment(token, params)
+          API.new(token).post_request('payments', params)
+        end
+
+        def self.check_payment_status(token, payment_id)
+          API.new(token).get_request("payments/#{payment_id}")
+        end
+
+        def self.requires_redirect_param?
+          false
+        end
+
+        class Helper < OffsitePayments::Helper
+          attr_reader :transaction_id, :redirect_parameters, :token
+
+            def initialize(order, account, options = {})
+              @token = account
+              @redirect_parameters = {
+                :amount => options[:amount],
+                :description => options[:description],
+                :redirectUrl => options[:return_url],
+                :method => 'mistercash',
+                :metadata => { :order => order }
+              }
+
+              @redirect_parameters[:webhookUrl] = options[:notify_url] if options[:notify_url]
+
+              super
+
+              raise ArgumentError, "The return_url option needs to be set." if options[:return_url].blank?
+              raise ArgumentError, "The description option needs to be set." if options[:description].blank?
+            end
+
+            def credential_based_url
+              response = request_redirect
+              uri = URI.parse(response['links']['paymentUrl'])
+              uri.to_s
+            end
+
+            def form_method
+              "GET"
+            end
+
+            def request_redirect
+              MollieMistercash.create_payment(token, redirect_parameters)
+            rescue ActiveUtils::ResponseError => e
+              case e.response.code
+              when '401', '403', '422'
+                error = JSON.parse(e.response.body)['error']['message']
+                raise ActionViewHelperError, error
+              when '503'
+                raise ActionViewHelperError, 'Service temporarily unavailable. Please try again.'
+              else
+                raise
+              end
+            end
+
+        end
+
+        class Notification < OffsitePayments::Notification
+          def initialize(post_arguments, options = {})
+            super
+
+            raise ArgumentError, "The transaction_id needs to be included in the query string." if transaction_id.nil?
+            raise ArgumentError, "The credential1 option needs to be set to the Mollie API key." if api_key.blank?
+          end
+
+          def complete?
+            true
+          end
+
+          def item_id
+            params['metadata']['order']
+          end
+
+          def transaction_id
+            params['id']
+          end
+
+          def api_key
+            @options[:credential1]
+          end
+
+          def currency
+            "EUR"
+          end
+
+          # the money amount we received in X.2 decimal.
+          def gross
+            @params['amount']
+          end
+
+          def gross_cents
+            (BigDecimal.new(@params['amount'], 2) * 100).to_i
+          end
+
+          def status
+            case @params['status']
+              when 'open';                 'Pending'
+              when 'paidout', 'paid';      'Completed'
+              else                         'Failed'
+            end
+          end
+
+          def test?
+            @params['mode'] == 'test'
+          end
+
+          def acknowledge(authcode = nil)
+            @params = check_payment_status(transaction_id)
+            true
+          end
+
+          def check_payment_status(transaction_id)
+            MollieMistercash.check_payment_status(@options[:credential1], transaction_id)
+          end
+        end
+
+        class Return < OffsitePayments::Return
+        end
+
+    end
+  end
+end

data/lib/offsite_payments/integrations/molpay.rb

@@ -0,0 +1,193 @@
+module OffsitePayments #:nodoc:
+  module Integrations #:nodoc:
+    module Molpay
+      mattr_accessor :acknowledge_url
+      self.acknowledge_url = 'https://www.onlinepayment.com.my/MOLPay/API/chkstat/returnipn.php'
+
+      def self.notification(post, options = {})
+        Notification.new(post, options)
+      end
+
+      def self.return(query_string, options={})
+        Return.new(query_string, options)
+      end
+
+      #  (Optional Parameter) = channel //will generate URL to go directly to specific channel, e.g maybank2u, cimb
+      #  Please refer MOLPay API spec for the channel routing
+      class Helper < OffsitePayments::Helper
+        include ActiveUtils::RequiresParameters
+
+        SUPPORTED_CURRENCIES = ['MYR', 'USD', 'SGD', 'PHP', 'VND', 'IDR', 'AUD', 'CNY', 'THB', 'GBP', 'EUR', 'HKD']
+
+        # Defaults to en
+        SUPPORTED_LANGUAGES = ['en', 'cn']
+
+        SERVICE_URL = 'https://www.onlinepayment.com.my/MOLPay/pay/'.freeze
+
+        mapping :account,             'merchantid'
+        mapping :amount,              'amount'
+        mapping :order,               'orderid'
+        mapping :customer, :name  =>  'bill_name',
+                           :email =>  'bill_email',
+                           :phone =>  'bill_mobile'
+
+        mapping :description,         'bill_desc'
+        mapping :language,            'langcode'
+        mapping :country,             'country'
+        mapping :currency,            'cur'
+        mapping :return_url,          'returnurl'
+        mapping :notify_url,          'callbackurl'
+        mapping :signature,           'vcode'
+
+        attr_reader :amount_in_cents, :verify_key, :channel
+
+        def credential_based_url
+          service_url = SERVICE_URL + @fields[mappings[:account]] + "/"
+          service_url = service_url + @channel if @channel
+          service_url
+        end
+
+        def initialize(order, account, options = {})
+          requires!(options, :amount, :currency, :credential2)
+          @verify_key = options[:credential2] if options[:credential2]
+          @amount_in_cents = options[:amount]
+          @channel = options.delete(:channel)
+          super
+        end
+
+        def form_fields
+          add_field mappings[:signature], signature
+          @fields
+        end
+
+        def amount=(money)
+          unless money > 0
+            raise ArgumentError, "amount must be greater than $0.00."
+          end
+          add_field mappings[:amount], sprintf("%.2f", money.to_f)
+        end
+
+        def currency=(cur)
+          raise ArgumentError, "unsupported currency" unless SUPPORTED_CURRENCIES.include?(cur)
+          add_field mappings[:currency], cur
+        end
+
+        def language=(lang)
+          raise ArgumentError, "unsupported language" unless SUPPORTED_LANGUAGES.include?(lang)
+          add_field mappings[:language], lang
+        end
+
+        private
+
+        def signature
+          Digest::MD5.hexdigest("#{@fields[mappings[:amount]]}#{@fields[mappings[:account]]}#{@fields[mappings[:order]]}#{@verify_key}")
+        end
+      end
+
+      class Notification < OffsitePayments::Notification
+        include ActiveUtils::PostsData
+
+        def status
+          case params['status']
+            when '00'
+              'Completed'
+            when '11'
+              'Failed'
+            when '22'
+              'Pending'
+          end
+        end
+
+        def complete?
+          status == 'Completed'
+        end
+
+        def item_id
+          params['orderid']
+        end
+
+        def transaction_id
+          params['tranID']
+        end
+
+        def account
+          params["domain"]
+        end
+
+        # the money amount we received in X.2 decimal.
+        def gross
+          params['amount']
+        end
+
+        def currency
+          params['currency']
+        end
+
+        def channel
+          params['channel']
+        end
+
+        # When was this payment received by the client.
+        def received_at
+          params['paydate']
+        end
+
+        def auth_code
+          params['appcode']
+        end
+
+        def error_code
+          params['error_code']
+        end
+
+        def error_desc
+          params['error_desc']
+        end
+
+        def security_key
+          params['skey']
+        end
+
+        def test?
+          gross.blank? && auth_code.blank? && error_code.blank? && error_desc.blank? && security_key.blank?
+        end
+
+        def status_orig
+          params['status']
+        end
+
+        def acknowledge(authcode = nil)
+          payload = raw + '&treq=1'
+          ssl_post(Molpay.acknowledge_url, payload,
+            'Content-Length' => "#{payload.size}",
+            'User-Agent'     => "Shopify/OffsitePayments"
+          )
+
+          status == 'Completed' && security_key == generate_signature
+        end
+
+        protected
+
+        def generate_signature
+          key0 = Digest::MD5.hexdigest("#{transaction_id}#{item_id}#{status_orig}#{account}#{gross}#{currency}")
+          Digest::MD5.hexdigest("#{received_at}#{account}#{key0}#{auth_code}#{@options[:credential2]}")
+        end
+      end
+
+      class Return < OffsitePayments::Return
+        def initialize(query_string, options = {})
+          super
+          @notification = Notification.new(query_string, options)
+        end
+
+        def success?
+          @notification.acknowledge
+        end
+
+        def pending?
+          @notification.status == 'Pending'
+        end
+      end
+    end
+  end
+end

data/lib/offsite_payments/integrations/{realex.rb → realex_offsite.rb}

@@ -1,9 +1,9 @@
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
-    module Realex
+    module RealexOffsite
       mattr_accessor :production_url
       mattr_accessor :test_url
-      self.production_url = 'https://hpp.realexpayments.com/pay'
+      self.production_url = 'https://epage.payandshop.com/epage.cgi'
       self.test_url       = 'https://hpp.sandbox.realexpayments.com/pay'
 
       def self.helper(order, account, options={})
@@ -117,6 +117,8 @@ module OffsitePayments #:nodoc:
           # Realex does not send back CURRENCY param in response
           # however it does echo any other param so we send it twice.
           add_field 'X-CURRENCY', @currency
+          add_field 'X-TEST', @test.to_s
+          add_field 'ORDER_ID', "#{order}#{@timestamp.to_i}"
         end
 
         def form_fields
@@ -153,9 +155,10 @@ module OffsitePayments #:nodoc:
         # Realex Required Fields
         mapping :currency,         'CURRENCY'
 
-        mapping :order,            'ORDER_ID'
+        mapping :order,            'CHECKOUT_ID'
         mapping :amount,           'AMOUNT'
-        mapping :return_url,       'MERCHANT_RESPONSE_URL'
+        mapping :notify_url,       'MERCHANT_RESPONSE_URL'
+        mapping :return_url,       'MERCHANT_RETURN_URL'
 
         # Realex Optional fields
         mapping :customer,         :email => 'CUST_NUM'
@@ -174,6 +177,22 @@ module OffsitePayments #:nodoc:
         end
 
         # Required Notification methods to define
+        def acknowledge(authcode = nil)
+          verified?
+        end
+
+        def item_id
+          checkout_id
+        end
+
+        def transaction_id
+          pasref
+        end
+
+        def test?
+          params['X-TEST']
+        end
+
         def status
           if result == '00'
             'Completed'
@@ -205,6 +224,10 @@ module OffsitePayments #:nodoc:
           params['MERCHANT_ID']
         end
 
+        def checkout_id
+          params['CHECKOUT_ID']
+        end
+
         def order_id
           params['ORDER_ID']
         end

data/lib/offsite_payments/integrations/sage_pay_form.rb

@@ -69,14 +69,20 @@ module OffsitePayments #:nodoc:
       class Helper < OffsitePayments::Helper
         include Encryption
 
+        attr_reader :identifier
+
+        def initialize(order, account, options={})
+          super
+          @identifier = rand(0..99999).to_s.rjust(5, '0')
+          add_field 'VendorTxCode', "#{order}-#{@identifier}"
+        end
+
         mapping :credential2, 'EncryptKey'
 
         mapping :account, 'Vendor'
         mapping :amount, 'Amount'
         mapping :currency, 'Currency'
 
-        mapping :order, 'VendorTxCode'
-
         mapping :customer,
           :first_name => 'BillingFirstnames',
           :last_name  => 'BillingSurname',
@@ -246,7 +252,7 @@ module OffsitePayments #:nodoc:
 
         # Vendor-supplied code (:order mapping).
         def item_id
-          params['VendorTxCode']
+          params['VendorTxCode'].rpartition('-').first
         end
 
         # Internal SagePay code, typically "{LONG-UUID}".

data/lib/offsite_payments/integrations/universal.rb

@@ -50,6 +50,10 @@ module OffsitePayments #:nodoc:
           @forward_url = options[:forward_url]
           @key = options[:credential2]
           @currency = options[:currency]
+
+          # x_credential3 should not be included in the request when using the universal offsite dev kit.
+          options[:credential3] = nil if options[:credential3] == @forward_url
+
           super
           self.country = options[:country]
           self.account_name = options[:account_name]
@@ -93,6 +97,8 @@ module OffsitePayments #:nodoc:
         mapping :transaction_type, 'x_transaction_type'
         mapping :description,      'x_description'
         mapping :invoice,          'x_invoice'
+        mapping :credential3,      'x_credential3'
+        mapping :credential4,      'x_credential4'
 
         mapping :customer, :first_name => 'x_customer_first_name',
                            :last_name  => 'x_customer_last_name',

data/lib/offsite_payments/integrations/world_pay.rb

@@ -1,3 +1,4 @@
+require 'ipaddr'
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module WorldPay
@@ -230,6 +231,12 @@ module OffsitePayments #:nodoc:
           return @custom_params ||= read_custom_params
         end
 
+        # Check if the request comes from IP range 195.35.90.0 – 195.35.91.255
+        def valid_sender?(ip)
+          return true if OffsitePayments.mode == :test 
+          IPAddr.new("195.35.90.0/23").include?(IPAddr.new(ip))
+        end
+
         private
 
         # Take the posted data and move the relevant data into a hash

data/lib/offsite_payments/version.rb

@@ -1,3 +1,3 @@
 module OffsitePayments
-  VERSION = "2.1.0"
+  VERSION = "2.3.0"
 end

metadata

@@ -1,36 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: offsite_payments
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
-cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIDcDCCAligAwIBAgIBATANBgkqhkiG9w0BAQUFADA/MQ8wDQYDVQQDDAZhZG1p
-  bnMxFzAVBgoJkiaJk/IsZAEZFgdzaG9waWZ5MRMwEQYKCZImiZPyLGQBGRYDY29t
-  MB4XDTE0MDUxNTIwMzM0OFoXDTE1MDUxNTIwMzM0OFowPzEPMA0GA1UEAwwGYWRt
-  aW5zMRcwFQYKCZImiZPyLGQBGRYHc2hvcGlmeTETMBEGCgmSJomT8ixkARkWA2Nv
-  bTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAL0/81O3e1vh5smcwp2G
-  MpLQ6q0kejQLa65bPYPxdzWA1SYOKyGfw+yR9LdFzsuKpwWzKq6zX35lj1IckWS4
-  bNBEQzxmufUxU0XPM02haFB8fOfDJzdXsWte9Ge4IFwahwn68gpMqN+BvxL+KMYz
-  Iut9YmN44d4LZdsENEIO5vmybuG2vYDz7R56qB0PA+Q2P2CdhymsBad2DQs69FBo
-  uico9V6VMYYctL9lCYdzu9IXrOYNTt88suKIVzzAlHOKeN0Ng5qdztFoTR8sfxDr
-  Ydg3KHl5n47wlpgd8R0f/4b5gGxW+v9pyJCgQnLlRu7DedVSvv7+GMtj3g9r3nhJ
-  KqECAwEAAaN3MHUwCQYDVR0TBAIwADALBgNVHQ8EBAMCBLAwHQYDVR0OBBYEFI/o
-  maf34HXbUOQsdoLHacEKQgunMB0GA1UdEQQWMBSBEmFkbWluc0BzaG9waWZ5LmNv
-  bTAdBgNVHRIEFjAUgRJhZG1pbnNAc2hvcGlmeS5jb20wDQYJKoZIhvcNAQEFBQAD
-  ggEBADkK9aj5T0HPExsov4EoMWFnO+G7RQ28C30VAfKxnL2UxG6i4XMHVs6Xi94h
-  qXFw1ec9Y2eDUqaolT3bviOk9BB197+A8Vz/k7MC6ci2NE+yDDB7HAC8zU6LAx8Y
-  Iqvw7B/PSZ/pz4bUVFlTATif4mi1vO3lidRkdHRtM7UePSn2rUpOi0gtXBP3bLu5
-  YjHJN7wx5cugMEyroKITG5gL0Nxtu21qtOlHX4Hc4KdE2JqzCPOsS4zsZGhgwhPs
-  fl3hbtVFTqbOlwL9vy1fudXcolIE/ZTcxQ+er07ZFZdKCXayR9PPs64heamfn0fp
-  TConQSX2BnZdhIEYW+cKzEC/bLc=
-  -----END CERTIFICATE-----
-date: 2015-01-17 00:00:00.000000000 Z
+cert_chain: []
+date: 2016-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -41,7 +19,7 @@ dependencies:
         version: 3.2.14
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -51,7 +29,7 @@ dependencies:
         version: 3.2.14
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -70,9 +48,6 @@ dependencies:
   name: money
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 7.0.0
@@ -80,9 +55,6 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 7.0.0
@@ -112,14 +84,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -143,7 +115,7 @@ dependencies:
         version: 3.2.20
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -153,7 +125,7 @@ dependencies:
         version: 3.2.20
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -262,7 +234,10 @@ files:
 - lib/offsite_payments/integrations/klarna.rb
 - lib/offsite_payments/integrations/liqpay.rb
 - lib/offsite_payments/integrations/maksuturva.rb
+- lib/offsite_payments/integrations/mollie.rb
 - lib/offsite_payments/integrations/mollie_ideal.rb
+- lib/offsite_payments/integrations/mollie_mistercash.rb
+- lib/offsite_payments/integrations/molpay.rb
 - lib/offsite_payments/integrations/moneybookers.rb
 - lib/offsite_payments/integrations/nochex.rb
 - lib/offsite_payments/integrations/pag_seguro.rb
@@ -279,7 +254,7 @@ files:
 - lib/offsite_payments/integrations/pxpay.rb
 - lib/offsite_payments/integrations/quickpay.rb
 - lib/offsite_payments/integrations/rbkmoney.rb
-- lib/offsite_payments/integrations/realex.rb
+- lib/offsite_payments/integrations/realex_offsite.rb
 - lib/offsite_payments/integrations/robokassa.rb
 - lib/offsite_payments/integrations/sage_pay_form.rb
 - lib/offsite_payments/integrations/two_checkout.rb
@@ -293,7 +268,7 @@ files:
 - lib/offsite_payments/notification.rb
 - lib/offsite_payments/return.rb
 - lib/offsite_payments/version.rb
-homepage: https://github.com/Shopify/offsite_payments
+homepage: https://github.com/activemerchant/offsite_payments
 licenses:
 - MIT
 metadata: {}
@@ -313,7 +288,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.2.3
 signing_key: 
 specification_version: 4
 summary: Framework and tools for dealing with offsite (hosted) payment pages.