odfl 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a30fc4c7716e4880cd056dd66644da31b423f577
-  data.tar.gz: 567fbdde1e965fab69de0fc2bf5a83d4941ab1e2
+  metadata.gz: 3d198de3ab8a6e3ccd62103f3676a8b99cadfa04
+  data.tar.gz: c1dedbf6dc40cb6d6420f969ad0978f5eca37bf1
 SHA512:
-  metadata.gz: 3711ce543943439d54172926c2c9847fcf99c4463a4e292439163741903691ab830004415627360eb4d70117ec2ea69267c49a83c746a7407fc74cd4c4be3ada
-  data.tar.gz: 8e09d32f020b5e80cfc4f86aa83527102013b5b0b587338126218e9760a458db1f463e9cf036e261950753185249c4414503689eb22158ae14430238f5fdca16
+  metadata.gz: 9199a23a640468efd90770db4aa5802edad75fc1a95b01e4a6a2e3a19cea5f3ad09c0473b85276b530d64a18978cb385ca017d766d721abae59293c7b8e64a79
+  data.tar.gz: fc1bc43456f388b8776067d7cdd93dcf7698194c0d59eafd933219917a35e3b7a5a3325f1d659e6861f5f763f9c37499ba239b459055624a9f7107dc4726d032

data/README.md

@@ -8,6 +8,7 @@ Get Old Dominion Freight Line Shipping Quotes
 [![Code Climate](https://codeclimate.com/github/rmevans1/odfl-gem/badges/gpa.svg)](https://codeclimate.com/github/rmevans1/odfl-gem)
 [![Test Coverage](https://codeclimate.com/github/rmevans1/odfl-gem/badges/coverage.svg)](https://codeclimate.com/github/rmevans1/odfl-gem)
 [![Build Status](https://travis-ci.org/rmevans1/odfl-gem.svg?branch=master)](https://travis-ci.org/rmevans1/odfl-gem)
+[![security](https://hakiri.io/github/rmevans1/odfl-gem/master.svg)](https://hakiri.io/github/rmevans1/odfl-gem/master)
 
 The gem allows you to retrieve shipping quotes from Old Dominion Freight Line.
 A customer account is required to retrieve customer specific pricing. However,
@@ -52,6 +53,7 @@ quote.addFreight(pallet.to_hash)
 
 # Get rates
 quote.get_rates
+estimate = quote.get_estimate # Gets the actual estimate from ODFL
 ```
 
 ### Debugging

data/lib/odfl.rb

@@ -214,6 +214,18 @@ class Odfl
     self.addAccessorial('COD')
   end
 
+  # Runs the rate request
+  #
+  # ==== Usage
+  # quote = Odfl.new
+  # assuming all other data has been correctly input
+  # quote.get_rates
+  #
+  # ==== Return Values
+  # true if quote was successfully generated
+  # call quote.get_estimate for the actual estimate information
+  # false if there was an error
+  # call quote.get_error for the error message
   def get_rates
     @response = @client.call(:get_rate_estimate, message: { originPostalCode: @originPostalCode,
                                                             originCountry: @originCountry,
@@ -259,20 +271,30 @@ class Odfl
     end
   end
 
+  # Return the originating service center information
   def getOriginatingServiceCenter
     @resultHash[:originating_service_center]
   end
 
+  # Return the destination service center information
   def getDestinationServiceCenter
     @resultHash[:destination_service_center]
   end
 
+  # Return the estimate information
   def get_estimate
     @resultHash[:rate_estimate]
   end
 
+  # Return the error message if any messages exist
+  # Returns false if no error exist
   def get_error
-    @resultHash[:error_messages][:string]
+    error = @resultHash[:error_messages]
+    if !error.nil?
+      error[:string]
+    else
+      false
+    end
   end
 
   private

data/lib/odfl/version.rb

@@ -1,3 +1,3 @@
 class Odfl
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/lib/odfl_spec.rb

@@ -99,6 +99,23 @@ describe Odfl do
     expect(quote.get_error).to be_a_kind_of(String)
   end
 
+  it 'get_error function should return false when no errors exist' do
+    quote = Odfl.new
+
+    quote.set_origin(20602)
+    quote.set_destination(90210)
+
+    pallet = OdflFreight.new
+    pallet.ratedClass = 70
+    pallet.weight = 1000
+    quote.addFreight(pallet.to_hash)
+
+    result = quote.get_rates
+    expect(result).to be_truthy
+
+    expect(quote.get_error).to be_falsey
+  end
+
   it 'should return a valid rate estimate for a valid quote' do
     quote = Odfl.new
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: odfl
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Robert Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-20 00:00:00.000000000 Z
+date: 2014-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -119,7 +119,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.4
 signing_key: 
 specification_version: 4
 summary: Get freight quotes from Old Dominion Freight Line