odf-report 0.5.0 → 0.5.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Mzc3ZTFmODBhMzEzZjQ1MzdmMjIyMDE3OTBlMmZjMTE0MTYxODI3MA==
+    YzhiYWE2MTU5OTRjZWQ2NGExZDc1ZDRjMGUzM2ZlZWU1ZWY4ZWUwNg==
   data.tar.gz: !binary |-
-    ZDY1OGI3MTRhY2Q1OTI1YjdkYzgyYjhiYjIwMDZhMjA0NzhmZjc0ZQ==
+    YTBkNGEzZjE1NmNkMjc3MTdiNjdmNjZhMDI4ZjAzYjg5NTU0NjJjZA==
 SHA512:
   metadata.gz: !binary |-
-    ZGEzNjBjYzhhZWMzMGFmNTIyYjdiYTdlNTFlMjA1ZDQyNWMwMWNiODQ3YTg1
-    YTk0OGJhZDYzZTA5NGUxZDFjMmIzMGM1NzVlNDgzZDRhNjVkMGFjNTJiN2Fj
-    MmI4ZTkwN2M3YzZhYjkzMTA2NmVlNzVkOWQyYjA1OWRjZTNmYzk=
+    ZjU1YzA0ZjY5YmRlMmJhZTE4YmM0NjY5MDQ0MDkyNGFlYjU1MGYzOTM1NTk0
+    Y2IyODBlMmEwNWRiODgzZmViMDI1MGE1MmJhODUxYzc3MWY4NDdlNzZmYTEw
+    YzVmZDA5NDIwNTVlYTRjMTQ0YTM1ZTQ0N2JkOTE4MDIyYThkOTY=
   data.tar.gz: !binary |-
-    N2Q1Yzk4NGZiMmY3OTg0OWE2NWYyMWYzOTUyYjVlNDI3YWUxYzRiZDZmYjJh
-    MTBlMGUzYzQwZDhiZTBhOGE1ZTAxN2VjMjljZWE2MWFjZTUwM2E4ODhiZmZl
-    ZTljNWU3Mzc0YTkwZjk0OWQ1YWEwNDUzOWFlNGM4MmUxNmYyOTQ=
+    MDNlY2U4ZTU2NTUxZTYzYTZlMWZkN2YxYjI1YTE0YTFlODBmMzFiOTdmMThk
+    YzYyMWQwN2QzZDcxZDhmZjE3ZmQ1ZjFhY2E0NTY5MzcxM2M4NWE3NmEzZTBk
+    ZTI1MjI2OGJmZGMzZGIzYTcwZDYxNjYzYzYyYTgzYjhkNDFmNDc=

data/.gitignore

@@ -3,3 +3,4 @@ pckg
 doc
 *.gem
 test/result
+Gemfile.lock

data/README.textile

@@ -2,9 +2,17 @@ h1. ODF-REPORT
 
 Gem for generating .odt files by making strings, images, tables and sections replacements in a previously created .odt file.
 
+h3. NEW
+
+* as per popular request, now uses rubyzip ~> 1.1.0
+* uses @Zip::OutputStream.write_buffer@ to generate the file. This should avoid corruption issues.
+* the @.generate@ method now returns the actual report binary, so you can send_data it directly
+* you can also use @.generate('file.odt')@, which saves the report to the specified file
+
 h2. INSTALL
 
-(sudo) gem install odf-report
+In your Gemfile
+<pre>gem 'odf-report' </pre>
 
 h2. USAGE
 
@@ -185,20 +193,19 @@ def print
 
   end
 
-  report_file_name = report.generate
-
-  send_file(report_file_name)
+  send_data report.generate, type: 'application/vnd.oasis.opendocument.text',
+                              disposition: 'attachment',
+                              filename: 'report.odt'
 
 end
 </pre>
 
-The @generate@ method will, er... generate the document in a temp dir and returns the full path of the generated file, so you can send it back to the user.
 
 _That's all I have to say about that._
 
 h4. Generating a document in a standalone script
 
-It's just the same as in a Rails app, but you can inform the path where the file will be generated instead of using a temp dir.
+It's just the same as in a Rails app, but you can inform the path where the file will be saved.
 
 <pre>
 report = ODFReport::Report.new("ticket.odt") do |r|
@@ -207,21 +214,12 @@ report = ODFReport::Report.new("ticket.odt") do |r|
 
 end
 
-report.generate("./documents/")
+report.generate("./documents/new_ticket.odt")
 </pre>
 
 <hr/>
 
 h3. REQUIREMENTS
 
-*rubyzip*: for manipulating the contents of the odt file, since it's actually a zip file.
-*nokogiri*: for parsing and manipulating the document xml files.
-
-
-<hr/>
-
-h3. THE FUTURE
-
-Well, this is my first attempt. This gem was extracted from an actual project we developed internally, to fulfill our specific needs.
-
-That said, I would really appreciate any input you can come up with. Critics, suggestions, bug reports are welcome and will be thoroughly examined.
+* rubyzip*: for manipulating the contents of the odt file, since it's actually a zip file.
+* nokogiri*: for parsing and manipulating the document xml files.

data/lib/odf-report/file.rb

@@ -21,9 +21,11 @@ module ODFReport
 
         file.each do |entry|
 
-          unless entry.directory?
+          next if entry.directory?
 
-            data = entry.get_input_stream.read
+          entry.get_input_stream do |is|
+
+            data = is.sysread
 
             if content_files.include?(entry.name)
               yield data
@@ -31,6 +33,7 @@ module ODFReport
 
             @output_stream.put_next_entry(entry.name)
             @output_stream.write data
+
           end
 
         end

data/lib/odf-report/report.rb

@@ -78,7 +78,7 @@ class Report
     end
 
     if dest
-      ::File.open(dest, "w") {|f| f.write(@file.data) }
+      ::File.open(dest, "wb") {|f| f.write(@file.data) }
     else
       @file.data
     end

data/lib/odf-report/version.rb

@@ -1,3 +1,3 @@
 module ODFReport
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: odf-report
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Sandro Duarte
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-24 00:00:00.000000000 Z
+date: 2014-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler