odeon_uk 4.0.1 → 5.0.0

data/test/lib/odeon_uk/internal/api_response_test.rb

@@ -1,47 +1,66 @@
 require_relative '../../../test_helper'
 
-describe OdeonUk::Internal::ApiResponse do
+class OdeonUk::Internal::ApiResponseTest < Minitest::Test
   include ApiFixturesHelper
 
-  let(:described_class) { OdeonUk::Internal::ApiResponse }
+  BASE_URL = 'https://vwc.odeon.co.uk/WSVistaWebClient/ocapi/v1'.freeze
+  HEADERS = {
+    'Authorization' => 'Bearer guest-jwt', 'Connect-Region-Code' => 'UK'
+  }.freeze
 
-  before { WebMock.disable_net_connect! }
-  after { WebMock.allow_net_connect! }
+  def setup
+    OdeonUk.token = 'guest-jwt'
+  end
+
+  def teardown
+    OdeonUk.token = nil
+    super
+  end
+
+  def test_sites
+    stub_request(:get, "#{BASE_URL}/sites")
+      .with(headers: HEADERS)
+      .to_return(status: 200, body: sites_json)
+
+    sites = api.sites
+
+    assert_kind_of Array, sites
+    assert_includes sites.first.keys, 'id'
+  end
 
-  describe '#app_init' do
-    subject { described_class.new.app_init }
+  def test_showtimes
+    stub_request(:get, "#{BASE_URL}/showtimes/by-business-date/2026-10-24")
+      .with(query: { 'siteIds' => '824' }, headers: HEADERS)
+      .to_return(status: 200, body: showtimes_json('824'))
 
-    before { stub_post('app-init', nil, app_init_plist) }
+    showtimes = api.showtimes('824', Date.new(2026, 10, 24))
 
-    it 'returns a hash' do
-      subject.class.must_equal Hash
-      subject.keys.must_equal(%w(films offers))
-    end
+    assert_equal %w(businessDate relatedData showtimes), showtimes.keys.sort
   end
 
-  describe '#all_cinemas' do
-    subject { described_class.new.all_cinemas }
+  def test_missing_token_raises_before_request
+    OdeonUk.token = nil
+
+    assert_raises(OdeonUk::AuthenticationError) { api.sites }
+  end
 
-    before { stub_post('all-cinemas', nil, all_cinemas_plist) }
+  def test_rejected_token_raises
+    stub_request(:get, "#{BASE_URL}/sites").to_return(status: 401)
 
-    it 'returns a hash' do
-      subject.class.must_equal Hash
-      subject.keys.must_equal(%w(sites))
-    end
+    assert_raises(OdeonUk::AuthenticationError) { api.sites }
   end
 
-  describe '#showtimes(id)' do
-    subject { described_class.new.film_times(71, 15_130) }
+  def test_server_error_omits_body
+    stub_request(:get, "#{BASE_URL}/sites").to_return(status: 500, body: 'secret')
+
+    error = assert_raises(RuntimeError) { api.sites }
+
+    assert_equal 'Vista HTTP error 500', error.message
+  end
 
-    before do
-      stub_post('film-times',
-                { s: '71', m: '15130' },
-                film_times_plist_random)
-    end
+  private
 
-    it 'returns an array' do
-      subject.class.must_equal Array
-      subject.each { |group| group.keys.must_equal(%w(date attributes)) }
-    end
+  def api
+    OdeonUk::Internal::ApiResponse.new
   end
 end

data/test/lib/odeon_uk/internal/fixture_shape_test.rb

@@ -0,0 +1,14 @@
+require_relative '../../../test_helper'
+
+class FixtureShapeTest < Minitest::Test
+  include ApiFixturesHelper
+  include ApiShapes
+
+  def test_sites_fixture_matches_shape
+    assert_sites_shape(JSON.parse(sites_json))
+  end
+
+  def test_showtimes_fixture_matches_shape
+    assert_showtimes_shape(JSON.parse(showtimes_json('824')))
+  end
+end

data/test/lib/odeon_uk/internal/guest_token_test.rb

@@ -0,0 +1,84 @@
+require_relative '../../../test_helper'
+require 'base64'
+require 'tmpdir'
+
+class OdeonUk::Internal::GuestTokenTest < Minitest::Test
+  def setup
+    @directory = Dir.mktmpdir('odeon-guest-token')
+  end
+
+  def teardown
+    FileUtils.remove_entry(@directory)
+    OdeonUk.token = nil
+  end
+
+  def test_fetch_returns_token_from_page_data
+    token = token_expiring_at(Time.now + 3600)
+    curl = fake_curl("#{page_with(token)}\n200")
+
+    assert_equal token, guest_token(curl).fetch
+  end
+
+  def test_fetch_rejects_expired_token
+    curl = fake_curl("#{page_with(token_expiring_at(Time.now - 60))}\n200")
+
+    assert_raises(OdeonUk::AuthenticationError) { guest_token(curl).fetch }
+  end
+
+  def test_fetch_rejects_page_without_page_data
+    curl = fake_curl("<html></html>\n200")
+
+    assert_raises(OdeonUk::AuthenticationError) { guest_token(curl).fetch }
+  end
+
+  def test_fetch_rejects_redirect_to_queue
+    curl = fake_curl("\n302")
+
+    assert_raises(OdeonUk::AuthenticationError) { guest_token(curl).fetch }
+  end
+
+  def test_fetch_rejects_failed_command
+    curl = fake_curl('', exit_status: 7)
+
+    assert_raises(OdeonUk::AuthenticationError) { guest_token(curl).fetch }
+  end
+
+  def test_fetch_explains_missing_executable
+    error = assert_raises(OdeonUk::AuthenticationError) do
+      guest_token(File.join(@directory, 'missing')).fetch
+    end
+
+    assert_match(/curl-impersonate/, error.message)
+  end
+
+  def test_acquire_token_sets_token
+    token = token_expiring_at(Time.now + 3600)
+
+    OdeonUk.acquire_token!(curl: fake_curl("#{page_with(token)}\n200"))
+
+    assert_equal token, OdeonUk.token
+  end
+
+  private
+
+  def guest_token(curl)
+    OdeonUk::Internal::GuestToken.new(curl: curl)
+  end
+
+  def token_expiring_at(time)
+    payload = Base64.urlsafe_encode64(JSON.generate('exp' => time.to_i), padding: false)
+    "header.#{payload}.signature"
+  end
+
+  def page_with(token)
+    data = { 'api' => { 'apiUrl' => 'https://vwc.odeon.co.uk/WSVistaWebClient', 'authToken' => token } }
+    "<script>\n  window.initialData = #{JSON.generate(data)};\n  window.pageData = [];\n</script>"
+  end
+
+  def fake_curl(output, exit_status: 0)
+    path = File.join(@directory, 'curl-impersonate')
+    File.write(path, "#!#{RbConfig.ruby}\nSTDOUT.write(#{output.dump})\nexit #{exit_status}\n")
+    File.chmod(0o755, path)
+    path
+  end
+end

data/test/lib/odeon_uk/internal/parser/api/showtime_test.rb

@@ -0,0 +1,68 @@
+require_relative '../../../../../test_helper'
+
+class OdeonUk::Internal::Parser::Api::ShowtimeTest < Minitest::Test
+  FILMS = {
+    'HO1' => { 'title' => { 'text' => 'Jailer 2 (Tamil)' } },
+    'HO2' => { 'title' => { 'text' => 'Cine-Excess 2026: Scum Of The Earth' } }
+  }.freeze
+
+  ATTRIBUTES = {
+    '1' => { 'shortName' => { 'text' => 'TamilA' }, 'name' => { 'text' => 'Tamil (Audio)' } },
+    '2' => { 'shortName' => { 'text' => 'EnglishSub' }, 'name' => { 'text' => 'English (Sub)' } },
+    '3' => { 'shortName' => { 'text' => 'IMAX' }, 'name' => { 'text' => 'IMAX' } },
+    '4' => { 'shortName' => { 'text' => 'OpenCapt' }, 'name' => { 'text' => 'Open Captioned' } },
+    '5' => { 'shortName' => { 'text' => 'Wheelchair' }, 'name' => { 'text' => 'Wheelchair Accessible' } }
+  }.freeze
+
+  def test_to_hash
+    expected = {
+      booking_url: 'https://www.odeon.co.uk/ticketing/seat-picker/?showtimeId=824-1',
+      dimension: '2d',
+      festival: nil,
+      film_name: 'Jailer 2',
+      language: nil,
+      starting_at: Time.utc(2026, 10, 24, 17, 30),
+      variant: []
+    }
+
+    assert_equal expected, parse
+  end
+
+  def test_3d_glasses
+    assert_equal '3d', parse(requires3d: true)[:dimension]
+  end
+
+  def test_audio_language
+    assert_equal 'Tamil', parse(attribute_ids: %w(1 2 3 5))[:language]
+  end
+
+  def test_maps_known_attributes_to_variants
+    assert_equal %w(subtitled imax), parse(attribute_ids: %w(1 2 3 5))[:variant]
+  end
+
+  def test_festival_moves_from_title_to_attribute
+    showtime = parse(film_id: 'HO2')
+
+    assert_equal Cinebase::Festival.new(name: 'Cine-Excess', year: 2026), showtime[:festival]
+    assert_equal 'Scum Of The Earth', showtime[:film_name]
+  end
+
+  def test_open_captions_and_subtitles_are_one_variant
+    assert_equal %w(subtitled), parse(attribute_ids: %w(2 4))[:variant]
+  end
+
+  private
+
+  def parse(attribute_ids: [], requires3d: false, film_id: 'HO1')
+    data = {
+      'id' => '824-1',
+      'filmId' => film_id,
+      'schedule' => { 'startsAt' => '2026-10-24T18:30:00+01:00' },
+      'attributeIds' => attribute_ids,
+      'requires3dGlasses' => requires3d
+    }
+    OdeonUk::Internal::Parser::Api::Showtime.new(
+      data, films: FILMS, attributes: ATTRIBUTES
+    ).to_hash
+  end
+end

data/test/lib/odeon_uk/internal/title_sanitizer_test.rb

@@ -1,121 +1,141 @@
 require_relative '../../../test_helper'
 
-describe OdeonUk::Internal::TitleSanitizer do
-  let(:described_class) { OdeonUk::Internal::TitleSanitizer }
+class OdeonUk::Internal::TitleSanitizerTest < Minitest::Test
+  def test_removes_2d
+    assert_sanitized 'Iron Man 3', 'Iron Man 3 2D'
+  end
 
-  describe '#sanitized' do
-    subject { described_class.new(title).sanitized }
+  def test_removes_3d
+    assert_sanitized 'Iron Man 3', 'Iron Man 3 3D'
+  end
 
-    describe 'with 2d in title' do
-      let(:title) { 'Iron Man 3 2D' }
+  def test_removes_autism_prefix
+    assert_sanitized 'Planes', 'Autism Friendly Screening - Planes'
+  end
 
-      it 'removes dimension' do
-        subject.must_equal('Iron Man 3')
-      end
-    end
+  def test_bolshoi
+    assert_sanitized 'Bolshoi: Spartacus', 'Bolshoi - Spartacus (Live)'
+  end
 
-    describe 'with 3d in title' do
-      let(:title) { 'Iron Man 3 3D' }
+  def test_removes_cinemagic_prefix
+    assert_sanitized 'Echo Planet', 'Cinemagic 2013 - Echo Planet'
+  end
 
-      it 'removes dimension' do
-        subject.must_equal('Iron Man 3')
-      end
-    end
+  def test_globe_on_screen
+    assert_sanitized 'Globe: Twelfth Night', 'Globe On Screen: Twelfth Night'
+  end
 
-    describe 'Austism screening' do
-      let(:title) { 'Autism Friendly Screening - Planes' }
+  def test_met_opera
+    assert_sanitized 'Met Opera: Eugene Onegin 2013', 'Met Opera - Eugene Onegin 2013'
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('Planes')
-      end
-    end
+  def test_met_opera_season
+    assert_sanitized 'Met Opera: La Fanciulla del West',
+                     'Met Opera 2026-27: La Fanciulla del West'
+  end
 
-    describe 'Bolshoi screeening' do
-      let(:title) { 'Bolshoi - Spartacus (Live)' }
+  def test_nt_live
+    assert_sanitized 'National Theatre: War Horse', 'NT Live - War Horse'
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('Bolshoi: Spartacus')
-      end
-    end
+  def test_national_theatre_encore
+    assert_sanitized 'National Theatre: Frankenstein',
+                     'National Theatre Live - Frankenstein (Encore Screening)'
+  end
 
-    describe 'Cinemagic screeening' do
-      let(:title) { 'Cinemagic 2013 - Echo Planet' }
+  def test_roh
+    assert_sanitized 'Royal Opera House: Carmen', 'ROH - Carmen'
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('Echo Planet')
-      end
-    end
+  def test_rbo_season
+    assert_sanitized 'Royal Ballet and Opera: Swan Lake',
+                     'RBO Cinema Season 2026-27: Swan Lake'
+  end
 
-    describe 'Globe on Screen screeening' do
-      let(:title) { 'Globe On Screen: Twelfth Night' }
+  def test_short_rbo_season
+    assert_sanitized "Royal Ballet and Opera: Alice's Adventures in Wonderland",
+                     "RBO 2026-27: Alice's Adventures in Wonderland"
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('Globe: Twelfth Night')
-      end
-    end
+  def test_rsc
+    assert_sanitized 'Royal Shakespeare Company: Richard II', 'Richard II - RSC Live 2013'
+  end
 
-    describe 'Met Opera screeening' do
-      let(:title) { 'Met Opera - Eugene Onegin 2013' }
+  def test_removes_ukjff_prefix
+    assert_sanitized 'From Cable Street To Brick Lane',
+                     'UKJFF - From Cable Street To Brick Lane'
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('Met Opera: Eugene Onegin 2013')
-      end
-    end
+  def test_removes_singalong
+    assert_sanitized 'Frozen', 'Frozen Sing-a-long'
+  end
 
-    describe 'NT Live screeening' do
-      let(:title) { 'NT Live - War Horse' }
+  def test_html_ampersands
+    assert_sanitized 'Fast & Furious 7', 'Fast &amp; Furious 7'
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('National Theatre: War Horse')
-      end
-    end
+  def test_removes_language_suffix
+    assert_sanitized 'Jailer 2', 'Jailer 2 (Telugu)'
+  end
+
+  def test_removes_encore_suffix
+    assert_sanitized 'Avengers Endgame', 'Avengers Endgame: Encore'
+  end
+
+  def test_keeps_sing_along_within_title
+    assert_sanitized 'Bebefinn Sing-Along Movie', 'Bebefinn Sing-Along Movie'
+  end
+
+  def test_removes_dubbed
+    assert_sanitized 'Arrietty', 'Arrietty (Dubbed)'
+  end
 
-    describe 'National Theatre screeening' do
-      let(:title) { 'National Theatre Live - Frankenstein (Encore Screening)' }
+  def test_removes_subbed
+    assert_sanitized 'Arrietty', 'Arrietty (Subbed)'
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('National Theatre: Frankenstein')
-      end
-    end
+  def test_removes_english_dub
+    assert_sanitized 'Kung Fu Soccer', 'Kung Fu Soccer (English Dub)'
+  end
 
-    describe 'ROH screeening' do
-      let(:title) { 'Autism Friendly Screening - Planes' }
+  def test_removes_subtitle_description
+    assert_sanitized 'Kung Fu Soccer', 'Kung Fu Soccer (Mandarin with EN/CH subtitles)'
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('Planes')
-      end
-    end
+  def test_removes_q_and_a
+    assert_sanitized 'NAZA', 'NAZA + Q&A'
+  end
 
-    describe 'RSC screeening' do
-      let(:title) { 'Richard II - RSC Live 2013' }
+  def test_removes_in_person_q_and_a
+    assert_sanitized "Charlie Shaw's Revenge", "Charlie Shaw's Revenge + In-Person Q&A"
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('Royal Shakespeare Company: Richard II')
-      end
-    end
+  def test_removes_festival_prefix
+    assert_sanitized 'Scum Of The Earth', 'Cine-Excess 2026: Scum Of The Earth'
+  end
 
-    describe 'UK Jewish FF screeening' do
-      let(:title) { 'UKJFF - From Cable Street To Brick Lane' }
+  def test_removes_anniversary
+    assert_sanitized 'SCREAM', 'SCREAM (30th Anniversary)'
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('From Cable Street To Brick Lane')
-      end
-    end
+  def test_world_tour_is_not_capitalised
+    assert_sanitized "ENHYPEN World Tour 'BLOOD SAGA'", "ENHYPEN WORLD TOUR 'BLOOD SAGA'"
+  end
 
-    describe 'singalong screeening' do
-      let(:title) { 'Frozen Sing-a-long' }
+  def test_keeps_titles_with_their_own_subtitles
+    [
+      'Harry Potter and the Deathly Hallows: Part 1',
+      'Spider-Man: Brand New Day',
+      'Hadestown: The Musical',
+      'Rammstein - Live in Mexico City',
+      'Ozzy & Black Sabbath: Back to the Beginning',
+      "BTS 'ARIRANG' IN BUENOS AIRES: LIVE VIEWING"
+    ].each { |title| assert_sanitized title, title }
+  end
 
-      it 'removes prefix' do
-        subject.must_equal('Frozen')
-      end
-    end
-
-    describe 'HTML ampersands' do
-      let(:title) { 'Fast &amp; Furious 7' }
+  private
 
-      it 'removes prefix' do
-        subject.must_equal('Fast & Furious 7')
-      end
-    end
+  def assert_sanitized(expected, title)
+    assert_equal expected, OdeonUk::Internal::TitleSanitizer.new(title).sanitized
   end
 end