odeon_uk 4.0.0 → 5.0.0

data/test/lib/odeon_uk/performance_test.rb

@@ -1,149 +1,150 @@
 require_relative '../../test_helper'
 
-describe OdeonUk::Performance do
-  let(:described_class) { OdeonUk::Performance }
-  let(:api_response) { FakeApiResponse.new }
-
-  before { WebMock.disable_net_connect! }
-  after { WebMock.allow_net_connect! }
-
-  describe '.at(cinema_id)' do
-    subject { described_class.at(71) }
-
-    it 'returns an array of performances' do
-      OdeonUk::Internal::ApiResponse.stub :new, api_response do
-        subject.must_be_instance_of(Array)
-        subject.each do |element|
-          element.must_be_instance_of(described_class)
-        end
-      end
-    end
+class OdeonUk::PerformanceTest < Minitest::Test
+  DATE = Date.new(2026, 10, 24)
 
-    it 'returns at least a sensible number' do
-      OdeonUk::Internal::ApiResponse.stub :new, api_response do
-        subject.count.must_be :>, 110
-      end
-    end
+  def setup
+    @api_response = FakeApiResponse.new
   end
 
-  describe '.new' do
-    subject { described_class.new(options) }
-
-    describe 'simple' do
-      let(:options) do
-        {
-          film_name:   'The Big Short',
-          cinema_id:   71,
-          cinema_name: 'Brighton',
-          starting_at: Time.utc(2013, 9, 12, 11, 0)
-        }
-      end
-
-      it 'sets cinema name and film name' do
-        subject.film_name.must_equal 'The Big Short'
-        subject.cinema_name.must_equal 'Brighton'
-      end
-
-      it 'booking url, dimension & varient are set to defaults' do
-        subject.booking_url.must_equal nil
-        subject.dimension.must_equal '2d'
-        subject.variant.must_equal []
-      end
-    end
+  def test_at_returns_performances
+    performances = performances_at(824)
+
+    assert(performances.all? { |p| p.instance_of?(OdeonUk::Performance) })
+    assert_equal 6, performances.count
   end
 
-  describe '#dimension' do
-    let(:options) do
-      {
-        film_name:   'Ant Man',
-        dimension:   '3d',
-        cinema_id:   71,
-        cinema_name: 'Brighton',
-        starting_at: Time.utc(2013, 9, 12, 11, 0)
-      }
-    end
+  def test_at_accepts_string_id
+    assert_equal 6, performances_at('824').count
+  end
 
-    subject { described_class.new(options).dimension }
+  def test_at_sets_cinema_details
+    performances = performances_at(824)
 
-    it 'returns 2d or 3d' do
-      subject.must_be_instance_of(String)
-      subject.must_equal '3d'
-    end
+    assert_equal ['824'], performances.map(&:cinema_id).uniq
+    assert_equal ['Brighton'], performances.map(&:cinema_name).uniq
   end
 
-  describe '#starting_at' do
-    subject { described_class.new(options).starting_at }
+  def test_at_parses_first_performance
+    performance = performances_at(824).first
 
-    describe 'with utc time' do
-      let(:options) do
-        {
-          film_name:   'Steve Jobs',
-          cinema_id:   71,
-          cinema_name: 'Brighton',
-          starting_at: Time.utc(2013, 9, 12, 11, 0)
-        }
-      end
+    assert_equal 'The Example Film', performance.film_name
+    assert_equal Time.utc(2026, 10, 24, 8, 0), performance.starting_at
+    assert_equal '2d', performance.dimension
+    assert_equal %w(audio_described), performance.variant
+    assert_equal 'https://www.odeon.co.uk/ticketing/seat-picker/?showtimeId=824-1001',
+                 performance.booking_url
+  end
 
-      it 'returns UTC time' do
-        subject.must_be_instance_of Time
-        subject.must_equal Time.utc(2013, 9, 12, 11, 0)
-      end
-    end
+  def test_at_parses_3d_imax
+    performance = performances_at(824)[1]
 
-    describe 'with non-utc time' do
-      let(:options) do
-        {
-          film_name:   'Steve Jobs',
-          cinema_id:   71,
-          cinema_name: 'Brighton',
-          starting_at: Time.new(2013, 9, 12, 11, 0)
-        }
-      end
-
-      it 'returns UTC time' do
-        subject.must_be_instance_of Time
-        subject.must_equal Time.utc(2013, 9, 12, 10, 0)
-        subject.utc?.must_equal(true)
-      end
-    end
+    assert_equal '3d', performance.dimension
+    assert_equal %w(imax), performance.variant
   end
 
-  describe '#showing_on' do
-    let(:options) do
-      {
-        film_name:   'The Hunger Games',
-        cinema_id:   71,
-        cinema_name: 'Brighton',
-        starting_at: Time.utc(2013, 9, 12, 11, 0)
-      }
-    end
+  def test_at_returns_language_and_subtitles
+    performances = performances_at(824)
+    tamil = performances[3]
+    korean = performances[2]
 
-    subject { described_class.new(options).showing_on }
+    assert_equal 'Imaginary Picture', tamil.film_name
+    assert_equal 'Tamil', tamil.language
+    assert tamil.subtitled?
+    assert_equal 'Korean', korean.language
+    assert_equal %w(arts subtitled), korean.variant
+  end
 
-    it 'returns date of showing' do
-      subject.must_be_instance_of(Date)
-      subject.must_equal Date.new(2013, 9, 12)
-    end
+  def test_at_treats_open_captions_as_subtitled
+    kids = performances_at(824)[4]
+
+    assert_nil kids.language
+    assert_equal %w(kids subtitled), kids.variant
+    assert kids.subtitled?
   end
 
-  describe '#variant' do
-    subject { described_class.new(options).variant }
+  def test_at_keeps_after_midnight_on_next_utc_day
+    assert_equal Time.utc(2026, 10, 24, 23, 15), performances_at(824).last.starting_at
+  end
 
-    let(:options) do
-      {
-        film_name:   'Carol',
-        cinema_id:   71,
-        cinema_name: 'Brighton',
-        starting_at: Time.utc(2013, 9, 12, 11, 0),
-        variant:     %w(Subtitles Senior)
-      }
-    end
+  def test_at_requests_each_date_in_range
+    to = DATE + 2
+
+    with_fake_api { OdeonUk::Performance.at(824, from: DATE, to: to) }
 
-    it 'is an alphabetically ordered array of lower-cased strings' do
-      subject.must_be_instance_of Array
-      subject.each { |element| element.must_be_instance_of String }
-      subject.must_equal %w(senior subtitles)
+    assert_equal (DATE..to).to_a, @api_response.requested_dates
+  end
+
+  def test_at_rejects_range_ending_before_start
+    assert_raises(ArgumentError) do
+      OdeonUk::Performance.at(824, from: DATE, to: DATE - 1)
     end
   end
 
+  def test_new_sets_names
+    performance = OdeonUk::Performance.new(options)
+
+    assert_equal 'The Big Short', performance.film_name
+    assert_equal 'Brighton', performance.cinema_name
+  end
+
+  def test_new_sets_defaults
+    performance = OdeonUk::Performance.new(options)
+
+    assert_nil performance.booking_url
+    assert_nil performance.festival
+    assert_equal '2d', performance.dimension
+    assert_nil performance.language
+    refute performance.subtitled?
+    assert_equal [], performance.variant
+  end
+
+  def test_language
+    assert_equal 'Tamil', OdeonUk::Performance.new(options(language: 'Tamil')).language
+  end
+
+  def test_festival
+    festival = Cinebase::Festival.new(name: 'Cine-Excess', year: 2026)
+    performance = OdeonUk::Performance.new(options(festival: festival))
+
+    assert_equal festival, performance.festival
+  end
+
+  def test_subtitled
+    assert OdeonUk::Performance.new(options(variant: %w(subtitled))).subtitled?
+  end
+
+  def test_starting_at_converts_local_time_to_utc
+    starting_at = OdeonUk::Performance.new(
+      options(starting_at: Time.new(2013, 9, 12, 11, 0))
+    ).starting_at
+
+    assert_equal Time.utc(2013, 9, 12, 10, 0), starting_at
+    assert starting_at.utc?
+  end
+
+  def test_variant_is_sorted_and_lower_case
+    performance = OdeonUk::Performance.new(options(variant: %w(Subtitled Senior)))
+
+    assert_equal %w(senior subtitled), performance.variant
+  end
+
+  private
+
+  def options(overrides = {})
+    {
+      film_name:   'The Big Short',
+      cinema_id:   '824',
+      cinema_name: 'Brighton',
+      starting_at: Time.utc(2013, 9, 12, 11, 0)
+    }.merge(overrides)
+  end
+
+  def performances_at(cinema_id)
+    with_fake_api { OdeonUk::Performance.at(cinema_id, from: DATE, to: DATE) }
+  end
+
+  def with_fake_api(&block)
+    OdeonUk::Internal::ApiResponse.stub(:new, @api_response, &block)
+  end
 end

data/test/lib/odeon_uk/version_test.rb

@@ -1,7 +1,7 @@
 require_relative '../../test_helper'
 
-describe OdeonUk do
-  it 'must be defined' do
-    OdeonUk::VERSION.wont_be_nil
+class OdeonUk::VersionTest < Minitest::Test
+  def test_version_is_defined
+    refute_nil OdeonUk::VERSION
   end
 end

data/test/live/api_shape_test.rb

@@ -0,0 +1,19 @@
+require_relative 'live_helper'
+
+class LiveApiShapeTest < Minitest::Test
+  include ApiShapes
+
+  def test_sites_are_readable
+    assert_sites_shape('sites' => api.sites)
+  end
+
+  def test_showtimes_are_readable
+    assert_showtimes_shape(api.showtimes('824', Date.today + 1))
+  end
+
+  private
+
+  def api
+    OdeonUk::Internal::ApiResponse.new
+  end
+end

data/test/live/integration_test.rb

@@ -0,0 +1,21 @@
+require_relative 'live_helper'
+
+class LiveCinemaTest < Minitest::Test
+  def test_all_returns_cinemas
+    cinemas = OdeonUk::Cinema.all
+
+    assert(cinemas.all? { |cinema| cinema.instance_of?(OdeonUk::Cinema) })
+    assert_operator cinemas.size, :>, 90
+    assert_equal 'Brighton', cinemas.detect { |cinema| cinema.id == '824' }.name
+  end
+end
+
+class LivePerformanceTest < Minitest::Test
+  def test_at_returns_performances
+    tomorrow = Date.today + 1
+    performances = OdeonUk::Performance.at(824, from: tomorrow, to: tomorrow)
+
+    assert(performances.all? { |p| p.instance_of?(OdeonUk::Performance) })
+    assert_operator performances.count, :>, 10
+  end
+end

data/test/live/live_helper.rb

@@ -0,0 +1,11 @@
+require 'minitest/autorun'
+require 'minitest/reporters'
+
+Minitest::Reporters.use! [
+  Minitest::Reporters::DefaultReporter.new(color: true)
+]
+
+require File.expand_path('../../../lib/odeon_uk.rb', __FILE__)
+require_relative '../support/api_shapes'
+
+OdeonUk.token = ENV.fetch('ODEON_TOKEN') { OdeonUk.acquire_token! }

data/test/package_test.rb

@@ -0,0 +1,56 @@
+# Run separately after building: ODEON_PACKAGE=pkg/...gem bundle exec ruby test/package_test.rb
+require "minitest/autorun"
+require "rubygems/installer"
+require "tmpdir"
+require "fileutils"
+require "open3"
+require "base64"
+require "json"
+
+class PlatformPackageTest < Minitest::Test
+  def setup
+    @directory = Dir.mktmpdir("odeon-package-test")
+    @spec = Gem::Installer.at(
+      ENV.fetch("ODEON_PACKAGE"), install_dir: @directory, ignore_dependencies: true
+    ).install
+    @vendor = File.join(@spec.full_gem_path, "vendor", "curl-impersonate")
+    @binary = File.join(@vendor, "bin", "curl-impersonate")
+  end
+
+  def teardown
+    FileUtils.remove_entry(@directory)
+  end
+
+  def test_installs_runnable_executable_with_notices_and_provenance
+    assert File.executable?(@binary)
+    output, status = Open3.capture2(@binary, "--version")
+    assert status.success?
+    assert_includes output, "curl"
+    assert File.file?(File.join(@vendor, "licenses", "LICENSE_CURL"))
+    assert_includes File.read(File.join(@vendor, "SOURCE")), "2.2.3"
+  end
+
+  def test_acquires_token_with_gem_local_executable_and_no_curl_on_path
+    payload = Base64.urlsafe_encode64(JSON.generate("exp" => Time.now.to_i + 3600), padding: false)
+    token = "header.#{payload}.signature"
+    data = { "api" => { "authToken" => token } }
+    page = "<script>\nwindow.initialData = #{JSON.generate(data)};\n</script>\n200"
+    # Substitute only the network response, not the installed package's path resolution.
+    File.write(@binary, "#!#{RbConfig.ruby}\nSTDOUT.write(#{page.dump})\n")
+    output, error, status = Open3.capture3(
+      { "PATH" => @directory, "RUBYOPT" => nil, "BUNDLER_SETUP" => nil,
+        "GEM_PATH" => Gem.path.join(File::PATH_SEPARATOR) }, RbConfig.ruby,
+      "-I#{File.join(@spec.full_gem_path, 'lib')}", *cinebase_load_path, "-rodeon_uk",
+      "-e", "print OdeonUk.acquire_token!"
+    )
+    assert status.success?, error
+    assert_equal token, output
+  end
+
+  private
+
+  # The package is installed without dependencies, so load the bundle's cinebase.
+  def cinebase_load_path
+    Gem.loaded_specs.fetch("cinebase").full_require_paths.map { |path| "-I#{path}" }
+  end
+end

data/test/support/api_fixtures_helper.rb

@@ -2,40 +2,15 @@
 module ApiFixturesHelper
   private
 
-  def all_cinemas_plist
-    read_fixture('api/all_cinemas')
+  def sites_json
+    read_fixture('api/sites')
   end
 
-  def app_init_plist
-    read_fixture('api/app_init')
-  end
-
-  def film_times_plist(cinema_id, film_id)
-    read_fixture("api/film_times/#{cinema_id}-#{film_id}")
-  end
-
-  def film_times_plist_random
-    read_fixture("api/film_times/#{film_times_plist_names(71).sample}")
-  end
-
-  def film_times_plist_names(cinema_id)
-    Dir.entries(File.expand_path('../../fixtures/api/film_times', __FILE__))
-       .reject { |filename| !filename.match(/\A#{cinema_id}-/) }
-       .map { |filename| filename.gsub('.plist', '') }
-  end
-
-  def parse(content)
-    plist = CFPropertyList::List.new(data: content).value
-    CFPropertyList.native_types(plist).fetch('data', {})
+  def showtimes_json(cinema_id)
+    read_fixture("api/showtimes-#{cinema_id}")
   end
 
   def read_fixture(filepath)
-    File.read(File.expand_path("../../fixtures/#{filepath}.plist", __FILE__))
-  end
-
-  def stub_post(site_path, request_body, response_body)
-    url      = "https://api.odeon.co.uk/2.1/api/#{site_path}"
-    response = { status: 200, body: response_body, headers: {} }
-    stub_request(:post, url).with(body: request_body).to_return(response)
+    File.read(File.expand_path("../../fixtures/#{filepath}.json", __FILE__))
   end
 end

data/test/support/api_shapes.rb

@@ -0,0 +1,46 @@
+require 'time'
+
+# The parts of Vista responses the gem reads. Checked against the hand-written
+# fixtures and, in the live suite, against real responses held only in memory.
+module ApiShapes
+  private
+
+  def assert_sites_shape(data)
+    sites = data.fetch('sites')
+    refute_empty sites
+    sites.each do |site|
+      assert_match(/\A\d{3}\z/, site.fetch('id'))
+      assert_kind_of String, site.dig('name', 'text')
+      address = site.fetch('contactDetails').fetch('address')
+      %w(line1 line2 city).each do |key|
+        assert_kind_of String, address.fetch(key), "site #{site['id']} #{key}"
+      end
+    end
+  end
+
+  def assert_showtimes_shape(data)
+    related = data.fetch('relatedData')
+    films = related.fetch('films').to_h { |film| [film.fetch('id'), film] }
+    attributes = related.fetch('attributes').to_h do |attribute|
+      [attribute.fetch('id'), attribute]
+    end
+
+    films.each_value { |film| assert_kind_of String, film.dig('title', 'text') }
+    attributes.each_value do |attribute|
+      assert_kind_of String, attribute.dig('shortName', 'text')
+      assert_kind_of String, attribute.dig('name', 'text')
+    end
+
+    showtimes = data.fetch('showtimes')
+    refute_empty showtimes
+    showtimes.each do |showtime|
+      assert_kind_of String, showtime.fetch('id')
+      assert_includes films.keys, showtime.fetch('filmId')
+      assert_kind_of Time, Time.iso8601(showtime.fetch('schedule').fetch('startsAt'))
+      assert_includes [true, false], showtime.fetch('requires3dGlasses')
+      showtime.fetch('attributeIds').each do |id|
+        assert_includes attributes.keys, id
+      end
+    end
+  end
+end

data/test/support/fake_api_response.rb

@@ -3,15 +3,18 @@ require_relative 'api_fixtures_helper'
 class FakeApiResponse
   include ApiFixturesHelper
 
-  def app_init
-    parse(app_init_plist)
+  attr_reader :requested_dates
+
+  def initialize
+    @requested_dates = []
   end
 
-  def all_cinemas
-    parse(all_cinemas_plist)
+  def sites
+    JSON.parse(sites_json).fetch('sites')
   end
 
-  def film_times(cinema_id, film_id)
-    parse(film_times_plist(cinema_id, film_id))
+  def showtimes(cinema_id, date)
+    @requested_dates << date
+    JSON.parse(showtimes_json(cinema_id))
   end
 end

data/test/test_helper.rb

@@ -1,7 +1,10 @@
-require 'codeclimate-test-reporter'
-CodeClimate::TestReporter.start
+require 'simplecov'
+SimpleCov.start do
+  add_filter '/test/'
+end
 
 require 'minitest/autorun'
+require 'minitest/mock'
 require 'minitest/reporters'
 
 Minitest::Reporters.use! [
@@ -9,9 +12,9 @@ Minitest::Reporters.use! [
 ]
 
 require 'webmock/minitest'
-WebMock.allow_net_connect!
 
 require File.expand_path('../../lib/odeon_uk.rb', __FILE__)
 
 require_relative 'support/api_fixtures_helper'
+require_relative 'support/api_shapes'
 require_relative 'support/fake_api_response'