odeon_uk 1.1.5 → 2.0.0

data/test/lib/odeon_uk/internal/film_with_screenings_parser_test.rb

@@ -1,171 +1,127 @@
 require_relative '../../../test_helper'
 
 describe OdeonUk::Internal::FilmWithScreeningsParser do
+  let(:described_class) { OdeonUk::Internal::FilmWithScreeningsParser }
 
   describe '#film_name' do
-    subject { OdeonUk::Internal::FilmWithScreeningsParser.new(film_html).film_name }
+    subject { described_class.new(film_html).film_name }
 
-    describe 'passed valid film html with simple name' do
-      let(:film_html) { read_film_html('about-time') }
+    describe 'passed first film html' do
+      let(:film_html) { read_film_html('brighton/film_first') }
 
-      it 'returns the film name' do
-        subject.must_equal('About Time')
+      it 'returns film name' do
+        subject.must_equal 'A Most Wanted Man'
       end
     end
 
-    describe 'passed valid film html with 2d name' do
-      let(:film_html) { read_film_html('star-trek-into-darkness-2d') }
+    describe 'passed last film html' do
+      let(:film_html) { read_film_html('brighton/film_last') }
 
-      it 'returns the film name' do
-        subject.must_equal('Star Trek Into Darkness')
+      it 'returns film name' do
+        subject.must_equal 'The Riot Club'
       end
     end
+  end
 
-    describe 'passed valid film html with autism text' do
-      let(:film_html) { read_film_html('autism-friendly-planes') }
-
-      it 'returns the film name' do
-        subject.must_equal('Planes')
-      end
-    end
-
-    describe 'passed valid film html with ROH live screening' do
-      let(:film_html) { read_film_html('royal-opera-house-turandot') }
-
-      it 'returns the film name' do
-        subject.must_equal('Royal Opera House: Turandot 2013')
-      end
-    end
-
-    describe 'passed valid film html with Met Opera screening' do
-      let(:film_html) { read_film_html('met-opera-eugene-onegin') }
-
-      it 'returns the film name' do
-        subject.must_equal('Met Opera: Eugene Onegin 2013')
-      end
-    end
-
-    describe 'passed valid film html with Met Opera screening' do
-      let(:film_html) { read_film_html('cinemagic-echo-planet') }
-
-      it 'returns the film name' do
-        subject.must_equal('Echo Planet')
-      end
-    end
-
-    describe 'passed valid film html with UK Jewish Film Festival' do
-      let(:film_html) { read_film_html('ukjff-from-cable-street-to-brick-lane') }
-
-      it 'returns the film name' do
-        subject.must_equal('From Cable Street To Brick Lane')
-      end
-    end
+  describe '#to_a' do
+    subject { described_class.new(film_html).to_a }
 
-    describe 'passed valid film html with NT Encore' do
-      let(:film_html) { read_film_html('national-theatre-live-frankenstein') }
+    describe 'passed first film html' do
+      let(:film_html) { read_film_html('brighton/film_first') }
 
-      it 'returns the film name' do
-        subject.must_equal('National Theatre: Frankenstein')
+      it 'returns an array of hashes of screening attributes' do
+        subject.must_be_instance_of Array
+        subject.each do |hash|
+          hash[:booking_url].must_match 'https://www.odeon.co.uk/'
+          hash[:dimension].must_match(/[23]d/)
+          hash[:film_name].must_be_instance_of String
+          hash[:time].must_be_instance_of Time
+          hash[:time].zone.must_equal 'UTC'
+        end
       end
-    end
 
-    describe 'passed valid film html with NT Encore' do
-      let(:film_html) { read_film_html('nt-live-war-horse') }
-
-      it 'returns the film name' do
-        subject.must_equal('National Theatre: War Horse')
+      it 'returns the same film title' do
+        first_title = subject[0][:film_name]
+        subject.each do |hash|
+          hash[:film_name].must_equal first_title
+        end
       end
-    end
-
-    describe 'passed valid film html with Bolshoi Ballet' do
-      let(:film_html) { read_film_html('bolshoi-spartacus-live') }
 
-      it 'returns the film name' do
-        subject.must_equal('Bolshoi: Spartacus')
+      it 'returns the correct number of screenings' do
+        subject.count.must_equal 10
       end
     end
 
-    describe 'passed valid film html with Globe' do
-      let(:film_html) { read_film_html('globe-on-screen-twelfth-night') }
-
-      it 'returns the film name' do
-        subject.must_equal('Globe: Twelfth Night')
+    describe 'passed last film html' do
+      let(:film_html) { read_film_html('brighton/film_last') }
+
+      it 'returns an array of hashes of screening attributes' do
+        subject.must_be_instance_of Array
+        subject.each do |hash|
+          hash[:booking_url].must_match 'https://www.odeon.co.uk/'
+          hash[:dimension].must_match(/[23]d/)
+          hash[:film_name].must_be_instance_of String
+          hash[:time].must_be_instance_of Time
+          hash[:time].zone.must_equal 'UTC'
+        end
       end
-    end
 
-    describe 'passed valid film html with RSC' do
-      let(:film_html) { read_film_html('rsc-richard-ii') }
-
-      it 'returns the film name' do
-        subject.must_equal('Royal Shakespeare Company: Richard II')
+      it 'returns at least 1' do
+        subject.count.must_be :>=, 1
       end
     end
-  end
 
-  describe '#showings' do
-    subject { OdeonUk::Internal::FilmWithScreeningsParser.new(film_html).showings }
-
-    describe 'passed valid film html' do
-      let(:film_html) { read_film_html('about-time') }
-
-      it 'returns an hash of variants => array of times' do
-        subject.must_be_instance_of Hash
-        subject.each do |key, value|
-          key.must_equal '2D'
-          value.must_be_instance_of Array
-          value.each do |element|
-            element[0].must_be_instance_of Time
-            element[0].zone.must_equal 'UTC'
-            element[1].must_be_instance_of String
-            element[1].must_match 'http://www.odeon.co.uk/'
-          end
+    describe 'passed imax film html' do
+      let(:film_html) { read_film_html('manchester/film_first_imax') }
+
+      it 'returns an array of hashes of screening attributes' do
+        subject.must_be_instance_of Array
+        subject.each do |hash|
+          hash[:booking_url].must_match 'https://www.odeon.co.uk/'
+          hash[:dimension].must_match(/[23]d/)
+          hash[:film_name].must_be_instance_of String
+          hash[:time].must_be_instance_of Time
+          hash[:time].zone.must_equal 'UTC'
         end
       end
 
-      it 'returns the correct number of screenings' do
-        subject['2D'].count.must_equal 21
+      it 'contains imax in the variant' do
+        variants = subject.map { |hash| hash[:variant] }
+        variants.must_include('imax')
       end
 
-      it 'returns UTC times for showings' do
-        # about times are from British Summer Time UTC+1
-        # the actual show time is 20:30 from the fixture
-        subject['2D'].last[0].must_equal Time.utc(2013, 9, 19, 19, 30, 0)
+      it 'returns at least 1' do
+        subject.count.must_be :>=, 1
       end
     end
 
-    describe 'passed valid film html for multi variants' do
-      let(:film_html) { read_film_html('thor-the-dark-world', 'manchester') }
-
-      it 'returns an hash of variants => array of times' do
-        subject.must_be_instance_of Hash
-        subject.keys.must_equal ['2D', 'IMAX 3D', '3D']
-        subject.values.each do |value|
-          value.must_be_instance_of Array
-          value.each do |element|
-            element[0].must_be_instance_of Time
-            element[0].zone.must_equal 'UTC'
-            element[1].must_be_instance_of String
-            element[1].must_match 'http://www.odeon.co.uk/'
-          end
+    describe 'passed d-box film html' do
+      let(:film_html) { read_film_html('liverpool_one/film_first_dbox') }
+
+      it 'returns an array of hashes of screening attributes' do
+        subject.must_be_instance_of Array
+        subject.each do |hash|
+          hash[:booking_url].must_match 'https://www.odeon.co.uk/'
+          hash[:dimension].must_match(/[23]d/)
+          hash[:film_name].must_be_instance_of String
+          hash[:time].must_be_instance_of Time
+          hash[:time].zone.must_equal 'UTC'
         end
       end
 
-      it 'returns the correct number of screenings' do
-        subject['2D'].count.must_equal 1
-        subject['3D'].count.must_equal 1
-        subject['IMAX 3D'].count.must_equal 37
+      it 'contains d-box in the variant' do
+        variants = subject.map { |hash| hash[:variant] }
+        variants.must_include('d-box')
       end
 
-      it 'returns UTC times for showings' do
-        # about times are from GMT
-        # the actual show time is 00:01 from the fixture
-        subject['2D'].last[0].must_equal Time.utc(2013, 10, 30, 0, 1, 0)
+      it 'returns at least 1' do
+        subject.count.must_be :>=, 1
       end
     end
   end
 
-  def read_film_html(filename, cinema='brighton')
-    path = "../../../../fixtures/#{cinema}-showtimes"
+  def read_film_html(filename)
+    path = '../../../../fixtures/showtimes'
     File.read(File.expand_path("#{path}/#{filename}.html", __FILE__))
   end
 end

data/test/lib/odeon_uk/internal/showtimes_page_test.rb

@@ -0,0 +1,51 @@
+require_relative '../../../test_helper'
+
+describe OdeonUk::Internal::ShowtimesPage do
+  let(:described_class) { OdeonUk::Internal::ShowtimesPage }
+
+  let(:website) { Minitest::Mock.new }
+
+  before { WebMock.disable_net_connect! }
+
+  describe '#to_a' do
+    subject { described_class.new(71).to_a }
+
+    before do
+      website.expect(:showtimes, brighton_showtimes_html, [71])
+    end
+
+    it 'returns an non-zero array of film screenings html fragments' do
+      OdeonUk::Internal::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.size.must_be :>, 0
+
+        subject.each do |film_html|
+          film_html.must_be_instance_of(String)
+          film_html.size.must_be :>, 0
+        end
+      end
+    end
+
+    it 'returns an array with correct content' do
+      OdeonUk::Internal::Website.stub :new, website do
+        subject.each do |html|
+          html.must_include('class="film-detail') # screenings group
+          html.must_include('class="presentation-info') # title
+          html.must_include('class="WEEK') # a performance
+          html.must_include('data-start="') # start time
+          html.must_include('data-end="') # end time
+        end
+      end
+    end
+  end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def brighton_showtimes_html
+    read_file('../../../../fixtures/showtimes/brighton.html')
+  end
+end

data/test/lib/odeon_uk/internal/title_sanitizer_test.rb

@@ -0,0 +1,105 @@
+require_relative '../../../test_helper'
+
+describe OdeonUk::Internal::TitleSanitizer do
+  let(:described_class) { OdeonUk::Internal::TitleSanitizer }
+
+  describe '#sanitized' do
+    subject { described_class.new(title).sanitized }
+
+    describe 'with 2d in title' do
+      let(:title) { 'Iron Man 3 2D' }
+
+      it 'removes dimension' do
+        subject.must_equal('Iron Man 3')
+      end
+    end
+
+    describe 'with 3d in title' do
+      let(:title) { 'Iron Man 3 3D' }
+
+      it 'removes dimension' do
+        subject.must_equal('Iron Man 3')
+      end
+    end
+
+    describe 'Austism screening' do
+      let(:title) { 'Autism Friendly Screening - Planes' }
+
+      it 'removes prefix' do
+        subject.must_equal('Planes')
+      end
+    end
+
+    describe 'Bolshoi screeening' do
+      let(:title) { 'Bolshoi - Spartacus (Live)' }
+
+      it 'removes prefix' do
+        subject.must_equal('Bolshoi: Spartacus')
+      end
+    end
+
+    describe 'Cinemagic screeening' do
+      let(:title) { 'Cinemagic 2013 - Echo Planet' }
+
+      it 'removes prefix' do
+        subject.must_equal('Echo Planet')
+      end
+    end
+
+    describe 'Globe on Screen screeening' do
+      let(:title) { 'Globe On Screen: Twelfth Night' }
+
+      it 'removes prefix' do
+        subject.must_equal('Globe: Twelfth Night')
+      end
+    end
+
+    describe 'Met Opera screeening' do
+      let(:title) { 'Met Opera - Eugene Onegin 2013' }
+
+      it 'removes prefix' do
+        subject.must_equal('Met Opera: Eugene Onegin 2013')
+      end
+    end
+
+    describe 'NT Live screeening' do
+      let(:title) { 'NT Live - War Horse' }
+
+      it 'removes prefix' do
+        subject.must_equal('National Theatre: War Horse')
+      end
+    end
+
+    describe 'National Theatre screeening' do
+      let(:title) { 'National Theatre Live - Frankenstein (Encore Screening)' }
+
+      it 'removes prefix' do
+        subject.must_equal('National Theatre: Frankenstein')
+      end
+    end
+
+    describe 'ROH screeening' do
+      let(:title) { 'Autism Friendly Screening - Planes' }
+
+      it 'removes prefix' do
+        subject.must_equal('Planes')
+      end
+    end
+
+    describe 'RSC screeening' do
+      let(:title) { 'Richard II - RSC Live 2013' }
+
+      it 'removes prefix' do
+        subject.must_equal('Royal Shakespeare Company: Richard II')
+      end
+    end
+
+    describe 'UK Jewish FF screeening' do
+      let(:title) { 'UKJFF - From Cable Street To Brick Lane' }
+
+      it 'removes prefix' do
+        subject.must_equal('From Cable Street To Brick Lane')
+      end
+    end
+  end
+end

data/test/lib/odeon_uk/internal/website_test.rb

@@ -0,0 +1,59 @@
+require_relative '../../../test_helper'
+
+describe OdeonUk::Internal::Website do
+  let(:described_class) { OdeonUk::Internal::Website }
+
+  describe '#cinema(id)' do
+    subject { described_class.new.cinema(71) }
+
+    before { stub_get('cinemas/odeon/71/', brighton_cinema_html) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+
+  describe '#sitemap' do
+    subject { described_class.new.sitemap }
+
+    before { stub_get('sitemap/', sitemap_html) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+
+  describe '#showtimes(id)' do
+    subject { described_class.new.showtimes(71) }
+
+    before { stub_get('showtimes/week/71/?siteId=71', brighton_showtimes_html) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+
+  private
+
+  def brighton_cinema_html
+    read_file('../../../../fixtures/cinema/brighton.html')
+  end
+
+  def brighton_showtimes_html
+    read_file('../../../../fixtures/showtimes/brighton.html')
+  end
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def sitemap_html
+    read_file('../../../../fixtures/sitemap.html')
+  end
+
+  def stub_get(site_path, response_body)
+    url      = "http://www.odeon.co.uk/#{site_path}"
+    response = { status: 200, body: response_body, headers: {} }
+    stub_request(:get, url).to_return(response)
+  end
+end

data/test/lib/odeon_uk/screening_test.rb

@@ -1,53 +1,87 @@
 require_relative '../../test_helper'
 
 describe OdeonUk::Screening do
+  let(:described_class) { OdeonUk::Screening }
+
+  let(:website) { Minitest::Mock.new }
 
   before { WebMock.disable_net_connect! }
 
-  describe '#new film_name, cinema_name, date, time, variant' do
-    it 'stores film_name, cinema_name & when (in UTC)' do
-      screening = OdeonUk::Screening.new 'Iron Man 3', 'Brighton', Time.parse('2013-09-12 12:00') # non-UTC time
-      screening.film_name.must_equal 'Iron Man 3'
-      screening.cinema_name.must_equal 'Brighton'
-      screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
-      screening.booking_url.must_equal nil
-      screening.variant.must_equal nil
+  describe '.at(cinema_id)' do
+    subject { described_class.at(71) }
+
+    before do
+      website.expect(:showtimes, brighton_showtimes_html, [71])
+      website.expect(:sitemap, sitemap_html)
     end
 
-    it 'stores variant if passed' do
-      screening = OdeonUk::Screening.new 'Iron Man 3', 'Brighton', Time.utc(2013, 9, 12, 11, 0), nil, '3d'
-      screening.film_name.must_equal 'Iron Man 3'
-      screening.cinema_name.must_equal 'Brighton'
-      screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
-      screening.booking_url.must_equal nil
-      screening.variant.must_equal '3d'
+    it 'returns an array of screenings' do
+      OdeonUk::Internal::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.each do |screening|
+          screening.must_be_instance_of(described_class)
+        end
+      end
     end
 
-    it 'stores booking_url if passed' do
-      screening = OdeonUk::Screening.new 'Iron Man 3', 'Brighton', Time.utc(2013, 9, 12, 11, 0), 'http://booking_url'
-      screening.film_name.must_equal 'Iron Man 3'
-      screening.cinema_name.must_equal 'Brighton'
-      screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
-      screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
-      screening.booking_url.must_equal 'http://booking_url'
-      screening.variant.must_equal nil
+    it 'returns correct number of screenings' do
+      OdeonUk::Internal::Website.stub :new, website do
+        subject.count.must_equal 214
+      end
     end
   end
 
-  describe '#date' do
-    subject { OdeonUk::Screening.new('Iron Man 3', 'Brighton', Time.utc(2013, 9, 12, 11, 0), '3d').date }
-    it 'should return date of showing' do
+  describe '#showing_on' do
+    subject { described_class.new(options).showing_on }
+
+    let(:options) do
+      {
+        film_name:   'Guardians of the Galaxy',
+        cinema_id:   71,
+        cinema_name: 'Odeon Brighton',
+        time:        Time.utc(2014, 9, 12, 11, 0),
+      }
+    end
+
+    it 'should return date of screening' do
       subject.must_be_instance_of(Date)
-      subject.must_equal Date.new(2013, 9, 12)
+      subject.must_equal Date.new(2014, 9, 12)
     end
   end
 
-  describe '#varient (DEPRECATED)' do
-    subject { screening.varient }
-    let(:screening) { OdeonUk::Screening.new('Iron Man 3', 'Brighton', Time.utc(2013, 9, 12, 11, 0), nil, '3d') }
+  describe '#variant' do
+    subject { described_class.new(options).variant }
+
+    let(:options) do
+      {
+        film_name:   'Guardians of the Galaxy',
+        cinema_id:   71,
+        cinema_name: 'Odeon Brighton',
+        time:        Time.utc(2014, 9, 12, 11, 0),
+        variant:     ['Kids', 'BABY']
+      }
+    end
 
-    it 'should return variant' do
-      subject.must_equal '3d'
+    it 'is an alphabetically ordered array of lower-cased strings' do
+      subject.must_be_instance_of Array
+      subject.each do |tag|
+        tag.must_be_instance_of String
+      end
+      subject.must_equal %w(baby kids)
     end
   end
+
+  private
+
+  def brighton_showtimes_html
+    read_file('../../../fixtures/showtimes/brighton.html')
+  end
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def sitemap_html
+    read_file('../../../fixtures/sitemap.html')
+  end
 end