odeon_uk 1.0.0 → 1.1.1

data/test/lib/odeon_uk/cinema_test.rb

@@ -25,28 +25,40 @@ describe OdeonUk::Cinema do
   end
 
   describe '.find(id)' do
-    let(:id) { 71 }
-
     subject { OdeonUk::Cinema.find(id) }
 
     before do
       sitemap_body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'odeon-sitemap.html') )
       stub_request(:get, 'http://www.odeon.co.uk/sitemap/').to_return( status: 200, body: sitemap_body, headers: {} )
-
-      # cinema_page_body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'odeon-brighton.html') )
-      # stub_request(:get, 'http://www.odeon.co.uk/cinema/brighton/23/').to_return( status: 200, body: cinema_page_body, headers: {} )
     end
 
-    it 'returns a cinema' do
-      subject.must_be_instance_of(OdeonUk::Cinema)
+    describe 'Brighton' do
+      let(:id) { 71 }
+
+      it 'returns a cinema' do
+        subject.must_be_instance_of(OdeonUk::Cinema)
 
-      subject.id.must_equal 71
-      subject.brand.must_equal 'Odeon'
-      subject.name.must_equal 'Brighton'
-      subject.slug.must_equal 'brighton'
-      subject.url.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
+        subject.id.must_equal 71
+        subject.brand.must_equal 'Odeon'
+        subject.name.must_equal 'Brighton'
+        subject.slug.must_equal 'brighton'
+        subject.url.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
+      end
     end
-  end
+
+    describe 'Leicester Square' do
+      let(:id) { 105 }
+
+      it 'returns a cinema with London prefix removed in the name' do
+        subject.must_be_instance_of(OdeonUk::Cinema)
+
+        subject.id.must_equal 105
+        subject.brand.must_equal 'Odeon'
+        subject.name.must_equal 'Leicester Square'
+        subject.slug.must_equal 'leicester-square'
+        subject.url.must_equal 'http://www.odeon.co.uk/cinemas/london_leicester_square/105/'
+      end
+    end  end
 
   describe '.new id, name, url' do
     it 'stores id, name, slug and url' do
@@ -59,6 +71,31 @@ describe OdeonUk::Cinema do
     end
   end
 
+  describe '#adr' do
+    describe 'short address' do
+      let(:cinema) { OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/') }
+      subject { cinema.adr }
+
+      before do
+        brighton_cinema_body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'odeon-brighton.html') )
+        stub_request(:get, 'http://www.odeon.co.uk/cinemas/brighton/71/').to_return( status: 200, body: brighton_cinema_body, headers: {} )
+      end
+
+      it 'returns a Hash' do
+        subject.must_be_instance_of Hash
+      end
+
+      it 'returns address hash' do
+        subject.must_equal({
+          street_address: 'Kingswest',
+          locality: 'Brighton',
+          postal_code: 'BN1 2RE',
+          country: 'United Kingdom'
+        })
+      end
+    end
+  end
+
   describe '#films' do
     let(:cinema) { OdeonUk::Cinema.new('71', 'Brighton & Hove', '/cinemas/brighton/71/') }
     subject { cinema.films }
@@ -76,7 +113,18 @@ describe OdeonUk::Cinema do
     end
 
     it 'returns correct number of films' do
-      subject.count.must_equal 17
+      subject.count.must_equal 16
+    end
+
+    it 'returns uniquely named films' do
+      subject.each_with_index do |item, index|
+        subject.each_with_index do |jtem, i|
+          if index != i
+            item.name.wont_equal jtem.name
+            item.wont_equal jtem
+          end
+        end
+      end
     end
 
     it 'returns film objects with correct names' do
@@ -85,6 +133,74 @@ describe OdeonUk::Cinema do
     end
   end
 
+  describe '#locality' do
+    describe 'short address' do
+      let(:cinema) { OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/') }
+      subject { cinema.locality }
+
+      before do
+        brighton_cinema_body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'odeon-brighton.html') )
+        stub_request(:get, 'http://www.odeon.co.uk/cinemas/brighton/71/').to_return( status: 200, body: brighton_cinema_body, headers: {} )
+      end
+
+      it 'returns a string' do
+        subject.must_be_instance_of String
+      end
+
+      it 'returns town name' do
+        subject.must_equal 'Brighton'
+      end
+    end
+  end
+
+  describe '#postal_code' do
+    describe 'short address' do
+      let(:cinema) { OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/') }
+      subject { cinema.postal_code }
+
+      before do
+        brighton_cinema_body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'odeon-brighton.html') )
+        stub_request(:get, 'http://www.odeon.co.uk/cinemas/brighton/71/').to_return( status: 200, body: brighton_cinema_body, headers: {} )
+      end
+
+      it 'returns a string' do
+        subject.must_be_instance_of String
+      end
+
+      it 'returns the postcode' do
+        subject.must_equal 'BN1 2RE'
+      end
+    end
+
+    describe 'short address (London)' do
+      let(:cinema) { OdeonUk::Cinema.new('211', 'BFI Imax', '/cinemas/bfi_imax/211/') }
+      subject { cinema.postal_code }
+
+      before do
+        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'odeon-bfi-imax.html') )
+        stub_request(:get, 'http://www.odeon.co.uk/cinemas/bfi_imax/211/').to_return( status: 200, body: body, headers: {} )
+      end
+
+      it 'returns the postcode' do
+        subject.must_equal 'SE1 8XR'
+      end
+    end
+
+    describe 'short address (extra London Postcode)' do
+      let(:cinema) { OdeonUk::Cinema.new('105', 'Leicester Square', '/cinemas/london_leicester_square/105/') }
+      subject { cinema.postal_code }
+
+      before do
+        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'odeon-london-leicester-square.html') )
+        stub_request(:get, 'http://www.odeon.co.uk/cinemas/london_leicester_square/105/').to_return( status: 200, body: body, headers: {} )
+      end
+
+      it 'returns the postcode' do
+        subject.must_equal 'WC2H 7LQ'
+      end
+    end
+  end
+
   describe '#screenings' do
     let(:cinema) { OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/') }
     subject { cinema.screenings }
@@ -114,6 +230,26 @@ describe OdeonUk::Cinema do
       subject.first.when.must_equal Time.utc(2013, 9, 14, 11, 20, 0)
       subject.last.when.must_equal Time.utc(2013, 9, 19, 19, 40, 0)
     end
+
+    it 'returns screening objects with correct varients' do
+      subject.each do |screening|
+        screening.varient.wont_be_nil
+        screening.varient.must_match /[23]D/
+      end
+
+      subject.first.varient.must_equal '2D'
+      subject.last.varient.must_equal '2D'
+    end
+
+    it 'returns screening objects with booking urls' do
+      subject.each do |screening|
+        screening.booking_url.wont_be_nil
+        screening.booking_url.must_be_instance_of String
+      end
+
+      subject.first.booking_url.must_equal 'http://www.odeon.co.uk/booking/init/MUZFRjAwMDAwMjNVRFBETVhHIzcxIzE0NDI2/'
+      subject.last.booking_url.must_equal 'http://www.odeon.co.uk/booking/init/RjhFRjAwMDAwMjNVRFBETVhHIzcxIzEzOTY3/'
+    end
   end
 
   describe '#screenings_of(film_or_string)' do
@@ -182,4 +318,23 @@ describe OdeonUk::Cinema do
     end
   end
 
+  describe '#street_address' do
+    describe 'short address' do
+      let(:cinema) { OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/') }
+      subject { cinema.street_address }
+
+      before do
+        brighton_cinema_body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'odeon-brighton.html') )
+        stub_request(:get, 'http://www.odeon.co.uk/cinemas/brighton/71/').to_return( status: 200, body: brighton_cinema_body, headers: {} )
+      end
+
+      it 'returns a string' do
+        subject.must_be_instance_of String
+      end
+
+      it 'returns first line of address' do
+        subject.must_equal 'Kingswest'
+      end
+    end
+  end
 end

data/test/lib/odeon_uk/film_test.rb

@@ -10,4 +10,86 @@ describe OdeonUk::Film do
       film.name.must_equal 'Iron Man 3'
     end
   end
+
+  describe 'Comparable' do
+    it 'includes comparable methods' do
+      film = OdeonUk::Film.new 'AAAA'
+      film.methods.must_include :<
+      film.methods.must_include :>
+      film.methods.must_include :==
+      film.methods.must_include :<=>
+      film.methods.must_include :<=
+      film.methods.must_include :>=
+    end
+
+    describe 'uniqueness' do
+      it 'defines #hash' do
+        film = OdeonUk::Film.new 'AAAA'
+        film.methods.must_include :hash
+      end
+
+      describe '#hash' do
+        it 'returns a hash of the slug' do
+          film = OdeonUk::Film.new 'AAAA'
+          film.hash == film.slug.hash
+        end
+      end
+
+      it 'defines #eql?(other)' do
+        film = OdeonUk::Film.new 'AAAA'
+        film.methods.must_include :eql?
+      end
+
+      describe 'two identically named films' do
+        let(:film)      { OdeonUk::Film.new 'AAAA' }
+        let(:otherfilm) { OdeonUk::Film.new 'AAAA' }
+
+        it 'retuns only one' do
+          result = [film, otherfilm].uniq
+          result.count.must_equal 1
+          result.must_equal [ OdeonUk::Film.new('AAAA') ]
+        end
+      end
+    end
+
+    describe '<=> (other)' do
+      subject { film <=> otherfilm }
+
+      describe 'film less than other' do
+        let(:film)      { OdeonUk::Film.new 'AAAA' }
+        let(:otherfilm) { OdeonUk::Film.new 'BBBB' }
+
+        it 'retuns -1' do
+          subject.must_equal -1
+        end
+      end
+
+      describe 'film greater than other' do
+        let(:film)      { OdeonUk::Film.new 'CCCC' }
+        let(:otherfilm) { OdeonUk::Film.new 'BBBB' }
+
+        it 'retuns 1' do
+          subject.must_equal 1
+        end
+      end
+
+      describe 'film same as other (exact name)' do
+        let(:film)      { OdeonUk::Film.new 'AAAA' }
+        let(:otherfilm) { OdeonUk::Film.new 'AAAA' }
+
+        it 'retuns 0' do
+          subject.must_equal 0
+        end
+      end
+
+      describe 'film same as other (inexact name)' do
+        let(:film)      { OdeonUk::Film.new 'blue jasmine' }
+        let(:otherfilm) { OdeonUk::Film.new 'Blue Jasmine' }
+
+        it 'retuns 0' do
+          subject.must_equal 0
+        end
+      end
+    end
+  end
 end

data/test/lib/odeon_uk/internal/film_with_screenings_parser_test.rb

@@ -114,8 +114,10 @@ describe OdeonUk::Internal::FilmWithScreeningsParser do
           key.must_equal '2D'
           value.must_be_instance_of Array
           value.each do |element|
-            element.must_be_instance_of Time
-            element.zone.must_equal 'UTC'
+            element[0].must_be_instance_of Time
+            element[0].zone.must_equal 'UTC'
+            element[1].must_be_instance_of String
+            element[1].must_match 'http://www.odeon.co.uk/'
           end
         end
       end
@@ -127,7 +129,7 @@ describe OdeonUk::Internal::FilmWithScreeningsParser do
       it 'returns UTC times for showings' do
         # about times are from British Summer Time UTC+1
         # the actual show time is 20:30 from the fixture
-        subject['2D'].last.must_equal Time.utc(2013, 9, 19, 19, 30, 0)
+        subject['2D'].last[0].must_equal Time.utc(2013, 9, 19, 19, 30, 0)
       end
     end
 
@@ -140,8 +142,10 @@ describe OdeonUk::Internal::FilmWithScreeningsParser do
         subject.values.each do |value|
           value.must_be_instance_of Array
           value.each do |element|
-            element.must_be_instance_of Time
-            element.zone.must_equal 'UTC'
+            element[0].must_be_instance_of Time
+            element[0].zone.must_equal 'UTC'
+            element[1].must_be_instance_of String
+            element[1].must_match 'http://www.odeon.co.uk/'
           end
         end
       end
@@ -155,7 +159,7 @@ describe OdeonUk::Internal::FilmWithScreeningsParser do
       it 'returns UTC times for showings' do
         # about times are from GMT
         # the actual show time is 00:01 from the fixture
-        subject['2D'].last.must_equal Time.utc(2013, 10, 30, 0, 1, 0)
+        subject['2D'].last[0].must_equal Time.utc(2013, 10, 30, 0, 1, 0)
       end
     end
   end

data/test/lib/odeon_uk/screening_test.rb

@@ -6,24 +6,36 @@ describe OdeonUk::Screening do
 
   describe '#new film_name, cinema_name, date, time, varient' do
     it 'stores film_name, cinema_name & when (in UTC)' do
-      screening = OdeonUk::Screening.new 'Iron Man 3', 'Brighton', '2013-09-12', '11:00'
+      screening = OdeonUk::Screening.new 'Iron Man 3', 'Brighton', Time.parse('2013-09-12 12:00') # non-UTC time
       screening.film_name.must_equal 'Iron Man 3'
       screening.cinema_name.must_equal 'Brighton'
       screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
+      screening.booking_url.must_equal nil
       screening.varient.must_equal nil
     end
 
     it 'stores varient if passed' do
-      screening = OdeonUk::Screening.new 'Iron Man 3', 'Brighton', '2013-09-12', '11:00', '3d'
+      screening = OdeonUk::Screening.new 'Iron Man 3', 'Brighton', Time.utc(2013, 9, 12, 11, 0), nil, '3d'
       screening.film_name.must_equal 'Iron Man 3'
       screening.cinema_name.must_equal 'Brighton'
       screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
+      screening.booking_url.must_equal nil
       screening.varient.must_equal '3d'
     end
+
+    it 'stores booking_url if passed' do
+      screening = OdeonUk::Screening.new 'Iron Man 3', 'Brighton', Time.utc(2013, 9, 12, 11, 0), 'http://booking_url'
+      screening.film_name.must_equal 'Iron Man 3'
+      screening.cinema_name.must_equal 'Brighton'
+      screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
+      screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
+      screening.booking_url.must_equal 'http://booking_url'
+      screening.varient.must_equal nil
+    end
   end
 
   describe '#date' do
-    subject { OdeonUk::Screening.new('Iron Man 3', 'Brighton', '2013-09-12', '11:30', '3d').date }
+    subject { OdeonUk::Screening.new('Iron Man 3', 'Brighton', Time.utc(2013, 9, 12, 11, 0), '3d').date }
     it 'should return date of showing' do
       subject.must_be_instance_of(Date)
       subject.must_equal Date.new(2013, 9, 12)

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: odeon_uk
 version: !ruby/object:Gem::Version
-  version: 1.0.0
-  prerelease: 
+  version: 1.1.1
 platform: ruby
 authors:
 - Andy Croll
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-13 00:00:00.000000000 Z
+date: 2013-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -62,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -78,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: tzinfo
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -86,7 +76,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -94,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: tzinfo-data
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -102,19 +90,20 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: An API to pull movie information from the ODEON.co.uk website
 email:
-- andycroll@deepcalm.com
+- andy@goodscary.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rdoc_options
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -139,8 +128,10 @@ files:
 - test/fixtures/brighton-showtimes/star-trek-into-darkness-2d.html
 - test/fixtures/brighton-showtimes/ukjff-from-cable-street-to-brick-lane.html
 - test/fixtures/manchester-showtimes/thor-the-dark-world.html
+- test/fixtures/odeon-bfi-imax.html
 - test/fixtures/odeon-brighton-showtimes.html
 - test/fixtures/odeon-brighton.html
+- test/fixtures/odeon-london-leicester-square.html
 - test/fixtures/odeon-sitemap.html
 - test/lib/odeon_uk/cinema_test.rb
 - test/lib/odeon_uk/film_test.rb
@@ -150,27 +141,26 @@ files:
 - test/test_helper.rb
 homepage: http://github.com/andycroll/odeon_uk
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.1.10
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: It's a scraper, but a nice one
 test_files:
 - test/fixtures/brighton-showtimes/about-time.html
@@ -186,8 +176,10 @@ test_files:
 - test/fixtures/brighton-showtimes/star-trek-into-darkness-2d.html
 - test/fixtures/brighton-showtimes/ukjff-from-cable-street-to-brick-lane.html
 - test/fixtures/manchester-showtimes/thor-the-dark-world.html
+- test/fixtures/odeon-bfi-imax.html
 - test/fixtures/odeon-brighton-showtimes.html
 - test/fixtures/odeon-brighton.html
+- test/fixtures/odeon-london-leicester-square.html
 - test/fixtures/odeon-sitemap.html
 - test/lib/odeon_uk/cinema_test.rb
 - test/lib/odeon_uk/film_test.rb
@@ -195,3 +187,4 @@ test_files:
 - test/lib/odeon_uk/screening_test.rb
 - test/lib/odeon_uk/version_test.rb
 - test/test_helper.rb
+has_rdoc: