oddb2xml 3.0.20 → 3.0.21

data/spec/spec_helper.rb

@@ -257,6 +257,8 @@ def mock_downloads
    "http://pillbox.oddb.org/TRANSFER.ZIP" => "transfer.zip",
    "https://raw.githubusercontent.com/zdavatz/cpp2sqlite/master/input/atc_codes_multi_lingual.txt" => "atc.csv",
    "https://raw.githubusercontent.com/zdavatz/oddb2xml_files/master/LPPV.txt" => "oddb2xml_files_lppv.txt",
+   "https://raw.githubusercontent.com/zdavatz/oddb2xml_files/master/weleda_arzneimittel.csv" => "weleda_arzneimittel.csv",
+   "https://raw.githubusercontent.com/zdavatz/oddb2xml_files/master/bag_sl_group_prices.csv" => "bag_sl_group_prices.csv",
    "http://www.xn--spezialittenliste-yqb.ch/File.axd?file=XMLPublications.zip" => "XMLPublications.zip",
    "https://www.spezialitaetenliste.ch/File.axd?file=XMLPublications.zip" => "XMLPublications.zip",
    "https://files.refdata.ch/simis-public-prod/Articles/1.0/Refdata.Articles.zip" => "Refdata.Articles.zip",

data/spec/weleda_sl_spec.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "oddb2xml/weleda_sl"
+
+RSpec.describe Oddb2xml::WeledaSL do
+  let(:prices_csv) {
+    <<~CSV
+      pharma_group_code,price_chf_incl_vat,description,limitation
+      2069591,26.95,Urtinktur 41−60 g/ml,
+      2070631,2.50,D/C 1−9 Ampulle,
+      2070275,28.45,D/C 10−29,
+    CSV
+  }
+
+  let(:weleda_csv) {
+    <<~CSV
+      id,name,darreichung,status,verweis,artikelnummer,pharmacode,ean,abgabekategorie,zulassungsnummer,csl
+      1,"Absinthium, ethanol. Infusum D1",Tropfen 50 ml,Lieferbar,,124755,1019849,7611916162404,FM / SL,,2069591
+      2,Acidum Formicae D6,Ampullen 8x1ml,Lieferbar,,1,2,7611916151071,B / SL,1,8x2070631
+      3,Anaemodoron,Tropfen 50 ml,Lieferbar,,5055,7767096,7680215220016,D / -,21522,
+      4,No Price Product,Tropfen,Lieferbar,,9,9,7611916999999,B / SL,9,
+      5,Spaced Multiplier,Ampullen,Lieferbar,,9,9,7611916152665,B / SL,9,2 x 2070275
+    CSV
+  }
+
+  describe ".parse_prices" do
+    it "maps group code to price" do
+      prices = described_class.parse_prices(prices_csv)
+      expect(prices["2069591"]).to eq "26.95"
+      expect(prices.size).to eq 3
+    end
+
+    it "returns {} for blank input" do
+      expect(described_class.parse_prices("")).to eq({})
+      expect(described_class.parse_prices(nil)).to eq({})
+    end
+  end
+
+  describe ".resolve_price" do
+    let(:prices) { described_class.parse_prices(prices_csv) }
+
+    it "resolves a plain code" do
+      expect(described_class.resolve_price("2069591", prices)).to eq "26.95"
+    end
+
+    it "applies the Nx package multiplier" do
+      expect(described_class.resolve_price("8x2070631", prices)).to eq "20.00"
+    end
+
+    it "tolerates spaces around the multiplier" do
+      expect(described_class.resolve_price("2 x 2070275", prices)).to eq "56.90"
+    end
+
+    it "returns nil for an unknown or empty code" do
+      expect(described_class.resolve_price("9999999", prices)).to be_nil
+      expect(described_class.resolve_price("", prices)).to be_nil
+      expect(described_class.resolve_price(nil, prices)).to be_nil
+    end
+  end
+
+  describe ".build_map" do
+    let(:prices) { described_class.parse_prices(prices_csv) }
+    subject(:map) { described_class.build_map(weleda_csv, prices) }
+
+    it "includes only SL rows, keyed by 13-digit GTIN" do
+      expect(map.keys).to contain_exactly(
+        "7611916162404", "7611916151071", "7611916999999", "7611916152665"
+      )
+      expect(map).not_to have_key("7680215220016") # D / - is not SL
+    end
+
+    it "joins the public price via csl, including the multiplier" do
+      expect(map["7611916162404"][:price]).to eq "26.95"
+      expect(map["7611916151071"][:price]).to eq "20.00"
+      expect(map["7611916152665"][:price]).to eq "56.90"
+    end
+
+    it "keeps SL rows whose price cannot be resolved (price nil)" do
+      expect(map["7611916999999"][:sl]).to be true
+      expect(map["7611916999999"][:price]).to be_nil
+    end
+  end
+
+  describe ".load with bundled fallback" do
+    it "loads the bundled data files when the download yields nothing" do
+      flexmock(Oddb2xml::WeledaDownloader).new_instances.should_receive(:download).and_return(nil)
+      flexmock(Oddb2xml::BagSlGroupPricesDownloader).new_instances.should_receive(:download).and_return(nil)
+      map = described_class.load({})
+      expect(map.size).to be > 400
+      expect(map["7611916162404"]).to include(sl: true, price: "26.95")
+    end
+  end
+end

data/tools/generate_bag_sl_group_prices.rb

@@ -0,0 +1,65 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+# Regenerate data/bag_sl_group_prices.csv (and the copy in
+# github.com/zdavatz/oddb2xml_files) from the BAG SL definition PDF
+# "Homoeopathica, Anthroposophica, Allergene".
+#
+# This maps each Pharma-Gruppen-Code (the `csl` column of
+# weleda_arzneimittel.csv) to its public price (CHF incl. MWST). oddb2xml joins
+# GTIN -> csl -> price to recover the SL flag and public price of Kapitel-70
+# complementary medicines that are missing from the FHIR feed (issue #121).
+#
+# Requirements: poppler's `pdftotext` (dev-time only -- NOT a gem/runtime
+# dependency, so the gem keeps its Ruby >= 2.5 floor; pdf-reader was rejected
+# because its `afm` dependency now requires Ruby >= 3.2).
+#
+# Usage:
+#   ruby tools/generate_bag_sl_group_prices.rb [path/to/HAA.pdf] [out.csv]
+# With no PDF path it downloads the current PDF from epl.bag.admin.ch.
+
+require "csv"
+require "open-uri"
+require "tempfile"
+
+PDF_URL = "https://epl.bag.admin.ch/static/sl/definitions/" \
+  "Homoeopathica,%20Anthroposophica,%20Allergene.pdf"
+
+pdf_path = ARGV[0]
+out_path = ARGV[1] || File.expand_path("../data/bag_sl_group_prices.csv", __dir__)
+
+unless pdf_path
+  tmp = Tempfile.new(["haa", ".pdf"])
+  tmp.binmode
+  tmp.write(URI.parse(PDF_URL).open.read) # standard:disable Security/Open
+  tmp.close
+  pdf_path = tmp.path
+end
+
+txt = `pdftotext -layout #{pdf_path.inspect} -`
+raise "pdftotext failed (is poppler installed?)" unless $?.success?
+
+seen = {}
+rows = []
+txt.each_line do |line|
+  rest = line.rstrip
+  next unless rest =~ /^\s*(\d{7})\s+(.*)$/
+  code = $1
+  body = $2
+  nums = body.scan(/\d+\.\d{2}/)
+  next if nums.empty?
+  price = nums.last                              # price is the last NN.NN on the row
+  next if seen[code]
+  seen[code] = true
+  tail = body.split(price, 2)[1].to_s
+  limitation = tail.gsub(/[^L0-9, ]/, "").strip  # optional Lx limitation markers
+  desc = body.sub(/\s+#{Regexp.escape(price)}.*$/, "").gsub(/\s{2,}/, " ").strip
+  rows << [code, price, desc, limitation]
+end
+
+CSV.open(out_path, "w") do |csv|
+  csv << %w[pharma_group_code price_chf_incl_vat description limitation]
+  rows.each { |r| csv << r }
+end
+
+puts "Wrote #{rows.size} price rows to #{out_path}"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: oddb2xml
 version: !ruby/object:Gem::Version
-  version: 3.0.20
+  version: 3.0.21
 platform: ruby
 authors:
 - Yasuhiro Asaka, Zeno R.R. Davatz, Niklaus Giger
@@ -462,10 +462,12 @@ files:
 - bin/compare_v5
 - bin/oddb2xml
 - data/article_overrides.yaml
+- data/bag_sl_group_prices.csv
 - data/gal_forms.yaml
 - data/gal_groups.yaml
 - data/gtin2ignore.yaml
 - data/product_overrides.yaml
+- data/weleda_arzneimittel.csv
 - dokumentation_calc.textile
 - flake.lock
 - flake.nix
@@ -488,6 +490,7 @@ files:
 - lib/oddb2xml/semantic_check.rb
 - lib/oddb2xml/util.rb
 - lib/oddb2xml/version.rb
+- lib/oddb2xml/weleda_sl.rb
 - lib/oddb2xml/xml_definitions.rb
 - oddb2xml.gemspec
 - oddb2xml.xsd
@@ -514,6 +517,7 @@ files:
 - spec/data/artikelstamm_P_010917.xml
 - spec/data/artikelstamm_P_011217.xml
 - spec/data/atc.csv
+- spec/data/bag_sl_group_prices.csv
 - spec/data/check_artikelstamm/artikelstamm_v5_gtin_non_numeric.xml
 - spec/data/check_artikelstamm/artikelstamm_v5_gtin_not_uniq.xml
 - spec/data/check_artikelstamm/artikelstamm_v5_limitation_exists.xml
@@ -552,6 +556,7 @@ files:
 - spec/data/varia_De_spa.htm
 - spec/data/vcr/transfer.dat
 - spec/data/vcr/transfer.zip
+- spec/data/weleda_arzneimittel.csv
 - spec/data/wsdl_nonpharma.xml
 - spec/data/wsdl_pharma.xml
 - spec/data_helper.rb
@@ -565,8 +570,10 @@ files:
 - spec/parslet_spec.rb
 - spec/refdata_cleanup_spec.rb
 - spec/spec_helper.rb
+- spec/weleda_sl_spec.rb
 - test_options.rb
 - tools/cacert.pem
+- tools/generate_bag_sl_group_prices.rb
 - tools/set.bat
 - tools/win_fetch_cacerts.rb
 homepage: https://github.com/zdavatz/oddb2xml
@@ -613,6 +620,7 @@ test_files:
 - spec/data/artikelstamm_P_010917.xml
 - spec/data/artikelstamm_P_011217.xml
 - spec/data/atc.csv
+- spec/data/bag_sl_group_prices.csv
 - spec/data/check_artikelstamm/artikelstamm_v5_gtin_non_numeric.xml
 - spec/data/check_artikelstamm/artikelstamm_v5_gtin_not_uniq.xml
 - spec/data/check_artikelstamm/artikelstamm_v5_limitation_exists.xml
@@ -651,6 +659,7 @@ test_files:
 - spec/data/varia_De_spa.htm
 - spec/data/vcr/transfer.dat
 - spec/data/vcr/transfer.zip
+- spec/data/weleda_arzneimittel.csv
 - spec/data/wsdl_nonpharma.xml
 - spec/data/wsdl_pharma.xml
 - spec/data_helper.rb
@@ -664,3 +673,4 @@ test_files:
 - spec/parslet_spec.rb
 - spec/refdata_cleanup_spec.rb
 - spec/spec_helper.rb
+- spec/weleda_sl_spec.rb