oddb2xml 3.0.13 → 3.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7683d46d314f40d96aee89b278969119fd9fe0b7736512e5e291eb127f57ab1
-  data.tar.gz: a4246838014fcc77f8a2560db7bf223ac5da3469171eed8873aaf82b81c20877
+  metadata.gz: 48a674b29560c021e581fdbcd060a0bcf58f618ce853a93a54e8a7504bbb3f0a
+  data.tar.gz: ac3fc397a257b03a51f760299241c9865c325b22c3bb1b57ba76a0dcfa5fcb59
 SHA512:
-  metadata.gz: a9eca4b589da6ffba2995a8f781a05f84529c376f234d9810bbfa3ff48d3c7bfa6126a1829c7560af676d085a6ff12bcf5556468cacaa63f64f70d794998541d
-  data.tar.gz: 36c76b18c0282ce169cfd152e0ff00bec9a2a670e7eb53c15a3c7e5a6014370e0884b0e8d64263847bd8a4219e5041aa6f8d257df354c42f2916d66fd9a59470
+  metadata.gz: bd0da98d7f153c459f0f8548f56c1ac416752ee9e05aafe2cb2bf5965e1f88c7bab1272237210b7ead8079b6f8d564eeca187801348d26763439dc6133a8c490
+  data.tar.gz: 7b53c6f9ed2f363bbae51c2f8d6cbce456774534f08045def0248a13a22a8e17c2e723f093936e6d607c02d7e3da95e74eb00945bdae6fd393f0aac6fa1da8fc

data/CLAUDE.md

@@ -49,7 +49,7 @@ The system follows a **download → extract → build → compress** pipeline:
 
 7. **FHIR support** (`lib/oddb2xml/fhir_support.rb`) — Self-contained module providing `FhirDownloader` and FHIR NDJSON parsing. Activated via `--fhir` (or `--fhir-url=<URL>`). Downloads per-language NDJSON files (`foph-sl-export-latest-{de,fr,it}.ndjson`) from `epl.bag.admin.ch` to populate French and Italian product names/descriptions. Maps legal status codes `756005022007` and `756005022008` to Swissmedic category D. Reads the BAG **Indikationscode** (`XXXXX.NN`) from the explicit `indicationCode` extension on each `RegulatedAuthorization.indication[].extension[regulatedAuthorization-limitation]` (BAG SL FHIR export >= v2.0.5; handled from 3.0.10). The BAG changelog states the limitation code (`ClinicalUseDefinition.id`) and the indication code are **independent** fields, so the older derivation — combining each indication CUD's `.NN` id-suffix with the reimbursement RA's `FOPHDossierNumber` — is kept only as a fallback for feeds lacking the extension. Exposed as `item[:indication_codes]` and per-package `:indication_codes` (each entry a `{code:, cud_id:, text:}` hash, where `cud_id` is the `limitationIndication` CUD reference used to resolve the text). From 3.0.7 onwards, `Builder#build_product` emits one `<INDICATION_CODE code="XXXXX.NN" cud_id="DRUG.NN">limitation text</INDICATION_CODE>` child per indication on every `<PRD>` in `oddb_product.xml`; live feed numbers: 539 products / 1,293 codes / 100 % with non-empty indication text. Mandatory on prescriptions/invoices for SL price-model drugs from 2026-07-01 — see issue [#113](https://github.com/zdavatz/oddb2xml/issues/113). **Limitation texts** (3.0.8 onwards): the `regulatedAuthorization-limitation` extension has no inline `limitationText` in the live BAG feed — it carries a `limitationIndication` reference to a `ClinicalUseDefinition` whose `indication.diseaseSymptomProcedure.concept.text` is the actual text. The parser stores the ref as `cud_ref` on each Limitation, `Bundle#cud_text_by_id` resolves DE, and `merge_language` propagates FR/IT from the per-language NDJSON files via the same CUD id. Coverage on the live feed jumped from 0 / 9'108 to 9'108 / 9'108 (issue [#116](https://github.com/zdavatz/oddb2xml/issues/116)). **Limitation code / LIMNAMEBAG** (3.0.12 onwards): FHIR has no native BAG limitation code (LIMCD), so `create_limitations_for_package` sets `LimitationCode = cud_ref` (the `limitationIndication` CUD id) instead of `""`. Without this, every FHIR limitation shared an empty `:code`; `Builder#build_artikelstamm` groups its `<LIMITATIONS>` section by code, so all of them collapsed into a single `<LIMITATION>` with an empty `<LIMNAMEBAG>` and only one text survived. Using the CUD id as the key makes each distinct limitation emit and be referenced from its `<PRODUCT>`. The downstream `bin/check_artikelstamm` (`semantic_check.rb`) also crashed on the lone-element output because Ox `:hash_no_attrs` collapses a one-child section into a Hash (and an empty one into nil) — `SemanticCheckXML#get_items` now normalises every section to an Array.
 
-8. **Refdata cleanup** (`lib/oddb2xml/refdata_cleanup.rb`) — Compensates for known data-quality issues in upstream Refdata.Articles.xml before they reach the output. Each fix is guarded by a Swissmedic-side heuristic (e.g. comma in `substance_swissmedic` to distinguish mono products from real combinations). Currently fixes the doubled-dose template bug (`X mg / X mg / Stk`). Called from `Builder#apply_refdata_description_cleanups!` at the start of `prepare_articles`. See GitHub issue #112 for the catalogue.
+8. **Refdata cleanup** (`lib/oddb2xml/refdata_cleanup.rb`) — Compensates for known data-quality issues in upstream Refdata.Articles.xml before they reach the output. Each fix is guarded by a Swissmedic-side heuristic (e.g. comma in `substance_swissmedic` to distinguish mono products from real combinations). Currently fixes (a) the doubled-dose template bug (`X mg / X mg / Stk`, `fix_double_dose`, guarded by `single_substance?`) and (b) the spelled-out German galenic form `Retardtabletten` → house-style abbreviation `Ret Tabl` (`normalize_galenic_form` / `GALENIC_NORMALISATIONS`, issue #112 case #13, e.g. RINVOQ — a narrow word-boundary substitution that leaves legitimate brand suffixes like `TRAMAL retard` and Mepha's `Lactab` untouched). Called from `Builder#apply_refdata_description_cleanups!` at the start of `prepare_articles`. See GitHub issue #112 for the catalogue.
 
 9. **Chapter-70 hack** (`lib/oddb2xml/chapter_70_hack.rb`) — Legacy scraper for the SL "Komplementärarzneimittel" products (homeopathic/anthroposophic/phytotherapeutic), called only from `Builder#build_artikelstamm`. **Deprecated / non-FHIR only (3.0.11 onwards):** the source page `varia_De.htm` was rebuilt as a JavaScript SPA with no static data table, so the scraper now returns nothing there. These products + limitations now come through the FHIR feed (SL classification `20. KOMPLEMENTÄRARZNEIMITTEL`, 221 products on the live DE feed with real GTINs and limitation texts), so `build_artikelstamm` **skips the scraper entirely when `@options[:fhir]`** (the default for `--artikelstamm` since 3.0.9). In `--no-fhir` mode the scraper degrades gracefully (skips non-row/`<script>` nodes and empty tables, warns, returns `[]`) instead of raising `NoMethodError`. See GitHub issue #118.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    oddb2xml (3.0.13)
+    oddb2xml (3.0.14)
       csv
       htmlentities
       httpi

data/History.txt

@@ -1,3 +1,6 @@
+=== 3.0.14 / 02.06.2026
+* Refdata cleanup: normalise the spelled-out German galenic form "Retardtabletten" to the Refdata house-style abbreviation "Ret Tabl" (issue #112 case #13, e.g. RINVOQ). Only 3 of the ~940 retard-tablet descriptions deviated from the convention; the fix is a narrow, German-only word-boundary substitution (RefdataCleanup.normalize_galenic_form, wired into Builder#apply_refdata_description_cleanups!). Legitimate brand suffixes ("TRAMAL retard", "XANAX retard", "MELATONIN Spirig HC retard") and Mepha's "Lactab" are left untouched.
+
 === 3.0.13 / 02.06.2026
 * Security: bump the nokogiri floor to >= 1.19.3. Fixes two GitHub/Dependabot advisories against nokogiri < 1.19.3: a high-severity ReDoS (regular expression backtracking) in the CSS selector tokenizer, and a medium-severity memory leak in the XSLT transform.
 

data/README.md

@@ -51,7 +51,7 @@ HIN (http://hin.ch) creates daily the actual file. They can be downloaded from `
 see `--help`.
 
 ```
-    /opt/src/oddb2xml/bin/oddb2xml version 3.0.13
+    /opt/src/oddb2xml/bin/oddb2xml version 3.0.14
     Usage:
     oddb2xml [option]
       produced files are found under data

data/lib/oddb2xml/builder.rb

@@ -96,6 +96,7 @@ module Oddb2xml
       @refdata_descriptions_cleaned = true
       return if @refdata.nil? || @refdata.empty?
       double_dose_fixed = 0
+      galenic_fixed = 0
       @refdata.each_value do |item|
         next unless item.is_a?(Hash)
         no8 = item[:no8]
@@ -110,11 +111,20 @@ module Oddb2xml
             item[key] = cleaned
             double_dose_fixed += 1
           end
+          original = item[key]
+          cleaned = RefdataCleanup.normalize_galenic_form(original)
+          if cleaned != original
+            item[key] = cleaned
+            galenic_fixed += 1
+          end
         end
       end
       if double_dose_fixed > 0
         Oddb2xml.log("Refdata cleanup: fixed double-dose pattern in #{double_dose_fixed} description(s)")
       end
+      if galenic_fixed > 0
+        Oddb2xml.log("Refdata cleanup: normalised galenic form in #{galenic_fixed} description(s)")
+      end
     end
 
     private_class_method

data/lib/oddb2xml/refdata_cleanup.rb

@@ -30,5 +30,23 @@ module Oddb2xml
       return desc unless single_substance?(swissmedic_substance)
       desc.sub(DOUBLE_DOSE_RE, '\1 / ')
     end
+
+    # Case #13 (issue #112): a handful of products spell the galenic form out
+    # in full ("RINVOQ Retardtabletten 30 mg 28 Stk") while the Refdata house
+    # style abbreviates it everywhere else ("Ret Tabl", 940 other DE names).
+    # Normalise the spelled-out form to the abbreviation so the outliers match
+    # the convention. The keys are German-only words (FR/IT use "comprimé …" /
+    # "compresse …"), so applying this to FR/IT descriptions is a safe no-op.
+    GALENIC_NORMALISATIONS = {
+      /\bRetardtabletten\b/ => "Ret Tabl"
+    }.freeze
+
+    # Normalises spelled-out German galenic forms to the Refdata house-style
+    # abbreviation. Returns the cleaned description, or the original string if
+    # no rule applies.
+    def self.normalize_galenic_form(desc)
+      return desc if desc.nil? || desc.empty?
+      GALENIC_NORMALISATIONS.reduce(desc) { |result, (re, repl)| result.gsub(re, repl) }
+    end
   end
 end

data/lib/oddb2xml/version.rb

@@ -1,3 +1,3 @@
 module Oddb2xml
-  VERSION = "3.0.13"
+  VERSION = "3.0.14"
 end

data/spec/refdata_cleanup_spec.rb

@@ -62,6 +62,36 @@ describe Oddb2xml::RefdataCleanup do
       expect(described_class.fix_double_dose(input, combo)).to eq input
     end
   end
+
+  describe ".normalize_galenic_form" do
+    it "abbreviates the spelled-out 'Retardtabletten' to 'Ret Tabl' (issue #112 #13)" do
+      input = "RINVOQ Retardtabletten 30 mg 28 Stk"
+      expected = "RINVOQ Ret Tabl 30 mg 28 Stk"
+      expect(described_class.normalize_galenic_form(input)).to eq expected
+    end
+
+    it "leaves the already-abbreviated house style untouched" do
+      input = "TRAMAL retard Ret Tabl 100 mg 30 Stk"
+      expect(described_class.normalize_galenic_form(input)).to eq input
+    end
+
+    it "is a no-op for FR/IT names (different galenic words)" do
+      fr = "RINVOQ comprimé à libération prolong. 30 mg 28 pce"
+      it_ = "RINVOQ compresse a rilascio prolungato 30 mg 28 pz"
+      expect(described_class.normalize_galenic_form(fr)).to eq fr
+      expect(described_class.normalize_galenic_form(it_)).to eq it_
+    end
+
+    it "is a no-op for nil or empty descriptions" do
+      expect(described_class.normalize_galenic_form(nil)).to be_nil
+      expect(described_class.normalize_galenic_form("")).to eq ""
+    end
+
+    it "does not touch 'Retardtabletten' embedded in a longer word" do
+      input = "FOO Retardtablettenspender 1 Stk"
+      expect(described_class.normalize_galenic_form(input)).to eq input
+    end
+  end
 end
 
 describe Oddb2xml::Builder do
@@ -147,5 +177,27 @@ describe Oddb2xml::Builder do
 
       expect(builder.refdata["7680694750066"][:desc_de]).to eq input
     end
+
+    it "normalises the galenic form on the German name only (RINVOQ, issue #112 #13)" do
+      builder.packs = {
+        "67257003" => {substance_swissmedic: "upadacitinibum"}
+      }
+      builder.refdata = {
+        "7680672570037" => {
+          ean13: "7680672570037",
+          no8: "67257003",
+          desc_de: "RINVOQ Retardtabletten 30 mg 28 Stk",
+          desc_fr: "RINVOQ comprimé à libération prolong. 30 mg 28 pce",
+          desc_it: "RINVOQ compresse a rilascio prolungato 30 mg 28 pz"
+        }
+      }
+
+      builder.apply_refdata_description_cleanups!
+
+      item = builder.refdata["7680672570037"]
+      expect(item[:desc_de]).to eq "RINVOQ Ret Tabl 30 mg 28 Stk"
+      expect(item[:desc_fr]).to eq "RINVOQ comprimé à libération prolong. 30 mg 28 pce"
+      expect(item[:desc_it]).to eq "RINVOQ compresse a rilascio prolungato 30 mg 28 pz"
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: oddb2xml
 version: !ruby/object:Gem::Version
-  version: 3.0.13
+  version: 3.0.14
 platform: ruby
 authors:
 - Yasuhiro Asaka, Zeno R.R. Davatz, Niklaus Giger