oddb2xml 2.7.4 → 2.7.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af1cbeb37bf057e98955776c87dd5092fc5706af18d00ba818efccd2c52a076e
-  data.tar.gz: 1f4faf8f73b2cffa14bd3dda23dad4e401b524587c0f95d80e0cc9cbd4ba5d2b
+  metadata.gz: 8d94c5e970a0c4917bfd547d1c71b6c889cd9ec4420e2d986eb53023bbdd2d94
+  data.tar.gz: 2a242506a97171bbb882f5daa9e634ff1485e32bed2116d4e2dd3ffb1d948850
 SHA512:
-  metadata.gz: ace048c855b3711fd6b75692373318fe992a5c6529d322c13b516a7bd09390e36efec3f14edaa91ddeb223438d74c97c15ba4691077e9c77ce5063a10bdcc423
-  data.tar.gz: 9dcf787039edc02a56b7301f6849e76259628ac55da598a2878e4a08c63fd3c3aaef35bfea6bda8184c6e3552314fba7bb028962d81151ca98bf76f830c3303f
+  metadata.gz: d3816794c1f84e301d091ddf35bbea6246da42bbb8fdce8bb9b9444b9cc8280e51f712ff3bc5b6b3166d2e78f942441e7600c9e86030034e93fe89bf5b5b0b91
+  data.tar.gz: 5518a263cd2e9813b7625f2aab9e32ce455ec4ece55dc84bf8bb862f62f8a61b027ae9eb5396c92ef2a35de3acfa9e4024f6ead2a581c6c009a4cc559da75d16

data/.github/workflows/ruby.yml

@@ -22,8 +22,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ ubuntu]
-        ruby: [2.5, 2.6, 2.7, 3.0, head]
-    continue-on-error: ${{ endsWith(matrix.ruby, 'head') }}
+        ruby: [2.6, 2.7, "3.0", 3.1]
     steps:
     - uses: actions/checkout@v2
     - uses: ruby/setup-ruby@v1

data/History.txt

@@ -1,3 +1,17 @@
+=== 2.7.7/ 12.08.2022
+* Workaround for artikelstamm V3. Strip IKSCAT from A+ to A to be compatible with XSD
+
+=== 2.7.6/ 9.03.2022
+* Workaround for artikelstamm V5. Strip IKSCAT from A+ to A to be compatible with XSD
+* Fix spec tests
+
+=== 2.7.5 / 1.02.2022
+* Specify old versions of savon and rdoc to avoid importing psych
+* Added ruby 3.1 to tested ruby versions
+* Removed ruby 2.5 from supported versions
+* Force psych to < 4.0 to avoid the error Psych::DisallowedClass: Tried to load unspecified class: Struct::GalenicGroup
+*   Therefor rdoc < 6.4
+
 === 2.7.4 / 30.03.2021
 * Update needed Ruby-Version to 2.5.0 in gemspec
 * Ensure downloads directory is created at first run

data/lib/oddb2xml/builder.rb

@@ -910,7 +910,7 @@ module Oddb2xml
               # xml.CDS01
               # xml.CDS02
               if ppac
-                xml.SMCAT ppac[:swissmedic_category] unless ppac[:swissmedic_category].empty?
+                xml.SMCAT ppac[:swissmedic_category][0] unless ppac[:swissmedic_category].empty?
                 xml.GEN_PRODUCTION ppac[:gen_production] unless ppac[:gen_production].empty?
                 xml.INSULIN_CATEGORY ppac[:insulin_category] unless ppac[:insulin_category].empty?
                 xml.DRUG_INDEX ppac[:drug_index] unless ppac[:drug_index].empty?
@@ -1568,7 +1568,7 @@ module Oddb2xml
                     xml.DOSAGE_FORMF info.galenic_form.descriptions["fr"] if info.galenic_form.descriptions["fr"]
                   end
                   xml.SL_ENTRY "true" if sl_gtins.index(pkg_gtin)
-                  xml.IKSCAT package[:swissmedic_category] if package[:swissmedic_category] && package[:swissmedic_category].length > 0
+                  xml.IKSCAT package[:swissmedic_category][0] if package[:swissmedic_category] && package[:swissmedic_category].length > 0
                   xml.GENERIC_TYPE sequence[:org_gen_code] if sequence[:org_gen_code] && !sequence[:org_gen_code].empty?
                   xml.LPPV "true" if @lppvs[pkg_gtin.to_s] # detect_nincd
                   if item && item[:deductible]

data/lib/oddb2xml/compositions_syntax.rb

@@ -213,7 +213,6 @@ class CompositionParser < Parslet::Parser
       str("et ") |
       str("excipiens") |
       str("partes") |
-      str("pro capsula") |
       str("pro dosi") |
       str("pro vitroe") |
       str("q.s. ad ") |
@@ -259,6 +258,9 @@ class CompositionParser < Parslet::Parser
 
   rule(:pro_identifiers) {
     str("ut aqua ad iniectabilia q.s. ad emulsionem pro ") |
+      str("aqua ").maybe >> str("ad iniectabile q.s. ad suspensionem pro ") |
+      str("aqua ").maybe >> str("ad iniectabile q.s. ad solutionem pro ") |
+      str("aqua ").maybe >> str("ad iniectabile ad solutionem pro ") |
       str("aqua ").maybe >> str("ad iniectabilia q.s. ad solutionem pro ") |
       str("aqua ").maybe >> str("ad solutionem pro ") |
       str("aqua ").maybe >> str("q.s. ad emulsionem pro ") |
@@ -270,6 +272,7 @@ class CompositionParser < Parslet::Parser
       str("excipiens ad pulverem pro ") |
       str("excipiens ad solutionem pro ") |
       str("pro vase ") |
+      str("pro capsula ") |
       str("q.s. ad pulverem pro ")
   }
   rule(:excipiens_dose) {

data/lib/oddb2xml/downloader.rb

@@ -243,7 +243,7 @@ module Oddb2xml
   class RefdataDownloader < Downloader
     def initialize(options = {}, type = :pharma)
       @type = (type == :pharma ? "Pharma" : "NonPharma")
-      url = "http://refdatabase.refdata.ch/Service/Article.asmx?WSDL"
+      url = "https://refdatabase.refdata.ch/Service/Article.asmx?WSDL"
       super(options, url)
     end
 

data/lib/oddb2xml/parslet_compositions.rb

@@ -6,7 +6,7 @@
 
 require "parslet"
 require "parslet/convenience"
-require "oddb2xml/compositions_syntax"
+require_relative "compositions_syntax"
 VERBOSE_MESSAGES ||= false
 
 module ParseUtil
@@ -101,6 +101,7 @@ module ParseUtil
   rescue => error
     puts "error #{error}"
     # binding.pry
+    raise error
   end
 end
 
@@ -373,6 +374,7 @@ class ParseComposition
   ERRORS_TO_FIX = {
     /(\d+)\s+-\s*(\d+)/ => '\1-\2',
     "o.1" => "0.1",
+    /polymerisat(i|um) \d:\d/ => "polymerisatum",
     /\s+(mg|g) DER:/ => ' \1, DER:',
     " mind. " => " min. ",
     " streptococci pyogen. " => " streptococci pyogen ",
@@ -384,7 +386,7 @@ class ParseComposition
     / U\.: (excipiens) / => ' U. \1 ',
     / U\.: (alnus|betula|betula|betulae) / => ' U., \1 ',
     /^(acari allergeni extractum (\(acarus siro\)|).+\s+U\.:)/ => 'A): \1',
-    "Solvens: alprostadilum" => "alprostadilum"
+    "Solvens: alprostadilum" => "alprostadilum",
   }
   @@error_handler = ParseUtil::HandleSwissmedicErrors.new(ERRORS_TO_FIX)
 

data/lib/oddb2xml/version.rb

@@ -1,3 +1,3 @@
 module Oddb2xml
-  VERSION = "2.7.4"
+  VERSION = "2.7.7"
 end

data/oddb2xml.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "minitar" # , '~> 0.5.2'
   spec.add_dependency "mechanize" # , '~> 2.5.1'
   spec.add_dependency "nokogiri", ">= 1.8.2"
-  spec.add_dependency "savon" # , '~> 2.11.0'
+  spec.add_dependency "savon" , '~> 2.12.0'
   spec.add_dependency "spreadsheet" # , '~> 1.0.0'
   spec.add_dependency "rubyXL", "~> 3.4.0"
   spec.add_dependency "sax-machine" # ,  '~> 0.1.0'
@@ -44,8 +44,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "webmock"
-  spec.add_development_dependency "rdoc"
+  spec.add_development_dependency "rdoc", "~> 6.3.3" # rdoc 6.4 depends on psych 4.0 which breaks savon!
   spec.add_development_dependency "vcr"
   spec.add_development_dependency "timecop"
   spec.add_development_dependency "flexmock"
+  spec.add_development_dependency "psych", "< 4.0.0"
 end

data/shell.nix

@@ -0,0 +1,17 @@
+# See https://nixos.wiki/wiki/Packaging/Ruby
+# A small helper script to get a development version for oddb2xml under NixOS
+with import <nixpkgs> {};
+stdenv.mkDerivation {
+  name = "env";
+  buildInputs = [
+    ruby_3_0.devEnv
+    git
+    python
+    libpcap
+    libxml2
+    libxslt
+    pkg-config
+    bundix
+    gnumake
+  ];
+}

data/spec/artikelstamm_spec.rb

@@ -12,7 +12,7 @@ describe Oddb2xml::Builder do
     unless @inhalt.index(expected_value)
       puts expected_value
     end
-    # binding.pry if defined?(Pry) && !@inhalt.index(expected_value)
+    # binding.irb unless @inhalt.index(expected_value)
     expect(@inhalt.index(expected_value)).not_to be nil
   end
 
@@ -475,7 +475,14 @@ Der behandelnde Arzt ist verpflichtet, die erforderlichen Daten laufend im vorge
 1\)	Geburtsjahr, sowie Vortherapien für das OC
 
 2\)	Datum Therapiestart, Dosierung, Dosisanpassungen, Datum Therapieende.
-</DSCR>)}
+</DSCR>),
+             "No A+" => %(<PRODUCT>
+            <PRODNO>1336901</PRODNO>
+            <SALECD>A</SALECD>
+            <DSCR>Pethidin HCl Amino 100 mg/2 ml, Injektionslösung</DSCR>
+            <DSCRF/>
+            <ATC>N02AB02</ATC>
+        </PRODUCT>)}
 
     tests.each do |key, expected|
       it "should a valid entry for #{key}" do
@@ -492,7 +499,7 @@ Der behandelnde Arzt ist verpflichtet, die erforderlichen Daten laufend im vorge
       result = Oddb2xml::Chapter70xtractor.parse
       expect(result.class).to eq Array
       expect(result.first).to eq ["2069562", "70.01.10", "Urtinktur", "1--10 g/ml", "13.40", ""]
-      expect(result.last).to eq ["6516727", "70.02", "Allergenorum extractum varium / Inj. Susp. \tFortsetzungsbehandlung", "1 Durchstfl 1.5 ml", "311.85", "L"]
+      expect(result.last).to eq ["6516727", "70.02", "Allergenorum extractum varium / Inj. Susp. \n\tFortsetzungsbehandlung", "1 Durchstfl 1.5 ml", "311.85", "L"]
     end
   end
 end

data/spec/builder_spec.rb

@@ -458,7 +458,7 @@ NR_LIMITATIONS = 15
 NR_INTERACTIONS = 2
 NR_CODES = 5
 NR_PRODNO = 31
-NR_PACKAGES = 46
+NR_PACKAGES = 47
 NR_PRODUCTS = 40
 REG_EXP_DESITIN = /1120000000LEVETIRACETAM DESITIN Mini Filmtab 250 mg 30 Stk/
 describe Oddb2xml::Builder do
@@ -497,7 +497,7 @@ describe Oddb2xml::Builder do
 
     it "should have a correct NBR_RECORD in oddb_products.xml" do
       oddb_product_xml = oddb_article_xml.sub("oddb_article.xml", "oddb_product.xml")
-      check_result(File.read(oddb_product_xml), 46)
+      check_result(File.read(oddb_product_xml), NR_PACKAGES)
     end
 
     it "oddb_article.xml should contain a SHA256" do
@@ -546,7 +546,8 @@ describe Oddb2xml::Builder do
     it "should flag fridge drugs correctly" do
       doc = REXML::Document.new IO.read(checkAndGetArticleXmlName)
       checkAndGetArticleWithGTIN(doc, Oddb2xml::FRIDGE_GTIN)
-      expect(REXML::XPath.match(doc, "//COOL='1']").size).to eq 1
+      expect(REXML::XPath.match(doc, "//COOL=").size).to eq 1
+      expect(REXML::XPath.match(doc, "//COOL").first.text).to eq "1"
     end
 
     ean_with_drug_index = 7680555610041

data/spec/extractor_spec.rb

@@ -181,7 +181,7 @@ describe Oddb2xml::SwissmedicExtractor do
       @packs.find { |pack| pack[1][:ean13] == ean13.to_s }[1]
     end
     it "should have correct nr of packages" do
-      expect(@packs.size).to eq(41)
+      expect(@packs.size).to eq(42)
     end
 
     it "should have serocytol" do

data/spec/fixtures/vcr_cassettes/oddb2xml.json

@@ -19,7 +19,7 @@
                     ]
                 },
                 "method": "get",
-                "uri": "http://refdatabase.refdata.ch/Service/Article.asmx?WSDL"
+                "uri": "https://refdatabase.refdata.ch/Service/Article.asmx?WSDL"
             },
             "response": {
                 "body": {

data/spec/parslet_spec.rb

@@ -1,8 +1,13 @@
-require "pp"
 VERBOSE_MESSAGES = false
-require "spec_helper"
-require "#{Dir.pwd}/lib/oddb2xml/parslet_compositions"
+if File.exists?("#{Dir.pwd}/lib/oddb2xml/parslet_compositions.rb")
+  require_relative "../lib/oddb2xml/parslet_compositions"
+else
+  puts :ParseFailed
+  require_relative "../src/plugin/parslet_compositions"
+end
+
 require "parslet/rig/rspec"
+require "socket"
 
 hostname = Socket.gethostbyname(Socket.gethostname).first
 RUN_ALL_COMPOSITION_TESTS = false # /travis|localhost/i.match(hostname) != nil # takes about five minutes to run!
@@ -15,7 +20,6 @@ describe ParseComposition do
     string = "conserv.: E 216, E 218, excipiens pro suppositorio."
     composition = ParseComposition.from_string(string)
     # active_agent = ["hynic-[d-phe(1)", "tyr(3)-octeotridum]trifluoroacetum", "acidum ethylendiamini-n,n'-diaceticum"]
-
     active_substance = "HYNIC-[D-Phe(1)"
     composition_text = "II) Durchstechflasche 2: acidum ethylendiamini-N,N'-diaceticum 10 mg, dinatrii phosphas dodecahydricus, natrii hydroxidum, pro vitro."
     composition = ParseUtil.parse_compositions(composition_text, active_substance).first
@@ -1290,6 +1294,63 @@ describe ParseComposition do
     specify { expect(substance.unit).to eq nil }
   end
 
+  context "should handle 41174" do
+    string = "triamcinoloni acetonidum 10 mg, carmellosum natricum, natrii chloridum, polysorbatum 80, conserv.: alcohol benzylicus 9.9 mg, aqua ad iniectabile q.s. ad suspensionem pro 1 ml."
+    composition = ParseComposition.from_string(string)
+    specify { expect(composition.source).to eq string }
+    specify { expect(composition.label).to eq nil }
+    specify { expect(composition.substances.size).to be > 1 }
+    specify { expect(composition.substances.first.name).to eq "Triamcinoloni Acetonidum" }
+    specify { expect(composition.substances.last.name).to eq "Alcohol Benzylicus" }
+  end
+
+  context "should handle 67023" do
+    string = "noradrenalinum 0.06 mg ut noradrenalini tartras, natrii chloridum, acidum hydrochloridum, aqua ad iniectabile q.s. ad solutionem pro 1 ml corresp. natrium 3.308 mg."
+    composition = ParseComposition.from_string(string)
+    specify { expect(composition.source).to eq string }
+    specify { expect(composition.label).to eq nil }
+    specify { expect(composition.substances.size).to be > 1 }
+    specify { expect(composition.substances.first.name).to eq "Noradrenalinum" }
+    specify { expect(composition.substances.last.name).to eq "Acidum Hydrochloridum" }
+  end
+
+  context "should handle 67023" do
+    string = "noradrenalinum 0.06 mg ut noradrenalini tartras, natrii chloridum, acidum hydrochloridum, aqua ad iniectabile q.s. ad solutionem pro 1 ml corresp. natrium 3.308 mg."
+    composition = ParseComposition.from_string(string)
+    specify { expect(composition.source).to eq string }
+    specify { expect(composition.label).to eq nil }
+    specify { expect(composition.substances.size).to be > 0 }
+    specify { expect(composition.substances.first.name).to eq "Noradrenalinum" }
+    specify { expect(composition.substances.last.name).to eq "Acidum Hydrochloridum" }
+  end
+
+  context "should handle 67689" do
+    string = "daratumumabum 1800 mg, hyaluronidasum humanum ADNr, histidinum, histidini hydrochloridum monohydricum, sorbitolum 735.1 mg, methioninum, polysorbatum 20, aqua ad iniectabile ad solutionem pro 15 ml"
+    composition = ParseComposition.from_string(string)
+    specify { expect(composition.source).to eq string }
+    specify { expect(composition.label).to eq nil }
+    specify { expect(composition.substances.size).to be > 0 }
+    specify { expect(composition.substances.first.name).to eq "Daratumumabum" }
+    specify { expect(composition.substances.last.name).to eq "Polysorbatum 20" }
+  end
+
+  context "should handle 66097" do
+    string = "acidum acetylsalicylicum 100 mg, cellulosum microcristallinum, maydis amylum, silica colloidalis anhydrica, acidum stearicum, Überzug: acidi methacrylici et ethylis acrylatis polymerisatum 1:1, polysorbatum 80, natrii laurilsulfas corresp. natrium 2 µg, triethylis citras, talcum pro compresso obducto" # fails
+    composition = ParseComposition.from_string(string)
+    specify { expect(composition.source).to eq string }
+    specify { expect(composition.label).to eq nil }
+    specify { expect(composition.substances.first.name).to eq "Acidum Acetylsalicylicum" }
+    specify { expect(composition.substances.last.name).to eq "Talcum pro compresso Obducto" }
+  end
+  context "should handle 65828" do
+    string = " esomeprazolum 20 mg ut esomeprazolum magnesicum dihydricum, acidi methacrylici et ethylis acrylatis polymerisati 1:1 dispersio 30 per centum, natrii laurilsulfas, talcum, triethylis citras, hypromellosum, sacchari sphaerae corresp. saccharum 4.73 mg et maydis amylum, magnesii stearas, hydroxypropylcellulosum, glyceroli monostearas 40-55, polysorbatum 80, cellulosum microcristallinum, povidonum K 29-32, macrogolum 6000, crospovidonum, natrii stearylis fumaras, Überzug: hypromellosum, E 171, macrogolum 400, E 172 (rubrum), E 172 (flavum), pro compresso obducto corresp. natrium 0.01 mg."
+    composition = ParseComposition.from_string(string)
+    specify { expect(composition.source).to eq string }
+    specify { expect(composition.label).to eq nil }
+    specify { expect(composition.substances.first.name).to eq "Esomeprazolum" }
+    specify { expect(composition.substances.last.name).to eq "pro compresso Obducto" }
+  end
+
   context "should return correct composition for 'minoxidilum excipiens'" do
     string = "minoxidilum 2.5 mg, excipiens pro compresso."
     composition = ParseComposition.from_string(string)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: oddb2xml
 version: !ruby/object:Gem::Version
-  version: 2.7.4
+  version: 2.7.7
 platform: ruby
 authors:
 - Yasuhiro Asaka, Zeno R.R. Davatz, Niklaus Giger
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-30 00:00:00.000000000 Z
+date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -70,16 +70,16 @@ dependencies:
   name: savon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
   name: spreadsheet
   requirement: !ruby/object:Gem::Requirement
@@ -336,16 +336,16 @@ dependencies:
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 6.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 6.3.3
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -388,6 +388,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: psych
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 4.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 4.0.0
 description: oddb2xml creates xml files using swissINDEX, BAG-XML and Swissmedic.
 email: yasaka@ywesee.com, zdavatz@ywesee.com, ngiger@ywesee.com
 executables:
@@ -439,6 +453,7 @@ files:
 - oddb2xml.gemspec
 - oddb2xml.xsd
 - oddb_calc.xsd
+- shell.nix
 - spec/artikelstamm_spec.rb
 - spec/builder_spec.rb
 - spec/calc_spec.rb
@@ -514,7 +529,7 @@ homepage: https://github.com/zdavatz/oddb2xml
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -529,9 +544,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
-signing_key: 
+rubygems_version: 3.2.26
+signing_key:
 specification_version: 4
 summary: oddb2xml creates xml files.
 test_files: