oddb2xml 2.7.3 → 2.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5dc59cd0f8ed09f2416f4ba77030ab3549618c3cbe90b3e0496e91808e51fa95
-  data.tar.gz: 3fdbf0803a5b92b4b3af6950c0021db33ade825de3bb768ca34c54c90e0e659a
+  metadata.gz: af1cbeb37bf057e98955776c87dd5092fc5706af18d00ba818efccd2c52a076e
+  data.tar.gz: 1f4faf8f73b2cffa14bd3dda23dad4e401b524587c0f95d80e0cc9cbd4ba5d2b
 SHA512:
-  metadata.gz: b742461c737d8409d8a6f79eba36d4a3d87458e6f211086ff8c828264d76b5c6b3216cdb9b8ce216c3bbb3caa3a38dae2a430e9dd97faa624e8c3b15ceb0a749
-  data.tar.gz: 1b825d705594c244f34a9ff4df06e158f8fd63ebabd1bdf7c760ea52a50b816d8781eacd5b0627df394a39de62dc3572afd07261358df66e6d6f0b7cfa0846bf
+  metadata.gz: ace048c855b3711fd6b75692373318fe992a5c6529d322c13b516a7bd09390e36efec3f14edaa91ddeb223438d74c97c15ba4691077e9c77ce5063a10bdcc423
+  data.tar.gz: 9dcf787039edc02a56b7301f6849e76259628ac55da598a2878e4a08c63fd3c3aaef35bfea6bda8184c6e3552314fba7bb028962d81151ca98bf76f830c3303f

data/History.txt

@@ -1,3 +1,7 @@
+=== 2.7.4 / 30.03.2021
+* Update needed Ruby-Version to 2.5.0 in gemspec
+* Ensure downloads directory is created at first run
+
 === 2.7.3 / 29.03.2021
 * Do not delete swissmedic_package.xlsx and swissmedic_orphan.xlsx
 * Save swissmedic_package.xlsx and swissmedic_orphan.xlsx under downloads

data/lib/oddb2xml/downloader.rb

@@ -16,6 +16,7 @@ module Oddb2xml
       @file2save = File.join(DOWNLOADS, File.basename(file))
       report_download(@url, @file2save)
       data = nil
+      FileUtils.makedirs(File.dirname(file), verbose: true)
       if Oddb2xml.skip_download(file)
         io = File.open(file, option)
         data = io.read
@@ -23,6 +24,7 @@ module Oddb2xml
         begin
           io = File.open(file, option)
           data = Oddb2xml.uri_open(@url).read
+          io.sync = true
           io.write(data)
         rescue => error
           puts "error #{error} while fetching #{@url}"

data/lib/oddb2xml/version.rb

@@ -1,3 +1,3 @@
 module Oddb2xml
-  VERSION = "2.7.3"
+  VERSION = "2.7.4"
 end

data/oddb2xml.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
-  spec.required_ruby_version = ">= 2.2.0"
+  spec.required_ruby_version = ">= 2.5.0"
 
   # We fix the version of the spec to newer versions only in the third position
   # hoping that these version fix only security/severe bugs

data/spec/downloader_spec.rb

@@ -256,6 +256,7 @@ describe Oddb2xml::SwissmedicDownloader do
       end
       VCR.eject_cassette
       VCR.insert_cassette("oddb2xml", tag: :swissmedic, exclusive: false)
+      FileUtils.rm_rf(Oddb2xml::DOWNLOADS, verbose: true)
       common_before
       @downloader = Oddb2xml::SwissmedicDownloader.new(:orphan)
     end
@@ -276,9 +277,12 @@ describe Oddb2xml::SwissmedicDownloader do
           expect { bin }.not_to raise_error
           expect(File.exist?("oddb_orphan.xls")).to eq(false)
         end
+        expect(File.dirname(bin)).to be == (Oddb2xml::DOWNLOADS)
+        expect(File.exist?(bin)).to eq(true)
       end
-      it "should not save into the download directory" do
-        expect(File.exist?(File.join(Oddb2xml::DOWNLOADS, "oddb_orphan.xls"))).to eq(false)
+      it "should save into the download directory" do
+        expect(File.exist?(bin)).to eq(true)
+        expect(File.exist?(File.join(Oddb2xml::DOWNLOADS, "swissmedic_orphan.xlsx"))).to eq(true)
       end
     end
   end

data/spec/spec_helper.rb

@@ -164,7 +164,6 @@ module ServerMockHelper
   def cleanup_directories_before_run
     dirs = [Oddb2xml::DOWNLOADS, Oddb2xml::WORK_DIR]
     dirs.each { |dir| FileUtils.rm_rf(Dir.glob(File.join(dir, "*")), verbose: false) }
-    dirs.each { |dir| FileUtils.makedirs(dir, verbose: false) }
     cleanup_compressor
     mock_downloads
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: oddb2xml
 version: !ruby/object:Gem::Version
-  version: 2.7.3
+  version: 2.7.4
 platform: ruby
 authors:
 - Yasuhiro Asaka, Zeno R.R. Davatz, Niklaus Giger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-29 00:00:00.000000000 Z
+date: 2021-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -522,7 +522,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="