oddb2xml 2.6.9 → 2.7.4

data/spec/compressor_spec.rb

@@ -1,19 +1,19 @@
-# encoding: utf-8
+require "spec_helper"
 
-require 'spec_helper'
-
-shared_examples_for 'any compressor' do
-  it 'should create compress file' do
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_article.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_product.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_substance.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_limitation.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_fi.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_fi_product.xml')
-    expect(@compressor.finalize!).not_to be nil
+shared_examples_for "any compressor" do
+  it "should create compress file" do
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_article.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_product.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_substance.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_limitation.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_fi.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_fi_product.xml")
+    %(
+    expect{@compressor.finalize!}.not_to be nil
     compress_file = @compressor.instance_variable_get(:@compress_file)
-    expect(File.exists?(compress_file)).to eq(true)
+    expect(File.exist?(compress_file)).to eq(true)
     @compressor = nil
+    )
   end
 end
 
@@ -22,96 +22,96 @@ describe Oddb2xml::Compressor do
     cleanup_compressor
     if @compress_file
       compress_file = @compressor.instance_variable_get(:@compress_file)
-      FileUtils.rm_f(compress_file, :verbose => true)
+      FileUtils.rm_f(compress_file, verbose: true)
     end
   end
   after(:all) do
     cleanup_compressor
   end
-  context 'at initialize' do
-    context ' argment is given' do
+  context "at initialize" do
+    context " argment is given" do
       before(:each) do
         cleanup_directories_before_run
         @compressor = Oddb2xml::Compressor.new
       end
-      it 'should have empty contents as array' do
+      it "should have empty contents as array" do
         expect(@compressor.contents).to be_a Array
         expect(@compressor.contents).to be_empty
       end
-      it 'should have formated filename with datetime' do
-        expect(@compressor.instance_variable_get(:@compress_file)).
-          to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
+      it "should have formated filename with datetime" do
+        expect(@compressor.instance_variable_get(:@compress_file))
+          .to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
       end
     end
     context "when swiss prefix is given" do
       before(:each) do
         cleanup_directories_before_run
-        @compressor = Oddb2xml::Compressor.new('swiss', {:compress_ext => 'tar.gz'})
+        @compressor = Oddb2xml::Compressor.new("swiss", {compress_ext: "tar.gz"})
       end
-      it 'should have formated filename with datetime' do
-        expect(@compressor.instance_variable_get(:@compress_file)).
-          to match(/swiss_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
+      it "should have formated filename with datetime" do
+        expect(@compressor.instance_variable_get(:@compress_file))
+          .to match(/swiss_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
       end
     end
     context "when tar.gz ext is given" do
       before(:each) do
         cleanup_directories_before_run
-        @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'tar.gz'})
+        @compressor = Oddb2xml::Compressor.new("oddb", {compress_ext: "tar.gz"})
       end
-      it 'should have formated filename with datetime' do
-        expect(@compressor.instance_variable_get(:@compress_file)).
-          to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
+      it "should have formated filename with datetime" do
+        expect(@compressor.instance_variable_get(:@compress_file))
+          .to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
       end
     end
     context "when zip ext is given" do
       before(:each) do
         cleanup_directories_before_run
-        @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'zip'})
+        @compressor = Oddb2xml::Compressor.new("oddb", {compress_ext: "zip"})
       end
-      it 'should have formated filename with datetime' do
-        expect(@compressor.instance_variable_get(:@compress_file)).
-          to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.zip/)
+      it "should have formated filename with datetime" do
+        expect(@compressor.instance_variable_get(:@compress_file))
+          .to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.zip/)
       end
     end
   end
-  context 'when finalize! is called' do
-    context 'unexpectedly' do
+  context "when finalize! is called" do
+    context "unexpectedly" do
       before(:each) do
         cleanup_directories_before_run
-        @savedDir = Dir.pwd
+        @saved_dir = Dir.pwd
         Dir.chdir Oddb2xml::SpecCompressor
         @compressor = Oddb2xml::Compressor.new
       end
       after(:each) do
-        Dir.chdir @savedDir if @savedDir and File.directory?(@savedDir)
+        Dir.chdir @saved_dir if @saved_dir && File.directory?(@saved_dir)
       end
-      it 'should fail with no contents' do
+      it "should fail with no contents" do
         expect(@compressor.finalize!).to eq(false)
       end
-      it 'should fail with invalid file' do
-        @compressor.contents << '../invalid_file'
-        expect(@compressor.finalize!).to eq(false)
+      it "should fail with invalid file" do
+        @compressor.contents << "../invalid_file"
+        expect { @compressor.finalize! }.to raise_error(RuntimeError)
       end
     end
-    context 'successfully' do
-      context 'with tar.gz' do
+    context "successfully" do
+      context "with tar.gz" do
         before(:each) do
           cleanup_directories_before_run
           @compressor = Oddb2xml::Compressor.new
         end
-        it_behaves_like 'any compressor'
+        it_behaves_like "any compressor"
       end
-      context 'with zip' do
+      context "with zip" do
         before(:each) do
           cleanup_directories_before_run
-          @savedDir = Dir.pwd
+          @saved_dir = Dir.pwd
           Dir.chdir Oddb2xml::SpecCompressor
-          @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'zip'})
+          @compressor = Oddb2xml::Compressor.new("oddb", {compress_ext: "zip"})
         end
         after(:each) do
-          Dir.chdir @savedDir if @savedDir and File.directory?(@savedDir)
+          Dir.chdir @saved_dir if @saved_dir && File.directory?(@saved_dir)
         end
-        it_behaves_like 'any compressor' if true
+        it_behaves_like "any compressor"
       end
     end
   end

data/spec/data/refdata_NonPharma.xml

@@ -5,7 +5,6 @@
       <ITEM DT="2015-11-24 00:00:00 +000">
         <ATYPE>NONPHARMA</ATYPE>
         <GTIN>7611600441020</GTIN>
-        <PHAR>0058519</PHAR>
         <NAME_DE>TUBEGAZE Verband weiss Nr 12 20m Finger gross</NAME_DE>
         <NAME_FR>TUBEGAZE pans tubul blanc Nr 12 20m doigts grands</NAME_FR>
         <AUTH_HOLDER_NAME>IVF HARTMANN AG</AUTH_HOLDER_NAME>
@@ -14,7 +13,6 @@
       <ITEM DT="2015-11-24 00:00:00 +000">
         <ATYPE>NONPHARMA</ATYPE>
         <GTIN>00040565124308</GTIN>
-        <PHAR>4236863</PHAR>
         <NAME_DE>ACTICOAT Flex 7 Wundverband 10x12.5cm 5 Stk</NAME_DE>
         <NAME_FR>ACTICOAT Flex 7 pansement vulné 10x12.5cm 5 pce</NAME_FR>
         <AUTH_HOLDER_NAME>Smith &amp; Nephew Schweiz AG</AUTH_HOLDER_NAME>
@@ -32,7 +30,6 @@
       <ITEM DT="2018-03-16T00:00:00">
         <ATYPE>NONPHARMA</ATYPE>
         <GTIN>68711428066649</GTIN>
-        <PHAR>5863450</PHAR>
         <NAME_DE>3M MEDIPORE+PAD Absorbtionsverb 10x15cm 8 x 25 Stk</NAME_DE>
         <NAME_FR>3M MEDIPORE+PAD compr absorb 10x15cm 8 x 25 pce</NAME_FR>
         <AUTH_HOLDER_NAME>3M (Schweiz) GmbH (Professional Health Care)</AUTH_HOLDER_NAME>

data/spec/data/refdata_Pharma.xml

@@ -5,7 +5,6 @@
       <ITEM DT="2018-12-05T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680005850010</GTIN>
-        <PHAR>1770177</PHAR>
         <SWMC_AUTHNR>00585001</SWMC_AUTHNR>
         <NAME_DE>VARILRIX Trockensub c Solv Fertspr 0.5 ml</NAME_DE>
         <NAME_FR>VARILRIX subst sèche c solv ser pré 0.5 ml</NAME_FR>
@@ -16,7 +15,6 @@
       <ITEM DT="2017-12-14T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680545340019</GTIN>
-        <PHAR>6749124</PHAR>
         <SWMC_AUTHNR>54534001</SWMC_AUTHNR>
         <NAME_DE>TEBOKAN Filmtabl 240 mg 30 Stk</NAME_DE>
         <NAME_FR>TEBOKAN cpr pell 240 mg 30 pce</NAME_FR>
@@ -27,7 +25,6 @@
       <ITEM DT="2017-12-14T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680540150118</GTIN>
-        <PHAR>1882189</PHAR>
         <SWMC_AUTHNR>54015011</SWMC_AUTHNR>
         <NAME_DE>NAROPIN Inj Lös 0.2 % 10ml Duofit Amp 5 Stk</NAME_DE>
         <NAME_FR>NAROPIN sol inj 0.2 % 10ml amp duofit 5 pce</NAME_FR>
@@ -38,7 +35,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680563520172</GTIN>
-        <PHAR>6477223</PHAR>
         <SWMC_AUTHNR>56352017</SWMC_AUTHNR>
         <NAME_DE>ADVATE Trockensub 250 IE c Solv 2 ml Durchstf</NAME_DE>
         <NAME_FR>ADVATE subst sèche 250 UI c solv 2 ml flac</NAME_FR>
@@ -49,7 +45,6 @@
       <ITEM DT="2018-09-20T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680658560014</GTIN>
-        <PHAR>7199565</PHAR>
         <SWMC_AUTHNR>65856001</SWMC_AUTHNR>
         <NAME_DE>DIBASE Tropfen 10000 IE/ml Fl 10 ml</NAME_DE>
         <NAME_FR>DIBASE gouttes 10000 UI/ml fl 10 ml</NAME_FR>
@@ -60,7 +55,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680555580054</GTIN>
-        <PHAR>2465312</PHAR>
         <SWMC_AUTHNR>55558005</SWMC_AUTHNR>
         <NAME_DE>ZYVOXID Filmtabl 600 mg 10 Stk</NAME_DE>
         <NAME_FR>ZYVOXID cpr pell 600 mg 10 pce</NAME_FR>
@@ -71,7 +65,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680620690084</GTIN>
-        <PHAR>5819012</PHAR>
         <SWMC_AUTHNR>62069008</SWMC_AUTHNR>
         <NAME_DE>LEVETIRACETAM DESITIN Mini Filmtab 250 mg 30 Stk</NAME_DE>
         <NAME_FR>LEVETIRACETAM DESITIN mini cpr pel 250 mg 30 pce</NAME_FR>
@@ -82,7 +75,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680353660163</GTIN>
-        <PHAR>0020273</PHAR>
         <SWMC_AUTHNR>35366016</SWMC_AUTHNR>
         <NAME_DE>KENDURAL Depottabl 30 Stk</NAME_DE>
         <NAME_FR>KENDURAL cpr dépôt 30 pce</NAME_FR>
@@ -93,7 +85,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680536620137</GTIN>
-        <PHAR>1699947</PHAR>
         <SWMC_AUTHNR>53662013</SWMC_AUTHNR>
         <NAME_DE>3TC Filmtabl 150 mg 60 Stk</NAME_DE>
         <NAME_FR>3TC cpr pell 150 mg 60 pce</NAME_FR>
@@ -104,7 +95,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680161050583</GTIN>
-        <PHAR>2731179</PHAR>
         <SWMC_AUTHNR>16105058</SWMC_AUTHNR>
         <NAME_DE>HIRUDOID Creme 3 mg/g 40 g</NAME_DE>
         <NAME_FR>HIRUDOID crème 3 mg/g 40 g</NAME_FR>
@@ -115,7 +105,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680324750190</GTIN>
-        <PHAR>0023722</PHAR>
         <SWMC_AUTHNR>32475019</SWMC_AUTHNR>
         <NAME_DE>LANSOYL Gel 225 g</NAME_DE>
         <NAME_FR>LANSOYL gel 225 g</NAME_FR>
@@ -126,7 +115,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680573230016</GTIN>
-        <PHAR>6824802</PHAR>
         <SWMC_AUTHNR>57323001</SWMC_AUTHNR>
         <NAME_DE>LANSOPRAZOL Mepha Kaps 15 mg Fl 60 Stk</NAME_DE>
         <NAME_FR>LANSOPRAZOL Mepha caps 15 mg fl 60 pce</NAME_FR>
@@ -137,7 +125,6 @@
       <ITEM DT="2017-12-08T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680532900196</GTIN>
-        <PHAR>1699999</PHAR>
         <SWMC_AUTHNR>53290019</SWMC_AUTHNR>
         <NAME_DE>HUMALOG Inj Lös 100 IE/ml Durchstf 10 ml</NAME_DE>
         <NAME_FR>HUMALOG sol inj 100 UI/ml flac 10 ml</NAME_FR>
@@ -148,7 +135,6 @@
       <ITEM DT="2017-12-01T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680002770014</GTIN>
-        <PHAR>0361815</PHAR>
         <SWMC_AUTHNR>00277001</SWMC_AUTHNR>
         <NAME_DE>SEROCYTOL Herz-Gefässe Supp 3 Stk</NAME_DE>
         <NAME_FR>SEROCYTOL Coeur-Vaisseaux supp 3 pce</NAME_FR>
@@ -159,7 +145,6 @@
       <ITEM DT="2017-12-01T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680002780013</GTIN>
-        <PHAR>0361821</PHAR>
         <SWMC_AUTHNR>00278001</SWMC_AUTHNR>
         <NAME_DE>SEROCYTOL Kolon Supp 3 Stk</NAME_DE>
         <NAME_FR>SEROCYTOL Côlon supp 3 pce</NAME_FR>
@@ -170,7 +155,6 @@
       <ITEM DT="2017-12-01T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680406620144</GTIN>
-        <PHAR>0769841</PHAR>
         <SWMC_AUTHNR>40662014</SWMC_AUTHNR>
         <NAME_DE>PEVISONE Creme 15 g</NAME_DE>
         <NAME_FR>PEVISONE crème 15 g</NAME_FR>
@@ -181,7 +165,6 @@
       <ITEM DT="2017-12-01T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680406620229</GTIN>
-        <PHAR>0863244</PHAR>
         <SWMC_AUTHNR>40662022</SWMC_AUTHNR>
         <NAME_DE>PEVISONE Creme 30 g</NAME_DE>
         <NAME_FR>PEVISONE crème 30 g</NAME_FR>
@@ -192,7 +175,6 @@
       <ITEM DT="2017-11-03T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680587340015</GTIN>
-        <PHAR>4153628</PHAR>
         <SWMC_AUTHNR>58734001</SWMC_AUTHNR>
         <NAME_DE>YONDELIS Trockensub 0.25 mg Durchstf</NAME_DE>
         <NAME_FR>YONDELIS subst sèche 0.25 mg flac</NAME_FR>
@@ -203,7 +185,6 @@
       <ITEM DT="2017-11-03T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680627160016</GTIN>
-        <PHAR>5301924</PHAR>
         <SWMC_AUTHNR>62716001</SWMC_AUTHNR>
         <NAME_DE>COOP VITALITY Bronchialpastillen 40 Stk</NAME_DE>
         <NAME_FR>COOP VITALITY pastilles bronchiques 40 pce</NAME_FR>
@@ -214,7 +195,6 @@
       <ITEM DT="2018-01-30T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680651600014</GTIN>
-        <PHAR>6571270</PHAR>
         <SWMC_AUTHNR>65160001</SWMC_AUTHNR>
         <NAME_DE>LYNPARZA Kaps 50 mg 448 Stk</NAME_DE>
         <NAME_FR>LYNPARZA caps 50 mg 448 pce</NAME_FR>
@@ -225,7 +205,6 @@
       <ITEM DT="2018-02-09T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680316440115</GTIN>
-        <PHAR>0020244</PHAR>
         <SWMC_AUTHNR>31644011</SWMC_AUTHNR>
         <NAME_DE>FERRO-GRADUMET Depottabl 30 Stk</NAME_DE>
         <NAME_FR>FERRO-GRADUMET cpr dépôt 30 pce</NAME_FR>
@@ -236,7 +215,6 @@
       <ITEM DT="2018-03-16T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680581580011</GTIN>
-        <PHAR>3656617</PHAR>
         <SWMC_AUTHNR>58158001</SWMC_AUTHNR>
         <NAME_DE>PRIORIX TETRA Trockensub c Solv Fertspr</NAME_DE>
         <NAME_FR>PRIORIX TETRA subst sèche c solv ser pré</NAME_FR>
@@ -247,7 +225,6 @@
       <ITEM DT="2018-03-23T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680444470107</GTIN>
-        <PHAR>0919766</PHAR>
         <SWMC_AUTHNR>44447010</SWMC_AUTHNR>
         <NAME_DE>LOPRESOR Retard Divitabs 200 mg 14 Stk</NAME_DE>
         <NAME_FR>LOPRESOR Retard Divitabs 200 mg 14 pce</NAME_FR>
@@ -258,7 +235,6 @@
       <ITEM DT="2018-03-23T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680444470299</GTIN>
-        <PHAR>0919772</PHAR>
         <SWMC_AUTHNR>44447029</SWMC_AUTHNR>
         <NAME_DE>LOPRESOR Retard Divitabs 200 mg 56 Stk</NAME_DE>
         <NAME_FR>LOPRESOR Retard Divitabs 200 mg 56 pce</NAME_FR>
@@ -269,7 +245,6 @@
       <ITEM DT="2018-03-23T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680152190687</GTIN>
-        <PHAR>0544042</PHAR>
         <SWMC_AUTHNR>15219068</SWMC_AUTHNR>
         <NAME_DE>ZYMAFLUOR Tabl 0.25 mg Ds 400 Stk</NAME_DE>
         <NAME_FR>ZYMAFLUOR cpr 0.25 mg bte 400 pce</NAME_FR>
@@ -280,7 +255,6 @@
       <ITEM DT="2018-03-23T00:00:00">
         <ATYPE>PHARMA</ATYPE>
         <GTIN>7680434540995</GTIN>
-        <PHAR>2381532</PHAR>
         <SWMC_AUTHNR>43454099</SWMC_AUTHNR>
         <NAME_DE>KAMILLIN Medipharm Bad liq 10 Btl 40 ml</NAME_DE>
         <NAME_FR>KAMILLIN Medipharm bain liq 10 sach 40 ml</NAME_FR>

data/spec/data/transfer.dat

@@ -69,5 +69,6 @@
 1122069562EINF ARZNEI Urtinktur 1-10g/ml                    0010040013401000000000025000005884712
 1122069639EINF ARZNEI Ceres Urtinktur spez 20ml             0023440031301000000000025000005885322
 1122069622EINF ARZNEI Ceres Urtinktur 20ml                  0018870025201000000000025000005885252
+1130361821SEROCYTOL Kolon Supp 3 Stk                        002275003960401B080700076800027800132
 1131770177VARILRIX Trockensub c Solv (alt) Fertspr 0.5 ml   004768006650101B080800076800058500102
 1127766692VARILRIX Trockensub c Solv Fertspr 0.5 ml         004767006650101B080800076800058500342

data/spec/data/varia_De.htm

@@ -197,7 +197,7 @@
 <p>70.01.10</p>
     </td>
     <td width="52%">
-<p>Ceres Urtinkturen gem&auml;ss L2</p>
+<p>Ceres Urtinkturen gem&auml;ss L2 mit -- im Kommentar</p>
     </td>
     <td align="right" width="10%">
 <p>20ml</p>
@@ -2438,4 +2438,4 @@ die Abrechnung zu erleichtern.<br>
 
 </body>
 
-</html>
+</html>

data/spec/data_helper.rb

@@ -1,47 +1,47 @@
 #!/usr/bin/env ruby
 $:.unshift File.join(File.dirname(__FILE__))
-require 'spec_helper'
+require "spec_helper"
 module Oddb2xml
-# Small helper script to see, whether all files are correctly filled
-  def Oddb2xml.fill
+  # Small helper script to see, whether all files are correctly filled
+  def self.fill
     start_keys = [
-    1125822801,
-    1125830700,
-    1122465312,
-    1120020209,
-    1120020244,
-    1130020646,
-    1120020652,
-    1130021806,
-    1130021976,
-    1130023722,
-    1130027447,
-    1130028470,
-    1135366964,
-    1122871437,
-    1122871443,
-    1122871466,
-    1122871472,
-    1132867163,
-    1138110429,
-    1130598003,
-    1125565072,
-    1126000923,
-    1128111222,
-    1128111718,
-    1128807890,
-    1117199565,
-    1128111611,
-    ] 
-    
-    gtins = GTINS_DRUGS + [ FERRO_GRADUMET_GTIN,
-                  HIRUDOID_GTIN,LANSOYL_GTIN, LEVETIRACETAM_GTIN,
-                  SOFRADEX_GTIN, THREE_TC_GTIN, ZYVOXID_GTIN]
-    gtins.each{|gtin| Oddb2xml.check_gtin(gtin)}
+      1125822801,
+      1125830700,
+      1122465312,
+      1120020209,
+      1120020244,
+      1130020646,
+      1120020652,
+      1130021806,
+      1130021976,
+      1130023722,
+      1130027447,
+      1130028470,
+      1135366964,
+      1122871437,
+      1122871443,
+      1122871466,
+      1122871472,
+      1132867163,
+      1138110429,
+      1130598003,
+      1125565072,
+      1126000923,
+      1128111222,
+      1128111718,
+      1128807890,
+      1117199565,
+      1128111611
+    ]
 
-    ENV['LANG']= "de_CH.ISO-8859"
-    outfile = 'spec/data/transfer.dat'
-    FileUtils.rm_f(outfile, :verbose => true)
+    gtins = GTINS_DRUGS + [FERRO_GRADUMET_GTIN,
+      HIRUDOID_GTIN, LANSOYL_GTIN, LEVETIRACETAM_GTIN,
+      SOFRADEX_GTIN, THREE_TC_GTIN, ZYVOXID_GTIN]
+    gtins.each { |gtin| Oddb2xml.check_gtin(gtin) }
+
+    ENV["LANG"] = "de_CH.ISO-8859"
+    outfile = "spec/data/transfer.dat"
+    FileUtils.rm_f(outfile, verbose: true)
     start_keys.each do |key|
       cmd = "egrep '^#{key}' downloads/transfer.dat >> #{outfile}"
       system(cmd)
@@ -50,23 +50,21 @@ module Oddb2xml
     gtins.each do |key|
       cmd = "grep #{key} downloads/transfer.dat >> #{outfile}"
       system(cmd)
-      iksnrs << key.to_s[4..8] if /^7680/i.match(key.to_s)
+      iksnrs << key.to_s[4..8] if /^7680/i.match?(key.to_s)
     end
     puts "Created #{outfile} #{File.size(outfile)} bytes"
-    puts "Used IKSNRS are #{iksnrs.sort.uniq.join(' ')}"
+    puts "Used IKSNRS are #{iksnrs.sort.uniq.join(" ")}"
   end
-  
-  def Oddb2xml.check_gtin(gtin)
+
+  def self.check_gtin(gtin)
     files = `grep -l #{gtin} downloads/*.xml`.split("\n")
     files.each do |file|
-      short = File.join(SpecData,File.basename(file))
-      nrMatches = 0
-      nrMatches = `grep -c #{gtin} #{short}`.to_i if File.exist?(short)
-      puts "Could not find #{gtin} in #{short}" unless nrMatches > 0  
+      short = File.join(SpecData, File.basename(file))
+      nr_matches = 0
+      nr_matches = `grep -c #{gtin} #{short}`.to_i if File.exist?(short)
+      puts "Could not find #{gtin} in #{short}" unless nr_matches > 0
     end
   end
 end
 
 Oddb2xml.fill
-
-