oddb2xml 2.1.7 → 2.1.8

data/spec/calc_spec.rb

@@ -1,9 +1,5 @@
 # encoding: utf-8
 
-begin
-require 'pry'
-rescue LoadError
-end
 require 'pp'
 require 'spec_helper'
 require "rexml/document"
@@ -13,6 +9,8 @@ include Oddb2xml
 
 describe Oddb2xml::Calc do
   RunAllTests = true
+  before(:all) do  VCR.eject_cassette; VCR.insert_cassette('oddb2xml') end
+  after(:all) do   VCR.eject_cassette end
 
   after(:each) do
     FileUtils.rm(Dir.glob(File.join(Oddb2xml::WorkDir, '*.*')))
@@ -21,7 +19,7 @@ describe Oddb2xml::Calc do
   before(:each) do
     FileUtils.rm(Dir.glob(File.join(Oddb2xml::WorkDir, '*.xml')))
     FileUtils.rm(Dir.glob(File.join(Oddb2xml::WorkDir, '*.csv')))
-    setup_epha_atc_csv_mock
+    # setup_epha_atc_csv_mock
   end
 
   Line_1 = 'I) Glucoselösung: glucosum anhydricum 150 g ut glucosum monohydricum, natrii dihydrogenophosphas dihydricus 2.34 g, zinci acetas dihydricus 6.58 mg, aqua ad iniectabilia q.s. ad solutionem pro 500 ml.'
@@ -303,10 +301,6 @@ if RunAllTests
       src = File.expand_path(File.join(File.dirname(__FILE__), 'data', 'swissmedic_package-galenic.xlsx'))
       dest =  File.join(Oddb2xml::WorkDir, 'swissmedic_package.xlsx')
       FileUtils.makedirs(Oddb2xml::WorkDir)
-      FileUtils.cp(src, dest, { :verbose => true, :preserve => true})
-      FileUtils.cp(File.expand_path(File.join(File.dirname(__FILE__), 'data', 'XMLPublications.zip')),
-                  File.join(Oddb2xml::WorkDir, 'downloads'),
-                  { :verbose => true, :preserve => true})
       cli.run
       expected = [
         'oddb_calc.xml',
@@ -347,9 +341,10 @@ if RunAllTests
           result.should eq value.to_s
       }
       matri_name = 'Matricariae Extractum Isopropanolicum Liquidum'
-      XPath.match( doc, "//ARTICLE[GTIN='7680545250363']/COMPOSITIONS/COMPOSITION/SUBSTANCES/SUBSTANCE/SUBSTANCE_NAME").
-        find{|x| x.text.eql?("Alprostadilum")}.text.should eq 'Alprostadilum'
-#      XPath.match( doc, "//ARTICLE[GTIN='7680458820202']/NAME").last.text.should eq 'Magnesiumchlorid 0,5 molar B. Braun'
+      XPath.match( doc, "//ARTICLE[GTIN='7680002770014']/NAME").first.text.should eq "Coeur-Vaisseaux Sérocytol, suppositoire"
+      XPath.match( doc, "//ARTICLE[GTIN='7680545250363']").first.should eq nil
+#      XPath.match( doc, "//ARTICLE[GTIN='7680545250363']/COMPOSITIONS/COMPOSITION/SUBSTANCES/SUBSTANCE/SUBSTANCE_NAME")
+#        find{|x| x.text.eql?("Alprostadilum")}.text.should eq 'Alprostadilum'
       XPath.match( doc, "//ARTICLE[GTIN='7680458820202']/NAME").last.text.should eq 'Magnesiumchlorid 0,5 molar B. Braun, Zusatzampulle für Infusionslösungen'
       XPath.match( doc, "//ARTICLE[GTIN='7680458820202']/GALENIC_FORM").last.text.should match /Ampulle/i
       XPath.match( doc, "//ARTICLE[GTIN='7680555940018']/COMPOSITIONS/COMPOSITION/LABEL").first.text.should eq 'I'
@@ -360,7 +355,6 @@ if RunAllTests
 
       XPath.match( doc, "//ARTICLE[GTIN='7680434541015']/COMPOSITIONS/COMPOSITION/SUBSTANCES/SUBSTANCE/SUBSTANCE_NAME").
         find{|x| x.text.eql?(matri_name)}.text.should eq matri_name
-#      XPath.match( doc, "//ARTICLE[GTIN='7680434541015']/NAME").last.text.should eq 'Kamillin Medipharm'
       XPath.match( doc, "//ARTICLE[GTIN='7680434541015']/NAME").last.text.should eq 'Kamillin Medipharm, Bad'
       XPath.match( doc, "//ARTICLE[GTIN='7680434541015']/GALENIC_FORM").last.text.should eq 'Bad'
       XPath.match( doc, "//ARTICLE[GTIN='7680434541015']/COMPOSITIONS/COMPOSITION/SUBSTANCES/SUBSTANCE/QTY").first.text.should eq '98.9'
@@ -374,7 +368,6 @@ if RunAllTests
 
       XPath.match( doc, "//ARTICLE[GTIN='7680446250592']/COMPOSITIONS/COMPOSITION/SUBSTANCES/SUBSTANCE/SALTS/SALT/SUBSTANCE_NAME").first.text.should eq 'Ceftriaxonum Natricum'
 
-#      XPath.match( doc, "//ARTICLE[GTIN='7680611860045']/NAME").first.text.should eq 'Nutriflex Omega special'
       XPath.match( doc, "//ARTICLE[GTIN='7680611860045']/NAME").first.text.should eq 'Nutriflex Omega special, Infusionsemulsion 2500 ml'
       XPath.match( doc, "//ARTICLE[GTIN='7680611860045']/GALENIC_FORM").first.text.should eq 'Infusionsemulsion'
       XPath.match( doc, "//ARTICLE[GTIN='7680611860045']/SELLING_UNITS").first.text.should eq '5'

data/spec/cli_spec.rb

@@ -2,20 +2,6 @@
 
 require 'spec_helper'
 
-module Kernel
-  def cli_capture(stream)
-    begin
-      stream = stream.to_s
-      eval "$#{stream} = StringIO.new"
-      yield
-      result = eval("$#{stream}").string
-    ensure
-      eval "$#{stream} = #{stream.upcase}"
-    end
-    result
-  end
-end
-
 RSpec::Matchers.define :have_option do |option|
   match do |interface|
     key = option.keys.first
@@ -29,16 +15,16 @@ RSpec::Matchers.define :have_option do |option|
 end
 
 shared_examples_for 'any interface for product' do
-  it { cli_capture(:stdout) { cli.should respond_to(:run) } }
+  it { @cli.should respond_to(:run) }
   it 'should run successfully' do
-    cli_capture(:stdout){ cli.run }.should match(/products/)
+    @cli_output.should match(/products/)
   end
 end
 
 shared_examples_for 'any interface for address' do
-  it { cli_capture(:stdout) { cli.should respond_to(:run) } }
+  it { buildr_capture(:stdout) { @cli.should respond_to(:run) } }
   it 'should run successfully' do
-    cli_capture(:stdout){ cli.run }.should match(/addresses/)
+    @cli_output.should match(/addresses/)
   end
 end
 
@@ -46,78 +32,154 @@ describe Oddb2xml::Cli do
   # Setting ShouldRun to false and changing one -> if true allows you
   # to run easily the failing test
   include ServerMockHelper
-  before(:each) do
+  before(:all) do
+    VCR.eject_cassette
+    VCR.insert_cassette('oddb2xml')
     @savedDir = Dir.pwd
     cleanup_directories_before_run
-    setup_server_mocks
     Dir.chdir(Oddb2xml::WorkDir)
   end
-  after(:each) do
+  after(:all) do
     Dir.chdir(@savedDir) if @savedDir and File.directory?(@savedDir)
     cleanup_compressor
   end
+
+  context 'when -t md option is given' do
+    before(:all) do
+      cleanup_directories_before_run
+      options = Oddb2xml::Options.new
+      options.parser.parse!('-t md'.split(' '))
+      @cli = Oddb2xml::Cli.new(options.opts)
+      @cli_output = buildr_capture(:stdout) { @cli.run }
+    end
+    it_behaves_like 'any interface for product'
+    it 'should have tag_suffix option' do
+      @cli.should have_option(:tag_suffix=> 'MD')
+    end
+    it 'should not create a compressed file' do
+      Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.tar.gz')).first.should be_nil
+      Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.zip')).first.should be_nil
+    end
+    it 'should create xml files with prefix swiss_' do
+      expected = [
+        'md_product.xml',
+        'md_article.xml',
+        'md_limitation.xml',
+        'md_substance.xml',
+        'md_interaction.xml',
+        'md_code.xml'
+      ]
+      expected.each{
+          |name|
+        expect(Dir.glob(File.join(Oddb2xml::WorkDir, name)).size).to eq 1
+        expect(File.size(File.join(Oddb2xml::WorkDir, name))).to be >= 1024
+      }
+    end
+    it 'should produce a correct report' do
+      @cli_output.should match(/Pharma products:/)
+    end
+  end
+
   context 'when -c tar.gz option is given' do
-    let(:cli) do
+    before(:all) do
+      cleanup_directories_before_run
       options = Oddb2xml::Options.new
       options.parser.parse!('-c tar.gz'.split(' '))
-      Oddb2xml::Cli.new(options.opts)
+      @cli = Oddb2xml::Cli.new(options.opts)
+      @cli_output = buildr_capture(:stdout) { @cli.run }
+      # @cli_output = @cli.run # to debug
     end
+
     it_behaves_like 'any interface for product'
+    it 'should not create any xml file' do
+        @cli_output.should match(/Pharma/)
+        Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.xml')).each do |file|
+        File.exists?(file).should be_false
+      end
+    end
     it 'should have compress option' do
-      cli.should have_option(:compress_ext => 'tar.gz')
+      @cli.should have_option(:compress_ext => 'tar.gz')
     end
     it 'should create tar.gz file' do
-      cli_capture(:stdout) { cli.run }.should match(/Pharma/)
       file = Dir.glob(File.join(Dir.pwd, 'oddb_*.tar.gz')).first
       File.exists?(file).should eq true
     end
     it 'should not create any xml file' do
-      cli_capture(:stdout) { cli.run }.should match(/Pharma/)
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.xml')).each do |file|
         File.exists?(file).should be_false
       end
     end
   end
+
   context 'when -c zip option is given' do
-    let(:cli) do
+    before(:all) do
+      cleanup_directories_before_run
       options = Oddb2xml::Options.new
       options.parser.parse!('-c zip'.split(' '))
-      Oddb2xml::Cli.new(options.opts)
+      @cli = Oddb2xml::Cli.new(options.opts)
+      @cli_output = buildr_capture(:stdout) { @cli.run }
     end
     it_behaves_like 'any interface for product'
     it 'should have compress option' do
-      cli.should have_option(:compress_ext => 'zip')
+      @cli.should have_option(:compress_ext => 'zip')
     end
     it 'should create zip file' do
-      cli_capture(:stdout) { cli.run }.should match(/Pharma/)
+      @cli_output.should match(/Pharma/)
       file = Dir.glob(File.join(Dir.pwd, 'oddb_*.zip')).first
       File.exists?(file).should eq true
     end
     it 'should not create any xml file' do
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.xml')).each do |file| FileUtil.rm_f(file) end
-      cli_capture(:stdout) { cli.run }.should match(/Pharma/)
+      @cli_output.should match(/Pharma/)
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.xml')).each do |file|
         File.exists?(file).should be_false
       end
     end
   end
+
+  context 'when -f dat option is given' do
+    before(:all) do
+      cleanup_directories_before_run
+      options = Oddb2xml::Options.new
+      options.parser.parse!('-f dat'.split(' '))
+      @cli = Oddb2xml::Cli.new(options.opts)
+      @cli_output = buildr_capture(:stdout) { @cli.run }
+    end
+    it_behaves_like 'any interface for product'
+    it 'should have nonpharma option' do
+      @cli.should have_option(:format => :dat, :extended => false)
+    end
+    it 'should create the needed files' do
+      @cli_output.should match(/\sPharma\s/)
+      expected = [
+        'duplicate_ean13_from_zur_rose.txt',
+        'zurrose_transfer.dat',
+        'oddb.dat',
+      ].each{ |file|
+        File.exists?(File.join(Oddb2xml::WorkDir, file)).should eq true
+            }
+    end
+  end
+
   context 'when -a nonpharma option is given' do
-    let(:cli) do
+    before(:all) do
+      cleanup_directories_before_run
       options = Oddb2xml::Options.new
       options.parser.parse!('-a nonpharma'.split(' '))
-      Oddb2xml::Cli.new(options.opts)
+      @cli = Oddb2xml::Cli.new(options.opts)
+      @cli_output = buildr_capture(:stdout) { @cli.run }
     end
     it_behaves_like 'any interface for product'
     it 'should have nonpharma option' do
-      cli.should have_option(:nonpharma => true)
+      @cli.should have_option(:nonpharma => true)
     end
     it 'should not create any compressed file' do
-      cli_capture(:stdout) { cli.run }.should match(/NonPharma/)
+      @cli_output.should match(/NonPharma/)
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.tar.gz')).first.should be_nil
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.zip')).first.should be_nil
     end
     it 'should create xml files' do
-      cli_capture(:stdout) { cli.run }.should match(/NonPharma/)
+      @cli_output.should match(/NonPharma/)
       expected = [
         'oddb_product.xml',
         'oddb_article.xml',
@@ -132,22 +194,24 @@ describe Oddb2xml::Cli do
     end
   end
   context 'when -t _swiss option is given' do
-    let(:cli) do
+    before(:all) do
+      cleanup_directories_before_run
       options = Oddb2xml::Options.new
       options.parser.parse!('-t _swiss'.split(' '))
-      Oddb2xml::Cli.new(options.opts)
+      @cli = Oddb2xml::Cli.new(options.opts)
+      @cli_output = buildr_capture(:stdout) { @cli.run }
     end
     it_behaves_like 'any interface for product'
     it 'should have tag_suffix option' do
-      cli.should have_option(:tag_suffix=> '_SWISS')
+      @cli.should have_option(:tag_suffix=> '_SWISS')
     end
     it 'should not create any compressed file' do
-      cli_capture(:stdout) { cli.run }.should match(/Pharma/)
+      @cli_output.should match(/Pharma/)
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.tar.gz')).first.should be_nil
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.zip')).first.should be_nil
     end
     it 'should create xml files with prefix swiss_' do
-      cli_capture(:stdout) { cli.run }.should match(/Pharma/)
+      @cli_output.should match(/Pharma/)
       expected = [
         'swiss_product.xml',
         'swiss_article.xml',
@@ -162,22 +226,24 @@ describe Oddb2xml::Cli do
     end
   end
   context 'when -o fi option is given' do
-    let(:cli) do
+    before(:all) do
+      cleanup_directories_before_run
       options = Oddb2xml::Options.new
       options.parser.parse!('-o fi'.split(' '))
-      Oddb2xml::Cli.new(options.opts)
+      @cli = Oddb2xml::Cli.new(options.opts)
+      @cli_output = buildr_capture(:stdout) { @cli.run }
     end
     it_behaves_like 'any interface for product'
     it 'should have nonpharma option' do
-      cli.should have_option(:fi => true)
+      @cli.should have_option(:fi => true)
     end
     it 'should not create any compressed file' do
-      cli_capture(:stdout) { cli.run }.should match(/Pharma/)
+      @cli_output.should match(/Pharma/)
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.tar.gz')).first.should be_nil
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.zip')).first.should be_nil
     end
     it 'should create xml files' do
-      cli_capture(:stdout) { cli.run }.should match(/Pharma/)
+      @cli_output.should match(/Pharma/)
       expected = [
         'oddb_fi.xml',
         'oddb_fi_product.xml',
@@ -194,22 +260,24 @@ describe Oddb2xml::Cli do
     end
   end
   context 'when -x address option is given' do
-    let(:cli) do
+    before(:all) do
+      cleanup_directories_before_run
       options = Oddb2xml::Options.new
       options.parser.parse!('-x address'.split(' '))
-      Oddb2xml::Cli.new(options.opts)
+      @cli = Oddb2xml::Cli.new(options.opts)
+      @cli_output = buildr_capture(:stdout) { @cli.run }
     end
     it_behaves_like 'any interface for address'
     it 'should have address option' do
-      cli.should have_option(:address=> true)
+      @cli.should have_option(:address=> true)
     end
     it 'should not create any compressed file' do
-      cli_capture(:stdout) { cli.run }.should match(/addresses/)
+      @cli_output.should match(/addresses/)
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.tar.gz')).first.should be_nil
       Dir.glob(File.join(Oddb2xml::WorkDir, 'oddb_*.zip')).first.should be_nil
     end
     it 'should create xml files' do
-      cli_capture(:stdout) { cli.run }.should match(/addresses/)
+      @cli_output.should match(/addresses/)
       expected = [
         'oddb_betrieb.xml',
         'oddb_medizinalperson.xml',