odata4 0.8.0 → 0.8.1

data/lib/odata4/service.rb

@@ -1,3 +1,6 @@
+require 'odata4/service/request'
+require 'odata4/service/response'
+
 module OData4
   # Encapsulates the basic details and functionality needed to interact with an
   # OData4 service.
@@ -14,6 +17,7 @@ module OData4
     MIME_TYPES = {
       atom:  'application/atom+xml',
       json:  'application/json',
+      xml:   'application/xml',
       plain: 'text/plain'
     }
 
@@ -133,55 +137,11 @@ module OData4
 
     # Execute a request against the service
     #
-    # @param url_chunk [to_s] string to append to service url
-    # @param additional_options [Hash] options to pass to Typhoeus
-    # @return [Typhoeus::Response]
-    def execute(url_chunk, additional_options = {})
-      accept = content_type(additional_options.delete(:format) || :auto)
-      accept_header = {'Accept' => accept }
-
-      request_options = options[:typhoeus]
-        .merge({ method: :get })
-        .merge(additional_options)
-
-      # Don't overwrite Accept header if already present
-      unless request_options[:headers]['Accept']
-        request_options[:headers] = request_options[:headers].merge(accept_header)
-      end
-
-      request = ::Typhoeus::Request.new(
-        URI.join("#{service_url}/", URI.escape(url_chunk)),
-        request_options
-      )
-      logger.info "Requesting #{URI.unescape(request.url)}..."
-      request.run
-
-      response = request.response
-      logger.debug(response.headers)
-      logger.debug(response.body)
-
-      validate_response(response)
-      response
-    end
-
-    # Find a specific node in the given result set
-    #
-    # @param results [Typhoeus::Response]
-    # @return [Nokogiri::XML::Element]
-    def find_node(results, node_name)
-      document = ::Nokogiri::XML(results.body)
-      document.remove_namespaces!
-      document.xpath("//#{node_name}").first
-    end
-
-    # Find entity entries in a result set
-    #
-    # @param results [Typhoeus::Response]
-    # @return [Nokogiri::XML::NodeSet]
-    def find_entities(results)
-      document = ::Nokogiri::XML(results.body)
-      document.remove_namespaces!
-      document.xpath('//entry')
+    # @param url_chunk [to_s] string to append to service URL
+    # @param options [Hash] additional request options
+    # @return [OData4::Service::Response]
+    def execute(url_chunk, options = {})
+      Request.new(self, url_chunk, options).execute
     end
 
     # Get the property type for an entity from metadata.
@@ -256,57 +216,29 @@ module OData4
     def default_options
       {
         typhoeus: {
-          headers: { 'OData4-Version' => '4.0' },
+          headers: { 'OData-Version' => '4.0' },
           timeout: HTTP_TIMEOUT
         },
         strict: true # strict property validation
       }
     end
 
-    def content_type(format)
-      if format == :auto
-        MIME_TYPES.values.join(',')
-      elsif MIME_TYPES.has_key? format
-        MIME_TYPES[format]
-      else
-        raise ArgumentError, "Unknown format '#{format}'"
-      end
-    end
-
     def read_metadata
-      response = nil
       # From file, good for debugging
       if options[:metadata_file]
         data = File.read(options[:metadata_file])
         ::Nokogiri::XML(data).remove_namespaces!
       else # From a URL
+        response = nil
         METADATA_TIMEOUTS.each do |timeout|
-          response = ::Typhoeus::Request.get(URI.escape(metadata_url),
-                                             options[:typhoeus].merge(timeout: timeout))
+          response = execute(metadata_url, timeout: timeout)
           break unless response.timed_out?
         end
         raise "Metadata Timeout" if response.timed_out?
-        validate_response(response)
         ::Nokogiri::XML(response.body).remove_namespaces!
       end
     end
 
-    def validate_response(response)
-      raise "Bad Request. #{error_message(response)}" if response.code == 400
-      raise "Access Denied" if response.code == 401
-      raise "Forbidden" if response.code == 403
-      raise "Not Found" if [0,404].include?(response.code)
-      raise "Method Not Allowed" if response.code == 405
-      raise "Not Acceptable" if response.code == 406
-      raise "Request Entity Too Large" if response.code == 413
-      raise "Internal Server Error" if response.code == 500
-      raise "Service Unavailable" if response.code == 503
-    end
-
-    def error_message(response)
-      OData4::Query::Result.new(nil, response).error_message
-    end
-
     def register_custom_types
       complex_types.each do |name, type|
         ::OData4::PropertyRegistry.add(name, type.property_class)

data/lib/odata4/version.rb

@@ -1,3 +1,3 @@
 module OData4
-  VERSION = '0.8.0'
+  VERSION = '0.8.1'
 end

data/lib/odata4.rb

@@ -21,9 +21,6 @@ require 'odata4/enum_type'
 require 'odata4/entity'
 require 'odata4/entity_container'
 require 'odata4/entity_set'
-require 'odata4/query/criteria'
-require 'odata4/query/result'
-require 'odata4/query/in_batches'
 require 'odata4/query'
 require 'odata4/schema'
 require 'odata4/service'

data/spec/fixtures/files/entity_to_xml.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <entry xmlns="http://www.w3.org/2005/Atom" xmlns:data="http://docs.oasis-open.org/odata/ns/data" xmlns:metadata="http://docs.oasis-open.org/odata/ns/metadata" xmlns:georss="http://www.georss.org/georss" xmlns:gml="http://www.opengis.net/gml" xml:base="http://services.odata.org/V4/OData/OData.svc">
-  <category term="ODataDemo.ODataDemo.Product" scheme="http://docs.oasis-open.org/odata/ns/scheme"/>
+  <category term="ODataDemo.Product" scheme="http://docs.oasis-open.org/odata/ns/scheme"/>
   <author>
     <name/>
   </author>

data/spec/fixtures/files/error.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<m:error xmlns:m="http://docs.oasis-open.org/odata/ns/metadata">
+    <m:code />
+    <m:message>Resource not found for the segment 'Products'.</m:message>
+</m:error>

data/spec/fixtures/vcr_cassettes/service/request_specs.yml

@@ -0,0 +1,193 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://services.odata.org/V4/OData/OData.svc/Products
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Typhoeus - https://github.com/typhoeus/typhoeus
+      OData4-Version:
+      - '4.0'
+      Accept:
+      - application/atom+xml,application/json,application/xml,text/plain
+      Expect:
+      - ''
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - no-cache
+      Content-Length:
+      - '1981'
+      Content-Type:
+      - application/json;odata.metadata=minimal;odata.streaming=true;IEEE754Compatible=false;charset=utf-8
+      Server:
+      - Microsoft-IIS/10.0
+      X-Content-Type-Options:
+      - nosniff
+      OData-Version:
+      - 4.0;
+      X-AspNet-Version:
+      - 4.0.30319
+      X-Powered-By:
+      - ASP.NET
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET
+      Access-Control-Allow-Headers:
+      - Accept, Origin, Content-Type, MaxDataServiceVersion
+      Access-Control-Expose-Headers:
+      - DataServiceVersion
+      Date:
+      - Thu, 15 Feb 2018 19:55:09 GMT
+    body:
+      encoding: UTF-8
+      string: '{"@odata.context":"http://services.odata.org/V4/OData/OData.svc/$metadata#Products","value":[{"ID":0,"Name":"Bread","Description":"Whole
+        grain bread","ReleaseDate":"1992-01-01T00:00:00Z","DiscontinuedDate":null,"Rating":4,"Price":2.5},{"ID":1,"Name":"Milk","Description":"Low
+        fat milk","ReleaseDate":"1995-10-01T00:00:00Z","DiscontinuedDate":null,"Rating":3,"Price":3.5},{"ID":2,"Name":"Vint
+        soda","Description":"Americana Variety - Mix of 6 flavors","ReleaseDate":"2000-10-01T00:00:00Z","DiscontinuedDate":null,"Rating":3,"Price":20.9},{"ID":3,"Name":"Havina
+        Cola","Description":"The Original Key Lime Cola","ReleaseDate":"2005-10-01T00:00:00Z","DiscontinuedDate":"2006-10-01T00:00:00Z","Rating":3,"Price":19.9},{"ID":4,"Name":"Fruit
+        Punch","Description":"Mango flavor, 8.3 Ounce Cans (Pack of 24)","ReleaseDate":"2003-01-05T00:00:00Z","DiscontinuedDate":null,"Rating":3,"Price":22.99},{"ID":5,"Name":"Cranberry
+        Juice","Description":"16-Ounce Plastic Bottles (Pack of 12)","ReleaseDate":"2006-08-04T00:00:00Z","DiscontinuedDate":null,"Rating":3,"Price":22.8},{"ID":6,"Name":"Pink
+        Lemonade","Description":"36 Ounce Cans (Pack of 3)","ReleaseDate":"2006-11-05T00:00:00Z","DiscontinuedDate":null,"Rating":3,"Price":18.8},{"ID":7,"Name":"DVD
+        Player","Description":"1080P Upconversion DVD Player","ReleaseDate":"2006-11-15T00:00:00Z","DiscontinuedDate":null,"Rating":5,"Price":35.88},{"ID":8,"Name":"LCD
+        HDTV","Description":"42 inch 1080p LCD with Built-in Blu-ray Disc Player","ReleaseDate":"2008-05-08T00:00:00Z","DiscontinuedDate":null,"Rating":3,"Price":1088.8},{"@odata.type":"#ODataDemo.FeaturedProduct","ID":9,"Name":"Lemonade","Description":"Classic,
+        refreshing lemonade (Single bottle)","ReleaseDate":"1970-01-01T00:00:00Z","DiscontinuedDate":null,"Rating":7,"Price":1.01},{"@odata.type":"#ODataDemo.FeaturedProduct","ID":10,"Name":"Coffee","Description":"Bulk
+        size can of instant coffee","ReleaseDate":"1982-12-31T00:00:00Z","DiscontinuedDate":null,"Rating":1,"Price":6.99}]}'
+    http_version: '1.1'
+    adapter_metadata:
+      effective_url: http://services.odata.org/V4/OData/OData.svc/Products
+  recorded_at: Thu, 15 Feb 2018 19:55:10 GMT
+- request:
+    method: get
+    uri: http://services.odata.org/V4/OData/OData.svc/$metadata
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Typhoeus - https://github.com/typhoeus/typhoeus
+      OData4-Version:
+      - '4.0'
+      Expect:
+      - ''
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - no-cache
+      Content-Length:
+      - '6742'
+      Content-Type:
+      - application/xml;charset=utf-8
+      Server:
+      - Microsoft-IIS/10.0
+      X-Content-Type-Options:
+      - nosniff
+      OData-Version:
+      - 4.0;
+      X-AspNet-Version:
+      - 4.0.30319
+      X-Powered-By:
+      - ASP.NET
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET
+      Access-Control-Allow-Headers:
+      - Accept, Origin, Content-Type, MaxDataServiceVersion
+      Access-Control-Expose-Headers:
+      - DataServiceVersion
+      Date:
+      - Thu, 15 Feb 2018 20:48:14 GMT
+    body:
+      encoding: UTF-8
+      string: <?xml version="1.0" encoding="utf-8"?><edmx:Edmx Version="4.0" xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx"><edmx:DataServices><Schema
+        Namespace="ODataDemo" xmlns="http://docs.oasis-open.org/odata/ns/edm"><EntityType
+        Name="Product"><Key><PropertyRef Name="ID" /></Key><Property Name="ID" Type="Edm.Int32"
+        Nullable="false" /><Property Name="Name" Type="Edm.String" /><Property Name="Description"
+        Type="Edm.String" /><Property Name="ReleaseDate" Type="Edm.DateTimeOffset"
+        Nullable="false" /><Property Name="DiscontinuedDate" Type="Edm.DateTimeOffset"
+        /><Property Name="Rating" Type="Edm.Int16" Nullable="false" /><Property Name="Price"
+        Type="Edm.Double" Nullable="false" /><NavigationProperty Name="Categories"
+        Type="Collection(ODataDemo.Category)" Partner="Products" /><NavigationProperty
+        Name="Supplier" Type="ODataDemo.Supplier" Partner="Products" /><NavigationProperty
+        Name="ProductDetail" Type="ODataDemo.ProductDetail" Partner="Product" /></EntityType><EntityType
+        Name="FeaturedProduct" BaseType="ODataDemo.Product"><NavigationProperty Name="Advertisement"
+        Type="ODataDemo.Advertisement" Partner="FeaturedProduct" /></EntityType><EntityType
+        Name="ProductDetail"><Key><PropertyRef Name="ProductID" /></Key><Property
+        Name="ProductID" Type="Edm.Int32" Nullable="false" /><Property Name="Details"
+        Type="Edm.String" /><NavigationProperty Name="Product" Type="ODataDemo.Product"
+        Partner="ProductDetail" /></EntityType><EntityType Name="Category" OpenType="true"><Key><PropertyRef
+        Name="ID" /></Key><Property Name="ID" Type="Edm.Int32" Nullable="false" /><Property
+        Name="Name" Type="Edm.String" /><NavigationProperty Name="Products" Type="Collection(ODataDemo.Product)"
+        Partner="Categories" /></EntityType><EntityType Name="Supplier"><Key><PropertyRef
+        Name="ID" /></Key><Property Name="ID" Type="Edm.Int32" Nullable="false" /><Property
+        Name="Name" Type="Edm.String" /><Property Name="Address" Type="ODataDemo.Address"
+        /><Property Name="Location" Type="Edm.GeographyPoint" SRID="Variable" /><Property
+        Name="Concurrency" Type="Edm.Int32" ConcurrencyMode="Fixed" Nullable="false"
+        /><NavigationProperty Name="Products" Type="Collection(ODataDemo.Product)"
+        Partner="Supplier" /></EntityType><ComplexType Name="Address"><Property Name="Street"
+        Type="Edm.String" /><Property Name="City" Type="Edm.String" /><Property Name="State"
+        Type="Edm.String" /><Property Name="ZipCode" Type="Edm.String" /><Property
+        Name="Country" Type="Edm.String" /></ComplexType><EntityType Name="Person"><Key><PropertyRef
+        Name="ID" /></Key><Property Name="ID" Type="Edm.Int32" Nullable="false" /><Property
+        Name="Name" Type="Edm.String" /><NavigationProperty Name="PersonDetail" Type="ODataDemo.PersonDetail"
+        Partner="Person" /></EntityType><EntityType Name="Customer" BaseType="ODataDemo.Person"><Property
+        Name="TotalExpense" Type="Edm.Decimal" Nullable="false" /></EntityType><EntityType
+        Name="Employee" BaseType="ODataDemo.Person"><Property Name="EmployeeID" Type="Edm.Int64"
+        Nullable="false" /><Property Name="HireDate" Type="Edm.DateTimeOffset" Nullable="false"
+        /><Property Name="Salary" Type="Edm.Single" Nullable="false" /></EntityType><EntityType
+        Name="PersonDetail"><Key><PropertyRef Name="PersonID" /></Key><Property Name="PersonID"
+        Type="Edm.Int32" Nullable="false" /><Property Name="Age" Type="Edm.Byte" Nullable="false"
+        /><Property Name="Gender" Type="Edm.Boolean" Nullable="false" /><Property
+        Name="Phone" Type="Edm.String" /><Property Name="Address" Type="ODataDemo.Address"
+        /><Property Name="Photo" Type="Edm.Stream" Nullable="false" /><NavigationProperty
+        Name="Person" Type="ODataDemo.Person" Partner="PersonDetail" /></EntityType><EntityType
+        Name="Advertisement" HasStream="true"><Key><PropertyRef Name="ID" /></Key><Property
+        Name="ID" Type="Edm.Guid" Nullable="false" /><Property Name="Name" Type="Edm.String"
+        /><Property Name="AirDate" Type="Edm.DateTimeOffset" Nullable="false" /><NavigationProperty
+        Name="FeaturedProduct" Type="ODataDemo.FeaturedProduct" Partner="Advertisement"
+        /></EntityType><EntityContainer Name="DemoService"><EntitySet Name="Products"
+        EntityType="ODataDemo.Product"><NavigationPropertyBinding Path="ODataDemo.FeaturedProduct/Advertisement"
+        Target="Advertisements" /><NavigationPropertyBinding Path="Categories" Target="Categories"
+        /><NavigationPropertyBinding Path="Supplier" Target="Suppliers" /><NavigationPropertyBinding
+        Path="ProductDetail" Target="ProductDetails" /></EntitySet><EntitySet Name="ProductDetails"
+        EntityType="ODataDemo.ProductDetail"><NavigationPropertyBinding Path="Product"
+        Target="Products" /></EntitySet><EntitySet Name="Categories" EntityType="ODataDemo.Category"><NavigationPropertyBinding
+        Path="Products" Target="Products" /></EntitySet><EntitySet Name="Suppliers"
+        EntityType="ODataDemo.Supplier"><NavigationPropertyBinding Path="Products"
+        Target="Products" /></EntitySet><EntitySet Name="Persons" EntityType="ODataDemo.Person"><NavigationPropertyBinding
+        Path="PersonDetail" Target="PersonDetails" /></EntitySet><EntitySet Name="PersonDetails"
+        EntityType="ODataDemo.PersonDetail"><NavigationPropertyBinding Path="Person"
+        Target="Persons" /></EntitySet><EntitySet Name="Advertisements" EntityType="ODataDemo.Advertisement"><NavigationPropertyBinding
+        Path="FeaturedProduct" Target="Products" /></EntitySet></EntityContainer><Annotations
+        Target="ODataDemo.DemoService"><Annotation Term="Org.OData.Display.V1.Description"
+        String="This is a sample OData service with vocabularies" /></Annotations><Annotations
+        Target="ODataDemo.Product"><Annotation Term="Org.OData.Display.V1.Description"
+        String="All Products available in the online store" /></Annotations><Annotations
+        Target="ODataDemo.Product/Name"><Annotation Term="Org.OData.Display.V1.DisplayName"
+        String="Product Name" /></Annotations><Annotations Target="ODataDemo.DemoService/Suppliers"><Annotation
+        Term="Org.OData.Publication.V1.PublisherName" String="Microsoft Corp." /><Annotation
+        Term="Org.OData.Publication.V1.PublisherId" String="MSFT" /><Annotation Term="Org.OData.Publication.V1.Keywords"
+        String="Inventory, Supplier, Advertisers, Sales, Finance" /><Annotation Term="Org.OData.Publication.V1.AttributionUrl"
+        String="http://www.odata.org/" /><Annotation Term="Org.OData.Publication.V1.AttributionDescription"
+        String="All rights reserved" /><Annotation Term="Org.OData.Publication.V1.DocumentationUrl
+        " String="http://www.odata.org/" /><Annotation Term="Org.OData.Publication.V1.TermsOfUseUrl"
+        String="All rights reserved" /><Annotation Term="Org.OData.Publication.V1.PrivacyPolicyUrl"
+        String="http://www.odata.org/" /><Annotation Term="Org.OData.Publication.V1.LastModified"
+        String="4/2/2013" /><Annotation Term="Org.OData.Publication.V1.ImageUrl "
+        String="http://www.odata.org/" /></Annotations></Schema></edmx:DataServices></edmx:Edmx>
+    http_version: '1.1'
+    adapter_metadata:
+      effective_url: http://services.odata.org/V4/OData/OData.svc/$metadata
+  recorded_at: Thu, 15 Feb 2018 20:48:14 GMT
+recorded_with: VCR 4.0.0

data/spec/odata4/properties/collection_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe OData4::Properties::Collection do
+  let(:subject) { OData4::Properties::Collection.new('Names', names) }
+  let(:names) { %w[Dan Greg Jon] }
+  let(:new_names) { %w[Andrew Doug Paul] }
+
+  it { expect(subject.type).to eq('Collection(Edm.String)') }
+  it { expect(subject.value).to eq(['Dan', 'Greg', 'Jon']) }
+  it { expect(subject.url_value).to eq("['Dan','Greg','Jon']") }
+
+  describe '#value=' do
+    it 'allows an array of string values to be set' do
+      subject.value = new_names
+      expect(subject.value).to eq(new_names)
+    end
+  end
+
+  # TODO: Make collection type work properly with data types other than string
+  xcontext 'with value type other than Edm.String' do
+    let(:subject) { OData4::Properties::Collection.new('Bits', [1, 0, 1], value_type: 'Edm.Binary') }
+
+    it { expect(subject.type).to eq('Collection(Edm.Int32)') }
+    it { expect(subject.value).to eq([1, 0, 1]) }
+    it { expect(subject.url_value).to eq('[1,0,1]') }
+
+    it 'does not allow other property types to be set' do
+      expect {
+        subject.value = names
+      }.to raise_error(ArgumentError)
+    end
+
+    xdescribe 'lenient validation' do
+      let(:subject) do
+        OData4::Properties::Collection.new('Names', names, value_type: 'Edm.String', strict: false)
+      end
+
+      it 'ignores invalid values' do
+        subject.value = [1, 2, 3]
+        expect(subject.value).to eq([])
+      end
+    end
+  end
+end

data/spec/odata4/query_spec.rb

@@ -132,7 +132,7 @@ describe OData4::Query, vcr: {cassette_name: 'query_specs'} do
 
   describe '#execute' do
     it { expect(subject).to respond_to(:execute) }
-    it { expect(subject.execute).to be_a(OData4::Query::Result) }
+    it { expect(subject.execute).to be_a(OData4::Service::Response) }
   end
 
   describe '#count' do
@@ -166,7 +166,7 @@ describe OData4::Query, vcr: {cassette_name: 'query_specs'} do
       batch_count = entity_count = 0
 
       subject.in_batches(of: 5) do |batch|
-        expect(batch).to be_a(OData4::Query::Result)
+        expect(batch).to be_a(OData4::Service::Response)
         expect(batch.count).to eq(5) unless batch_count == 2
 
         batch.each do |entity|

data/spec/odata4/service/request_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe OData4::Service::Request, vcr: {cassette_name: 'service/request_specs'} do
+  let(:subject) { OData4::Service::Request.new(service, 'Products') }
+  let(:service) { OData4::Service.open(service_url, name: 'ODataDemo', metadata_file: metadata_file) }
+  let(:service_url) { 'http://services.odata.org/V4/OData/OData.svc' }
+  let(:metadata_file) { 'spec/fixtures/files/metadata.xml' }
+
+  describe '#url' do
+    it 'returns the full request URL' do
+      expect(subject.url).to eq('http://services.odata.org/V4/OData/OData.svc/Products')
+    end
+  end
+
+  describe '#method' do
+    it 'defaults to GET' do
+      expect(subject.method).to eq(:get)
+    end
+  end
+
+  describe '#format' do
+    it 'defaults to :auto' do
+      expect(subject.format).to eq(:auto)
+    end
+  end
+
+  describe '#content_type' do
+    it 'return all acceptable types when format = :auto' do
+      expect(subject.content_type).to eq(OData4::Service::MIME_TYPES.values.join(','))
+    end
+
+    it 'returns the correct MIME type when format = :atom' do
+      subject.format = :atom
+      expect(subject.content_type).to eq('application/atom+xml')
+    end
+
+    it 'returns the correct MIME type when format = :json' do
+      subject.format = :json
+      expect(subject.content_type).to eq('application/json')
+    end
+  end
+
+  describe '#execute' do
+    it 'returns a response object' do
+      expect(subject.execute).to be_a(OData4::Service::Response)
+    end
+    it 'retries on wrong content type'
+  end
+end

data/spec/odata4/service/response_spec.rb

@@ -0,0 +1,77 @@
+require 'spec_helper'
+
+shared_examples 'a valid response' do
+  it { expect(subject).to be_success }
+  it { expect(subject.count).to eq(11) }
+
+  describe '#empty?' do
+    it { expect(subject).to respond_to(:empty?) }
+    it { expect(subject.empty?).to eq(false) }
+  end
+
+  describe '#each' do
+    it { expect(subject).to respond_to(:each) }
+    it 'returns just OData4::Entities of the right type' do
+      subject.each do |entity|
+        expect(entity).to be_a(OData4::Entity)
+        expect(entity.type).to eq('ODataDemo.Product')
+      end
+    end
+  end
+end
+
+describe OData4::Service::Response, vcr: {cassette_name: 'service/response_specs'} do
+  let(:subject) { OData4::Service::Response.new(service, response, entity_set.query) }
+  let(:service) { OData4::Service.open(service_url, name: 'ODataDemo', metadata_file: metadata_file) }
+  let(:service_url) { 'http://services.odata.org/V4/OData/OData.svc' }
+  let(:metadata_file) { 'spec/fixtures/files/metadata.xml' }
+  let(:entity_set) { service['Products'] }
+  let(:response) do
+    response = double('response')
+    allow(response).to receive_messages(
+      headers: { 'Content-Type' => content_type },
+      code: response_status,
+      body: response_body
+    )
+    response
+  end
+
+  context 'with Atom result' do
+    let(:content_type) { 'application/atom+xml' }
+    let(:response_status) { 200 }
+    let(:response_body) { File.read('spec/fixtures/files/products.xml') }
+
+    it_behaves_like 'a valid response'
+  end
+
+  context 'with JSON result' do
+    let(:content_type) { 'application/json' }
+    let(:response_status) { 200 }
+    let(:response_body) { File.read('spec/fixtures/files/products.json') }
+
+    it_behaves_like 'a valid response'
+  end
+
+  context 'with XML result' do
+    let(:content_type) { 'application/xml' }
+    let(:response_status) { 200 }
+    let(:response_body) { File.read('spec/fixtures/files/error.xml') }
+
+    it 'contains no entities' do
+      expect(subject.empty?).to eq(true)
+    end
+
+    it 'contains error message' do
+      expect(subject.error_message).to match(/Resource not found/)
+    end
+  end
+
+  context 'with plain text result' do
+    let(:content_type) { 'text/plain' }
+    let(:response_status) { 200 }
+    let(:response_body) { '123' }
+
+    it { expect(subject).to be_success }
+    it { expect(subject.body).to match(/123/) }
+  end
+end