odata-model 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 995370eea78ea8a601aa51f63c24d4c5b44ca21f
-  data.tar.gz: 8407abe05108d9cd8ea77715de0b34feb45d0256
+  metadata.gz: 3f3848c44d4405013bdf8759766f32d0d7eed788
+  data.tar.gz: 514c663ad8f2fe30635444b96eb38c00208dffbd
 SHA512:
-  metadata.gz: 83cbbcb630063ab7b5ea5b09842890da0e2bbbad209904f44118e7c7acd4b923b62c176e7fbe9e3795cf9d776fcc1d0d171f8e5f3c17112a8f376c0373673c80
-  data.tar.gz: 43e2eabce06e6bf56c687ba98714263943673aafc1bf15abe967fcded63f7681c6d5da38907373565be0ff141ba8f30edfd5e9b4567513e504883e695819ab6c
+  metadata.gz: 92d82ecb0dec062b31c58eeb57698150e9d04a65eb766639bfa7f416fdb4813641a4b359d92693e5782f492bc1711164240a75ca093f7cb56602fdc6786c7002
+  data.tar.gz: 26535f3f30778fea0a13daf60bee9d17c3e5192ab0ef7973c087736f36304505fae8e998fdb7dd71444acb5e3f5d21e6cf3fcfc69f985aa2b0d48d47ec1038ed

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 0.4.1
+
+* Added validation a property exists for an Entity when setting up its mapping.
+
 ## 0.4.0
 
 * Removed strict dependency on ActiveModel.

data/lib/odata/model/attributes.rb

@@ -36,6 +36,7 @@ module OData
         def property(literal_name, options = {})
           attribute_name = (options[:as] || literal_name.to_s.underscore).to_sym
 
+          validate_attribute(literal_name)
           register_attribute(attribute_name, literal_name, options)
           create_accessors(attribute_name)
 
@@ -80,6 +81,17 @@ module OData
           end
         end
 
+        # Validates the existence of the supplied attribute on the relevant
+        # Entity.
+        # @param property_name [to_s]
+        # @api private
+        def validate_attribute(property_name)
+          valid_properties = odata_service.properties_for(odata_entity_set.type)
+          unless valid_properties[property_name.to_s]
+            raise ArgumentError, "property #{property_name} does not exist for #{odata_entity_set.type} entity"
+          end
+        end
+
         # Registers a supplied attribute with its literal property name and any
         # provided options.
         # @return [nil]

data/lib/odata/model/configuration.rb

@@ -76,6 +76,7 @@ module OData
         # @return [nil]
         def limit_default_selection
           odata_config[:limit_default_selection] = true
+          nil
         end
 
         # Get the OData::Service

data/lib/odata/model/version.rb

@@ -1,5 +1,5 @@
 module OData
   module Model
-    VERSION = '0.4.0'
+    VERSION = '0.4.1'
   end
 end

data/odata-model.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = OData::Model::VERSION
   spec.authors       = ['James Thompson']
   spec.email         = %w{james@buypd.com}
-  spec.summary       = 'An ActiveModel mapping layer for the OData gem'
-  spec.description   = 'A mapping layer for the OData gem that integrates with ActiveModel'
+  spec.summary       = 'A basic mapping layer for the OData gem'
+  spec.description   = 'A mapping layer for the OData gem that can integrate with ActiveModel'
   spec.homepage      = 'https://github.com/ruby-odata/odata-model'
   spec.license       = 'MIT'
 
@@ -23,10 +23,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'simplecov', '~> 0.9.0'
   spec.add_development_dependency 'codeclimate-test-reporter'
   spec.add_development_dependency 'rspec', '~> 3.0.0'
-
   spec.add_development_dependency 'activemodel', '>= 3.0.0'
 
-  spec.add_dependency 'odata', '~> 0.5'
+  spec.add_dependency 'odata', '~> 0.5.0'
   spec.add_dependency 'activesupport', '>= 3.0.0'
 
   spec.add_dependency 'slop', '~> 3.6.0'

data/spec/model/property_defaults_spec.rb

@@ -18,5 +18,18 @@ describe OData::Model do
 
     it { expect(Product.new).to respond_to(:attributes) }
     it { expect(Product.new.attributes).to eq(attributes) }
+
+    it 'raises an error if the property does not exist on the entity' do
+      expect {
+        class InvalidProduct
+          include OData::Model
+
+          use_service 'ODataDemo'
+          for_entity 'Product'
+
+          property 'NonExistent'
+        end
+      }.to raise_error(ArgumentError, 'property NonExistent does not exist for Product entity')
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: odata-model
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - James Thompson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-31 00:00:00.000000000 Z
+date: 2014-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: 0.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -136,7 +136,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.6.0
-description: A mapping layer for the OData gem that integrates with ActiveModel
+description: A mapping layer for the OData gem that can integrate with ActiveModel
 email:
 - james@buypd.com
 executables:
@@ -200,7 +200,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: An ActiveModel mapping layer for the OData gem
+summary: A basic mapping layer for the OData gem
 test_files:
 - spec/example_models/bare_model.rb
 - spec/example_models/odatademo_limited_product.rb