octokit 4.6.2 → 6.1.1

data/lib/octokit/client/issues.rb

@@ -1,11 +1,11 @@
+# frozen_string_literal: true
+
 module Octokit
   class Client
-
     # Methods for the Issues API
     #
     # @see https://developer.github.com/v3/issues/
     module Issues
-
       # List issues for the authenticated user or repository
       #
       # @param repository [Integer, String, Repository, Hash] A GitHub repository.
@@ -28,10 +28,10 @@ module Octokit
       #   @client = Octokit::Client.new(:login => 'foo', :password => 'bar')
       #   @client.list_issues
       def list_issues(repository = nil, options = {})
-        path = repository ? "#{Repository.new(repository).path}/issues" : "issues"
+        path = repository ? "#{Repository.new(repository).path}/issues" : 'issues'
         paginate path, options
       end
-      alias :issues :list_issues
+      alias issues list_issues
 
       # List all issues across owned and member repositories for the authenticated user
       #
@@ -81,6 +81,7 @@ module Octokit
       # @param body [String] An optional concise description
       # @param options [Hash] A customizable set of options.
       # @option options [String] :assignee User login.
+      # @option options [Array<String>] :assignees User login.
       # @option options [Integer] :milestone Milestone number.
       # @option options [String] :labels List of comma separated Label names. Example: <tt>bug,ui,@high</tt>.
       # @return [Sawyer::Resource] Your newly created issue
@@ -90,17 +91,17 @@ module Octokit
       def create_issue(repo, title, body = nil, options = {})
         options[:labels] = case options[:labels]
                            when String
-                             options[:labels].split(",").map(&:strip)
+                             options[:labels].split(',').map(&:strip)
                            when Array
                              options[:labels]
                            else
                              []
                            end
-        parameters = { :title => title }
+        parameters = { title: title }
         parameters[:body] = body unless body.nil?
         post "#{Repository.path repo}/issues", options.merge(parameters)
       end
-      alias :open_issue :create_issue
+      alias open_issue create_issue
 
       # Get a single issue from a repository
       #
@@ -120,6 +121,7 @@ module Octokit
       # @param number [Integer] Number ID of the issue
       # @param options [Hash] A customizable set of options.
       # @option options [String] :assignee User login.
+      # @option options [Array<String>] :assignees User login.
       # @option options [Integer] :milestone Milestone number.
       # @option options [Array<String>] :labels List of Label names. Example: <tt>['bug', 'ui', '@high']</tt>.
       # @return [Sawyer::Resource] The updated Issue
@@ -127,7 +129,7 @@ module Octokit
       # @example Close Issue #25 from octokit/octokit.rb
       #   Octokit.close_issue("octokit/octokit.rb", "25")
       def close_issue(repo, number, options = {})
-        patch "#{Repository.path repo}/issues/#{number}", options.merge({:state => "closed"})
+        patch "#{Repository.path repo}/issues/#{number}", options.merge({ state: 'closed' })
       end
 
       # Reopen an issue
@@ -136,6 +138,7 @@ module Octokit
       # @param number [Integer] Number ID of the issue
       # @param options [Hash] A customizable set of options.
       # @option options [String] :assignee User login.
+      # @option options [Array<String>] :assignees User login.
       # @option options [Integer] :milestone Milestone number.
       # @option options [Array<String>] :labels List of Label names. Example: <tt>['bug', 'ui', '@high']</tt>.
       # @return [Sawyer::Resource] The updated Issue
@@ -143,7 +146,7 @@ module Octokit
       # @example Reopen Issue #25 from octokit/octokit.rb
       #   Octokit.reopen_issue("octokit/octokit.rb", "25")
       def reopen_issue(repo, number, options = {})
-        patch "#{Repository.path repo}/issues/#{number}", options.merge({:state => "open"})
+        patch "#{Repository.path repo}/issues/#{number}", options.merge({ state: 'open' })
       end
 
       # Lock an issue's conversation, limiting it to collaborators
@@ -179,6 +182,7 @@ module Octokit
       #   @param body [String] Updated body of the issue
       #   @param options [Hash] A customizable set of options.
       #   @option options [String] :assignee User login.
+      #   @option options [Array<String>] :assignees User login.
       #   @option options [Integer] :milestone Milestone number.
       #   @option options [String] :labels List of comma separated Label names. Example: <tt>bug,ui,@high</tt>.
       #   @option options [String] :state State of the issue. <tt>open</tt> or <tt>closed</tt>
@@ -190,6 +194,7 @@ module Octokit
       #   @option options [String] :title Updated title for the issue
       #   @option options [String] :body Updated body of the issue
       #   @option options [String] :assignee User login.
+      #   @option options [Array<String>] :assignees User login.
       #   @option options [Integer] :milestone Milestone number.
       # @option options [Array<String>] :labels List of Label names. Example: <tt>['bug', 'ui', '@high']</tt>.
       #   @option options [String] :state State of the issue. <tt>open</tt> or <tt>closed</tt>
@@ -205,7 +210,7 @@ module Octokit
         arguments = Arguments.new(args)
         opts = arguments.options
 
-        if arguments.length > 0
+        unless arguments.empty?
           opts[:title] = arguments.shift
           opts[:body] = arguments.shift
         end
@@ -261,7 +266,7 @@ module Octokit
       # @return [Sawyer::Resource] The specific comment in question
       # @see https://developer.github.com/v3/issues/comments/#get-a-single-comment
       # @example Get comment #1194549 from an issue on octokit/octokit.rb
-      #   Octokit.issue_comments("octokit/octokit.rb", 1194549)
+      #   Octokit.issue_comment("octokit/octokit.rb", 1194549)
       def issue_comment(repo, number, options = {})
         paginate "#{Repository.path repo}/issues/comments/#{number}", options
       end
@@ -276,7 +281,7 @@ module Octokit
       # @example Add the comment "Almost to v1" to Issue #23 on octokit/octokit.rb
       #   Octokit.add_comment("octokit/octokit.rb", 23, "Almost to v1")
       def add_comment(repo, number, comment, options = {})
-        post "#{Repository.path repo}/issues/#{number}/comments", options.merge({:body => comment})
+        post "#{Repository.path repo}/issues/#{number}/comments", options.merge({ body: comment })
       end
 
       # Update a single comment on an issue
@@ -289,7 +294,7 @@ module Octokit
       # @example Update the comment #1194549 with body "I've started this on my 25-issue-comments-v3 fork" on an issue on octokit/octokit.rb
       #   Octokit.update_comment("octokit/octokit.rb", 1194549, "Almost to v1, added this on my fork")
       def update_comment(repo, number, comment, options = {})
-        patch "#{Repository.path repo}/issues/comments/#{number}", options.merge({:body => comment})
+        patch "#{Repository.path repo}/issues/comments/#{number}", options.merge({ body: comment })
       end
 
       # Delete a single comment
@@ -313,9 +318,50 @@ module Octokit
       # @example Get timeline for issue #1435 on octokit/octokit.rb
       #   Octokit.issue_timeline("octokit/octokit.rb", 1435)
       def issue_timeline(repo, number, options = {})
-        options = ensure_api_media_type(:issue_timelines, options)
         paginate "#{Repository.path repo}/issues/#{number}/timeline", options
       end
+
+      # Lists the available assignees for issues in a repository.
+      #
+      # @param repo [Integer, String, Repository, Hash] A GitHub repository
+      # @return [Array<Sawyer::Resource>] List of GitHub users.
+      # @see https://developer.github.com/v3/issues/assignees/#list-assignees
+      # @example Get available assignees on repository octokit/octokit.rb
+      #   Octokit.list_assignees("octokit/octokit.rb")
+      def list_assignees(repo, options = {})
+        paginate "#{Repository.path repo}/assignees", options
+      end
+
+      # Add assignees to an issue
+      #
+      # @param repo [Integer, String, Repository, Hash] A GitHub repository
+      # @param number [Integer] Issue number
+      # @param assignees [Array<String>] Assignees to be added
+      # @return [Sawyer::Resource] Issue
+      # @see https://developer.github.com/v3/issues/assignees/#add-assignees-to-an-issue
+      # @example Add assignees "pengwynn" and "joeyw" to Issue #23 on octokit/octokit.rb
+      #   Octokit.add_assignees("octokit/octokit.rb", 23, ["pengwynn", "joeyw"])
+      def add_assignees(repo, number, assignees, options = {})
+        post "#{Repository.path repo}/issues/#{number}/assignees", options.merge({ assignees: assignees })
+      end
+
+      # Remove assignees from an issue
+      #
+      # @param repo [Integer, String, Repository, Hash] A GitHub repository
+      # @param number [Integer] Issue number
+      # @param assignees [Array<String>] Assignees to be removed
+      # @param options [Hash] Header params for request
+      # @return [Sawyer::Resource] Issue
+      # @see https://developer.github.com/v3/issues/assignees/#remove-assignees-from-an-issue
+      # @example Remove assignees "pengwynn" and "joeyw" from Issue #23 on octokit/octokit.rb
+      #   Octokit.remove_assignees("octokit/octokit.rb", 23, ["pengwynn", "joeyw"])
+      #
+      # @example Remove assignees "pengwynn" from Issue #23 on octokit/octokit.rb
+      #   Octokit.remove_assignees("octokit/octokit.rb", 23, ["pengwynn"],
+      #     :accept => "application/vnd.github.v3+json")
+      def remove_assignees(repo, number, assignees, options = {})
+        delete "#{Repository.path repo}/issues/#{number}/assignees", options.merge({ assignees: assignees })
+      end
     end
   end
 end

data/lib/octokit/client/labels.rb

@@ -1,13 +1,13 @@
-require 'cgi'
+# frozen_string_literal: true
+
+require 'erb'
 
 module Octokit
   class Client
-
     # Methods for the Issue Labels API
     #
     # @see https://developer.github.com/v3/issues/labels/
     module Labels
-
       # List available labels for a repository
       #
       # @param repo [Integer, String, Repository, Hash] A GitHub repository
@@ -26,9 +26,9 @@ module Octokit
       # @return [Sawyer::Resource] A single label from the repository
       # @see https://developer.github.com/v3/issues/labels/#get-a-single-label
       # @example Get the "V3 Addition" label from octokit/octokit.rb
-      #   Octokit.labels("octokit/octokit.rb", "V3 Addition")
+      #   Octokit.label("octokit/octokit.rb", "V3 Addition")
       def label(repo, name, options = {})
-        get "#{Repository.path repo}/labels/#{name}", options
+        get "#{Repository.path repo}/labels/#{ERB::Util.url_encode(name)}", options
       end
 
       # Add a label to a repository
@@ -40,8 +40,8 @@ module Octokit
       # @see https://developer.github.com/v3/issues/labels/#create-a-label
       # @example Add a new label "Version 1.0" with color "#cccccc"
       #   Octokit.add_label("octokit/octokit.rb", "Version 1.0", "cccccc")
-      def add_label(repo, label, color="ffffff", options = {})
-        post "#{Repository.path repo}/labels", options.merge({:name => label, :color => color})
+      def add_label(repo, label, color = 'ffffff', options = {})
+        post "#{Repository.path repo}/labels", options.merge({ name: label, color: color })
       end
 
       # Update a label
@@ -56,7 +56,7 @@ module Octokit
       # @example Update the label "Version 1.0" with new color "#cceeaa"
       #   Octokit.update_label("octokit/octokit.rb", "Version 1.0", {:color => "cceeaa"})
       def update_label(repo, label, options = {})
-        patch "#{Repository.path repo}/labels/#{label}", options
+        patch "#{Repository.path repo}/labels/#{ERB::Util.url_encode(label)}", options
       end
 
       # Delete a label from a repository.
@@ -70,7 +70,7 @@ module Octokit
       # @example Delete the label "Version 1.0" from the repository.
       #   Octokit.delete_label!("octokit/octokit.rb", "Version 1.0")
       def delete_label!(repo, label, options = {})
-        boolean_from_response :delete, "#{Repository.path repo}/labels/#{label}", options
+        boolean_from_response :delete, "#{Repository.path repo}/labels/#{ERB::Util.url_encode(label)}", options
       end
 
       # Remove a label from an Issue
@@ -78,14 +78,14 @@ module Octokit
       # This removes the label from the Issue
       #
       # @param repo [Integer, String, Repository, Hash] A GitHub repository
-      # @param number [Fixnum] Number ID of the issue
+      # @param number [Integer] Number ID of the issue
       # @param label [String] String name of the label
       # @return [Array<Sawyer::Resource>] A list of the labels currently on the issue
       # @see https://developer.github.com/v3/issues/labels/#remove-a-label-from-an-issue
       # @example Remove the label "Version 1.0" from the repository.
       #   Octokit.remove_label("octokit/octokit.rb", 23, "Version 1.0")
       def remove_label(repo, number, label, options = {})
-        delete "#{Repository.path repo}/issues/#{number}/labels/#{label}", options
+        delete "#{Repository.path repo}/issues/#{number}/labels/#{ERB::Util.url_encode(label)}", options
       end
 
       # Remove all label from an Issue
@@ -93,7 +93,7 @@ module Octokit
       # This removes the label from the Issue
       #
       # @param repo [Integer, String, Repository, Hash] A GitHub repository
-      # @param number [Fixnum] Number ID of the issue
+      # @param number [Integer] Number ID of the issue
       # @return [Boolean] Success of operation
       # @see https://developer.github.com/v3/issues/labels/#remove-all-labels-from-an-issue
       # @example Remove all labels from Issue #23
@@ -105,7 +105,7 @@ module Octokit
       # List labels for a given issue
       #
       # @param repo [Integer, String, Repository, Hash] A GitHub repository
-      # @param number [Fixnum] Number ID of the issue
+      # @param number [Integer] Number ID of the issue
       # @return [Array<Sawyer::Resource>] A list of the labels currently on the issue
       # @see https://developer.github.com/v3/issues/labels/#list-labels-on-an-issue
       # @example List labels for octokit/octokit.rb, issue # 1
@@ -117,7 +117,7 @@ module Octokit
       # Add label(s) to an Issue
       #
       # @param repo [Integer, String, Repository, Hash] A Github repository
-      # @param number [Fixnum] Number ID of the issue
+      # @param number [Integer] Number ID of the issue
       # @param labels [Array] An array of labels to apply to this Issue
       # @return [Array<Sawyer::Resource>] A list of the labels currently on the issue
       # @see https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue
@@ -130,20 +130,20 @@ module Octokit
       # Replace all labels on an Issue
       #
       # @param repo [Integer, String, Repository, Hash] A Github repository
-      # @param number [Fixnum] Number ID of the issue
+      # @param number [Integer] Number ID of the issue
       # @param labels [Array] An array of labels to use as replacement
       # @return [Array<Sawyer::Resource>] A list of the labels currently on the issue
       # @see https://developer.github.com/v3/issues/labels/#replace-all-labels-for-an-issue
       # @example Replace labels for octokit/octokit.rb Issue #10
       #   Octokit.replace_all_labels("octokit/octokit.rb", 10, ['V3 Transition', 'Improvement'])
-      def replace_all_labels(repo, number, labels, options = {})
+      def replace_all_labels(repo, number, labels, _options = {})
         put "#{Repository.path repo}/issues/#{number}/labels", labels
       end
 
       # Get labels for every issue in a milestone
       #
       # @param repo [Integer, String, Repository, Hash] A GitHub repository
-      # @param number [Fixnum] Number ID of the milestone
+      # @param number [Integer] Number ID of the milestone
       # @return [Array<Sawyer::Resource>] A list of the labels across the milestone
       # @see  http://developer.github.com/v3/issues/labels/#get-labels-for-every-issue-in-a-milestone
       # @example List all labels for milestone #2 on octokit/octokit.rb

data/lib/octokit/client/legacy_search.rb

@@ -1,11 +1,11 @@
+# frozen_string_literal: true
+
 module Octokit
   class Client
-
     # Methods for the Legacy Search API
     #
     # @see https://developer.github.com/v3/search/
     module LegacySearch
-
       # Legacy repository search
       #
       # @see https://developer.github.com/v3/search/#search-repositories
@@ -23,7 +23,7 @@ module Octokit
       # @return [Array<Sawyer::Resource>] A list of issues matching the search term and state
       # @example Search for 'test' in the open issues for sferik/rails_admin
       #   Octokit.search_issues("sferik/rails_admin", 'test', 'open')
-      def legacy_search_issues(repo, search_term, state='open', options = {})
+      def legacy_search_issues(repo, search_term, state = 'open', options = {})
         get("legacy/issues/search/#{Repository.new(repo)}/#{state}/#{search_term}", options)['issues']
       end
 

data/lib/octokit/client/licenses.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 module Octokit
   class Client
-
     # Methods for licenses API
     #
     module Licenses
-
       # List all licenses
       #
       # @see https://developer.github.com/v3/licenses/#list-all-licenses
@@ -12,8 +12,7 @@ module Octokit
       # @example
       #   Octokit.licenses
       def licenses(options = {})
-        options = ensure_api_media_type(:licenses, options)
-        paginate "licenses", options
+        paginate 'licenses', options
       end
 
       # List an individual license
@@ -24,7 +23,6 @@ module Octokit
       # @example
       #   Octokit.license 'mit'
       def license(license_name, options = {})
-        options = ensure_api_media_type(:licenses, options)
         get "licenses/#{license_name}", options
       end
 
@@ -35,9 +33,8 @@ module Octokit
       # @option options [String] :ref name of the Commit/Branch/Tag. Defaults to 'master'.
       # @return [Sawyer::Resource] The detail of the license file
       # @example
-      #   Octokit.license_contents 'benbalter/licensee'
+      #   Octokit.repository_license_contents 'benbalter/licensee'
       def repository_license_contents(repo, options = {})
-        options = ensure_api_media_type(:licenses, options)
         get "#{Repository.path repo}/license", options
       end
     end

data/lib/octokit/client/markdown.rb

@@ -1,11 +1,11 @@
+# frozen_string_literal: true
+
 module Octokit
   class Client
-
     # Methods for the Markdown API
     #
     # @see https://developer.github.com/v3/markdown/
     module Markdown
-
       # Render an arbitrary Markdown document
       #
       # @param text [String] Markdown source
@@ -20,7 +20,7 @@ module Octokit
         options[:repo] = Repository.new(options[:repo]) if options[:repo]
         options[:accept] = 'application/vnd.github.raw'
 
-        post "markdown", options
+        post 'markdown', options
       end
     end
   end

data/lib/octokit/client/marketplace.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+module Octokit
+  class Client
+    # Methods for the Marketplace Listing API
+    #
+    # @see https://developer.github.com/v3/apps/marketplace/
+    module Marketplace
+      # List all plans for an app's marketplace listing
+      #
+      # @param options [Hash] A customizable set of options
+      #
+      # @see https://developer.github.com/v3/apps/marketplace/#list-all-plans-for-your-marketplace-listing
+      #
+      # @return [Array<Sawyer::Resource>] A list of plans
+      def list_plans(options = {})
+        paginate '/marketplace_listing/plans', options
+      end
+
+      # List all GitHub accounts on a specific plan
+      #
+      # @param plan_id [Integer] The id of the GitHub plan
+      # @param options [Hash] A customizable set of options
+      #
+      # @see https://developer.github.com/v3/apps/marketplace/#list-all-github-accounts-user-or-organization-on-a-specific-plan
+      #
+      # @return [Array<Sawyer::Resource>] A list of accounts
+      def list_accounts_for_plan(plan_id, options = {})
+        paginate "/marketplace_listing/plans/#{plan_id}/accounts", options
+      end
+
+      # Get the plan associated with a given GitHub account
+      #
+      # @param account_id [Integer] The id of the GitHub account
+      # @param options [Hash] A customizable set of options
+      #
+      # @see https://developer.github.com/v3/apps/marketplace/#check-if-a-github-account-is-associated-with-any-marketplace-listing
+      #
+      # @return <Sawyer::Resource> Account with plan details, or nil
+      def plan_for_account(account_id, options = {})
+        get "/marketplace_listing/accounts/#{account_id}", options
+      end
+
+      # Get user's Marketplace purchases
+      #
+      # @param options [Hash] A customizable set of options
+      #
+      # @see https://developer.github.com/v3/apps/marketplace/#get-a-users-marketplace-purchases
+      #
+      # @return [Array<Sawyer::Resource>] A list of Marketplace purchases
+      def marketplace_purchases(options = {})
+        get '/user/marketplace_purchases', options
+      end
+    end
+  end
+end

data/lib/octokit/client/meta.rb

@@ -1,21 +1,20 @@
+# frozen_string_literal: true
+
 module Octokit
   class Client
-
     # Methods for the Meta API
     #
     # @see https://developer.github.com/v3/meta/
     module Meta
-
       # Get meta information about GitHub.com, the service.
       # @see https://developer.github.com/v3/meta/#meta
       # @return [Sawyer::Resource] Hash with meta information.
       # @example Get GitHub meta information
       #   @client.github_meta
       def meta(options = {})
-        get "meta", options
+        get 'meta', options
       end
-      alias :github_meta :meta
-
+      alias github_meta meta
     end
   end
 end

data/lib/octokit/client/milestones.rb

@@ -1,11 +1,11 @@
+# frozen_string_literal: true
+
 module Octokit
   class Client
-
     # Methods for the Issues Milestones API
     #
     # @see https://developer.github.com/v3/issues/milestones/
     module Milestones
-
       # List milestones for a repository
       #
       # @param repository [Integer, String, Repository, Hash] A GitHub repository
@@ -21,7 +21,7 @@ module Octokit
       def list_milestones(repository, options = {})
         paginate "#{Repository.path repository}/milestones", options
       end
-      alias :milestones :list_milestones
+      alias milestones list_milestones
 
       # Get a single milestone for a repository
       #
@@ -49,7 +49,7 @@ module Octokit
       # @example Create a milestone for a repository
       #   Octokit.create_milestone("octokit/octokit.rb", "0.7.0", {:description => 'Add support for v3 of Github API'})
       def create_milestone(repository, title, options = {})
-        post "#{Repository.path repository}/milestones", options.merge({:title => title})
+        post "#{Repository.path repository}/milestones", options.merge({ title: title })
       end
 
       # Update a milestone for a repository
@@ -68,7 +68,7 @@ module Octokit
       def update_milestone(repository, number, options = {})
         patch "#{Repository.path repository}/milestones/#{number}", options
       end
-      alias :edit_milestone :update_milestone
+      alias edit_milestone update_milestone
 
       # Delete a single milestone for a repository
       #

data/lib/octokit/client/notifications.rb

@@ -1,11 +1,11 @@
+# frozen_string_literal: true
+
 module Octokit
   class Client
-
     # Methods for the Notifications API
     #
     # @see https://developer.github.com/v3/activity/notifications/
     module Notifications
-
       # List your notifications
       #
       # @param options [Hash] Optional parameters
@@ -24,7 +24,7 @@ module Octokit
       # @example Get all notifications since a certain time.
       #   @client.notifications({all: true, since: '2012-10-09T23:39:01Z'})
       def notifications(options = {})
-        paginate "notifications", options
+        paginate 'notifications', options
       end
 
       # List your notifications in a repository
@@ -48,7 +48,7 @@ module Octokit
       def repository_notifications(repo, options = {})
         paginate "#{Repository.path repo}/notifications", options
       end
-      alias :repo_notifications :repository_notifications
+      alias repo_notifications repository_notifications
 
       # Mark notifications as read
       #
@@ -66,7 +66,7 @@ module Octokit
       # @example
       #   @client.mark_notifications_as_read
       def mark_notifications_as_read(options = {})
-        request :put, "notifications", options
+        request :put, 'notifications', options
 
         last_response.status == 205
       end
@@ -91,7 +91,7 @@ module Octokit
 
         last_response.status == 205
       end
-      alias :mark_repo_notifications_as_read :mark_repository_notifications_as_read
+      alias mark_repo_notifications_as_read mark_repository_notifications_as_read
 
       # List notifications for a specific thread
       #
@@ -108,10 +108,6 @@ module Octokit
       # Mark thread as read
       #
       # @param thread_id [Integer] Id of the thread to update.
-      # @param options [Hash] Optional parameters.
-      # @option options [Boolean] :unread Changes the unread status of the
-      #   threads.
-      # @option options [Boolean] :read Inverse of 'unread'.
       # @return [Boolean] True if updated, false otherwise.
       # @see https://developer.github.com/v3/activity/notifications/#mark-a-thread-as-read
       # @example