octokit 1.19.0 → 1.20.0

data/spec/octokit/client/authorizations_spec.rb

@@ -53,7 +53,7 @@ describe Octokit::Client::Authorizations do
     stub_delete('/authorizations/999999').
       to_return(:status => 204)
     result = @client.delete_authorization(999999)
-    expect(result).to be_true
+    expect(result).to eq(true)
   end
 
   context "when working with tokens" do

data/spec/octokit/client/commits_spec.rb

@@ -239,7 +239,7 @@ describe Octokit::Client::Commits do
       stub_delete("/repos/sferik/rails_admin/comments/860296").
         to_return(:status => 204, :body => "")
       commit_comment = @client.delete_commit_comment("sferik/rails_admin", "860296")
-      expect(commit_comment).to be_true
+      expect(commit_comment).to eq(true)
     end
 
   end

data/spec/octokit/client/downloads_spec.rb

@@ -56,7 +56,7 @@ describe Octokit::Client::Downloads do
     it "deletes a download" do
       stub_request(:delete, "https://api.github.com/repos/octocat/Hellow-World/downloads/165347").
         to_return(:status => 204, :body => "", :headers => {})
-      expect(@client.delete_download('octocat/Hellow-World', 165347)).to be_true
+      expect(@client.delete_download('octocat/Hellow-World', 165347)).to eq(true)
     end
   end
 

data/spec/octokit/client/gists_spec.rb

@@ -86,7 +86,7 @@ describe Octokit::Client::Gists do
     it "stars an existing gist" do
       stub_put("/gists/12345/star").to_return(:status => 204)
       success = @client.star_gist(12345)
-      expect(success).to be_true
+      expect(success).to eq(true)
     end
   end
 
@@ -94,7 +94,7 @@ describe Octokit::Client::Gists do
     it "unstars an existing gist" do
       stub_delete("/gists/12345/star").to_return(:status => 204)
       success = @client.unstar_gist(12345)
-      expect(success).to be_true
+      expect(success).to eq(true)
     end
   end
 
@@ -102,7 +102,7 @@ describe Octokit::Client::Gists do
     it "is starred" do
       stub_get("/gists/12345/star").to_return(:status => 204)
       starred = @client.gist_starred?(12345)
-      expect(starred).to be_true
+      expect(starred).to eq(true)
     end
 
     it "is not starred" do
@@ -114,7 +114,7 @@ describe Octokit::Client::Gists do
 
   describe ".fork_gist" do
     it "forks an existing gist" do
-      stub_post("/gists/12345/fork").
+      stub_post("/gists/12345/forks").
         to_return(json_response("gist.json"))
 
       gist = @client.fork_gist(12345)
@@ -126,7 +126,7 @@ describe Octokit::Client::Gists do
     it "deletes an existing gist" do
       stub_delete("/gists/12345").to_return(:status => 204)
       deleted = @client.delete_gist(12345)
-      expect(deleted).to be_true
+      expect(deleted).to eq(true)
     end
   end
 
@@ -171,7 +171,7 @@ describe Octokit::Client::Gists do
     it "deletes a gist comment" do
       stub_delete("/gists/4bcad24/comments/12345").to_return(:status => 204)
       result = @client.delete_gist_comment("4bcad24", 12345)
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
   end
 

data/spec/octokit/client/gitignore_spec.rb

@@ -0,0 +1,29 @@
+# -*- encoding: utf-8 -*-
+require 'helper'
+
+describe Octokit::Client::Gitignore do
+
+  before do
+    @client = Octokit::Client.new
+  end
+
+  describe ".gitignore_templates" do
+    it "returns all gitignore templates" do
+      stub_get("/gitignore/templates").
+        to_return(json_response("gitignore_templates.json"))
+      templates = @client.gitignore_templates
+      expect(templates.first).to eq("Actionscript")
+    end
+  end
+
+  describe ".gitignore_template" do
+    it "returns the ruby gitignore template" do
+      stub_get("/gitignore/templates/Ruby").
+        to_return(json_response("gitignore_template_ruby.json"))
+      template = @client.gitignore_template("Ruby")
+      expect(template.name).to eq("Ruby")
+      expect(template.source).to include("*.gem\n")
+    end
+  end
+
+end

data/spec/octokit/client/issues_spec.rb

@@ -113,6 +113,17 @@ describe Octokit::Client::Issues do
 
   end
 
+  describe ".repository_issues_comments" do
+
+    it "returns comments for all issues in a repository" do
+      stub_get("/repos/pengwynn/octokit/issues/comments").
+        to_return(json_response('repository_issues_comments.json'))
+      comments = @client.issues_comments("pengwynn/octokit")
+      expect(comments.first.user.login).to eq("pengwynn")
+    end
+
+  end
+
   describe ".issue_comments" do
 
     it "returns comments for an issue" do
@@ -166,7 +177,7 @@ describe Octokit::Client::Issues do
       stub_delete("/repos/pengwynn/octokit/issues/comments/1194549").
         to_return(:status => 204)
       result = @client.delete_comment("pengwynn/octokit", 1194549)
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end

data/spec/octokit/client/labels_spec.rb

@@ -72,7 +72,7 @@ describe Octokit::Client::Labels do
        to_return(:status => 204)
 
       result = @client.delete_label!("pengwynn/octokit", "V3 Transition")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -96,7 +96,7 @@ describe Octokit::Client::Labels do
        to_return(:status => 204)
 
      result = @client.remove_all_labels('pengwynn/octokit', 23)
-     expect(result).to be_true
+     expect(result).to eq(true)
     end
 
   end

data/spec/octokit/client/milestones_spec.rb

@@ -59,7 +59,7 @@ describe Octokit::Client::Milestones do
       stub_delete("/repos/pengwynn/octokit/milestones/2").
         to_return(:status => 204, :body => "", :headers => {})
       result = @client.delete_milestone("pengwynn/octokit", 2)
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end

data/spec/octokit/client/notifications_spec.rb

@@ -14,7 +14,7 @@ describe Octokit::Client::Notifications do
         to_return(json_response("notifications.json"))
       notifications = @client.notifications
       expect(notifications.first.id).to eq(1)
-      expect(notifications.first.unread).to be_true
+      expect(notifications.first.unread).to eq(true)
     end
 
   end
@@ -26,7 +26,7 @@ describe Octokit::Client::Notifications do
         to_return(json_response("repository_notifications.json"))
       notifications = @client.repository_notifications("pengwynn/octokit")
       expect(notifications.first.id).to eq(1)
-      expect(notifications.first.unread).to be_true
+      expect(notifications.first.unread).to eq(true)
     end
 
   end
@@ -37,7 +37,7 @@ describe Octokit::Client::Notifications do
       stub_put("https://api.github.com/notifications").
         to_return(:status => 205)
       result = @client.mark_notifications_as_read
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
     it "returns false when unsuccessful" do
@@ -55,7 +55,7 @@ describe Octokit::Client::Notifications do
       stub_put("https://api.github.com/repos/pengwynn/octokit/notifications").
         to_return(:status => 205)
       result = @client.mark_repository_notifications_as_read("pengwynn/octokit")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
     it "returns false when unsuccessful" do
@@ -74,7 +74,7 @@ describe Octokit::Client::Notifications do
         to_return(json_response('notification_thread.json'))
       notifications = @client.thread_notifications(1)
       expect(notifications.first.id).to eq(1)
-      expect(notifications.first.unread).to be_true
+      expect(notifications.first.unread).to eq(true)
     end
 
   end
@@ -85,7 +85,7 @@ describe Octokit::Client::Notifications do
       stub_patch("https://api.github.com/notifications/threads/1").
         to_return(:status => 205)
       result = @client.mark_thread_as_read(1)
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
     it "returns false when unsuccessful" do
@@ -103,7 +103,7 @@ describe Octokit::Client::Notifications do
       stub_get("https://api.github.com/notifications/threads/1/subscription").
         to_return(json_response("thread_subscription.json"))
       subscription = @client.thread_subscription(1)
-      expect(subscription.subscribed).to be_true
+      expect(subscription.subscribed).to eq(true)
     end
 
   end
@@ -114,7 +114,7 @@ describe Octokit::Client::Notifications do
       stub_put("https://api.github.com/notifications/threads/1/subscription").
         to_return(json_response("thread_subscription_update.json"))
       subscription = @client.update_thread_subscription(1, :subscribed => true)
-      expect(subscription.subscribed).to be_true
+      expect(subscription.subscribed).to eq(true)
     end
 
   end
@@ -125,12 +125,12 @@ describe Octokit::Client::Notifications do
       stub_delete("https://api.github.com/notifications/threads/1").
         to_return(:status => 204)
       result = @client.delete_thread_subscription(1)
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
     it "returns false when subscription deletion fails" do
       stub_delete("https://api.github.com/notifications/threads/1").
-        to_return(:status => 500)
+        to_return(:status => 404)
       result = @client.delete_thread_subscription(1)
       expect(result).to be_false
     end

data/spec/octokit/client/organizations_spec.rb

@@ -86,7 +86,7 @@ describe Octokit::Client::Organizations do
         stub_get("https://api.github.com/orgs/github/members/pengwynn").
           to_return(:status => 204)
         is_hubbernaut = @client.organization_member?('github', 'pengwynn')
-        expect(is_hubbernaut).to be_true
+        expect(is_hubbernaut).to eq(true)
       end
 
     end
@@ -112,7 +112,7 @@ describe Octokit::Client::Organizations do
         stub_get("https://api.github.com/orgs/github/public_members/pengwynn").
           to_return(:status => 204)
         is_hubbernaut = @client.organization_public_member?('github', 'pengwynn')
-        expect(is_hubbernaut).to be_true
+        expect(is_hubbernaut).to eq(true)
       end
 
     end
@@ -182,7 +182,7 @@ describe Octokit::Client::Organizations do
       stub_delete("https://api.github.com/teams/32598").
         to_return(:status => 204)
       result = @client.delete_team(32598)
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -206,7 +206,7 @@ describe Octokit::Client::Organizations do
         with(:name => "sferik").
         to_return(:status => 204)
       result = @client.add_team_member(32598, "sferik")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -217,7 +217,7 @@ describe Octokit::Client::Organizations do
       stub_delete("https://api.github.com/teams/32598/members/sferik").
         to_return(:status => 204)
       result = @client.remove_team_member(32598, "sferik")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -227,7 +227,7 @@ describe Octokit::Client::Organizations do
       stub_delete("https://api.github.com/orgs/codeforamerica/members/glow-mdsol").
           to_return(:status => 204)
       result = @client.remove_organization_member("codeforamerica", "glow-mdsol")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -250,7 +250,7 @@ describe Octokit::Client::Organizations do
         with(:name => "reddavis/One40Proof").
         to_return(:status => 204)
       result = @client.add_team_repository(32598, "reddavis/One40Proof")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -261,7 +261,7 @@ describe Octokit::Client::Organizations do
       stub_delete("https://api.github.com/teams/32598/repos/reddavis/One40Proof").
         to_return(:status => 204)
       result = @client.remove_team_repository(32598, "reddavis/One40Proof")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -273,7 +273,7 @@ describe Octokit::Client::Organizations do
         with(:name => "sferik").
         to_return(:status => 204)
       result = @client.publicize_membership("codeforamerica", "sferik")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -285,7 +285,7 @@ describe Octokit::Client::Organizations do
         with(:name => "sferik").
         to_return(:status => 204)
       result = @client.unpublicize_membership("codeforamerica", "sferik")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end

data/spec/octokit/client/pulls_spec.rb

@@ -57,6 +57,17 @@ describe Octokit::Client::Pulls do
 
   end
 
+  describe ".pull_requests_comments" do
+
+    it "returns all comments on all pull requests" do
+      stub_get("https://api.github.com/repos/pengwynn/octokit/pulls/comments").
+        to_return(json_response("pull_requests_comments.json"))
+      comments = @client.pull_requests_comments("pengwynn/octokit")
+      expect(comments.first.user.login).to eq("sferik")
+    end
+
+  end
+
   describe ".pull_request" do
 
     it "returns a pull request" do
@@ -156,7 +167,7 @@ describe Octokit::Client::Pulls do
       stub_delete("https://api.github.com/repos/pengwynn/octokit/pulls/comments/1907270").
         to_return(:status => 204)
       result = @client.delete_pull_request_comment("pengwynn/octokit", 1907270)
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -192,7 +203,7 @@ describe Octokit::Client::Pulls do
       stub_get("https://api.github.com/repos/pengwynn/octokit/pulls/67/merge").
         to_return(:status => 204)
       merged = @client.pull_merged?("pengwynn/octokit", 67)
-      expect(merged).to be_true
+      expect(merged).to eq(true)
     end
   end
 

data/spec/octokit/client/refs_spec.rb

@@ -70,7 +70,7 @@ describe Octokit::Client::Refs do
       stub_delete("/repos/octocat/Hello-World/git/refs/heads/feature-a").
         to_return(:status => 204)
       result = @client.delete_ref("octocat/Hello-World", "heads/feature-a")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end

data/spec/octokit/client/repositories_spec.rb

@@ -68,12 +68,23 @@ describe Octokit::Client::Repositories do
 
   end
 
+  describe ".all_repositories" do
+
+    it "returns all repositories on github" do
+      stub_get("/repositories").
+        to_return(json_response("all_repositories.json"))
+      repositories = @client.all_repositories
+      expect(repositories.first.name).to eq("grit")
+    end
+
+  end
+
   describe ".star" do
 
     it "stars a repository" do
       stub_put("/user/starred/sferik/rails_admin").
         to_return(:status => 204)
-      expect(@client.star("sferik/rails_admin")).to be_true
+      expect(@client.star("sferik/rails_admin")).to eq(true)
     end
 
   end
@@ -83,7 +94,7 @@ describe Octokit::Client::Repositories do
     it "unstars a repository" do
       stub_delete("/user/starred/sferik/rails_admin").
         to_return(:status => 204)
-      expect(@client.unstar("sferik/rails_admin")).to be_true
+      expect(@client.unstar("sferik/rails_admin")).to eq(true)
     end
 
   end
@@ -93,7 +104,7 @@ describe Octokit::Client::Repositories do
     it "watches a repository" do
       stub_put("/user/watched/sferik/rails_admin").
         to_return(:status => 204)
-      expect(@client.watch("sferik/rails_admin")).to be_true
+      expect(@client.watch("sferik/rails_admin")).to eq(true)
     end
 
   end
@@ -103,7 +114,7 @@ describe Octokit::Client::Repositories do
     it "unwatches a repository" do
       stub_delete("/user/watched/sferik/rails_admin").
         to_return(:status => 204)
-      expect(@client.unwatch("sferik/rails_admin")).to be_true
+      expect(@client.unwatch("sferik/rails_admin")).to eq(true)
     end
 
   end
@@ -146,7 +157,7 @@ describe Octokit::Client::Repositories do
       stub_delete("/repos/sferik/rails_admin").
         to_return(:status => 204, :body => "")
       result = @client.delete_repository("sferik/rails_admin")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -205,7 +216,7 @@ describe Octokit::Client::Repositories do
       stub_delete("/repos/sferik/rails_admin/keys/#{103205}").
         to_return(:status => 204)
       result = @client.remove_deploy_key("sferik/rails_admin", 103205)
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -227,7 +238,7 @@ describe Octokit::Client::Repositories do
       stub_put("/repos/sferik/rails_admin/collaborators/sferik").
         to_return(:status => 204)
       result = @client.add_collaborator("sferik/rails_admin", "sferik")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -238,7 +249,7 @@ describe Octokit::Client::Repositories do
       stub_delete("/repos/sferik/rails_admin/collaborators/sferik").
         to_return(:status => 204)
       result = @client.remove_collaborator("sferik/rails_admin", "sferik")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
   end
@@ -409,7 +420,7 @@ describe Octokit::Client::Repositories do
     it "removes a hook" do
       stub_delete("/repos/railsbp/railsbp.com/hooks/154284").
         to_return(:status => 204)
-      expect(@client.remove_hook("railsbp/railsbp.com", 154284)).to be_true
+      expect(@client.remove_hook("railsbp/railsbp.com", 154284)).to eq(true)
     end
 
   end
@@ -417,9 +428,9 @@ describe Octokit::Client::Repositories do
   describe ".test_hook" do
 
     it "tests a hook" do
-      stub_post("/repos/railsbp/railsbp.com/hooks/154284/test").
+      stub_post("/repos/railsbp/railsbp.com/hooks/154284/tests").
         to_return(:status => 204)
-      expect(@client.test_hook("railsbp/railsbp.com", 154284)).to be_true
+      expect(@client.test_hook("railsbp/railsbp.com", 154284)).to eq(true)
     end
 
   end
@@ -465,7 +476,7 @@ describe Octokit::Client::Repositories do
       stub_get("/repos/pengwynn/octokit/subscription").
         to_return(json_response("subscription.json"))
       subscription = @client.subscription("pengwynn/octokit")
-      expect(subscription.subscribed).to be_true
+      expect(subscription.subscribed).to eq(true)
     end
 
   end
@@ -487,12 +498,12 @@ describe Octokit::Client::Repositories do
       stub_delete("/repos/pengwynn/octokit/subscription").
         to_return(:status => 204)
       result = @client.delete_subscription("pengwynn/octokit")
-      expect(result).to be_true
+      expect(result).to eq(true)
     end
 
     it "returns false when delete repo subscription fails" do
       stub_delete("/repos/pengwynn/octokit/subscription").
-        to_return(:status => 500)
+        to_return(:status => 404)
       result = @client.delete_subscription("pengwynn/octokit")
       expect(result).to be_false
     end