octokit 1.17.1 → 1.18.0

data/lib/octokit/connection.rb

@@ -13,11 +13,12 @@ module Octokit
       end
 
       options = {
-        :proxy => proxy,
         :ssl => { :verify => false },
         :url => url,
       }
 
+      options[:proxy] = proxy unless proxy.nil?
+
       options.merge!(:params => {:access_token => oauth_token}) if oauthed? && !authenticated?
       options.merge!(:params => unauthed_rate_limit_params) if !oauthed? && !authenticated? && unauthed_rate_limited?
 

data/lib/octokit/version.rb

@@ -1,3 +1,3 @@
 module Octokit
-  VERSION = "1.17.1" unless defined?(Octokit::VERSION)
+  VERSION = "1.18.0" unless defined?(Octokit::VERSION)
 end

data/spec/fixtures/v3/gist_comment.json

@@ -0,0 +1,19 @@
+{
+  "updated_at": "2012-08-30T13:53:41Z",
+  "body": "That was easy..\r\n![Not Bad](http://i.imgur.com/4evZN.jpg)",
+  "user": {
+    "_links": {
+      "self": {
+        "href": "https://api.github.com/users/12k"
+      }
+    },
+    "gravatar_id": "483dbc17be3a07e7e0136bef0e341707",
+    "login": "12k",
+    "url": "https://api.github.com/users/12k",
+    "avatar_url": "https://secure.gravatar.com/avatar/483dbc17be3a07e7e0136bef0e341707?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png",
+    "id": 1312973
+  },
+  "created_at": "2012-08-30T13:53:41Z",
+  "url": "https://api.github.com/gists/comments/451398",
+  "id": 451398
+}

data/spec/fixtures/v3/gist_comment_create.json

@@ -0,0 +1,19 @@
+{
+  "updated_at": "2012-10-13T23:03:57Z",
+  "body": "This is very helpful.",
+  "user": {
+    "gravatar_id": "18c2c44835cc7c5ada7c027f12674714",
+    "login": "joeyw",
+    "_links": {
+      "self": {
+        "href": "https://api.github.com/users/joeyw"
+      }
+    },
+    "url": "https://api.github.com/users/joeyw",
+    "avatar_url": "https://secure.gravatar.com/avatar/18c2c44835cc7c5ada7c027f12674714?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png",
+    "id": 478247
+  },
+  "created_at": "2012-10-13T23:03:57Z",
+  "url": "https://api.github.com/gists/comments/586399",
+  "id": 586399
+}

data/spec/fixtures/v3/gist_comment_update.json

@@ -0,0 +1,19 @@
+{
+  "updated_at": "2012-10-13T23:25:50Z",
+  "body": ":heart:",
+  "user": {
+    "avatar_url": "https://secure.gravatar.com/avatar/18c2c44835cc7c5ada7c027f12674714?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png",
+    "gravatar_id": "18c2c44835cc7c5ada7c027f12674714",
+    "login": "joeyw",
+    "_links": {
+      "self": {
+        "href": "https://api.github.com/users/joeyw"
+      }
+    },
+    "url": "https://api.github.com/users/joeyw",
+    "id": 478247
+  },
+  "created_at": "2012-10-13T23:03:57Z",
+  "url": "https://api.github.com/gists/comments/586399",
+  "id": 586399
+}

data/spec/fixtures/v3/gist_comments.json

@@ -0,0 +1,40 @@
+[
+  {
+    "updated_at": "2012-08-30T13:53:41Z",
+    "body": "That was easy..\r\n![Not Bad](http://i.imgur.com/4evZN.jpg)",
+    "user": {
+      "_links": {
+        "self": {
+          "href": "https://api.github.com/users/12k"
+        }
+      },
+      "gravatar_id": "483dbc17be3a07e7e0136bef0e341707",
+      "login": "12k",
+      "url": "https://api.github.com/users/12k",
+      "avatar_url": "https://secure.gravatar.com/avatar/483dbc17be3a07e7e0136bef0e341707?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png",
+      "id": 1312973
+    },
+    "created_at": "2012-08-30T13:53:41Z",
+    "url": "https://api.github.com/gists/comments/451398",
+    "id": 451398
+  },
+  {
+    "updated_at": "2012-08-30T18:52:56Z",
+    "body": ":sparkles:",
+    "user": {
+      "_links": {
+        "self": {
+          "href": "https://api.github.com/users/eriwen"
+        }
+      },
+      "gravatar_id": "bca89ff7612c074bbe1a77d2cf0a4fb0",
+      "login": "eriwen",
+      "url": "https://api.github.com/users/eriwen",
+      "avatar_url": "https://secure.gravatar.com/avatar/bca89ff7612c074bbe1a77d2cf0a4fb0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png",
+      "id": 51534
+    },
+    "created_at": "2012-08-30T18:52:56Z",
+    "url": "https://api.github.com/gists/comments/458664",
+    "id": 458664
+  }
+]

data/spec/fixtures/v3/pull_update.json

@@ -0,0 +1,138 @@
+{
+    "_links": {
+        "comments": {
+            "href": "https://api.github.com/repos/ctshryock/octokit/issues/15/comments"
+        }, 
+        "html": {
+            "href": "https://github.com/ctshryock/octokit/pull/15"
+        }, 
+        "review_comments": {
+            "href": "https://api.github.com/repos/ctshryock/octokit/pulls/15/comments"
+        }, 
+        "self": {
+            "href": "https://api.github.com/repos/ctshryock/octokit/pulls/15"
+        }
+    }, 
+    "additions": 5015, 
+    "base": {
+        "label": "ctshryock:master", 
+        "ref": "master", 
+        "repo": {
+            "clone_url": "https://github.com/ctshryock/octokit.git", 
+            "created_at": "2011-04-29T18:43:10Z", 
+            "description": "Simple Ruby wrapper for the GitHub v2 API and feeds", 
+            "fork": true, 
+            "forks": 0, 
+            "git_url": "git://github.com/ctshryock/octokit.git", 
+            "has_downloads": true, 
+            "has_issues": true, 
+            "has_wiki": true, 
+            "homepage": "", 
+            "html_url": "https://github.com/ctshryock/octokit", 
+            "id": 1682040, 
+            "language": "Ruby", 
+            "master_branch": null, 
+            "mirror_url": null, 
+            "name": "octokit", 
+            "open_issues": 1, 
+            "owner": {
+                "avatar_url": "https://secure.gravatar.com/avatar/dfb3948650131e4f0385c3328187cfca?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png", 
+                "gravatar_id": "dfb3948650131e4f0385c3328187cfca", 
+                "id": 61721, 
+                "login": "ctshryock", 
+                "url": "https://api.github.com/users/ctshryock"
+            }, 
+            "private": false, 
+            "pushed_at": "2012-02-11T16:06:32Z", 
+            "size": 140, 
+            "ssh_url": "git@github.com:ctshryock/octokit.git", 
+            "svn_url": "https://github.com/ctshryock/octokit", 
+            "updated_at": "2012-02-11T16:06:34Z", 
+            "url": "https://api.github.com/repos/ctshryock/octokit", 
+            "watchers": 1
+        }, 
+        "sha": "89e255143524b71bd91f51d2ca31b7e8c90f398c", 
+        "user": {
+            "avatar_url": "https://secure.gravatar.com/avatar/dfb3948650131e4f0385c3328187cfca?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png", 
+            "gravatar_id": "dfb3948650131e4f0385c3328187cfca", 
+            "id": 61721, 
+            "login": "ctshryock", 
+            "url": "https://api.github.com/users/ctshryock"
+        }
+    }, 
+    "body": "Updated body", 
+    "changed_files": 15, 
+    "closed_at": null, 
+    "comments": 0, 
+    "commits": 19, 
+    "created_at": "2012-02-11T16:12:31Z", 
+    "deletions": 112, 
+    "diff_url": "https://github.com/ctshryock/octokit/pull/15.diff", 
+    "head": {
+        "label": "ctshryock:api-version-3", 
+        "ref": "api-version-3", 
+        "repo": {
+            "clone_url": "https://github.com/ctshryock/octokit.git", 
+            "created_at": "2011-04-29T18:43:10Z", 
+            "description": "Simple Ruby wrapper for the GitHub v2 API and feeds", 
+            "fork": true, 
+            "forks": 0, 
+            "git_url": "git://github.com/ctshryock/octokit.git", 
+            "has_downloads": true, 
+            "has_issues": true, 
+            "has_wiki": true, 
+            "homepage": "", 
+            "html_url": "https://github.com/ctshryock/octokit", 
+            "id": 1682040, 
+            "language": "Ruby", 
+            "master_branch": null, 
+            "mirror_url": null, 
+            "name": "octokit", 
+            "open_issues": 1, 
+            "owner": {
+                "avatar_url": "https://secure.gravatar.com/avatar/dfb3948650131e4f0385c3328187cfca?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png", 
+                "gravatar_id": "dfb3948650131e4f0385c3328187cfca", 
+                "id": 61721, 
+                "login": "ctshryock", 
+                "url": "https://api.github.com/users/ctshryock"
+            }, 
+            "private": false, 
+            "pushed_at": "2012-02-11T16:06:32Z", 
+            "size": 140, 
+            "ssh_url": "git@github.com:ctshryock/octokit.git", 
+            "svn_url": "https://github.com/ctshryock/octokit", 
+            "updated_at": "2012-02-11T16:06:34Z", 
+            "url": "https://api.github.com/repos/ctshryock/octokit", 
+            "watchers": 1
+        }, 
+        "sha": "3a3a3ca7ca0ca0026fca1bccfb090b4113a7e754", 
+        "user": {
+            "avatar_url": "https://secure.gravatar.com/avatar/dfb3948650131e4f0385c3328187cfca?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png", 
+            "gravatar_id": "dfb3948650131e4f0385c3328187cfca", 
+            "id": 61721, 
+            "login": "ctshryock", 
+            "url": "https://api.github.com/users/ctshryock"
+        }
+    }, 
+    "html_url": "https://github.com/ctshryock/octokit/pull/15", 
+    "id": 815669, 
+    "issue_url": "https://github.com/ctshryock/octokit/issues/15", 
+    "mergeable": null, 
+    "merged": false, 
+    "merged_at": null, 
+    "merged_by": null, 
+    "number": 15, 
+    "patch_url": "https://github.com/ctshryock/octokit/pull/15.patch", 
+    "review_comments": 0, 
+    "state": "closed", 
+    "title": "New title", 
+    "updated_at": "2012-02-11T16:12:31Z", 
+    "url": "https://api.github.com/repos/ctshryock/octokit/pulls/15", 
+    "user": {
+        "avatar_url": "https://secure.gravatar.com/avatar/dfb3948650131e4f0385c3328187cfca?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png", 
+        "gravatar_id": "dfb3948650131e4f0385c3328187cfca", 
+        "id": 61721, 
+        "login": "ctshryock", 
+        "url": "https://api.github.com/users/ctshryock"
+    }
+}

data/spec/fixtures/v3/tag.json

@@ -0,0 +1,16 @@
+{
+  "tagger": {
+    "date": "2012-06-03T17:03:11-07:00",
+    "name": "Wynn Netherland",
+    "email": "wynn.netherland@gmail.com"
+  },
+  "message": "Version 1.4.0\n",
+  "object": {
+    "type": "commit",
+    "url": "https://api.github.com/repos/pengwynn/octokit/git/commits/f4cdf6eb734f32343ce3f27670c17b35f54fd82e",
+    "sha": "f4cdf6eb734f32343ce3f27670c17b35f54fd82e"
+  },
+  "url": "https://api.github.com/repos/pengwynn/octokit/git/tags/23aad20633f4d2981b1c7209a800db3014774e96",
+  "sha": "23aad20633f4d2981b1c7209a800db3014774e96",
+  "tag": "v1.4.0"
+}

data/spec/fixtures/v3/tag_create.json

@@ -0,0 +1,16 @@
+{
+  "tagger": {
+    "date": "2012-06-03T17:03:11-07:00",
+    "name": "Wynn Netherland",
+    "email": "wynn.netherland@gmail.com"
+  },
+  "message": "Version 9000\n",
+  "object": {
+    "type": "commit",
+    "url": "https://api.github.com/repos/pengwynn/octokit/git/commits/f4cdf6eb734f32343ce3f27670c17b35f54fd82e",
+    "sha": "f4cdf6eb734f32343ce3f27670c17b35f54fd82e"
+  },
+  "url": "https://api.github.com/repos/pengwynn/octokit/git/tags/23aad20633f4d2981b1c7209a800db3014774e96",
+  "sha": "23aad20633f4d2981b1c7209a800db3014774e96",
+  "tag": "v9000.0.0"
+}

data/spec/octokit/client/gists_spec.rb

@@ -130,4 +130,49 @@ describe Octokit::Client::Gists do
     end
   end
 
+  describe ".gist_comments" do
+    it "returns the list of gist comments" do
+      stub_get("/gists/12345/comments").
+        to_return(:body => fixture("v3/gist_comments.json"))
+      comments = @client.gist_comments(12345)
+      expect(comments.first.id).to eq(451398)
+    end
+  end
+
+  describe ".gist_comment" do
+    it "returns a gist comment" do
+      stub_get("/gists/comments/12345").
+        to_return(:body => fixture("v3/gist_comment.json"))
+      comment = @client.gist_comment(12345)
+      expect(comment.id).to eq(451398)
+    end
+  end
+
+  describe ".create_gist_comment" do
+    it "creates a gist comment" do
+      stub_post("/gists/12345/comments").
+        to_return(:body => fixture("v3/gist_comment_create.json"))
+      comment = @client.create_gist_comment(12345, "This is very helpful.")
+      expect(comment.id).to eq(586399)
+      expect(comment.body).to eq("This is very helpful.")
+    end
+  end
+
+  describe ".update_gist_comment" do
+    it "updates a gist comment" do
+      stub_patch("/gists/comments/12345").
+        to_return(:body => fixture("v3/gist_comment_update.json"))
+      comment = @client.update_gist_comment(12345, ":heart:")
+      expect(comment.body).to eq(":heart:")
+    end
+  end
+
+  describe ".delete_gist_comment" do
+    it "deletes a gist comment" do
+      stub_delete("/gists/comments/12345").to_return(:status => 204)
+      result = @client.delete_gist_comment(12345)
+      expect(result).to be_true
+    end
+  end
+
 end

data/spec/octokit/client/objects_spec.rb

@@ -58,4 +58,52 @@ describe Octokit::Client::Objects do
 
   end
 
+  describe ".tag" do
+
+    it "returns a tag" do
+      stub_get("/repos/pengwynn/octokit/git/tags/23aad20633f4d2981b1c7209a800db3014774e96").
+        to_return(:body => fixture("v3/tag.json"))
+      tag = @client.tag("pengwynn/octokit", "23aad20633f4d2981b1c7209a800db3014774e96")
+      expect(tag.sha).to eq("23aad20633f4d2981b1c7209a800db3014774e96")
+      expect(tag.message).to eq("Version 1.4.0\n")
+      expect(tag.tag).to eq("v1.4.0")
+    end
+
+  end
+
+  describe ".create_tag" do
+
+    it "creates a tag" do
+      stub_post("/repos/pengwynn/octokit/git/tags").
+        with(:body => {
+                :tag => "v9000.0.0",
+                :message => "Version 9000\n",
+                :object => "f4cdf6eb734f32343ce3f27670c17b35f54fd82e",
+                :type => "commit",
+                :tagger => {
+                  :name => "Wynn Netherland",
+                  :email => "wynn.netherland@gmail.com",
+                  :date => "2012-06-03T17:03:11-07:00"
+                }
+              },
+            :headers => { "Content-Type" => "application/json" }).
+              to_return(:body => fixture("v3/tag_create.json"))
+      tag = @client.create_tag(
+        "pengwynn/octokit",
+        "v9000.0.0",
+        "Version 9000\n",
+        "f4cdf6eb734f32343ce3f27670c17b35f54fd82e",
+        "commit",
+        "Wynn Netherland",
+        "wynn.netherland@gmail.com",
+        "2012-06-03T17:03:11-07:00"
+      )
+      expect(tag.tag).to eq("v9000.0.0")
+      expect(tag.message).to eq("Version 9000\n")
+      expect(tag.sha).to eq("23aad20633f4d2981b1c7209a800db3014774e96")
+    end
+
+  end
+
+
 end

data/spec/octokit/client/pulls_spec.rb

@@ -20,6 +20,20 @@ describe Octokit::Client::Pulls do
 
   end
 
+  describe ".update_pull_request" do
+
+    it "updates a pull request" do
+      stub_post("https://api.github.com/repos/pengwynn/octokit/pulls/67").
+        with(:pull => { :title => "New title", :body => "Updated body", :state => "closed"}).
+          to_return(:body => fixture('v3/pull_update.json'))
+      pull = @client.update_pull_request('pengwynn/octokit', 67, 'New title', 'Updated body', 'closed')
+      expect(pull.title).to eq('New title')
+      expect(pull.body).to eq('Updated body')
+      expect(pull.state).to eq('closed')
+    end
+
+  end
+
   describe ".create_pull_request_for_issue" do
 
     it "creates a pull request and attach it to an existing issue" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: octokit
 version: !ruby/object:Gem::Version
-  version: 1.17.1
+  version: 1.18.0
   prerelease: 
 platform: ruby
 authors:
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-11 00:00:00.000000000 Z
+date: 2012-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -287,6 +287,10 @@ files:
 - spec/fixtures/v3/following.json
 - spec/fixtures/v3/forks.json
 - spec/fixtures/v3/gist.json
+- spec/fixtures/v3/gist_comment.json
+- spec/fixtures/v3/gist_comment_create.json
+- spec/fixtures/v3/gist_comment_update.json
+- spec/fixtures/v3/gist_comments.json
 - spec/fixtures/v3/gists.json
 - spec/fixtures/v3/hook.json
 - spec/fixtures/v3/hooks.json
@@ -322,6 +326,7 @@ files:
 - spec/fixtures/v3/pull_request_files.json
 - spec/fixtures/v3/pull_request_merged.json
 - spec/fixtures/v3/pull_requests.json
+- spec/fixtures/v3/pull_update.json
 - spec/fixtures/v3/readme.json
 - spec/fixtures/v3/ref.json
 - spec/fixtures/v3/ref_create.json
@@ -338,6 +343,8 @@ files:
 - spec/fixtures/v3/starred_gists.json
 - spec/fixtures/v3/status.json
 - spec/fixtures/v3/statuses.json
+- spec/fixtures/v3/tag.json
+- spec/fixtures/v3/tag_create.json
 - spec/fixtures/v3/tags.json
 - spec/fixtures/v3/team.json
 - spec/fixtures/v3/teams.json
@@ -429,6 +436,10 @@ test_files:
 - spec/fixtures/v3/following.json
 - spec/fixtures/v3/forks.json
 - spec/fixtures/v3/gist.json
+- spec/fixtures/v3/gist_comment.json
+- spec/fixtures/v3/gist_comment_create.json
+- spec/fixtures/v3/gist_comment_update.json
+- spec/fixtures/v3/gist_comments.json
 - spec/fixtures/v3/gists.json
 - spec/fixtures/v3/hook.json
 - spec/fixtures/v3/hooks.json
@@ -464,6 +475,7 @@ test_files:
 - spec/fixtures/v3/pull_request_files.json
 - spec/fixtures/v3/pull_request_merged.json
 - spec/fixtures/v3/pull_requests.json
+- spec/fixtures/v3/pull_update.json
 - spec/fixtures/v3/readme.json
 - spec/fixtures/v3/ref.json
 - spec/fixtures/v3/ref_create.json
@@ -480,6 +492,8 @@ test_files:
 - spec/fixtures/v3/starred_gists.json
 - spec/fixtures/v3/status.json
 - spec/fixtures/v3/statuses.json
+- spec/fixtures/v3/tag.json
+- spec/fixtures/v3/tag_create.json
 - spec/fixtures/v3/tags.json
 - spec/fixtures/v3/team.json
 - spec/fixtures/v3/teams.json