octokit 1.17.0 → 1.17.1

data/spec/octokit/client/events_spec.rb

@@ -7,38 +7,38 @@ describe Octokit::Client::Events do
   end
 
   describe ".public_events" do
-    it "should return all public events" do
+    it "returns all public events" do
       stub_get("/events").
         to_return(:body => fixture("v3/public_events.json"))
       public_events = @client.public_events
-      public_events.first.id.should == '1513284759'
+      expect(public_events.first.id).to eq('1513284759')
     end
   end
 
   describe ".user_events" do
-    it "should return all user events" do
+    it "returns all user events" do
       stub_get("/users/sferik/events").
         to_return(:body => fixture("v3/user_events.json"))
       user_events = @client.user_events('sferik')
-      user_events.first.id.should == '1525888969'
+      expect(user_events.first.id).to eq('1525888969')
     end
   end
 
   describe ".received_events" do
-    it "should return all user received events" do
+    it "returns all user received events" do
       stub_get("/users/sferik/received_events").
         to_return(:body => fixture("v3/user_events.json"))
       received_events = @client.received_events('sferik')
-      received_events.first.type.should == 'PushEvent'
+      expect(received_events.first.type).to eq('PushEvent')
     end
   end
 
   describe ".repository_events" do
-    it "should return events for a repository" do
+    it "returns events for a repository" do
       stub_get("/repos/sferik/rails_admin/events").
         to_return(:body => fixture("v3/repo_events.json"))
       repo_events = @client.repository_events("sferik/rails_admin")
-      repo_events.first.type.should == "IssuesEvent"
+      expect(repo_events.first.type).to eq("IssuesEvent")
     end
     
   end

data/spec/octokit/client/gists_spec.rb

@@ -9,50 +9,50 @@ describe Octokit::Client::Gists do
   end
 
   describe ".public_gists" do
-    it "should return public gists" do
+    it "returns public gists" do
       stub_get("/gists/public").to_return(:body => fixture("v3/public_gists.json"))
       gists = @client.public_gists
-      gists.should_not be_empty
+      expect(gists).not_to be_empty
     end
   end # .public_gists
 
   describe ".gists" do
     context "with username passed" do
-      it "should return a list of gists" do
+      it "returns a list of gists" do
         stub_get("/users/#{@username}/gists").
           to_return(:body => fixture("v3/gists.json"))
         gists = @client.gists(@username)
-        gists.first.user.login.should == @username
+        expect(gists.first.user.login).to eq(@username)
       end
     end
 
     context "without a username passed" do
-      it "should return a list of gists" do
+      it "returns a list of gists" do
         stub_get("/gists").to_return(:body => fixture("v3/gists.json"))
         gists = @client.gists
-        gists.first.user.login.should == @username
+        expect(gists.first.user.login).to eq(@username)
       end
     end
   end # .gists
 
   describe ".starred_gists" do
-    it "should return the user's starred gists" do
+    it "returns the user's starred gists" do
       stub_get("/gists/starred").to_return(:body => fixture("v3/starred_gists.json"))
       gists = @client.starred_gists
-      gists.should_not be_empty
+      expect(gists).not_to be_empty
     end
   end
 
   describe ".gist" do
-    it "should return the gist by ID" do
+    it "returns the gist by ID" do
       stub_get("/gists/1").to_return(:body => fixture("v3/gist.json"))
       gist = @client.gist(1)
-      gist.user.login.should == @username
+      expect(gist.user.login).to eq(@username)
     end
   end
 
   describe ".create_gist" do
-    it "should create a new gist" do
+    it "creates a new gist" do
       gist_content = JSON.parse(fixture("v3/gist.json").read)
       new_gist = {
         :description => gist_content['description'],
@@ -64,12 +64,12 @@ describe Octokit::Client::Gists do
         to_return(:body => fixture("v3/gist.json"))
 
       gist = @client.create_gist(new_gist)
-      gist.should == gist_content
+      expect(gist).to eq(gist_content)
     end
   end
 
   describe ".edit_gist" do
-    it "should edit an existing gist" do
+    it "edit an existing gist" do
       gist_content = JSON.parse(fixture("v3/gist.json").read)
       gist_id = gist_content['id']
       updated_gist = gist_content.merge('description' => 'updated')
@@ -78,55 +78,55 @@ describe Octokit::Client::Gists do
         to_return(:body => updated_gist)
 
       gist = @client.edit_gist(gist_id, :description => 'updated')
-      gist['description'].should == 'updated'
+      expect(gist['description']).to eq('updated')
     end
   end
 
   describe ".star_gist" do
-    it "should star an existing gist" do
+    it "stars an existing gist" do
       stub_put("/gists/12345/star").to_return(:status => 204)
       success = @client.star_gist(12345)
-      success.should be_true
+      expect(success).to be_true
     end
   end
 
   describe ".unstar_gist" do
-    it "should unstar an existing gist" do
+    it "unstars an existing gist" do
       stub_delete("/gists/12345/star").to_return(:status => 204)
       success = @client.unstar_gist(12345)
-      success.should be_true
+      expect(success).to be_true
     end
   end
 
   describe ".gist_starred?" do
-    it "should be starred" do
+    it "is starred" do
       stub_get("/gists/12345/star").to_return(:status => 204)
       starred = @client.gist_starred?(12345)
-      starred.should be_true
+      expect(starred).to be_true
     end
 
-    it "should not be starred" do
+    it "is not starred" do
       stub_get("/gists/12345/star").to_return(:status => 404)
       starred = @client.gist_starred?(12345)
-      starred.should be_false
+      expect(starred).to be_false
     end
   end
 
   describe ".fork_gist" do
-    it "should fork an existing gist" do
+    it "forks an existing gist" do
       stub_post("/gists/12345/fork").
         to_return(:body => fixture("v3/gist.json"))
 
       gist = @client.fork_gist(12345)
-      gist.user.login.should == @username
+      expect(gist.user.login).to eq(@username)
     end
   end
 
   describe ".delete_gist" do
-    it "should delete an existing gist" do
+    it "deletes an existing gist" do
       stub_delete("/gists/12345").to_return(:status => 204)
       deleted = @client.delete_gist(12345)
-      deleted.should be_true
+      expect(deleted).to be_true
     end
   end
 

data/spec/octokit/client/issue_events_spec.rb

@@ -9,20 +9,20 @@ describe Octokit::Client::Issues do
 
   describe ".issue_events" do
 
-    it "should list events for an issue" do
+    it "lists events for an issue" do
       stub_get("/repos/pengwynn/octokit/issues/38/events").
       to_return(:body => fixture("v3/issue_events.json"))
       events = @client.issue_events("pengwynn/octokit", 38)
-      events.first.event.should == "mentioned"
-      events.last.actor.login.should == "ctshryock"
+      expect(events.first.event).to eq("mentioned")
+      expect(events.last.actor.login).to eq("ctshryock")
     end
 
-    it "should get a single event" do
+    it "gets a single event" do
       stub_get("/repos/pengwynn/octokit/issues/events/3094334").
       to_return(:body => fixture("v3/issue_event.json"))
       events = @client.issue_event("pengwynn/octokit", 3094334)
-      events.actor.login.should == "sferik"
-      events.event.should == "closed"
+      expect(events.actor.login).to eq("sferik")
+      expect(events.event).to eq("closed")
     end
 
   end

data/spec/octokit/client/issues_spec.rb

@@ -9,153 +9,153 @@ describe Octokit::Client::Issues do
 
   describe ".search_issues" do
 
-    it "should return matching issues" do
+    it "returns matching issues" do
       stub_get("https://api.github.com/legacy/issues/search/sferik/rails_admin/open/activerecord").
       to_return(:body => fixture("legacy/issues.json"))
       issues = @client.search_issues("sferik/rails_admin", "activerecord")
-      issues.first.number.should == 105
+      expect(issues.first.number).to eq(105)
     end
 
   end
 
   describe ".list_issues" do
 
-    it "should return issues for a repository" do
+    it "returns issues for a repository" do
       stub_get("/repos/sferik/rails_admin/issues").
         to_return(:body => fixture("v3/issues.json"))
       issues = @client.issues("sferik/rails_admin")
-      issues.first.number.should == 388
+      expect(issues.first.number).to eq(388)
     end
 
-    it "should return issues for the authenticated user" do
+    it "returns issues for the authenticated user" do
       stub_get("/issues").
         to_return(:body => fixture("v3/issues.json"))
       issues = @client.issues
-      issues.first.number.should == 388
+      expect(issues.first.number).to eq(388)
     end
 
   end
 
   describe ".create_issue" do
 
-    it "should create an issue" do
+    it "creates an issue" do
       stub_post("/repos/ctshryock/octokit/issues").
         with(:body => {"title" => "Migrate issues to v3", "body" => "Move all Issues calls to v3 of the API"},
              :headers => {'Content-Type'=>'application/json'}).
         to_return(:body => fixture("v3/issue.json"))
       issue = @client.create_issue("ctshryock/octokit", "Migrate issues to v3", "Move all Issues calls to v3 of the API")
-      issue.number.should == 12
+      expect(issue.number).to eq(12)
     end
 
   end
 
   describe ".issue" do
 
-    it "should return an issue" do
+    it "returns an issue" do
       stub_get("/repos/ctshryock/octokit/issues/12").
         to_return(:body => fixture("v3/issue.json"))
       issue = @client.issue("ctshryock/octokit", 12)
-      issue.number.should == 12
+      expect(issue.number).to eq(12)
     end
 
   end
 
   describe ".close_issue" do
 
-    it "should close an issue" do
+    it "closes an issue" do
       stub_post("/repos/ctshryock/octokit/issues/12").
         with(:body => {"state" => "closed"},
              :headers => {'Content-Type'=>'application/json'}).
         to_return(:body => fixture("v3/issue_closed.json"))
       issue = @client.close_issue("ctshryock/octokit", 12)
-      issue.number.should == 12
-      issue.should include :closed_at
-      issue.state.should == "closed"
+      expect(issue.number).to eq(12)
+      expect(issue).to include :closed_at
+      expect(issue.state).to eq("closed")
     end
 
   end
 
   describe ".reopen_issue" do
 
-    it "should reopen an issue" do
+    it "reopens an issue" do
       stub_post("/repos/ctshryock/octokit/issues/12").
         with(:body => {"state" => "open"},
              :headers => {'Content-Type'=>'application/json'}).
         to_return(:body => fixture("v3/issue.json"))
       issue = @client.reopen_issue("ctshryock/octokit", 12)
-      issue.number.should == 12
-      issue.state.should == "open"
+      expect(issue.number).to eq(12)
+      expect(issue.state).to eq("open")
     end
 
   end
 
   describe ".update_issue" do
 
-    it "should update an issue" do
+    it "updates an issue" do
       stub_post("/repos/ctshryock/octokit/issues/12").
         with(:body => {"title" => "Use all the v3 api!", "body" => ""},
              :headers => {'Content-Type'=>'application/json'}).
         to_return(:body => fixture("v3/issue.json"))
       issue = @client.update_issue("ctshryock/octokit", 12, "Use all the v3 api!", "")
-      issue.number.should == 12
+      expect(issue.number).to eq(12)
     end
 
   end
 
   describe ".issue_comments" do
 
-    it "should return comments for an issue" do
+    it "returns comments for an issue" do
       stub_get("/repos/pengwynn/octokit/issues/25/comments").
         to_return(:status => 200, :body => fixture('v3/comments.json'))
       comments = @client.issue_comments("pengwynn/octokit", 25)
-      comments.first.user.login.should == "ctshryock"
+      expect(comments.first.user.login).to eq("ctshryock")
     end
 
   end
 
   describe ".issue_comment" do
 
-    it "should return a single comment for an issue" do
+    it "returns a single comment for an issue" do
       stub_get("/repos/pengwynn/octokit/issues/comments/25").
         to_return(:status => 200, :body => fixture('v3/comment.json'))
       comments = @client.issue_comment("pengwynn/octokit", 25)
-      comments.user.login.should == "ctshryock"
-      comments.url.should == "https://api.github.com/repos/pengwynn/octokit/issues/comments/1194690"
+      expect(comments.user.login).to eq("ctshryock")
+      expect(comments.url).to eq("https://api.github.com/repos/pengwynn/octokit/issues/comments/1194690")
     end
 
   end
 
   describe ".add_comment" do
 
-    it "should add a comment" do
+    it "adds a comment" do
       stub_post("/repos/pengwynn/octokit/issues/25/comments").
         with(:body => {"body" => "A test comment"}).
         to_return(:status => 201, :body => fixture('v3/comment.json'))
       comment = @client.add_comment("pengwynn/octokit", 25, "A test comment")
-      comment.user.login.should == "ctshryock"
+      expect(comment.user.login).to eq("ctshryock")
     end
 
   end
 
   describe ".update_comment" do
 
-    it "should update an existing comment" do
+    it "updates an existing comment" do
       stub_post("/repos/pengwynn/octokit/issues/comments/1194549").
         with(:body => {"body" => "A test comment update"}).
         to_return(:status => 200, :body => fixture('v3/comment.json'))
       comment = @client.update_comment("pengwynn/octokit", 1194549, "A test comment update")
-      comment.user.login.should == "ctshryock"
+      expect(comment.user.login).to eq("ctshryock")
     end
 
   end
 
   describe ".delete_comment" do
 
-    it "should delete an existing comment" do
+    it "deletes an existing comment" do
       stub_delete("/repos/pengwynn/octokit/issues/comments/1194549").
         to_return(:status => 204)
       comment = @client.delete_comment("pengwynn/octokit", 1194549)
-      comment.status.should == 204
+      expect(comment.status).to eq(204)
     end
 
   end

data/spec/octokit/client/labels_spec.rb

@@ -9,143 +9,143 @@ describe Octokit::Client::Labels do
 
   describe ".labels" do
 
-    it "should return labels" do
+    it "returns labels" do
       stub_get("/repos/pengwynn/octokit/labels").
         to_return(:body => fixture("v3/labels.json"))
       labels = @client.labels("pengwynn/octokit")
-      labels.first.name.should == "V3 Transition"
+      expect(labels.first.name).to eq("V3 Transition")
     end
 
   end
 
   describe ".label" do
 
-    it "should return a single labels" do
+    it "returns a single labels" do
       stub_get("/repos/pengwynn/octokit/labels/V3+Addition").
         to_return(:status => 200, :body => fixture('v3/label.json'))
       label = @client.label("pengwynn/octokit", "V3 Addition")
-      label.name.should == "V3 Addition"
+      expect(label.name).to eq("V3 Addition")
     end
 
   end
 
   describe ".add_label" do
 
-    it "should add a label with a color" do
+    it "adds a label with a color" do
       stub_post("/repos/pengwynn/octokit/labels").
         with(:body => {"name" => "a significant bug", "color" => "ededed"},
              :headers => {'Content-Type'=>'application/json'}).
         to_return(:status => 201, :body => fixture('v3/label.json'))
       labels = @client.add_label("pengwynn/octokit", "a significant bug", 'ededed')
-      labels.color.should == "ededed"
-      labels.name.should  == "V3 Addition"
+      expect(labels.color).to eq("ededed")
+      expect(labels.name).to  eq("V3 Addition")
     end
 
-    it "should add a label with default color" do
+    it "adds a label with default color" do
       stub_post("/repos/pengwynn/octokit/labels").
         with(:body => {"name" => "another significant bug", "color" => "ffffff"},
              :headers => {'Content-Type'=>'application/json'}).
         to_return(:status => 201, :body => fixture('v3/label.json'))
       labels = @client.add_label("pengwynn/octokit", "another significant bug")
-      labels.color.should == "ededed"
-      labels.name.should  == "V3 Addition"
+      expect(labels.color).to eq("ededed")
+      expect(labels.name).to  eq("V3 Addition")
     end
 
   end
 
   describe ".update_label" do
 
-    it "should update a label with a new color" do
+    it "updates a label with a new color" do
       stub_post("/repos/pengwynn/octokit/labels/V3+Addition").
         with(:body => {"color" => "ededed"},
             :headers => {'Content-Type'=>'application/json'}).
         to_return(:status => 200, :body => fixture('v3/label.json'))
 
       label = @client.update_label("pengwynn/octokit", "V3 Addition", {:color => 'ededed'})
-      label.color.should == 'ededed'
+      expect(label.color).to eq('ededed')
     end
 
   end
 
   describe ".delete_label!" do
 
-    it "should delete a label from the repository" do
+    it "deletes a label from the repository" do
       stub_delete("/repos/pengwynn/octokit/labels/V3+Transition").
        to_return(:status => 204)
 
       response = @client.delete_label!("pengwynn/octokit", "V3 Transition")
-      response.status.should == 204
+      expect(response.status).to eq(204)
     end
 
   end
 
   describe ".remove_label" do
 
-    it "should remove a label from the specified issue" do
+    it "removes a label from the specified issue" do
       stub_delete("/repos/pengwynn/octokit/issues/23/labels/V3+Transition").
         to_return(:status => 200, :body => fixture('v3/labels.json'), :headers => {})
 
       response = @client.remove_label("pengwynn/octokit", 23, "V3 Transition")
-      response.last.name.should == 'Bug'
+      expect(response.last.name).to eq('Bug')
     end
 
   end
 
   describe ".remove_all_labels" do
 
-    it "should remove all labels from the specified issue" do
+    it "removes all labels from the specified issue" do
      stub_delete("/repos/pengwynn/octokit/issues/23/labels").
        to_return(:status => 204)
 
      response = @client.remove_all_labels('pengwynn/octokit', 23)
-     response.status.should == 204
+     expect(response.status).to eq(204)
     end
 
   end
 
   describe ".add_labels_to_an_issue" do
-    it "should add labels to a given issue" do
+    it "adds labels to a given issue" do
       stub_post("/repos/pengwynn/octokit/issues/42/labels").
         with(:body => '["V3 Transition","Bug"]',
             :headers => {'Accept'=>'*/*', 'Content-Type'=>'application/json'}).
         to_return(:status => 200, :body => fixture('v3/labels.json'), :headers => {})
 
       labels = @client.add_labels_to_an_issue('pengwynn/octokit', 42, ['V3 Transition', 'Bug'])
-      labels.first.name.should == 'V3 Transition'
-      labels.last.name.should  == 'Bug'
+      expect(labels.first.name).to eq('V3 Transition')
+      expect(labels.last.name).to  eq('Bug')
     end
   end
 
   describe ".replace_all_labels" do
-    it "should replace all labels for an issue" do
+    it "replaces all labels for an issue" do
        stub_put("/repos/pengwynn/octokit/issues/42/labels").
          with(:body => '["V3 Transition","V3 Adding"]',
               :headers => {'Accept'=>'*/*', 'Content-Type'=>'application/json'}).
          to_return(:status => 200, :body => fixture('v3/labels.json'), :headers => {})
 
       labels = @client.replace_all_labels('pengwynn/octokit', 42, ['V3 Transition', 'V3 Adding'])
-      labels.first.name.should == 'V3 Transition'
+      expect(labels.first.name).to eq('V3 Transition')
     end
   end
 
   describe ".lables_for_milestone" do
-    it "should return all labels for a repository" do
+    it "returns all labels for a repository" do
       stub_get('/repos/pengwynn/octokit/milestones/2/labels').
         to_return(:status => 200, :body => fixture('v3/labels.json'), :headers => {})
 
       labels = @client.labels_for_milestone('pengwynn/octokit', 2)
-      labels.size.should == 3
+      expect(labels.size).to eq(3)
     end
   end
 
   describe ".labels_for_issue" do
-    it "should return all labels for a given issue" do
+    it "returns all labels for a given issue" do
       stub_get("/repos/pengwynn/octokit/issues/37/labels").
         to_return(:status => 200, :body => fixture('v3/labels.json'), :headers => {})
 
       labels = @client.labels_for_issue('pengwynn/octokit', 37)
-      labels.first.name.should == 'V3 Transition'
-      labels.last.name.should  == 'Bug'
+      expect(labels.first.name).to eq('V3 Transition')
+      expect(labels.last.name).to  eq('Bug')
     end
   end