octokit 1.0.7 → 1.1.0
Sign up to get free protection for your applications and to get access to all the features.
- data/CHANGELOG.md +1 -0
- data/lib/octokit/client.rb +3 -0
- data/lib/octokit/client/gists.rb +66 -0
- data/lib/octokit/gist.rb +27 -0
- data/lib/octokit/version.rb +1 -1
- data/spec/fixtures/timeline.json +1408 -1237
- data/spec/fixtures/v2/blob_metadata.json +2052 -1
- data/spec/fixtures/v2/blobs.json +260 -1
- data/spec/fixtures/v2/issues.json +49 -1
- data/spec/fixtures/v2/network_data.json +3551 -1
- data/spec/fixtures/v2/network_meta.json +2530 -1
- data/spec/fixtures/v2/repositories.json +173 -1
- data/spec/fixtures/v2/tree_metadata.json +2612 -1
- data/spec/fixtures/v2/user.json +19 -1
- data/spec/fixtures/v2/users.json +24 -1
- data/spec/fixtures/v3/blob.json +5 -5
- data/spec/fixtures/v3/branches.json +14 -14
- data/spec/fixtures/v3/collaborators.json +60 -60
- data/spec/fixtures/v3/comment.json +12 -12
- data/spec/fixtures/v3/comments.json +41 -41
- data/spec/fixtures/v3/commit.json +50 -1
- data/spec/fixtures/v3/commit_comment.json +17 -17
- data/spec/fixtures/v3/commit_comments.json +76 -76
- data/spec/fixtures/v3/commits.json +1414 -1
- data/spec/fixtures/v3/contributors.json +889 -889
- data/spec/fixtures/v3/download.json +9 -9
- data/spec/fixtures/v3/downloads.json +33 -33
- data/spec/fixtures/v3/emails.json +3 -3
- data/spec/fixtures/v3/followers.json +210 -210
- data/spec/fixtures/v3/following.json +207 -207
- data/spec/fixtures/v3/forks.json +870 -870
- data/spec/fixtures/v3/gist.json +51 -0
- data/spec/fixtures/v3/gists.json +548 -0
- data/spec/fixtures/v3/issue.json +33 -35
- data/spec/fixtures/v3/issue_closed.json +34 -36
- data/spec/fixtures/v3/issue_event.json +40 -42
- data/spec/fixtures/v3/issue_events.json +70 -70
- data/spec/fixtures/v3/issues.json +1559 -1577
- data/spec/fixtures/v3/label.json +3 -3
- data/spec/fixtures/v3/labels.json +15 -15
- data/spec/fixtures/v3/languages.json +3 -3
- data/spec/fixtures/v3/list_commit_comments.json +570 -570
- data/spec/fixtures/v3/milestone.json +9 -10
- data/spec/fixtures/v3/milestones.json +25 -25
- data/spec/fixtures/v3/not_found.json +1 -1
- data/spec/fixtures/v3/organization-repositories.json +4290 -4290
- data/spec/fixtures/v3/organization-repository.json +41 -41
- data/spec/fixtures/v3/organization.json +16 -16
- data/spec/fixtures/v3/organization_members.json +574 -574
- data/spec/fixtures/v3/organization_team_members.json +14 -14
- data/spec/fixtures/v3/organization_team_repos.json +60 -60
- data/spec/fixtures/v3/organizations.json +42 -42
- data/spec/fixtures/v3/public_events.json +1101 -1107
- data/spec/fixtures/v3/public_gists.json +968 -0
- data/spec/fixtures/v3/public_key.json +3 -3
- data/spec/fixtures/v3/public_keys.json +5 -5
- data/spec/fixtures/v3/pull_created.json +134 -134
- data/spec/fixtures/v3/pull_request.json +134 -134
- data/spec/fixtures/v3/pull_requests.json +185 -185
- data/spec/fixtures/v3/repo_events.json +1644 -1660
- data/spec/fixtures/v3/repo_issues_events.json +127 -133
- data/spec/fixtures/v3/repositories.json +871 -871
- data/spec/fixtures/v3/repository.json +33 -33
- data/spec/fixtures/v3/starred_gists.json +30 -0
- data/spec/fixtures/v3/tags.json +171 -171
- data/spec/fixtures/v3/team.json +6 -6
- data/spec/fixtures/v3/teams.json +10 -10
- data/spec/fixtures/v3/tree.json +110 -110
- data/spec/fixtures/v3/user.json +18 -18
- data/spec/fixtures/v3/user_events.json +99 -100
- data/spec/fixtures/v3/watched.json +1020 -1020
- data/spec/fixtures/v3/watchers.json +180 -180
- data/spec/octokit/client/gists_spec.rb +133 -0
- data/spec/octokit/gist_spec.rb +49 -0
- metadata +40 -26
data/spec/fixtures/v3/label.json
CHANGED
@@ -1,17 +1,17 @@
|
|
1
1
|
[
|
2
|
-
|
3
|
-
|
4
|
-
|
5
|
-
|
6
|
-
|
7
|
-
|
8
|
-
|
9
|
-
|
10
|
-
|
11
|
-
|
12
|
-
|
13
|
-
|
14
|
-
|
15
|
-
|
16
|
-
|
2
|
+
{
|
3
|
+
"color": "02d7e1",
|
4
|
+
"name": "V3 Transition",
|
5
|
+
"url": "https://api.github.com/repos/pengwynn/octokit/labels/V3+Transition"
|
6
|
+
},
|
7
|
+
{
|
8
|
+
"color": "ededed",
|
9
|
+
"name": "V3 Addition",
|
10
|
+
"url": "https://api.github.com/repos/pengwynn/octokit/labels/V3+Addition"
|
11
|
+
},
|
12
|
+
{
|
13
|
+
"color": "e10c02",
|
14
|
+
"name": "Bug",
|
15
|
+
"url": "https://api.github.com/repos/pengwynn/octokit/labels/Bug"
|
16
|
+
}
|
17
17
|
]
|
@@ -1,572 +1,572 @@
|
|
1
1
|
[
|
2
|
-
|
3
|
-
|
4
|
-
|
5
|
-
|
6
|
-
|
7
|
-
|
8
|
-
|
9
|
-
|
10
|
-
|
11
|
-
|
12
|
-
|
13
|
-
|
14
|
-
|
15
|
-
|
16
|
-
|
17
|
-
|
18
|
-
|
19
|
-
|
20
|
-
|
21
|
-
|
22
|
-
|
23
|
-
|
24
|
-
|
25
|
-
|
26
|
-
|
27
|
-
|
28
|
-
|
29
|
-
|
30
|
-
|
31
|
-
|
32
|
-
|
33
|
-
|
34
|
-
|
35
|
-
|
36
|
-
|
37
|
-
|
38
|
-
|
39
|
-
|
40
|
-
|
41
|
-
|
42
|
-
|
43
|
-
|
44
|
-
|
45
|
-
|
46
|
-
|
47
|
-
|
48
|
-
|
49
|
-
|
50
|
-
|
51
|
-
|
52
|
-
|
53
|
-
|
54
|
-
|
55
|
-
|
56
|
-
|
57
|
-
|
58
|
-
|
59
|
-
|
60
|
-
|
61
|
-
|
62
|
-
|
63
|
-
|
64
|
-
|
65
|
-
|
66
|
-
|
67
|
-
|
68
|
-
|
69
|
-
|
70
|
-
|
71
|
-
|
72
|
-
|
73
|
-
|
74
|
-
|
75
|
-
|
76
|
-
|
77
|
-
|
78
|
-
|
79
|
-
|
80
|
-
|
81
|
-
|
82
|
-
|
83
|
-
|
84
|
-
|
85
|
-
|
86
|
-
|
87
|
-
|
88
|
-
|
89
|
-
|
90
|
-
|
91
|
-
|
92
|
-
|
93
|
-
|
94
|
-
|
95
|
-
|
96
|
-
|
97
|
-
|
98
|
-
|
99
|
-
|
100
|
-
|
101
|
-
|
102
|
-
|
103
|
-
|
104
|
-
|
105
|
-
|
106
|
-
|
107
|
-
|
108
|
-
|
109
|
-
|
110
|
-
|
111
|
-
|
112
|
-
|
113
|
-
|
114
|
-
|
115
|
-
|
116
|
-
|
117
|
-
|
118
|
-
|
119
|
-
|
120
|
-
|
121
|
-
|
122
|
-
|
123
|
-
|
124
|
-
|
125
|
-
|
126
|
-
|
127
|
-
|
128
|
-
|
129
|
-
|
130
|
-
|
131
|
-
|
132
|
-
|
133
|
-
|
134
|
-
|
135
|
-
|
136
|
-
|
137
|
-
|
138
|
-
|
139
|
-
|
140
|
-
|
141
|
-
|
142
|
-
|
143
|
-
|
144
|
-
|
145
|
-
|
146
|
-
|
147
|
-
|
148
|
-
|
149
|
-
|
150
|
-
|
151
|
-
|
152
|
-
|
153
|
-
|
154
|
-
|
155
|
-
|
156
|
-
|
157
|
-
|
158
|
-
|
159
|
-
|
160
|
-
|
161
|
-
|
162
|
-
|
163
|
-
|
164
|
-
|
165
|
-
|
166
|
-
|
167
|
-
|
168
|
-
|
169
|
-
|
170
|
-
|
171
|
-
|
172
|
-
|
173
|
-
|
174
|
-
|
175
|
-
|
176
|
-
|
177
|
-
|
178
|
-
|
179
|
-
|
180
|
-
|
181
|
-
|
182
|
-
|
183
|
-
|
184
|
-
|
185
|
-
|
186
|
-
|
187
|
-
|
188
|
-
|
189
|
-
|
190
|
-
|
191
|
-
|
192
|
-
|
193
|
-
|
194
|
-
|
195
|
-
|
196
|
-
|
197
|
-
|
198
|
-
|
199
|
-
|
200
|
-
|
201
|
-
|
202
|
-
|
203
|
-
|
204
|
-
|
205
|
-
|
206
|
-
|
207
|
-
|
208
|
-
|
209
|
-
|
210
|
-
|
211
|
-
|
212
|
-
|
213
|
-
|
214
|
-
|
215
|
-
|
216
|
-
|
217
|
-
|
218
|
-
|
219
|
-
|
220
|
-
|
221
|
-
|
222
|
-
|
223
|
-
|
224
|
-
|
225
|
-
|
226
|
-
|
227
|
-
|
228
|
-
|
229
|
-
|
230
|
-
|
231
|
-
|
232
|
-
|
233
|
-
|
234
|
-
|
235
|
-
|
236
|
-
|
237
|
-
|
238
|
-
|
239
|
-
|
240
|
-
|
241
|
-
|
242
|
-
|
243
|
-
|
244
|
-
|
245
|
-
|
246
|
-
|
247
|
-
|
248
|
-
|
249
|
-
|
250
|
-
|
251
|
-
|
252
|
-
|
253
|
-
|
254
|
-
|
255
|
-
|
256
|
-
|
257
|
-
|
258
|
-
|
259
|
-
|
260
|
-
|
261
|
-
|
262
|
-
|
263
|
-
|
264
|
-
|
265
|
-
|
266
|
-
|
267
|
-
|
268
|
-
|
269
|
-
|
270
|
-
|
271
|
-
|
272
|
-
|
273
|
-
|
274
|
-
|
275
|
-
|
276
|
-
|
277
|
-
|
278
|
-
|
279
|
-
|
280
|
-
|
281
|
-
|
282
|
-
|
283
|
-
|
284
|
-
|
285
|
-
|
286
|
-
|
287
|
-
|
288
|
-
|
289
|
-
|
290
|
-
|
291
|
-
|
292
|
-
|
293
|
-
|
294
|
-
|
295
|
-
|
296
|
-
|
297
|
-
|
298
|
-
|
299
|
-
|
300
|
-
|
301
|
-
|
302
|
-
|
303
|
-
|
304
|
-
|
305
|
-
|
306
|
-
|
307
|
-
|
308
|
-
|
309
|
-
|
310
|
-
|
311
|
-
|
312
|
-
|
313
|
-
|
314
|
-
|
315
|
-
|
316
|
-
|
317
|
-
|
318
|
-
|
319
|
-
|
320
|
-
|
321
|
-
|
322
|
-
|
323
|
-
|
324
|
-
|
325
|
-
|
326
|
-
|
327
|
-
|
328
|
-
|
329
|
-
|
330
|
-
|
331
|
-
|
332
|
-
|
333
|
-
|
334
|
-
|
335
|
-
|
336
|
-
|
337
|
-
|
338
|
-
|
339
|
-
|
340
|
-
|
341
|
-
|
342
|
-
|
343
|
-
|
344
|
-
|
345
|
-
|
346
|
-
|
347
|
-
|
348
|
-
|
349
|
-
|
350
|
-
|
351
|
-
|
352
|
-
|
353
|
-
|
354
|
-
|
355
|
-
|
356
|
-
|
357
|
-
|
358
|
-
|
359
|
-
|
360
|
-
|
361
|
-
|
362
|
-
|
363
|
-
|
364
|
-
|
365
|
-
|
366
|
-
|
367
|
-
|
368
|
-
|
369
|
-
|
370
|
-
|
371
|
-
|
372
|
-
|
373
|
-
|
374
|
-
|
375
|
-
|
376
|
-
|
377
|
-
|
378
|
-
|
379
|
-
|
380
|
-
|
381
|
-
|
382
|
-
|
383
|
-
|
384
|
-
|
385
|
-
|
386
|
-
|
387
|
-
|
388
|
-
|
389
|
-
|
390
|
-
|
391
|
-
|
392
|
-
|
393
|
-
|
394
|
-
|
395
|
-
|
396
|
-
|
397
|
-
|
398
|
-
|
399
|
-
|
400
|
-
|
401
|
-
|
402
|
-
|
403
|
-
|
404
|
-
|
405
|
-
|
406
|
-
|
407
|
-
|
408
|
-
|
409
|
-
|
410
|
-
|
411
|
-
|
412
|
-
|
413
|
-
|
414
|
-
|
415
|
-
|
416
|
-
|
417
|
-
|
418
|
-
|
419
|
-
|
420
|
-
|
421
|
-
|
422
|
-
|
423
|
-
|
424
|
-
|
425
|
-
|
426
|
-
|
427
|
-
|
428
|
-
|
429
|
-
|
430
|
-
|
431
|
-
|
432
|
-
|
433
|
-
|
434
|
-
|
435
|
-
|
436
|
-
|
437
|
-
|
438
|
-
|
439
|
-
|
440
|
-
|
441
|
-
|
442
|
-
|
443
|
-
|
444
|
-
|
445
|
-
|
446
|
-
|
447
|
-
|
448
|
-
|
449
|
-
|
450
|
-
|
451
|
-
|
452
|
-
|
453
|
-
|
454
|
-
|
455
|
-
|
456
|
-
|
457
|
-
|
458
|
-
|
459
|
-
|
460
|
-
|
461
|
-
|
462
|
-
|
463
|
-
|
464
|
-
|
465
|
-
|
466
|
-
|
467
|
-
|
468
|
-
|
469
|
-
|
470
|
-
|
471
|
-
|
472
|
-
|
473
|
-
|
474
|
-
|
475
|
-
|
476
|
-
|
477
|
-
|
478
|
-
|
479
|
-
|
480
|
-
|
481
|
-
|
482
|
-
|
483
|
-
|
484
|
-
|
485
|
-
|
486
|
-
|
487
|
-
|
488
|
-
|
489
|
-
|
490
|
-
|
491
|
-
|
492
|
-
|
493
|
-
|
494
|
-
|
495
|
-
|
496
|
-
|
497
|
-
|
498
|
-
|
499
|
-
|
500
|
-
|
501
|
-
|
502
|
-
|
503
|
-
|
504
|
-
|
505
|
-
|
506
|
-
|
507
|
-
|
508
|
-
|
509
|
-
|
510
|
-
|
511
|
-
|
512
|
-
|
513
|
-
|
514
|
-
|
515
|
-
|
516
|
-
|
517
|
-
|
518
|
-
|
519
|
-
|
520
|
-
|
521
|
-
|
522
|
-
|
523
|
-
|
524
|
-
|
525
|
-
|
526
|
-
|
527
|
-
|
528
|
-
|
529
|
-
|
530
|
-
|
531
|
-
|
532
|
-
|
533
|
-
|
534
|
-
|
535
|
-
|
536
|
-
|
537
|
-
|
538
|
-
|
539
|
-
|
540
|
-
|
541
|
-
|
542
|
-
|
543
|
-
|
544
|
-
|
545
|
-
|
546
|
-
|
547
|
-
|
548
|
-
|
549
|
-
|
550
|
-
|
551
|
-
|
552
|
-
|
553
|
-
|
554
|
-
|
555
|
-
|
556
|
-
|
557
|
-
|
558
|
-
|
559
|
-
|
560
|
-
|
561
|
-
|
562
|
-
|
563
|
-
|
564
|
-
|
565
|
-
|
566
|
-
|
567
|
-
|
568
|
-
|
569
|
-
|
570
|
-
|
571
|
-
|
2
|
+
{
|
3
|
+
"body": "This commit appears to have broken the build: http://ci.railsadmin.org/job/RailsAdmin/478/",
|
4
|
+
"commit_id": "0667424ae17990941624f1dc84dece421fecd595",
|
5
|
+
"created_at": "2011-07-30T18:59:10Z",
|
6
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0667424ae1#commitcomment-504455",
|
7
|
+
"id": 504455,
|
8
|
+
"line": null,
|
9
|
+
"path": null,
|
10
|
+
"position": null,
|
11
|
+
"updated_at": "2011-07-30T18:59:10Z",
|
12
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/504455",
|
13
|
+
"user": {
|
14
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
15
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
16
|
+
"id": 10308,
|
17
|
+
"login": "sferik",
|
18
|
+
"url": "https://api.github.com/users/sferik"
|
19
|
+
}
|
20
|
+
},
|
21
|
+
{
|
22
|
+
"body": "This is a really common mistake, should we add an assertion to test suite that dummy_app really outputs English? I bet it's confusing for many of the users who take RailsAdmin for a test drive using dummy_app when it outputs a foreign language.",
|
23
|
+
"commit_id": "07597b5fed5febe9ae159378b3c3f2dc0637489c",
|
24
|
+
"created_at": "2010-12-22T12:33:46Z",
|
25
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/07597b5fed#commitcomment-224114",
|
26
|
+
"id": 224114,
|
27
|
+
"line": null,
|
28
|
+
"path": "",
|
29
|
+
"position": null,
|
30
|
+
"updated_at": "2010-12-22T12:33:46Z",
|
31
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/224114",
|
32
|
+
"user": {
|
33
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
34
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
35
|
+
"id": 215071,
|
36
|
+
"login": "kaapa",
|
37
|
+
"url": "https://api.github.com/users/kaapa"
|
38
|
+
}
|
39
|
+
},
|
40
|
+
{
|
41
|
+
"body": "Yes, I'd be in favor of adding that test. Thanks for catching this and fixing it.",
|
42
|
+
"commit_id": "07597b5fed5febe9ae159378b3c3f2dc0637489c",
|
43
|
+
"created_at": "2010-12-22T19:51:45Z",
|
44
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/07597b5fed#commitcomment-224469",
|
45
|
+
"id": 224469,
|
46
|
+
"line": null,
|
47
|
+
"path": "",
|
48
|
+
"position": null,
|
49
|
+
"updated_at": "2010-12-22T19:51:45Z",
|
50
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/224469",
|
51
|
+
"user": {
|
52
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
53
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
54
|
+
"id": 10308,
|
55
|
+
"login": "sferik",
|
56
|
+
"url": "https://api.github.com/users/sferik"
|
57
|
+
}
|
58
|
+
},
|
59
|
+
{
|
60
|
+
"body": "Added in ef73d5843b64083b5e9de26fb0bcc722e2484c53.",
|
61
|
+
"commit_id": "07597b5fed5febe9ae159378b3c3f2dc0637489c",
|
62
|
+
"created_at": "2010-12-22T22:14:29Z",
|
63
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/07597b5fed#commitcomment-224582",
|
64
|
+
"id": 224582,
|
65
|
+
"line": null,
|
66
|
+
"path": "",
|
67
|
+
"position": null,
|
68
|
+
"updated_at": "2010-12-22T22:14:29Z",
|
69
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/224582",
|
70
|
+
"user": {
|
71
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
72
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
73
|
+
"id": 215071,
|
74
|
+
"login": "kaapa",
|
75
|
+
"url": "https://api.github.com/users/kaapa"
|
76
|
+
}
|
77
|
+
},
|
78
|
+
{
|
79
|
+
"body": "Nice one @bbenezech! You're on a roll.",
|
80
|
+
"commit_id": "08e296957f04ed07c7ad930ed41e66cb1e3c41ef",
|
81
|
+
"created_at": "2011-09-06T23:29:20Z",
|
82
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/08e296957f#commitcomment-573186",
|
83
|
+
"id": 573186,
|
84
|
+
"line": null,
|
85
|
+
"path": null,
|
86
|
+
"position": null,
|
87
|
+
"updated_at": "2011-09-06T23:29:20Z",
|
88
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/573186",
|
89
|
+
"user": {
|
90
|
+
"avatar_url": "https://secure.gravatar.com/avatar/67c0c5d4a82a8b28405d2fe4f581cc65?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
91
|
+
"gravatar_id": "67c0c5d4a82a8b28405d2fe4f581cc65",
|
92
|
+
"id": 42500,
|
93
|
+
"login": "gunn",
|
94
|
+
"url": "https://api.github.com/users/gunn"
|
95
|
+
}
|
96
|
+
},
|
97
|
+
{
|
98
|
+
"body": "This one needs preview as well... The performance benefit here is big, but is it too risky to make it spec's responsibility to reset the environment once it's been run?",
|
99
|
+
"commit_id": "0f47569290af9fabb3002d0009cd57245e8453de",
|
100
|
+
"created_at": "2010-11-16T18:32:36Z",
|
101
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0f47569290#commitcomment-195206",
|
102
|
+
"id": 195206,
|
103
|
+
"line": null,
|
104
|
+
"path": "",
|
105
|
+
"position": null,
|
106
|
+
"updated_at": "2010-11-16T18:32:48Z",
|
107
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/195206",
|
108
|
+
"user": {
|
109
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
110
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
111
|
+
"id": 215071,
|
112
|
+
"login": "kaapa",
|
113
|
+
"url": "https://api.github.com/users/kaapa"
|
114
|
+
}
|
115
|
+
},
|
116
|
+
{
|
117
|
+
"body": "The risk is that someone might write a spec but forget to call reset, which could have side-effects? Or are there some other risk?\n\nIn my testing, these changes make the specs run 33% faster, which seems like a worthwhile tradeoff.",
|
118
|
+
"commit_id": "0f47569290af9fabb3002d0009cd57245e8453de",
|
119
|
+
"created_at": "2010-11-16T20:15:57Z",
|
120
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0f47569290#commitcomment-195300",
|
121
|
+
"id": 195300,
|
122
|
+
"line": null,
|
123
|
+
"path": "",
|
124
|
+
"position": null,
|
125
|
+
"updated_at": "2010-11-16T22:32:05Z",
|
126
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/195300",
|
127
|
+
"user": {
|
128
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
129
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
130
|
+
"id": 10308,
|
131
|
+
"login": "sferik",
|
132
|
+
"url": "https://api.github.com/users/sferik"
|
133
|
+
}
|
134
|
+
},
|
135
|
+
{
|
136
|
+
"body": "Indeed that's what I meant. It would have been nice to stick to automatic reset after each test, but I wanted to introduce this approach as it is a real time saver in development cycle. Good thing is though that it only affects the tests in the config section of the suite. Also the performance benefit will become even greater as more tests are written to the config section.",
|
137
|
+
"commit_id": "0f47569290af9fabb3002d0009cd57245e8453de",
|
138
|
+
"created_at": "2010-11-16T20:31:26Z",
|
139
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0f47569290#commitcomment-195306",
|
140
|
+
"id": 195306,
|
141
|
+
"line": null,
|
142
|
+
"path": "",
|
143
|
+
"position": null,
|
144
|
+
"updated_at": "2010-11-16T20:31:26Z",
|
145
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/195306",
|
146
|
+
"user": {
|
147
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
148
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
149
|
+
"id": 215071,
|
150
|
+
"login": "kaapa",
|
151
|
+
"url": "https://api.github.com/users/kaapa"
|
152
|
+
}
|
153
|
+
},
|
154
|
+
{
|
155
|
+
"body": "Can't we just split this big file into files dedicated to different features of the admin?\nWhen I develop a new feature I just run the tests that are specific to what I wrote and before pushing to master I run the whole suite.\nAnd the performance improvement is really great so it's worth the risk!",
|
156
|
+
"commit_id": "0f47569290af9fabb3002d0009cd57245e8453de",
|
157
|
+
"created_at": "2010-11-16T20:56:03Z",
|
158
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0f47569290#commitcomment-195333",
|
159
|
+
"id": 195333,
|
160
|
+
"line": null,
|
161
|
+
"path": "",
|
162
|
+
"position": null,
|
163
|
+
"updated_at": "2010-11-16T20:59:22Z",
|
164
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/195333",
|
165
|
+
"user": {
|
166
|
+
"avatar_url": "https://secure.gravatar.com/avatar/dfa3143343f3680753e0ae09de57bcd6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
167
|
+
"gravatar_id": "dfa3143343f3680753e0ae09de57bcd6",
|
168
|
+
"id": 2641,
|
169
|
+
"login": "hurrycane",
|
170
|
+
"url": "https://api.github.com/users/hurrycane"
|
171
|
+
}
|
172
|
+
},
|
173
|
+
{
|
174
|
+
"body": "yeah, splitting the file would be great - you can run just the file that you want during development and then run them all before you check in.\r\n\r\nyou can also tell rspec to run only specific specs, e.g.,\r\n$ rake spec SPEC_OPTS=\"-l 1539\" SPEC=\"spec/requests/rails_admin_spec.rb\"\r\n\r\nFor some unknown reason the \"-l\" flag (line number) works but the \"-e\" flag doesnt, it never matches anthing. Might be me doing it wrong:\r\n$ rake spec SPEC_OPTS=\"-e \\\"has-and-belongs\\\"\" SPEC=\"spec/requests/rails_admin_spec.rb\"\r\n\r\n(in /home/ccabot/rails_admin)\r\n/home/ccabot/.rvm/rubies/ruby-1.8.7-p302/bin/ruby -S bundle exec rspec spec/requests/rails_admin_spec.rb\r\nWARNING: SimpleCov is activated, but you're not running Ruby 1.9 - no coverage analysis will happen\r\nRun filtered using {:full_description=>/(?-mix:\"has-and-belongs\")/}\r\nNo examples were matched. Perhaps {:unless=>#<Proc:0xb73f8538@/home/ccabot/.rvm/gems/ruby-1.8.7-p302/gems/rspec-core-2.1.0/lib/rspec/core/configuration.rb:53>, :if=>#<Proc:0xb73f863c@/home/ccabot/.rvm/gems/ruby-1.8.7-p302/gems/rspec-core-2.1.0/lib/rspec/core/configuration.rb:52>} is excluding everything?\r\n",
|
175
|
+
"commit_id": "0f47569290af9fabb3002d0009cd57245e8453de",
|
176
|
+
"created_at": "2010-11-16T21:27:54Z",
|
177
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0f47569290#commitcomment-195370",
|
178
|
+
"id": 195370,
|
179
|
+
"line": null,
|
180
|
+
"path": "",
|
181
|
+
"position": null,
|
182
|
+
"updated_at": "2010-11-16T21:27:54Z",
|
183
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/195370",
|
184
|
+
"user": {
|
185
|
+
"avatar_url": "https://secure.gravatar.com/avatar/6d246f2dde05095bebd3ba3cb54c676a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
186
|
+
"gravatar_id": "6d246f2dde05095bebd3ba3cb54c676a",
|
187
|
+
"id": 331883,
|
188
|
+
"login": "ccabot",
|
189
|
+
"url": "https://api.github.com/users/ccabot"
|
190
|
+
}
|
191
|
+
},
|
192
|
+
{
|
193
|
+
"body": "+1 on splitting the suite - great idea!",
|
194
|
+
"commit_id": "0f47569290af9fabb3002d0009cd57245e8453de",
|
195
|
+
"created_at": "2010-11-16T22:06:44Z",
|
196
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0f47569290#commitcomment-195402",
|
197
|
+
"id": 195402,
|
198
|
+
"line": null,
|
199
|
+
"path": "",
|
200
|
+
"position": null,
|
201
|
+
"updated_at": "2010-11-16T22:06:44Z",
|
202
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/195402",
|
203
|
+
"user": {
|
204
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
205
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
206
|
+
"id": 215071,
|
207
|
+
"login": "kaapa",
|
208
|
+
"url": "https://api.github.com/users/kaapa"
|
209
|
+
}
|
210
|
+
},
|
211
|
+
{
|
212
|
+
"body": "I nominate Bogdan (hurrycane) to do the splitting, since it was his idea. ;)",
|
213
|
+
"commit_id": "0f47569290af9fabb3002d0009cd57245e8453de",
|
214
|
+
"created_at": "2010-11-16T22:11:24Z",
|
215
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0f47569290#commitcomment-195408",
|
216
|
+
"id": 195408,
|
217
|
+
"line": null,
|
218
|
+
"path": "",
|
219
|
+
"position": null,
|
220
|
+
"updated_at": "2010-11-16T22:11:24Z",
|
221
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/195408",
|
222
|
+
"user": {
|
223
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
224
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
225
|
+
"id": 10308,
|
226
|
+
"login": "sferik",
|
227
|
+
"url": "https://api.github.com/users/sferik"
|
228
|
+
}
|
229
|
+
},
|
230
|
+
{
|
231
|
+
"body": "On it :D",
|
232
|
+
"commit_id": "0f47569290af9fabb3002d0009cd57245e8453de",
|
233
|
+
"created_at": "2010-11-16T22:27:32Z",
|
234
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/0f47569290#commitcomment-195419",
|
235
|
+
"id": 195419,
|
236
|
+
"line": null,
|
237
|
+
"path": "",
|
238
|
+
"position": null,
|
239
|
+
"updated_at": "2010-11-16T22:27:32Z",
|
240
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/195419",
|
241
|
+
"user": {
|
242
|
+
"avatar_url": "https://secure.gravatar.com/avatar/dfa3143343f3680753e0ae09de57bcd6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
243
|
+
"gravatar_id": "dfa3143343f3680753e0ae09de57bcd6",
|
244
|
+
"id": 2641,
|
245
|
+
"login": "hurrycane",
|
246
|
+
"url": "https://api.github.com/users/hurrycane"
|
247
|
+
}
|
248
|
+
},
|
249
|
+
{
|
250
|
+
"body": "See the Markdown section of http://about.travis-ci.org/docs/user/status-images/",
|
251
|
+
"commit_id": "105ab72638b528b2542a22ece9736e2dd2e9dafa",
|
252
|
+
"created_at": "2011-07-31T18:24:18Z",
|
253
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/105ab72638#commitcomment-505142",
|
254
|
+
"id": 505142,
|
255
|
+
"line": null,
|
256
|
+
"path": null,
|
257
|
+
"position": null,
|
258
|
+
"updated_at": "2011-07-31T18:24:18Z",
|
259
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/505142",
|
260
|
+
"user": {
|
261
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
262
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
263
|
+
"id": 10308,
|
264
|
+
"login": "sferik",
|
265
|
+
"url": "https://api.github.com/users/sferik"
|
266
|
+
}
|
267
|
+
},
|
268
|
+
{
|
269
|
+
"body": "Sferik, please review this approach to support CI with multiple db backends.\r\n\r\nThe idea here is that the test suite has minimal relation to needs of the CI. With a setup like this Hudson can invoke a build with each ruby version / database backend with a command like this (when setup with a multi-axis build configuration):\r\n bash -l -c \"rvm use $CI_RUBY_VERSION && export CI_DB_ADAPTER=$CI_DB_ADAPTER && cd spec/dummy_app && bundle install && rake admin:prepare_ci_env && cd ../../ && bundle exec rake\"\r\n\r\nThere probably would be a better location for prepare_ci_env rake task somewhere within the engine itself, but that was beyond the scope of this first iteration.",
|
270
|
+
"commit_id": "107a4d2231a213eb46763d48f8feab4ec8a7c7ee",
|
271
|
+
"created_at": "2010-12-21T21:16:37Z",
|
272
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/107a4d2231#commitcomment-223633",
|
273
|
+
"id": 223633,
|
274
|
+
"line": null,
|
275
|
+
"path": "",
|
276
|
+
"position": null,
|
277
|
+
"updated_at": "2010-12-21T21:16:37Z",
|
278
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/223633",
|
279
|
+
"user": {
|
280
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
281
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
282
|
+
"id": 215071,
|
283
|
+
"login": "kaapa",
|
284
|
+
"url": "https://api.github.com/users/kaapa"
|
285
|
+
}
|
286
|
+
},
|
287
|
+
{
|
288
|
+
"body": "Also, I picked the db driver versions for the Gemfile from rubygems.org and only tested that it works on sqlite3.",
|
289
|
+
"commit_id": "107a4d2231a213eb46763d48f8feab4ec8a7c7ee",
|
290
|
+
"created_at": "2010-12-21T21:19:27Z",
|
291
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/107a4d2231#commitcomment-223639",
|
292
|
+
"id": 223639,
|
293
|
+
"line": null,
|
294
|
+
"path": "",
|
295
|
+
"position": null,
|
296
|
+
"updated_at": "2010-12-21T21:19:27Z",
|
297
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/223639",
|
298
|
+
"user": {
|
299
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
300
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
301
|
+
"id": 215071,
|
302
|
+
"login": "kaapa",
|
303
|
+
"url": "https://api.github.com/users/kaapa"
|
304
|
+
}
|
305
|
+
},
|
306
|
+
{
|
307
|
+
"body": "This looks good to me! I can't wait to see this up and running with multiple backends.",
|
308
|
+
"commit_id": "107a4d2231a213eb46763d48f8feab4ec8a7c7ee",
|
309
|
+
"created_at": "2010-12-21T22:14:58Z",
|
310
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/107a4d2231#commitcomment-223714",
|
311
|
+
"id": 223714,
|
312
|
+
"line": null,
|
313
|
+
"path": "",
|
314
|
+
"position": null,
|
315
|
+
"updated_at": "2010-12-21T22:16:29Z",
|
316
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/223714",
|
317
|
+
"user": {
|
318
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
319
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
320
|
+
"id": 10308,
|
321
|
+
"login": "sferik",
|
322
|
+
"url": "https://api.github.com/users/sferik"
|
323
|
+
}
|
324
|
+
},
|
325
|
+
{
|
326
|
+
"body": "[About disabling registerable](https://github.com/plataformatec/devise/wiki/How-To:-Manage-users-through-a-CRUD-interface). Perhaps we now need to either document initial user creation or write it to the generator?",
|
327
|
+
"commit_id": "11440180fb09b3136840f277cf80bab05a7eb8ec",
|
328
|
+
"created_at": "2010-11-13T13:27:00Z",
|
329
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/11440180fb#commitcomment-193186",
|
330
|
+
"id": 193186,
|
331
|
+
"line": null,
|
332
|
+
"path": "",
|
333
|
+
"position": null,
|
334
|
+
"updated_at": "2010-11-13T13:27:00Z",
|
335
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/193186",
|
336
|
+
"user": {
|
337
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
338
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
339
|
+
"id": 215071,
|
340
|
+
"login": "kaapa",
|
341
|
+
"url": "https://api.github.com/users/kaapa"
|
342
|
+
}
|
343
|
+
},
|
344
|
+
{
|
345
|
+
"body": "Removing :registerable makes it harder for new users to try out RailsAdmin by running the dummy app. I think I understand the rationale behind removing it in production apps, but I don't think this applies to the dummy app.\n\nAs an aside, I wish this was done in two separate commits, so I could revert just that change. As a general rule, if you find yourself using the word \"and\" in a commit message, you should consider splitting it up.",
|
346
|
+
"commit_id": "11440180fb09b3136840f277cf80bab05a7eb8ec",
|
347
|
+
"created_at": "2010-12-21T22:03:43Z",
|
348
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/11440180fb#commitcomment-223703",
|
349
|
+
"id": 223703,
|
350
|
+
"line": null,
|
351
|
+
"path": "",
|
352
|
+
"position": null,
|
353
|
+
"updated_at": "2010-12-21T22:24:20Z",
|
354
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/223703",
|
355
|
+
"user": {
|
356
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
357
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
358
|
+
"id": 10308,
|
359
|
+
"login": "sferik",
|
360
|
+
"url": "https://api.github.com/users/sferik"
|
361
|
+
}
|
362
|
+
},
|
363
|
+
{
|
364
|
+
"body": "True, didn't realize that point at the time. Good note about the commits also, there's definitely room for improvement for me there.",
|
365
|
+
"commit_id": "11440180fb09b3136840f277cf80bab05a7eb8ec",
|
366
|
+
"created_at": "2010-12-21T22:19:29Z",
|
367
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/11440180fb#commitcomment-223719",
|
368
|
+
"id": 223719,
|
369
|
+
"line": null,
|
370
|
+
"path": "",
|
371
|
+
"position": null,
|
372
|
+
"updated_at": "2010-12-21T22:19:29Z",
|
373
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/223719",
|
374
|
+
"user": {
|
375
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
376
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
377
|
+
"id": 215071,
|
378
|
+
"login": "kaapa",
|
379
|
+
"url": "https://api.github.com/users/kaapa"
|
380
|
+
}
|
381
|
+
},
|
382
|
+
{
|
383
|
+
"body": "No big deal. I'll manually revert the change.",
|
384
|
+
"commit_id": "11440180fb09b3136840f277cf80bab05a7eb8ec",
|
385
|
+
"created_at": "2010-12-21T22:24:37Z",
|
386
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/11440180fb#commitcomment-223730",
|
387
|
+
"id": 223730,
|
388
|
+
"line": null,
|
389
|
+
"path": "",
|
390
|
+
"position": null,
|
391
|
+
"updated_at": "2010-12-21T22:24:37Z",
|
392
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/223730",
|
393
|
+
"user": {
|
394
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
395
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
396
|
+
"id": 10308,
|
397
|
+
"login": "sferik",
|
398
|
+
"url": "https://api.github.com/users/sferik"
|
399
|
+
}
|
400
|
+
},
|
401
|
+
{
|
402
|
+
"body": "I like Aristo too, but can you elaborate why to diverge from the Activo theme?",
|
403
|
+
"commit_id": "12aa156d0bba244a1584f32f9f7a3862c8307ef7",
|
404
|
+
"created_at": "2011-07-27T21:38:09Z",
|
405
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/12aa156d0b#commitcomment-499913",
|
406
|
+
"id": 499913,
|
407
|
+
"line": null,
|
408
|
+
"path": null,
|
409
|
+
"position": null,
|
410
|
+
"updated_at": "2011-07-27T21:38:09Z",
|
411
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/499913",
|
412
|
+
"user": {
|
413
|
+
"avatar_url": "https://secure.gravatar.com/avatar/40a0afa49eb7b12db4dcda70b2e1520d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
414
|
+
"gravatar_id": "40a0afa49eb7b12db4dcda70b2e1520d",
|
415
|
+
"id": 215071,
|
416
|
+
"login": "kaapa",
|
417
|
+
"url": "https://api.github.com/users/kaapa"
|
418
|
+
}
|
419
|
+
},
|
420
|
+
{
|
421
|
+
"body": "Activo uses some default ugly jquery-ui theme, I just changed it to aristo. It's totally independent from Activo's styling.\r\nAn idea would be to make it configurable. (jquery-ui themes can be served by google CDN, and we can serve activo locally).",
|
422
|
+
"commit_id": "12aa156d0bba244a1584f32f9f7a3862c8307ef7",
|
423
|
+
"created_at": "2011-07-28T07:43:28Z",
|
424
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/12aa156d0b#commitcomment-500561",
|
425
|
+
"id": 500561,
|
426
|
+
"line": null,
|
427
|
+
"path": null,
|
428
|
+
"position": null,
|
429
|
+
"updated_at": "2011-07-28T07:43:28Z",
|
430
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/500561",
|
431
|
+
"user": {
|
432
|
+
"avatar_url": "https://secure.gravatar.com/avatar/c1607873b99845b2cd53f8634860d4d4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
433
|
+
"gravatar_id": "c1607873b99845b2cd53f8634860d4d4",
|
434
|
+
"id": 26794,
|
435
|
+
"login": "bbenezech",
|
436
|
+
"url": "https://api.github.com/users/bbenezech"
|
437
|
+
}
|
438
|
+
},
|
439
|
+
{
|
440
|
+
"body": "hi @bbenezech \r\n\r\ncan you please jump in #travis when you have a chance\r\n\r\nthanks",
|
441
|
+
"commit_id": "18fe8c2c9ff11c93b4c29d76de0e4dece3a16614",
|
442
|
+
"created_at": "2011-08-25T15:20:57Z",
|
443
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/18fe8c2c9f#commitcomment-551697",
|
444
|
+
"id": 551697,
|
445
|
+
"line": null,
|
446
|
+
"path": null,
|
447
|
+
"position": null,
|
448
|
+
"updated_at": "2011-08-25T15:20:57Z",
|
449
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/551697",
|
450
|
+
"user": {
|
451
|
+
"avatar_url": "https://secure.gravatar.com/avatar/21b21efe14359ec323f9a70464b91e39?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
452
|
+
"gravatar_id": "21b21efe14359ec323f9a70464b91e39",
|
453
|
+
"id": 8701,
|
454
|
+
"login": "joshk",
|
455
|
+
"url": "https://api.github.com/users/joshk"
|
456
|
+
}
|
457
|
+
},
|
458
|
+
{
|
459
|
+
"body": "This causes tests to break in Ruby versions < 1.8: http://travis-ci.org/#!/sferik/rails_admin/builds/104957",
|
460
|
+
"commit_id": "18fe8c2c9ff11c93b4c29d76de0e4dece3a16614",
|
461
|
+
"created_at": "2011-08-27T19:52:10Z",
|
462
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/18fe8c2c9f#commitcomment-555420",
|
463
|
+
"id": 555420,
|
464
|
+
"line": null,
|
465
|
+
"path": null,
|
466
|
+
"position": null,
|
467
|
+
"updated_at": "2011-08-27T19:52:10Z",
|
468
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/555420",
|
469
|
+
"user": {
|
470
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
471
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
472
|
+
"id": 10308,
|
473
|
+
"login": "sferik",
|
474
|
+
"url": "https://api.github.com/users/sferik"
|
475
|
+
}
|
476
|
+
},
|
477
|
+
{
|
478
|
+
"body": "This commit appears to be causing tests to fail: http://ci.railsadmin.org/job/RailsAdmin/437/\r\n\r\n@bbenezech Since you merged it, can you please make sure it either gets fixed or reverted?",
|
479
|
+
"commit_id": "1cf63f4b596df69db57a0db65337dba308b9358f",
|
480
|
+
"created_at": "2011-07-21T07:11:07Z",
|
481
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/1cf63f4b59#commitcomment-488557",
|
482
|
+
"id": 488557,
|
483
|
+
"line": null,
|
484
|
+
"path": null,
|
485
|
+
"position": null,
|
486
|
+
"updated_at": "2011-07-21T07:11:07Z",
|
487
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/488557",
|
488
|
+
"user": {
|
489
|
+
"avatar_url": "https://secure.gravatar.com/avatar/1f74b13f1e5c6c69cb5d7fbaabb1e2cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
490
|
+
"gravatar_id": "1f74b13f1e5c6c69cb5d7fbaabb1e2cb",
|
491
|
+
"id": 10308,
|
492
|
+
"login": "sferik",
|
493
|
+
"url": "https://api.github.com/users/sferik"
|
494
|
+
}
|
495
|
+
},
|
496
|
+
{
|
497
|
+
"body": "I've always declared attributes as a hash. Is this new functionality in haml?",
|
498
|
+
"commit_id": "2282a77bac957849c3aec745d17df50b63f5bd0c",
|
499
|
+
"created_at": "2011-07-27T14:33:24Z",
|
500
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/2282a77bac#commitcomment-499003",
|
501
|
+
"id": 499003,
|
502
|
+
"line": 147,
|
503
|
+
"path": "app/views/rails_admin/main/list.html.haml",
|
504
|
+
"position": 5,
|
505
|
+
"updated_at": "2011-07-27T14:33:24Z",
|
506
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/499003",
|
507
|
+
"user": {
|
508
|
+
"avatar_url": "https://secure.gravatar.com/avatar/7b8632be88e93b4764bbab50c2515182?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
509
|
+
"gravatar_id": "7b8632be88e93b4764bbab50c2515182",
|
510
|
+
"id": 47560,
|
511
|
+
"login": "jbrown",
|
512
|
+
"url": "https://api.github.com/users/jbrown"
|
513
|
+
}
|
514
|
+
},
|
515
|
+
{
|
516
|
+
"body": "This change is actually breaking custom devise routing.\n\nI have a specific overload for the session controller in my app, which does not live in 'devise/sessions'\n\nI will fork, fix and submit a pull request\n\nNinja",
|
517
|
+
"commit_id": "22a7e9b2dc829909d641264bd91fb96252b5fa82",
|
518
|
+
"created_at": "2011-09-13T06:36:46Z",
|
519
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/22a7e9b2dc#commitcomment-585211",
|
520
|
+
"id": 585211,
|
521
|
+
"line": 13,
|
522
|
+
"path": "app/views/layouts/rails_admin/_header.html.haml",
|
523
|
+
"position": 17,
|
524
|
+
"updated_at": "2011-09-13T06:36:46Z",
|
525
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/585211",
|
526
|
+
"user": {
|
527
|
+
"avatar_url": "https://secure.gravatar.com/avatar/84e83f58b9a0e02926ffb700dbf3d88f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
528
|
+
"gravatar_id": "84e83f58b9a0e02926ffb700dbf3d88f",
|
529
|
+
"id": 117323,
|
530
|
+
"login": "davetheninja",
|
531
|
+
"url": "https://api.github.com/users/davetheninja"
|
532
|
+
}
|
533
|
+
},
|
534
|
+
{
|
535
|
+
"body": "This change breaks some configurations. \n\nWhen I updated to this commit my ckeditor configuration throws the error:\n\n undefined method `sort_by!' for #<Array:0x1054d0d68>\n\nWhen I go back to the commit before this my ckeditor configuration works fine. My configuration currently looks like:\n\n config.model BlogPost do\n edit do\n field :title\n field :body, :text do\n ckeditor true\n end\n field :blog_id\n field :user_id\n end\n end",
|
536
|
+
"commit_id": "241a3bfb2f6f56021f94a74c16c657225f15afc2",
|
537
|
+
"created_at": "2011-07-01T01:44:41Z",
|
538
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/241a3bfb2f#commitcomment-456491",
|
539
|
+
"id": 456491,
|
540
|
+
"line": 27,
|
541
|
+
"path": "lib/rails_admin/config/has_fields.rb",
|
542
|
+
"position": 12,
|
543
|
+
"updated_at": "2011-07-01T01:44:41Z",
|
544
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/456491",
|
545
|
+
"user": {
|
546
|
+
"avatar_url": "https://secure.gravatar.com/avatar/3917b9c81197f1cd96f4546930b39d54?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
547
|
+
"gravatar_id": "3917b9c81197f1cd96f4546930b39d54",
|
548
|
+
"id": 25104,
|
549
|
+
"login": "jdutil",
|
550
|
+
"url": "https://api.github.com/users/jdutil"
|
551
|
+
}
|
552
|
+
},
|
553
|
+
{
|
554
|
+
"body": "Fix in this pull request https://github.com/sferik/rails_admin/pull/507",
|
555
|
+
"commit_id": "241a3bfb2f6f56021f94a74c16c657225f15afc2",
|
556
|
+
"created_at": "2011-07-01T01:57:22Z",
|
557
|
+
"html_url": "https://github.com/sferik/rails_admin/commit/241a3bfb2f#commitcomment-456497",
|
558
|
+
"id": 456497,
|
559
|
+
"line": 27,
|
560
|
+
"path": "lib/rails_admin/config/has_fields.rb",
|
561
|
+
"position": 12,
|
562
|
+
"updated_at": "2011-07-01T01:57:22Z",
|
563
|
+
"url": "https://api.github.com/repos/sferik/rails_admin/comments/456497",
|
564
|
+
"user": {
|
565
|
+
"avatar_url": "https://secure.gravatar.com/avatar/3917b9c81197f1cd96f4546930b39d54?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
|
566
|
+
"gravatar_id": "3917b9c81197f1cd96f4546930b39d54",
|
567
|
+
"id": 25104,
|
568
|
+
"login": "jdutil",
|
569
|
+
"url": "https://api.github.com/users/jdutil"
|
570
|
+
}
|
571
|
+
}
|
572
572
|
]
|