occams-record 1.8.0 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 846af974c8bc267fe8e901995d0aa3341b018d135eeb267c11d9add447cd0155
-  data.tar.gz: 763f8a038908cb9a990bcf305644661736dd9133e51a9d8fb8ece2b8ff018fd2
+  metadata.gz: 2778b16aee6b725c967c4877b9905eed75b37b64bf8c5fca7077918ea2a4a53a
+  data.tar.gz: b8948ddd57573efcbeb90e96235626e482cc557e9b92d4e5fdf0237c182e39df
 SHA512:
-  metadata.gz: 24e1c5dfb09cb35b2b7116cb40aafcb1eb215ac96e3c8bab7ff6558598b31e8abb77b49c2b711392567862b182e1aed705888e939f8b66f15285f2ca352dbc89
-  data.tar.gz: 04f78d14765b6ae4d9ccee5f01633132ed1e39662071dfc39f6e33583e9cd3e6214841225eb35ce2f678472ce34bf45e27e23660114f28cede6a27cdb38613b0
+  metadata.gz: e436f30e97f0a256d146539902b3f6fe9b54c241d7b49a51da63242f59505793c14f6ceef601343660750d0030ddf21c196e40a4aec41b1b5f1490b71b255ca6
+  data.tar.gz: 14095b912856efe2a097471046e518c0d3040320e72198ae28cf8b76c84040ca3319f16916ef2c70c357d8661e6465a36d7b80c49109896c828a2cc36dd777ee

data/README.md

@@ -1,4 +1,4 @@
-# Occams Record [![Build Status](https://travis-ci.org/jhollinger/occams-record.svg?branch=master)](https://travis-ci.org/jhollinger/occams-record)
+# Occams Record
 
 > Do not multiply entities beyond necessity. -- Occam's Razor
 
@@ -298,32 +298,40 @@ On the other hand, Active Record makes it *very* easy to forget to eager load as
 
 # Testing
 
-```bash
-bundle install
-
-# test against SQLite
-bundle exec rake test
-
-# test against Postgres
-TEST_DATABASE_URL=postgresql://postgres@localhost:5432/occams_record bundle exec rake test
-
-# test against MySQL
-TEST_DATABASE_URL=mysql2://root:@127.0.0.1:3306/occams_record bundle exec rake test
-```
-
-**Test against all supported ActiveRecord versions**
+Tests are run with `appraisal` in Docker Compose using the `bin/test` or `bin/testall` scripts.
 
 ```bash
-bundle exec appraisal install
-
-# test against all supported AR versions (defaults to SQLite)
-bundle exec appraisal rake test
-
-# test against a specific AR version
-bundle exec appraisal ar-7.0 rake test
-
-# test against Postgres
-TEST_DATABASE_URL=postgresql://postgres@localhost:5432/occams_record bundle exec appraisal rake test
+# Run tests against all supported ActiveRecord versions, Ruby versions, and databases
+bin/testall
+
+# Run tests for Ruby vX only
+bin/testall ruby-3.1
+
+# Run tests for ActiveRecord vX only
+bin/testall ar-6.1
+
+# Run tests against a specific database
+bin/testall sqlite|postgres-14|mysql-8
+
+# Run exactly one set of tests
+bin/test ruby-3.1 ar-7.0 postgres-14
+
+# If all tests complete successfully, you'll be rewarded by an ASCII Nyancat!
+
++      o     +              o
+    +             o     +       +
+o          +
+    o  +           +        +
++        o     o       +        o
+-_-_-_-_-_-_-_,------,      o
+_-_-_-_-_-_-_-|   /\_/\
+-_-_-_-_-_-_-~|__( ^ .^)  +     +
+_-_-_-_-_-_-_-""  ""
+    +      o         o   +       o
+    +         +
+o        o         o      o     +
+    o           +
++      +     o        o      +
 ```
 
 # License

data/lib/occams-record/pluck.rb

@@ -12,45 +12,24 @@ module OccamsRecord
 
     # returns an array of values
     def pluck_results_single(results, col, model: nil)
-      enum = model&.defined_enums&.[](col)
-      inv_enum = enum&.invert
-      if enum
-        results.map { |r|
-          val = r[col]
-          enum.has_key?(val) ? val : inv_enum[val]
-        }
-      else
-        # micro-optimization for when there are no enums
-        results.map { |r| r[col] }
-      end
+      casters = TypeCaster.generate(results.columns, results.column_types, model: model)
+      col = results.columns[0]
+      caster = casters[col]
+      results.map { |row|
+        val = row[col]
+        caster ? caster.(val) : val
+      }
     end
 
     # returns an array of arrays
     def pluck_results_multi(results, cols, model: nil)
-      any_enums = false
-      cols_with_enums = cols.map { |col|
-        enum = model&.defined_enums&.[](col)
-        any_enums ||= !!enum
-        [col, enum, enum&.invert]
-      }
-
-      if any_enums
-        results.map { |row|
-          cols_with_enums.map { |(col, enum, inv_enum)|
-            if enum
-              val = row[col]
-              enum.has_key?(val) ? val : inv_enum[val]
-            else
-              row[col]
-            end
-          }
-        }
-      else
-        # micro-optimization for when there are no enums
-        results.map { |row|
-          cols.map { |col| row[col] }
+      casters = TypeCaster.generate(results.columns, results.column_types, model: model)
+      results.map { |row|
+        row.map { |col, val|
+          caster = casters[col]
+          caster ? caster.(val) : val
         }
-      end
+      }
     end
   end
 end

data/lib/occams-record/results/results.rb

@@ -1,13 +1,6 @@
 module OccamsRecord
   # Classes and methods for handing query results.
   module Results
-    # ActiveRecord's internal type casting API changes from version to version.
-    CASTER = case ActiveRecord::VERSION::MAJOR
-             when 4 then :type_cast_from_database
-             when 5, 6, 7 then :deserialize
-             else raise "OccamsRecord::Results::CASTER does yet support this version of ActiveRecord"
-             end
-
     #
     # Dynamically build a class for a specific set of result rows. It inherits from OccamsRecord::Results::Row, and optionall prepends
     # user-defined modules.
@@ -43,53 +36,22 @@ module OccamsRecord
         attr_accessor(*association_names)
 
         # Build a getter for each attribute returned by the query. The values will be type converted on demand.
-        model_column_types = model ? model.attributes_builder.types : nil
+        casters = TypeCaster.generate(column_names, column_types, model: model)
         self.columns.each_with_index do |col, idx|
-          #
-          # NOTE there's lots of variation between DB adapters and AR versions here. Some notes:
-          # * Postgres AR < 6.1 `column_types` will contain entries for every column.
-          # * Postgres AR >= 6.1 `column_types` only contains entries for "exotic" types. Columns with "common" types have already been converted by the PG adapter.
-          # * SQLite `column_types` will always be empty. Some types will have already been convered by the SQLite adapter, but others will depend on
-          #   `model_column_types` for converstion. See test/raw_query_test.rb#test_common_types for examples.
-          # * MySQL ?
-          #
-          type = column_types[col] || model_column_types&.[](col)
-
-          #
-          # NOTE is also some variation in when enum values are mapped in different AR versions.
-          # In >=5.0, <=7.0, ActiveRecord::Result objects contain the human-readable values. In 4.2 and
-          # pre-release versions of 7.1, they instead have the RAW values (e.g. integers) which we must map ourselves.
-          #
-          enum = model&.defined_enums&.[](col)
-          inv_enum = enum&.invert
+          caster = casters[col]
 
-          case type&.type
-          when nil
-            if enum
-              define_method(col) {
-                val = @raw_values[idx]
-                enum.has_key?(val) ? val : inv_enum[val]
-              }
-            else
-              define_method(col) { @raw_values[idx] }
-            end
-          when :datetime
-            define_method(col) { @cast_values[idx] ||= type.send(CASTER, @raw_values[idx])&.in_time_zone }
-          when :boolean
-            define_method(col) { @cast_values[idx] ||= type.send(CASTER, @raw_values[idx]) }
-            define_method("#{col}?") { !!send(col) }
+          if caster
+            define_method(col) {
+              @cast_values[idx] = caster.(@raw_values[idx]) if @cast_values[idx].nil?
+              @cast_values[idx]
+            }
           else
-            if enum
-              define_method(col) {
-                @cast_values[idx] ||= (
-                  val = type.send(CASTER, @raw_values[idx])
-                  enum.has_key?(val) ? val : inv_enum[val]
-                )
-              }
-            else
-              define_method(col) { @cast_values[idx] ||= type.send(CASTER, @raw_values[idx]) }
-            end
+            define_method(col) {
+              @raw_values[idx]
+            }
           end
+
+          define_method("#{col}?") { !!send(col) }
         end
       end
     end

data/lib/occams-record/type_caster.rb

@@ -0,0 +1,60 @@
+module OccamsRecord
+  # @private
+  module TypeCaster
+    CASTER =
+      case ActiveRecord::VERSION::MAJOR
+      when 4 then :type_cast_from_database
+      when 5, 6, 7 then :deserialize
+      else raise "OccamsRecord::TypeCaster::CASTER does yet support this version of ActiveRecord"
+      end
+
+    #
+    # @param column_names [Array<String>] the column names in the result set. The order MUST match the order returned by the query.
+    # @param column_types [Hash] Column name => type from an ActiveRecord::Result
+    # @param model [ActiveRecord::Base] the AR model representing the table (it holds column & type info).
+    # @return [Hash<Proc>] a Hash of casting Proc's keyed by column
+    #
+    def self.generate(column_names, column_types, model: nil)
+      column_names.each_with_object({}) { |col, memo|
+        #
+        # NOTE there's lots of variation between DB adapters and AR versions here. Some notes:
+        # * Postgres AR < 6.1 `column_types` will contain entries for every column.
+        # * Postgres AR >= 6.1 `column_types` only contains entries for "exotic" types. Columns with "common" types have already been converted by the PG adapter.
+        # * SQLite `column_types` will always be empty. Some types will have already been convered by the SQLite adapter, but others will depend on
+        #   `model_column_types` for converstion. See test/raw_query_test.rb#test_common_types for examples.
+        # * MySQL ?
+        #
+        type = column_types[col] || model&.attributes_builder&.types&.[](col)
+
+        #
+        # NOTE is also some variation in when enum values are mapped in different AR versions.
+        # In >=5.0, <=7.0, ActiveRecord::Result objects *usually* contain the human-readable values. In 4.2 and
+        # pre-release versions of 7.1, they instead have the RAW values (e.g. integers) which we must map ourselves.
+        #
+        enum = model&.defined_enums&.[](col)
+        inv_enum = enum&.invert
+
+        memo[col] =
+          case type&.type
+          when nil
+            if enum
+              ->(val) { enum.has_key?(val) ? val : inv_enum[val] }
+            end
+          when :datetime
+            ->(val) { type.send(CASTER, val)&.in_time_zone }
+          when :boolean
+            ->(val) { type.send(CASTER, val) }
+          else
+            if enum
+              ->(val) {
+                val = type.send(CASTER, val)
+                enum.has_key?(val) ? val : inv_enum[val]
+              }
+            else
+              ->(val) { type.send(CASTER, val) }
+            end
+          end
+      }
+    end
+  end
+end

data/lib/occams-record/version.rb

@@ -3,5 +3,5 @@
 #
 module OccamsRecord
   # @private
-  VERSION = "1.8.0".freeze
+  VERSION = "1.8.1".freeze
 end

data/lib/occams-record.rb

@@ -3,6 +3,7 @@ require 'occams-record/version'
 require 'occams-record/merge'
 require 'occams-record/measureable'
 require 'occams-record/eager_loaders/eager_loaders'
+require 'occams-record/type_caster'
 require 'occams-record/results/results'
 require 'occams-record/results/row'
 require 'occams-record/pluck'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: occams-record
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.1
 platform: ruby
 authors:
 - Jordan Hollinger
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-01 00:00:00.000000000 Z
+date: 2023-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -30,20 +30,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '7.1'
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: A faster, lower-memory, fuller-featured querying API for ActiveRecord
   that returns results as unadorned, read-only objects.
 email: jordan.hollinger@gmail.com
@@ -79,6 +65,7 @@ files:
 - lib/occams-record/raw_query.rb
 - lib/occams-record/results/results.rb
 - lib/occams-record/results/row.rb
+- lib/occams-record/type_caster.rb
 - lib/occams-record/ugly.rb
 - lib/occams-record/version.rb
 homepage: https://jhollinger.github.io/occams-record/