observers 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '03108108c365bb1857d0ff575823ba87a1c530e0c83014534e8f6d696ea0a3dd'
-  data.tar.gz: be85d6ddfe681c52ea79b3f09dc1538c1da6c494fbf8667cc2a98237f3e1c12e
+  metadata.gz: fbb9116b5b3a86d777d4aca13b5c4c04214340596e1df83adebada4dd871bc43
+  data.tar.gz: 560fbbb9480ac2968036b8024e9362c12ea68994c77a587abc2432505ceeda7f
 SHA512:
-  metadata.gz: d3845675c5749e181bea80f4082ab86df3072258867847562a214e872f02bc668688dc41e02e95e5ab91c3c2bd5649986cc850c108141b06f8c40054fd97b010
-  data.tar.gz: 94ca9aaedd1c66bc410115e4bd9426a38dd497eaa8563d68488a4fb4b917d9e7150f31e64735fdffd058bb669570bcf81bb9c91e70904882cc902933b2fafb89
+  metadata.gz: 403fe656fda85237d897b4e82b84e9b770f352807ac5ef05a37f4c1d58784af7f43e5f22d6ab5999bdebeea831350757125f184870de45ad78330efc6fe07ace
+  data.tar.gz: '06680f408eaf15377c441fd995a7a3b05b3a41bcf6b8e3e3aa87dd06a6e65227f43a50b01c03193845d26d306e368b2ecfaec814af0cb8f4ba9a34386641af83'

data/lib/models/key.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 module Observers
+  class NoObserversError < StandardError; end
+
   class Key
     attr_reader :observers
 
@@ -10,21 +12,19 @@ module Observers
     end
 
     def observe(object:, action:)
-      # TODO: We can observe objects directly, no need to wrap in an observer... no need to let the object's observer override the action?
+      # TODO: We can observe objects directly, no need to wrap in an observer, unless need to let the object's observer override the action?
       # A future reason I can think of for keeping observer wrapper is to track whether the object has implemented certain actions/methods.
       @observers << Observer.new(object:, action:)
     end
 
     # @returns: The result of the last observer with a non-nil value.
     def trigger(action: nil, event: nil)
-      empty_observers_callback
-
-      action = event.action if event && action.nil?
-      action = :handle if action.nil?
+      # TODO: Breaks some tests... should it? Yes. Should it be disabled when testing? Yes.
+      # raise NoObserversError, "No observers configured for #{@key}" if @observers.empty?
 
       last_result = nil
 
-      @observers.each do |observer|
+      per_observer_per_action(action:, event:) do |observer, action|
         result = observer.trigger(action:, event:)
         last_result = result unless result.nil?
         yield if block_given?
@@ -33,26 +33,41 @@ module Observers
       last_result
     end
 
-    # @returns: The result of the first observer with a non-nil value.
+    # @returns: The result of the first observer and the first action with a non-nil value.
     def take(action: nil, event: nil)
-      empty_observers_callback
-
-      action = event.action if event && action.nil?
-      action = :handle if action.nil?
+      # TODO: Breaks some tests... should it? Yes. Should it be disabled when testing? Yes.
+      # raise NoObserversError, "No observers configured for #{@key}" if @observers.empty?
 
-      @observers.each do |observer|
+      per_observer_per_action(action:, event:) do |observer, action|
         result = observer.trigger(action:, event:)
         yield if block_given?
         return result unless result.nil?
       end
 
-      nil # This is a bad day for the take method, one of the worst.
+      # None of the observers returned a non-nil value.
+      nil
     end
 
     private
 
-    def empty_observers_callback
-      Observers.config.empty_observers_callback.call(@key) if Observers.config.empty_observers_callback && @observers.empty?
+    def per_observer_per_action(action:, event:)
+      action ||= event&.action
+
+      if action
+        @observers.each do |observer|
+          yield observer, action
+        end
+      elsif event&.actions
+        @observers.each do |observer|
+          event.actions.each do |action|
+            yield observer, action
+          end
+        end
+      else
+        @observers.each do |observer|
+          yield observer, :handle
+        end
+      end
     end
   end
 end

data/lib/models/observer.rb

@@ -12,6 +12,8 @@ module Observers
     def trigger(action:, event:)
       action = @action if @action
 
+      return unless @object.respond_to?(action)
+
       # Assumption that if method has params then that param is "event:".
       if event && @object.method(action).parameters.count > 0
         @object.send(action, **{ event: })
@@ -24,8 +26,8 @@ module Observers
 
       raise ArgumentError, "#{type}##{action} has an 'event:' keyword argument but no event arg was sent" if event.nil?
 
-      # Events trigger events, so the error bubbles up to becomes the error message for the next rescue's error message:
-      # "RequestEvent sent to Rain::Router#handle -> StatusEvent sent to Error404Node.render -> unknown keyword: :props"
+      # Events trigger events, so the error bubbles up to become the error message for the next rescue's error message:
+      # "RequestEvent sent to Rain::Router#route_request -> StatusEvent sent to Error404Node.render -> unknown keyword: :props"
       raise ArgumentError, "#{event.class} sent to #{type}#{method_type}#{action} -> #{e.message}"
     end
   end

data/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Observers
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: observers
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - maedi
@@ -40,7 +40,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Observe objects of any kind
 test_files: []